[Differential] [Request, 19 lines] D2866: add flag to for per-display scaling
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a KScreen::Config::Feature for per-display scaling. As we plan to introduce this with Wayland, we need to be able to check in the UI whether this feature is supported. This will be implemented by the backends at a later stage, but can now already be used to work on UI changes. A relatively simple change that I'd already like to get merged. TEST PLAN added autotests for the new flag and possible combinations REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/perdisplayscalingflag REVISION DETAIL https://phabricator.kde.org/D2866 AFFECTED FILES autotests/testscreenconfig.cpp src/config.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 14 lines] D2865: Change component shown on selection changes
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ::activated depends on the mouse click behaviour - as double click starts a rename this led to the global shortcuts KCM being unusable with double click set. This patch follows the selection chaging - which is more semantically correct as we're not really activating an option in the left hand sidebar, merely selecting it to show the correct sub-options. It fixes keys up/down changing selection but also allows double click mouse settings to work. TEST PLAN Ran. clicked once, got the correct sub-options. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2865 AFFECTED FILES kcms/keys/kglobalshortcutseditor.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Abandoned] D2826: Fix shortcuts editor with double click to activate enabled
davidedmundson abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect
https://bugs.kde.org/show_bug.cgi?id=357288 Raman Gupta changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|UPSTREAM|--- --- Comment #7 from Raman Gupta --- Well, this problem is back again, for no apparent reason. Simply applied some updates (kernel 4.7.3) and rebooted, and now monitor power-save / sleep again does not work. -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Closed] D2859: Bump kirigami dependency to include things we rely on
This revision was automatically updated to reflect the committed changes. Closed by commit rDISCOVER676ce98c0c08: Bump kirigami dependency to include things we rely on (authored by davidedmundson). REPOSITORY rDISCOVER Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2859?vs=6929&id=6938 REVISION DETAIL https://phabricator.kde.org/D2859 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: System Settings - Network -> Connectivity
On Mon, Sep 26, 2016 at 10:01 PM, kainz.a wrote: > After some review of the existing System Setting overview page I come up > that the subgroups for each main group should be at least near the same, > therefore I'd like to update the Network section. > > The main problem of the network section is that you can't configure the > network. The network (lan, wlan, ...) you can configure with the nm > plasmoid. > Intersting question that raises, should you be able to? kde5-nm-connection-editor is runnable standalone, it wouldn't be /too/ much work to put that into a KCM. It just needs everything in the toolbar and the "connection" entry in the menu (7 things in total) into something KCM friendly. >So I'd like to rename the Network main group to >- connectivity > - KDE Connect can now be moved to connectivity > - Online Accounts too > - Blutooth no changes needed > - Webbrowser > (we have some kcm's from kio which are usefull when you use konqueror, > but as kio use them too, they were added to system settings. as they > are > all affected web browsing a subgroup for this kcm's would be nice) > the following KCM's are in this group > - Identification > - Cache > - Cookies > - Web Shortcuts > - Network > (now all network kcm's were grouped in this last group) > - Windows Shares > - Proxy > - Connection preferences > - SSL Preferences > > here is how it should look like > https://share.kde.org/index.php/s/d4i2OAjF1uzlWfB > As much as I don't like moving for the sake of moving, I think here you've got a pretty solid argument. +1 seems sensible. David
Re: Review Request 129035: add the subgroup accessibility to personalization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129035/#review99556 --- Description doesn't match patch - I think you've missed adding a file? - David Edmundson On Sept. 26, 2016, 9:13 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129035/ > --- > > (Updated Sept. 26, 2016, 9:13 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > accessibility is for some users very importend and shouldn't hide in a > desktop behavior subgroup. therefore this patch add a subgroup accessibility > in the personalization section. > > move is in this patch https://git.reviewboard.kde.org/r/129036/ > > > Diffs > - > > categories/old/settings-accessibility.desktop 9604b7f > categories/settings-personalization-accountdetails.desktop 52a2cab > > Diff: https://git.reviewboard.kde.org/r/129035/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Re: Review Request 129040: update search sorting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129040/#review99554 --- Ship it! Ship It! - David Edmundson On Sept. 26, 2016, 9:45 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129040/ > --- > > (Updated Sept. 26, 2016, 9:45 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > I think file search on your pc (indexing) should be the first one in the > search group. also we have an icon for plasma-search > > > Diffs > - > > kcms/baloo/kcm_baloofile.desktop 5ca3964 > kcms/runners/kcm_plasmasearch.desktop 19416f5 > > Diff: https://git.reviewboard.kde.org/r/129040/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Re: Review Request 129039: update startup and shutdown system settings group - others
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129039/#review99553 --- Weight changes - I think we can improve on that, and it's good that you are. +1 Moving KCMS around again - I'm massively against. We've only just moved them round 24 months ago, and whilst it's fine to itterate and bug fix, this is just purely subjective changes with absolutely no rationale given. Everyone has a different opinion where they should be, neither is more wrong, and neither is more right. At which point moving causes more problems than it solves. - David Edmundson On Sept. 26, 2016, 9:38 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129039/ > --- > > (Updated Sept. 26, 2016, 9:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > new startup and shutdown system setting group will look like this > > Startup and Shutdown > - Login Screen (SDDM) > - Splash Screen > - Autostart > - Background Services > - Lock Screen > - Logout and Session > > there are some patches to rearrange the existing kcm's. > - https://git.reviewboard.kde.org/r/129037/ > - https://git.reviewboard.kde.org/r/129038/ > - https://git.reviewboard.kde.org/r/129039/ > > > Diffs > - > > kcms/autostart/autostart.desktop fdd7233 > kcms/kded/kcmkded.desktop 4d9aa28 > kcms/ksmserver/kcmsmserver.desktop c92a4b3 > kcms/ksplash/kcm_splashscreen.desktop b13691f > > Diff: https://git.reviewboard.kde.org/r/129039/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Review Request 129041: Launch Feedback is a notification isn't it?
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129041/ --- Review request for Plasma. Repository: plasma-desktop Description --- move from the Application group to the notification group. I think Launch feedback is more a notification than an application. Diffs - kcms/launch/kcmlaunch.desktop 6c95c4d Diff: https://git.reviewboard.kde.org/r/129041/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129040: update search sorting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129040/ --- Review request for Plasma. Repository: plasma-desktop Description --- I think file search on your pc (indexing) should be the first one in the search group. also we have an icon for plasma-search Diffs - kcms/baloo/kcm_baloofile.desktop 5ca3964 kcms/runners/kcm_plasmasearch.desktop 19416f5 Diff: https://git.reviewboard.kde.org/r/129040/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129039: update startup and shutdown system settings group - others
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129039/ --- Review request for Plasma. Repository: plasma-desktop Description --- new startup and shutdown system setting group will look like this Startup and Shutdown - Login Screen (SDDM) - Splash Screen - Autostart - Background Services - Lock Screen - Logout and Session there are some patches to rearrange the existing kcm's. - https://git.reviewboard.kde.org/r/129037/ - https://git.reviewboard.kde.org/r/129038/ - https://git.reviewboard.kde.org/r/129039/ Diffs - kcms/autostart/autostart.desktop fdd7233 kcms/kded/kcmkded.desktop 4d9aa28 kcms/ksmserver/kcmsmserver.desktop c92a4b3 kcms/ksplash/kcm_splashscreen.desktop b13691f Diff: https://git.reviewboard.kde.org/r/129039/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129038: update startup and shutdown system settings group - sddm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129038/ --- Review request for Plasma. Repository: sddm-kcm Description --- new startup and shutdown system setting group will look like this Startup and Shutdown - Login Screen (SDDM) - Splash Screen - Autostart - Background Services - Lock Screen - Logout and Session there are some patches to rearrange the existing kcm's. - https://git.reviewboard.kde.org/r/129037/ - https://git.reviewboard.kde.org/r/129038/ - https://git.reviewboard.kde.org/r/129039/ Diffs - kcm_sddm.desktop 193c4f6 Diff: https://git.reviewboard.kde.org/r/129038/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129037: update startup and shutdown system settings group - screenlocker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129037/ --- Review request for Plasma. Repository: kscreenlocker Description --- new startup and shutdown system setting group will look like this Startup and Shutdown - Login Screen (SDDM) - Splash Screen - Autostart - Background Services - Lock Screen - Logout and Session there are some patches to rearrange the existing kcm's. - https://git.reviewboard.kde.org/r/129037/ - https://git.reviewboard.kde.org/r/129038/ - https://git.reviewboard.kde.org/r/129039/ Diffs - kcm/screenlocker.desktop 17e6279 Diff: https://git.reviewboard.kde.org/r/129037/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129036: move accessibility kcm to the new subgroup in personalization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129036/ --- Review request for Plasma. Repository: plasma-desktop Description --- move accessibility kcm in the new subgroup added here https://git.reviewboard.kde.org/r/129035/ Diffs - kcms/access/kcmaccess.desktop 5eab3a0 Diff: https://git.reviewboard.kde.org/r/129036/diff/ Testing --- Thanks, Andreas Kainz
Re: Review Request 129035: add the subgroup accessibility to personalization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129035/ --- (Updated Sept. 26, 2016, 9:13 p.m.) Review request for Plasma. Repository: systemsettings Description (updated) --- accessibility is for some users very importend and shouldn't hide in a desktop behavior subgroup. therefore this patch add a subgroup accessibility in the personalization section. move is in this patch https://git.reviewboard.kde.org/r/129036/ Diffs - categories/old/settings-accessibility.desktop 9604b7f categories/settings-personalization-accountdetails.desktop 52a2cab Diff: https://git.reviewboard.kde.org/r/129035/diff/ Testing --- Thanks, Andreas Kainz
Review Request 129035: add the subgroup accessibility to personalization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129035/ --- Review request for Plasma. Repository: systemsettings Description --- accessibility is for some users very importend and shouldn't hide in a desktop behavior subgroup. therefore this patch add a subgroup accessibility in the personalization section. Diffs - categories/old/settings-accessibility.desktop 9604b7f categories/settings-personalization-accountdetails.desktop 52a2cab Diff: https://git.reviewboard.kde.org/r/129035/diff/ Testing --- Thanks, Andreas Kainz
System Settings - Network -> Connectivity
After some review of the existing System Setting overview page I come up that the subgroups for each main group should be at least near the same, therefore I'd like to update the Network section. The main problem of the network section is that you can't configure the network. The network (lan, wlan, ...) you can configure with the nm plasmoid. So I'd like to rename the Network main group to - connectivity - KDE Connect can now be moved to connectivity - Online Accounts too - Blutooth no changes needed - Webbrowser (we have some kcm's from kio which are usefull when you use konqueror, but as kio use them too, they were added to system settings. as they are all affected web browsing a subgroup for this kcm's would be nice) the following KCM's are in this group - Identification - Cache - Cookies - Web Shortcuts - Network (now all network kcm's were grouped in this last group) - Windows Shares - Proxy - Connection preferences - SSL Preferences here is how it should look like https://share.kde.org/index.php/s/d4i2OAjF1uzlWfB
Re: Review Request 129033: plural description
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129033/ --- (Updated Sept. 26, 2016, 10:45 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 27cb33c4c0b408a8bdeae54b587c9de83042d2ce by andreas kainz to branch master. Repository: systemsettings Description --- the single kcm's use the plural description so also the group should use plural like Icons. Diffs - categories/settings-appearance-color.desktop 973ad8b categories/settings-appearance-font.desktop 53f0993 Diff: https://git.reviewboard.kde.org/r/129033/diff/ Testing --- Thanks, Andreas Kainz
Re: Review Request 129033: plural description
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129033/#review99550 --- Ship it! Ship It! - David Edmundson On Sept. 26, 2016, 8:26 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129033/ > --- > > (Updated Sept. 26, 2016, 8:26 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > the single kcm's use the plural description so also the group should use > plural like Icons. > > > Diffs > - > > categories/settings-appearance-color.desktop 973ad8b > categories/settings-appearance-font.desktop 53f0993 > > Diff: https://git.reviewboard.kde.org/r/129033/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Review Request 129033: plural description
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129033/ --- Review request for Plasma. Repository: systemsettings Description --- the single kcm's use the plural description so also the group should use plural like Icons. Diffs - categories/settings-appearance-color.desktop 973ad8b categories/settings-appearance-font.desktop 53f0993 Diff: https://git.reviewboard.kde.org/r/129033/diff/ Testing --- Thanks, Andreas Kainz
Re: Review Request 128802: task bar lines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 26, 2016, 8:24 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Update of the tasks.svgz file focus task -- had now a 3px height line in Highlight color (direction of the line is the same than the lines in kicker, system tray, ... normal task --- no line no color at all no indicator. breeze mean no additional unusefull information and space for the elements to breath hover task -- blue Highlight color line like focus task with additional Highlight color background and 24% opacity attention task -- had a 3px height line in NeutralText color (old one didn't use colorscheme here) minimzed task - rectangular element with Text color and 0.16% opacity (you can see it now in breeze and breeze-dark color scheme) I know it's to late for kf5.26 (03.09) but however if you think it should be available with plasma 5.8 LTS let me know. Diffs - src/desktoptheme/breeze/widgets/tasks.svgz 15a5921 Diff: https://git.reviewboard.kde.org/r/128802/diff/ Testing --- the stylesheed stuff were checked with different color schemes and with kate in the svg "source code". File Attachments the tasks.svgz file for your tests please copy it to your plasma theme dictionary https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz preview of the different tasks (inkscape file preview) https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png Breeze Preview https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png Breeze Dark Color Scheme https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png Arch Color Scheme https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png Oxygen Color Scheme https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png Honeycomb color scheme https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png update tasks file with suggestions from kai https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/5ba391cd-6bbc-43df-ab51-fcab9cbf964c__tasks.svgz Breeze Color Scheme with updated tasks.svgz file https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/202f150a-1011-4ca9-acfc-1811af24ae79__Screenshot_20160830_155736.png Breeze Dark Color Scheme with updated tasks.svgz file https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/88a6cb0d-571d-43e9-9901-8e55ac238073__Screenshot_20160830_155802.png Honeycomb Color Scheme with updated tasks.svgz file https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/f3be8584-bfb3-42e4-b687-87309615a9dd__Screenshot_20160830_155820.png now with ButtonHover for hover task https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/c068c5ab-341f-4c31-a94b-a737befa058b__tasks.svgz tasks are now always bottom lines https://git.reviewboard.kde.org/media/uploaded/files/2016/09/02/32ee725a-d73a-457b-a4cb-a00a3c1e49a7__tasks.svgz screenshot breeze-dark https://git.reviewboard.kde.org/media/uploaded/files/2016/09/02/685a840f-bffd-4868-a184-1b308a1aadbc__Screenshot_20160902_091022.png Thanks, Andreas Kainz
[Differential] [Requested Changes To] D2858: Fix Plasma discover with the Kirigami it can depend on
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Should be discarded, it's incompatible with another RR REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D2858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2859: Bump kirigami dependency to include things we rely on
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rDISCOVER Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D2859 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Discover and Kirigami
Ack, thanks. Just read the full log. At which point: - I'll merge https://phabricator.kde.org/D2859 into both branches - someone should email plasma-packagers (if not done already) David
[Differential] [Accepted] D2858: Fix Plasma discover with the Kirigami it can depend on
apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Please also merge to master and revert the patch there. REPOSITORY rDISCOVER Discover Software Store BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Discover and Kirigami
This was discussed in the meeting today, seems a mistake was made in not freezing this properly. After some discussion it was decided the best options was to go with the Kirigami 1.1 release which is out today. Jonathan On 26 September 2016 at 18:04, David Edmundson wrote: > The Plasma dependency freeze was on the 9th of September. > > Discover, at dependency freeze, depends on Kirigami 1.0 > (and btw, still does) > > With Kirigami 1.0 my plasma-discover crashes on boot: > > QQmlApplicationEngine failed to load component > qrc:/qml/DiscoverWindow.qml:128 Type DiscoverDrawer unavailable > qrc:/qml/DiscoverDrawer.qml:103 Kirigami.Separator is not a type > KCrash: crashing... crashRecursionCounter = 2 > > I don't need to explain why this fails to run. > > What I apparently do need to explain is the dependency freeze rule. > > "After the dependency freeze, you can't change external dependencies on > anything outside Plasma.". Rules can suck, but they're there for a reason. > > If we can't manage 3 weeks without following the simple rules that ensure we > don't break everything, we won't be able to manage 18 months. > > David
[Differential] [Request, 2 lines] D2859: Bump kirigami dependency to include things we rely on
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY (master only) REPOSITORY rDISCOVER Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D2859 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Discover and Kirigami
The Plasma dependency freeze was on the 9th of September. Discover, at dependency freeze, depends on Kirigami 1.0 (and btw, still does) With Kirigami 1.0 my plasma-discover crashes on boot: QQmlApplicationEngine failed to load component qrc:/qml/DiscoverWindow.qml:128 Type DiscoverDrawer unavailable qrc:/qml/DiscoverDrawer.qml:103 Kirigami.Separator is not a type KCrash: crashing... crashRecursionCounter = 2 I don't need to explain why this fails to run. What I apparently do need to explain is the dependency freeze rule. "After the dependency freeze, you can't change external dependencies on anything outside Plasma.". Rules can suck, but they're there for a reason. If we can't manage 3 weeks without following the simple rules that ensure we don't break everything, we won't be able to manage 18 months. David
[Differential] [Request, 69 lines] D2858: Fix Plasma discover with the Kirigami it can depend on
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At Plasma dependency freeze Discover depended on Kirigami 1.0. That means it *has* to work on Kirigami 1.0. It cannot then decide to use features from 1.1, just because it's released. It's against all compatibility promises we make. TEST PLAN Tested discover loads again. Not tested the rest. REPOSITORY rDISCOVER Discover Software Store BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2858 AFFECTED FILES discover/qml/DiscoverDrawer.qml discover/qml/Separator.qml discover/resources.qrc EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/ --- (Updated Sept. 26, 2016, 3:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1369bca36f6ced7d7c64899d1664469d32699f96 by David Rosca to branch master. Repository: plasma-framework Description --- ^^ Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 src/declarativeimports/plasmacomponents/qmenu.cpp b7037da Diff: https://git.reviewboard.kde.org/r/128999/diff/ Testing --- Thanks, David Rosca
Re: Review Request 128870: [ToolButtonStyle] Fix menu arrow
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128870/#review99542 --- Ping - Kai Uwe Broulik On Sept. 9, 2016, 9:41 vorm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128870/ > --- > > (Updated Sept. 9, 2016, 9:41 vorm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This fixes the size of the icon as well as its color group. > > > Diffs > - > > src/declarativeimports/plasmastyle/ToolButtonStyle.qml 2518656 > > Diff: https://git.reviewboard.kde.org/r/128870/diff/ > > > Testing > --- > > It is no longer squashed and ugly and its color is correct on the lock screen > now (white like the text) > > > File Attachments > > > Fixed > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/9d02ec39-2cb2-4c18-8088-aa86973daab4__Screenshot_20160909_113913.png > > > Thanks, > > Kai Uwe Broulik > >
Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/#review99540 --- Ship it! Ship It! - Kai Uwe Broulik On Sept. 23, 2016, 11:20 vorm., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128999/ > --- > > (Updated Sept. 23, 2016, 11:20 vorm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > ^^ > > > Diffs > - > > src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 > src/declarativeimports/plasmacomponents/qmenu.cpp b7037da > > Diff: https://git.reviewboard.kde.org/r/128999/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > >
[Differential] [Closed] D2832: [plasma-pa] Set NotificationAreaCategory to Hardware
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA59aa9bda6507: [plasma-pa] Set NotificationAreaCategory to Hardware (authored by broulik). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2832?vs=6867&id=6922 REVISION DETAIL https://phabricator.kde.org/D2832 AFFECTED FILES applet/metadata.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2730: [Task Manager] Use Qt.binding for prefix
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc0f7ba8504d3: [Task Manager] Use Qt.binding for prefix (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2730?vs=6604&id=6923 REVISION DETAIL https://phabricator.kde.org/D2730 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: A Plasma Vision draft
On 26.09.2016 13:27, Olivier Churlaud wrote: Hi, Sorry if I come late, I wasn't aware of this thread... Le lundi 26 septembre 2016, 12:56:25 CEST Jens Reuterberg a écrit : "Plasma is for people using a computing device in a professional context, where productivity, performance and privacy are essential" I find that the "is for people .." kind of restrictive. I agree that you need to have a precise target audience, but don't freak out other people. If this is your vision, it should be the first big sentence that people will read. Normal users might say, 'uh, I want games as well, and listening to music and editing videos: it's not for me'. We could replace "is for" with "focuses on" if necessary. On the other hand, the stricter a vision is, the more useful it becomes to focus effort. With the above vision, if someone complains about bad gaming performance in Plasma, we can just ask "Do you play games in a professional context? If not, then sorry, your usecase is not what Plasma is made for." Editing videos, though, for me is a classic example of a professional context. Not everybody edits videos professionally, but if Plasma works well for those who do it professionally, it should also work well for those who do it privately. It's really a question of "Do we dare scaring some people off in order to focus more on our target audience?" I wonder if the professional context is important. To me plasma is productivity, performance and privacy. To achieve this, you target professionals (more mission-like). Again, depends on how much we want to focus. Some ideas, that still sound wrong to me, but less (I don't like the "for people"): "Plasma turns computing devices into productive, performant and private tools" We had "performant" in our original draft, but then it was pointed out that it is not a proper English word. "Plasma is for people for which productivity, performance and privacy are essential" If we don't want to define our target audience in the Vision, then this would be a good alternative. Then again, aren't those important for pretty much anybody? "Plasma aims at enhancing the productivity, performance and privacy of the user experience" I don't think an experience can have productivity... ;) "Plasma: experience prod, perf and priv" ? That sounds more like a tagline than a vision, but we already have the tagline "Plasma: Getting things done." Well just some (bad) ideas... They're not bad ideas at all, it's really a matter of how much Plasma wants to focus. Thank you for the input! Olivier
release
System Settings To unify and standardize the stystem configurations the modules cursor theme, colors, emoticons, window decoration get an update.
Re: Minutes Monday Plasma Meeting
VDG: - Breeze Dark for LibreOffice bug fixes were done by kmux from the limux team. Will be backported and shipped with the next 5.2.x update too. - Breeze-dark Icon theme for LibreOffice will be shiped with the next major LO release - alex update the breeze mimetype icons 90% done will be shiped with the next KF release (not part of the LTS release) if you have some UI fixes for 5.8 let us know. 2016-09-26 14:34 GMT+02:00 Sebastian Kügler : > Plasma Meeting minutes 19-9-2016 via IRC > > Present: bshah, Sho, Riddell, notmart, sebas > > bshah: > - Two mobile IMG updates > - Build fix for discover packaging on MCI > - new appstream and packagekit > - now mobile have new kirigami based discover > - Got tips from mck182 on how to debug the accounts on mobile > - Updated all related packages to latest ones > - libkf5wallet-bin was not pulled in by default and hence signond was > not > starting fully > - Further debugging output suggests adding accounts failed due to SSL > errors > - Was missing ca-certificates package (WAT!!?!) > - Now one can add accounts but can't sync contacts yet > - Will debug it further this week > - This week planning to update wayland and xwayland to newer version > - Reported multiple issues with wayland/multiscreen setup > > > notmart: > * week of mostly bugfixes > * fixed a couple of serious bugs in the systray for 5.8 (that could lead to > partially corrupted appletsrc config file) > * panel creation: first startup was behaviong different > * on first startup 2 views were created, now only one > ** now panel creation by javascript is delayed as well, scripting adjusted > to > take that into consideration (in order for panels to have a screen property > right after they are created) > * small layout fix in the splashscreen so now is like vdg wants > * a bit of handholding to opensuse guys (they forked sddm/lockscreen themes > rather than..configuring them) > * fixed bug in the kcolorscheme editor > * preparing for kirigami 1.1 release, that needs to be done before Plasma > 5.8 > (due to discover dependency) > > Riddell: > * 5.8 is on thursday! > * please check over release announce https://www.kde.org/announcements/ > plasma-5.8.0.php (although I'm reluctant for changes due to translations) > > kbroulik: > * Fixed panelcontroller showing up *behind* the panels (probably Qt > behavioral > change, it set "always on top" through KWindowSystem but Qt 5.7 seems to > drop > that flag again if it's not set through QWindow flags, now sets both to be > sure :P) > * Fix for device notifier to only pop up ever if the device is actually > listed > (fixes it popping up when dealing with snappy packages which mounts a loop > device) > * Crash fix on shutdown (keyboard layout thing crashing kded), could > alleviate > kde neon shutdown taking forever as then kded quits gracefully and systemd > doesn't wait for it or its crash handler(?) > > sebas: > - worked on plugin indexing in kcoreaddons, could save 200ms on Plasma > startup, not sure the added complexity is worth it > - will have to do some bugtracking w/ multiscreen > - to reply to journalists' query about LTS release > - will work a bit on kscreen design (feedback, prepare implementation bits > by > cleaning up) > > Full log attached. > -- > sebas > > http://www.kde.org | http://vizZzion.org
Minutes Monday Plasma Meeting
Plasma Meeting minutes 19-9-2016 via IRC Present: bshah, Sho, Riddell, notmart, sebas bshah: - Two mobile IMG updates - Build fix for discover packaging on MCI - new appstream and packagekit - now mobile have new kirigami based discover - Got tips from mck182 on how to debug the accounts on mobile - Updated all related packages to latest ones - libkf5wallet-bin was not pulled in by default and hence signond was not starting fully - Further debugging output suggests adding accounts failed due to SSL errors - Was missing ca-certificates package (WAT!!?!) - Now one can add accounts but can't sync contacts yet - Will debug it further this week - This week planning to update wayland and xwayland to newer version - Reported multiple issues with wayland/multiscreen setup notmart: * week of mostly bugfixes * fixed a couple of serious bugs in the systray for 5.8 (that could lead to partially corrupted appletsrc config file) * panel creation: first startup was behaviong different * on first startup 2 views were created, now only one ** now panel creation by javascript is delayed as well, scripting adjusted to take that into consideration (in order for panels to have a screen property right after they are created) * small layout fix in the splashscreen so now is like vdg wants * a bit of handholding to opensuse guys (they forked sddm/lockscreen themes rather than..configuring them) * fixed bug in the kcolorscheme editor * preparing for kirigami 1.1 release, that needs to be done before Plasma 5.8 (due to discover dependency) Riddell: * 5.8 is on thursday! * please check over release announce https://www.kde.org/announcements/ plasma-5.8.0.php (although I'm reluctant for changes due to translations) kbroulik: * Fixed panelcontroller showing up *behind* the panels (probably Qt behavioral change, it set "always on top" through KWindowSystem but Qt 5.7 seems to drop that flag again if it's not set through QWindow flags, now sets both to be sure :P) * Fix for device notifier to only pop up ever if the device is actually listed (fixes it popping up when dealing with snappy packages which mounts a loop device) * Crash fix on shutdown (keyboard layout thing crashing kded), could alleviate kde neon shutdown taking forever as then kded quits gracefully and systemd doesn't wait for it or its crash handler(?) sebas: - worked on plugin indexing in kcoreaddons, could save 200ms on Plasma startup, not sure the added complexity is worth it - will have to do some bugtracking w/ multiscreen - to reply to journalists' query about LTS release - will work a bit on kscreen design (feedback, prepare implementation bits by cleaning up) Full log attached. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 26-9-2016 via IRC Present: bshah, Sho, Riddell, notmart, sebas bshah: - Two mobile IMG updates - Build fix for discover packaging on MCI - new appstream and packagekit - now mobile have new kirigami based discover - Got tips from mck182 on how to debug the accounts on mobile - Updated all related packages to latest ones - libkf5wallet-bin was not pulled in by default and hence signond was not starting fully - Further debugging output suggests adding accounts failed due to SSL errors - Was missing ca-certificates package (WAT!!?!) - Now one can add accounts but can't sync contacts yet - Will debug it further this week - This week planning to update wayland and xwayland to newer version - Reported multiple issues with wayland/multiscreen setup notmart: * week of mostly bugfixes * fixed a couple of serious bugs in the systray for 5.8 (that could lead to partially corrupted appletsrc config file) * panel creation: first startup was behaviong different * on first startup 2 views were created, now only one ** now panel creation by javascript is delayed as well, scripting adjusted to take that into consideration (in order for panels to have a screen property right after they are created) * small layout fix in the splashscreen so now is like vdg wants * a bit of handholding to opensuse guys (they forked sddm/lockscreen themes rather than..configuring them) * fixed bug in the kcolorscheme editor * preparing for kirigami 1.1 release, that needs to be done before Plasma 5.8 (due to discover dependency) Riddell: * 5.8 is on thursday! * please check over release announce https://www.kde.org/announcements/plasma-5.8.0.php (although I'm reluctant for changes due to translations) kbroulik: * Fixed panelcontroller showing up *behind* the panels (probably Qt behavioral change, it set "always on top" through KWindowSystem but Qt 5.7 seems to drop that flag again if it's not set through QWindow flags, now sets both to be sure :P) * Fix for device notifier to only pop up ever if the device is actually listed (fixes it popping up when dealing with snappy packages which mounts a loop device) * Crash fix on shutdown (keyboard layout thi
Re: A Plasma Vision draft
So the current version after revisions looks like this. To this comes of course addendums like the one in previous versions. We simply want feedback on this so that we know the previous objections are cleared out and we can go forward "Plasma is for people using a computing device in a professional context, where productivity, performance and privacy are essential" Added to that may come the "detail parts" and it will be packaged up, we just want to give everyone a chance to comment first until we nail it down. /Jens On Monday, 4 April 2016 15:45:30 CEST Jens Reuterberg wrote: > Hey, so me and Thomas have been hard at work on this for a while now and I > think we are at a good point to show what we got. > > Please remember that THIS IS JUST A DRAFT! Nothing is set in stone even if > the document looks fancy (the PNG attached to this email) > Below is the raw text of it. > > /Jens > > The Vision is split into three subsections: > Vision, Details and and three key points. > The actual Vision: > Plasma is created to be the primary user interface for multiple device > classes providing a stable, performant, usable and above all productive > environment for professional computer users. > Plasma's feature set is selected for its usefulness in a productive context > with a constant care to user privacy. > > Detail 1: Plasma not only promises to never invade its users' privacy > itself, but also protect against other parties' attempts to spy on them. > Security is a precondition to privacy, all privacy measures are useless in > an insecure system. > Detail 2: Our target audience works with their devices in a professional > setting. Productivity is key for them and their user interface must give > them an efficient and swift way of completing tasks. > Detail 3: A perfomant desktop is the base of any productive environment and > code quality, usability and aesthetic value are relevant to the experience. > Nothing in the interface exists on its own merits but for what it brings to > the user. > > The Three Key points: > Private, Professional, Performant.
[Differential] [Abandoned] D2778: Expose the banner sourceSize
apol abandoned this revision. apol added a comment. I don't like the patch, I'll find a way to work around it. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol
[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5
marten added a comment. A grid layout would fix it, but I assume that the point of using a form layout is that it would automatically pick up the platform and style policy (field and label alignment, stretch policy etc). REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2778: Expose the banner sourceSize
mart added a comment. what's the status of that? REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol
[Differential] [Commented On] D2449: small utility to create L&F packages
mart added inline comments. INLINE COMMENTS > aspotashev wrote in lnflogic.cpp:66 > Double space here in "Plasma Look And Feel". fixed REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: aspotashev, colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D2853: Mouse KCM: Align spin boxes, port to Qt5
mart added inline comments.
INLINE COMMENTS
> mouse.cpp:796
> + foreach (QObject *obj, children) {
> +QAbstractSpinBox *field = qobject_cast(obj);
> +if (field != NULL) {
not sure about this manual resize.
couldn't the kcm just have used a gridlayout instead?
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2853
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D2850: Prevent "TypeError: Cannot read property 'Layout' of null" warning on plasmashell startup
broulik added inline comments.
INLINE COMMENTS
> Panel.qml:79
> when: containment
> value: {
> +if (!containment) {
The binding is still evaluated and a value assigned to "value", it's just that
Binding {} won't propagate it to its target when "when" doesn't evaluate true.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2850
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: eliasp, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
