Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 7 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 07:24:01 +
Build duration: 19 min

CHANGE SET
Revision 1534d93d94355870d1c21d852d92d5fb54d42104 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit applets/kicker/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Failing!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 07:24:31 +
Build duration: 14 min

CHANGE SET
Revision e28256eadd944ee8b7a12afb7bd134844510c8d7 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/appmenu/package/metadata.desktop


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 554 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/554/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 05:45:35 +
Build duration: 28 min

CHANGE SET
Revision 98eb112974f7fa53d04b5b295301736b9a414541 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 553 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/553/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:01:56 +
Build duration: 17 min

CHANGE SET
Revision 274b4e463d0fe0d633d228e08b30c5902284cb29 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
Revision fb285cdecfa8df5eaf55b9cfdcc1fd10a67ab503 by hein: (Fix switching from 
#039;All Applications#039; to #039;Widgets#039;.)
  change: edit applets/kicker/package/contents/ui/DashboardRepresentation.qml
Revision 010ee4fa07aa42b9a6b2453464c7fad71c1d550e by hein: (Don#039;t 
hardcore reserve size.)
  change: edit applets/kicker/plugin/rootmodel.cpp
Revision 57c6c9df72e92971a1a4b2b9aaf1ecd3d453c688 by hein: (Use correct loop 
variable.)
  change: edit applets/kicker/plugin/rootmodel.cpp
Revision c47072294589f7033c6e933a381956e3f1c4ae54 by kde: ([Task Manager] Find 
player if we don#039;t have a PID)
  change: edit applets/taskmanager/package/contents/ui/main.qml
Revision 2b404bd65c582505a838930be6d725f09df0f1e6 by kde: ([Task Manager] 
Don#039;t show separator between media controls and 
quot;Mutequot;)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread Thomas Lübking
luebking added a comment.


  The entire parsing is totally not safe against JoeReddiot murking around in 
the config file, I wonder what happens if we pass "-1" and what is " " cast 
as...
  
  One should probably use "parseInt(border, 10);"?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: luebking, graesslin, mart, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas


[Differential] [Request, 66 lines] D4128: Use an InputEventSpy to notify about key and modifier state changes

2017-01-13 Thread Martin Gräßlin
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  Instead of emitting the key state changed and modifier state changed
  signals from the right point before processing the events, let's use
  an InputEventSpy to do that. The spies were introduced to be called
  directly before the event processing. So the contract still holds.

REPOSITORY
  R108 KWin

BRANCH
  event-spy-for-key-changes

REVISION DETAIL
  https://phabricator.kde.org/D4128

AFFECTED FILES
  keyboard_input.cpp
  keyboard_input.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas


[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread John Salatas
https://bugs.kde.org/show_bug.cgi?id=375005

John Salatas  changed:

   What|Removed |Added

 CC||jsala...@gmail.com

--- Comment #5 from John Salatas  ---
You can also use the keyboard's up/down arrow keys, for more precision/control.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D4091: Add support for skip close animation to OnScreenMessage

2017-01-13 Thread Martin Gräßlin
graesslin added a comment.


  ping, important for Plasma 5.9

REVISION DETAIL
  https://phabricator.kde.org/D4091

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas


[Differential] [Closed] D4089: Add support for skipCloseAnimation for internal windows

2017-01-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:00c68891c782: Add support for skipCloseAnimation for 
internal windows (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4089?vs=10065=10155#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4089?vs=10065=10155

REVISION DETAIL
  https://phabricator.kde.org/D4089

AFFECTED FILES
  autotests/integration/internal_window.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas


[Differential] [Commented On] D4074: Add workaround for touch input offset for decorated windows

2017-01-13 Thread Martin Gräßlin
graesslin added a comment.


  ping, important for Plasma 5.9

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4074

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas


[Differential] [Commented On] D3571: [effects] Use arg="true" in the kcfg files

2017-01-13 Thread Martin Gräßlin
graesslin added a comment.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3571

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas


[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread Martin Gräßlin
graesslin added a comment.


  In https://phabricator.kde.org/D4113#77077, @davidedmundson wrote:
  
  > > isthere a bug # for this?
  >
  > There's a Reddit comment...the new bugzilla.
  
  
  Maybe we need a new bugzilla hook which can automatically reply to reddit 
threads.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: graesslin, mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Closed] D4121: add support for display_name in categories

2017-01-13 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R235:6e4d27af5a8d: add support for display_name in categories 
(authored by mart).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4121?vs=10139=10147

REVISION DETAIL
  https://phabricator.kde.org/D4121

AFFECTED FILES
  src/category.cpp
  src/category.h
  src/categoryparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 15:24:32 +
Build duration: 4 min 1 sec

CHANGE SET
Revision 083396bfd8495115fafbae3f9e475668149d8aab by David Edmundson: (Fix 
mapToGlobal)
  change: edit applets/appmenu/lib/appmenuapplet.cpp
Revision dd10d605c3d0aa2f59bcda3eb2312b474eac4a84 by David Edmundson: (Enable 
Edit Action in plasmoid mode)
  change: edit klipper/klipper.cpp


[Differential] [Closed] D4114: Enable Edit Action in plasmoid mode

2017-01-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dd10d605c3d0: Enable Edit Action in plasmoid mode 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4114?vs=10126=10144

REVISION DETAIL
  https://phabricator.kde.org/D4114

AFFECTED FILES
  klipper/klipper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread David Edmundson
davidedmundson added a comment.


  > isthere a bug # for this?
  
  There's a Reddit comment...the new bugzilla.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Closed] D4120: add support for display_name in categories

2017-01-13 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:7407ca5b4780: add support for display_name in categories 
(authored by mart).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4120?vs=10140=10146

REVISION DETAIL
  https://phabricator.kde.org/D4120

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/provider.h
  src/downloadwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: kossebau, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Closed] D4036: When updating another user's avatar don't save icon into our home

2017-01-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:0d43e0379a16: When updating another user's avatar don't 
save icon into our home (authored by davidedmundson).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4036?vs=9888=10145

REVISION DETAIL
  https://phabricator.kde.org/D4036

AFFECTED FILES
  src/accountinfo.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: Plasma Sprint discussion planning

2017-01-13 Thread Marco Martin
On Thursday 12 January 2017 20:39:39 Martin Gräßlin wrote:
> 1. Global Touchscreen gestures:
> ...
> 2. Global Touchpad gestures:
> we started on that, unfortunately the design document went into the
> world of gestures which cannot be supported, since then it didn't go
> anywhere. I would love the team to have a look at it again and define
> the gestures to implement.

I'll give another go at obtaining an updated design document, for both
if not, we'll talk about that at the sprint, as we have several developers 
with many years of experience in designing UI.
I refrained from that so far, as I didn't want to prevaricate

> 3. Maintaining X11 specific code:
> Over the last half year exclusively on Wayland I realized that I cannot
> maintain X11 specific code any more. KWin is mostly no problem as
> XWayland windows are used the same way as native X windows. But things
> which have a different implementation on Wayland I cannot maintain any
> more. This affects mostly kglobalaccel, klipper and partly the
> KWin-standalone platform. I want the team to think about plans how we
> can continue to maintain the X11 specific parts especially with more of
> the team (hopefully) moving to Wayland.

This is one of the most important things that have to be discussed at the 
sprint, yes

-- 
Marco Martin


[Differential] [Closed] D4117: Fix mapToGlobal

2017-01-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:083396bfd849: Fix mapToGlobal (authored by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4117?vs=10131=10143

REVISION DETAIL
  https://phabricator.kde.org/D4117

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ddae0398027b: Correct inital loading of BorderActivate 
(authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4113?vs=10125=10142

REVISION DETAIL
  https://phabricator.kde.org/D4113

AFFECTED FILES
  scripts/minimizeall/contents/code/main.js

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D4120: add support for display_name in categories

2017-01-13 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Sounds good. While touching this, have you considered localized display names?
  
  While content description might be still English as lingua-franca, having the 
display name localized might be another step into the direction of average 
users which are not fluent in English.

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: kossebau, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Accepted] D4121: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  This being an extension of ocs, we will need to prepare a proposal of this at 
some point in the not too far distant future. However, as other things (tags 
etc) are also going to be required, perhaps that could all be done at the same 
time. OCS being implementation-driven, and attica/ocs-server being the 
reference implementations, i did think that we might be venturing into 
embrace/extend territory here, however it is more akin to how OCS has always 
been developed (just more in the public eye now, rather than behind closed 
doors). So, yup, let's do this.

REPOSITORY
  R235 Attica

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Accepted] D4120: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  We will need to consider the implications of adding functionality into ocs, 
but technically this would be fine.

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Accepted] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread Marco Martin
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  isthere a bug # for this?

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=375005

Paul M  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=375005

--- Comment #4 from Paul M  ---
(In reply to Kai Uwe Broulik from comment #3)
> Don't you have a mouse wheel or scroll gesture on your touchpad?

Yes I do but those aren't always precise (especially touchpad scroll gestures).
The arrows are useful for scrolling small distances, or for scrolling lazily
whereby you just keep the arrow pressed down.

I know you don't *have* to click the arrow itself to scroll, but I think they
add some visual clarity, especially for novices, that the function is for
moving up and down. The arrows also distinguish a scroll bar from other UI
elements used in breeze e.g. in Dolphin there is a disk space indicator which
looks almost visually identical to a scroll bar. Hide the arrow when the mouse
is not over and you still get the elegant clean clutter-free design you are
striving for.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated] D4121: add support for display_name in categories

2017-01-13 Thread Star Buck
starbuck updated the summary for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated] D4120: add support for display_name in categories

2017-01-13 Thread Star Buck
starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Accepted] D4114: Enable Edit Action in plasmoid mode

2017-01-13 Thread Marco Martin
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4114

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4121: add support for display_name in categories

2017-01-13 Thread Star Buck
starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated] D4121: add support for display_name in categories

2017-01-13 Thread Star Buck
starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated] D4120: add support for display_name in categories

2017-01-13 Thread Marco Martin
mart added a dependency: D4121: add support for display_name in categories.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated] D4121: add support for display_name in categories

2017-01-13 Thread Marco Martin
mart added a dependent revision: D4120: add support for display_name in 
categories.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 31 lines] D4121: add support for display_name in categories

2017-01-13 Thread Marco Martin
mart created this revision.
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  categories description on ocs now supports a new tag, that is disaplay_name
  which unlike name is supposed to be user friendly and be changeable
  by the server without clients actually breaking
  
  for instance
  https://api.kde-look.org/ocs/v1/content/categories

TEST PLAN
  wallpaper ghns dialog uses display names for categories now

REPOSITORY
  R235 Attica

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4121

AFFECTED FILES
  src/category.cpp
  src/category.h
  src/categoryparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 84 lines] D4120: add support for display_name in categories

2017-01-13 Thread Marco Martin
mart created this revision.
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  categories description on ocs now supports a new tag, that is disaplay_name
  which unlike name is supposed to be user friendly and be changeable
  by the server without clients actually breaking
  
  for instance
  https://api.kde-look.org/ocs/v1/content/categories

TEST PLAN
  wallpaper ghns dialog uses display names for categories now

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/provider.h
  src/downloadwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 13:16:35 +
Build duration: 15 min

CHANGE SET
Revision c47072294589f7033c6e933a381956e3f1c4ae54 by kde: ([Task Manager] Find 
player if we don#039;t have a PID)
  change: edit applets/taskmanager/package/contents/ui/main.qml
Revision 2b404bd65c582505a838930be6d725f09df0f1e6 by kde: ([Task Manager] 
Don#039;t show separator between media controls and 
quot;Mutequot;)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Closed] D4107: [Task Manager] Don't show separator between media controls and "Mute"

2017-01-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b404bd65c58: [Task Manager] Don't show separator between 
media controls and "Mute" (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4107?vs=10112=10134

REVISION DETAIL
  https://phabricator.kde.org/D4107

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4106: [Task Manager] Find player if we don't have a PID

2017-01-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c47072294589: [Task Manager] Find player if we don't have 
a PID (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4106?vs=10111=10133

REVISION DETAIL
  https://phabricator.kde.org/D4106

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4089: Add support for skipCloseAnimation for internal windows

2017-01-13 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  internal-window-skip-close-animation

REVISION DETAIL
  https://phabricator.kde.org/D4089

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas


[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=375005

--- Comment #3 from Kai Uwe Broulik  ---
Don't you have a mouse wheel or scroll gesture on your touchpad?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=375005

--- Comment #2 from Paul M  ---
(In reply to Kai Uwe Broulik from comment #1)
> You can configure which buttons you want

Yes, I know you can configure the scroll bar, but as a default it doesn't make
sense to hide the arrow.

The defaults should also be suitable for novices and most of my relatives (who
have used computers for years) read webpages by repeatedly clicking the arrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D4117: Fix mapToGlobal

2017-01-13 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4117

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=375005

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||k...@privat.broulik.de
 Resolution|--- |WORKSFORME

--- Comment #1 from Kai Uwe Broulik  ---
You can configure which buttons you want to have a scroll bars in System
Settings → Application Style → "Configure" next to the "Breeze" dropdown →
Scroll bars. (or just run "breeze-settings5" app)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated] D4118: if is not an archive, always copy

2017-01-13 Thread Marco Martin
mart added a reviewer: leinir.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4118

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 5 lines] D4118: if is not an archive, always copy

2017-01-13 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  for wallpapers, some items can be an archive, some aren't
  this may be true for other types of resources as well, so
  make this more general. if the downloaded file is not an archive,
  just copy it, instead of silently fail

TEST PLAN
  different types of assets still install correctly, all wallpapers now install

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/isarchive

REVISION DETAIL
  https://phabricator.kde.org/D4118

AFFECTED FILES
  src/core/installation.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 2 lines] D4117: Fix mapToGlobal

2017-01-13 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When recreating QQuickItem::mapToGlobal for < Qt 5.7 we are currently
  using the window's global position and the item's position relevant to
  it's parent. We need to use the item's position relative to the scene.

TEST PLAN
  Had applet on right hand side of panel, menus are now in the correct place.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4117

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Breeze] [Bug 375005] New: New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=375005

Bug ID: 375005
   Summary: New scrollbars for Plasma 4.9: slow scrolling is no
longer intuitive
   Product: Breeze
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: k...@paulmcauley.com
  Target Milestone: ---

I tried the new scrollbars for Plasma 4.9 and think they need tweaked further.
With the traditional scrollbars there were arrows on which you could click to
scroll slowly. Now to scroll slowly you have to click on a smaller and less
intuitive hidden white area outside the main scrollbar. Arrows were also more
intuitive for novice users to indicate the function of the bar.

To correct this I think you should show the scroll arrows on mouse over, just
like you show the area representing what is hidden only on mouse over. This
keeps the less cluttered new look, except with the same original functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D4115: Keep AppletMenu as small as possible

2017-01-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e7dc85aa0b5f: Keep AppletMenu as small as possible 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4115?vs=10127=10130#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4115?vs=10127=10130

REVISION DETAIL
  https://phabricator.kde.org/D4115

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4116: associate with deb and rpm to expose local file install capability

2017-01-13 Thread Harald Sitter
sitter added a comment.


  That may well be overengineering the solution. I think it'd be fine to 
configure_file the desktop file and build the list of miemtypes 
programmatically at build time and let packagers override it.
  Separate mimetype files would only be useful if platform 'foo' has >1 
packagekit backend and the list of supported formats is different between the 
backends. Which I think is not the case for any right now.
  
  That being said, should it become necessary, separate files would be the way 
to go.
  For packagers this is then representable as
  
  - pk-backend-foo --(depends)--> discover-backend-foo [only contains desktop 
file]
  - pk-backend-bar --(depends)--> discover-backend-bar [only contains desktop 
file]

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D4116

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4116: associate with deb and rpm to expose local file install capability

2017-01-13 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:2a864687bf5b: associate with deb and rpm to expose local 
file install capability (authored by sitter).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4116?vs=10128=10129

REVISION DETAIL
  https://phabricator.kde.org/D4116

AFFECTED FILES
  discover/org.kde.discover.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4116: associate with deb and rpm to expose local file install capability

2017-01-13 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  This is good for now.
  
  I wonder if we should have separate desktop files, like okular does...

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4116

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 11:37:18 +
Build duration: 5 min 47 sec

CHANGE SET
Revision 57c6c9df72e92971a1a4b2b9aaf1ecd3d453c688 by hein: (Use correct loop 
variable.)
  change: edit applets/kicker/plugin/rootmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Request, 2 lines] D4116: associate with deb and rpm to expose local file install capability

2017-01-13 Thread Harald Sitter
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4116

AFFECTED FILES
  discover/org.kde.discover.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4115: Keep AppletMenu as small as possible

2017-01-13 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4115

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 11:11:00 +
Build duration: 21 min

CHANGE SET
Revision 010ee4fa07aa42b9a6b2453464c7fad71c1d550e by hein: (Don#039;t 
hardcore reserve size.)
  change: edit applets/kicker/plugin/rootmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Request, 3 lines] D4115: Keep AppletMenu as small as possible

2017-01-13 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In retrospect there's no need to fill the width, if people want that
  effect they can add a spacer; whereas you can't do the opposite.
  
  Also set the size to 0 when it's empty. This mean using status as
  normally PanelContainment ensures plasmoid's are a minimum of a square.
  
  BUG: 374996

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4115

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: "Software not found" Runner

2017-01-13 Thread Harald Sitter
On Fri, Jan 13, 2017 at 11:56 AM, Marco Martin  wrote:
> On Thursday 12 January 2017 14:46:49 Aleix Pol wrote:
>> On Tue, Jan 10, 2017 at 3:57 PM, Marco Martin  wrote:
>> > On Tuesday 10 January 2017, Aleix Pol wrote:
>> >> Bump?
>> >>
>> >> It's working well here, past memory issues have been fixed in upstream
>> >> AppStreamQt.
>> >> Is it something we want?
>> >>
>> >> Aleix
>> >
>> > I would be ok with this
>>
>> Do we want this for 5.9?
>
> my gut feeling is is a bit late and hasn't been tested enough, so merge at the
> very beginning of 5.10 cycle?

Well, 5.9 is feature frozen since yesterday anyway, so now it has to
be master for 5.10 :P

On a slightly related note: to get more testing exposure I'd also
argue that it should be enabled in kickoff (which IIRC has its own
hardcoded list of runners), whether or not it should stay enabled I'd
take to the VDG. Personally I am using kickoff more than krunner since
the meta-opens-menu change, so I'd be in favor of having it enabled in
kickoff for 5.10. There may be a need for visual decluttering though.
Kickoff mushes all runner results together, it may well be useful to
have them grouped like in krunner to avoid confusion?

HS


Re: "Software not found" Runner

2017-01-13 Thread Marco Martin
On Thursday 12 January 2017 14:46:49 Aleix Pol wrote:
> On Tue, Jan 10, 2017 at 3:57 PM, Marco Martin  wrote:
> > On Tuesday 10 January 2017, Aleix Pol wrote:
> >> Bump?
> >> 
> >> It's working well here, past memory issues have been fixed in upstream
> >> AppStreamQt.
> >> Is it something we want?
> >> 
> >> Aleix
> > 
> > I would be ok with this
> 
> Do we want this for 5.9?

my gut feeling is is a bit late and hasn't been tested enough, so merge at the 
very beginning of 5.10 cycle?

-- 
Marco Martin


[Differential] [Request, 1 line] D4114: Enable Edit Action in plasmoid mode

2017-01-13 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  EditAction is a keyboard activated shortcut that shows a dialog, there's
  no reason for it to be available in standalone mode only, especially given 
the 
  option to enable the shortcut is available from the plasmoid.
  
  BUG: 374961

TEST PLAN
  Set shortcut.
  Pressed it.
  Got a dialog with my clipboard contents
  
  Standalone mode should be unchanged as it was showing it already.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4114

AFFECTED FILES
  klipper/klipper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4103: Support spring-loading on drag hover and drops into preview popups.

2017-01-13 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 7 lines] D4113: Correct inital loading of BorderActivate

2017-01-13 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  We have a comma separated list:
  
  "".split(',') returns ""
  JS decides that's worth itterating over, and we implicitly cast "" to a
  number which means we register on screen edge 0 (the top).
  
  We can't use typeof is isFinite because valid entries are still strings
  at this point.

TEST PLAN
  Ran with default config, no longer registered on top edge
  Set an edge properly in the KCM. Still worked.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4113

AFFECTED FILES
  scripts/minimizeall/contents/code/main.js

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas


Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Failing!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 08:42:39 +
Build duration: 9 min 23 sec

CHANGE SET
Revision abd5a4a1ce5af2cb5d125acd82716ff6cb77a980 by hein: (Show quot;All 
Widgetsquot; even when showSpecialFilters=false.)
  change: edit components/shellprivate/widgetexplorer/widgetexplorer.cpp


[Differential] [Closed] D4112: Show "All Widgets" even when showSpecialFilters=false.

2017-01-13 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:abd5a4a1ce5a: Show "All Widgets" even when 
showSpecialFilters=false. (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4112?vs=10122=10123

REVISION DETAIL
  https://phabricator.kde.org/D4112

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4112: Show "All Widgets" even when showSpecialFilters=false.

2017-01-13 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4112

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 6 lines] D4112: Show "All Widgets" even when showSpecialFilters=false.

2017-01-13 Thread Eike Hein
hein created this revision.
hein added reviewers: Plasma, mart, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  "All Widgets" is a reasonable default state, and semantically not
  really a filter.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4112

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 3 - Still Unstable!

2017-01-13 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 08:30:09 +
Build duration: 5 min 42 sec

CHANGE SET
Revision fb285cdecfa8df5eaf55b9cfdcc1fd10a67ab503 by hein: (Fix switching from 
#039;All Applications#039; to #039;Widgets#039;.)
  change: edit applets/kicker/package/contents/ui/DashboardRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)