D5381: Add brightness control using ddcutil lib
dvogel updated this revision to Diff 13586. dvogel added a comment. Addition of a QTimer set by default to 1 sec to filter setBrightness calls: the actual DDC communication happens 1 sec after the last setBrightness() call. This solves brightness flickering when scrolling quickly on the battery icon, and communication failure over DDC when waking the monitor from power-save mode (Dell U2212HM wakes up in less than 1 sec). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=13395&id=13586 REVISION DETAIL https://phabricator.kde.org/D5381 AFFECTED FILES daemon/backends/CMakeLists.txt daemon/backends/upower/ddcutilbrightness.cpp daemon/backends/upower/ddcutilbrightness.h daemon/backends/upower/powerdevilupowerbackend.cpp daemon/backends/upower/powerdevilupowerbackend.h To: dvogel, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 858 - Still Unstable!
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/858/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 22:04:33 +
Build duration: 42 min
CHANGE SET
Revision 3468d970dbebf9892a3b1648973adcb226435b20 by scripty: (SVN_SILENT made
messages (.desktop file) - always resolve ours)
change: edit plasma.desktop.cmake
change: edit plasmawayland.desktop.cmake
change: edit
shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop
Revision d90aa6fe922a54b0cf5e146dbf29261c9133c7ea by scripty: (SVN_SILENT made
messages (.desktop file) - always resolve ours)
change: edit dataengines/mouse/plasma-dataengine-mouse.desktop
Revision ef12ad389ee48208e7a7c8520dc3a05864d2fe87 by Marco Martin: (Correctly
handle when a new primary screen displaces the old)
change: edit shell/shellcorona.cpp
Revision d9937c535aa8c6f7eaf381cb882e53a8f1d34d2e by scripty: (SVN_SILENT made
messages (.desktop file) - always resolve ours)
change: edit templates/ion-dataengine/ion-dataengine.kdevtemplate
change: edit applets/appmenu/package/metadata.desktop
change: edit xembed-sni-proxy/xembedsniproxy.desktop
change: edit runners/baloo/plasma-runner-baloosearch.desktop
change: edit wallpapers/image/wallpaper.knsrc
change: edit templates/ion-dataengine/src/ion-%{APPNAMELC}.desktop
change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc
Revision 1a26abe5b0e6af45eab95a6147c627793755e088 by hein: (Fix losing
wallpaper selection when clicking "Apply".)
change: edit wallpapers/image/imagepackage/contents/ui/config.qml
Revision 58206408a35a0900b5678231b7aaf490b2a3ec10 by kde: (When deleting the
panel the notifications applet is in, the containment)
change: edit applets/notifications/lib/notificationsapplet.cpp
Revision 550860f6366cc99d3f0ff19f74fd3fc3d1bfc0ad by kde: ([Media Controller]
Use double for length instead of int)
change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
JUNIT RESULTS
Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total:
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory
COBERTURA RESULTS
Cobertura Coverage Report
PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979
(39%)CONDITIONAL 1624/5952 (27%)
By packages
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL
122/3251 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL
15/30 (50%)
Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 111 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 22:00:03 + Build duration: 44 min CHANGE SET Revision 58206408a35a0900b5678231b7aaf490b2a3ec10 by kde: (When deleting the panel the notifications applet is in, the containment) change: edit applets/notifications/lib/notificationsapplet.cpp Revision 550860f6366cc99d3f0ff19f74fd3fc3d1bfc0ad by kde: ([Media Controller] Use double for length instead of int) change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 (39%)CONDITIONAL 1634/5924 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 122/3247 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
D5497: Improved Suggestions Model
Aiix added a comment. In https://phabricator.kde.org/D5497#103180, @apol wrote: > Isn't mycroft supposed to do the language parts? is it mandatory to have this huge list? mycroft is doing the language parts, but i don't think currently i can utilize its skills output capability yet for a recommender system. For something like auto complete or presenting a choice of suggestions for the user to choose from i am manually creating an offline recommender system based of category based filtering so i need to support that huge word list or provide some alternative feed to the filtering system with words to lookup and match from. If i require mycroft to work as a recommender system out of the box currently I'd i have to make changes to the upstream core files and fork it that is another package management and mycroft core maintenance issue all together. I will look into moving all of the word and suggestions list in some kind of offline DB or fetch words from a source online to keep it more clean. REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D5497 To: Aiix Cc: apol, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
D5464: Nextcloud Upload Purpose Plugin
davidedmundson added inline comments.
INLINE COMMENTS
> CMakeLists.txt:8
> +
> +
you need to set the translation domain (copy and paste the line from another
CMakeLists)
> nextcloudjob.cpp:82
> +
> +void NextcloudJob::checkTargetFile(const int suffix, const QUrl& local,
> KJob* j)
> +{
Replace this first argument with KIO::suggestName(); you just need to know the
name of the last one you tried; which you can extract from the URL you're using
Then you can kill: createTargetUrl
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D5464
To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 939 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/939/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 18:27:37 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.org.kde.plasma.analogclock-test COBERTURA RESULTS Cobertura Coverage Report By packages
D5464: Nextcloud Upload Purpose Plugin
yuenlim added a comment. Ping :) Think someone can help me review this? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5497: Improved Suggestions Model
apol added a comment. Isn't mycroft supposed to do the language parts? is it mandatory to have this huge list? REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D5497 To: Aiix Cc: apol, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
D5481: [Media Controller] Use double for length instead of int
broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-workspace.git/commit/?id=550860f6366cc99d3f0ff19f74fd3fc3d1bfc0ad REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5481 To: broulik, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5321: [Notifications Applet] Don't crash when containment() disappears
This revision was automatically updated to reflect the committed changes. Closed by commit R120:58206408a35a: When deleting the panel the notifications applet is in, the containment is… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5321?vs=13155&id=13582#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5321?vs=13155&id=13582 REVISION DETAIL https://phabricator.kde.org/D5321 AFFECTED FILES applets/notifications/lib/notificationsapplet.cpp To: broulik, #plasma, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5495: Make sure the backend has been set up properly
This revision was automatically updated to reflect the committed changes. Closed by commit R134:ffd101f129a9: Make sure the backend has been set up properly (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5495?vs=13572&id=13581 REVISION DETAIL https://phabricator.kde.org/D5495 AFFECTED FILES libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp libdiscover/backends/FlatpakBackend/FlatpakBackend.h To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner edited the summary of this revision. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
ltoscano added a comment. While you fix the issue with the code, please add a line BUG: 372635 in the summary instead of the other reference to the bug; this should send a notification and close the bug when the review is accepted. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5499: Fix new checkbox for file content indexing in kcm_baloofile
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5499 To: fvogt, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5499: Fix new checkbox for file content indexing in kcm_baloofile
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Needs a new connection to enable the "Apply" button. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5499 AFFECTED FILES kcms/baloo/kcm.cpp To: fvogt, #plasma Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[kio-extras] [Bug 376344] cant write to smb shares which has write access
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #13 from fbr --- (In reply to Elvis Angelaccio from comment #12) > (In reply to fbr from comment #11) > > (In reply to mathojojo from comment #10) > > > Hello, > > > > > > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug > > > has been reported here many times, and on duplicates as well... > > > > I agree with you... many people have the same issue but this bug seems to be > > forgotten :( > > Changing the status to confirmed would be pointless. Either there is a dev > who uses samba and is motivated to fix this bug, or the bug will stay there > (even if you mark it as confirmed). You are right but I can't believe that no devs use samba :). However it is not a good point for KDE in some contexts : For example I use KDE for my work in my company and this kind of problems can be very impacting and could be a "motivation" to switch to another DE. KDE is really good, I don't want to change :) -- You are receiving this mail because: You are the assignee for the bug.
[kio-extras] [Bug 376344] cant write to smb shares which has write access
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #12 from Elvis Angelaccio --- (In reply to fbr from comment #11) > (In reply to mathojojo from comment #10) > > Hello, > > > > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug > > has been reported here many times, and on duplicates as well... > > I agree with you... many people have the same issue but this bug seems to be > forgotten :( Changing the status to confirmed would be pointless. Either there is a dev who uses samba and is motivated to fix this bug, or the bug will stay there (even if you mark it as confirmed). -- You are receiving this mail because: You are the assignee for the bug.
D5497: Improved Suggestions Model
Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T5892 Provide suggestions and randomization on each char text entry, Match characters and inital predict word, Display random suggestion if keywords do not match TEST PLAN Random input of characters to check if the new suggestion model can predict the next best word or closer match, Test for keyword match which will display an entire question or query suggestion REPOSITORY R846 Mycroft Plasma integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D5497 AFFECTED FILES plasmoid/contents/ui/Suggestions.qml plasmoid/contents/ui/main.qml plasmoid/contents/ui/suggestion/WikiList plasmoid/contents/ui/suggestion/WikiList.txt plasmoid/contents/ui/suggestion/words.txt plasmoid/contents/ui/suggestion/words1.txt plugin/filereader.cpp plugin/filereader.h To: Aiix Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[kio-extras] [Bug 376344] cant write to smb shares which has write access
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #11 from fbr --- (In reply to mathojojo from comment #10) > Hello, > > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug > has been reported here many times, and on duplicates as well... I agree with you... many people have the same issue but this bug seems to be forgotten :( -- You are receiving this mail because: You are the assignee for the bug.
D5492: We don't have this dependency anymore
apol abandoned this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5492 To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5321: [Notifications Applet] Don't crash when containment() disappears
davidedmundson added a comment. RE: your message on IRC this morning. Yes, you should submit this. I explained in my comment why it's needed. It's not quite for the reason you initially said, but the solution is still valid. Ideally fix your comment about the containment being gone. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5321 To: broulik, #plasma, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5495: Make sure the backend has been set up properly
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D5495 AFFECTED FILES libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp libdiscover/backends/FlatpakBackend/FlatpakBackend.h To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5492: We don't have this dependency anymore
apol updated this revision to Diff 13571. apol added a comment. - Better assert on flatpak successfully set up REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5492?vs=13567&id=13571 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5492 AFFECTED FILES CMakeLists.txt libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp libdiscover/backends/FlatpakBackend/FlatpakBackend.h To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Next Plasma LTS and openSUSE
Am 2017-04-18 13:55, schrieb Luca Beltrame: Hi everyone, this is basically the same discussion as already took place for 5.8. According to distrowatch, it looks very much like we're currently the _only_ remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default. Not only has Ubuntu switched to GNOME, for openSUSE there's currently also a major fork in the road happening next: - openSUSE Tumbleweed will likely switch to having no default at all (user has to choose one) - openSUSE Leap _may_ switch to GNOME as it is the desktop in SUSE Linux Enterprise. The argument here is that SUSE has a desktop team that is paid to fix bugs, while this is not the case for the community-maintained KDE packages. It's obvious that this switch must not happen for various political reasons: - GNOME becomes the de-facto standard desktop (Fedora, Ubuntu, openSUSE) - This headline: "openSUSE switches default desktop after 10+ years, KDE not viable?" - openSUSE KDE users might think that the focus shifted away The only chance I can see avoiding the switch is by delivering a flawless experience for the next major release, which will be released roughly this time next year. So it would be perfect to have a 5.12 (?) LTS by then. The way the schedule aligned for Leap 42.2 with Plasma 5.8.2 was perfect, thanks for that again! Additionally, it would be great to have an Applications LTS as well, which would make a faster feature-release cycle alongside a slower LTS cycle possible. I'm aware that this is an awful situation to be in, but I hope that we can figure something out... Hi Luca, like what Aleix said a retrospection oh how 5.8 worked would be great. Concerning the release schedule I suggest to have the openSUSE Leap release team talk directly to our release team to come up with a nicely aligned schedule which works for both projects. 5.8 was a little bit hurried, so more planning is good. Personally I'm quite concerned about this constant threat of "we switch to GNOME". I have a feeling that people high in openSUSE are lobbying for it and we have no real chance. Either it's used as a way to put pressure on us - which would suck - or it might be better for our developers health to say "let openSUSE move". This is now my personal opinion based on the last year. Overall it felt to me like openSUSE is trying to push us around with the constant threat of using GNOME. In any case I want to collaborate as much as possible with openSUSE and I'm all for aligning the LTS so that it works for you, but I think the pressure from openSUSE and the threats need to stop. Cheers Martin
Re: Next Plasma LTS and openSUSE
On Tue, Apr 18, 2017 at 1:55 PM, Luca Beltrame wrote: > Hi everyone, > > this is basically the same discussion as already took place for 5.8. > > According to distrowatch, it looks very much like we're currently the _only_ > remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default. > Not only has Ubuntu switched to GNOME, for openSUSE there's currently also a > major fork in the road happening next: > > - openSUSE Tumbleweed will likely switch to having no default at all > (user has to choose one) > - openSUSE Leap _may_ switch to GNOME as it is the desktop in SUSE Linux > Enterprise. The argument here is that SUSE has a desktop team that is paid > to fix bugs, while this is not the case for the community-maintained KDE > packages. > > It's obvious that this switch must not happen for various political reasons: > - GNOME becomes the de-facto standard desktop (Fedora, Ubuntu, openSUSE) > - This headline: "openSUSE switches default desktop after 10+ years, KDE not > viable?" > - openSUSE KDE users might think that the focus shifted away > > The only chance I can see avoiding the switch is by delivering a flawless > experience for the next major release, which will be released roughly this > time next year. So it would be perfect to have a 5.12 (?) LTS by then. The way > the schedule aligned for Leap 42.2 with Plasma 5.8.2 was perfect, thanks for > that again! > > Additionally, it would be great to have an Applications LTS as well, which > would make a faster feature-release cycle alongside a slower LTS cycle > possible. > > I'm aware that this is an awful situation to be in, but I hope that we can > figure something out... Hi Luca, Thanks for reaching out! Clearly having an LTS release doesn't cut it for openSUSE, as we already did that last time and for the next release we're receiving yet another e-mail like the house is on fire. I think it would be healthy to release a new LTS by next year anyway, and it seems to align with what we have over here: https://community.kde.org/Schedules/Plasma_5 Now the interesting conversation would be how can we work better. - Which parts from 5.8 have worked well? - Which parts from 5.8 haven't worked well? - Do you have the feeling that your feedback is acted on? - Where are the problems we should be concerned with? Personally, with my Discover hat on, I have seen very little feedback from opensuse and that worries me: https://bugs.kde.org/buglist.cgi?product=Discover&query_format=advanced&rep_platform=openSUSE%20RPMs Aleix
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 857 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 11:37:23 + Build duration: 18 min CHANGE SET Revision 71dda89bb80d69bd8fe0d77c3e28075341270a34 by kde: ([Plasma Windowed] Disable standard actions on SNI) change: edit plasma-windowed/plasmawindowedview.cpp Revision 27efb8b19577cde1c332259a12bc5e85375e67b1 by kde: ([Plasma Windowed] Emit contextualActionsAboutToShow before showing them) change: edit plasma-windowed/plasmawindowedview.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979 (39%)CONDITIONAL 1624/5952 (27%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 56/90 (62%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 (66%)CONDITIONAL 113/216 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 349/820 (43%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 122/3251 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner added a comment.
In https://phabricator.kde.org/D5490#103059, @lfurmetz wrote:
> In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote:
>
> > You can do this:
> >
> > property bool moved: false
> > onMovedChanged: if (moved) {
> > listView.currentIndex = index
> > }
> > onPositionChanged: {
> > ...
> > moved = true;
> > }
> >
>
>
> I tried this, but onPositionChanged doesn't fire for me at all in qt
4.8.0.. Is this a bug?
>
> Is it possible to attach the property __moved to the parent ListView
dynamically, so it can be checked by all delegates?
See my updated patch. It moves the moved property to listView and works much
better than the previous patch.
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D5490
To: leszeklesner, broulik
Cc: lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
lfurmetz added a comment.
In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote:
> You can do this:
>
> property bool moved: false
> onMovedChanged: if (moved) {
> listView.currentIndex = index
> }
> onPositionChanged: {
> ...
> moved = true;
> }
>
I tried this, but onPositionChanged doesn't fire for me at all in qt 4.8.0..
Is this a bug?
Is it possible to attach the property __moved to the parent ListView
dynamically, so it can be checked by all delegates?
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D5490
To: leszeklesner, broulik
Cc: lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner updated this revision to Diff 13568. leszeklesner edited the summary of this revision. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5490?vs=13561&id=13568 REVISION DETAIL https://phabricator.kde.org/D5490 AFFECTED FILES lib/qml/ResultDelegate.qml lib/qml/ResultsView.qml To: leszeklesner, broulik Cc: anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5492: We don't have this dependency anymore
apol abandoned this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5492 To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 719 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/719/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 09:32:41 + Build duration: 27 min CHANGE SET Revision 87f4c65282b97abc1c292f635df1960de57c7514 by ivan.cukic: (Adding an option to show popular documents/apps for Kicker and Dash) change: edit applets/kicker/plugin/rootmodel.h change: edit applets/kicker/plugin/rootmodel.cpp change: edit applets/kicker/package/contents/ui/ConfigGeneral.qml change: edit applets/kicker/plugin/recentusagemodel.cpp change: edit applets/kicker/package/contents/config/main.xml change: edit applets/kicker/package/contents/ui/main.qml change: edit applets/kicker/plugin/recentusagemodel.h JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1546/3761 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
D5490: Only follow mouse when moved (Fixes Bug #372635)
anthonyfieroni added a comment.
You can do this:
property bool moved: false
onMovedChanged: if (moved) {
listView.currentIndex = index
}
onPositionChanged: {
...
moved = true;
}
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D5490
To: leszeklesner, broulik
Cc: anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5492: We don't have this dependency anymore
jgrulich added a comment. We still do need this, in flatpak backend this library is used on many places. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5492 To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner added a comment. In https://phabricator.kde.org/D5490#103049, @davidedmundson wrote: > Yes, and you have this boolean separately for each delegate. > > So I can see how this supresses that initial selection in your bug report; but surely it will also supress every other normal case after that. > > When we move from one delegate to another the first time from the point of view of the delegate we're moving into: > > you get an onContainsMouseChanged - _moved is falsed. We set it to true, but otherwise do nothing > we get a onPositionChanged - we set _moved to true > > > We're not going to get another onContainsMouseChanged unless there's a bug in Qt. Yeah you are right. Upon testing I noticed that I need to hover twice over an item to actually highlight it. Hmm... so we need to place the _moved outside the delegate that should do it REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
davidedmundson added a comment. Yes, and you have this boolean separately for each delegate. So I can see how this supresses that initial selection in your bug report; but surely it will also supress every other normal case after that. When we move from one delegate to another the first time from the point of view of the delegate we're moving into: you get an onContainsMouseChanged - _moved is falsed. We set it to true, but otherwise do nothing we get a onPositionChanged - we set _moved to true We're not going to get another onContainsMouseChanged unless there's a bug in Qt. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5492: We don't have this dependency anymore
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D5492 AFFECTED FILES CMakeLists.txt To: apol, jgrulich Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5409: Queue some connections which cannot be autodetected
This revision was automatically updated to reflect the committed changes. Closed by commit R134:639bf33c0192: Queue some connections which cannot be autodetected (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5409?vs=13386&id=13566#toc REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5409?vs=13386&id=13566 REVISION DETAIL https://phabricator.kde.org/D5409 AFFECTED FILES libdiscover/backends/KNSBackend/KNSBackend.cpp libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp To: leinir, #discover_software_store, apol Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5409: Queue some connections which cannot be autodetected
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Go for it, let's see how it goes. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5409 To: leinir, #discover_software_store, apol Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner added a comment. In https://phabricator.kde.org/D5490#103036, @davidedmundson wrote: > Yes, I can see what the code is doing, but I don't see how that means it works. > > > will be then set to true so that when you move the mouse on an item onContainsMouseChanged is called again and because __moved is now true sets the index accordingly. > > When you move a mouse on an item (without leaving and entering again) why would onContainsMouseChanged be called again - unless you exited and left again. You need to hover over another item in the result list thats true. Otherwise it would not be called again and thus not highlight anything. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
davidedmundson added a comment. Yes, I can see what the code is doing, but I don't see how that means it works. > will be then set to true so that when you move the mouse on an item onContainsMouseChanged is called again and because __moved is now true sets the index accordingly. When you move a mouse on an item (without leaving and entering again) why would onContainsMouseChanged be called again - unless you exited and left again. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5382: Improve password dialogs
This revision was automatically updated to reflect the committed changes. Closed by commit R116:e5574b458abb: Improve password dialogs (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5382?vs=13317&id=13565 REVISION DETAIL https://phabricator.kde.org/D5382 AFFECTED FILES kded/passworddialog.cpp kded/passworddialog.h kded/passworddialog.ui kded/secretagent.cpp vpn/openconnect/openconnectauth.ui vpn/ssh/sshauth.ui vpn/sstp/sstpauth.ui vpn/strongswan/strongswanauth.ui To: jgrulich, #vdg, #plasma, mart Cc: lukas, fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5382: Improve password dialogs
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R116 Plasma Network Management Applet BRANCH password-dialogs REVISION DETAIL https://phabricator.kde.org/D5382 To: jgrulich, #vdg, #plasma, mart Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Next Plasma LTS and openSUSE
Hi everyone, this is basically the same discussion as already took place for 5.8. According to distrowatch, it looks very much like we're currently the _only_ remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default. Not only has Ubuntu switched to GNOME, for openSUSE there's currently also a major fork in the road happening next: - openSUSE Tumbleweed will likely switch to having no default at all (user has to choose one) - openSUSE Leap _may_ switch to GNOME as it is the desktop in SUSE Linux Enterprise. The argument here is that SUSE has a desktop team that is paid to fix bugs, while this is not the case for the community-maintained KDE packages. It's obvious that this switch must not happen for various political reasons: - GNOME becomes the de-facto standard desktop (Fedora, Ubuntu, openSUSE) - This headline: "openSUSE switches default desktop after 10+ years, KDE not viable?" - openSUSE KDE users might think that the focus shifted away The only chance I can see avoiding the switch is by delivering a flawless experience for the next major release, which will be released roughly this time next year. So it would be perfect to have a 5.12 (?) LTS by then. The way the schedule aligned for Leap 42.2 with Plasma 5.8.2 was perfect, thanks for that again! Additionally, it would be great to have an Applications LTS as well, which would make a faster feature-release cycle alongside a slower LTS cycle possible. I'm aware that this is an awful situation to be in, but I hope that we can figure something out... The openSUSE KDE team -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.
Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 110 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 08:20:01 + Build duration: 27 min CHANGE SET Revision 1a26abe5b0e6af45eab95a6147c627793755e088 by hein: (Fix losing wallpaper selection when clicking "Apply".) change: edit wallpapers/image/imagepackage/contents/ui/config.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 (39%)CONDITIONAL 1634/5924 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 122/3247 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 856 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/856/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 08:19:36 + Build duration: 27 min CHANGE SET Revision e99f396713db6d13b0ba620df96b1513e1576f78 by kde: ([Notifications] Introduce "settings" action) change: edit applets/notifications/package/contents/ui/NotificationPopup.qml change: edit applets/notifications/package/contents/ui/NotificationItem.qml change: edit applets/notifications/package/contents/ui/Notifications.qml change: edit applets/notifications/package/contents/ui/NotificationDelegate.qml JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979 (39%)CONDITIONAL 1624/5952 (27%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 56/90 (62%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 (66%)CONDITIONAL 113/216 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 349/820 (43%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 122/3251 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
D5382: Improve password dialogs
fabianr added a comment. +1, other then the spacing mentioned above, I like the change. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D5382 To: jgrulich, #vdg, #plasma Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner added a comment. In https://phabricator.kde.org/D5490#103017, @davidedmundson wrote: > Copying my reply from RB, to keep this in one place: > > Sorry for being dim, but I don't understand how this is meant to work. Basically it should not set the currentIndex to index right after opening up the search results in krunner so it does not jump to the mouse position. __moved will be then set to true so that when you move the mouse on an item onContainsMouseChanged is called again and because __moved is now true sets the index accordingly. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
davidedmundson added a comment. Copying my reply from RB, to keep this in one place: Sorry for being dim, but I don't understand how this is meant to work. In order for __moved to be true in containsMouseChanged: You're either expecting to get a hoverMoveEvent followed by a hoverEnterEventOr you're expecting to get a hoverEnterEvent twice Those will only happen if you enter a delegate, leave and enter it again? What else would cause it? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5408: Don't forward keys until the recipient is ready
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c06013e88e4f: Don't forward keys until the recipient is ready (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5408?vs=13374&id=13562 REVISION DETAIL https://phabricator.kde.org/D5408 AFFECTED FILES src/controls/ScrollablePage.qml To: leinir, #kirigami, apol, mart Cc: plasma-devel, apol
D5490: Only follow mouse when moved (Fixes Bug #372635)
leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use a new variable __moved to detect if mouse moved and only change index if the mouse moved. This helps preventing index changes when only using keyboard to search something in milou and to not accidently start/open something you did not want (see bug report https://bugs.kde.org/show_bug.cgi?id=372635 ) In general the onEntered signal seems to be broken in Qt somehow as I could not make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the code using onEntered failed to work with onPositionChanged (I guess this also does not always set it to true). Hence I tried containsMouse which seems to work reliably at least on Qt 5.7.1. Tests are appreciated especially on other Qt versions. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 AFFECTED FILES lib/qml/ResultDelegate.qml To: leszeklesner, broulik Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5408: Don't forward keys until the recipient is ready
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5408 To: leinir, #kirigami, apol, mart Cc: plasma-devel, apol
D5408: Don't forward keys until the recipient is ready
mart accepted this revision. This revision now requires changes to proceed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5408 To: leinir, #kirigami, apol, mart Cc: plasma-devel, apol
D5378: Adding an option to show popular documents/apps for Kicker and Dash
This revision was automatically updated to reflect the committed changes. Closed by commit R119:87f4c65282b9: Adding an option to show popular documents/apps for Kicker and Dash (authored by ivan). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5378?vs=13509&id=13560 REVISION DETAIL https://phabricator.kde.org/D5378 AFFECTED FILES applets/kicker/package/contents/config/main.xml applets/kicker/package/contents/ui/ConfigGeneral.qml applets/kicker/package/contents/ui/main.qml applets/kicker/plugin/recentusagemodel.cpp applets/kicker/plugin/recentusagemodel.h applets/kicker/plugin/rootmodel.cpp applets/kicker/plugin/rootmodel.h To: ivan, mart, hein Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5378: Adding an option to show popular documents/apps for Kicker and Dash
hein accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D5378 To: ivan, mart, hein Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5239: [Plasma Windowed] Emit contextualActionsAboutToShow before showing them
This revision was automatically updated to reflect the committed changes. Closed by commit R120:27efb8b19577: [Plasma Windowed] Emit contextualActionsAboutToShow before showing them (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5239?vs=12964&id=13559 REVISION DETAIL https://phabricator.kde.org/D5239 AFFECTED FILES plasma-windowed/plasmawindowedview.cpp To: broulik, #plasma, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5333: [Plasma Windowed] Disable standard actions on SNI
This revision was automatically updated to reflect the committed changes. Closed by commit R120:71dda89bb80d: [Plasma Windowed] Disable standard actions on SNI (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5333?vs=13198&id=13558 REVISION DETAIL https://phabricator.kde.org/D5333 AFFECTED FILES plasma-windowed/plasmawindowedview.cpp To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5424: [Notifications] Introduce "settings" action
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e99f396713db: [Notifications] Introduce "settings" action (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5424?vs=13377&id=13556 REVISION DETAIL https://phabricator.kde.org/D5424 AFFECTED FILES applets/notifications/package/contents/ui/NotificationDelegate.qml applets/notifications/package/contents/ui/NotificationItem.qml applets/notifications/package/contents/ui/NotificationPopup.qml applets/notifications/package/contents/ui/Notifications.qml To: broulik, #vdg, #plasma, markg, mck182 Cc: fabianr, andreaska, mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5440: Fix losing wallpaper selection when clicking "Apply".
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a26abe5b0e6: Fix losing wallpaper selection when clicking "Apply". (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5440?vs=13440&id=13557 REVISION DETAIL https://phabricator.kde.org/D5440 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml To: hein, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5424: [Notifications] Introduce "settings" action
fabianr added a comment. I like the change, the text button was too striking. the icon is much better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5424 To: broulik, #vdg, #plasma, markg, mck182 Cc: fabianr, andreaska, mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5424: [Notifications] Introduce "settings" action
andreaska added a comment. look good to me +1 thanks for the improvement REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5424 To: broulik, #vdg, #plasma, markg, mck182 Cc: andreaska, mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
