D7201: Install required runtime for flatpakref if it's specified

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:224012fabcf2: Install required runtime for flatpakref if 
it's specified (authored by jgrulich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7201?vs=17871=17916

REVISION DETAIL
  https://phabricator.kde.org/D7201

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7207: Add virtual Scene::bufferPicture method

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c1892e6c0fd4: Add virtual Scene::xrenderBufferPicture 
method (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7207?vs=17897=17915

REVISION DETAIL
  https://phabricator.kde.org/D7207

AFFECTED FILES
  effects.cpp
  scene.cpp
  scene.h
  scene_xrender.cpp
  scene_xrender.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7214: Add virtual Scene::scenePainter method

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So far EffectsHandlerImpl directly accessed SceneQPainter::painter
  through a dynamic cast. If in future the QPainter based compositor should
  be moved into a plugin we cannot access it through a dynamic cast.
  
  To solve this problem the painter method is moved into Scene as
  a virtual method returning a sane default value.

BRANCH
  scene-qpainter

REVISION DETAIL
  https://phabricator.kde.org/D7214

AFFECTED FILES
  effects.cpp
  scene.cpp
  scene.h
  scene_qpainter.cpp
  scene_qpainter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

[Powerdevil] [Bug 383296] Powerdevil immediately discards xdg-screensaver inhibitions

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=383296

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from David Edmundson  ---


*** This bug has been marked as a duplicate of bug 381160 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 383296] New: Powerdevil immediately discards xdg-screensaver inhibitions

[Nicolas Frattaroli]

https://bugs.kde.org/show_bug.cgi?id=383296

Bug ID: 383296
   Summary: Powerdevil immediately discards xdg-screensaver
inhibitions
   Product: Powerdevil
   Version: 5.10.4
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: kdeb...@fratti.ch
  Target Milestone: ---

Steps to reproduce:

1. watch the log with `journalctl -x -f`
2. run `xdg-screensaver suspend 0xsomevalididhere`

powerdevil will do the following:

Aug 09 00:10:51 archbook org_kde_powerdevil[797]: powerdevil: Scheduling
inhibition from ":1.12" "0x5c1" with cookie 24 and reason "xdg-screensaver"
Aug 09 00:10:51 archbook org_kde_powerdevil[797]: powerdevil: Releasing
inhibition with cookie  24
Aug 09 00:10:51 archbook org_kde_powerdevil[797]: powerdevil: It was only
scheduled for inhibition but not enforced yet, just discarding it

mpv's current git HEAD relies on xdg-screensaver to suspend the lock screen, so
this is somewhat irritating.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7204: Use cached version isDir()

[Eike Hein]

hein added a comment.


  Hmm shouldn't we improve the caching in either KDirModel or FolderModel then? 
Working around a performance issue in the model in delegate code just feels so 
wrong. Any potential other user of FolderModel (e.g. future Plasma Mobile file 
manager) would  possibly have to know to do this too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7204

To: davidedmundson, mart
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7201: Install required runtime for flatpakref if it's specified

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  flatpakref-runtime

REVISION DETAIL
  https://phabricator.kde.org/D7201

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7181: [Task Manager] Elide context menu entries

[Eike Hein]

hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ContextMenu.qml:126
> +if (elided) {
> +item.action.text += "...";
> +}

We can't hard-code "...". Different locales use different characters for text 
elision (e.g. an actual ellipsis, not three dots).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7181

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7204: Use cached version isDir()

[Eike Hein]

hein added a comment.


  > model.isDir() does a full stat of a file.
  
  model.isDir() does indeed, but this uses model.isDir, which is a data role. 
The FolderView::data() implementation already uses a cache. The cache is 
inserted into the first time isDir() is called and evicted e.g. on item 
deletion. It normally shouldn't stat.
  
  This makes me wary of this patch because I don't want us to adopt an 
anti-pattern of caching model data as Qt Quick var copies. I expect Qt Quick to 
be smart enough to optimize model access.
  
  I assume you did this based on profiling? Maybe data() is broken?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7204

To: davidedmundson, mart
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7207: Add virtual Scene::bufferPicture method

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R108 KWin

BRANCH
  scene-render-buffer

REVISION DETAIL
  https://phabricator.kde.org/D7207

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7207: Add virtual Scene::bufferPicture method

[Martin Flöser]

graesslin updated this revision to Diff 17897.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Incorporated David's naming suggestion

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7207?vs=17895=17897

BRANCH
  scene-render-buffer

REVISION DETAIL
  https://phabricator.kde.org/D7207

AFFECTED FILES
  effects.cpp
  scene.cpp
  scene.h
  scene_xrender.cpp
  scene_xrender.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D3805: Per-activity favorites (Final, again?)

[Eike Hein]

hein added a comment.


  UI design note: Even though I'm nerdy enough to understand the checkbox 
stuff, sometimes I want to remove a favorite and spend two seconds of confusion 
looking for a Remove action ...

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7207: Add virtual Scene::bufferPicture method

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> scene.h:164
> + **/
> +virtual xcb_render_picture_t bufferPicture() const;
> +

IMHO, as this class is generic, yet the return type is very specific, the name 
should be reflect that and be
xrenderBufferPicture like effectsHandler has.

REPOSITORY
  R108 KWin

BRANCH
  scene-render-buffer

REVISION DETAIL
  https://phabricator.kde.org/D7207

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7207: Add virtual Scene::bufferPicture method

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  So far EffectsHandlerImpl directly accessed SceneXrender::bufferPicture
  through a dynamic cast. If in future the XRender based compositor should
  be moved into a plugin we cannot access it through a dynamic cast.
  
  To solve this problem the bufferPicture method is moved into Scene as
  a virtual method returning a sane default value.

REPOSITORY
  R108 KWin

BRANCH
  scene-render-buffer

REVISION DETAIL
  https://phabricator.kde.org/D7207

AFFECTED FILES
  effects.cpp
  scene.cpp
  scene.h
  scene_xrender.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7070: give wallpaper packages a comment

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1e9591ae400a: give wallpaper packages a comment (authored 
by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7070?vs=17558=17882

REVISION DETAIL
  https://phabricator.kde.org/D7070

AFFECTED FILES
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: sitter, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Minutes Monday Plasma Hangout

[Bhushan Shah]

Sorry for delayed note-sending, attached logs and notes

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
2017-08-07 15:31:47 <@bshah> meeting?
2017-08-07 15:32:02  meetng!
2017-08-07 15:32:27 <@bshah> notmart: d_ed: kbroulik: meeting time!
2017-08-07 15:32:32  here
2017-08-07 15:33:17 <@bshah> alright.. notmart starts then
2017-08-07 15:33:25  ok
2017-08-07 15:33:35  * kirigami toolbar component: fixing issues when 
transitioning between single and multiple column mode, experimenting ways to 
put extra custom widgets in that toolbar
2017-08-07 15:33:36  * kirigami, high dpi fixes, correct sizing for 
handles and action buttons, better rendering of labels on non integer scaling
2017-08-07 15:33:38  * desktop qqc theme: better rendering of text on 
non integer scaling
2017-08-07 15:33:39  * wayland: start of implementation of the 
xdg_foreign protocol
2017-08-07 15:33:41  * wayland: investigating a crash in ping in the 
xdgv6 protocol, leading to another bug uncovering
2017-08-07 15:33:42  * fixed undeterministic ordering in modules order
2017-08-07 15:33:44  * patch for bug in notifications with multi 
screen https://phabricator.kde.org/D7127
2017-08-07 15:33:44  Diff 7127 "ignore spurious resize events to 
empty sizes" [Needs Revision] https://phabricator.kde.org/D7127
2017-08-07 15:34:03  "desktop qqc theme: better rendering of text on 
non integer scaling" ← how's that?
2017-08-07 15:35:41  sadly, atm is just by using distance filed 
rendering on non integer scalings
2017-08-07 15:35:47  right
2017-08-07 15:36:04  which, doesn't look gorgeous, but at least not 
completely garbled
2017-08-07 15:36:28  there's a few QtQuick scaling changes recently
2017-08-07 15:36:32  which might help
2017-08-07 15:36:43  in 5.9 branch?
2017-08-07 15:37:09  (which makes me think, still no answer of the 
parenting stuff take 2 in qt, meh)
2017-08-07 15:38:18 <@bshah> I guess it's turn of kbroulik then
2017-08-07 15:38:23  * Did some model cleanup in FolderView (Pro tip: 
implementing setData in QAIM makes "model" magic property writable from QML)
2017-08-07 15:38:36  * Various KIOSK-related fixes for GHNS, 
"download new wallpaper" and "download new plasmoids" ghns button is now hidden 
if "ghns" restriction applies
2017-08-07 15:38:44  * Fixed a visual glitch when 
expanding/collapsing treeviews in Breeze widget style
2017-08-07 15:38:54  * Fixed URLs in notifications not clickable. 
Selecting text inside them is still broken but I don't think we can fix that 
(we have couple conflicting interactions there: clicking links, selecting text, 
triggering the default action, flicking, ..)
2017-08-07 15:39:04  * I might look into hybrid suspend support, if I 
can figure out how to make Logind allow "CanHybridSleep". I think the 
intermediate solution would be to just add a new entry in kickoff and 
powerdevil, since it's not something that is enabled by default in most 
distros, no? A proper solution would perhaps be to add an option to PowerDevil 
to have suspend-to-ram or suspend-to-disk instead do HybridSuspend?
2017-08-07 15:39:05  kbroulik: you mean in the delefate model.roleName 
= "blah" will call setData?
2017-08-07 15:39:48  yes
2017-08-07 15:39:52  neat
2017-08-07 15:40:14  pretty cool, works also across 
qsortfilterproxymodels etc
2017-08-07 15:40:27  makes for really neat code, and saves custom 
Q_INVOKABLE setFoo(int index, ...)
2017-08-07 15:40:46  sometimes even a pleasant surprise, go figure :)
2017-08-07 15:41:40 <@bshah> if kbroulik is done it's turn of d_ed
2017-08-07 15:42:09  I've been away most of last week, I've written up 
notes of my time at Guadec, which I think are worth reading
2017-08-07 15:42:22  Also we /possibly/ have a lead on that stupid 
AnimationFinished crash
2017-08-07 15:42:43  that uncontrolledAnimationFinished?
2017-08-07 15:42:43  wa reading and writing some questions as followup
2017-08-07 15:42:50  kbroulik: yes that
2017-08-07 15:42:52  ooh, nice, what is it?
2017-08-07 15:42:58  I'm trying to make a smaller test.
2017-08-07 15:43:32  we have a valgrind trace of a double free, when we 
have nested grouped animations; it seems to be us disabling one of the 
animations mid-animation.
2017-08-07 15:43:46  so when the group finishes it deletes an already 
deleted thing
2017-08-07 15:44:31  Did someone bisect already as it's IIRC a 
regression?
2017-08-07 15:44:47  oh damn
2017-08-07 15:44:49  i forgot the meeting
2017-08-07 15:44:54  i'm here too
2017-08-07 15:44:55  I will when I have a reproducible case
2017-08-07 15:45:12 * Sho_ even has an exciting item
2017-08-07 15:45:16  talk of Qt regressions, I am also somewhere on the 
slideshow leaking huge amounts of memory
2017-08-07 15:45:49  we're meant to go "render window 1, render window 2, 
all windows are done I'll release resources"
2017-08-07 15:46:07  somehow we go "render window 1, render window 2, oh 
look! window 1 needs rendering, I'll 

D7070: give wallpaper packages a comment

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master-comments

REVISION DETAIL
  https://phabricator.kde.org/D7070

To: sitter, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[David Faure]

dfaure added a comment.


  Ah, this key is already used, for applications? I wasn't aware, if that's the 
case.
  
  Hmm, then maybe better keep the same key indeed.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8e7e96db2683: Summary: change user visible text to use 
modern branding (authored by jriddell).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7202?vs=17878=17880

REVISION DETAIL
  https://phabricator.kde.org/D7202

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake
  startkde/startplasmacompositor.cmake

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7205: Don't require X11 to save font DPI to config

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  startplasma (wayland) uses the font DPI value from this config.
  We don't require X11 to show a spinbox and save it to a file.
  
  The part that calls into xrdb is still guarded.

TEST PLAN
  Compiled
  Compiled with #undef HAVE_X11 added after including config-workspace.
  Still had the UI setting

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7205

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell added a comment.


  ack

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7204: Use cached version isDir()

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7204

To: davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  and comment at the top of startplasma.cmake please.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell updated this revision to Diff 17878.
jriddell added a comment.


  - change comment to current branding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7202?vs=17877=17878

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake
  startkde/startplasmacompositor.cmake

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell added a comment.


  I don't see any user visible strings in the startplasma/startplasmacompositor 
scripts, it's just that one comment

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell updated this revision to Diff 17877.
jriddell added a comment.


  - change comment to current branding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7202?vs=17872=17877

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasmacompositor.cmake

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7204: Use cached version isDir()

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Micro-optimisation.
  
  model.isDir() does a full stat of a file.
  We hover a lot, may as well use a cached version of the variable.
  
  CCBUG: 379994

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7204

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  any changes to this file should be mirrored in the wayland version (split as 
either startplasma/startplasmacompositor)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7185: Set a default font DPI if not set

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7cfdd9a5260b: Set a default font DPI if not set (authored 
by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7185?vs=17828=17874

REVISION DETAIL
  https://phabricator.kde.org/D7185

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7200: Determine if we should use Qt scaling based on env var

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0fa58f0abc71: Determine if we should use Qt scaling based 
on env var (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7200?vs=17869=17873

REVISION DETAIL
  https://phabricator.kde.org/D7200

AFFECTED FILES
  shell/main.cpp
  startkde/startplasma.cmake

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell added a reviewer: Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7202

To: jriddell, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7202: change user visible text to use modern branding

[Jonathan Riddell]

jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  change user visible text to use modern branding

TEST PLAN
  run it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7202

AFFECTED FILES
  startkde/startkde.cmake

To: jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7200: Determine if we should use Qt scaling based on env var

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  ok, let's go with this verison

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7200

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7201: Install required runtime for flatpakref if it's specified

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If one wants to install using flatpakref which requires a runtime we should 
check
  if it's installed and provided by the flatpakref file to automatically 
install it as
  well, otherwise user ends up with just application installed but not working 
because
  of missing runtime.

REPOSITORY
  R134 Discover Software Store

BRANCH
  flatpakref-runtime

REVISION DETAIL
  https://phabricator.kde.org/D7201

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7f9e7c854936: Terminology fixes in KCMs: 
KDE-as-the-desktop -> Plasma (authored by ltoscano).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6469?vs=16149=17870

REVISION DETAIL
  https://phabricator.kde.org/D6469

AFFECTED FILES
  kcms/autostart/advanceddialog.cpp
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.desktop
  kcms/componentchooser/emailclientconfig_ui.ui
  kcms/desktoppaths/globalpaths.cpp
  kcms/fonts/fonts.cpp
  kcms/keyboard/kcm_keyboard.ui
  kcms/keyboard/kcmmisc.cpp
  kcms/knotify/knotify.cpp

To: ltoscano, davidedmundson
Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7200: Determine if we should use Qt scaling based on env var

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KWindowSystem::platform() cannot be used before QApplication is
  constructed.
  
  QCoreApplication::setAttribute needs to be called before QApplication is
  constructed.
  
  We need a different method. I've used an explicit new env variable so
  that some users can also opt in to use this when on X.

TEST PLAN
  Logged in. 
  Plasma panels all work. Look to be native resolution.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7200

AFFECTED FILES
  shell/main.cpp
  startkde/startplasma.cmake

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7188: Use Qt scaling in Plamsa

[David Edmundson]

davidedmundson added a comment.


  @notmart
  
  If this was generic code, we should care about that. 
  For plasmashell we can be sure we're launched via startplasma and have the 
env vars that set. If they're not there, it's the user's fault for being weird.
  
  I might make it an expliticit env var and sell it as a feature so we can 
re-test X easier.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7188

To: davidedmundson, #plasma, mart
Cc: graesslin, cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6899#133625, @dfaure wrote:
  
  > "Show" is a bit of a historical name here, this isn't about showing apps in 
a menu...
  >
  > X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
  >
  > Looks good otherwise.
  
  
  that would be a new key, would you prefer that version?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7188: Use Qt scaling in Plamsa

[Marco Martin]

mart added a comment.


  wonder if we'll have to end up adding a command line switch for it? :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7188

To: davidedmundson, #plasma, mart
Cc: graesslin, cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7188: Use Qt scaling in Plamsa

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D7188#133604, @graesslin wrote:
  
  > You could check for env variable QT_QPA_PLATFORM
  
  
  what about when is undefined but platform undetected?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7188

To: davidedmundson, #plasma, mart
Cc: graesslin, cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Fwd: Windows Manager architecture document being discussed within AGL

[Marco Martin]

really they require Weston? (which, was intended pretty much as a proof of 
concept)

On Monday 07 August 2017 10:47:44 Agustin Benito wrote:
> Dear Plasma devs,
> 
> this document might be of interest. Please read below for context.
> 
> 
> Agustin Benito (toscalix)
> KDE eV member
> Profile: http://es.linkedin.com/in/toscalix
> 
> 
> 
> -- Forwarded message --
> From: Agustin Benito (toscalix) 
> Date: Mon, Aug 7, 2017 at 9:46 AM
> Subject: Windows Manager architecture document being discussed within AGL
> To: kde-embed...@kde.org, Volker Krause 
> Cc: Marco Martin , Sebastian Kügler
> , Richard Dale 
> 
> 
> Hi,
> 
> for those of you interested in the automotive industry, I attach the
> Windows Manager (HMI) architecture document draft that will be
> discussed within the AGL Graphics expert group. This document has been
> created by Toyota.
> 
> Volker, where can we upload it to have it future references? I assume
> there will be several revisions of the document as outcome of the
> discussion process.
> 
> It is a heavy doc (3Mb)
> 
> Best regards
> 
> Agustin Benito (toscalix)
> KDE eV member
> Profile: http://es.linkedin.com/in/toscalix

-- 
Marco Martin

D7184: [Color Picker] Add drag pixmap for color

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:3e63fa62e629: [Color Picker] Add drag pixmap for color 
(authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7184?vs=17825=17865

REVISION DETAIL
  https://phabricator.kde.org/D7184

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[David Faure]

dfaure added a comment.


  "Show" is a bit of a historical name here, this isn't about showing apps in a 
menu...
  
  X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
  
  Looks good otherwise.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas