date:20171025

D8460: Refactor kcm_input to enable having multiple backends.

2017-10-25 Thread Roman Gilg

subdiff added a comment.


  A kapplymousetheme binary is for sure only needed in the context of X. I 
would therefore not write it by the tools of the backend plugin system, but 
leave it as it is and put it in the X11 backend directory (and put its cmake 
code into the X11 cmake file). That will reduce the necessary linking for the 
binary.

INLINE COMMENTS

> mouse.cpp:82
>  MouseConfig::MouseConfig(QWidget *parent, const QVariantList )
> -  : KCModule(parent, args)
> +  : KCModule(parent, args), backend(MouseBackend::implementation())
>  {

Break into two lines.

> mousebackend.cpp:32
> +//There are multiple possible backends
> +if (KWindowSystem::isPlatformX11()) {
> +static QThreadStorage backend;

Until there is a full backend plugin for Wayland the X backend needs to be used 
on Wayland as well for Xwayland stuff (see the `extern "C"` method).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8485: Fix viewport for screenshot on multiple screens

2017-10-25 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8485

To: kpiwowarski, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8485: Fix viewport for screenshot on multiple screens

2017-10-25 Thread Kamil Piwowarski

kpiwowarski created this revision.
kpiwowarski added reviewers: KWin, Plasma.
kpiwowarski added a project: KWin.
Restricted Application edited projects, added Plasma; removed KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  https://phabricator.kde.org/D8479 fixes viewport for real hardware, but there 
is still problem with screenshots. This patch fixes that.

TEST PLAN
  - Have three monitors (like in bug 385655)
  - Press PrtSc and then Enter
  - Screenshot is ok
  
  Before: 
  F5450056: Screenshot_20171025_232900.png 

  After:
  F5450058: Screenshot_20171026_010701.png 


REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8485

AFFECTED FILES
  libkwineffects/kwinglutils.cpp

To: kpiwowarski, #kwin, #plasma
Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-25 Thread Sebastian Krzyszkowiak

dos added a comment.


  F5450052: breeze-gtk-before.png 
  
  F5450051: breeze-gtk-after.png 
  
  There you are :) Firefox, System Settings and gedit, before and after.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

To: dos, #breeze, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-25 Thread Aleix Pol Gonzalez

apol added a comment.


  In such reviews a before & after screenshot works great. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

To: dos, #breeze, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-10-25 Thread Henrik Fehlauer

rkflx added a comment.


  In https://phabricator.kde.org/D8361#159058, @rpelorosso wrote:
  
  > I'm fairly new to this process. As this hasn't gotten any attention, is 
there any other group that might want to review this beside VDG?
  
  
  In general you could use `git blame` locally or in Phabricator 

 and have a look at the commit history 
 for non-trivial 
commits. You'll probably find you could add the same reviewer as I added to 
your other Diff (https://phabricator.kde.org/D8232).

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8361

To: rpelorosso, #vdg, broulik, aacid
Cc: rkflx, aacid, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8479: Fix viewport on vertically stacked monitors

2017-10-25 Thread David Edmundson

davidedmundson added a comment.


  > Could you also adjust the virtual platform? I think it should also have the 
viewport adjustments.
  
  It doesn't (currently) use per-screen rendering so there's nothing 
(currently) to adjust.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8479

To: davidedmundson, #plasma, graesslin
Cc: kpiwowarski, graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
mart

D8479: Fix viewport on vertically stacked monitors

2017-10-25 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5d7e22e5dcf8: Fix viewport on vertically stacked monitors 
(authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8479?vs=21326=21341

REVISION DETAIL
  https://phabricator.kde.org/D8479

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/x11/windowed/egl_x11_backend.cpp

To: davidedmundson, #plasma, graesslin
Cc: kpiwowarski, graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
mart

D8479: Fix viewport on vertically stacked monitors

2017-10-25 Thread Kamil Piwowarski

kpiwowarski added a comment.


  This patch fixes my bug (mentioned by @graesslin) 
https://bugs.kde.org/show_bug.cgi?id=385655
  
  Thank you, I hope now I will be able to use Wayland session for everyday work 
<3

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8479

To: davidedmundson, #plasma, graesslin
Cc: kpiwowarski, graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
mart

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Ivan Čukić

ivan added inline comments.

INLINE COMMENTS

> cryptodude wrote in directorypairchooserwidget.cpp:90
> I didn't consider it an issue as its just data that they would never ever 
> interact with. People never cared where their post-it notes etc are stored.
> 
> Making it disabled will more likely be the cause of people not being able to 
> figure out why its disabled. And they start to look for a way to enable it. 
> Causing more confusion.
> 
> How does replacing it with a text label sound?

Fair enough. Leave it hidden, and if we get complaints, we can change it later.

> cryptodude wrote in directorypairchooserwidget.cpp:123
> No, the Qt one includes the appname. So I'd get;
> 
> > ~/.local/share/kded5/
> 
> Are the Windows/Mac platforms relevant at all? If not, I'd just like to keep 
> it the way it is.

Can you try `QStandardPaths::GenericDataLocation` and append "/plasma-vault"? 
(if we are changing the path, let's use the full name of product just in case 
other DE people decide to call something of theirs 'vault')

> QStandardPaths::GenericDataLocation
>  Returns a directory location where persistent data shared across 
> applications can be 
>  stored. This is a generic value. The returned path is never empty.

Windows and Mac are not relevant at the moment, but I'd still like it more if 
we relied on Qt implementation instead of simulating what QSP does.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Crypto Dude

cryptodude added a comment.


  > I'm not sure the users will like what you did with encfs, but we can at 
least test the waters. :)
  
  Sounds good.
  
  I know for every feature you take away from users they will be a user that 
will complain about it. No doubt. I hope we can stand by the position that a 
wizard that allows a user to set up a vault that is easy to spoof or break is a 
broken wizard. Not a missing feature.

INLINE COMMENTS

> ivan wrote in directorypairchooserwidget.cpp:90
> What do you think about having it disabled instead of hidden?
> 
> (I'm expecting bug reports "no information about the data location" if it 
> just gets hidden - if it is just disabled, at least people will know where it 
> is)

I didn't consider it an issue as its just data that they would never ever 
interact with. People never cared where their post-it notes etc are stored.

Making it disabled will more likely be the cause of people not being able to 
figure out why its disabled. And they start to look for a way to enable it. 
Causing more confusion.

How does replacing it with a text label sound?

> ivan wrote in directorypairchooserwidget.cpp:123
> Replace this with http://doc.qt.io/qt-5/qstandardpaths.html (I think you need 
> QStandardPaths::AppLocalDataLocation)

No, the Qt one includes the appname. So I'd get;

> ~/.local/share/kded5/

Are the Windows/Mac platforms relevant at all? If not, I'd just like to keep it 
the way it is.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

2017-10-25 Thread Nicolas Fella

nicolasfella added a comment.


  https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

2017-10-25 Thread Crypto Dude

cryptodude added a comment.


  Ok, I see the confusion.  The name of this pull request uses the word 
'default' and that confused everyone.
  
  What I meant with that is that the User Interface should respond to the 
packager picking a default. The UI itself does not pick a default. It just 
avoids showing an option that isn't actually an option for the user.
  
  So if you have a neon install and the packager only auto-installs CryFS, then 
we simply auto-select CryFS for him. Making the UI simpler.
  In the rare case where a user finds multiple backends installed, then I added 
a priority to start the user with the highest prio.
  
  The word "default" here is just respecting the distros choice.
  
  > p.s. BTW, do you have push access? If not, and you plan to help around with 
Vault (which would be great), you should probably ask for it.
  
  No, I don't. Can you point out how that works? I'm rather new to the KDE 
development process.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Ivan Čukić

ivan added a comment.


  This one is almost mergeable.
  
  I'm not sure the users will like what you did with encfs, but we can at least 
test the waters. :)

INLINE COMMENTS

> directorypairchooserwidget.cpp:90
> +d->ui.editDevice->setVisible(false);
> +d->ui.labelDevice->setVisible(false);
> +} else {

What do you think about having it disabled instead of hidden?

(I'm expecting bug reports "no information about the data location" if it just 
gets hidden - if it is just disabled, at least people will know where it is)

> directorypairchooserwidget.cpp:123
>  {
> -const auto name = payload[KEY_NAME].toString();
> +QString xdgHomeString = QFile::decodeName(qgetenv("XDG_DATA_HOME"));
> +if (xdgHomeString.isEmpty())

Replace this with http://doc.qt.io/qt-5/qstandardpaths.html (I think you need 
QStandardPaths::AppLocalDataLocation)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-25 Thread Sebastian Krzyszkowiak

dos added reviewers: Breeze, Plasma.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

To: dos, #breeze, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-25 Thread Sebastian Krzyszkowiak

dos created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: dos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8397: Align logout screen action buttons to the top

2017-10-25 Thread Christoph Feck

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3e495b220fd0: Align logout screen action buttons to the 
top (authored by aleksejshilin, committed by cfeck).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8397?vs=21047=21330

REVISION DETAIL
  https://phabricator.kde.org/D8397

AFFECTED FILES
  lookandfeel/contents/logout/LogoutButton.qml

To: aleksejshilin, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8479: Fix viewport on vertically stacked monitors

2017-10-25 Thread Martin Flöser

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  > Nested wayland only seems to support one screen?
  
  There's a command line switch and it could be that only the xcb platform 
supports it.
  
  We have another bug report about three screens not working if the middle one 
is smaller. I expect that to be fixed as well, but if you could test that would 
be awesome (I don't have any system with three connectors). Also two screens 
did not work if they have different size and are aligned on bottom. Given your 
description that should also be fixed, but might be worth testing as well.
  
  Please push to 5.11 branch instead of master. Thanks for fixing, I had that 
on my mental note for looking into once I'm back.
  
  Could you also adjust the virtual platform? I think it should also have the 
viewport adjustments.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8479

To: davidedmundson, #plasma, graesslin
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart

D8479: Fix viewport on vertically stacked monitors

2017-10-25 Thread Aleix Pol Gonzalez

apol added a comment.


  Tested and works for me.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8479

To: davidedmundson, #plasma
Cc: apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-25 Thread Nathaniel Graham

ngraham edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: subdiff, ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8473: Modernize code. Use nullptr where it's possible

2017-10-25 Thread Laurent Montel

mlaurent added inline comments.

INLINE COMMENTS

> broulik wrote in mimetypesmodel.cpp:109
> Isn't the compiler smart ehough?

Really I don't know if compiler is able to resolve it when it's not a const 
variable.
If you told me that gcc/clang is able to do it ok :)
I can trust you if you told me it's not a problem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8473

To: mlaurent, hein
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8476: qPort to new connect api + use const'ref

2017-10-25 Thread Laurent Montel

mlaurent updated this revision to Diff 21324.
mlaurent added a comment.


  - Perhaps that qml doesn't support const QUrl &

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8476?vs=21315=21324

BRANCH
  port_to_new_connect_api

REVISION DETAIL
  https://phabricator.kde.org/D8476

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8476: qPort to new connect api + use const'ref

2017-10-25 Thread Laurent Montel

mlaurent added inline comments.

INLINE COMMENTS

> broulik wrote in foldermodel.h:256
> Did you check whether QML can cope with `const &`? The `urls` is used in an 
> `onMove` QML handler (I recall it not handling `const *` well)

I didn't see an error here, but perhaps I didn't test action which use this 
signal.
To be safe I will exclude this part of patch until I am sure that it's ok.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8473: Modernize code. Use nullptr where it's possible

2017-10-25 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> mimetypesmodel.cpp:109
>  {
> -for (int i = 0; i < m_mimeTypesList.size(); i++) {
> +for (int i = 0, total = m_mimeTypesList.size(); i < total; ++i) {
>  if (m_mimeTypesList.at(i).name() == name) {

Isn't the compiler smart ehough?

> previewpluginsmodel.cpp:112
>  QStringList list;
> -for (int i =0; i < m_checkedRows.size(); ++i) {
> +for (int i =0, total = m_checkedRows.size(); i < total; ++i) {
>  if (m_checkedRows.at(i)) {

Space after `=`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8473

To: mlaurent, hein
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8477: Use directly hasLinkType()

2017-10-25 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3b3c83c14971: Use directly hasLinkType() (authored by 
mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8477?vs=21317=21320

REVISION DETAIL
  https://phabricator.kde.org/D8477

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8478: We already depend against 5.34

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8478

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8478: We already depend against 5.34

2017-10-25 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9f99b4a3c7e8: We already depend against 5.34 (authored by 
mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8478?vs=21319=21321

REVISION DETAIL
  https://phabricator.kde.org/D8478

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8478: We already depend against 5.34

2017-10-25 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove_check

REVISION DETAIL
  https://phabricator.kde.org/D8478

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8477: Use directly hasLinkType()

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8477

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8477: Use directly hasLinkType()

2017-10-25 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use_hasLinkType

REVISION DETAIL
  https://phabricator.kde.org/D8477

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8476: qPort to new connect api + use const'ref

2017-10-25 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> foldermodel.h:256
>  void requestRename() const;
> -void move(int x, int y, QList urls);
> +void move(int x, int y, const QList );
>  void popupMenuAboutToShow(KIO::DropJob *dropJob, QMimeData 
> *mimeData, int x, int y);

Did you check whether QML can cope with `const &`? The `urls` is used in an 
`onMove` QML handler (I recall it not handling `const *` well)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8477: Use directly hasLinkType()

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use_hasLinkType

REVISION DETAIL
  https://phabricator.kde.org/D8477

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8478: We already depend against 5.34

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove_check

REVISION DETAIL
  https://phabricator.kde.org/D8478

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8476: qPort to new connect api + use const'ref

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8476: qPort to new connect api + use const'ref

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  port_to_new_connect_api

REVISION DETAIL
  https://phabricator.kde.org/D8476

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8475: Avoid to make loop twice. Return -1 if we don't find it

2017-10-25 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aac3db7a4d3c: Avoid to make loop twice. Return -1 if we 
dont find it (authored by mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8475?vs=21312=21314

REVISION DETAIL
  https://phabricator.kde.org/D8475

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8287: Default X font DPI to 96 on wayland

2017-10-25 Thread David Edmundson

davidedmundson closed this revision.
davidedmundson added a comment.


  Merged

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8287

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8475: Avoid to make loop twice. Return -1 if we don't find it

2017-10-25 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  optimize_search_indexforurl

REVISION DETAIL
  https://phabricator.kde.org/D8475

To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

2017-10-25 Thread Andres Betts

abetts added a comment.


  I like this, I would even place the "title" to align with "location" and push 
the combobox where it says "none" to align with the radial buttons.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8424

To: marten, #plasma, hein
Cc: abetts, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D8475: Avoid to make loop twice. Return -1 if we don't find it

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  optimize_search_indexforurl

REVISION DETAIL
  https://phabricator.kde.org/D8475

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8475: Avoid to make loop twice. Return -1 if we don't find it

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8475

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8474: Reserve size in container

2017-10-25 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a4205b4ef4e0: Reserve size in container (authored by 
mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8474?vs=21310=21311

REVISION DETAIL
  https://phabricator.kde.org/D8474

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8474: Reserve size in container

2017-10-25 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reserve_info

REVISION DETAIL
  https://phabricator.kde.org/D8474

To: mlaurent, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8474: Reserve size in container

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8474

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8474: Reserve size in container

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  compile/test

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reserve_info

REVISION DETAIL
  https://phabricator.kde.org/D8474

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Plasma 5.8.8 LTS

2017-10-25 Thread Jonathan Riddell

Plasma 5.8.8 LTS fixes some crashers

https://www.kde.org/announcements/plasma-5.8.8.php

D8473: Modernize code. Use nullptr where it's possible

2017-10-25 Thread Laurent Montel

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Remove extra ';'
  Use override everywhere as we already use it in some part of code
  Fix potential crash when we delete a pointer

TEST PLAN
  build/using :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize_folderplugin

REVISION DETAIL
  https://phabricator.kde.org/D8473

AFFECTED FILES
  containments/desktop/plugins/folder/directorypicker.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/labelgenerator.cpp
  containments/desktop/plugins/folder/mimetypesmodel.cpp
  containments/desktop/plugins/folder/mimetypesmodel.h
  containments/desktop/plugins/folder/placesmodel.h
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/previewpluginsmodel.cpp
  containments/desktop/plugins/folder/previewpluginsmodel.h
  containments/desktop/plugins/folder/rubberband.h
  containments/desktop/plugins/folder/shortcut.h
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8473: Modernize code. Use nullptr where it's possible

2017-10-25 Thread Laurent Montel

mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8473

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: System Settings KCM Tidying

2017-10-25 Thread Marco Martin

On Wed, Oct 25, 2017 at 3:14 PM, David Edmundson
 wrote:
> M112 is the collection of literally all of them.

err, yah, I mean the cursor one

--
Marco Martin

Re: System Settings KCM Tidying

2017-10-25 Thread David Edmundson

M112 is the collection of literally all of them.

D8358: Use QActions directly in menu

2017-10-25 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:f65b9c8719c1: Use QActions directly in menu (authored by 
broulik).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8358?vs=20944=21306

REVISION DETAIL
  https://phabricator.kde.org/D8358

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml

To: broulik, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-25 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8445?vs=21232=21305

REVISION DETAIL
  https://phabricator.kde.org/D8445

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D1029: [FolderView] Fix Location config placement

2017-10-25 Thread Kai Uwe Broulik

broulik abandoned this revision.
broulik added a comment.


  Superseded by https://phabricator.kde.org/D8424

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1029

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: System Settings KCM Tidying

2017-10-25 Thread Marco Martin

On martedì 24 ottobre 2017 16:51:19 CEST David Edmundson wrote:
> Hopefully we can base Plasma 5.13 off Qt5.10. Probably deserves a different
> thread in a few months.
> 
> Personally, I want to start wtih M111, it's already in QtQuick, and has the
> best reward to effort ratio.
> It also defines some components that will get re-used elsewhere. Even if we
> only get some of the changes in.

I am already working on M112, for which i am pretty much finished with the 
components...
I could put them in an import into plasma-workspace (not the kcm, just the 
base view and delegate which would get reimplemented)
so both kcms from workspace and desktop would be able to use it (and i think 
shouldbe a safe assumption that kcms woulddepend from plasma-workspace?)

-- 
Marco Martin

D8469: Use XDG_DATA_DIR and security fix

2017-10-25 Thread Crypto Dude

cryptodude created this revision.
cryptodude added reviewers: ivan, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The EncFS has security issues when the encrypted files are shared
  in the open. For instance on a usb-pendrive or a shared drive.
  
  Only when the user picks EncFS we then continue to not allow the user to pick 
his 'device' directory where the encrypted files would go, just store this on 
the XDG_DATA_DIR which is defined as;
   the base directory relative to which user specific data files should be 
stored
  
  Users can continue picking their datadir just fine when they pick the CryFS 
and other future backends.
  
  BUG:385982

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

AFFECTED FILES
  kded/ui/directorypairchooserwidget.cpp
  kded/ui/directorypairchooserwidget.h
  kded/ui/vaultcreationwizard.cpp

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

2017-10-25 Thread Crypto Dude

cryptodude updated this revision to Diff 21302.
cryptodude added a comment.


  I tested this version to do what I described.
  
  Please review and/or merge.
  
  The point about EncFS being a security issue when saved on something like a 
USB pen is a separate commit I'll create a different differential for.

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8449?vs=21236=21302

REVISION DETAIL
  https://phabricator.kde.org/D8449

AFFECTED FILES
  kded/ui/backendchooserwidget.cpp
  kded/ui/backendchooserwidget.h
  kded/ui/backendchooserwidget.ui
  kded/ui/vaultcreationwizard.cpp

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8466: Show shortcuts in menus

2017-10-25 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:59d0ad3064bb: Show shortcuts in menus (authored by 
broulik).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8466?vs=21293=21301

REVISION DETAIL
  https://phabricator.kde.org/D8466

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8468: Allow applications to be somewhat convergent on a desktop-y system

2017-10-25 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d0f3941a4d7f: Allow applications to be somewhat 
convergent on a desktop-y system (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8468?vs=21298=21299

REVISION DETAIL
  https://phabricator.kde.org/D8468

AFFECTED FILES
  src/controls/ApplicationWindow.qml
  src/styles/org.kde.desktop/ApplicationWindow.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8468: Allow applications to be somewhat convergent on a desktop-y system

2017-10-25 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8468

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8468: Allow applications to be somewhat convergent on a desktop-y system

2017-10-25 Thread Aleix Pol Gonzalez

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Doesn't hardcode the application to be wide at all times
  Gives some margin so that the application doesn't fold too soon

TEST PLAN
  Been using it for some days with Discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8468

AFFECTED FILES
  src/controls/ApplicationWindow.qml
  src/styles/org.kde.desktop/ApplicationWindow.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8435: Make sure the content of the SwipeListItem doesn't overlap the handle

2017-10-25 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4f3f83e2a95c: Make sure the content of the SwipeListItem 
doesnt overlap the handle (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8435?vs=21178=21295

REVISION DETAIL
  https://phabricator.kde.org/D8435

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml
  src/styles/org.kde.desktop/SwipeListItem.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8466: Show shortcuts in menus

2017-10-25 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D8466

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8466: Show shortcuts in menus

2017-10-25 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Since Qt 5.10 a new hint exists that we didn't set and so no shortcuts were 
shown in menus.

TEST PLAN
  Thanks Fabian for finding this, see also QTBUG-49435
  
  I now get shortcuts shown in context menus again.
  
  I'd say 5.11 branch, even though Qt 5.10 is not out yet it's due End of 
November.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D8466

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

2017-10-25 Thread Laurent Montel

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel

mlaurent marked an inline comment as done.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel

mlaurent updated this revision to Diff 21288.
mlaurent added a comment.


  - Don't use Q_FOREACH as it will be deprecated in the future

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8444?vs=21283=21288

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

2017-10-25 Thread Andras Mantia

amantia updated this revision to Diff 21287.
amantia added a comment.


  Use QStringLiteral and nullptr

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8447?vs=21284=21287

REVISION DETAIL
  https://phabricator.kde.org/D8447

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin_private_export.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

2017-10-25 Thread Eike Hein

hein accepted this revision.
hein added a comment.


  Thanks for working on this! We really need better test coverage in Plasma 
bits.
  
  I'm a little bit unhappy about littering headers with 
FOLDERPLUGIN_TESTS_EXPORT, but I guess it's the lesser evil of statically 
linking and building the code twice.
  
  The tests itself look like a good start.
  
  (Aside: If you have bigger plans for upcoming FV contributions, it'd be cool 
to sit down on IRC and talk a bit. I had a long conversation with Milian last 
month, I guess/hope he passed that info on.)

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

2017-10-25 Thread Andras Mantia

amantia updated this revision to Diff 21284.
amantia added a comment.


  Added copyright notice

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8447?vs=21281=21284

REVISION DETAIL
  https://phabricator.kde.org/D8447

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin_private_export.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Martin Flöser

graesslin added inline comments.

INLINE COMMENTS

> generator.cpp:550
> +
> +Q_FOREACH(KScreen::OutputPtr output, connectedOutputs) {
> +output->setEnabled(true);

Please don't use qforeach in new code as Qt might deprecate it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

2017-10-25 Thread Laurent Montel

mlaurent added inline comments.

INLINE COMMENTS

> folderplugin_private_export.h:1
> +#ifndef FOLDERPLUGIN_PRIVATE_EXPORT_H
> +#define FOLDERPLUGIN_PRIVATE_EXPORT_H

Missing copyright

> foldermodeltest.cpp:1
> +#include "foldermodeltest.h"
> +#include "foldermodel.h"

Missing copyright

> foldermodeltest.cpp:87
> +QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> +}

QStringLiteral(...).arg

> foldermodeltest.cpp:102
> +QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> +}

QStringLiteral(...).arg(...)

> foldermodeltest.cpp:132
> +QTest::addColumn("name");
> +QTest::newRow("Folder rename") << 0 << "firstDirRenamed";
> +QTest::newRow("File rename") << 1 << "file1.pdf";

QStringLiteral("...) same for other line

> foldermodeltest.h:1
> +#ifndef FOLDERMODELTEST_H
> +#define FOLDERMODELTEST_H

missing copyright

> positionertest.cpp:1
> +#include "positionertest.h"
> +

copyright

> positionertest.cpp:53
> +delete m_folderModel;
> +m_folderModel = 0;
> +delete m_positioner;

nullptr;

> positionertest.cpp:55
> +delete m_positioner;
> +m_positioner = 0;
> +}

nullptr;

> positionertest.h:1
> +#ifndef POSITIONERTEST_H
> +#define POSITIONERTEST_H

missing copyright

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel

mlaurent updated this revision to Diff 21283.
mlaurent added a comment.


  - Update extend to left

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8444?vs=21231=21283

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8462: [batterymonitor] Fix brightness resetting to 1 on startup

2017-10-25 Thread Bhushan Shah

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1c0f417939d5: [batterymonitor] Fix brightness resetting 
to 1 on startup (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8462?vs=21280=21282

REVISION DETAIL
  https://phabricator.kde.org/D8462

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: bshah, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8462: [batterymonitor] Fix brightness resetting to 1 on startup

2017-10-25 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-brightness-reset

REVISION DETAIL
  https://phabricator.kde.org/D8462

To: bshah, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8435: Make sure the content of the SwipeListItem doesn't overlap the handle

2017-10-25 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8435

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8447: Add unit tests for Folder View

2017-10-25 Thread Andras Mantia

amantia updated this revision to Diff 21281.
amantia added a comment.


  Implement changes requested by Laurent.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8447?vs=21235=21281

REVISION DETAIL
  https://phabricator.kde.org/D8447

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin_private_export.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel

mlaurent added a subscriber: dvratil.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Plasma Workspace Wallpapers] [Bug 386153] plasma is shit

2017-10-25 Thread Martin Flöser

https://bugs.kde.org/show_bug.cgi?id=386153

Martin Flöser  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

78 matches

Mail list logo