D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  In https://phabricator.kde.org/D8699#165474, @davidedmundson wrote:
  
  > > if auto rotation is enabled you cannot manually rotate the screen and 
vice versa.
  >
  > Yeah, that's great...but kscreen needs to have that information.
  >
  > It's going to be especially difficult if you do want to support X.
  >  kscreen there is following any external xrandr changes and we need to 
think about the whole set of potential races between kwin, X and kscreen.
  
  
  Hmm, I was only thinking of Wayland where we have the Wayland protocol. So 
maybe sebas suggestion of dbus service. It's still possible to race of course 
but that's something we should be able to handle. Activating the sensor takes 
it time so dbus should be faster. Then kscreen can ignore all rotations.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  5.11 yes, 5.8 no

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8706

To: apol, #plasma, davidedmundson
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df78989bb287: text improvements for Colors, Icons, Style, 
and Workspace KCMs (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8684?vs=22027=22062

REVISION DETAIL
  https://phabricator.kde.org/D8684

AFFECTED FILES
  doc/kcontrol/colors/index.docbook
  doc/kcontrol/icons/index.docbook
  doc/kcontrol/kcmstyle/index.docbook
  kcms/colors/scmeditoroptions.ui
  kcms/icons/icons.cpp
  kcms/style/finetuning.ui
  kcms/workspaceoptions/mainpage.ui

To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart


D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-07 Thread Andres Betts
abetts accepted this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D8684

REVISION DETAIL
  https://phabricator.kde.org/D8684

To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart


D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Andres Betts
abetts added a comment.


  In https://phabricator.kde.org/D8361#165580, @ngraham wrote:
  
  > Yeah, maybe a combobox toggling between Glow and Shadow styles/blending 
modes would be more intuitive here.
  
  
  That's what I mean.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8361

To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Nathaniel Graham
ngraham added a comment.


  Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes 
would be more intuitive here.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8361

To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Andres Betts
abetts accepted this revision as: abetts.
abetts added a comment.
This revision is now accepted and ready to land.


  I like this change, I think it makes sense. However, if there is a way to 
know that the user "means" to use shadow then lets do this. If the user means 
to do "glow" this behavior should stay.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8361

To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D8711: Possibly no need to have klipper executed by default

2017-11-07 Thread David Edmundson
davidedmundson added a comment.


  This was re-added recently for "other desktops".
  
  It shouldn't run on plasma though. It has both:
  
  NotShowIn=KDE;
  
  and
  
  X-KDE-autostart-condition=klipperrc:General:AutoStart:false

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8711

To: apol, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8711: Possibly no need to have klipper executed by default

2017-11-07 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In fact it fails, also isn't it a plasmoid now? This is a KStatusNotifierItem.

TEST PLAN
  Removed it from my autostart, I can still copy and paste, I think.
  I'm quite confused

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8711

AFFECTED FILES
  klipper/CMakeLists.txt

To: apol, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget

2017-11-07 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8706

To: apol, #plasma, davidedmundson
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8707: Adapt to changes in KWindowSystem

2017-11-07 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8707

To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8707: Adapt to changes in KWindowSystem

2017-11-07 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Doesn't rely on it adding a QWidgetList include
  See https://phabricator.kde.org/D8705

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8707

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.h

To: apol, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget

2017-11-07 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Fixes the build with https://phabricator.kde.org/D8705

TEST PLAN
  Just adds includes, I wonder if it should go into Plasma/5.8 and /5.11 too

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8706

AFFECTED FILES
  effects/coverswitch/coverswitch.cpp
  effects/coverswitch/coverswitch.h
  effects/cube/cube.h
  effects/flipswitch/flipswitch.h
  effects/mouseclick/mouseclick.h
  effects/presentwindows/presentwindows.h
  effects/showfps/showfps.cpp
  effects/showfps/showfps.h
  effects/slidingpopups/slidingpopups.cpp
  libkwineffects/kwineffects.h

To: apol, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Nathaniel Graham
ngraham added a reviewer: abetts.
ngraham added a subscriber: abetts.
ngraham added a comment.


  @abetts, what do you think?

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8361

To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread David Edmundson
davidedmundson added a comment.


  > if auto rotation is enabled you cannot manually rotate the screen and vice 
versa.
  
  Yeah, that's great...but kscreen needs to have that information.
  
  It's going to be especially difficult if you do want to support X.
  kscreen there is following any external xrandr changes and we need to think 
about the whole set of potential races between kwin, X and kscreen.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8703: Print screen scale in supportInformation

2017-11-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b806915d5d5e: Print screen scale in supportInformation 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8703?vs=22045=22049#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8703?vs=22045=22049

REVISION DETAIL
  https://phabricator.kde.org/D8703

AFFECTED FILES
  workspace.cpp

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8702: Debug output for platforms

2017-11-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:92e5db1ffe6a: Debug output for platforms (authored by 
davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8702?vs=22044=22050

REVISION DETAIL
  https://phabricator.kde.org/D8702

AFFECTED FILES
  platform.cpp
  platform.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h
  workspace.cpp

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


Re: Need help: vertical screen rotation!

2017-11-07 Thread Martin Flöser

Am 2017-11-07 19:03, schrieb Sebastian Kügler:

On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:

> upside down works, 90 and 270 do nothing on my system.
>
> Debian Unstable
> Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01)
> x86_64 GNU/ Linux
>
> 00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620
> (rev 02)
>
> I think above satisfies the requirements for AMS? Anything I can
> test?

What about XRandr? Does XRandR support 90 or 270 on your system?


Yup, that works.


meh, my assumption was that if we have rotation on XRandR, we get the 
same rotations on DRM. So either my code doesn't work for rotation or we 
need to rotate the crtc instead of the plane. Can you try the 
supportedTransformations patch and check the debug output which 
rotations are supported for the planes?


Cheers
Martin


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  That reminds me: https://phabricator.kde.org/tag/vdg/ how can I request two 
new status notifier icons? I need: "automatic-screen-rotation-enabled" and 
"automatic-screen-rotation-disabled"

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  In https://phabricator.kde.org/D8699#165399, @sebas wrote:
  
  > Ah, btw ... we have icons: They're in 
breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg
  >
  > These should probably be used for the statusnotifier then.
  
  
  No, the idea for the status notifier is to indicate whether we have automatic 
rotation enabled/disabled. I think we need new icons for this. I don't think 
the icon needs to express the current mode, I'm sure the user can visually see 
it without the icon.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  In https://phabricator.kde.org/D8699#165407, @davidedmundson wrote:
  
  > I don't see how the interaction with KScreen is going to work; you rotate 
the screen in kscreen, kscreen will consider that a completely different config 
change and save it.
  
  
  My suggestion would be to copy from Windows 10 (I studied a system on 
Saturday for inspiration): if auto rotation is enabled you cannot manually 
rotate the screen and vice versa. The "Windows KScreen KCM" has a checkbox 
which disables the rotation combobox.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a comment.


  In https://phabricator.kde.org/D8699#165395, @sebas wrote:
  
  > Code-wise, looks good.
  >
  > Have you thought about a way to switch it on and off? Perhaps a simple dbus 
interface that allows checking its state and turning it on and off is 
sufficient.
  
  
  There's a status notifier to enable/disable it.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8702: Debug output for platforms

2017-11-07 Thread Martin Flöser
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8702

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8703: Print screen scale in supportInformation

2017-11-07 Thread Martin Flöser
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8703

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8703: Print screen scale in supportInformation

2017-11-07 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

TEST PLAN
  Printed support info.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8703

AFFECTED FILES
  workspace.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D8702: Debug output for platforms

2017-11-07 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Mostly so DRM can report if it has AMS or not

TEST PLAN
  Ran on my DRM setup, printed debug.
  Spawned nested compositor, printed debug on that

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8702

AFFECTED FILES
  platform.cpp
  platform.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h
  workspace.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


Re: Need help: vertical screen rotation!

2017-11-07 Thread Sebastian Kügler
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:
> > upside down works, 90 and 270 do nothing on my system.
> > 
> > Debian Unstable
> > Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01)
> > x86_64 GNU/ Linux
> > 
> > 00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620
> > (rev 02)
> > 
> > I think above satisfies the requirements for AMS? Anything I can
> > test?
> 
> What about XRandr? Does XRandR support 90 or 270 on your system?

Yup, that works.
-- 
sebas

http://www.kde.org | http://vizZzion.org


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas added a comment.


  Or ... kwin has two modes: 1) kwin auto-rotates, tells kscreen that it 
doesn't do any other transforms, 2) kwin hands over to kscreen, not 
auto-rotating...
  
  Perhaps adding "auto" is the best option, though.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8652: Add supported transformations to OutputDevice

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> outputdevice.h:244
> + * @returns The transformations supported on this OutputDevice
> + * @since 5.XX
> + * @see supportedTransformationAdded

5.40 I guess :)

> outputdevice_interface.h:133
> + * Due to that there is no remove operation for supported 
> transformations.
> + * @since 5.XX
> + **/

5.40

REPOSITORY
  R127 KWayland

BRANCH
  supported-transformations

REVISION DETAIL
  https://phabricator.kde.org/D8652

To: graesslin, #frameworks, #kwin, #plasma, sebas
Cc: sebas, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart


D8645: [platforms/drm] Determine the supported transformation on a plane

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  drm-supported-transformations

REVISION DETAIL
  https://phabricator.kde.org/D8645

To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas added a comment.


  Ah, btw ... we have icons: They're in 
breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg
  
  These should probably be used for the statusnotifier then.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.


  Code-wise, looks good.
  
  Have you thought about a way to switch it on and off? Perhaps a simple dbus 
interface that allows checking its state and turning it on and off is 
sufficient.

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


Re: Need help: vertical screen rotation!

2017-11-07 Thread Martin Flöser

Am 2017-11-07 18:27, schrieb Sebastian Kügler:

On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote:

Hi all,

I am currently working on screen rotation on Wayland. Unfortunately my
systems do not support vertical rotation (rotate by 90 or 270
degrees). Thus I do not know whether my code works or what needs
fixing.

I need someone who has a system which supports vertical screens to
test my code and report back what works and what doesn't. Perfect
would be to be willing to test patches or even try some patches.

If you know someone with such a setup who might not read this mail:
please poke them. All required code is in current KWin master. The
rotation can be selected through KScreen KCM.

Please note that the system requires atomic modesetting support. This
might need to be activated in the kernel. For example in Ubuntu 16.04
with Intel driver it is not activated out of the box, on Debian
testing it is.

Thanks in advance for the help!

Martin


upside down works, 90 and 270 do nothing on my system.

Debian Unstable
Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01) x86_64
GNU/ Linux

00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620
(rev 02)

I think above satisfies the requirements for AMS? Anything I can test?


What about XRandr? Does XRandR support 90 or 270 on your system?

Cheers
Martin


Re: Regarding the outputdevice Wayland protocol

2017-11-07 Thread Martin Flöser

Am 2017-11-07 09:03, schrieb Sebastian Kügler:

Hi Drew,

Thanks for reaching out!

On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote:

As part of our effort to reuse existing Wayland protocols for common
desktop features in Sway (and wlroots), we're taking a look at KDE's
output-management.xml. However, we feel like the related
outputdevice.xml protocol has some overlap with wl_output - can you
provide some context for these protocols and would you consider
working with us on a simplified protocol we can share?


outputdevice.xml is indeed an extended version of wl_output. It has
some additional options that we need for the outputmanagement stuff, so
it becomes useful, wl_output wasn't sufficient there. I've added the
current mode, edid and enabled fields, as wl_outputs are always
supposed to be enabled, and outputdevices are just connected displays
which may be enabled or not. We also needed a way to pass through the
edid blob. We've checked with upstream wayland, and there was "little
desire" to have these things in wl_output, so an extended version is
what we did. I'm not overly happy with this, but at some point we had
to move on, even if it left warts on the protocol semantics.

A simplified protocol to be shared could be two things:

* merged wl_output with edid, currentmode and enablement added
* simplified outputdevice which uses a wl_output and attaches just the
  above properties

I'm not sure if the above *could* work, since a wl_output was never
designed to be not enabled, so just sitting there, being available, but
the above is at least what I can imagine recalling the discussions we
had back then when we implemented it in kwayland. Martin can probably
provide some more insight here.


Not much to add to what sebas writes. Only I can point out that I 
currently have an open review for the first addition:
the supported transformations on an output. The idea behind that is to 
tell KScreen what transformations it can offer to select. And thus the 
whole interface is designed for screen configuration tool. Given that I 
don't think it makes much sense to try to merge with wl_output.


So for sway the question is whether you want to have a screen 
configuration tool talking through Wayland with the compositor. If you 
don't need that you can probably just forget about this interface. If 
you need something like that it makes sense to reuse our protocols. We 
spend quite some engineering effort into it. I remember that we defined 
the protocols for weeks till we were happy with them.


Interesting side node: we had these protocols around for quite some 
time, but not hooked up in KWin. The last two weeks I worked on it and 
everything works exactly as we wanted from the start. No need to change 
anything in KScreen or the protocol. Everything just works after 
connecting the hooks.


Cheers
Martin


Re: Need help: vertical screen rotation!

2017-11-07 Thread Sebastian Kügler
On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote:
> Hi all,
> 
> I am currently working on screen rotation on Wayland. Unfortunately my
> systems do not support vertical rotation (rotate by 90 or 270
> degrees). Thus I do not know whether my code works or what needs
> fixing.
> 
> I need someone who has a system which supports vertical screens to
> test my code and report back what works and what doesn't. Perfect
> would be to be willing to test patches or even try some patches.
> 
> If you know someone with such a setup who might not read this mail:
> please poke them. All required code is in current KWin master. The
> rotation can be selected through KScreen KCM.
> 
> Please note that the system requires atomic modesetting support. This
> might need to be activated in the kernel. For example in Ubuntu 16.04
> with Intel driver it is not activated out of the box, on Debian
> testing it is.
> 
> Thanks in advance for the help!
> 
> Martin

upside down works, 90 and 270 do nothing on my system.

Debian Unstable
Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01) x86_64
GNU/ Linux

00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620
(rev 02)

I think above satisfies the requirements for AMS? Anything I can test?
-- 
sebas

http://www.kde.org | http://vizZzion.org


Re: Need help: vertical screen rotation!

2017-11-07 Thread Martin Flöser

Am 2017-11-07 17:46, schrieb David Edmundson:

​Linux david-laptop 4.10.17-2-MANJARO #1 SMP PREEMPT Sun May 21
11:02:41 UTC 2017 x86_64 GNU/Linux


On Intel it's not yet enabled by default with 4.10. Please do the 
following:


1. Edit /etc/default/grub
and add "i915.nuclear_pageflip=1" to GRUB_CMDLINE_LINUX_DEFAULT
2. update-grub
3. reboot
4. enjoy atomic mode settings

As an alternative you can also just add the i915.nuclear_pageflip=1 in 
grub directly. I went for the grub variant on my notebook (which runs 
Neon and thus also 4.10 kernel).


Cheers
Martin


Re: Need help: vertical screen rotation!

2017-11-07 Thread David Edmundson
​Linux david-laptop 4.10.17-2-MANJARO #1 SMP PREEMPT Sun May 21 11:02:41
UTC 2017 x86_64 GNU/Linux

Renderer:
Compositing
===
Compositing is active
Compositing Type: OpenGL
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Haswell Mobile
OpenGL version string: 3.0 Mesa 17.2.4
OpenGL platform interface: EGL
OpenGL shading language version string: 1.30
Driver: Intel
GPU class: Haswell
OpenGL version: 3.0
GLSL version: 1.30
Mesa version: 17.2.4
Linux kernel version: 4.10.17
Direct rendering: Requires strict binding: no
GLSL shaders:  yes
Texture NPOT support:  yes
Virtual Machine:  no
OpenGL 2 Shaders are used
Painting blocks for vertical retrace:  no


D8645: [platforms/drm] Determine the supported transformation on a plane

2017-11-07 Thread Martin Flöser
graesslin added a dependent revision: D8699: Support automatic screen rotation 
based on orientation sensor.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8645

To: graesslin, #kwin, #plasma, subdiff
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin added a dependency: D8645: [platforms/drm] Determine the supported 
transformation on a plane.

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Martin Flöser
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change introduces an OrientationSensor class which wraps a
  QOrientationSensor. The OrientationSensor is hold by Screens and gets
  enabled if Screens knows about an internal (e.g. LVDS) display which
  supports rotation. In addition the OrientationSensor holds an KSni to
  enable/disable the automatic rotation support.
  
  The drm platform plugin is adjusted to make use of the OrientationSensor.
  The API is defined in a way that this can also be implemented on other
  platforms supporting rotation. Most important are hwcomposer and X11
  standalone. The latter should be straight forward as rotation is provided
  through XRandR. The former needs addition for rotation support first.

TEST PLAN
  Rotated my Yoga 12

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  orientation_sensor.cpp
  orientation_sensor.h
  plugins/platforms/drm/drm_object_plane.h
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/screens_drm.cpp
  plugins/platforms/drm/screens_drm.h
  screens.cpp
  screens.h
  tests/CMakeLists.txt
  tests/orientationtest.cpp

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


Re: Need help: vertical screen rotation!

2017-11-07 Thread Martin Flöser

Am 2017-11-06 19:07, schrieb David Edmundson:

I am not :(
drmSetClientCap fails

Is there much I can do?


Could you please tell me which kernel version and which gpu driver you 
are using?


Cheers
Martin


D8641: FormLayout

2017-11-07 Thread Marco Martin
mart updated this revision to Diff 22033.
mart added a comment.


  - add heuristic to exclude repeaters from layout

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8641?vs=21991=22033

BRANCH
  mart/formlayout

REVISION DETAIL
  https://phabricator.kde.org/D8641

AFFECTED FILES
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/FormLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/FormLayout.qml
  src/controls/Heading.qml
  src/controls/templates/FormLayout.qml
  src/formlayoutattached.cpp
  src/formlayoutattached.h
  src/kirigamiplugin.cpp

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein


D8695: Fix ampersand characters not showing in tab titles

2017-11-07 Thread Corentin Risselin
corentinr added inline comments.

INLINE COMMENTS

> adridg wrote in Workspace.cpp:142
> Are you sure this won't affect tabs that *do* have shortcuts, and need them? 
> How about after a save/restart cycle, are the ampersands re-doubled?

There is no default tab with shortcut and I felt there was no need for them. If 
the Qt shortcut feature is preferable the best way would probably be a tooltip 
upon entering an ampersand in the title.

save/restart cycle doesn't re-doubled as this replace is"on the fly" and never 
saved anywhere.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8695: Fix ampersand characters not showing in tab titles

2017-11-07 Thread Corentin Risselin
corentinr edited the summary of this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8695: Fix ampersand characters not showing in tab titles

2017-11-07 Thread Adriaan de Groot
adridg added inline comments.

INLINE COMMENTS

> Workspace.cpp:142
> +// Title ampersands must be doubled or will not be displayed and used as 
> QT shortcut
> +insertTab(-1, sheet, dlg.sheetTitle().replace( "&", "&&" ) );
>  mSheetList.append( sheet );

Are you sure this won't affect tabs that *do* have shortcuts, and need them? 
How about after a save/restart cycle, are the ampersands re-doubled?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D8695

To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8694: Add .arcconfig

2017-11-07 Thread Adriaan de Groot
adridg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8694

AFFECTED FILES
  .arcconfig

To: adridg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8695: Fix ampersand characters not showing in tab titles

2017-11-07 Thread Corentin Risselin
corentinr created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8695

AFFECTED FILES
  gui/Workspace.cpp

To: corentinr
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8694: Add .arcconfig

2017-11-07 Thread Adriaan de Groot
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:1f8fec738573: Add .arcconfig (authored by adridg).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8694?vs=22030=22031

REVISION DETAIL
  https://phabricator.kde.org/D8694

AFFECTED FILES
  .arcconfig

To: adridg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


Plasma 5.11.3

2017-11-07 Thread Jonathan Riddell
Plasma 5.11.3 fixes Network Manager passwords and Discover repo loading
https://www.kde.org/announcements/plasma-5.11.3.php


D8692: QML mouse cursor KCM and components

2017-11-07 Thread Nathaniel Graham
ngraham added a comment.


  Even though that window is narrow, looks like we have room for another 
column; we should use it. If this view is capable of resizing itself to fit in 
very narrow windows, that will make a bit difference in letting System Settings 
be more compact over time, which is important because the default layout has an 
omnipresent left sidebar that takes up space.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8692

To: mart, #plasma
Cc: ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-07 Thread Nathaniel Graham
ngraham marked 3 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D8684

REVISION DETAIL
  https://phabricator.kde.org/D8684

To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart


D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 22027.
ngraham added a comment.


  Update dobcook dates and release versions

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8684?vs=22015=22027

BRANCH
  arcpatch-D8684

REVISION DETAIL
  https://phabricator.kde.org/D8684

AFFECTED FILES
  doc/kcontrol/colors/index.docbook
  doc/kcontrol/icons/index.docbook
  doc/kcontrol/kcmstyle/index.docbook
  kcms/colors/scmeditoroptions.ui
  kcms/icons/icons.cpp
  kcms/style/finetuning.ui
  kcms/workspaceoptions/mainpage.ui

To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart


D8691: add some metadata

2017-11-07 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/moduledata

REVISION DETAIL
  https://phabricator.kde.org/D8691

To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8692: QML mouse cursor KCM and components

2017-11-07 Thread Roman Gilg
subdiff added a comment.


  - Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view 
with only one column
  - There is no white background to the list view

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8692

To: mart, #plasma
Cc: subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8692: QML mouse cursor KCM and components

2017-11-07 Thread Marco Martin
mart updated this revision to Diff 22026.
mart added a comment.


  - make use of the separed kcm modules
  - use Q_DECL_OVERRIDE

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8692?vs=22024=22026

BRANCH
  kcm-redesign/cursorTheme

REVISION DETAIL
  https://phabricator.kde.org/D8692

AFFECTED FILES
  CMakeLists.txt
  kcmcontrols/GridDelegate.qml
  kcmcontrols/GridViewPage.qml
  kcmcontrols/qmldir
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/Messages.sh
  kcms/cursortheme/cursortheme.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop
  kcms/cursortheme/xcursor/cursortheme.cpp
  kcms/cursortheme/xcursor/cursortheme.h
  kcms/cursortheme/xcursor/itemdelegate.cpp
  kcms/cursortheme/xcursor/itemdelegate.h
  kcms/cursortheme/xcursor/previewwidget.cpp
  kcms/cursortheme/xcursor/previewwidget.h
  kcms/cursortheme/xcursor/sortproxymodel.cpp
  kcms/cursortheme/xcursor/sortproxymodel.h
  kcms/cursortheme/xcursor/thememodel.cpp
  kcms/cursortheme/xcursor/thememodel.h
  kcms/cursortheme/xcursor/themepage.cpp
  kcms/cursortheme/xcursor/themepage.h
  kcms/cursortheme/xcursor/themepage.ui
  kcms/cursortheme/xcursor/xcursor.knsrc
  kcms/cursortheme/xcursor/xcursortheme.cpp
  kcms/cursortheme/xcursor/xcursortheme.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8692: QML mouse cursor KCM and components

2017-11-07 Thread Marco Martin
mart updated this revision to Diff 22024.
mart added a comment.


  - use Q_DECL_OVERRIDE

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8692?vs=22023=22024

BRANCH
  kcm-redesign/cursorTheme

REVISION DETAIL
  https://phabricator.kde.org/D8692

AFFECTED FILES
  CMakeLists.txt
  kcmcontrols/GridDelegate.qml
  kcmcontrols/GridViewPage.qml
  kcmcontrols/qmldir
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/Messages.sh
  kcms/cursortheme/cursortheme.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop
  kcms/cursortheme/xcursor/cursortheme.cpp
  kcms/cursortheme/xcursor/cursortheme.h
  kcms/cursortheme/xcursor/itemdelegate.cpp
  kcms/cursortheme/xcursor/itemdelegate.h
  kcms/cursortheme/xcursor/previewwidget.cpp
  kcms/cursortheme/xcursor/previewwidget.h
  kcms/cursortheme/xcursor/sortproxymodel.cpp
  kcms/cursortheme/xcursor/sortproxymodel.h
  kcms/cursortheme/xcursor/thememodel.cpp
  kcms/cursortheme/xcursor/thememodel.h
  kcms/cursortheme/xcursor/themepage.cpp
  kcms/cursortheme/xcursor/themepage.h
  kcms/cursortheme/xcursor/themepage.ui
  kcms/cursortheme/xcursor/xcursor.knsrc
  kcms/cursortheme/xcursor/xcursortheme.cpp
  kcms/cursortheme/xcursor/xcursortheme.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8692: QML mouse cursor KCM and components

2017-11-07 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  introduce a cursor theme kcm ported to QML, following the new
  design guidelines, alongside generic components that will be reused for
  modules that are mostly big grid views, such as look and feel.

TEST PLAN
  tested on different devices with different dpi

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm-redesign/cursorTheme

REVISION DETAIL
  https://phabricator.kde.org/D8692

AFFECTED FILES
  CMakeLists.txt
  kcmcontrols/GridDelegate.qml
  kcmcontrols/GridViewPage.qml
  kcmcontrols/qmldir
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/Messages.sh
  kcms/cursortheme/cursortheme.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop
  kcms/cursortheme/xcursor/cursortheme.cpp
  kcms/cursortheme/xcursor/cursortheme.h
  kcms/cursortheme/xcursor/itemdelegate.cpp
  kcms/cursortheme/xcursor/itemdelegate.h
  kcms/cursortheme/xcursor/previewwidget.cpp
  kcms/cursortheme/xcursor/previewwidget.h
  kcms/cursortheme/xcursor/sortproxymodel.cpp
  kcms/cursortheme/xcursor/sortproxymodel.h
  kcms/cursortheme/xcursor/thememodel.cpp
  kcms/cursortheme/xcursor/thememodel.h
  kcms/cursortheme/xcursor/themepage.cpp
  kcms/cursortheme/xcursor/themepage.h
  kcms/cursortheme/xcursor/themepage.ui
  kcms/cursortheme/xcursor/xcursor.knsrc
  kcms/cursortheme/xcursor/xcursortheme.cpp
  kcms/cursortheme/xcursor/xcursortheme.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8691: add some metadata

2017-11-07 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  accessible by the qml implementations

TEST PLAN
  the properties kcm.name and kcm.description are accessible from the qml part 
of
  the cursortheme kcm

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/moduledata

REVISION DETAIL
  https://phabricator.kde.org/D8691

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8641: FormLayout

2017-11-07 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> FormLayout.qml:71
> +itemContainer.parent = lay;
> +//if section, wee need another placeholder
> +if (item.Kirigami.FormData.isSection) {

typo

> FormLayout.qml:85-86
> +property var item
> +implicitWidth: item.implicitWidth
> +Layout.preferredHeight: Math.max(item.Layout.preferredHeight, 
> item.implicitHeight)
> +

why do something different for width and height?

Also I think we're better off doing

implicitheight: item.implicitHeight
Layout.preferredheight: item.Layout.preferredHeight

For layouts. Layout.preferred takes precedence over implicit if set, I think it 
makes sense to just copy that.

> FormLayout.qml:113
> +id: buddyComponent
> +Kirigami.Heading {
> +id: labelItem

I'd like it if we can make this on the desktop style look the same as QGroupBox 
looks in flat mode. Even if that means changing our QStyle.

Currently this means spanning both columns and then centre aligning.

> FormLayout.qml:117
> +text: item.Kirigami.FormData.label
> +
> +level: item.Kirigami.FormData.isSection ? 3 : 5

visible: item.visible might make sense.

it allows a dev to hide a UI component and label if it's not relevantl together

> FormLayout.qml:120
> +
> +Layout.preferredHeight: item.Kirigami.FormData.label.length > 0 
> ? implicitHeight : Kirigami.Units.smallSpacing
> +Layout.alignment: root.wideMode ? (Qt.AlignRight | 
> (item.Kirigami.FormData.buddyFor.height > height * 2 ? Qt.AlignTop : 
> Qt.AlignVCenter))

why are we giving it a height if it's empty?

> FormLayout.qml:121
> +Layout.preferredHeight: item.Kirigami.FormData.label.length > 0 
> ? implicitHeight : Kirigami.Units.smallSpacing
> +Layout.alignment: root.wideMode ? (Qt.AlignRight | 
> (item.Kirigami.FormData.buddyFor.height > height * 2 ? Qt.AlignTop : 
> Qt.AlignVCenter))
> +: (Qt.AlignLeft | Qt.AlignBottom)

In general with text, I think it's better to set the item to occupy the whole 
space it /can/ take up, then use the Text.Alignment property to position the 
text within it.

Otherwise if this wraps, your second line would start on the left not the right.

Related; what should happen if a user sets a really really really long label?

> FormLayout.qml:121-123
> +Layout.alignment: root.wideMode ? (Qt.AlignRight | 
> (item.Kirigami.FormData.buddyFor.height > height * 2 ? Qt.AlignTop : 
> Qt.AlignVCenter))
> +: (Qt.AlignLeft | Qt.AlignBottom)
> +Layout.topMargin: item.Kirigami.FormData.buddyFor.height > 
> height * 2 ? Kirigami.Units.smallSpacing : 0

What's the rationale for this "if buddy.height > height *2" stuff?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein


D8641: FormLayout

2017-11-07 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in FormLayout.qml:8
> Why do we inherit from Control?

I tend to have them controls by default as they have the padding properties 
that can be very convenient sometimes (as well, if one needs to put a 
background on the back of it for whatever reason)

> davidedmundson wrote in formlayoutattached.h:40
> That's a really clever idea; it makes it very flexible so a phone layout 
> could have the labels on top 
> 
> so I'm a bit surprised that the FormLayout.qml is an object, and not a 
> template; I think it's throwing away an opportunity.

at the moment it automatically switches based on the width..
but maybe indeed better to make it a template and force two columns on desktop 
(on mobile, still automatic i guess, for phone/tablet, or even just 
portait/landscape phone

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein


Re: Regarding the outputdevice Wayland protocol

2017-11-07 Thread Sebastian Kügler
Hi Drew,

Thanks for reaching out!

On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote:
> As part of our effort to reuse existing Wayland protocols for common
> desktop features in Sway (and wlroots), we're taking a look at KDE's
> output-management.xml. However, we feel like the related
> outputdevice.xml protocol has some overlap with wl_output - can you
> provide some context for these protocols and would you consider
> working with us on a simplified protocol we can share?

outputdevice.xml is indeed an extended version of wl_output. It has
some additional options that we need for the outputmanagement stuff, so
it becomes useful, wl_output wasn't sufficient there. I've added the
current mode, edid and enabled fields, as wl_outputs are always
supposed to be enabled, and outputdevices are just connected displays
which may be enabled or not. We also needed a way to pass through the
edid blob. We've checked with upstream wayland, and there was "little
desire" to have these things in wl_output, so an extended version is
what we did. I'm not overly happy with this, but at some point we had
to move on, even if it left warts on the protocol semantics.

A simplified protocol to be shared could be two things:

* merged wl_output with edid, currentmode and enablement added
* simplified outputdevice which uses a wl_output and attaches just the
  above properties

I'm not sure if the above *could* work, since a wl_output was never
designed to be not enabled, so just sitting there, being available, but
the above is at least what I can imagine recalling the discussions we
had back then when we implemented it in kwayland. Martin can probably
provide some more insight here.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org