D9353: Fix the user switcher not updating open sessions

[Lasath Fernando]

fernando added a comment.


  Thanks. Here's an updated diff without the console.log().
  
  As for commit access, I had it a very long time ago, but I have no idea if my 
key will still work.
  I'll try to push and let you know if I can't.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9353

To: fernando, davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9353: Fix the user switcher not updating open sessions

[Lasath Fernando]

fernando updated this revision to Diff 24815.
fernando marked an inline comment as done.
fernando added a comment.


  Removed log statement I originally added for debugging.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9353?vs=23979=24815

REVISION DETAIL
  https://phabricator.kde.org/D9353

AFFECTED FILES
  applets/userswitcher/package/contents/ui/main.qml

To: fernando, davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

[Chris Holland]

Zren marked an inline comment as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

[Chris Holland]

Zren updated this revision to Diff 24808.
Zren retitled this revision from "[Panel Config] Scrolling over size button 
increments size by 1 and shows current thickness" to "[Panel Config] Scrolling 
over size button increments size by 2 and shows current thickness".
Zren edited the summary of this revision.
Zren added a comment.


  Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's 
code.
  
  Now that I'm submitting this... I could probably also use this instead of the 
while loops...
  
var deltaThickness = wheelDelta / 120
deltaThickness = deltaThickness < 0 ? Math.ceil(deltaThickness) : 
Math.floor(deltaThickness)
wheelDelta -= deltaThickness * 120
  
  Meh. The loop pattern is tested an works (in plasma-pa too).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6392?vs=15888=24808

REVISION DETAIL
  https://phabricator.kde.org/D6392

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 54 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/54/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 06 Jan 2018 01:31:33 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 53 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/53/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 06 Jan 2018 01:24:23 +
 Build duration:
5 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 667.03 KB...]Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 15%] Automatic MOC for target kcm_desktopthemeAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/desktoptheme/kcm.cpp"The file includes the moc file "kcm.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/kcm.mocGenerating MOC source EWIEGA46WW/moc_kcm.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 15%] Automatic MOC for target kcm_standard_actionsAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/standard_actions/standard_actions_module.cpp"The file includes the moc file "standard_actions_module.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/standard_actions_module.mocGenerating MOC source EWIEGA46WW/moc_standard_actions_module.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 15%] Automatic MOC for target kcm_keysAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/keys/globalshortcuts.cpp"The file includes the moc file "globalshortcuts.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/moc_export_scheme_dialog.cppGenerating MOC source include/globalshortcuts.mocGenerating MOC source include/moc_select_scheme_dialog.cppGenerating MOC source EWIEGA46WW/moc_globalshortcuts.cppGenerating MOC source EWIEGA46WW/moc_kglobalshortcutseditor.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 15%] Automatic MOC for target kcm_smserverAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/ksmserver/kcmsmserver.cpp"The file includes the moc file "kcmsmserver.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/kcmsmserver.mocGenerating MOC source EWIEGA46WW/moc_kcmsmserver.cppGenerating MOC source EWIEGA46WW/moc_smserverconfigimpl.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 15%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/lookandfeel/kcm_lookandfeel-kcms-metadata.json" [ 15%] Built target kcm_lookandfeel-kcms-metadata-jsonScanning dependencies of target lookandfeeltool_autogen[ 15%] Generating klauncher_iface.cpp, klauncher_iface.h[ 15%] Automatic MOC for target lookandfeeltoolAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/lookandfeel/kcm.cpp"The file includes the moc file "kcm.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source 

D8922: Avoid jumping of items toward right/botton when dropping

[Eike Hein]

hein added a comment.


  I'm going to revert this commit. It has made the DND experience very poor 
(icons jump around like crazy on drop). My review comment was ignored, and it 
went in after an accept by a developer who is not involved with Plasma 
development and doesn't maintain the codebase. This style of "we'll get code in 
by ACK'ing each other" is extremely poor form.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8922

To: amantia, #plasma, hein, mwolff
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9201: Slightly reduce vertical gutter width.

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5ae880f84626: Slightly reduce vertical gutter width. 
(authored by Zren).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9201?vs=24677=24805

REVISION DETAIL
  https://phabricator.kde.org/D9201

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: Zren, #plasma, hein
Cc: ngraham, abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

[Fabian Vogt]

fvogt updated this revision to Diff 24804.
fvogt added a comment.


  Remove the history tail before appending the head to never exceed the 
reserved vector size

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9689?vs=24803=24804

BRANCH
  history

REVISION DETAIL
  https://phabricator.kde.org/D9689

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp
  tests/processtest.cpp
  tests/processtest.h

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  By adding a new PercentageHistoryRole returning a QVector with timestamps and
  values, the delegate can show the history of the percentage as background.
  
  This is currently only done for the CPU usage, but can easily be added for
  memory as well.
  
  The history vector is only created and filled after the first access on each
  process.

TEST PLAN
  Added a small testcase which verifies that the history vector has an entry
  with the current value after the first refresh after the initial access.
  The end result looks like this:
  
https://phabricator.kde.org/file/data/mwuxhmkgb7p5gr2jl6ax/PHID-FILE-v76g3drarovozb4fue3w/KSysguard_with_per-process_cpu_graph

REPOSITORY
  R111 KSysguard Library

BRANCH
  history

REVISION DETAIL
  https://phabricator.kde.org/D9689

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp
  tests/processtest.cpp
  tests/processtest.h

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Henrik Fehlauer]

rkflx added a comment.


  Thanks for the update. I won't need to test again, as the screenshots clearly 
show it working fine ;)
  
  If Hugo is happy with the code, this could land.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham updated this revision to Diff 24801.
ngraham added a comment.


  - Make Small replicate the old default shadow size
  - Rename Normal to Medium
  - Call the new default "Large"

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9627?vs=24771=24801

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/breezeconfigwidget.cpp
  kdecoration/config/ui/breezeconfigurationui.ui
  kstyle/breeze.kcfg
  kstyle/breezeshadowhelper.cpp

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9019: [Calendar] Adjust the calendar toolbar anchors

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D9019#172645, @akulichalexandr wrote:
  
  > In https://phabricator.kde.org/D9019#172612, @broulik wrote:
  >
  > > Thanks! It's the little things that make it feel polished :)
  > >
  > > Do you have commit access?
  >
  >
  > Yes, I have the access, but I did not contribute for a long time and still 
have to get used to Phabricator.
  >  Thank you for the review, I'll push the commit once I'll figure out how to 
do it properly nowadays. :-)
  
  
  Since you seem to have used arc properly, this will do
  
  arc patch https://phabricator.kde.org/D9019
  arc land
  
  I can do it for you if you want

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  upstreaming

REVISION DETAIL
  https://phabricator.kde.org/D9019

To: akulichalexandr, #plasma, broulik
Cc: aacid, davidedmundson, broulik, plasma-devel, #plasma, #frameworks, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D6567: Do not leak XVisualInfo (GLX path)

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:d1355c3a1ca9: Do not leak XVisualInfo (GLX path) 
(authored by madcatx, committed by aacid).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6567?vs=16334=24798

REVISION DETAIL
  https://phabricator.kde.org/D6567

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: madcatx, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[Martin Flöser]

graesslin added a comment.


  I like it!

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D9627#186637, @ngraham wrote:
  
  > In https://phabricator.kde.org/D9627#186631, @rkflx wrote:
  >
  > > Works for the menu, but the window shadow is not as before for me. Maybe 
insert Tiny with 16px + 16px?
  >
  >
  > Are you sure? the old shadow default was 16px, which is replicated in the 
Small option. Of course it doesn't look //exactly// the same as before since 
the old shadow was right-biased, so it looked bigger than 16px on the right 
side, and almost non-existent on the left side. But technically, we do still 
have a 16px shadow option.
  
  
  For me Small looks like this currently (note the bigger window shadow, while 
you claim it should be smaller with centering):
  
  F5622435: small-after.png 
  
  Before, it looked like this (note the size of the window shadow is the same 
small size as the menu shadow):
  
  F5622437: small-before.png 
  
  Essentially all I want is that we provide a fallback for those not liking the 
change (personally I like it), they have to accept the centering anyway. I 
guess that's what we would get with 12px menu shadow + 12 px window shadow? 
(Not 16px, because we have to account for the centering). As far as I 
understand the code, currently Small is 12px + 32px. We would not need to 
change that, just add another which gets us the old behaviour.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D9627#186631, @rkflx wrote:
  
  > As we now have three comboboxes (sizes of shadow, border, window buttons) 
all with slightly different options, we could think about unifying these, both 
in the number of options (not too many) and the wording (no "normal"/"default" 
etc.). For example Tiny > Small > Medium > Large > Huge plus special cases 
(e.g. No [Side] Borders). Different patch, of course. Thoughts?
  
  
  Great idea. I even wonder if we actually need Tiny as an option. It seems to 
me that the kind of person who wants Tiny window borders generally prefers None 
at all (disclosure: I am one such person). Same for shadows, really. But yes, 
this is a discussion for another patch.
  
  > 
  > 
  >  ---
  > 
  >> Small is the old default value for people who preferred that.
  > 
  > Works for the menu, but the window shadow is not as before for me. Maybe 
insert Tiny with 6px + 6px?
  
  Are you sure? the old shadow default was 16px, which is replicated in the 
Small option. Of course it doesn't look //exactly// the same as before since 
the old shadow was right-biased, so it looked bigger than 16px on the right 
side, and almost non-existent on the left side. But technically, we do still 
have a 16px shadow option.
  
  > @ngraham BTW, how did you solve the `.so` problem in the end?
  
  In the end the `.so`s weren't actually being compiled with my changes due to 
stale files in my checkout. After doing a clean, the libraries were generated 
correctly and then installing them using my prior procedure worked fine.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D9627#186592, @ngraham wrote:
  
  > FWIW, I rather prefer abstract words instead of numbers, since then we have 
more freedom to tweak the numbers under the hood in the future. The actual 
numbers aren't important enough to show to the user IMHO. And if we do expose 
the number, people will eventually ask for a spinbox to precisely input 
arbitrary values, and we'll be back to where we started from. :-)
  
  
  Exactly my thoughts.
  
  As we now have three comboboxes (sizes of shadow, border, window buttons) all 
with slightly different options, we could think about unifying these, both in 
the number of options (not too many) and the wording (no "normal"/"default" 
etc.). For example Tiny > Small > Medium > Large > Huge plus special cases 
(e.g. No [Side] Borders). Different patch, of course. Thoughts?
  
  ---
  
  > Small is the old default value for people who preferred that.
  
  Works for the menu, but the window shadow is not as before for me. Maybe 
insert Tiny with 6px + 6px?
  
  As for the rest, it's working well for me (did not look at the code, though). 
Thank you Hugo + Nate!
  
  @ngraham BTW, how did you solve the `.so` problem in the end?

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[David Edmundson]

davidedmundson updated this revision to Diff 24791.
davidedmundson added a comment.


  Debug--

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24788=24791

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Andres Betts]

abetts accepted this revision.
abetts added a comment.


  Thanks guys!

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9685: Add config for the lockscreen to toggle media controls

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  See related patch to kscreenlocker

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9685

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/config.qml
  lookandfeel/contents/lockscreen/config.xml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9658: Use explicit palette interface

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:0490a151f95b: Use explicit palette interface (authored by 
davidedmundson).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9658?vs=24765=24789

REVISION DETAIL
  https://phabricator.kde.org/D9658

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp
  src/platformtheme/kwaylandintegration.h

To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D9627#186592, @ngraham wrote:
  
  > FWIW, I rather prefer abstract words instead of numbers, since then we have 
more freedom to tweak the numbers under the hood in the future. The actual 
numbers aren't important enough to show to the user IMHO. And if we do expose 
the number, people will eventually ask for a spinbox to precisely input 
arbitrary values, and we'll be back to where we started from. :-)
  
  
  I agree.  IMO numbers in themselves are technical implementations irrelevant 
for the users, especially when you actually paint a gaussian gradient (for 
which the actual size is not quite well defined).
  
  I am ok with changing normal by medium, adding more sizes, etc.
  
  But please not changing to "default", since "default size" means essentially 
nothing (and I agree that "normal size" does not mean much either).

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[David Edmundson]

davidedmundson updated this revision to Diff 24788.
davidedmundson added a comment.


  Remove unintended change to .ui file

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24787=24788

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[David Edmundson]

davidedmundson added a comment.


  F5622292: Spectacle.fjteac.png 

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This is loaded in a QQuickView like the wallpaper, rest of the code is
  mostly based on something quite similar.
  
  Only differences is that wallpapers packages can change during the
  config, whereas the base package cannot; which simplifies some code.
  
  BUG: 384264

TEST PLAN
  Started playing some tunes
  Locked screen, still had my controls
  Changed setting
  Locked screen, didn't have my controls
  Changed wallpaper to confirm I hadn't broken anything

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9601: Make media controls configurable

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D9601#186415, @davidedmundson wrote:
  
  > > maybe we need a lnf specific config module? It's not the first feature 
where I would say that this actually doesn't belong into kscreenlocker kcm as 
it's specific to the theme.
  >
  > I like half of that.
  >
  > I think configuring the look and feel package somewhere separate would be a 
very weird user experience. 
  >  You'd want to configure things for the lockscreen in the lockscreen.
  >
  > But, having the lnf provide the config makes sense.
  >
  > If we added a screenlocker config to the lnf and then loaded that in this 
UI in the same way that we do wallpapers that would be perfect.
  
  
  That's how I meant it

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9658: Use explicit palette interface

[Martin Flöser]

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Soon my kdevelop will be black again!

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9658

To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham added a comment.


  FWIW, I rather prefer abstract words instead of numbers, since then we have 
more freedom to tweak the numbers under the hood in the future. The actual 
numbers aren't important enough to show to the user IMHO. And if we do expose 
the number, people will eventually ask for a spinbox to precisely input 
arbitrary values, and we'll be back to where we started from. :-)

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Andres Betts]

abetts added a comment.


  In https://phabricator.kde.org/D9627#186584, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D9627#186582, @abetts wrote:
  >
  > > Would you consider changing the word "Normal" for something more related 
to measurements? For example, regular, default, current. Normal works better in 
other languages like Spanish where it is related to measurements. In English 
that link is not as strong.
  >
  >
  > For the record, normal is already used at many places: decoration border 
sizes, decoration button sizes to cite a few.
  >  Back in the days I was explicitly asked to change Default to Normal.
  
  
  That is why I was thinking that maybe using words to describe it is harder 
than numbers. Could we consider using numbers instead of words? 
@hpereiradacosta Normal is not a bad words but doesn't work well in English 
when explaining measurements. Hence my suggestion.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D9627#186583, @ngraham wrote:
  
  > How about "Medium"?
  
  
  It's not really of size medium, isn't it? However, compared to before 3 
different sizes are not that many anyway, so we could insert an extra / actual 
"Medium", rename the new default to "Large", and finally rename the last one to 
"Huge" or "Very Large".

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D9627#186582, @abetts wrote:
  
  > Would you consider changing the word "Normal" for something more related to 
measurements? For example, regular, default, current. Normal works better in 
other languages like Spanish where it is related to measurements. In English 
that link is not as strong.
  
  
  For the record, normal is already used at many places: decoration border 
sizes, decoration button sizes to cite a few.
  Back in the days I was explicitly asked to change Default to Normal.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham added a comment.


  How about "Medium"?

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Andres Betts]

abetts added a comment.


  Would you consider changing the word "Normal" for something more related to 
measurements? For example, regular, default, current. Normal works better in 
other languages like Spanish where it is related to measurements. In English 
that link is not as strong.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9661

To: broulik, #plasma, #vdg, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Re: detecting tablet mode

[Martin Flöser]

Am 2018-01-05 16:11, schrieb Marco Martin:

debugging a bit what happens currently on my machine, i don't seem to
have any event device which libinput_device_switch_has_switch,
however, when i flip it, i do get an event, but oddly from the event
device called
"intel virtual button driver" and i get a key event of id 240.
do you think it's a kernel problem and can'tbe made work on our level?
I can also try to do the patch blindly, but how to test not having the
proper hardware support? (on a running kwin, i know autotests have a
fake libinput that injects events)
I wonder on how many devices thoise events will actually work as 
intended...


From libinput documentation it seems to only be Lenovo Yoga currently. 
And you probably need a rather new kernel, maybe even unreleased ones. 
This is a pretty brand new feature in libinput and I don't think it's 
widely exposed.


Best ask Peter Hutterer, he will also be able to help you get your 
device supported so that we have it for everyone. I expect this will be 
a great crowd effort which should be doable. If we have the 
infrastructure and easy way to test/debug, we should be able to get some 
users to help there.


Cheers
Martin



On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser  
wrote:
I want to provide a dbus service in KWin to export the state. Apps 
cannot use libinput directly, one needs root for that.


Cheers
Martin

Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin 
:

Hi all,
one thing i wanted to look into, is to detect when a trasformable
laptop goes
in tablet mode from applications, so that plasmashell and kirigami 
apps

can
adapt themselves and do things(tm)
KWin does that (on wayland) already, and i see it uses libinput for
that, like
i seem to evince from this recent commit (and the logic when to show
the on
screen keyboard)
https://cgit.kde.org/kwin.git/commit/?
id=ac2f41c86d3b5b13ba3655e6c2f17f59a4cb7f01

would a normal application use libinput too or is something reserved 
to

the
compositor?
what would be the right way(tm) there? a dbus signal from KWin?

Re: detecting tablet mode

[Martin Flöser]

Am 2018-01-05 12:48, schrieb Marco Martin:

I would like to give it a try about it if you don't mind(ie had
precise plans or code started)..


I don't mind :-)


so i was thinking about a property for the current state, plus a
signal for state change.
as for the location, into ConnectionAdaptor would probably be the
easiest, iff makes semantically sense it comes from
org.kde.KWin.InputDeviceManager, which is proably arguable for both
yes and no ;)


I wouldn't put it into ConnectionAdaptor. What I had in mind was basing 
it on top of D9521 which passes the event down into KWin core. That way 
other areas in KWin can use it.


So I would do something like a small class

class TabletModeManager : public QObject, public InputEventSpy
{
};

and monitor from there whatever the state is. That would make the 
feature independent from the libinput implementation.


Cheers
Martin



On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser  
wrote:
I want to provide a dbus service in KWin to export the state. Apps 
cannot use libinput directly, one needs root for that.


Cheers
Martin

Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin 
:

Hi all,
one thing i wanted to look into, is to detect when a trasformable
laptop goes
in tablet mode from applications, so that plasmashell and kirigami 
apps

can
adapt themselves and do things(tm)
KWin does that (on wayland) already, and i see it uses libinput for
that, like
i seem to evince from this recent commit (and the logic when to show
the on
screen keyboard)
https://cgit.kde.org/kwin.git/commit/?
id=ac2f41c86d3b5b13ba3655e6c2f17f59a4cb7f01

would a normal application use libinput too or is something reserved 
to

the
compositor?
what would be the right way(tm) there? a dbus signal from KWin?

D9201: Slightly reduce vertical gutter width.

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Thanks Chris!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9201

To: Zren, #plasma, hein
Cc: ngraham, abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9682: Don't build pci module on ARM

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:5d022b435fc4: Dont build pci module on ARM 
(authored by mart).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9682?vs=24783=24784

REVISION DETAIL
  https://phabricator.kde.org/D9682

AFFECTED FILES
  Modules/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9682: Don't build pci module on ARM

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D9682

To: mart, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9682: Don't build pci module on ARM

[Marco Martin]

mart updated this revision to Diff 24783.
mart removed a reviewer: broulik.
mart added a comment.
This revision now requires review to proceed.


  also exclude aarch64

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9682?vs=24782=24783

BRANCH
  phab/npciarm

REVISION DETAIL
  https://phabricator.kde.org/D9682

AFFECTED FILES
  Modules/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.


  I'm ok with the part of the patch that moves availability property from Port 
to Profile. Adding availableProfiles is not a good way to achieve what you want 
though. Profiles should be filtered on QML side.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

[Kai Uwe Broulik]

broulik added a comment.


  Seems to cause weird crashes regularly for me :/ (probably the `callLater`?)
  
#0  0x722611b5 in QV4::QObjectWrapper::wrap(QV4::ExecutionEngine*, 
QObject*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#1  0x722d9816 in ?? () from 
/usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#2  0x722da786 in 
QV4::QObjectWrapper::getQmlProperty(QQmlContextData*, QV4::String*, 
QV4::QObjectWrapper::RevisionMode, bool*, bool) const () from 
/usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#3  0x722f11d7 in 
QV4::Runtime::method_getProperty(QV4::ExecutionEngine*, QV4::Value const&, int) 
() from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: detecting tablet mode

[Marco Martin]

debugging a bit what happens currently on my machine, i don't seem to
have any event device which libinput_device_switch_has_switch,
however, when i flip it, i do get an event, but oddly from the event
device called
"intel virtual button driver" and i get a key event of id 240.
do you think it's a kernel problem and can'tbe made work on our level?
I can also try to do the patch blindly, but how to test not having the
proper hardware support? (on a running kwin, i know autotests have a
fake libinput that injects events)
I wonder on how many devices thoise events will actually work as intended...

On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser  wrote:
> I want to provide a dbus service in KWin to export the state. Apps cannot use 
> libinput directly, one needs root for that.
>
> Cheers
> Martin
>
> Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin :
>>Hi all,
>>one thing i wanted to look into, is to detect when a trasformable
>>laptop goes
>>in tablet mode from applications, so that plasmashell and kirigami apps
>>can
>>adapt themselves and do things(tm)
>>KWin does that (on wayland) already, and i see it uses libinput for
>>that, like
>>i seem to evince from this recent commit (and the logic when to show
>>the on
>>screen keyboard)
>>https://cgit.kde.org/kwin.git/commit/?
>>id=ac2f41c86d3b5b13ba3655e6c2f17f59a4cb7f01
>>
>>would a normal application use libinput too or is something reserved to
>>the
>>compositor?
>>what would be the right way(tm) there? a dbus signal from KWin?

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9072: make ksshaskpass work with git-lfs

[Martin Koller]

mkoller added a comment.


  ping

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

To: mkoller, cfeck, jriddell, whiting
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham retitled this revision from "Use combobox to choose shadow size and 
reduce menu shadows to 25% of window shadow size" to "Use combobox to choose 
shadow size and use more appropriate values for menu & tooltip shadow sizes".

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and reduce menu shadows to 25% of window shadow size

[Nathaniel Graham]

ngraham retitled this revision from "Reduce menu shadows to 25% of the window 
shadow size" to "Use combobox to choose shadow size and reduce menu shadows to 
25% of window shadow size".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Nathaniel Graham]

ngraham updated this revision to Diff 24771.
ngraham added a comment.


  Use combobox to determine shadow size (massive amount of help from Hugo)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9627?vs=24674=24771

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/breezeconfigwidget.cpp
  kdecoration/config/ui/breezeconfigurationui.ui
  kstyle/breeze.kcfg
  kstyle/breezeshadowhelper.cpp

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9478: Drop use of qtpaths in startkde

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R120:fd7d1ca3d705: Drop use of qtpaths in startkde (authored 
by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9478?vs=24712=24770

REVISION DETAIL
  https://phabricator.kde.org/D9478

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasmacompositor.cmake

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9668: Fix keyboard navigation not working after opening Folder View popup.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1466a873db05: Fix keyboard navigation not working after 
opening Folder View popup. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9668?vs=24743=24769

REVISION DETAIL
  https://phabricator.kde.org/D9668

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9600: [Look and feel package definition] Add X-Plasma-Capabilities

[Kai Uwe Broulik]

broulik abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9600

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9601: Make media controls configurable

[David Edmundson]

davidedmundson added a comment.


  > maybe we need a lnf specific config module? It's not the first feature 
where I would say that this actually doesn't belong into kscreenlocker kcm as 
it's specific to the theme.
  
  I like half of that.
  
  I think configuring the look and feel package somewhere separate would be a 
very weird user experience. 
  You'd want to configure things for the lockscreen in the lockscreen.
  
  But, having the lnf provide the config makes sense.
  
  If we added a screenlocker config to the lnf and then loaded that in this UI 
in the same way that we do wallpapers that would be perfect.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9600: [Look and feel package definition] Add X-Plasma-Capabilities

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't think this can work (as per comment in kscreenlocker review)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9600

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9658: Use explicit palette interface

[David Edmundson]

davidedmundson updated this revision to Diff 24765.
davidedmundson added a comment.


  Lazy create the palette manager

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9658?vs=24722=24765

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9658

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp
  src/platformtheme/kwaylandintegration.h

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: detecting tablet mode

[Marco Martin]

I would like to give it a try about it if you don't mind(ie had
precise plans or code started)..
so i was thinking about a property for the current state, plus a
signal for state change.
as for the location, into ConnectionAdaptor would probably be the
easiest, iff makes semantically sense it comes from
org.kde.KWin.InputDeviceManager, which is proably arguable for both
yes and no ;)

On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser  wrote:
> I want to provide a dbus service in KWin to export the state. Apps cannot use 
> libinput directly, one needs root for that.
>
> Cheers
> Martin
>
> Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin :
>>Hi all,
>>one thing i wanted to look into, is to detect when a trasformable
>>laptop goes
>>in tablet mode from applications, so that plasmashell and kirigami apps
>>can
>>adapt themselves and do things(tm)
>>KWin does that (on wayland) already, and i see it uses libinput for
>>that, like
>>i seem to evince from this recent commit (and the logic when to show
>>the on
>>screen keyboard)
>>https://cgit.kde.org/kwin.git/commit/?
>>id=ac2f41c86d3b5b13ba3655e6c2f17f59a4cb7f01
>>
>>would a normal application use libinput too or is something reserved to
>>the
>>compositor?
>>what would be the right way(tm) there? a dbus signal from KWin?

Re: detecting tablet mode

[Dan Leinir Turthra Jensen]

i am more than a little interested in having something like this to listen to. 
Windows being the only system with this detection in place (for several years 
now) just seems so silly... Also because it breaks every few weeks on there, 
where i expect we might be able to do /slightly/ better, at least ;) This lack 
has been, effectively, my main reason for not getting anywhere with the Gemini 
framework... not being able to test it on Linux based systems just makes it 
that much less interesting to play with :D

On Friday, 5 January 2018 05:23:20 GMT Martin Flöser wrote:
> I want to provide a dbus service in KWin to export the state. Apps cannot
> use libinput directly, one needs root for that.
> 
> Cheers
> Martin
> 
> Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin :
> >Hi all,
> >one thing i wanted to look into, is to detect when a trasformable
> >laptop goes
> >in tablet mode from applications, so that plasmashell and kirigami apps
> >can
> >adapt themselves and do things(tm)
> >KWin does that (on wayland) already, and i see it uses libinput for
> >that, like
> >i seem to evince from this recent commit (and the logic when to show
> >the on
> >screen keyboard)
> >https://cgit.kde.org/kwin.git/commit/?
> >id=ac2f41c86d3b5b13ba3655e6c2f17f59a4cb7f01
> >
> >would a normal application use libinput too or is something reserved to
> >the
> >compositor?
> >what would be the right way(tm) there? a dbus signal from KWin?


-- 
..dan / leinir..
http://leinir.dk/

D9659: Remove now unused set window property

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:ba25aa68afda: Remove now unused set window property 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9659?vs=24723=24764#toc

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9659?vs=24723=24764

REVISION DETAIL
  https://phabricator.kde.org/D9659

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp
  src/platformtheme/kwaylandintegration.h

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[Kai Uwe Broulik]

broulik added a comment.


  +1
  
  I can verify that it makes VLC player's "Speed" sub menu in its tray icon 
work, checked that Qt's code is identical.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9657: Add manual test for win deco palettes

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:189a19f4e40d: Add manual test for win deco palettes 
(authored by davidedmundson).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9657?vs=24721=24763

REVISION DETAIL
  https://phabricator.kde.org/D9657

AFFECTED FILES
  CMakeLists.txt
  tests/CMakeLists.txt
  tests/windowdecotest.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 50 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/50/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 05 Jan 2018 09:56:07 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D9657: Add manual test for win deco palettes

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9657

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9658: Use explicit palette interface

[Kai Uwe Broulik]

broulik added a comment.


  lgtm

INLINE COMMENTS

> kwaylandintegration.cpp:72
> +if (paletteManagerInterface .name != 0) {
> +m_paletteManager = 
> registry->createServerSideDecorationPaletteManager(paletteManagerInterface.name,
>  paletteManagerInterface.version, this);
> +}

Can't we create these the first time an app sets a palette since hardly any 
apps actually do?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9658

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9659: Remove now unused set window property

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9659

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/49/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 05 Jan 2018 09:24:52 +
 Build duration:
6 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 667.13 KB...]Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 15%] Automatic MOC for target kcm_desktopthemeAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/desktoptheme/kcm.cpp"The file includes the moc file "kcm.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/kcm.mocGenerating MOC source EWIEGA46WW/moc_kcm.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 15%] Automatic MOC for target kcm_standard_actionsAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/standard_actions/standard_actions_module.cpp"The file includes the moc file "standard_actions_module.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/standard_actions_module.mocGenerating MOC source EWIEGA46WW/moc_standard_actions_module.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 15%] Automatic MOC for target kcm_keysAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/keys/globalshortcuts.cpp"The file includes the moc file "globalshortcuts.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/moc_export_scheme_dialog.cppGenerating MOC source include/globalshortcuts.mocGenerating MOC source include/moc_select_scheme_dialog.cppGenerating MOC source EWIEGA46WW/moc_globalshortcuts.cppGenerating MOC source EWIEGA46WW/moc_kglobalshortcutseditor.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 15%] Automatic MOC for target kcm_smserverAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/ksmserver/kcmsmserver.cpp"The file includes the moc file "kcmsmserver.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source include/kcmsmserver.mocGenerating MOC source EWIEGA46WW/moc_kcmsmserver.cppGenerating MOC source EWIEGA46WW/moc_smserverconfigimpl.cppGenerating MOC compilation mocs_compilation.cpp[ 15%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 15%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/lookandfeel/kcm_lookandfeel-kcms-metadata.json" [ 15%] Built target kcm_lookandfeel-kcms-metadata-jsonScanning dependencies of target lookandfeeltool_autogen[ 15%] Generating klauncher_iface.cpp, klauncher_iface.h[ 15%] Automatic MOC for target lookandfeeltoolAutoMoc: Warning: "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/kcms/lookandfeel/kcm.cpp"The file includes the moc file "kcm.moc", but does not contain a Q_OBJECT or Q_GADGET macro.Generating MOC source 

D9655: [Kickoff] Hide tab bar if only one tab button is configured

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9655

To: broulik, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9655: [Kickoff] Hide tab bar if only one tab button is configured

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cc0e08dc8846: [Kickoff] Hide tab bar if only one tab 
button is configured (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9655?vs=24714=24759

REVISION DETAIL
  https://phabricator.kde.org/D9655

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9635: [AppMenuModel] Monitor window properties

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b12647946e19: [AppMenuModel] Monitor window properties 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9635?vs=24658=24758

REVISION DETAIL
  https://phabricator.kde.org/D9635

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b711b7073fd5: [DBusMenuImporter] Send opened 
signal alongside about to show (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9631?vs=24657=24757

REVISION DETAIL
  https://phabricator.kde.org/D9631

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9601: Make media controls configurable

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9601: Make media controls configurable

[Kai Uwe Broulik]

broulik updated this revision to Diff 24754.
broulik added a comment.


  - Always show media controls config

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9601?vs=24567=24754

REVISION DETAIL
  https://phabricator.kde.org/D9601

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  kcfg/kscreenlockersettings.kcfg
  kcm/kcm.ui

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

[Kai Uwe Broulik]

broulik updated this revision to Diff 24753.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - Check for != application windows

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9661?vs=24728=24753

REVISION DETAIL
  https://phabricator.kde.org/D9661

AFFECTED FILES
  tabbox/clientmodel.cpp

To: broulik, #plasma, #vdg
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9668: Fix keyboard navigation not working after opening Folder View popup.

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9668

To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9601: Make media controls configurable

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:136
> This won't work.
> 
> Kpacakges don't inherit metadata, so I think if you changed to breeze-dark 
> you'd get the controls but lose the ability to turn them off.
> You can't assume that authors should copy metadata, as we existing packages 
> out there.
> 
> But also you can't just iterate through parent packages metadata either, what 
> if someone inherited Breeze but then *did* replace the lockscreen.
> 
> I can't think of anything that'll work, other than just adding "if available" 
> to the config label and skipping this.

> I can't think of anything that'll work, other than just adding "if available" 
> to the config label and skipping this.

Okay… that was the main reason I didn't add this months ago

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart