D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 26407.
anemeth added a comment.


  Added breezeblurhelper files

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26406&id=26407

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 26406.
anemeth added a comment.


  Moved blur handling to breezeblurhelper

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26329&id=26406

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This also sort of broke using ESC to close, because that's what
  users try next, but after clicking on the desktop the dialog no
  longer has focus.
  
  I examined the revision that introduced this change 
(https://phabricator.kde.org/R119:e635931e433cb31d1fe23e40c8af625a8f7c24f2)
  but saw no good reason for it. It was likely accidental.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10263

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10262: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Writing just a sausage name into the test color scheme file confuses
  both the human reader (and makes them go away from the computer to the
  kitchen, productivity--) and also annoys the scheme file parser,
  with no obvious purpose for this test

REPOSITORY
  R119 Plasma Desktop

BRANCH
  sausagesonlyinkitchen

REVISION DETAIL
  https://phabricator.kde.org/D10262

AFFECTED FILES
  kcms/lookandfeel/autotests/kcmtest.cpp

To: kossebau, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Oh, and this fixes the unit test "KcmTest::testKCMSave()" which is failing 
since https://phabricator.kde.org/R119:cf49d415e7bb30e98c0e7529e7307d8449b8ffcd 
(both in 5.12 and master after yesterday's merge).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10259

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10259

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Another option would be to move the
  
configGroup.writeEntry("ColorScheme", scheme); 
  
  behind the config-copy loop.
  
  But then I would think that we do not want to blend in the kdeglobals config 
into the color schemes files data in general, or? There is similar color scheme 
loading code below "kcms/colors/", where also the kdeglobals are blended in. 
Those might need to be fixed as well then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10259

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: broulik, davidedmundson, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Using one argument with "KSharedConfig::openConfig(filename)" actually
  results in using the default value for the second argument, "FullConfig".
  Which results also in "Blend kdeglobals into the config object."
  As a result the color scheme file opened in KCMLookandFeel::setColors(...)
  this way has the complete global config groups and settings (with the data
  as stored on the disc, not in any runtime working copies) mapped into the
  profile (incl. e.g. the group "[General]" with the entry "ColorScheme").
  So when then all the groups are copied over from the scheme config, actually
  also all the stored global config groups and settings are copied over,
  overwriting the not yet synced [General]/ColorScheme entry which was just
  set a few lines before with the old value from the storage.
  
  Possibly the old code which was doing the sync right after setting the new
  scheme value had been there exactly to protect against that
  (cmp. change in 
https://phabricator.kde.org/R119:cf49d415e7bb30e98c0e7529e7307d8449b8ffcd).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixsettingcolorschemelnf

REVISION DETAIL
  https://phabricator.kde.org/D10259

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10148: KCM: Show only available device profiles

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  This leads to the wrong profile being selected. Because some profiles are 
excluded from the model the indices don't match anymore.

REVISION DETAIL
  https://phabricator.kde.org/D10148

To: drosca, #plasma, nicolasfella
Cc: nicolasfella, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10148: KCM: Show only available device profiles

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CardListItem.qml:57
>  Layout.fillWidth: true
> -model: Profiles
> +model: {
> +var m = [];

model: Profiles.filter(function (profile) {
  return profile.availability === Profile.Available;
  })

REVISION DETAIL
  https://phabricator.kde.org/D10148

To: drosca, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  The business logic was using the resolved URL in lookups in
  internal data structures, instead of the internal key it
  previously established equivalence to. This could lead to
  junk in internal maps and unnecessarily emitted model changes.
  
  This also improves the unit test not to require apps to be
  installed, fixing the CI failure over missing Dolphin.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10253

AFFECTED FILES
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/launchertasksmodel.cpp

To: hein, #plasma, kossebau
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/27/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 18:39:05 +
 Build duration:
3 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 536.03 KB...]Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 11%] Automatic MOC for target kcm_standard_actions[ 11%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 11%] Automatic MOC for target kcm_keys[ 11%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/

D10251: [RFC] Use mipmap filtering in window thumbnails

[Eike Hein]

hein added a comment.


  It's definitely nicer, but could we go for the full thing and make it crisper 
too?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Re: Plasma 4 bug reports: Open for bugs

[David Edmundson]

Done.

D10252: Applet: Use new device icons

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10252

To: drosca, #plasma, andreask, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Re: Plasma 4 bug reports: Open for bugs

[pointedstick]

 On Fri, 02 Feb 2018 07:46:11 -0800 Marco Martin  wrote  
>On Thu, Feb 1, 2018 at 10:19 PM, David Edmundson 
> wrote: 
>> In bugzilla a product can be "Open for bug entry" or not. 
>> It can also be done at a per-version level. 
>> 
>> When unset a user will not see it in the "enter bug" list, or the version 
>> won't be listed. If they force it, they'll get a message like: 
>> https://bugs.kde.org/enter_bug.cgi?product=Aktion 
>> 
>> Currently Plasma 4 is "open for bug entry". 
>> 
>> One can also enter a bug on the 4.x entries on products like systemsettings, 
>> kscreenlocker etc. 
>> 
>> Should we disable them? It still gets a few every month and it's wasting the 
>> user's time if we're clearly not going to do anything with it. 
> 
>+1 for closing 4.x 
>-- 
>Marco Martin 

+2. Let's do it. Who has the power? If someone can get me access, I can take 
care of this and all subsequent requests of this nature. I have an unusual love 
for well-functioning bug trackers.

Nate

D10252: Applet: Use new device icons

[David Rosca]

drosca created this revision.
drosca added reviewers: Plasma, andreask.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
drosca requested review of this revision.

REVISION SUMMARY
  They were now added to Breeze icon theme

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10252

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: drosca, #plasma, andreask
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10188: Sanitise notification HTML

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in notificationsanitizer.cpp:45
> They don't, because that's not what we're parsing.
> 
> We will parse Ä  which is handled
> 
> Sending Ä will get Ä   
> Sending Ä will show Ä
> 
> Old code is the same.

I see. Nevermind then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: broulik, aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10188: Sanitise notification HTML

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in notificationsanitizer.cpp:45
> We need a `QXmlStreamEntityResolver` like `KNotification` has otherwise HTML 
> entities like `Ä` (for `Ä`) will error out.

They don't, because that's not what we're parsing.

We will parse Ä  which is handled

Sending Ä will get Ä   
Sending Ä will show Ä

Old code is the same.

> broulik wrote in notificationsanitizer.cpp:72
> Don't write `alt` if it doesn't have one?

QmlStreamWriter skips it if the value is empty

> broulik wrote in notificationsengine.cpp:265
> Won't you end up with piles of `` tags since `_body` is the body text 
> of the notification it would group to.
> 
>   
>   
>   old notification
>   
>   new notification
>   
> 
> Not that it really matters, though.

Oh, I didn't think about that code. You're right.

I'll add a .mid()

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: broulik, aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> view.cpp:246
> -
> m_plasmaShellSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::WindowsGoBelow);
> -m_plasmaShellSurface->setPanelTakesFocus(true);
> -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel);

Don't we still need this somewhere?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10250: track the validity of the texture

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Good analysis on the plotter. Thanks for looking into it.
  
  > but in some rare cases, it can be deleted too by some external cause, 
usually when a widget changes its parent
  
  If someone deletes something that's meant to be ref-counted it's being used 
wrong.  
  If there was a real bug in ManagedTextureNode we would have seen it in all 
the code that already used it; iconitem, framesvgitem, etc...
  
  This is just a bug in plotter. If you do need to reverse the smart pointer 
logic to have a weak pointer, keep it within there.
  
  Btw, you don't need managedtexturenode unless you're using the texturecache, 
since Qt 5.4 you can use QSGSimpleTextureNode::setOwnsTexture.   It might help?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D10250

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, ngraham, plasma-devel, #frameworks, michaelh, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10188: Sanitise notification HTML

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for taking care of this.

INLINE COMMENTS

> notificationsanitizer.cpp:45
> +
> +QXmlStreamReader r(QStringLiteral("") + t + 
> QStringLiteral(""));
> +QString result;

We need a `QXmlStreamEntityResolver` like `KNotification` has otherwise HTML 
entities like `Ä` (for `Ä`) will error out.

> notificationsanitizer.cpp:72
> +
> +out.writeAttribute(QStringLiteral("alt"), alt);
> +}

Don't write `alt` if it doesn't have one?

> notificationsanitizer.h:2
> +/*
> + *   Copyright (C) 2017 David Edmundson 
> + *

2018

> notificationsengine.cpp:265
>  QString bodyFinal = (partOf == 0 ? body : _body);
> -// First trim whitespace from beginning and end
> -bodyFinal = bodyFinal.trimmed();
> -// Now replace all \ns with 
> -bodyFinal = bodyFinal.replace(QLatin1String("\n"), 
> QLatin1String(""));
> -// Now remove all inner whitespace (\ns are already s
> -bodyFinal = bodyFinal.simplified();
> -// Finally, check if we don't have multiple s following,
> -// can happen for example when "\n   \n" is sent, this replaces
> -// all s in succsession with just one
> -
> bodyFinal.replace(QRegularExpression(QStringLiteral("\\s*(\\s|)*")),
>  QLatin1String(""));
> -// This fancy RegExp escapes every occurence of & since QtQuick Text 
> will blatantly cut off
> -// text where it finds a stray ampersand.
> -// Only &{apos, quot, gt, lt, amp}; as well as { character 
> references will be allowed
> -
> bodyFinal.replace(QRegularExpression(QStringLiteral("&(?!(?:apos|quot|[gl]t|amp);|#)")),
>  QLatin1String("&"));
> -// The Text.StyledText format handles only html3.2 stuff and ' is 
> html4 stuff
> -// so we need to replace it here otherwise it will not render at all.
> -bodyFinal.replace(QLatin1String("'"), QChar('\''));
> +bodyFinal = NotificationSanitizer::parse(bodyFinal);
>  

Won't you end up with piles of `` tags since `_body` is the body text of 
the notification it would group to.

  
  
  old notification
  
  new notification
  

Not that it really matters, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: broulik, aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10184: Port mediawiki runner to Plasma5/Qt5

[Kai Uwe Broulik]

broulik added a comment.


  Lgtm

INLINE COMMENTS

> mediawiki.cpp:60
>  //FIXME: at the moment KIO doesn't seem to work in threads
>  d->manager = new QNetworkAccessManager( this );
>  //d->manager = new KIO::AccessManager( this );

Make sure to enable `QNetworkAccessManager` auto-redirect or else Ben will get 
mad at you

> mediawiki.cpp:134
>  
> -kDebug() << "Constructed search URL" << url;
> +qDebug() << "Constructed search URL" << url;
>  

Categorized logging, perhaps?

> mediawiki.h:74
>   */
> -MediaWiki( QObject *parent=0 );
> -virtual ~MediaWiki();
> +explicit MediaWiki(QObject* parent = nullptr);
> +~MediaWiki() override;

Asterisk goes to variable name, `QObject *parent` (pedantic)

> plasma-runner-wikipedia.desktop:118
>  
> -X-Plasma-Args=http://en.wikipedia.org/w/api.php

Is there a chance we can make this user-configurable or perhaps have it use the 
current language automatically? (Just asking, it's fine if you just did a 
straight port)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10184

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10250: track the validity of the texture

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> managedtexturenode.cpp:42
> +{
> +if (s_d.contains(this)) {
> +delete s_d[this];

`delete s_d.take(this);`

> managedtexturenode.cpp:50
> +{
> +if (s_d.contains(this)) {
> +return s_d[this];

auto *d = s_d.value(this);
  if (!d) {
  d = new ManagedTextureNodePrivate();
  s_d.insert(this, d);
  }
  return d;

> managedtexturenode.cpp:68
> +{
> +return d_ptr()->textureTracker;
> +}

Can you perhaps prevent creation of the `ManagedTextureNodePrivate` for this 
check? `d_ptr()` would create it just to then see that its `textureTracker` is 
`null`. (Might be worth profiling, though)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D10250

To: mart, #plasma
Cc: broulik, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 4 bug reports: Open for bugs

[Marco Martin]

On Thu, Feb 1, 2018 at 10:19 PM, David Edmundson
 wrote:
> In bugzilla a product can be "Open for bug entry" or not.
> It can also be done at a per-version level.
>
> When unset a user will not see it in the "enter bug" list, or the version
> won't be listed. If they force it, they'll get a message like:
> https://bugs.kde.org/enter_bug.cgi?product=Aktion
>
> Currently Plasma 4 is "open for bug entry".
>
> One can also enter a bug on the 4.x entries on products like systemsettings,
> kscreenlocker etc.
>
> Should we disable them? It still gets a few every month and it's wasting the
> user's time if we're clearly not going to do anything with it.

+1 for closing 4.x
--
Marco Martin

D10247: Add a width ratio to the OverlaySheet

[Igor Cota]

icota abandoned this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10247

To: icota, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik added a comment.


  Before and after:
  F5688790: before-after.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.

REVISION SUMMARY
  Blit the contents of the window texture to a separate mipmap texture, and 
(re)generate the mipmaps on each damage event.
  
  The mipmap filter is the default linear filter, which results in soft images. 
Using a filter with a sharpening kernel, such as a cubic or a windowed sinc 
filter would produce better results, but this is still an improvement over not 
using a mipmap filter at all.
  
  The scaling is gamma-correct when desktop GL is used.
  
  Note that this patch only modifies the GLX path.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  If this is only a change for the "disconnected wifi" icon, then maybe we 
should mimic the "disconnected wired network" icon and make the color red, 
rather than fiddling with the lightness, which will never satisfy everyone (if 
this merged, I predict bug reports that say "The disconnected wifi icon looks 
almost exactly like the connected wifi icon!")

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10247: Add a width ratio to the OverlaySheet

[Marco Martin]

mart added a comment.


  hmm I don't think this is the right approach to it.. it should rather use 
size hints from the sheet contents (which if you want can also be a ratio of 
whatever the parent, but that would be user-specific)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10247

To: icota, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

D10247: Add a width ratio to the OverlaySheet

[Igor Cota]

icota added a reviewer: Kirigami.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10247

To: icota, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10250: track the validity of the texture

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  the texture of ManagedTextureNode gets deleted by the
  refcountung of the internal QSharedPointer,
  but in some rare cases, it can be deleted too by some
  external cause, usually when a widget changes its parent
  window (either changing containment or switching between
  full/collapsed view)
  dragging a system monitor applet that uses the plotter
  component between the desktop and panel quite reliably
  crashes plasma, as it was trying to access the texture that may
  have become invalid at the moment.
  track it also with a qpointer which is used only to provide
  an hasValidTexture boolean which should be checked before
  accessing the texture of the node.
  
  BUG:388508
  BUG:374280
  BUG:365052
  BUG:343576

TEST PLAN
  The bug is easily reproducible without the patch, wasn't
  able to reproduce it anymore with it

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/guardTexture

REVISION DETAIL
  https://phabricator.kde.org/D10250

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
  src/qmlcontrols/kquickcontrolsaddons/plotter.h
  src/quickaddons/managedtexturenode.cpp
  src/quickaddons/managedtexturenode.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks @andreask. Could we also see what it looks like next to the icon with 
all bars filled, or with only a few filled? This looks better for disconnected 
ones, but without seeing those use cases, it do worry that the presentation 
becomes too muddy for weak connections.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

[Nathaniel Graham]

ngraham resigned from this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8054: Show headset icons for devices identifying as "Headset" in Description

[Andreas Kainz]

andreask added a comment.


  icons are added to breeze-icons

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D8054

To: antlarr, #plasma, davidedmundson, drosca
Cc: andreask, drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D10151: Correction with the & problem in tabs

[Sergio Carlavilla]

carlavilla retitled this revision from "Solved bug 382512" to "Correction with 
the & problem in tabs".
carlavilla edited the summary of this revision.
carlavilla edited the test plan for this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

[Sergio Carlavilla]

carlavilla added a comment.


  Sorry for my late response, but I've been moving all week.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10151: Solved bug 382512

[Laurent Montel]

mlaurent added a comment.


  Ping ?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D10151

To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 4 bug reports: Open for bugs

[David Edmundson]

On Fri, Feb 2, 2018 at 5:43 AM, Martin Flöser  wrote:

> Am 2018-02-01 22:19, schrieb David Edmundson:
>
>> In bugzilla a product can be "Open for bug entry" or not.
>> It can also be done at a per-version level.
>>
>> When unset a user will not see it in the "enter bug" list, or the
>> version won't be listed. If they force it, they'll get a message like:
>> https://bugs.kde.org/enter_bug.cgi?product=Aktion
>>
>> Currently Plasma 4 is "open for bug entry".
>>
>> One can also enter a bug on the 4.x entries on products like
>> systemsettings, kscreenlocker etc.
>>
>
> kscreenlocker is still a product in 5.
>

To clarify, I'm suggesting in addition to turning off the product Plasma4,
we turn off reporting on 4.x on the products that are still relevant in
5.x.

>If we apply that rule for more prodcuts, it would be super awesome to
automate. I just noticed that all 5.11 versions were still open for bugs.

There's a script in releaseme for creating versions in all products. I'm
sure it could be made to disable versions.

D10247: Add a width ratio to the OverlaySheet

[Igor Cota]

icota created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
icota requested review of this revision.

REVISION SUMMARY
  Instead of hardcoding the OverlaySheet to half the mainItem width multiply by 
the ratio to enable wider or skinnier sheets

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10247

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: icota
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  F5688471: wifi icon.png 
  top after
  
  - breeze(light)
  - breeze-dark
  
  bottom before
  
  - breeze(light)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5209: Load translations from KPackage files if bundled

[Luigi Toscano]

ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI 
& KEXI frameworks stable is 3.1.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: ltoscano, Zren, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask retitled this revision from "Improve visibility of disconnected Wi-Fi 
icon" to "Improve visibility of disconnected Wi-Fi icons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icon

[Andreas Kainz]

andreask retitled this revision from "Disconnected wi-fi icons are almost 
invisible BUG:384018" to "Improve visibility of disconnected Wi-Fi icon".
andreask edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Aleksandar Varagic]

avaragic accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  libinput-event-device

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt, avaragic
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart