Re: What does LTS mean again?

[Sebastian Kügler]

On Tue, 20 Feb 2018 23:34:33 +
Jonathan Riddell  wrote:

> On Tue, Feb 20, 2018 at 09:13:42PM +0100, Sebastian Kügler wrote:
> > Hi,
> > 
> > I know we talked about it extensively and even put it into writing,
> > but I can't find it anymore. What does our LTS promise for 5.12
> > entail?  
> 
> Bugfix releases happen over a longer term.
> 
> https://community.kde.org/Schedules/Plasma_5

I recall that we had a much clearer definition than that, and that we
actually wrote it down. What I recall:

- Bugfixes releases guaranteed at least 1.5 years (or was it 2?)
- Wayland explicitely part of this promise
- All modules in kde/workspace
- outside of the release dates planned in above schedule, we'll release
  updates as needed

But:
- What about the frameworks dependency, will we be shipping important
  bugfixes to 5.43 as well (like we did with Plasma 5.8)?

-- 
sebas

http://vizZzion.org   ⦿http://www.kde.org

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Aleix Pol Gonzalez]

apol added a comment.


  For some reason, didn't see this review >.<. Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> systemtray.h:30
>  class QQuickItem;
> +class QQuickWindow;
>  class PlasmoidModel;

Why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10091: Combine source and version into a single piece of metadata

[Andrew Crouthamel]

acrouthamel added a comment.


  I would also change `Also available in` to `Also available:`, since adding 
the version number in front of the sentence doesn't flow correctly in English.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10091

To: ngraham, apol, #discover_software_store, #vdg
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Nathaniel Graham]

ngraham added a comment.


  Thanks! I'll land this later tonight, if Alex doesn't beat me to it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  diffD10701

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10429: Disable the title bar separator by default

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, 
anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D10032: Swap play/pause icons in mediacontroller plasmoid

[Chris Rizzitello]

rizzitello added a comment.


  We place this item in the system tray by default. This being a place were 
users expect to be able to at a glance get some quick info about things their 
system is doing. While media is playing the play icon is what most users would 
expect to see. I do agree that this needs its own icon and should not reusing 
the play and pause actions.
  
  In D10032#195166 , @ngraham wrote:
  
  > Someone in the VDG room suggested the following (or something like it) for 
the "currently playing something" icon: 
http://www.iconninja.com/files/407/146/323/note-audio-play-sound-listen-song-music-icon.svg
  >
  > And when not playing, it could have a line through the note, or display the 
note using a very light color, or something like that. I think this approach 
could resolve the impasse.
  
  
  Showing that icon is fine if have a static icon, otherwise we should use some 
form of play and pause icons they are synonymous with the actions and using 
others will confuse alot more users.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10032

To: nicolasfella, #plasma, #vdg
Cc: rizzitello, abetts, davidedmundson, broulik, ngraham, plasma-devel, #vdg, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10429: Disable the title bar separator by default

[Chris Rizzitello]

rizzitello added a comment.


  I'm a breeze dark user and the current color is just way to strong on this 
theme as @ngraham said above. It was quite jarring to have this bright line on 
my window out of nowhere. If we can not find a more muted color then my vote 
its  +1 disable  no need to remove it its a low maintance

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10697: Make the badge text readable on dark color schemes

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:00f113eacb03: Make the badge text readable on dark color 
schemes (authored by mwolff).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10697?vs=27637=27725

REVISION DETAIL
  https://phabricator.kde.org/D10697

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Badge.qml

To: mwolff, broulik, hein
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

[Andras Mantia]

amantia added reviewers: Plasma, hein.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10728

To: amantia, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10729: Improve detecting D between two screen showing the same URL

[Andras Mantia]

amantia added reviewers: Plasma, hein, mwolff.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10729

To: amantia, #plasma, hein, mwolff
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andreas Krutzler]

akrutzler updated this revision to Diff 27724.
akrutzler added a comment.


  Rebase to origin/Plasma/5.12.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10701?vs=27642=27724

BRANCH
  diffD10701

REVISION DETAIL
  https://phabricator.kde.org/D10701

AFFECTED FILES
  discover/qml/Shadow.qml

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  An alternate idea:
  
  - we open it without giging focus
  - the current show time is 5 seconds
  - after 2 seconds (1 would be enough?) we check if there was user activity 
with kidletime
  - if there was activity, if the notifier doesn't contain the cursor or isn't 
focused, then close it
  - otherwise the usual 5 seconds

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10723: hide primary display combo when not supported

[Sebastian Kügler]

sebas created this revision.
sebas added reviewers: Plasma, dvratil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sebas requested review of this revision.

REVISION SUMMARY
  Some backends, for example the kwayland backend, do not support
  setting the primary display. The backends already make their
  feature set known so we can just hide it from the UI.
  
  It's enough to hide it from the UI since setting it doesn't make
  any difference, the libkscreen backend will simply ignore it
  internally, so it's just honest to not show it.
  
  BUG:390638

TEST PLAN
  ran kscreen kcm on both, X11 and wayland platforms, combo
  and label are shown and hidden as expected

REPOSITORY
  R104 KScreen

BRANCH
  sebas/pcombo

REVISION DETAIL
  https://phabricator.kde.org/D10723

AFFECTED FILES
  kcm/src/widget.cpp
  kcm/src/widget.h

To: sebas, #plasma, dvratil
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart updated this revision to Diff 27715.
mart added a comment.


  - new approach: parent full reps to the dialog only when needed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10692?vs=27710=27715

BRANCH
  arcpatch-D10692

REVISION DETAIL
  https://phabricator.kde.org/D10692

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.h

To: mart, #plasma
Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> svgitem.cpp:50
>  
> +void SvgItem::componentComplete()
> +{

I don't see how this makes any difference.

Every setSomeProperty already calls scheduleImageUpdate regardless of whether 
we're complete or not.
and if you don't have any properties set, then there's nothing to polish.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Nathaniel Graham]

ngraham added a comment.


  Since this is a small bugfix, I'd like to land it on the Stable branch 
(Plasma 5.12). However, I can't easily do this using `arc` because you did the 
work on master without a branch (in the future, see 
https://community.kde.org/Infrastructure/Phabricator#Workflow). Can you put it 
on a branch and re-base this patch on Plasma 5.12 branch? Here's how to do that:
  
git checkout -b [branchname] #create a new branch
git fetch # fetch all changes from the remote repo
git rebase --onto origin/Plasma/5.12 master #re-base your branch onto the 
Plasma/5.12 branch
arc diff --update D10701 #update this diff
  
  See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart added a comment.


  now it depends from D10722 , which can 
preload it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart updated this revision to Diff 27710.
mart added a comment.


  - less hacks on this part, ones in libplasma enough

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10692?vs=27633=27710

BRANCH
  arcpatch-D10692

REVISION DETAIL
  https://phabricator.kde.org/D10692

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.h

To: mart, #plasma
Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  ping

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10142

To: graesslin, #frameworks, #kwin, #plasma
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  ping

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks
Cc: plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10440: Support modifier mouse/scroll action on internal decorated windows

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10440

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10549: Don't crash if the cursor theme fails to create

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10291

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10294: Init the icon in ShellClient::init

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10294

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10308: Send hoverLeave or hoverMotion after touch up on decoration

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10308

To: graesslin, #kwin, #plasma, ngraham
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10490

To: graesslin, #kwin, #plasma
Cc: davidedmundson, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10594: Disable window rule configuration for Wayland

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7bf4a94286a7: Disable window rule configuration for 
Wayland (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10594?vs=27375=27709

REVISION DETAIL
  https://phabricator.kde.org/D10594

AFFECTED FILES
  kcmkwin/kwinrules/main.cpp
  useractions.cpp
  useractions.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, iodelay, bwowk, hardening

D10431: Properly handle move during touch events

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:338c7362c9fb: Properly handle move during touch events 
(authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10431?vs=26890=27708

REVISION DETAIL
  https://phabricator.kde.org/D10431

AFFECTED FILES
  autotests/integration/quick_tiling_test.cpp
  input.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10722: other preload microoptimizations

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> iconitem.h:42
>  Q_OBJECT
> +Q_INTERFACES(QQmlParserStatus)
>  

`QQuickItem` should do that for you already

> svgitem.h:41
>  Q_OBJECT
> +Q_INTERFACES(QQmlParserStatus)
>  

Same here

> ScrollArea.qml:58
> +Component.onCompleted: {
> +if (contentItem.forceLayout !== undefined) {
> +contentItem.forceLayout();

`typeof contentItem.forceLayout === "function"`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  make svgitem schedule a polish right when it's done loading
  
  ScrollView now forces to layout items as soon is created, to preload items
  before the window is shown
  
  remove useless include

TEST PLAN
  possible to preload (almost) the whole systray with less hacks
  on that part (see D10692 )

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preloadmicropts

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/core/iconitem.h
  src/declarativeimports/core/svgitem.cpp
  src/declarativeimports/core/svgitem.h
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10325: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header 
(authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10325?vs=26642=27706

REVISION DETAIL
  https://phabricator.kde.org/D10325

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidgetdocktitlebar.cpp
  src/filewidgets/kfilewidgetdocktitlebar_p.h

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10710: update appMenu status only from qml side

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e6969f2c776f: update appMenu status only from qml side 
(authored by mvourlakos).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10710?vs=27677=27705

REVISION DETAIL
  https://phabricator.kde.org/D10710

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10586: [Task Manager] Limit badge label to a sane size

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3b526a3a2aa9: [Task Manager] Limit badge label to a sane 
size (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10586?vs=27355=27701

REVISION DETAIL
  https://phabricator.kde.org/D10586

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Badge.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10557: [Clipboard plasmoid] Split delegate into separate files

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7c644c4499c8: [Clipboard plasmoid] Split delegate into 
separate files (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10557?vs=27647=27702

REVISION DETAIL
  https://phabricator.kde.org/D10557

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/ImageItemDelegate.qml
  applets/clipboard/contents/ui/TextItemDelegate.qml
  applets/clipboard/contents/ui/UrlItemDelegate.qml

To: broulik, #plasma, graesslin, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10499: [spellcheck runner] Make each suggestion copyable as separate item

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Thanks for review.
  
  In D10499#210493 , @broulik wrote:
  
  > >   and then copy the correct or suggested into the clipboard for further 
usage?
  >
  > Calculator runner does `setText` on `QClipboard` in `run`, so I guess this 
is the way.
  
  
  Which seems to not be triggered when chosing the match though, from what I 
tested incl. extra debug log.
  
  Currently one has to use the action enabled on the match to get the result 
copied to the clipboard.
  
  So chance is that code is dead code, either due to being copy on plugin 
creation or due to policy changes in krunner plasma5 porting?
  
  > `InformationalMatch` causes the `data` to be set as query when run. Pick 
your poison.
  
  I guess that most use cases with this runner are when someone wants to use to 
correct term in other places, so on selecting the match people do not intend to 
have it as new query content for further queries, but have the term straight 
available for use in that other place (-> clipboard).
   So considering to take the HelperMatch pill. Though might also go for extra 
copy action as with calculator.

REPOSITORY
  R114 Plasma Addons

BRANCH
  spellrunnerMakeTermsCopyable

REVISION DETAIL
  https://phabricator.kde.org/D10499

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Closing old Plasma 4 bugs

[Nate Graham]

I have also cleaned up the bug triaging page: 
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging


It's still a bit long, so any further editing to condense it a bit would 
be welcome.


Nate



On 02/21/2018 07:16 AM, Nate Graham wrote:



On 02/21/2018 06:26 AM, Nate Graham wrote:




On Feb 21, 2018, at 12:59 AM, Ben Cooksley  wrote:

On Wed, Feb 21, 2018 at 9:34 AM, pointedstick 
 wrote:
I have editbugs power on bugs.kde.org, but cannot edit the 
Importance field
or mark a bug as CLOSED on bugstest.kde.org. I appear to have the 
new normal

permissions.


Thanks for confirming my testing Nate.

I've now gone ahead and rolled this out on bugs.kde.org.
Everyone who had editbugs rights already (all 3,221 of us) have been
made members of the new (fully empowered) contributors group.

If someone would like to announce this via a blog post please feel
free to do so as I likely won't have time in the next few days to do
so.


Fantastic! I'll do that.


Done: 
https://pointieststick.wordpress.com/2018/02/21/its-now-much-easier-to-be-a-bug-triager/ 



Nate

Re: Closing old Plasma 4 bugs

[Nate Graham]

On 02/21/2018 06:26 AM, Nate Graham wrote:




On Feb 21, 2018, at 12:59 AM, Ben Cooksley  wrote:


On Wed, Feb 21, 2018 at 9:34 AM, pointedstick  wrote:
I have editbugs power on bugs.kde.org, but cannot edit the Importance field
or mark a bug as CLOSED on bugstest.kde.org. I appear to have the new normal
permissions.


Thanks for confirming my testing Nate.

I've now gone ahead and rolled this out on bugs.kde.org.
Everyone who had editbugs rights already (all 3,221 of us) have been
made members of the new (fully empowered) contributors group.

If someone would like to announce this via a blog post please feel
free to do so as I likely won't have time in the next few days to do
so.


Fantastic! I'll do that.


Done: 
https://pointieststick.wordpress.com/2018/02/21/its-now-much-easier-to-be-a-bug-triager/


Nate

D10653: Set IconItem default to smooth=true

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bf4facd8c1b9: Set IconItem default to smooth=true 
(authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10653?vs=27528=27685

REVISION DETAIL
  https://phabricator.kde.org/D10653

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: davidedmundson, #plasma, apol
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10713: Render application icon at paintdevice DPR

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:c32eb4129275: Render application icon at paintdevice DPR 
(authored by davidedmundson).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10713?vs=27683=27684

REVISION DETAIL
  https://phabricator.kde.org/D10713

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10713: Render application icon at paintdevice DPR

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10713

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10713: Render application icon at paintdevice DPR

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QIcon::pixmap doesn't know anything about the paint device currently
  being used so uses qApp->devicePixelRatio.
  This works in systemsettings, but not in kwin and we get a standard
  resolution pixmap returned.
  
  We can't manually multiply by painter->device->dpr because then system
  settings would get scaled twice.
  
  QIcon::paint solves that in a way that won't break should kwin's
  qApp->dpr change. Also it's IMHO cleaner as it does the alignment
  internally.
  
  BUG: 390639

TEST PLAN
  System settings look the same
  Icon in kwin deco is crisper than before

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10713

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Closing old Plasma 4 bugs

[Nate Graham]

> On Feb 21, 2018, at 12:59 AM, Ben Cooksley  wrote:
> 
>> On Wed, Feb 21, 2018 at 9:34 AM, pointedstick  wrote:
>> I have editbugs power on bugs.kde.org, but cannot edit the Importance field
>> or mark a bug as CLOSED on bugstest.kde.org. I appear to have the new normal
>> permissions.
> 
> Thanks for confirming my testing Nate.
> 
> I've now gone ahead and rolled this out on bugs.kde.org.
> Everyone who had editbugs rights already (all 3,221 of us) have been
> made members of the new (fully empowered) contributors group.
> 
> If someone would like to announce this via a blog post please feel
> free to do so as I likely won't have time in the next few days to do
> so.

Fantastic! I'll do that. 

Nate

D10710: update appMenu status only from qml side

[Michail Vourlakos]

mvourlakos added a comment.


  > but I think the panel (at least Plasma, dunno about latte) is smart enough 
to stay open when a transient child is open
  
  no prob the... Latte uses the NeedsAttention from applets to block auto-hiding

REPOSITORY
  R120 Plasma Workspace

BRANCH
  menustatus

REVISION DETAIL
  https://phabricator.kde.org/D10710

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10710: update appMenu status only from qml side

[Kai Uwe Broulik]

broulik added a comment.


  > AcceptingInputStatus
  
  This was to keep an auto-hidden panel visible but I think the panel (at least 
Plasma, dunno about latte) is smart enough to stay open when a transient child 
is open, see 2d8b4e1dec26c5976dd75c238c3ae8a4700b8dd9 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  menustatus

REVISION DETAIL
  https://phabricator.kde.org/D10710

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10710: update appMenu status only from qml side

[Michail Vourlakos]

mvourlakos added a comment.


  @broulik my only concerns are for line:
  
setStatus(Plasma::Types::AcceptingInputStatus);
  
  do you know if there was any specific reason for it?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  menustatus

REVISION DETAIL
  https://phabricator.kde.org/D10710

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10710: update appMenu status only from qml side

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  BUG: 390271

REPOSITORY
  R120 Plasma Workspace

BRANCH
  menustatus

REVISION DETAIL
  https://phabricator.kde.org/D10710

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10710: update appMenu status only from qml side

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --add NeedsAttention status when a menu is showing, and
  Passive status when the menu is not available
  --remove status updates from plasmoid interface

TEST PLAN
  I used debug messages to confirm the status changes and
  also Latte to check that dynamic background now works ok

REPOSITORY
  R120 Plasma Workspace

BRANCH
  menustatus

REVISION DETAIL
  https://phabricator.kde.org/D10710

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml

To: mvourlakos, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10695: dont initialize app menu index in every hiding

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1e7b424826c9: dont initialize app menu index in every 
hiding (authored by mvourlakos).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10695?vs=27634=27675

REVISION DETAIL
  https://phabricator.kde.org/D10695

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in Menu.qml:36
> Would that also help Kickoff's initial opening?
> 
> Also see D10557  which makes a huge 
> difference without that..

yeah, pretty much everything that has a listview in it, tough i don't know how 
to do it without hacing this ugly thing into every applet

D10557  seems indeed to make a difference

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10557: [Clipboard plasmoid] Split delegate into separate files

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10557

To: broulik, #plasma, graesslin, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate updated this revision to Diff 27672.
jtamate edited the summary of this revision.
jtamate added a comment.


  Updated the summary and added a comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10670?vs=27576=27672

REVISION DETAIL
  https://phabricator.kde.org/D10670

AFFECTED FILES
  src/plasma/private/effectwatcher.cpp

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski added a comment.


  @ivan When database is broken additionaly kactivitymanagerd is in endless 
loop of creating and closing processes. Each KF5 application prints to console 
message: "KActivities: FATAL ERROR: Failed to contact the activity manager 
daemon"
  
  Maybe it would be good to display dialog from kactivitymanagerd and ask user 
to fix (remove and create again) database instead of creating new processes 
infinitialy? It would fix the source of the problem which is broken database (I 
only wonder why the database is broken).
  
  I think that for now it's more important to fix crash and then help user to 
fix database. Additionally at this moment I think I don't have good C++ skills 
to fix that another way :(

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10695: dont initialize app menu index in every hiding

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Makes sense

REPOSITORY
  R120 Plasma Workspace

BRANCH
  global

REVISION DETAIL
  https://phabricator.kde.org/D10695

To: mvourlakos, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10697: Make the badge text readable on dark color schemes

[Milian Wolff]

mwolff added a comment.


  I did not test it with a light color scheme yet, will do that eventually and 
commit it then to the branch you indicated

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10697

To: mwolff, broulik, hein
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Plasma 5.13 dependencies

[Ben Cooksley]

On Wed, Feb 21, 2018 at 12:28 AM, Tobias C. Berner  wrote:
> Hi Ben

Hi Tobias,

>
>
> I think we could upgrade the CI to 5.10 "sans webengine" -- which is the one
> part we are missing.

Okay, that's good to know. I presume getting webengine working will be
a bit further off?
(I know it has caused issues in the past).

Cheers,
Ben

>
>
>
> mfg Tobias
>
> On 19 February 2018 at 20:17, Ben Cooksley  wrote:
>>
>> On 20/02/2018 12:23 AM, "Jonathan Riddell"  wrote:
>>
>> Hi Jonathan,
>>
>> Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks
>> 5.46.  The newer Qt will help us port KControl modules to QtQuick
>> Controls 2 a target of this release.
>> https://phabricator.kde.org/project/view/254/
>>
>>
>> When will this dependency start coming into effect?
>>
>> While we fortunately already have a Qt 5.10 image for Linux on the CI
>> system, I'm not sure what the status is of Qt 5.10 for FreeBSD so a timeline
>> for this would be nice.
>>
>>
>>
>> Jonathan
>>
>>
>> Cheers,
>> Ben
>
>