D11082: [WIP] Display all StreamRestore entries in it's own config Tab

[Chris Holland]

Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Was just wondering how difficult it would be to implement this. This was 
practice than anything else, but if you thinks it's worth cleaning up I can do 
so. Otherwise, reject it.
  
  F5742990: 2018-03-06___01-30-43.png 
  
  F5742991: 2018-03-06___01-32-11.png 
  
  Issues:
  
  - You can filter the streams using a hack that forces 
PlasmaCore.SortFilterModel to invalidate the filter.
  - I duplicated `BaseMap` in `map.h` to use a QString key focused on the 
`info.name` property. Code duplication sucks. :/
  - Every stream uses the system notifications icon. Would need to play around 
with that.
  - I don't believe the "device dropdown" is correct. I think all my streams 
are set to a "default device index" so it's not selecting the right dropdown 
option.
  - Double scrollbars sucks, but I'd need to look into why there's a binding 
loop on `AppletConfiguration.height`. We need to use ScrollView + ListView so 
that it only loads 4-5 delegates at a time since I personally had 100+ entries 
(games) which took a few seconds to load the tab when I removed the filter from 
the Applications tab.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11082

AFFECTED FILES
  src/context.cpp
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/main.qml
  src/maps.h
  src/streamrestore.cpp
  src/streamrestore.h

To: Zren, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Fwd: Re: kwin display issue on librem5

[Bhushan Shah]

Hello,

On Mon, Mar 05, 2018 at 06:58:08PM -0700, Heather Ellsworth wrote:
> Since PureOS is based on Debian buster, the versions of kwayland and
> kwin I was running were:
> 
> kwayland 5.42.0-2
> kwin 5.12.1-1
> 
> Using the patches attached to T8067...
> 1. I built and installed a kwayland 5.42.0-3 and kwin 5.12.1-2 from the
> debian sources + the patches
> 2. rebooted for good measure
> 3. I uncommented the 'export QT_QPA_PLATFORM=wayland' line in the
> plasma-phone script (so that it is back to the original version with no
> changes)
> 4. Started kwin_wayland with:
> $ kwin_wayland --drm plasma-phone
> 
> I can confirm that the patches remove the bad display issue and the
> display looks great!!

Awesome, glad that helped!

> When will the Plasma 5.13 release be ready? I can carry them in a fork
> but I'd like to be working ideally off of packages included in Debian,
> or at least the patched kwin and kwayland repos.

Since 5.13 is next feature release and we "just" released Plasma 5.12,
there is still time till Plasma 5.13 release, the beta is expected on
May 17, and final release is on June 12.

So I think best for you is to have a patched kwin and kwayland packages.

also note that kwayland is part of KDE frameworks, so hopefully at least
kwayland patch will be included in Next month's KDE Frameworks 5.45
release.

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D10762: Fix the build on armhf/aarch64

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3fa287280b04: Fix the build on armhf/aarch64 (authored by 
bshah).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10762?vs=28659=28781

REVISION DETAIL
  https://phabricator.kde.org/D10762

AFFECTED FILES
  fixqopengl.h
  libkwineffects/kwinglplatform.cpp
  platform.h
  plugins/qpa/abstractplatformcontext.h
  plugins/qpa/integration.h
  plugins/qpa/window.h

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added inline comments.

INLINE COMMENTS

> panel.cpp:1031
>  impanel->xkbLayoutManager = new XkbLayoutManager;
> +impanel->settings_general = g_settings_new (IBUS_SCHEMA_GENERAL);
> +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY);

IMHO you need to g_object_unref this two new settings in 
ibus_panel_impanel_destroy.

> panel.cpp:1033
> +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY);
> +g_signal_connect(impanel->settings_general, "changed", G_CALLBACK 
> (impanel_settings_changed_callback), impanel);
> +g_signal_connect(impanel->settings_hotkey, "changed", G_CALLBACK 
> (impanel_settings_changed_callback), impanel);

and disconnect the signal too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara added a comment.


  In D11061#219603 , @xuetianweng 
wrote:
  
  > May I ask when this gsettings is introduced? Is it required after certain 
ibus version? Is there any case that this will not work?
  >
  > If so I'd like to see a version check on ibus at compile time.
  
  
  GSettings has been supported in IBus 1.5.0 at least and you don't have to 
mind IBus.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28778.
kossebau marked an inline comment as done.
kossebau added a comment.


  don't use Stop for middle button, simply disable if CanPause==false

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11025?vs=28716=28778

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28777.
kossebau added a comment.


  - remove Stop state again
  - simply disable Pause button if CanPause==false
  - still use media-playback-stop button as status when neither paused nor 
playing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10973?vs=28709=28777

BRANCH
  mpriscontrollersupportnocanpause

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28776.
kossebau added a comment.


  push missed update without playpause

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11007?vs=28610=28776

BRANCH
  fixtaskmanagercontextmenuformpris

REVISION DETAIL
  https://phabricator.kde.org/D11007

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Christoph Feck]

cfeck added a reviewer: xuetianweng.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Fwd: Re: kwin display issue on librem5

[Heather Ellsworth]

On 03/04/2018 11:38 PM, Bhushan Shah wrote:
> Hello,
> 
> On Fri, Mar 02, 2018 at 10:43:28AM -0700, Heather Ellsworth wrote:
>>> So my questions for you are:
>>> * Do you have any idea what could be missing or causing the
>>> display_issue.jpg that could be fixed by exporting KWIN_COMPOSE?
> 
> This issue is due to kwin_wayland not using the zwp_linux_dmabuf
> interface yet.
> 
> See the following task: https://phabricator.kde.org/T8067 and the diffs
> attached with it.
> 
> In my opinion you should have a local kwin and kwayland packaging fork
> with patches attached to this tasks or wait for Plasma 5.13 release

Since PureOS is based on Debian buster, the versions of kwayland and
kwin I was running were:

kwayland 5.42.0-2
kwin 5.12.1-1

Using the patches attached to T8067...
1. I built and installed a kwayland 5.42.0-3 and kwin 5.12.1-2 from the
debian sources + the patches
2. rebooted for good measure
3. I uncommented the 'export QT_QPA_PLATFORM=wayland' line in the
plasma-phone script (so that it is back to the original version with no
changes)
4. Started kwin_wayland with:
$ kwin_wayland --drm plasma-phone

I can confirm that the patches remove the bad display issue and the
display looks great!!

When will the Plasma 5.13 release be ready? I can carry them in a fork
but I'd like to be working ideally off of packages included in Debian,
or at least the patched kwin and kwayland repos.

> 
>>> * Do you know how to make the mouse cursor show up?
> 
> There is two bugs, and workaround:
> 
> - https://bugs.kde.org/show_bug.cgi?id=391412 : due to this, if hardware
>   doesn't provide the cursor plane it never fallbacks to software
>   cursor.
> - However, this is more interesting
> - KWin calls : output->initCursor(m_cursorSize)
> - initCursor calls DrmBuffer::map
> - But somehow map function is failing internally, but returns true
>   anyway.
> - Through gdb session if we break on DrmOutput::initCursor() and
>   make it return false early, it initalizes the software cursor
>   correctly.
> - Which makes me believe either there is something wrong in
>   DrmBuffer::map and/or the DRM driver.
> 
> The solution is to ofcourse fix a bug.. but other then that, as a
> workaround you can enable track mouse effect and press Ctrl+Meta to make
> it show a "circle" around mouse cursor position.

I can confirm that Ctrl+super does indeed show a circle where the mouse
pointer is.

> 
> https://files.kde.org/plasma/kwin/effect-videos/track_mouse.mp4
> 
> You can add following line under [Plugins] section in ~/.config/kwinrc
> 
> trackmouseEnabled=true

I've also added this to my kwinrc.
Thanks so much for all of your help!!

Cheers,
Heather



signature.asc
Description: OpenPGP digital signature

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9665afb2a594: Make it possible to show the title despite 
having ctx actions (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=28727=28774

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg updated this revision to Diff 28772.
romangg added a comment.


  - [mediacontroller applet] App icon when cover not available

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11063?vs=28730=28772

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:187
> +transform: Scale {
> +xScale: 1. / QtWindow.Screen.devicePixelRatio;
> +yScale: 1. / QtWindow.Screen.devicePixelRatio;

We dont' need these transforms.
There shouldn't be any high DPI specicfic code in QML.

> previewrenderengine.cpp:136
> +
> +return draw(name, style, faceNo, txt, bgnd, fSize, text);
> +}

change to

QImage image(draw(name, style,...));
image.setDevicePixelRatio(ratio);
return image;

This keeps the metadata of the image scaling with the image, and then the Image 
item knows automatically what the logical of this image is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart, davidedmundson
Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  None
  
  F5742456: none.png 
  
  Small
  
  F5742458: small.png 
  
  Medium
  
  F5742460: medium.png 
  
  Large
  
  F5742462: large.png 
  
  Very Large
  
  F5742465: very-large.png 
  
  but background also matters
  
  F5742471: with-bg.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  About KStyle: I suggest to use gradients in order to approximate decoration 
shadows. It doesn't have big shadows so we don't need too much of precision. 
Also, I suggest to make them lighter.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#219426 , 
@hpereiradacosta wrote:
  
  > Hello, 
  >  Thanks for the patch.
  >
  > - As we discussed already in telegram, I am not convinced you absolutely 
need fast fourier transform nor blur, and could probably handled thing with 
"simple" QGradients. If you do not have time to try implement such a solution, 
I can give it a shot myself whenever there is time.
  
  
  It's a little bit hard(at least for me) to make good lookin shadows with 
gradients. For example, how would someone handle corners with gradients? Blur 
makes things much easier..
  
  So, yeah, could you please implement these softer shadows with gradients?
  
  > - I can also help with moving the loading and destroying of the shadow to 
the pluggin loading/unloading rather than to first and last window opening. 
(this could also go in with the current shadows in fact, and would rather be a 
separate patch).
  
  It would be great to get help with plugins. I'm not familiar with KPlugin 
shenanigans
  
  > - Also, these shadows look nice but are rather strong. To me they represent 
a shift of paradigm with respect to the original (subtle) breeze ideas. But 
that is not me to decide. Still: could you also post screenshots with the 
smaller sizes ? And then we can discuss what the default size should be.
  
  They're not final. Shadow params is an open question. Yes, I'll post them 
later.
  
  Also, could some of original Breeze authors review this too?
  
  > - finally, I really don't think we need too separate setting for the two 
shadow strength. These are just implementation details. IMHO. And will make the 
code very hard to maintain. (how do you test that all combinations of settings 
look good ?)
  
  These shadows are softer than shadows in kstyle. So, single shadow strength 
option doesn't fit for both of them, it either
  
  - makes decoration shadows very light, and kstyle shadows normal
  - makes decoration shadows normal, and kstyle shadows really dark
  
  I'm still thinking about it, having two different shadow styles is not OK.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28767.
progwolff added a comment.


  - fix preview scale on high dpi screens

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28740=28767

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  When appmenu is too large to fit in and "»" button instead of overflowing.
  
  F5742423: Screenshot_20180305_215938.png 

  
  There is a change to C++ backend -- button indexes -10 and lower mean a drop 
down menu which contains some suffix of menubar items -- -10 contains them all, 
-11 all without first one and so on.
  
  The tricky part is to determine which items to hide -- current approach is to 
draw all at first and then iterate through them and hide ones too much on right 
(`fixOverflow` function). Property `effectiveWidth` calculates how much space 
we can use and is only correct when buttons are on right and should not be 
overlapped by the menu. (Should be resolved after D11071: [RFC] [Active Window 
Control] Allow global menu be left alligned with buttons on right 
.)
  
  If the backend changes and hiding logic are considered sane, it might be 
worth porting to Global Menu applet (there the computation of available space 
would be much simplier).
  
  This patch was only tested on top of D11071: [RFC] [Active Window Control] 
Allow global menu be left alligned with buttons on right 
.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11073

AFFECTED FILES
  lib/appmenuapplet.cpp
  package/contents/ui/AppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:68a2ec5d6365: Convert EffectView to a QQuickWidget 
(authored by fvogt).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11066?vs=28743=28765

REVISION DETAIL
  https://phabricator.kde.org/D11066

AFFECTED FILES
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/main.cpp
  kcmkwin/kwincompositing/model.cpp
  kcmkwin/kwincompositing/model.h

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Some apps do not have application name (e.g. Android Emulator) so we display 
window title instead of empty string.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

AFFECTED FILES
  package/contents/ui/main.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

[Martin Flöser]

graesslin accepted this revision.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Currently global menu is always aligned on the other side than buttons 
(minimize / maximize / close) are.
  This patch tries to make alignment of global menu independent.
  
  F5742391: Screenshot_20180305_212852.png 

  
  It fails for some setups -- e.g. the left margin of window label is too 
large: F5742413: Screenshot_20180305_214250.png 

  
  I tried hard to find a better solution but failed so far.
  
  Any suggestions are welcome.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

AFFECTED FILES
  package/contents/config/main.xml
  package/contents/ui/AppMenu.qml
  package/contents/ui/config/ConfigAppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello, 
  Thanks for the patch.
  
  - As we discussed already in telegram, I am not convinced you absolutely need 
fast fourier transform nor blur, and could probably handled thing with "simple" 
QGradients.
  
  If you do not have time to try implement such a solution, I can give it a 
shot myself whenever there is time.
  
  - I can also help with moving the loading and destroying of the shadow to the 
pluggin loading/unloading rather than to first and last window opening. (this 
could also go in with the current shadows in fact, and would rather be a 
separate patch).
  - Also, these shadows look nice but are rather strong. To me they represent a 
shift of paradigm with respect to the original (subtle) breeze ideas. But that 
is not me to decide. Still: could you also post screenshots with the smaller 
sizes ? And then we can discuss what the default size should be.
  - finally, I really don't think we need too separate setting for the two 
shadow strength. These are just implementation details. IMHO. And will make the 
code very hard to maintain. (how do you test that all combinations of settings 
look good ?)
  
  Others opinion welcome, of course.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a reviewer: hpereiradacosta.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  TODOs:
  
  - separate shadow strength settings
  - improve performance
- do not delete cached shadow when last decoration is destroyed?
- or, use a faster blur algorithm(i.e. approximate gaussian blur), like 
exponential blur?
- create shadow on startup(e.g. during splash screen) and delete shadow on 
shutdown?
  - revise shadow params

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Breeze, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  5.12 release introduced new decoration shadows. These new shadows are
  bigger, centered, and they try to solve a problem related to depth.
  Yet, there are still some problems:
  
  - new(5.12) shadows are hard.
  - lighting model is broken. Because 5.12 shadows have been centered and made 
bigger, they should be casted from north.
  
  This change refines how decoration shadows look:
  
  - shadows are casted from north(shadow under window is bigger and darker, 
side shadows are smaller, etc);
  - shadows are made up of several separate shadows(one for overall shape, 
another for contrast). The separate shadows are produced by using box shadow 
helper(something similar to CSS box-shadow property, except there are no inset 
and spread properties);
  - shadow sizes(e.g. Small, Medium, and so on) haven't changed.
  
  Because GPUs can't be used for blurring images(in our case), the box shadow
  helper is using CPU to blur images. More precisely, when blur radius is < 64,
  images are blurred with "separable convolutions", otherwise, images are 
blurred
  with a two-dimensional Fourier Transform.
  
  Depends on D10942 
  Depends on D10811 

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel added a comment.


  Would it be better to move global menu 1px down instead?
  
 PlasmaComponents.Label {
 id: appmenuButtonTitle
-anchors.centerIn: appmenuButtonBackground
+anchors.top: appmenuButtonBackground.top
+anchors.bottom: appmenuButtonBackground.bottom
+verticalAlignment: Text.AlignVCenter
+anchors.horizontalCenter: 
appmenuButtonBackground.horizontalCenter
 font.pixelSize: fontPixelSize * 
plasmoid.configuration.appmenuButtonTextSizeScale
 text: activeMenu.replace('&', '')
 font.weight: appmenuFontBold ? Font.Bold : 
theme.defaultFont.weight
  
  It also fixes the issue (although I liked the 1px higher a bit better in this 
specific case).
  
  F5742205: Screenshot_20180305_200905.png 

  
  Anyway the root of the problem seems to be that each of them was centered in 
a different way.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

[Fabian Vogt]

fvogt added a comment.


  I won't land this now to give @graesslin a chance to review this as well.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.

REVISION SUMMARY
  The Qt Wayland support for subsurfaces is broken in many ways, producing
  graphical glitches and crashes:
  https://bugreports.qt.io/browse/QTBUG-54888 for instance.
  
  Using a QQuickWidget instead of a QQuickView avoids those issues, with
  the additional benefit of a nicer API.

TEST PLAN
  Opened the KCM with kcmshell and systemsettings, no subsurfaces used
  anymore.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

AFFECTED FILES
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/main.cpp
  kcmkwin/kwincompositing/model.cpp
  kcmkwin/kwincompositing/model.h

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Kai Uwe Broulik]

broulik added a comment.


  This disregards any descenders text might have, the previous approach was 
more technically correct.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10762: Fix the build on armhf/aarch64

[Martin Flöser]

graesslin added a comment.


  btw. please push to 5.12 branch

REPOSITORY
  R108 KWin

BRANCH
  arcpatch-D10762

REVISION DETAIL
  https://phabricator.kde.org/D10762

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  On my setup the window label was 1px lower than global menu items (with Fill 
height enabled) which was very annoying.
  I guess it was caused by some rounding error. This patch fixes it.
  
  Old: F5742154: Screenshot_20180305_191056.png 

  
  New: F5742155: Screenshot_20180305_191530.png 

  
  (Red rectangle was added so the issue is easier to spot.)

TEST PLAN
  Checked that window label is still vertically centered.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

AFFECTED FILES
  package/contents/ui/main.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28740.
progwolff added a comment.


  - fix face number

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28737=28740

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  Thanks so much for your work! As I am not a developer, as you progress with 
the patch, can you also please post screenshots? Just so I get where your work 
is going.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff added a comment.


  Thanks for your feedback!
  
  This patch was ment to provide the functionality we need for the UI redesign, 
but you are probably right that I should fix the mentioned problems before we 
land this.
  I will see what I can do about the popup width, the preview text and high dpi 
screens tomorrow.

INLINE COMMENTS

> broulik wrote in main.qml:22
> Is `2.2` also sufficient (Qt 5.9)?

Seems like even `2.0` is okay.
I misinterpreted the docs where it says `import QtQuick.Controls 2.3`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28737.
progwolff marked 7 inline comments as done.
progwolff edited the summary of this revision.
progwolff added a comment.


  - revert QtQuick.Controls version
  - coding style, unneccessary defaults, Label instead of Text
  - split only once, add range check
  - move include guards

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28735=28737

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10762: Fix the build on armhf/aarch64

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  arcpatch-D10762

REVISION DETAIL
  https://phabricator.kde.org/D10762

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Kai Uwe Broulik]

broulik added a comment.


  Thanks a lot for your patch! This makes the effect of those settings a lot 
easier to understand. I have a couple of nitpicks below.

INLINE COMMENTS

> main.qml:22
>  import QtQuick.Layouts 1.1
> -import QtQuick.Controls 2.0 as QtControls
> +import QtQuick.Controls 2.3 as QtControls
>  import QtQuick.Dialogs 1.2 as QtDialogs

Is `2.2` also sufficient (Qt 5.9)?

> main.qml:143
> +id: subPixelDelegate
> +width: subPixelComboImage.implicitWidth
> +contentItem: ColumnLayout {

The popup width is too small, the text cut off. Either make it larger or at 
least elide the text on the right

> main.qml:147
> +width: subPixelComboImage.implicitWidth
> +Text {
> +id: subPixelComboText

Use QtQuick Controls `Label` instead of plain `Text` for proper rendering and 
text color

> main.qml:153
> +id: subPixelComboImage
> +fillMode: Image.Pad
> +sourceSize: undefined

This is the default, no need to explicitly specify

> main.qml:154
> +fillMode: Image.Pad
> +sourceSize: undefined
> +source: 
> "image://preview/"+model.index+"_"+kcm.fontAASettings.hintingCurrentIndex+".png"

Also not needed

> main.qml:155
> +sourceSize: undefined
> +source: 
> "image://preview/"+model.index+"_"+kcm.fontAASettings.hintingCurrentIndex+".png"
> +}

Coding style, add spaces between:

  source: "image://preview/" + model.index + "_" + 
kcm.fontAASettings.hintCurrentIndex + ".png"

> previewimageprovider.cpp:35
> +{
> +int subPixelIndex = id.split('_')[0].toInt();
> +int hintingIndex = id.split('_')[1].toInt();

avoid splitting twice, I suggest storing

  const auto sections = id.splitRef(QLatin1Char('_'));

Also do a bounds check

> previewimageprovider.cpp:66
> +PreviewRenderEngine eng(true);
> +QImage img = eng.drawAutoSize(m_font, text, bgnd, 
> eng.getDefaultPreviewString());
> +

Your image does not take into account `devicePixelRatio` which makes it blurred 
on my high dpi screen.

I'm not sure how to exactly fix that, perhaps `@2x` works for the image 
provider, or you can manually implement this, to test run

  QT_SCREEN_SCALE_FACTORS=2 kcmshell5 kcm_fonts

> previewimageprovider.h:1
> +#ifndef __PREVIEW_IMAGE_PROVIDER_H__
> +#define __PREVIEW_IMAGE_PROVIDER_H__

Include guard typically goes below copyright, you can also use `#pragma once` 
in plasma-desktop

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Andres Betts]

abetts added a comment.


  Thank you for this. This is what I thought was best. It is a method that many 
applications use. It is straightforward and quick. Is there a way that the list 
width can be dynamic so as to accommodate the name of the font family? 
Sometimes font families are very long. Also, I would suggest one of two ways to 
show the list:
  
  Method 1:
  
  __
  
  Font Family Name
  Sample Text
  Sample numbers
  
  _
  
  Method 2:
  
  _
  
  FONT FAMILY NAME (Shows looks on the font family name label)
  
  _

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart
Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Kai Uwe Broulik]

broulik added a comment.


  Cool!

INLINE COMMENTS

> ExpandedRepresentation.qml:123
> +id: playerCombo
> +width: 0.6 * parent.width
> +height: visible ? undefined : 0

`Math.round`

> ExpandedRepresentation.qml:124
> +width: 0.6 * parent.width
> +height: visible ? undefined : 0
> +anchors.horizontalCenter: parent.horizontalCenter

Why is this thing no longer in a `ColumLayout`?

> ExpandedRepresentation.qml:171
> +top: playerCombo.bottom
> +bottom: cntrlCol.top
> +margins: units.smallSpacing

cnthrwueif..what?

> romangg wrote in ExpandedRepresentation.qml:269
> Pls tell me a way to use Headings without huge margins all around.

`height: undefined`

> ExpandedRepresentation.qml:280
> +text: {
> +if (!root.track)
> +return i18n("No media playing")

Add braces

> ExpandedRepresentation.qml:282
> +return i18n("No media playing")
> +var artist = root.artist ? root.artist + " – " : ""
> +

return root.artist ? i18nc("artist - track", "%1 – %2", root.artist, 
root.track) : root.track

> ExpandedRepresentation.qml:290
> +PlasmaExtras.Heading {
> +width: parent.width
> +level: 7

Why not use a `ColumnLayout`?

> ExpandedRepresentation.qml:291
> +width: parent.width
> +level: 7
> +opacity: 0.6

I thought level only went up to 5 but fine with me

> ExpandedRepresentation.qml:297
> +visible: text !== ""
> +text: {
> +var metadata = root.currentMetadata

So you now use the file name as "album"? How does it behave when you have no 
id3 info at all?

> ExpandedRepresentation.qml:337
> +
> +anchors.horizontalCenter: parent.horizontalCenter
> +

Not neccessary, that item is full width already

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff updated this revision to Diff 28735.
progwolff added a comment.


  - cleanup
  - add license

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11064?vs=28734=28735

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff edited the summary of this revision.
progwolff edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11064

To: progwolff, #plasma, harmathy, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11064: add preview images to fonts kcm

[Julian Wolff]

progwolff created this revision.
progwolff added reviewers: Plasma, harmathy, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  The fonts kcm offers different font rendering settings. Currently, one needs 
to apply the settings and 
  reopen the application to see the changes.
  This patch adds a way to render fonts at different settings (mostly based on 
existing code in kfontinst) and 
  adds preview images to the sub-pixel and hinting comboboxes.
  
  This is part of a planned redesign of the fonts kcm. See the discussion in 
https://phabricator.kde.org/T7927

TEST PLAN
  Open the fonts kcm, click on the sub-pixel combobox. The preview images 
should look different.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11064

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp
  kcms/fonts/previewimageprovider.h
  kcms/fonts/previewrenderengine.cpp
  kcms/fonts/previewrenderengine.h
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/FcEngine.h

To: progwolff, #plasma, harmathy, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Today's minutes!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 05-03-2018

Present: notmart, kbroulik, romangg, Sho_, psifidotos, bshah, d_ed

notmart:
* more bugfixes connected to preloading
* more work on card component, taken a lot of time due to funny qqc2 bugs, most 
of the week on that
* implemented new idea for devicenotifier dismissal, almost same behavior as 
notification applet for timeouts autohide and stuff
it's pretty much it as i spent days trying to solve a binding loop in that 
component and then discovered it's endemic in qqc2 itself, "sweet"
* https://bugreports.qt.io/browse/QTBUG-66826

kbroulik:
* Ported remaining places in plasmashell from own QML Engine to shared engine 
(applet alternatives, OSD, shell handler)
* Drop job now creates a proper Trash link when dropping trash:/, makes it 
easier for users to get back Trash on desktop now that we removed it by default
* Did major refactoring to gmenu-dbusmenu-proxy
** Now has heuristic for menu icons, supports check boxes and radio buttons in 
menus
** It's now good to be merged imho, want to have d_ed's final opinion on it, 
though
** https://phabricator.kde.org/D10461
Diff 10461 "GMenu-DBusMenu-Proxy" [Accepted] https://phabricator.kde.org/D10461
* Various fixes
** Recent documents using desktop file name (e.g. org.kde.kate) instead of app 
name (kate), D10863 will merge soon
** Tried to fix device notifier not properly reflecting mounting/unmounting 
progress, D10858 but didn't fix it fully
** Please have a look at D10769 and D10571 and D10686 and D9141
Diff 10863 "[KRecentDocument] Use QGuiApplication::desktopFileName()" 
[Accepted] https://phabricator.kde.org/D10863
Diff 10858 "[Solid Device Engine] Connect device signals initially" [Needs 
Review] https://phabricator.kde.org/D10858
Diff 10769 "[Dialog] Remove now obsolete KWindowSystem::setState calls" [Needs 
Review] https://phabricator.kde.org/D10769
Diff 10571 "[AppletAppearance] Remove d QtObject" [Needs Review] 
https://phabricator.kde.org/D10571
Diff 10686 "[DesktopNotifier] Notify change for any link to trash:/" [Needs 
Review] https://phabricator.kde.org/D10686
Diff 9141 "Setup QQmlEngine only once in QmlObject" [Needs Review] 
https://phabricator.kde.org/D9141

romangg:
Currently looking into a solution for D10032. I have created some patches 
D11049 and D11050 for that
Diff 10032 "Swap play/pause icons in mediacontroller plasmoid" [Needs Review] 
https://phabricator.kde.org/D10032
Diff 11049 "Remove frame around media action icons" [Needs Review] 
https://phabricator.kde.org/D11049
Diff 11050 "Remove frames around media buttons" [Needs Review] 
https://phabricator.kde.org/D11050
Then another icon for status only.
Today is the day to report on the HIG rework. Shall we do this now?

Sho:
* [SM] Did a Simple Menu release with some fixes and optimizations
** Touchscreen launch now works
** Item highlight deco stays when opening context menu
** Lighter delegates
** Some other tiny fixes
* [SM] Nate Graham is making a new menu based on SM, talked with him about 
requirements for the Kicker backend rewrite and some PlasmaComponents issues he 
ran into, etc.
* [TM] Spent some time trying to debug why the TM tooltip sometimes shows a 
window thumb too many (dupe), but walked away unsuccessfully and with other 
tooltip issues (e.g. various racy ReferenceErrors) so far - not liking this 
code ...
* [Kirigami] Progress on my KMessageWidget thingie (mostly got stumped by 
learning how Kirigami organizes source for a bit), hopefully ready this week, 
followed by the Language KCM Qt Quick port using it
* [Other] Dealing with merging a bunch of Phabs submitted by irregular 
contributors
* [Sprint] Poke status:
** Nate Graham confirmed
** Shawn Rutledge (Qt) a possibility
** Drew DeVault (Sway) a possibility
** Ikey Doherty (Budgie) a possibility
** Michail Vourlakos (Latte) n/a
** Alex Nemeth (Blur patches) n/a
** Bhushan poked a Halium person to come, I think they are
** Who knows someone at LXqt we can poke?

psifidotos:
* small fix for trash applet, it was missing a return statement
* [Latte] release v0.7.4 and remove a font that was used internally for the 
trademark
* [Latte] I drew new image patterns for editing mode
* [Latte] find a way to alter a panel presentation in order to colorize it in 
monochrome for better contrast with the desktop background
* [Latte] fixed all known wayland crashes
* [Latte] improve context menus appearance under wayland
* [Latte] use taskmanager way of activating tasks in order to activate 
surrounding applets
* [Latte] improve the use of mouse wheel for audio badges in order to 
increase/decrease stream volume

bshah:
 Got my visa for plasma sprint (you won't see me crying about visa for whole 
year now :p as I got 1 year valid visa)
- Worked on pinebook imaging refactor (4h build time v/s 30 mins build time)
- working on qt 5.10 based Plasma Mobile images
- Refined the fix for building kwin on GLES platforms

sebas:
* 

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg added a dependency: D11063: [mediacontroller applet] Reorder elements.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg added a dependent revision: D11056: [mediacontroller applet] Use media 
playback status icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel updated this revision to Diff 28729.
Pitel added a comment.


  The `changeVolume` helper must be in `PlayerControl` class and 
`MultiplexedService` must only forward calls to it in order to volume change by 
mouse wheel also work for other sources than only mutliplex one.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28701=28729

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/multiplexedservice.h
  dataengines/mpris2/playercontrol.cpp
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:269
> +width: parent.width
> +spacing: -units.smallSpacing
> +

Pls tell me a way to use Headings without huge margins all around.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Improve overall look according to bug report and mockup.
  
  BUG: 390280

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good now! With your latest update, the right padding issue now actually 
resolved. The follow-up patch only needs to fix the left padding for the menu 
items that don't have checkboxes.

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D10475_1

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D9141: Setup QQmlEngine only once in QmlObject

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0ecea38b5998: Setup QQmlEngine only once in QmlObject 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9141?vs=28691=28728#toc

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9141?vs=28691=28728

REVISION DETAIL
  https://phabricator.kde.org/D9141

AFFECTED FILES
  src/kdeclarative/kdeclarative.cpp
  src/kdeclarative/kdeclarative.h
  src/kdeclarative/qmlobject.cpp
  src/kdeclarative/qmlobject.h
  src/kdeclarative/qmlobjectsharedengine.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28727.
apol added a comment.


  Improve how we calculate the header title.
  Let's fix the right spacing issue in a separate review

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=28726=28727

BRANCH
  arcpatch-D10475_1

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  The problems persist with `QT_SCALE_FACTOR=1.5`, and additionally the titles 
get inappropriately elided:
  
  F5741717: Persists.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D11061: Migration request from IBusConfig to GSettings

[Luca Beltrame]

lbeltrame added reviewers: Plasma, hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

[Aleix Pol Gonzalez]

apol added a comment.


  In D10571#219016 , @mart wrote:
  
  > the concern is that now applets have a codepath to access it by going to 
see their parents...
  >  but is something they should never ever do, so good to go for me
  
  
  If this is a concern, these properties can be set on the Timer...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson, mart
Cc: apol, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28726.
apol added a comment.


  Odd, they both look rather small to me, probably a high dpi issue to look 
into...

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=28723=28726

BRANCH
  arcpatch-D10475_1

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  Hmm, now there's too much side padding!
  F5741687: Now there's too much.png 
  
  Can we make the padding identical on the top, bottom, and right side?
  
  Also, as you can see in the above screenshot, the menu items without 
checkboxes have zero left padding, so they touch the bounds of the menu.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D11059: Add convenience method to get a persistent model index from TasksModel

[Chris Holland]

Zren added a comment.


  Typo. You only have 1 "s" in persistent there.
  
makePeristentModelndex
   QPersistentModelIndex
clients.push(tasksModel.makePersistentModelIndex(i)); // minimizeall

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11059

To: davidedmundson, #plasma
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28723.
apol added a comment.


  Address Nate's comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=28393=28723

BRANCH
  arcpatch-D10475_1

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
fujiwara requested review of this revision.

REVISION SUMMARY
  kimpanel-ibus-panel uses IBusConfig and I'd ask to migrate it to GSettings 
and delete IBusConfig.
  
  https://groups.google.com/forum/#!topic/ibus-devel/Mu1IoFX-bKE

TEST PLAN
  Run ibus-setup and changes "Next input method" or IMEs and KIM panel works 
fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: fujiwara
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11059: Add convenience method to get a persistent model index from TasksModel

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Used in the minimizeAll plasmoid (see D10019 
)

TEST PLAN
  Used in applet

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11059

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11057: Add a custom default avatar to the sddm-breeze theme.

[Phil Stefan]

pstefan edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11057

To: pstefan, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg added a comment.


  Should we add a fallback mechanism in case the icon pack does not contain the 
media playback state icons? I mean as a fallback the normal 
media-playback-start and pause icons again as it is now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11057: Add a custom default avatar to the sddm-breeze theme.

[Phil Stefan]

pstefan created this revision.
pstefan added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  With commit 945a95d908b4544f7c5dea6caacffdc0f44cffcb SDDM will now support a 
custom default avatar in the next release.
  
  Before the patch:
  F5741458: Screenshot from 2018-02-27 15:03:20.png 

  After tha patch:
  F5741459: Screenshot from 2018-03-05 14:24:08.png 

  
  Note that the above is not quite the same as the logout screen thingy. But I 
am not sure how to make it render the image in a way that it does not quite 
touch the edge of the border.
  To illustrate what I mean:
  F5741460: Screenshot from 2018-02-28 18:00:41.png 

  With the logout screen the user icon is not touching the circle border.

TEST PLAN
  Works for me

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11057

AFFECTED FILES
  sddm-theme/faces/.face.icon

To: pstefan, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10032: Swap play/pause icons in mediacontroller plasmoid

[Nicolas Fella]

nicolasfella abandoned this revision.
nicolasfella added a comment.


  Abandoning in favor of D11056 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10032

To: nicolasfella, #plasma, #vdg
Cc: rizzitello, abetts, davidedmundson, broulik, ngraham, plasma-devel, #vdg, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28716.
kossebau added a comment.


  use play() & pause() instead of playpause()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11025?vs=28616=28716

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg added a dependency: D11054: Add media status icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Instead of using the action icons to indicate the current state use
  the new media playback status icons.
  
  This is an alternative solution to the problem that the mediacontroller applet
  icon in the system tray and the play/pause controll in the player are always
  the opposite.
  
  While it is still the opposite icon there is now a slight visual difference
  to show that these icons mean different things.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStatusIcon

REVISION DETAIL
  https://phabricator.kde.org/D11056

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 28709.
kossebau added a comment.


  use play() & pause() everywhere instead of playpause()

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10973?vs=28619=28709

BRANCH
  mpriscontrollersupportnocanpause

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9141: Setup QQmlEngine only once in QmlObject

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  i like it now

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9141

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10686: [DesktopNotifier] Notify change for any link to trash:/

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10686

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

[Marco Martin]

mart accepted this revision.
mart added a comment.


  the concern is that now applets have a codepath to access it by going to see 
their parents...
  but is something they should never ever do, so good to go for me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson, mart
Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Marco Martin]

mart added a comment.


  did you try if after removing it, repeatedly showing and hiding, the dialog 
does not appear in the taskbar, even for an instant? (if so, good to go for me)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel added a reviewer: broulik.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10858: [Solid Device Engine] Connect device signals initially

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10858

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c7f2d8e7331a: [media controller applet] Fix JS error on 
no xesam:url data set (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11028?vs=28621=28702#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11028?vs=28621=28702

REVISION DETAIL
  https://phabricator.kde.org/D11028

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel updated this revision to Diff 28701.
Pitel added a comment.


  - Added OSD support.
  - Refactored osd & volume bounding logic into helper 
`MultiplexedService::changeVolume`.
  
  Is there any way to get player name & icon without adding 
`PlayerControl::container`?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28604=28701

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/multiplexedservice.h
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D11028#218774 , @broulik wrote:
  
  > My approach would have been
  >
  >   var xesamUrl = (metadata["xesam:url"] || "").toString();
  >
  >
  > but this is fine and more understandable for non-JS developers :)
  
  
  It took me years to no longer be a JS developer ;) But never seen this 
pattern before, think this is more nice, so will go for that :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixtoStringfromnull

REVISION DETAIL
  https://phabricator.kde.org/D11028

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11026: [taskmanager applet] Mark some caching QML Item properties readonly

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:de5ab396f277: [taskmanager applet] Mark some caching QML 
Item properties readonly (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11026?vs=28617=28700

REVISION DETAIL
  https://phabricator.kde.org/D11026

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11047: Fix typo in config group name

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b1bffa445823: Fix typo in config group name (authored by 
fvogt).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11047?vs=28686=28698

REVISION DETAIL
  https://phabricator.kde.org/D11047

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:47521b011d33: Use QQuickWidget instead of QQuickView for 
the main view in the kcm (authored by fvogt).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11045?vs=28683=28696

REVISION DETAIL
  https://phabricator.kde.org/D11045

AFFECTED FILES
  kcm/qml/main.qml
  kcm/src/widget.cpp
  kcm/src/widget.h

To: fvogt, #plasma, sebas, dvratil, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks for finding a simple fix for this, it was super annoying.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11045

To: fvogt, #plasma, sebas, dvratil, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9141: Setup QQmlEngine only once in QmlObject

[Kai Uwe Broulik]

broulik updated this revision to Diff 28691.
broulik edited the test plan for this revision.
broulik added a comment.


  - Use protected constructor with pseudo argument instead of flags

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9141?vs=23360=28691

REVISION DETAIL
  https://phabricator.kde.org/D9141

AFFECTED FILES
  src/kdeclarative/kdeclarative.cpp
  src/kdeclarative/kdeclarative.h
  src/kdeclarative/qmlobject.cpp
  src/kdeclarative/qmlobject.h
  src/kdeclarative/qmlobjectsharedengine.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11047: Fix typo in config group name

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11047

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11047: Fix typo in config group name

[Fabian Vogt]

fvogt updated this revision to Diff 28686.
fvogt added a comment.


  Remove blank line at EOF.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11047?vs=28685=28686

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11047

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11047: Fix typo in config group name

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.

REVISION SUMMARY
  Quickly fix it before anyone relies on this typo.

TEST PLAN
  None. Yes, really untested.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11047

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11046: Fix position of output identifier popup for screen scaling

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Tested with
  
QT_SCREEN_SCALE_FACTORS=1 kcmshell5 kcm_kscreen
QT_SCREEN_SCALE_FACTORS=1.5 kcmshell5 kcm_kscreen
QT_SCREEN_SCALE_FACTORS=2 kcmshell5 kcm_kscreen
  
  Popup was placed correctly every time. Previously it would appear offset to 
the bottom right

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D11046

AFFECTED FILES
  kcm/src/widget.cpp

To: broulik, #plasma, sebas
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11045: Use QQuickWidget instead of QQuickView for the main view in the kcm

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, sebas, dvratil.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  This makes it usable on wayland. The Qt Wayland support for subsurfaces
  is broken in many ways, producing practically unusuable graphics and crashes.
  https://bugreports.qt.io/browse/QTBUG-54888 for instance.

TEST PLAN
  Used it on wayland works fine now.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11045

AFFECTED FILES
  kcm/qml/main.qml
  kcm/src/widget.cpp
  kcm/src/widget.h

To: fvogt, #plasma, sebas, dvratil
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10890: Don't skip certain recent documents in kicker and taskmanager

[Алексей Шилин]

aleksejshilin edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart