D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

Pitel added a comment.


  I do not have write access.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Radek Hušek]

Pitel added a comment.


  @painlessroaster is not me. What gave you impression he is?

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Christoph Feck]

cfeck added a comment.


  Was this committed?

REPOSITORY
  R134 Discover Software Store

BRANCH
  sourcesUI

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Nathaniel Graham]

ngraham added a subscriber: Pitel.
ngraham added a comment.


  Looks like the patch no longer applies. Radek, can you re-base this on 
master? You can do this with `git pull --rebase origin master`
  
  Also, are you @pitel? If so, it's a bit confusing to have two accounts for 
the same person; please choose one to use exclusively going forward.

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Nathaniel Graham]

ngraham added a comment.


  Looks like no. I'll be happy to commit it shortly...

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Christoph Feck]

cfeck added a comment.


  Was this already committed?

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11316: Components for Cards

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CardsLayoutGallery.qml:83
> +Kirigami.AbstractCard {
> +Layout.fillWidth: true
> +showClickFeedback: true

Why is it the responsiblility of the user of a CardLayout to set 
Layout.fillWidth: true on every item yet CardLayout goes to great lengths to 
auto-inject Layout.fillHeight on every item? Surely one of the other?

(also it seems to visually completely explode if you don't have this set, which 
sounds like the sign of a bug elsewhere)

> CardsLayout.qml:35
> + * such as a mobile phone screen.
> + * A CardsLayout should always be contained within a ColumnLayout.
> + * @inherits GridLayout

I can see you want it in a layout because you're setting the relevant attached 
properties, but why explicitly Column?

> CardsLayout.qml:55
> +
> +Layout.preferredWidth: maximumColumnWidth * 2
> +Layout.maximumWidth: maximumColumnWidth * 2

shouldn't this include the spacing? Otherwise it's always ever so slightly 
smaller than my maxSize

> BannerImage.qml:106
> +color: source != "" ? "white" : Kirigami.Theme.textColor
> +elide: Text.ElideRight
> +}

this will never elide properly, the layout it's filling is not constrained.

 left: root.titleAlignment & Qt.AlignLeft ? parent.left : undefined
  right: root.titleAlignment & Qt.AlignRight ? parent.right : undefined

will only have one.

> AbstractApplicationHeader.qml:88
> -transform: Translate {
> -id: translateTransform
> -y: {

What are these changes in the header about?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11072: [Active Window Control] Show window title when app name is missing

[Martin Kostolný]

martinkostolny added a comment.


  If you have write access, you can push it to git directly. Otherwise let me 
know, I can push it for you with your name as the original author :).

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Please note, I didn't add getters because params struct:
  
  - is internal
  - that's const
  - that's struct and structures have public fields by default

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#226041 , @ngraham wrote:
  
  > Right, and I can accept that. Visually, I feel like the bottom shadow is a 
bit too stark and eye-catching. There's a very dark strip right under the 
bottom of the window that I find a bit distracting.
  
  
  Well, according to the lighting model that's totally correct. So, I don't 
want to change that.
  
  If bottom shadows and side shadows were equally sized, then they would give 
impression like it's an aura or neon or whatever. That would be totally fine in 
Oxygen but here.. I dunno.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Nathaniel Graham]

ngraham added a comment.


  In D11069#226037 , @zzag wrote:
  
  > Oh, sorry, I misunderstood you. Bottom shadows should be bigger than side 
shadows because shadows are casted from north. :)
  >
  > For example, raise a light source above the title bar and look at the 
window from infinity(I wish I could have such sight).
  
  
  Right, and I can accept that. Visually, I feel like the bottom shadow is a 
bit too stark and eye-catching. There's a very dark strip right under the 
bottom of the window that I find a bit distracting.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#226036 , @abetts wrote:
  
  > What is there left to be done in this implementation?
  
  
  If you're happy about current look of the shadows than nothing. :)
  
  I'm still waiting for KWin patches to be reviewed. (see 'Depends on' in the 
revision's summary)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Andres Betts]

abetts added a comment.


  What is there left to be done in this implementation? Are we close to 
shipping?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Oh, sorry, I misunderstood you. Bottom shadows should be bigger than side 
shadows because shadows are casted from north. :)
  
  For example, raise a light source above the title bar and look at the window 
from infinity(I wish I could have such sight).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#226026 , @ngraham wrote:
  
  > I still think the light source is a bit too far up on the Y axis, and the 
bottom shadow is a bit too big compared to the side shadows. But I won't -1 it, 
since these new shadows are just so awesome in the aggregate!
  
  
  I haven't implemented spread property, sorry. I don't have too much time for 
this. :(

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Nathaniel Graham]

ngraham added a comment.


  I still think the light source is a bit too far up on the Y axis, and the 
bottom shadow is a bit too big compared to the side shadows. But I won't -1 it, 
since these new shadows are just so awesome in the aggregate!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a subscriber: abetts.
zzag added a comment.


  See current menu shadows in revision's summary.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Hugo, could you please review it?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29541.
zzag added a comment.


  - don't use aggregate initialization(available only in >= C++20)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=29198=29541

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a subscriber: abetts.
zzag added a comment.


  Hugo, could you please review this patch?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29540.
zzag added a comment.


  - tweak opacity values
  - bump strength to 100%
  - don't use aggregate initialization(available only in >= C++20)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29197=29540

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag added a comment.


  Hugo, could you please review this patch?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11198: [WIP][libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag updated this revision to Diff 29535.
zzag added a comment.


  Delete #includes.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=29126=29535

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Wojciech Stachurski]

wsdfhjxc added a comment.


  Currently dragging active items into the trash bin and saving changes results 
in setting auto visibility and displaying them at the end of both the system 
tray and configuration list, so it's not really deleting them from user's point 
of view. I was wondering, shouldn't the trash bin be accessible only while 
dragging inactive items (assuming `statusNotifierModel` will be fixed)?
  
  Hidden items could be displayed below non-hidden items, because it's a little 
bit messy right now. But I see the whole list is dependant solely on 
`cfg_itemOrder` which contains mixed entries, so I guess this would require a 
bit more code to split them. Not sure what's your opinion on this, as it would 
bring additional complexity, but I think it would be better to somehow 
differentiate those two types and reduce confusion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Wojciech Stachurski]

wsdfhjxc added a comment.


  I can no longer reproduce the issue with incorrect visibility state in 
checkboxes. It seems to be working correctly after last patch.
  
  Also, I've added some minor styling suggestions, so it looks a little bit 
more polished in my opinion.

INLINE COMMENTS

> ConfigEntries.qml:201
> +QtLayouts.Layout.preferredWidth: 1
> +QtLayouts.Layout.fillHeight: true
> +}

height: measureButton.height

> ConfigEntries.qml:319
> +
> +Rectangle {
> +color: "black"

Rectangle {
  SystemPalette {
  id: sysPalette
  colorGroup: SystemPalette.Active
  }
  
  color: sysPalette.mid
  opacity: 0.85
  anchors.fill: parent
  }

> ConfigEntries.qml:328
> +anchors.margins: Math.round(units.gridUnit * 0.2)
> +icon: "trash-empty"
>  }

icon: "albumfolder-user-trash"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7537: KDE logout screen - change black icons & texts to white/greyish

[Nathaniel Graham]

ngraham added a comment.


  You can abandon the revision in favor of that other one using Phabricator's 
"Add Action..." menu above the comment field.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: davidedmundson, Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11309: Use the default Plasma wallpaper on the login screen

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Thanks for grabbing this, David!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

[Nathaniel Graham]

ngraham added a comment.


  Hmm, doesn't apply for me:
  
This diff is against commit 5286b919498174dbde7b867e166ac45f2032d443, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (6ab76d791caa552091057f88365b24847014ff1d)
[Y/n] y

Checking patch sddm-theme/theme.conf.cmake...
error: sddm-theme/theme.conf.cmake: already exists in working directory
Checking patch sddm-theme/theme.conf...
error: sddm-theme/theme.conf: does not exist in index
Checking patch CMakeLists.txt...
error: while searching for:
plasma_install_package(lookandfeel org.kde.breeze.desktop look-and-feel 
lookandfeel)

if (INSTALL_SDDM_THEME)
# Install the login theme into the SDDM directory
# Longer term we need to look at making SDDM load from look and feel 
somehow.. and allow copying at runtime
#NOTE this trailing slash is important to rename the directory
install(DIRECTORY sddm-theme/ DESTINATION 
${KDE_INSTALL_FULL_DATADIR}/sddm/themes/breeze PATTERN "README.txt" EXCLUDE 
PATTERN "components" EXCLUDE PATTERN "dummydata" EXCLUDE)
install(DIRECTORY lookandfeel/contents/components DESTINATION 
${KDE_INSTALL_FULL_DATADIR}/sddm/themes/breeze PATTERN "README.txt" EXCLUDE)
endif()

add_definitions(-DQT_NO_URL_CAST_FROM_STRING)

error: patch failed: CMakeLists.txt:121
Applying patch CMakeLists.txt with 1 reject...
Rejected hunk #1.

 Patch Failed!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11335: [System Tray] Fix hiding applets with HiddenStatus

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The `effectiveStatus` didn't take it into account.

TEST PLAN
  Set an applet to `HiddenStatus` and it completely disappeared from system tray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11335

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11333: introduce the function containmentGraphicsItemPreview

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  ShellCorona only creates the containment in currentActivityChanged, so this 
swiping stuff isn't going to work until you've first switched containment an 
existing way, then started swiping.

INLINE COMMENTS

> desktopview.cpp:201
>  
> +QQuickItem *DesktopView::containmentItemForActivity(const QString )
> +{

In the main code path shellcorona is responsible for assigning containments to 
desktopviews.

In this code path DesktopView is extracting the relevant containments for 
itself.

That's super messy, please redesign.

> shellcorona.cpp:1234
>  
> +Plasma::Containment *ShellCorona::containmentGraphicsItemPreview(const 
> QString& activity, int screenNum)
> +{

This is generically finding a containment.

The method name and comment shouldn't have anything to do with what 1 usage of 
it is doing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Eike Hein]

hein added a comment.


  The argument that it's a semantic abuse of the highlight color is quite 
convincing to me.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11316: Components for Cards

[Marco Martin]

mart added a comment.


  now it's on top of master and qmldir has all the public files

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11316: Components for Cards

[Marco Martin]

mart updated this revision to Diff 29514.
mart added a comment.


  - add to qmldir
  - Merge branch 'master' into mart/Card
  - add more items to qmldir

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11316?vs=29502=29514

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11316: Components for Cards

[Marco Martin]

mart added a comment.


  In D11316#225668 , @apol wrote:
  
  > Worked for me. Had to expose the components in the qmldir:
  >
  >   diff --git a/src/qmldir b/src/qmldir
  >   index f262452..2275600 100644
  >   --- a/src/qmldir
  >   +++ b/src/qmldir
  >   @@ -36,4 +36,6 @@ AbstractApplicationHeader 2.0 
AbstractApplicationHeader.qml
  >ContextDrawer 2.0 ContextDrawer.qml
  >ApplicationWindow 2.0 ApplicationWindow.qml
  >PageRow 2.0 PageRow.qml
  >   +AbstractCard 2.4 AbstractCard.qml
  >   +Card 2.4 Card.qml
  >   
  >
  > Also had to rebase to master.
  
  
  hmm, that qmldir file should be used only for purposes of doxygen indexing, 
shouldn't affect the components being available?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11333: introduce the function containmentGraphicsItemPreview

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  binded to the desktopview function containmentItemForActivity
  usable from the shell package: will be needed for gesture based
  activity switching on plasma mobile

TEST PLAN
  works well on plasma mobile

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/containmentPreview

REVISION DETAIL
  https://phabricator.kde.org/D11333

AFFECTED FILES
  shell/desktopview.cpp
  shell/desktopview.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Richard Bowen]

richardbowen added a comment.


  Blue screen is fine with me but hey, I like blue.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11190: Make sure we are taking into account hte size of the element when styling

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:c41339d7ed30: Make sure we are taking into account hte 
size of the element when styling (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11190?vs=29112=29509

REVISION DETAIL
  https://phabricator.kde.org/D11190

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Vlad Zagorodniy]

zzag added a comment.


  In D11308#225711 , @hein wrote:
  
  > > The blue background was not particularly well-received.
  >
  > Are you sure you are not reacting to a loud minority? The bright background 
has some practical benefits, e.g. it allows people to type in their passwords 
in dark rooms without a backlit keyboard. There may be a silent majority who is 
served rather well by it. I'm concerned with just implementing the opinion of 
whoever screams the loudest.
  
  
  The loud minority is still part of the community and KDE is all about 
community, isn't it? ;-)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Vlad Zagorodniy]

zzag added a comment.


  In D11308#225401 , @mart wrote:
  
  > Sadly, the current design doesn't really allow for arbitrary wallpapers 
(and since is possible already to put any image, that's quite a problem)
  >  if a wallpaper should become the default again, the text elements should 
either have a visible background for contrast (so would mean a pretty heavy 
redesign) or, showing only the wallpaper by default and only after mouse 
move/any interaction the actual controls appear and the wallpaper gets either 
completely covered or with an heavy blur+contrast (blur alone isn't enough to 
ensure readability of text, the shader should modify the colors as well, like 
the plasma panel does)
  
  
  I agree with you, raw images will make everything worse so background should 
be somehow filtered. IMO, blur+contrast is a good idea.
  
  Do we really need to use shaders? QML some useful effects like FastBlur and 
BrightnessContrast.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Radek Hušek]

Pitel added a comment.


  +1 for picture instead of blue. With the current UI I would really appreciate 
option to choose text color independently on plasma color scheme (and such 
option would solve any static picture). Other possibility I was thinking about 
was 50 % opaque (default black) rectangle (with rounded corners) around control 
elements (i.e. like logout screen but only around controls not whole screen) 
but I have not found the way to position it where I want it to be...

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham added a comment.


  In D11308#225711 , @hein wrote:
  
  > > The blue background was not particularly well-received.
  >
  > Are you sure you are not reacting to a loud minority? The bright background 
has some practical benefits, e.g. it allows people to type in their passwords 
in dark rooms without a backlit keyboard.
  
  
  Using the plasma wallpaper as a background serves that purpose just fine:
  F5754004: FileDownload.jpeg 
  
  It's hard to express something like this in a photo due to the extreme 
contrast involved, but I ssume you that the keyboard is perfecetly readable in 
an otherwise totally dark room.
  
  In D11308#225711 , @hein wrote:
  
  > There may be a silent majority who is served rather well by it. I'm 
concerned with just implementing the opinion of whoever screams the loudest.
  
  
  I'm happy to have the discussion again here if you'd like, but in a nutshell, 
entirely aside from public opinion, here are the substantive objections to the 
bright blue background:
  
  - Emotional: reminds former Windows users of the blue screen of death
  - Reflects a design error: a highlight color is used as a background color, 
so it becomes overwhelming and blinding
  - Doesn't reflect the depth of VDG's visual design skills; makes us look 
amateurish
  - Doesn't make use of any of our branding
  - Provides no continuity with the default desktop experience; nothing else 
uses the blue highlight color so starkly and totally

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Julian Wolff]

progwolff added a comment.


  @hein might be right here.
  If it's the single-click/double-click thing or this issue here: People who 
are happy with the status quo won't reach out to us.
  Maybe we need to discuss at a different place if and how we can learn about 
the opinion of the majority of KDE users, before we change things that are 
possibly only broken for few.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: progwolff, abetts, hein, mart, graesslin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Eike Hein]

hein added a comment.


  > The blue background was not particularly well-received.
  
  Are you sure you are not reacting to a loud minority? The bright background 
has some practical benefits, e.g. it allows people to type in their passwords 
in dark rooms without a backlit keyboard. There may be a silent majority who is 
served rather well by it. I'm concerned with just implementing the opinion of 
whoever screams the loudest.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: abetts, hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D11309: Use the default Plasma wallpaper on the login screen

[David Edmundson]

davidedmundson updated this revision to Diff 29507.
davidedmundson added a comment.


  The same but different

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11309?vs=29454=29507

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11309

AFFECTED FILES
  CMakeLists.txt
  sddm-theme/theme.conf
  sddm-theme/theme.conf.cmake

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson added a reviewer: ngraham.
davidedmundson added a comment.




REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  OK, sounds like a plan!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a comment.


  In D11306#225695 , @ngraham wrote:
  
  > I agree that consistency is important! For that reason, I would propose 
adding text everywhere. Buttons without text are inherently ambiguous unless 
their icons are //perfect// (and even a broom icon doesn't quite get there 
IMHO, though it's better). I know designers hate excessive text, but users 
appreciate the clarity and obviousness of buttons with text.
  
  
  I'm willing to nod off (even though there I have no say in it there) a patch 
which adds it to all places  ( e.g. the klipper I linked) if reasonably sure 
that it works across languages  (so we don't have half of text in some 
languages, which is arguably worse than no text at all), but I'd like to give a 
clear, recognizable icon a try first.
  
  We have lots of other icons in plasmoids  (close notifications, mute, copy, 
menu, ...) that work well without text, some of them also destructive actions, 
so I'd like to give that a try first for the sake of space and not-clutterednes.
  
  I will comment on the clear-all bug and hope that something great comes out 
of this, then we can re-evaluate this one here :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  I agree that consistency is important! For that reason, I would propose 
adding text everywhere. Buttons without text are inherently ambiguous unless 
their icons are //perfect// (and even a broom icon doesn't quite get there 
IMHO, though it's better). I know designers hate excessive text, but users 
appreciate the clarity and obviousness of buttons with text.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a comment.


  In D11306#225691 , @ngraham wrote:
  
  > How about just "Clear" for the text? That should be short enough even in 
German, no? The word "history" is pretty redundant anyway.
  
  
  Actually the oppposite, if you only do "clear" it might become unclear in a 
few languages. I think the text is fine, really. I'd just prefer to have no 
text at all, consistent with the klipper one.
  
  > And yeah, I agree that we need a better icon for these. For that, I've 
filed https://bugs.kde.org/show_bug.cgi?id=391855.
  
  Wonderful, thank you. I still think a broom might do, it's what tango does, 
it doesn't depend on position of to-be-cleared icons and it is rather cultural 
independent. But that's something to discuss there.
  
  I'm afraid that I am going to be very strict on  "have a solution that is 
consistent with the rest", so I will reject all proposed changes that are not 
consistent across the board, which includes, right now, any kind of text. 
Sorry. For once I'd love to have a global solution and not partial solutions in 
some and not in other places. 
  As in: I see it as a valid problem, but I don't see adding this change here 
as a solution, so I stay with "no"
  
  Once we have a proper, recognizable icon I think we can use that in the cases 
named and do not need text, hopefully.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  How about just "Clear" for the text? That should be short enough even in 
German, no? The word "history" is pretty redundant anyway.
  
  And yeah, I agree that we need a better icon for these. For that, I've filed 
https://bugs.kde.org/show_bug.cgi?id=391855.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a subscriber: broulik.
Fuchs added a comment.


  In D11306#225671 , @broulik wrote:
  
  > Do whatever you want with this button.
  
  
  Okay, recommendation: due to all plasma buttons that have an icon having it 
on the left (see e.g. F5753917: btns1.png 
) and klipper having a clear history 
functionality  (see F5753919: btn2.png )  
find a proper solution that works for both, e.g. an icon that is clear to 
understand, and then implement in both.
  
  Until then: leave the clear notification history as is.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Kai Uwe Broulik]

broulik resigned from this revision.
broulik added a comment.


  Do whatever you want with this button.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a comment.


  In D11306#225667 , @broulik wrote:
  
  > Either remove the icon or put it on the right, then I wouldn't really mind 
this change.
  
  
  putting it on the right would make it inconsistent with every single plasma 
and KDE button I am aware of, so I'd still mind.
  
  Removing the icon would make it inconsistent with the klipper plasmoid.
  
  I still think the proper solution is to have a proper, understandable icon 
which is used consistently across plasmoids, either of the three changes would 
do the exact opposite of that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11316: Components for Cards

[Aleix Pol Gonzalez]

apol added a comment.


  Worked for me. Had to expose the components in the qmldir:
  
diff --git a/src/qmldir b/src/qmldir
index f262452..2275600 100644
--- a/src/qmldir
+++ b/src/qmldir
@@ -36,4 +36,6 @@ AbstractApplicationHeader 2.0 
AbstractApplicationHeader.qml
 ContextDrawer 2.0 ContextDrawer.qml
 ApplicationWindow 2.0 ApplicationWindow.qml
 PageRow 2.0 PageRow.qml
+AbstractCard 2.4 AbstractCard.qml
+Card 2.4 Card.qml
 
  
  Also had to rebase to master.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11306: Give the "Clear History" button some text

[Kai Uwe Broulik]

broulik added a comment.


  Either remove the icon or put it on the right, then I wouldn't really mind 
this change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: abetts, hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D11189: Force a content size into the background style item

[Aleix Pol Gonzalez]

apol updated this revision to Diff 29505.
apol added a comment.


  Remove a hardcoded size, so it's there just once.
  
  Note this depends on D11190 .

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11189?vs=29111=29505

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11189

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D11316: Components for Cards

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AbstractCard.qml:69
> The following should behave the same and it keeps all the semantic meaning 
> and it means data flows in the right directions
> 
>   implicitHeight: mainLayout.implicitHeight + topPadding + bottomPadding
>   height: internal.completed && internal.gridView
>   ? internal.gridView.cellHeight - Kirigami.Units.largeSpacing*2 : 
> implicitHeight
> 
> (not tested as I have an error running the gallery, see IRC)

seems to behave the same, but with it i have a binding loop on implicitHeight 
now

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[Marco Martin]

mart added a comment.


  In D11316#225496 , @progwolff 
wrote:
  
  > There seems to be a problem with the overflow menu:
  >
  > F5753673: Screenshot_20180314_121900.png 

  
  
  fixed in latest version

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[Marco Martin]

mart updated this revision to Diff 29502.
mart added a comment.


  - fix last binging loop
  - update the qrc
  - up to date qmltypes
  - take layout spacing into account

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11316?vs=29486=29502

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/styles/org.kde.desktop/Units.qml

To: mart, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11327: [Workspace Options KCM] sync() after writing settings

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Something must have changed in KConfig or so since I've seen the same 
pattern in various other KCMs lately (e.g. looandfeel)
  
  I think you're identifying non-issues.
  Unless someone else has a plasmarc open that kconfig goes out of scope, the 
destructor syncs which is why it's never been a problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11327

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham added a comment.


  In D11308#225251 , @graesslin 
wrote:
  
  > I think we first need to bring back some background for the UI elements. 
Otherwise it's too difficult to read.
  
  
  
  
  In D11308#225401 , @mart wrote:
  
  > if a wallpaper should become the default again, the text elements should 
either have a visible background for contrast (so would mean a pretty heavy 
redesign) or, showing only the wallpaper by default and only after mouse 
move/any interaction the actual controls appear and the wallpaper gets either 
completely covered or with an heavy blur+contrast (blur alone isn't enough to 
ensure readability of text, the shader should modify the colors as well, like 
the plasma panel does)
  
  
  I agree with you guys and would like to see those changes too, as they would 
resolve some ussbility issues that are tracked by 
https://bugs.kde.org/show_bug.cgi?id=388622 and 
https://bugs.kde.org/show_bug.cgi?id=369676
  
  However, this patch doesn't make the image dynamic, so the vendor (us, 
distros) can make sure that the image works against white text. The current one 
does, I think. So we don't need to tackle the readability of white text on 
arbitrary backgrounds here.
  
  > Personally I'm very confused as it was the vdg's wish to have it blue. I 
hope our users don't take this negative. I would take it negative to see such a 
forward and backward.
  
  We have received a lot of negative feedback over the past year and a half 
regarding the blue color and have decided that the initiative was a failed 
experiment. On the contrary, I expect our users to appreciate the change 
because the current bright blur color is not popular. Listening to feedback is 
important. The blue background was not particularly well-received.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:86038b5b8c80: Simplify display when theres only a 
single input device and a single output… (authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11166?vs=29440=29497

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Ahh sorry I misunderstood you. Moving this option to containment level seems 
reasonable although I'm not sure for how many other applets it might be useful 
-- except taskbar and Active Windows Control (the global menu applet in my 
screen shot and it already has this option) all applets I use are fixed width.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11327: [Workspace Options KCM] sync() after writing settings

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures changes take effect immediately

TEST PLAN
  Something must have changed in KConfig or so since I've seen the same pattern 
in various other KCMs lately (e.g. looandfeel)
  
  - Verified that changing tooltip settings now enables/disables tooltip 
immediately

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11327

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11316: Components for Cards

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mart wrote in AbstractCard.qml:69
> no, when it's in a layout the size hints are based purely on the content.
> 
> the different behavior is when it's in a gridview or a listview, where its 
> sized is based respectively on the cell size or to be expanding to be as wide 
> as the listview.
> it is kindof hacky, but is the only way i found that "just works"

The following should behave the same and it keeps all the semantic meaning and 
it means data flows in the right directions

  implicitHeight: mainLayout.implicitHeight + topPadding + bottomPadding
  height: internal.completed && internal.gridView
  ? internal.gridView.cellHeight - Kirigami.Units.largeSpacing*2 : 
implicitHeight

(not tested as I have an error running the gallery, see IRC)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: davidedmundson, progwolff, plasma-devel, apol, mart, hein

D10944: [taskmanager applet] Do not fill width

[Eike Hein]

hein added a comment.


  The applet basically exports "this is the space I need at a minimum" and 
"give me all you got". What I'm saying is that there should be a 
containment-level option to override the latter and disable fillWidth for the 
applet. fillWidth is a hint, not a guarantee, and it's up to the containment to 
grant it or not.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  I understand you do not like adding options that you do not like adding 
options adjust think which should be configured on another level. But to be 
able to configure filling empty space at level of panel applets must not claim 
they need more space than they really do (and now taskmanager is doing exactly 
that). So possible solutions I see are:
  
  - Always limit taskmanager to needed space only (i.e. set `maximumWidth: 
preferredWidth`): The best solution from technical point of view, lets you 
config filling empty space by adding expanding spacers into panel **but** it 
breaks existing setups which is highly undesirable as I understood from 
previous comments.
  - Add config option as proposed by this patch: It enables the desired 
behavior without breaking existing setups, but adds a bit non-systematic config 
option.
  - Do nothing: Taskmanager will keep eating all space and and some reasonable 
setups will be impossible to achieve.  F5735027: Screenshot_20180301_175311.png 

  
  I believe the last option is the worst by far.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11316: Components for Cards

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in AbstractCard.qml:69
> no, when it's in a layout the size hints are based purely on the content.
> 
> the different behavior is when it's in a gridview or a listview, where its 
> sized is based respectively on the cell size or to be expanding to be as wide 
> as the listview.
> it is kindof hacky, but is the only way i found that "just works"

in the latest version i get zero binding loops in fact

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[Julian Wolff]

progwolff added a comment.


  There seems to be a problem with the overflow menu:
  
  F5753673: Screenshot_20180314_121900.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AbstractCard.qml:69
> are you basing the implicit size from the size of the parent layout?

no, when it's in a layout the size hints are based purely on the content.

the different behavior is when it's in a gridview or a listview, where its 
sized is based respectively on the cell size or to be expanding to be as wide 
as the listview.
it is kindof hacky, but is the only way i found that "just works"

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AbstractCard.qml:69
> +
> +implicitWidth: internal.completed
> +? (internal.listView ? internal.listView.width - 
> internal.listView.spacing * 2 :   

are you basing the implicit size from the size of the parent layout?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: davidedmundson, progwolff, plasma-devel, apol, mart, hein

D11316: Components for Cards

[Marco Martin]

mart updated this revision to Diff 29486.
mart added a comment.


  - fix typos

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11316?vs=29469=29486

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/styles/org.kde.desktop/Units.qml

To: mart, #kirigami
Cc: progwolff, plasma-devel, apol, davidedmundson, mart, hein

D11316: Components for Cards

[Julian Wolff]

progwolff added a comment.


  Marked some typos. Note that I am not a native speaker, so please re-check 
them.
  
  Besides that, looks good to me.

INLINE COMMENTS

> CardsGridViewGallery.qml:61
> +wrapMode: Text.WordWrap
> +text: "The Kirigami types AbstractCard and Card are used to 
> implement the popular Card pattern used on many mobile and web platforms that 
> is used to display a collection of information or actions.\n Besides the Card 
> components, Kirigami offers also 3 kinds of views and positioners to help to 
> present cards with beautiful and responsive layouts.\n\nIn this page, 
> CardsGridView shows an example on how to put cards in a grid view, generated 
> by a Qt model.\nThe behavior is same as CardsLayout, and it allowes cards to 
> be put in one or two columns depending from the available 
> width.\nCardsGridView has the limitation that every Card must have the same 
> exact height, so cellHeight must be manually set to a value in which the 
> content fits for every item.\nIf possible use cards only when you don't need 
> to instantiate that many and use CardsLayout intead."
> +}

If I'm not wrong: allowes -> allows

> CardsLayoutGallery.qml:78
> +wrapMode: Text.WordWrap
> +text: "An AbstractCard is the simplest form of card. Its 
> just a rectangle with a shadow, which can contain any Item in it. It can also 
> have items assigned to the Header or Footer properties. in this case a 
> Kirigami.Heading is its header and a Label with WordWrap is the contentItem."
> +}

Its just a -> It's just a
. in -> . In

> CardsLayoutGallery.qml:87
> +wrapMode: Text.WordWrap
> +text: "This is an AbstractCard with a Label with 
> WordWrap in it and nothing else, it's the simplest form Cards can be found 
> in.\nAn AbstractCard can be clicked itself, with the usual onClicked signal 
> handler and the showClickFeedback property can be used if the click should 
> show any kind of visual feedback. It is recomended to set it to true if you 
> plan to make the card reactive on any kind of click."
> +}

recomended -> recommended

> CardsLayoutGallery.qml:215
> +topPadding: avatarIcon.height/2
> +text: "It's possible to customize the look and feel for 
> Cards too, if the no padding behavior for headers is needed. This is usually 
> discouraged in order to have greater consistency, but in some cases the 
> design requires a more fancy layout, as shown in this example of a Card. if a 
> custom header is used, the title and icon in the banner property shouldn't be 
> used. If a custom footer is used (which is discouraged), actions shouldn't be 
> used."
> +}

. if -> . If

> CardsLayoutGallery.qml:247
> +wrapMode: Text.WordWrap
> +text: "A card can optionally have horizontal 
> orientation.\n in this case will be wider than tall, so is fit to be used 
> also in a ColumnLayout.\nIf you need to put it in a CardsLayout, it will have 
> by default a columnSpan of 2 (which can be overridden)."
> +}

.\n in -> .\n In

> CardsListViewGallery.qml:61
> +wrapMode: Text.WordWrap
> +text: "The Kirigami types AbstractCard and Card are used to 
> implement the popular Card pattern used on many mobile and web platforms that 
> is used to display a collection of information or actions.\n Besides the Card 
> components, Kirigami offers also 3 kinds of views and positioners to help to 
> present cards with beautiful and responsive layouts.\n\nIn this page, 
> CardsListView is used to do a list view of AbstractCard subclasses with a 
> custom layout inside.\n CardsListView should be used only with cards which 
> can look good at any horizontal size, so It is recommended to use directly 
> AbstractCard with an appropriate layout inside, because they are stretching 
> for the whole list width.\nTherefore is discouraged to use it with the Card 
> type, unless it has Horizontal as headerOrientation.\n The choice between 
> using this view with AbstractCard or a normal ListView with 
> AbstractListItem/BasicListItem is purely a choice based on aestetics alone."
> +}

so It is -> so it is

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami
Cc: progwolff, plasma-devel, apol, davidedmundson, mart, hein

D10944: [taskmanager applet] Do not fill width

[Eike Hein]

hein added a comment.


  I'm not going to accept the patch as is, sorry - to me this is littering 
applets with config options that should be handled generically at the 
containment level instead. I had a brief chat with Marco Martin about this last 
week and he agreed as well and I think was going to look into it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10297: Add new "Tools" button above System Monitor's process list

[Eike Hein]

hein added a comment.


  I haven't been able to review the patch in detail myself, but the basic idea 
is fantastic IMHO.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Eike Hein]

hein added a comment.


  FWIW: AIUI this patch isn't about making the lock screen use the current user 
wallpaper dynamically, which means the vendor gets control over making sure the 
default wallpaper they pick works with the UI elements at least.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Marco Martin]

mart added a comment.


  Sadly, the current design doesn't really allow for arbitrary wallpapers (and 
since is possible already to put any image, that's quite a problem)
  if a wallpaper should become the default again, the text elements should 
either have a visible background for contrast (so would mean a pretty heavy 
redesign) or, showing only the wallpaper by default and only after mouse 
move/any interaction the actual controls appear and the wallpaper gets either 
completely covered or with an heavy blur+contrast (blur alone isn't enough to 
ensure readability of text, the shader should modify the colors as well, like 
the plasma panel does)
  
  there are several options for that, but all will mean some rewrite, in order 
for it to look like a godd quality product. So now the challenge is i guess 
arriving firt with a good design which is not too big of a departure, doesn't 
look too busy, and works well with any wallpaper.. sounds like a fun challenge 
:)
  
  btw, for reference, the current is https://phabricator.kde.org/T2062

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Marco Martin]

mart added a comment.


  -1 from me too

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11316: Components for Cards

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Cards are divided in AbstractCard which is empty and Card,
  which has a default layout of
  header: image and title
  contentItem: free for any kind of item, but just a Label
  with WordWrap recommended
  footer: list of action buttons

TEST PLAN
  tested in Kirigmai Gallery

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/styles/org.kde.desktop/Units.qml

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11309: Use the default Plasma wallpaper on the login screen

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> theme.conf:3
> +type=image
> +background=/usr/share/wallpapers/Next/contents/images/3200x2000.png

This must follow `${KDE_INSTALL_DATADIR}` or whatever this cmake variable this 
is (I'm not good at build systems)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: ngraham, #plasma, #vdg, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11205: Fix ActionButton size

[Igor Cota]

icota closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11205

To: icota, #kirigami, mart
Cc: ngraham, plasma-devel, #kirigami, apol, davidedmundson, mart, hein

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel updated this revision to Diff 29457.
Pitel added a comment.


  - modified `onConfigurationChanged` so it triggers updates of properties 
depending on `cfg_shownItems` and `cfg_hiddenItems`
  - make trash bin not draggable
  - removed `ComboBox` hack (which was not working anyway) and added an overlay 
label to combobox showing `S` for items in `cfg_shownItems` and `H` for items 
in `cfg_hiddenItems` (this is meant as debugging tool only) -- when dragging 
the visibility values in comboboxes go wrong but those letter remain correct 
which leads me to conclusion that the problem is `ComboBox` component 
(@wsdfhjxc can you verify this behavior?)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11292?vs=29421=29457

BRANCH
  stableSystray

REVISION DETAIL
  https://phabricator.kde.org/D11292

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/OrderableItem.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #plasma, #vdg
Cc: zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8302: Add FreeBSD port from the development-repo

[Tobias C . Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:36033bac748f: Add FreeBSD port from the development-repo 
(authored by tcberner).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8302?vs=29455=29456

REVISION DETAIL
  https://phabricator.kde.org/D8302

AFFECTED FILES
  README.md

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D8302: Add FreeBSD port from the development-repo

[Tobias C . Berner]

tcberner updated this revision to Diff 29455.
tcberner added a comment.


  Update text

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8302?vs=20765=29455

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8302

AFFECTED FILES
  README.md

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a comment.


  Sorry, but clear -1 from me for the reasons outlined in the Telegram channel.
  
  It looks cluttered, and with the very limited space in plasmoids it becomes 
unpredictable with translations. 
  It removes the very alignment that broulik and I worked hard to achieve. 
  It is inconsistent with the klipper plasmoid, which had that exact 
functionality for years, so I think we can live with it until we fixed the 
actual problem, which is "we need a better, more clear icon".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart