KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 90 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/90/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Mar 2018 02:07:55 +
 Build duration:
1 hr 30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30458.
hein added a comment.


  Remove unrelated files.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30446=30458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  I disagree with this patch - I renamed things for consistency for a reason 
and emailed i18n-doc, so I expect the docs to get renamed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10454: Translated all texts from the en directory so the extension works in es

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  As per Kai's comments, marking as needs changes

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10454

To: antlarr, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[David Edmundson]

davidedmundson added a comment.


  In general fine.

INLINE COMMENTS

> main.qml:65-67
> +// button itself adds sufficient visual padding
> +Layout.leftMargin: -parent.spacing
> +Layout.rightMargin: -parent.spacing

You can find a better solution. Especially as there's only 3 items (two spaces) 
in this Layout.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11665: Make Select/Deselect All operate on the filtered rows.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b49b73dee7d1: Make Select/Deselect All operate on the 
filtered rows. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11665?vs=30450=30456

REVISION DETAIL
  https://phabricator.kde.org/D11665

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigFilter.qml
  containments/desktop/plugins/folder/mimetypesmodel.cpp
  containments/desktop/plugins/folder/mimetypesmodel.h

To: hein, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11590: Add mutex round static member used in a thread

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:52ceb2454be4: Add mutex round static member used in a 
thread (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11590?vs=30298=30455

REVISION DETAIL
  https://phabricator.kde.org/D11590

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h

To: davidedmundson, #plasma, mart
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11591: Remove anchors in layout in wallpaper config

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:21d97beb28be: Remove anchors in layout in wallpaper 
config (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11591?vs=30265=30454#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11591?vs=30265=30454

REVISION DETAIL
  https://phabricator.kde.org/D11591

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11665: Make Select/Deselect All operate on the filtered rows.

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  BUG:392264

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11665

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigFilter.qml
  containments/desktop/plugins/folder/mimetypesmodel.cpp
  containments/desktop/plugins/folder/mimetypesmodel.h

To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  I have no strong preference as far as the visuals are concerned. I would be 
OK with the rounded + colored version, too. It's also fairly close to 
KMessageWidget, which would make it quite easy to make KMessageWidget look 
similar (other than spacing). If this version achieves consensus, I would fix 
the inside border corners rounding properly. As the code changes for that would 
be very minor, I'll leave the code as-is for now for initial code review.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Nathaniel Graham]

ngraham added a comment.


  Big +1 on the version with the colored borders and background.  That looks 
really classy IMHO.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30446.
hein added a comment.


  Get rid of an unnecessary extra Rectangle.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30445=30446

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/Card.qml
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  Quick hacks for alternate appearances based on VDG chat brainstorming:
  
  F5765210: inlinemessages4.png 
  
  F5765212: inlinemessages5.png 
  
  On this last one the inside corners are not properly rounded because it's 
just a quick and dirty hack.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30445.
hein added a comment.


  Don't use redundant default value in API documentation code example.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30444=30445

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30444.
hein added a comment.


  Add more defaults to API documentation.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30442=30444

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  Additional note: The missing icons in the Material Gallery screenshot are 
because the Gallery app build system seems to refuse to extract them from 
Breeze for unknown reasons (perhaps missing sizes).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  This component is needed to complete task T7247 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30442.
hein added a comment.


  Fix typo in Gallery error message example text.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30441=30442

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  Kirigami Gallery app, desktop style:
  
  F5765163: inlinemessages1.png 
  
  Kirigami Gallery app, desktop style, after the actions are used:
  
  F5765167: inlinemessages2.png 
  
  Kirigami Gallery app, Material style:
  
  F5765169: inlinemessages3.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein created this revision.
hein added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  InlineMessage can be used to show various messages to the user,
  without requiring the use of a dialog.
  
  InlineMessage is analogous to KWidgetAddons' KMessageWidget and
  provides nearly the same API:
  
  - Message type: Information (default), Positive, Warning or Error
  - Message text
  - Icon (optional)
  - Closable (optional, shows close button)
  - Actions list (shown as buttons)
  - Signals for link hover and link activation
  - Animation state
  
  It does not implement the 'wordWrap' property of KMessageWidget.
  Instead, wrapping the message text is always wrapped.
  
  Further, unlike in KMessageWidget, actions buttons are added from
  left to right, not from right to left.
  
  Additionally, it improves over KMessageWidget in two ways:
  
  - If no icon is manually set, it shows an appropriate icon for the message 
type by default.
  - Overflow handling for many messages (à la the Card component).
  
  All properties are declared abstractly in the template and all
  visuals are implemented in the control, so that the style can
  optionally override the appearance fully.
  
  This patch also adds an example page to the Gallery app which
  illustrates the various message types and features in an
  interactive manner.
  
  Random notes:
  
  - I would have preferred to make the template API completely abstract and had 
'showCloseButton' as 'closable' originally but then changed it for consistency 
with the property in OverlaySheet.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11662: Minor cleanup.

[Eike Hein]

hein created this revision.
hein added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
hein requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11662

AFFECTED FILES
  src/controls/Card.qml
  src/controls/templates/ApplicationHeader.qml

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Localization, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  kcms/launch/kcm_launchfeedback.desktop
  X-DocPath=kcontrol/kcmlaunchfeedback/index.html
  
  doc/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION 
${KDE_INSTALL_DOCBUNDLEDIR}/en SUBDIR kcontrol/kcmlaunch)
  
  kcmlaunch != kcmlaunchfeedback therefore the en_US documentation is not found
  
  Scripty generates the install path from the dir name
  l10n-kf5/[lang]/docs/kde-workspace/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION 
${HTML_INSTALL_DIR}/${CURRENT_LANG}/ SUBDIR kcontrol/kcmlaunch )
  
  We need X-DocPath=kcontrol/kcmlaunch/index.html in the desktop file
  then khelpcenter finds the correct docbook for en_US and all language 
translations

TEST PLAN
  build and works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

AFFECTED FILES
  kcms/launch/kcm_launchfeedback.desktop

To: lueck, #plasma, #localization, #documentation
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11660: Update systemsettings cursortheme docbook

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releaseinfo

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11660

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11659: Update systemsettings fonts docbook to 5.12

[Burkhard Lück]

lueck added a comment.


  The kcm_fonts.desktop file has an entry X-DocPath=kcontrol/fonts/index.html,
  but the Help button in the QML module is disabled

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11659

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11659: Update systemsettings fonts docbook to 5.12

[Burkhard Lück]

lueck added a comment.


  F5765097: main.png 
  
  F5765096: adjust-all.png 
  
  New updated screenshots

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11659

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11659: Update systemsettings fonts docbook to 5.12

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update to match the new GUI
  bump date + releaseinfo
  update screenshots

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11659

AFFECTED FILES
  doc/kcontrol/fonts/adjust-all.png
  doc/kcontrol/fonts/index.docbook
  doc/kcontrol/fonts/main.png

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Ben Cooksley]

On Sun, Mar 25, 2018 at 6:59 AM, Martin Flöser  wrote:
> Hi Ben,

Hi Martin,

>
> I pushed a possible fix. No guarnatees as this code obviously compiled on my
> system.

Thanks. That has fixed the issue.

>
> Could the compiler settings please be adjusted so that we have warnings be
> warnings on all ci systems and not fail on randomly? This was rather
> unexpected for me and makes it quite difficult to properly test before hand.
> The firefighting afterwards is something I don't like as mails with "fix
> this as soon as possible" are difficult if you don't have much time.

It appears that this is a FreeBSD or Clang specific issue as it didn't
fail on the Linux or Windows builds.

I've no idea where those settings could be coming from - however I
don't think it's a good idea for us to alter any settings specified by
the distributor, at least not at the CI system level, as that then
makes the CI system different from normal systems (and having it
compile on the CI system when it breaks on user systems is non-ideal).

Changing it in ECM or elsewhere in our CMake code would be the
preferable fix here if the compiler settings need changing.

>
> Cheers
> Martin

Thanks,
Ben

>
> Am 2018-03-24 11:25, schrieb Ben Cooksley:
>>
>> Hi Martin,
>>
>> Please see below. Could you please fix this as soon as possible?
>>
>> This is blocking all FreeBSD Dependency builds meaning any change to
>> the binary compatibility state of the FreeBSD platform will break the
>> whole CI system on FreeBSD.
>>
>> Cheers,
>> Ben
>>
>> On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:
>>
>>> BUILD FAILURE
>>>
>>> Build URL
>>>
>>
>> https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/
>>>
>>> [1]
>>>
>>>
>>> Project:
>>> Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
>>>
>>> Date of build:
>>> Wed, 21 Mar 2018 05:50:19 +
>>>
>>> Build duration:
>>> 1 min 31 sec and counting
>>>
>>> CONSOLE OUTPUT
>>>
>>> [...truncated 92.62 KB...]
>>>
>>> [ 10%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o
>>>
>>>
>>> [ 11%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o
>>>
>>>
>>> [ 12%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o
>>>
>>>
>>> [ 12%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o
>>>
>>>
>>> [ 13%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning:
>>> unused variable 'num' [-Wunused-variable]
>>>
>>> char num[ 256 ];
>>>
>>> ^
>>>
>>> 1 warning generated.
>>>
>>> [ 14%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o
>>>
>>> [ 15%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o
>>>
>>> [ 16%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> keySymX = XKeycodeToKeysym(QX11Info::display(),
>>> xmk->modifiermap[xmk->max_keypermod * i + j], k);
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2))
>>> {
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> 

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Fabian Vogt]

fvogt added a comment.


  In D10816#233088 , @graesslin 
wrote:
  
  > In D10816#233074 , @fvogt wrote:
  >
  > > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a 
tty - so should this also check for `WAYLAND_DISPLAY` or 
`startplasmacompositor` set `XDG_SESSION_TYPE=wayland`?
  >
  >
  > [...] from developers we can expect to set this variable.
  
  
  Any reason not to set it in `startplasmacompositor` then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: fvogt, davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma systemsettings kf5-qt5 FreeBSDQt5.9 - Build # 34 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Plasma systemsettings kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 18:49:12 +
 Build duration:
3 min 33 sec and counting

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Martin Flöser]

graesslin added a comment.


  In D10816#233074 , @fvogt wrote:
  
  > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty 
- so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` 
set `XDG_SESSION_TYPE=wayland`?
  
  
  No, I think that's a cornercase. Running from a tty is not the way users 
interact with the system and from developers we can expect to set this variable.
  
  Basing the change on the availability of WAYLAND_DISPLAY or DISPLAY has 
disadvantages including that we don't know what the door is. We could have 
both: Wayland on top of X of X on top of Wayland.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: fvogt, davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11607: Update systemsettings docbook to 5.12

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:b73b544a1281: Update systemsettings docbook to 5.12 
(authored by lueck).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11607?vs=30300=30423

REVISION DETAIL
  https://phabricator.kde.org/D11607

AFFECTED FILES
  doc/index.docbook

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11561: fix typos in UI strings

[Ivan Čukić]

ivan added a comment.


  > "can't" should not be used in formal writings. Not sure how formal 
documentation is considered to be.
  
  Heh, I was thought that as well, and then had to search'n'replace my whole 
book to  replace with *n't forms of everything. ;)
  
  Thanks for this patch!

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D11561

To: schwarzer, ivan, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Fabian Vogt]

fvogt added a comment.


  `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - 
so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set 
`XDG_SESSION_TYPE=wayland`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: fvogt, davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 17:54:55 +
 Build duration:
3 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Martin Flöser]

Hi Ben,

I pushed a possible fix. No guarnatees as this code obviously compiled 
on my system.


Could the compiler settings please be adjusted so that we have warnings 
be warnings on all ci systems and not fail on randomly? This was rather 
unexpected for me and makes it quite difficult to properly test before 
hand. The firefighting afterwards is something I don't like as mails 
with "fix this as soon as possible" are difficult if you don't have much 
time.


Cheers
Martin

Am 2018-03-24 11:25, schrieb Ben Cooksley:

Hi Martin,

Please see below. Could you please fix this as soon as possible?

This is blocking all FreeBSD Dependency builds meaning any change to
the binary compatibility state of the FreeBSD platform will break the
whole CI system on FreeBSD.

Cheers,
Ben

On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:


BUILD FAILURE

Build URL


https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/

[1]

Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9

Date of build:
Wed, 21 Mar 2018 05:50:19 +

Build duration:
1 min 31 sec and counting

CONSOLE OUTPUT

[...truncated 92.62 KB...]

[ 10%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o


[ 11%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o


[ 12%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o


[ 12%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o


[ 13%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning:
unused variable 'num' [-Wunused-variable]

char num[ 256 ];

^

1 warning generated.

[ 14%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o

[ 15%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o

[ 16%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

keySymX = XKeycodeToKeysym(QX11Info::display(),
xmk->modifiermap[xmk->max_keypermod * i + j], k);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

[ 16%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o


6 warnings generated.

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from
'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases
required alignment from 1 to 4 [-Wcast-align]

uint32_t *d32 = (uint32_t *) 

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 17:54:55 +
 Build duration:
2 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  In D11220#232803 , @hein wrote:
  
  > If it's the only way to end this debate, could you instead implement the 
patch that uses the icon size setting as switch threshold?
  
  
  I created the following: https://phabricator.kde.org/D11651

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11651: FolderView applet respect panel maxIcon size

[Michail Vourlakos]

mvourlakos updated this revision to Diff 30420.
mvourlakos added a comment.


  - fix typo to iconSizeHints

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11651?vs=30413=30420

BRANCH
  folderview

REVISION DETAIL
  https://phabricator.kde.org/D11651

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma, hein, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11651: FolderView applet respect panel maxIcon size

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, hein, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --FolderView takes into account the
  units.iconSizes.panel value when is in panel
  in order to switch its appearance from
  CompactRepresentation to FullRepresentation
  and vice versa.

TEST PLAN
  confirm that in order for FolderView to change to
  FullRepresention when it is in panel, it respects
  the units.iconSizes.panel value.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  folderview

REVISION DETAIL
  https://phabricator.kde.org/D11651

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma, hein, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 89 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/89/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 13:36:55 +
 Build duration:
48 min and counting
   CONSOLE OUTPUT
  [...truncated 68.53 KB...]BUILD_DISPLAY_NAME= '#89'USER  = 'jenkins'LANG  = 'en_US.UTF-8'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so - found-- Looking for gethostbyname-- Looking for gethostbyname - found-- Looking for connect-- Looking for connect - found-- Looking for remove-- Looking 

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 13:36:22 +
 Build duration:
45 min and counting
   CONSOLE OUTPUT
  [...truncated 91.64 KB...][ 10%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning: unused variable 'num' [-Wunused-variable]char num[ 256 ]; ^1 warning generated.[ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]keySymX = XKeycodeToKeysym(QX11Info::display(), xmk->modifiermap[xmk->max_keypermod * i + j], k);  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))   ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2)) {  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3)) {  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);   ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^6 warnings generated./usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from 'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]uint32_t *d32 = (uint32_t *) icons[i].data;^~/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: error: non-constant-_expression_ cannot be narrowed from type 'int' to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]topology.top, topology.bottom, topology.left, topology.right, 1^~~~/usr/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: note: insert an explicit cast to silence this issuetopology.top, topology.bottom, topology.left, topology.right, 1^~~~static_cast( 

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 24 Mar 2018 13:36:22 +
 Build duration:
44 min and counting
   CONSOLE OUTPUT
  [...truncated 93.62 KB...][ 11%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning: unused variable 'num' [-Wunused-variable]char num[ 256 ]; ^1 warning generated.[ 14%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]keySymX = XKeycodeToKeysym(QX11Info::display(), xmk->modifiermap[xmk->max_keypermod * i + j], k);  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))   ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2)) {  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3)) {  ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning: 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);   ^/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been explicitly marked deprecated hereextern KeySym XKeycodeToKeysym(  ^[ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o6 warnings generated./usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from 'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]uint32_t *d32 = (uint32_t *) icons[i].data;^~/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: error: non-constant-_expression_ cannot be narrowed from type 'int' to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]topology.top, topology.bottom, topology.left, topology.right, 1^~~~/usr/home/jenkins/workspace/Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: note: insert an explicit cast to silence this issuetopology.top, 

[kdeplasma-addons] applets: Revert "use plasma_install_bundled_package"

[Friedrich W . H . Kossebau]

Git commit db0bc0e3116986850f9d6b304b739698caef39d6 by Friedrich W. H. Kossebau.
Committed on 24/03/2018 at 14:06.
Pushed by kossebau into branch 'master'.

Revert "use plasma_install_bundled_package"

This reverts commit c505a726b3f1fff95c382e46377b495016d04786.

Quoting David Edmundson from similar commit to plasma-workspace:
"
Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.

When re-reverting we need to be sure to test with clean install prefixes.
"
CC: plasma-devel@kde.org

M  +4-4applets/CMakeLists.txt
M  +1-1applets/binary-clock/CMakeLists.txt
M  +1-1applets/calculator/CMakeLists.txt
M  +1-1applets/colorpicker/CMakeLists.txt
M  +1-1applets/comic/CMakeLists.txt
M  +1-1applets/dict/CMakeLists.txt
M  +1-1applets/diskquota/CMakeLists.txt
M  +1-1applets/fifteenPuzzle/CMakeLists.txt
M  +1-1applets/fuzzy-clock/CMakeLists.txt
M  +1-1applets/grouping/CMakeLists.txt
M  +1-1applets/grouping/container/CMakeLists.txt
M  +1-1applets/mediaframe/CMakeLists.txt
M  +1-1applets/minimizeall/CMakeLists.txt
M  +1-1applets/notes/CMakeLists.txt
M  +1-1applets/quicklaunch/CMakeLists.txt
M  +1-1applets/quickshare/CMakeLists.txt
M  +1-1applets/showdesktop/CMakeLists.txt
M  +1-1applets/systemloadviewer/CMakeLists.txt
M  +1-1applets/timer/CMakeLists.txt
M  +1-1applets/userswitcher/CMakeLists.txt
M  +1-1applets/weather/CMakeLists.txt
M  +1-1applets/webbrowser/CMakeLists.txt

https://commits.kde.org/kdeplasma-addons/db0bc0e3116986850f9d6b304b739698caef39d6

diff --git a/applets/CMakeLists.txt b/applets/CMakeLists.txt
index 4da44bb5a..e73be9008 100644
--- a/applets/CMakeLists.txt
+++ b/applets/CMakeLists.txt
@@ -1,7 +1,7 @@
-plasma_install_bundled_package(activitypager org.kde.plasma.activitypager)
-plasma_install_bundled_package(kickerdash org.kde.plasma.kickerdash)
-plasma_install_bundled_package(konsoleprofiles/package 
org.kde.plasma.konsoleprofiles)
-plasma_install_bundled_package(keyboardindicator 
org.kde.plasma.keyboardindicator)
+plasma_install_package(activitypager org.kde.plasma.activitypager)
+plasma_install_package(kickerdash org.kde.plasma.kickerdash)
+plasma_install_package(konsoleprofiles/package org.kde.plasma.konsoleprofiles)
+plasma_install_package(keyboardindicator org.kde.plasma.keyboardindicator)
 
 add_subdirectory(binary-clock)
 add_subdirectory(calculator)
diff --git a/applets/binary-clock/CMakeLists.txt 
b/applets/binary-clock/CMakeLists.txt
index 909178d4e..39cef05cb 100644
--- a/applets/binary-clock/CMakeLists.txt
+++ b/applets/binary-clock/CMakeLists.txt
@@ -1 +1 @@
-plasma_install_bundled_package(package org.kde.plasma.binaryclock)
+plasma_install_package(package org.kde.plasma.binaryclock)
diff --git a/applets/calculator/CMakeLists.txt 
b/applets/calculator/CMakeLists.txt
index 25f0c7210..15d6d4f35 100644
--- a/applets/calculator/CMakeLists.txt
+++ b/applets/calculator/CMakeLists.txt
@@ -1 +1 @@
-plasma_install_bundled_package(package org.kde.plasma.calculator)
+plasma_install_package(package org.kde.plasma.calculator)
diff --git a/applets/colorpicker/CMakeLists.txt 
b/applets/colorpicker/CMakeLists.txt
index fde98c750..c9ee88f89 100644
--- a/applets/colorpicker/CMakeLists.txt
+++ b/applets/colorpicker/CMakeLists.txt
@@ -1,6 +1,6 @@
 set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
 
-plasma_install_bundled_package(package org.kde.plasma.colorpicker)
+plasma_install_package(package org.kde.plasma.colorpicker)
 
 set(colorpickerplugin_SRCS
 plugin/grabwidget.cpp
diff --git a/applets/comic/CMakeLists.txt b/applets/comic/CMakeLists.txt
index fb889d07f..58063c9cb 100644
--- a/applets/comic/CMakeLists.txt
+++ b/applets/comic/CMakeLists.txt
@@ -38,5 +38,5 @@ install(TARGETS plasma_applet_comic DESTINATION 
${KDE_INSTALL_PLUGINDIR}/plasma/
 #install(FILES plasma-comic-default.desktop DESTINATION 
${SERVICES_INSTALL_DIR})
 
 install(FILES comic.knsrc DESTINATION ${KDE_INSTALL_CONFDIR})
-plasma_install_bundled_package(package org.kde.plasma.comic)
+plasma_install_package(package org.kde.plasma.comic)
 
diff --git a/applets/dict/CMakeLists.txt b/applets/dict/CMakeLists.txt
index 36bf7b9ae..d14e91149 100644
--- a/applets/dict/CMakeLists.txt
+++ b/applets/dict/CMakeLists.txt
@@ -10,7 +10,7 @@ if (Qt5WebEngine_FOUND)
 
 
###
 # Package (metadata.desktop and QML)
-plasma_install_bundled_package(package org.kde.plasma_applet_dict)
+plasma_install_package(package org.kde.plasma_applet_dict)
 
 
###
 # Icon for the package
diff --git a/applets/diskquota/CMakeLists.txt b/applets/diskquota/CMakeLists.txt
index a46cc6046..cb974949d 100644
--- a/applets/diskquota/CMakeLists.txt
+++ 

D10251: [RFC] Use mipmap filtering in window thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Could we land this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg, davidedmundson
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11631: Fix pixelated icon scaling for HiDPI screens

[Andrew Crouthamel]

acrouthamel added a comment.


  In D11631#232788 , @rkflx wrote:
  
  > @acrouthamel Awesome, you made it!
  
  
  Thanks to you and @broulik :)

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D11631

To: acrouthamel, rkflx, broulik, davidedmundson
Cc: davidedmundson, cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11220: option to force FolderView icon-only presentation

[Eike Hein]

hein added a comment.


  I really think this is ugly and don't want it :/
  
  If it's the only way to end this debate, could you instead implement the 
patch that uses the icon size setting as switch threshold?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11631: Fix pixelated icon scaling for HiDPI screens

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:e8e3c0f8e4a1: Fix pixelated icon scaling for HiDPI 
screens (authored by acrouthamel, committed by rkflx).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11631?vs=30368=30382

REVISION DETAIL
  https://phabricator.kde.org/D11631

AFFECTED FILES
  main.cpp
  treeview.cpp

To: acrouthamel, rkflx, broulik, davidedmundson
Cc: davidedmundson, cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11631: Fixes pixelated icon scaling for HiDPI screens

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  @acrouthamel Awesome, you made it!
  
  In D11631#232691 , @cfeck wrote:
  
  > Does it still need KIconThemes framework elsewhere? If not, the dependency 
could be removed.
  
  
  E.g. `KIconLoader` is used elsewhere, so we'll have to keep the dependency 
for now.

REPOSITORY
  R103 KMenu Editor

BRANCH
  fix-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11631

To: acrouthamel, rkflx, broulik, davidedmundson
Cc: davidedmundson, cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Ben Cooksley]

Hi Martin,

Please see below. Could you please fix this as soon as possible?

This is blocking all FreeBSD Dependency builds meaning any change to the
binary compatibility state of the FreeBSD platform will break the whole CI
system on FreeBSD.

Cheers,
Ben

On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:

> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%
> 20kf5-qt5%20FreeBSDQt5.9/15/
> Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
> Date of build: Wed, 21 Mar 2018 05:50:19 +
> Build duration: 1 min 31 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 92.62 KB...]
> [ 10%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/
> ECMQmLoader-kwindowsystem5_qt.cpp.o
> [ 11%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kselectionowner.cpp.o
> [ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kselectionwatcher.cpp.o
> [ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxerrorhandler.cpp.o
> [ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxutils.cpp.o
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning: unused
> variable 'num' [-Wunused-variable]
> char num[ 256 ];
> ^
> 1 warning generated.
> [ 14%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kkeyserver.cpp.o
> [ 15%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxmessages.cpp.o
> [ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/netwm.cpp.o
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> keySymX = XKeycodeToKeysym(QX11Info::display(), 
> xmk->modifiermap[xmk->max_keypermod
> * i + j], k);
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> [ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/
> KF5WindowSystem_autogen/mocs_compilation.cpp.o
> 6 warnings generated.
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from
> 'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases required
> alignment from 1 to 4 [-Wcast-align]
> uint32_t *d32 = (uint32_t *) icons[i].data;
> ^~
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: error:
> non-constant-expression cannot be narrowed from type 'int' to 'uint32_t'
> (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
> topology.top, topology.bottom, topology.left, topology.right, 1
> ^~~~
> 

D11639: delete COPYING-ICONS

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Icons are not a part of this repo anymore so delete corresponding COPYING 
file.

REPOSITORY
  R31 Breeze

BRANCH
  delete-copying-icons

REVISION DETAIL
  https://phabricator.kde.org/D11639

AFFECTED FILES
  COPYING-ICONS

To: zzag, #breeze
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11638: modernize: delete redundant return statements

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  All these return statements are at the end of functions which return
  nothing.

REPOSITORY
  R31 Breeze

BRANCH
  modernize-redundant-control-flow

REVISION DETAIL
  https://phabricator.kde.org/D11638

AFFECTED FILES
  kdecoration/breezesizegrip.cpp
  kdecoration/config/breezedetectwidget.cpp
  kdecoration/config/breezeexceptionlistwidget.cpp
  kdecoration/config/breezelistmodel.h
  kstyle/animations/breezeanimations.cpp
  kstyle/animations/breezebusyindicatorengine.cpp
  kstyle/animations/breezetransitionwidget.cpp
  kstyle/breezeframeshadow.cpp
  kstyle/breezehelper.cpp
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezemnemonics.cpp
  kstyle/breezestyle.cpp
  kstyle/breezewindowmanager.cpp

To: zzag, #breeze
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11636: modernize: delete redundant void args

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Redundant void args are deleted with clang-tidy.
  See 
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html

REPOSITORY
  R31 Breeze

BRANCH
  modernize-void-arg

REVISION DETAIL
  https://phabricator.kde.org/D11636

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezebutton.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsprovider.cpp
  kdecoration/breezesettingsprovider.h
  kdecoration/breezesizegrip.cpp
  kdecoration/breezesizegrip.h
  kdecoration/config/breezeconfigwidget.cpp
  kdecoration/config/breezeconfigwidget.h
  kdecoration/config/breezedetectwidget.h
  kdecoration/config/breezeexceptiondialog.cpp
  kdecoration/config/breezeexceptiondialog.h
  kdecoration/config/breezeexceptionlistwidget.cpp
  kdecoration/config/breezeexceptionlistwidget.h
  kdecoration/config/breezeitemmodel.h
  kdecoration/config/breezelistmodel.h
  kstyle/breezeblurhelper.h

To: zzag, #breeze
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11635: modernize: use nullptr

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The old null pointer constants(NULL, 0, etc) are converted to the
  the new C++11 nullptr keyword with clang-tidy.

REPOSITORY
  R31 Breeze

BRANCH
  modernize-nullptr

REVISION DETAIL
  https://phabricator.kde.org/D11635

AFFECTED FILES
  kdecoration/breezesettingsprovider.cpp
  kdecoration/breezesizegrip.cpp
  kdecoration/config/breezedetectwidget.cpp
  kdecoration/config/breezeexceptiondialog.cpp
  kdecoration/config/breezeexceptionlistwidget.h
  kdecoration/config/breezeitemmodel.h
  kdecoration/config/breezelistmodel.h
  kstyle/animations/breezetransitionwidget.cpp
  kstyle/animations/breezetransitionwidget.h
  kstyle/breezeframeshadow.cpp
  kstyle/breezehelper.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyleplugin.h
  kstyle/config/breezestyleconfig.cpp

To: zzag, #breeze
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[plasma-workspace] applets: Revert "use plasma_install_bundled_package"

[David Edmundson]

Git commit 450ef5884d9e93e6f0a2df48aae82f9ed239b394 by David Edmundson.
Committed on 24/03/2018 at 07:31.
Pushed by davidedmundson into branch 'master'.

Revert "use plasma_install_bundled_package"

This reverts commit e37156b404bffd4dc6fd0d1b2dbb5dc1ae0ddfa4.

Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.

When re-reverting we need to be sure to test with clean install prefixes.

CC: plasma-devel@kde.org

M  +6-6applets/CMakeLists.txt
M  +1-1applets/appmenu/CMakeLists.txt
M  +1-1applets/batterymonitor/CMakeLists.txt
M  +1-1applets/calendar/CMakeLists.txt
M  +1-1applets/devicenotifier/CMakeLists.txt
M  +1-1applets/digital-clock/CMakeLists.txt
M  +1-1applets/icon/CMakeLists.txt
M  +1-1applets/notifications/CMakeLists.txt
M  +1-1applets/systemtray/CMakeLists.txt
M  +1-1applets/systemtray/container/CMakeLists.txt

https://commits.kde.org/plasma-workspace/450ef5884d9e93e6f0a2df48aae82f9ed239b394

diff --git a/applets/CMakeLists.txt b/applets/CMakeLists.txt
index 34b3a399..956105e5 100644
--- a/applets/CMakeLists.txt
+++ b/applets/CMakeLists.txt
@@ -1,10 +1,10 @@
-plasma_install_bundled_package(activitybar org.kde.plasma.activitybar)
+plasma_install_package(activitybar org.kde.plasma.activitybar)
 add_subdirectory(icon)
 
-plasma_install_bundled_package(analog-clock org.kde.plasma.analogclock)
-plasma_install_bundled_package(mediacontroller org.kde.plasma.mediacontroller)
-plasma_install_bundled_package(panelspacer org.kde.plasma.panelspacer)
-plasma_install_bundled_package(lock_logout org.kde.plasma.lock_logout)
+plasma_install_package(analog-clock org.kde.plasma.analogclock)
+plasma_install_package(mediacontroller org.kde.plasma.mediacontroller)
+plasma_install_package(panelspacer org.kde.plasma.panelspacer)
+plasma_install_package(lock_logout org.kde.plasma.lock_logout)
 
 add_subdirectory(appmenu)
 add_subdirectory(systemmonitor)
@@ -12,7 +12,7 @@ add_subdirectory(batterymonitor)
 add_subdirectory(calendar)
 add_subdirectory(devicenotifier)
 add_subdirectory(digital-clock)
-plasma_install_bundled_package(clipboard org.kde.plasma.clipboard)
+plasma_install_package(clipboard org.kde.plasma.clipboard)
 
 if(NOT WIN32)
 ##notifications
diff --git a/applets/appmenu/CMakeLists.txt b/applets/appmenu/CMakeLists.txt
index c1786eb4..731013ba 100644
--- a/applets/appmenu/CMakeLists.txt
+++ b/applets/appmenu/CMakeLists.txt
@@ -1,4 +1,4 @@
 add_subdirectory(lib)
 add_subdirectory(plugin)
 
-plasma_install_bundled_package(package org.kde.plasma.appmenu)
+plasma_install_package(package org.kde.plasma.appmenu)
diff --git a/applets/batterymonitor/CMakeLists.txt 
b/applets/batterymonitor/CMakeLists.txt
index 78ff53b9..fb7aea96 100644
--- a/applets/batterymonitor/CMakeLists.txt
+++ b/applets/batterymonitor/CMakeLists.txt
@@ -1 +1 @@
-plasma_install_bundled_package(package org.kde.plasma.battery)
+plasma_install_package(package org.kde.plasma.battery)
diff --git a/applets/calendar/CMakeLists.txt b/applets/calendar/CMakeLists.txt
index 7c08c68b..869aa715 100644
--- a/applets/calendar/CMakeLists.txt
+++ b/applets/calendar/CMakeLists.txt
@@ -11,4 +11,4 @@ target_link_libraries(plasma_applet_calendar
 
 install(TARGETS plasma_applet_calendar DESTINATION 
${KDE_INSTALL_PLUGINDIR}/plasma/applets)
 
-plasma_install_bundled_package(package org.kde.plasma.calendar)
+plasma_install_package(package org.kde.plasma.calendar)
diff --git a/applets/devicenotifier/CMakeLists.txt 
b/applets/devicenotifier/CMakeLists.txt
index abb8952a..23d70e2e 100644
--- a/applets/devicenotifier/CMakeLists.txt
+++ b/applets/devicenotifier/CMakeLists.txt
@@ -1,3 +1,3 @@
-plasma_install_bundled_package(package org.kde.plasma.devicenotifier)
+plasma_install_package(package org.kde.plasma.devicenotifier)
 
 install(FILES test-predicate-openinwindow.desktop DESTINATION 
${KDE_INSTALL_DATADIR}/solid/actions )
diff --git a/applets/digital-clock/CMakeLists.txt 
b/applets/digital-clock/CMakeLists.txt
index 87849742..3114564a 100644
--- a/applets/digital-clock/CMakeLists.txt
+++ b/applets/digital-clock/CMakeLists.txt
@@ -1,3 +1,3 @@
 add_subdirectory(plugin)
 
-plasma_install_bundled_package(package org.kde.plasma.digitalclock)
\ No newline at end of file
+plasma_install_package(package org.kde.plasma.digitalclock)
\ No newline at end of file
diff --git a/applets/icon/CMakeLists.txt b/applets/icon/CMakeLists.txt
index c4793dc6..e4ffda67 100644
--- a/applets/icon/CMakeLists.txt
+++ b/applets/icon/CMakeLists.txt
@@ -17,4 +17,4 @@ target_link_libraries(plasma_applet_icon
 
 install(TARGETS plasma_applet_icon DESTINATION 
${KDE_INSTALL_PLUGINDIR}/plasma/applets)
 
-plasma_install_bundled_package(package org.kde.plasma.icon)
+plasma_install_package(package org.kde.plasma.icon)
diff --git a/applets/notifications/CMakeLists.txt 
b/applets/notifications/CMakeLists.txt
index 7c60237c..adfd6013 100644
--- 

D11631: Fixes pixelated icon scaling for HiDPI screens

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R103 KMenu Editor

BRANCH
  fix-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11631

To: acrouthamel, rkflx, broulik, davidedmundson
Cc: davidedmundson, cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11631: Fixes pixelated icon scaling for HiDPI screens

[Christoph Feck]

cfeck added a comment.


  Does it still need KIconThemes framework elsewhere? If not, the dependency 
could be removed.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D11631

To: acrouthamel, rkflx, broulik
Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart