D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  The whole area of the Kirigami style back button is clickable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11726: Vastly simplify image wallpaper code

[David Edmundson]

davidedmundson added a comment.


  Thanks,  in future can you use arc if you're going to build off another patch.
  
  - Only push image item when it's finished (or failed) loading
  
  is already this code uploaded here, but wasn't in that branch. :/
  
  I don't understand the need for the wrapper you added, opacity is inherited 
from the parent item, so the background should still fade with it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11726

To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11722: If GL context creation fails fall back to the software renderer

[Martin Flöser]

graesslin added a comment.


  An env variable would not work for things like lock screen as the process 
starting the lock screen is started before Plasmashell.
  
  Given that I think persistent storage makes more sense. But a way to get back 
would be cool. Maybe we could create a test app to see whether OpenGL Scene 
Graph works? Something like mapping a transparent rectangle?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11722

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11722: If GL context creation fails fall back to the software renderer

[David Edmundson]

davidedmundson updated this revision to Diff 30771.
davidedmundson added a comment.


  Remove debug

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11722?vs=30643=30771

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11722

AFFECTED FILES
  shell/desktopview.cpp
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/shellmanager.cpp
  shell/shellmanager.h

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  Yea, the hover border isn't necessary. Maybe the back navigation should work 
like how it does with Kirigami.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer updated this revision to Diff 30744.
tillschafer added a comment.


  update documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11754?vs=30740=30744

BRANCH
  klipper_notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11754

AFFECTED FILES
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  I prefer the system settings as it currently is in 5.12, though the submenu 
heading could be a little bit darker.
  
  As for the changes made, I think the person that made the main sidebar header 
color different from the sub-sidebar header color did so intentionally, in line 
with the menu heirarchy. The horizontal line you added separating the search 
section from the sidebar options is cool though. The back navigation as it is 
is pretty clear, no need to turn it into a button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Nathaniel Graham]

ngraham added a comment.


  In D11757#235700 , @richardbowen 
wrote:
  
  > I prefer the system settings as it currently is in 5.12, though the submenu 
heading could be a little bit darker.
  >
  > As for the changes made, I think the person that made the main sidebar 
header color different from the sub-sidebar header color did so intentionally, 
in line with the menu heirarchy.
  
  
  That parson was @mart, which is why I added him as a reviewer. Previously, 
the light subcategory header text was visually consistent with the category 
headers on the main list--which were far too light due to a bug. I fixed that 
bug, and now the subcategory header text no longer matches with anything. It's 
also inconsistent with other column-based navigation headers, and is just too 
light in general. 30% opacity text is hard to read and doesn't make conceptual 
sense for a header.
  
  > The horizontal line you added separating the search section from the 
sidebar options is cool though.
  
  Thanks!
  
  > The back navigation as it is is pretty clear, no need to turn it into a 
button.
  
  It's not necessarily about clarity, it's about visual polish. Did you read 
the linked bug? It looks especially weird in HiDPI mode. If we're going to keep 
the present appearance, we should remove the button borders that show up on 
hover that are jammed up against the parent frame. But I kind of like bit big 
explicit button approach myself (obviously, or I wouldn't have proposed it! :-) 
)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: mart, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Polish the category headers in response to user feedback and for aesthetic 
reasons.
  
  BUG: 392340

TEST PLAN
  Category page: Made the separator line always visible
  [Image goes here]
  
  Subcategory page: Made the back button look like a button (the whole area 
still clickable anyway)
  [Image goes here]

REPOSITORY
  R124 System Settings

BRANCH
  polish-sidebar-header-appearance (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D11757

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, mart, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Nathaniel Graham]

ngraham added a comment.


  Also, the subcategory header is //already// bold when not in widescreen mode, 
so the fact that it's still light in widescreen mode is likely a simple bug.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[David Edmundson]

davidedmundson added a subscriber: fvogt.
davidedmundson added a comment.


  Wait for @fvogt and @kbroulik to confirm, but in general ok with me.
  Please update the text in the .h file. and make it clear that these are in 
addition to the ones in the spec.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11754

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer updated this revision to Diff 30746.
tillschafer added a comment.


  minor formatting

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11754?vs=30745=30746

BRANCH
  klipper_notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11754

AFFECTED FILES
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer updated this revision to Diff 30747.
tillschafer added a comment.


  minor formatting

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11754?vs=30746=30747

BRANCH
  klipper_notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11754

AFFECTED FILES
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Fabian Vogt]

fvogt added a comment.


  In D11739#235478 , @bcooksley 
wrote:
  
  > Please update the dependency metadata in kde-build-metadata.
  >  This has broken the CI builds for kde-cli-tools on all platforms.
  
  
  The issue here is that plasma-workspace requires kde-cli-tools currently, so 
adding this dependency would cause a build loop.
  
  I'm not sure why plasma-workspace depends on kde-cli-tools though, it's only 
a runtime dependency and not a buildtime dependency.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma, romangg
Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Fabian Vogt]

fvogt added a comment.


  > Given this is just runtime, I suggest we just cut it. If it causes issues 
then the tests which start failing can be remedied later.
  
  Ok, done.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma, romangg
Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer added a comment.


  I was thinking if I should also add "th" for a more complete table tag set, 
but decided to keep it minimal.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11754

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Ben Cooksley]

bcooksley added a comment.


  Given this is just runtime, I suggest we just cut it. If it causes issues 
then the tests which start failing can be remedied later.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma, romangg
Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Nathaniel Graham]

ngraham updated this revision to Diff 30753.
ngraham added a comment.


  Also improve the widescreen case

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11757?vs=30752=30753

BRANCH
  polish-sidebar-header-appearance (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D11757

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, mart, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer updated this revision to Diff 30745.
tillschafer added a comment.


  minor formatting

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11754?vs=30744=30745

BRANCH
  klipper_notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11754

AFFECTED FILES
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h

To: tillschafer, davidedmundson
Cc: fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Ben Cooksley]

bcooksley added a comment.


  Please update the dependency metadata in kde-build-metadata.
  This has broken the CI builds for kde-cli-tools on all platforms.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma, romangg
Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer added a comment.


  IMO, aligned text makes it much more readable at a quick glance. Thus, just 
from the pure appearance POV I would prefer the current solution.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11754

To: tillschafer, davidedmundson
Cc: broulik, fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Till Schäfer]

tillschafer created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tillschafer requested review of this revision.

REVISION SUMMARY
  Bug: 390375

REPOSITORY
  R120 Plasma Workspace

BRANCH
  klipper_notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11754

AFFECTED FILES
  dataengines/notifications/notificationsanitizer.cpp

To: tillschafer
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:896dd5516cfb: Use platform detection from KWorkSpace in 
KCMShell (authored by fvogt).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11739?vs=30731=30736

REVISION DETAIL
  https://phabricator.kde.org/D11739

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: fvogt, #plasma, romangg
Cc: romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11739: Use platform detection from KWorkSpace in KCMShell

[Ben Cooksley]

bcooksley added a comment.


  Thanks, I've initiated rebuilds of kde-cli-tools now.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma, romangg
Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11748: Assign notification area category

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense, but let's only commit if and when D11352 
 goes in, since it doesn't make sense 
without it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11748

To: wsdfhjxc, #plasma, ngraham
Cc: ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Nathaniel Graham]

ngraham added a comment.


  In D11757#235714 , @richardbowen 
wrote:
  
  > Yea, the hover border isn't necessary. Maybe the back navigation should 
work like how it does with Kirigami or similar.
  
  
  A Kirigami-style small back button sacrifices the usability advantages of 
having the whole area clickable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Slightly improve discoverability for changing the wallpaper

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d6bc5f35232a: Slightly improve discoverability for 
changing the wallpaper (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=30755=30766

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Improve discoverability for changing the wallpaper

[Nathaniel Graham]

ngraham updated this revision to Diff 30755.
ngraham added a comment.


  Give up on the unpopular text changes and only change the icon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=30327=30755

BRANCH
  arcpatch-D11253

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 22 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/22/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 19:32:35 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)13%
(4/30)13%
(4/30)19%
(488/2568)17%
(281/1659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/166)0%
(0/88)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/194)keditfiletype18%
(3/17)18%
(3/17)23%
(287/1256)21%
(150/728)keditfiletype.tests100%
(1/1)100%
(1/1)78%
(201/257)43%
(131/308)kioclient0%
(0/2)0%
(0/2)0%
(0/222)0%
(0/98)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/224)0%
(0/172)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/35)

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 19:32:35 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.filetypestest

D11754: fix: Klipper notifications visually broken since plasma 5.12

[Fabian Vogt]

fvogt added a subscriber: broulik.
fvogt added a comment.


  There was a discussion about this on IRC quite some time ago:
  
13:01 < d_ed> fvogt: kbroulik_: can I have your opinion on 
https://bugs.kde.org/show_bug.cgi?id=390375
13:01 < sKreamer> KDE bug 390375 in plasmashell (Notifications) "Klipper 
notifications visually broken since plasma 5.12" [normal,] 
https://bugs.kde.org/show_bug.cgi?id=390375
13:03 < kbroulik_> d_ed: lol "up", "current", "down"
13:03 < fvogt> Fixing klipper is IMO better
13:03 < kbroulik_> yes
13:03 < kbroulik_> but we also have no  tag anymore, right?
13:03 < d_ed> no, just "b"
13:04 < kbroulik_> so let's change it to
13:04 < kbroulik_> current: fobar
  
  and later
  
16:28 < kbroulik_> d_ed: did you do a klipper patch for Bug 390375 else I 
will
  
  So looks like this was just forgotten? Maybe @broulik remembers what the best 
option was.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11754

To: tillschafer, davidedmundson
Cc: broulik, fvogt, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 23 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Plasma plasma-pa kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 18:34:57 +
 Build duration:
5 min 5 sec and counting

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 18:34:56 +
 Build duration:
3 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 131.83 KB...][  9%] Built target kmimetypefinder5_autogenScanning dependencies of target ktraderclient5_autogen[ 10%] Automatic MOC for target ktraderclient5[ 10%] Built target ktraderclient5_autogenScanning dependencies of target kdemv5_autogen[ 12%] Automatic MOC for target kdemv5[ 12%] Built target doc-kcontrol5-filetypes-index-cache-bz2Scanning dependencies of target kdecp5_autogen[ 13%] Automatic MOC for target kdecp5Warn: AUTHOR sect.: no personblurb|contrib for Lauri Watts kdesuNote: AUTHOR sect.: see see http://docbook.sf.net/el/contrib   kdesuNote: AUTHOR sect.: see see http://docbook.sf.net/el/personblurb   kdesuNote: Writing kdesu.1[ 13%] Built target doc-kdesu-index-cache-bz2Scanning dependencies of target kde-open5_autogen[ 13%] Built target keditfiletype5_autogen[ 14%] Automatic MOC for target kde-open5Scanning dependencies of target kioclient5_autogen[ 15%] Automatic MOC for target kioclient5[ 15%] Built target kdemv5_autogen[ 15%] Built target kdecp5_autogenScanning dependencies of target ksvgtopng5_autogenScanning dependencies of target kstart5_autogen[ 17%] Automatic MOC for target ksvgtopng5[ 18%] Built target doc-kdesu-kdesu-1[ 18%] Automatic MOC for target kstart5[ 18%] Built target ksvgtopng5_autogenScanning dependencies of target kdesu_executable_autogenScanning dependencies of target kbroadcastnotification_autogen[ 19%] Automatic MOC for target kdesu_executable[ 20%] Automatic MOC for target kbroadcastnotification[ 20%] Built target kde-open5_autogen[ 20%] Built target kbroadcastnotification_autogen[ 20%] Built target kioclient5_autogenScanning dependencies of target filetypestest[ 21%] Built target kstart5_autogen[ 21%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/filetypestest.cpp.oScanning dependencies of target kmimetypefinder5[ 23%] Building CXX object kmimetypefinder/CMakeFiles/kmimetypefinder5.dir/kmimetypefinder.cpp.oScanning dependencies of target keditfiletype5Scanning dependencies of target kdeinit_kcmshell5[ 24%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/keditfiletype.cpp.o[ 24%] Built target kdesu_executable_autogen[ 25%] Building CXX object kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/main.cpp.o[ 26%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/filetypedetails.cpp.o[ 26%] Built target kcm_filetypes_autogen[ 28%] Building CXX object kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/kdeinit_kcmshell5_autogen/mocs_compilation.cpp.o[ 29%] Building CXX object kmimetypefinder/CMakeFiles/kmimetypefinder5.dir/kmimetypefinder5_autogen/mocs_compilation.cpp.o[ 30%] Linking CXX executable ../bin/kmimetypefinder5[ 30%] Built target kmimetypefinder5[ 31%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/__/mimetypedata.cpp.o[ 32%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/__/mimetypewriter.cpp.o[ 34%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/filetypestest_autogen/mocs_compilation.cpp.o[ 35%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/filegroupdetails.cpp.o[ 36%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/kservicelistwidget.cpp.o[ 37%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/typeslistitem.cpp.o/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9/kcmshell/main.cpp:180:32: error: use of undeclared identifier 'argc'; did you mean '_argc'?KWorkSpace::detectPlatform(argc, argv);   ^~~~   _argc/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9/kcmshell/main.cpp:177:42: note: '_argc' declared hereextern "C" Q_DECL_EXPORT int kdemain(int _argc, char *_argv[]) ^/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9/kcmshell/main.cpp:180:38: error: use of undeclared identifier 'argv'; did you mean '_argv'?KWorkSpace::detectPlatform(argc, argv); ^~~~ _argv/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9/kcmshell/main.cpp:177:55: note: '_argv' declared hereextern "C" Q_DECL_EXPORT int kdemain(int _argc, char *_argv[])  ^2 errors generated.gmake[2]: *** [kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/build.make:63: kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/main.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:380: kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 39%] Building CXX object 

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 21 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/21/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 18:34:56 +
 Build duration:
2 min 54 sec and counting
   CONSOLE OUTPUT
  [...truncated 160.19 KB...][ 12%] Automatic MOC for target kdecp5[ 13%] Automatic MOC for target kioclient5[ 13%] Built target kcm_filetypes_autogenScanning dependencies of target kdemv5_autogen[ 14%] Automatic MOC for target kdemv5[ 14%] Built target kdemv5_autogen[ 14%] Built target kioclient5_autogen[ 14%] Built target kdecp5_autogenScanning dependencies of target kde-open5_autogenScanning dependencies of target kstart5_autogen[ 14%] Built target doc-kcontrol5-filetypes-index-cache-bz2Scanning dependencies of target ksvgtopng5_autogen[ 15%] Automatic MOC for target kde-open5[ 15%] Built target doc-kdesu-index-cache-bz2[ 17%] Automatic MOC for target kstart5[ 18%] Automatic MOC for target ksvgtopng5Scanning dependencies of target kdesu_executable_autogenScanning dependencies of target kbroadcastnotification_autogen[ 19%] Automatic MOC for target kbroadcastnotification[ 20%] Automatic MOC for target kdesu_executable[ 20%] Built target ksvgtopng5_autogen[ 20%] Built target kbroadcastnotification_autogen[ 20%] Built target kde-open5_autogen[ 20%] Built target kstart5_autogen[ 20%] Built target kdesu_executable_autogenWarn: AUTHOR sect.: no personblurb|contrib for Lauri Watts kdesuNote: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/contr  kdesuNote: AUTHOR sect.: see http://www.docbook.org/tdg5/en/html/perso  kdesuNote: Writing kdesu.1Scanning dependencies of target kmimetypefinder5Scanning dependencies of target kdeinit_kcmshell5Scanning dependencies of target filetypestestScanning dependencies of target keditfiletype5Scanning dependencies of target kcm_filetypes[ 21%] Building CXX object kmimetypefinder/CMakeFiles/kmimetypefinder5.dir/kmimetypefinder.cpp.o[ 23%] Building CXX object kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/main.cpp.o[ 24%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/filetypestest.cpp.o[ 25%] Building CXX object keditfiletype/CMakeFiles/kcm_filetypes.dir/filetypesview.cpp.o[ 26%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/keditfiletype.cpp.o[ 26%] Built target doc-kdesu-kdesu-1[ 28%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/filetypedetails.cpp.o/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9/kcmshell/main.cpp: In function 'int kdemain(int, char**)':/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9/kcmshell/main.cpp:180:32: error: 'argc' was not declared in this scope KWorkSpace::detectPlatform(argc, argv);^~~~/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9/kcmshell/main.cpp:180:32: note: suggested alternative: '_argc' KWorkSpace::detectPlatform(argc, argv);^~~~_argc/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9/kcmshell/main.cpp:180:38: error: 'argv' was not declared in this scope KWorkSpace::detectPlatform(argc, argv);  ^~~~/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9/kcmshell/main.cpp:180:38: note: suggested alternative: '_argv' KWorkSpace::detectPlatform(argc, argv);  ^~~~  _argvmake[2]: *** [kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/build.make:63: kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/main.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:380: kcmshell/CMakeFiles/kdeinit_kcmshell5.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 29%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/__/mimetypedata.cpp.o[ 30%] Building CXX object kmimetypefinder/CMakeFiles/kmimetypefinder5.dir/kmimetypefinder5_autogen/mocs_compilation.cpp.o[ 31%] Linking CXX executable ../bin/kmimetypefinder5[ 32%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/filegroupdetails.cpp.o[ 34%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/kservicelistwidget.cpp.o[ 35%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/typeslistitem.cpp.o[ 35%] Built target kmimetypefinder5[ 36%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/mimetypedata.cpp.o[ 37%] Building CXX object keditfiletype/CMakeFiles/kcm_filetypes.dir/filegroupdetails.cpp.o[ 39%] Building CXX object keditfiletype/CMakeFiles/kcm_filetypes.dir/filetypedetails.cpp.o[ 40%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/mimetypewriter.cpp.o[ 41%] Building CXX object keditfiletype/tests/CMakeFiles/filetypestest.dir/__/mimetypewriter.cpp.o[ 42%] Building CXX object keditfiletype/CMakeFiles/keditfiletype5.dir/newtypedlg.cpp.o[ 43%] Building CXX object 

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/20/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 17:26:29 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 90.65 KB...]HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'QTC_BUILD = '/usr'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/20/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/'BUILD_DISPLAY_NAME= '#20'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma kde-cli-tools kf5-qt5 SUSEQt5.9-20'NODE_LABELS   = 'Docker Swarm-81674d9104f1 SUSEQt5.9'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.45.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Su: /home/jenkins/install-prefix/lib64/cmake/KF5Su/KF5SuConfig.cmake (found version "5.45.0") CMake Error at CMakeLists.txt:55 (find_package):  By not providing "FindLibKWorkspace.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file 

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 17:26:29 +
 Build duration:
2 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 66.02 KB...]USER  = 'jenkins'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'LANG  = 'en_US.UTF-8'MAIL  = '/var/mail/jenkins'BUILD_DISPLAY_NAME= '#15'HUDSON_URL= 'https://build.kde.org/'JENKINS_HOME  = '/home/production/data'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'XDG_CURRENT_DESKTOP   = 'KDE'JOB_NAME  = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9'SHELL = '/usr/local/bin/bash'BUILD_NUMBER  = '15'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/15/display/redirect?page=changes'JENKINS_NODE_COOKIE   = '6840c629-9c19-4772-b299-e1411d7bb681'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/'BLOCKSIZE = 'K'QT_SELECT = 'qt5'JOB_BASE_NAME = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/15/'BUILD_ID  = '15'JENKINS_URL   = 'https://build.kde.org/'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/15/display/redirect'LOGNAME   = 'jenkins'_ = '/usr/local/bin/java'OLDPWD= '/usr/home/jenkins'MM_CHARSET= 'UTF-8'HOME  = '/usr/home/jenkins'HUDSON_HOME   = '/home/production/data'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'WORKSPACE = '/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9'STAGE_NAME= 'Configuring Build'PWD   = '/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Su: /usr/home/jenkins/install-prefix/lib/cmake/KF5Su/KF5SuConfig.cmake (found version "5.45.0") CMake Error at CMakeLists.txt:55 (find_package):  By not providing "FindLibKWorkspace.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by 

D6313: Support Icon Scale from Icon naming specification 0.13

[Nathaniel Graham]

ngraham added a comment.


  TBH, I prefer the "Before" images. The only reason why the symbolic line-art 
versions exist is because the prettier icons look bad at small sizes on low-dpi 
screens. Especially for the document icons, IMHO the Before versions look 
vastly better.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7481: RFC: Batch window changes events on XCB

[Kai Uwe Broulik]

broulik added a comment.


  Monthly ping :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9984: WIP: Add bookmarks runner

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Not really worth it given it cannot work when the browser isn't running (main 
usecase for using it) and if we add a caching mechanism we're basically doing 
the same as the old bookmarks runner. Also, the runner is now (will shortly be) 
out of process so the Qt Sqlite stuff shouldn't have that big of a crashy 
impact anymore.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D9984

To: broulik, #plasma, #vdg, davidedmundson
Cc: sebas, abetts, mart, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, apol

D10836: Ensure _NET_CURRENT_DESKTOP is set on startup

[Kai Uwe Broulik]

broulik added a comment.


  Can this be landed?

REPOSITORY
  R108 KWin

BRANCH
  set-current-desktop-on-startup

REVISION DETAIL
  https://phabricator.kde.org/D10836

To: graesslin, #kwin, #plasma, romangg
Cc: broulik, plasma-devel, kwin, ragreen, iodelay, zzag, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11333: introduce candidateContainments

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> desktopview.cpp:55
> +if (items.length() > 0) {
> +qDebug()<<"double activity insertion attempted";
> +info->deleteLater();

Remove or cleanup

> desktopview.cpp:93
> +{
> +QHash roles;
> +roles[Id] = "id";

Use initializer list

> desktopview.h:41
> +Id = Qt::UserRole + 1,
> +Name,
> +Current,

use `Qt::DisplayRole` for that

> desktopview.h:45
> +};
> +Q_ENUM(ActivityRoles)
> +

You're not using those from QML (not needed for `model` magic property)

> shellcorona.cpp:1228
>  
> +QStringList existingActivities = m_activityController->activities();
> +for (const auto  : existingActivities) {

`const`

> shellcorona.cpp:1571
>  m_activityContainmentPlugins.insert(id, defaultContainmentPlugin());
> +for (const auto desktopView : m_desktopViewforId) {
> +desktopView->activitiesModel()->addActivity(id, 
> containmentGraphicsItemPreview(id, desktopView->containment()->screen()));

`qAsConst`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  I finally got to do some testing and it is not looking good for luminance 
formula `0.2126*r + 0.7152*g + 0.0722*b`.
  
  Screenshot with background color `#5500FF` (blueish, button background on 
picture), you can see that black text is readable on it, but it has luminance 
only 0.14 so in overlay it is replaced by black.
  F5769603: Screenshot_20180327_174715.png 

  
  So I would rather stay conservative, and used formula `max(r, g, b)`. I am 
still not sure whether the threshold should be `0.5` or a bit lower...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Pitel wrote in multiplexedservice.h:38
> I guess it would look more consistent if it was a job but somehow I fail to 
> see why any of this is job in the first place: all the actions are very 
> simple so offloading work to other thread is not needed and it hides 
> interface in ugly way... Do you have any insight why?

That's how dataengines worked 10 years ago. I'm not a huge fan either but I'd 
like to keep it consistent(ly bad)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10855: Emit clicked when double click expires

[Kai Uwe Broulik]

broulik added a comment.


  So, what shall we do with this?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

To: broulik, #plasma, graesslin, #vdg
Cc: mart, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10381: [ToolTipArea] Add "aboutToShow" signal

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e5dcc0b47f0e: [ToolTipArea] Add aboutToShow 
signal (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10381?vs=26747=30732#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10381?vs=26747=30732

REVISION DETAIL
  https://phabricator.kde.org/D10381

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/declarativeimports/core/tooltip.h

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ragreen, michaelh, ZrenBot, ngraham, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11722: If GL context creation fails fall back to the software renderer

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in main.cpp:186
> So you will permanently force software rendering even for a single hickup 
> (think of upgrading nvidia driver)?

Nvidia driver upgrade is how I ended up in my situation :D

Pernament global forcing is what I've gone for. Which is why it sort of already 
covers the lock screen case.
I could make it not save and do it all through just setting an env when it 
restarts.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11722

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  Committed as 
https://cgit.kde.org/plasma-framework.git/commit/?id=612494e2b2e9265d33ce148332d5f490b024a3bd

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg, davidedmundson
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, ragreen, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D11722: If GL context creation fails fall back to the software renderer

[Kai Uwe Broulik]

broulik added a comment.


  I like the direction but I would like
  
  - something that doesn't permanently lock out the user if something failed 
once, we either need a KCM like KWin has or a SNI ("we had to switch you back 
to software rendering" with a sad puppy face)
  - something more generic in KDeclarative like QtQuickRenderSettings so stuff 
like KRunner, lock screen and so on can do the same, especially the screen 
locker should fail gracefully

INLINE COMMENTS

> main.cpp:186
> +if (configGroup.readEntry("SceneGraphBackend") != 
> QLatin1String("software")) {
> +configGroup.writeEntry("SceneGraphBackend", "software", 
> KConfigBase::Global | KConfigBase::Persistent);
> +configGroup.sync();

So you will permanently force software rendering even for a single hickup 
(think of upgrading nvidia driver)?

> main.cpp:192
> +QMessageBox::critical(nullptr, i18n("Plasma Failed To Start"),
> +  i18n("Plasma is unable to start as it could not 
> correctly use OpenGL 2 or software fallback\nPlease check that your graphic 
> drivers are set up correctly."));
> +}

Add period after fallback

> shellcorona.h:117
> +Q_SIGNALS:
> +void glInitialisationFailed();
> +

initiali**z**ation

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11722

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11253: Improve discoverability for changing the wallpaper

[Marco Martin]

mart added a comment.


  I would prefer the new icon, but still "Configure Desktop" for brevity

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11726: Vastly simplify image wallpaper code

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Can you please incorporate the changes I did in 
34454b17f3c54c701418c0e921ca1bea155b4539 
, 
most notably `Qt.callLater` instead of a `Timer` and putting the `Rectangle` 
//outside// rather than behind (`z`) the `Image` so it fades nicely together 
with the image.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11726

To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11739: Use platform detection from KWorkSpace in KCMShell

[Fabian Vogt]

fvogt updated this revision to Diff 30731.
fvogt added a comment.


  Do the same as krunner, unset the variable if platform got detected.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11739?vs=30697=30731

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11739

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: fvogt, #plasma
Cc: romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11744: Revert "Revert "Get rid of KDELibs4Support""

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11744

To: volkov, davidedmundson, broulik, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11726: Vastly simplify image wallpaper code

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> main.qml:62
>  }
> +loadImage();
>  }

are you sure none of the *changed signals will be triggered i nthe beginning? 
this could call loadImage twice

> main.qml:80
> +}
> +onFillModeChanged: loadTimer.start();
> +onModelImageChanged: loadTimer.start();

the result will be the same with a 0 interval, but would be more 
correct-correct using loadTimer.restart() instead?

> main.qml:146
> +}
> +replaceExit: Transition {
> +OpacityAnimator {

if the new image is fading in, i don't think the old image should be fading 
out, as at some point of the anmiation both items would be semitransparent, in 
that case the black on the back of everything would be creeping in for a while, 
so if you transition between 2 light wallpaper, you would see a transition to a 
darker result, then going lighter again

replaceExit: Transition {

  PauseAnimation {
  duration: wallpaper.configuration.TransitionAnimationDuration
  }
  }

seems to have a more pleasing effect

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11726

To: davidedmundson, #plasma
Cc: mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 30728.
Pitel added a comment.


  - Remove QtQuick.Controls import (was needed only by Checkbox)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=30555=30728

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11747: Fix warnings on Qt 5.11

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ca8468a2fac8: Fix warnings on Qt 5.11 (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11747?vs=30719=30727

REVISION DETAIL
  https://phabricator.kde.org/D11747

AFFECTED FILES
  src/controls/GlobalDrawer.qml

To: apol, #kirigami, davidedmundson
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11739: Use platform detection from KWorkSpace in KCMShell

[Roman Gilg]

romangg added a comment.


  Unset the variable again after app call just to make sure?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D11739

To: fvogt, #plasma
Cc: romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in libinput_settings.h:27
> this use of templates doesn't match the implementation

Do you mean in the cpp file? There are two template specializations defined.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: davidedmundson, hein, mart, abetts, ngraham, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11750: Assign notification area category

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  This is a supplement for D11352 .

REPOSITORY
  R114 Plasma Addons

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11750

AFFECTED FILES
  applets/keyboardindicator/metadata.desktop

To: wsdfhjxc, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11749: Assign notification area category

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  This is a supplement for D11352 .

REPOSITORY
  R119 Plasma Desktop

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11749

AFFECTED FILES
  kcms/touchpad/src/applet/qml/metadata.desktop

To: wsdfhjxc, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11748: Assign notification area category

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  This is a supplement for D11352 .

REPOSITORY
  R134 Discover Software Store

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11748

AFFECTED FILES
  notifier/plasmoid/metadata.desktop

To: wsdfhjxc, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11747: Fix warnings on Qt 5.11

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Layouts don't like it when its items anchor to them. Instead use Layout
  positioning properties.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11747

AFFECTED FILES
  src/controls/GlobalDrawer.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11746: Assign notification area category

[Wojciech Stachurski]

wsdfhjxc created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  This is a supplement for D11352 .

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11746

AFFECTED FILES
  applet/metadata.desktop

To: wsdfhjxc
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11744: Revert "Revert "Get rid of KDELibs4Support""

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> volkov wrote in CMakeLists.txt:26
> What do you mean? It's revert revert...

Urgh, I have trouble reading words. That's clear. sorry

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11744

To: volkov, davidedmundson, broulik, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Plasma 5.12.4

[Jonathan Riddell]

Plasma 5.12.4 sources are now available for packagers

https://www.kde.org/announcements/plasma-5.12.4.php

D11744: Revert "Revert "Get rid of KDELibs4Support""

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:26
> I'm confused, the commit description doesn't match the diff

What do you mean? It's revert revert...

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11744

To: volkov, davidedmundson, broulik, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11744: Revert "Revert "Get rid of KDELibs4Support""

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:26
>  find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus 
> X11Extras)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth 
> IdleTime Config DBusAddons Solid I18n GlobalAccel KIO NotifyConfig 
> KDELibs4Support Wayland)
> +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth 
> IdleTime Config DBusAddons Solid I18n GlobalAccel KIO NotifyConfig Wayland 
> DocTools Crash Notifications)
>  find_package(KF5Screen CONFIG REQUIRED)

I'm confused, the commit description doesn't match the diff

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11744

To: volkov, davidedmundson, broulik, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 504 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/504/
 Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 12:32:17 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 1.22 MB...][ 86%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit.dir/main.cpp.o[ 87%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit.dir/klauncher_iface.cpp.o[ 87%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit.dir/kdeinit_kcminit_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX shared library ../../bin/libkdeinit5_kcminit.so[ 87%] Built target kdeinit_kcminitScanning dependencies of target kdeinit_kcminit_startup[ 87%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit_startup.dir/main.cpp.o[ 87%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit_startup.dir/klauncher_iface.cpp.o[ 87%] Building CXX object startkde/kcminit/CMakeFiles/kdeinit_kcminit_startup.dir/kdeinit_kcminit_startup_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX shared library ../../bin/libkdeinit5_kcminit_startup.so[ 87%] Built target kdeinit_kcminit_startup[ 87%] Generating screensaver_interface.cpp, screensaver_interface.h[ 87%] Generating krunner_interface.cpp, krunner_interface.h[ 87%] Generating screensaver_interface.moc[ 87%] Generating krunner_interface.mocScanning dependencies of target plasma_containmentactions_contextmenu[ 87%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/menu.cpp.o[ 87%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/krunner_interface.cpp.o[ 87%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/screensaver_interface.cpp.o[ 87%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/plasma_containmentactions_contextmenu_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX shared module ../../bin/plasma_containmentactions_contextmenu.so[ 87%] Built target plasma_containmentactions_contextmenuScanning dependencies of target plasma_containmentactions_switchactivity[ 87%] Building CXX object containmentactions/switchactivity/CMakeFiles/plasma_containmentactions_switchactivity.dir/switch.cpp.o[ 87%] Building CXX object containmentactions/switchactivity/CMakeFiles/plasma_containmentactions_switchactivity.dir/plasma_containmentactions_switchactivity_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX shared module ../../bin/plasma_containmentactions_switchactivity.so[ 87%] Built target plasma_containmentactions_switchactivity[ 88%] Generating screensaver_interface.cpp, screensaver_interface.h[ 88%] Generating screensaver_interface.mocScanning dependencies of target krunner_sessions[ 88%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o[ 88%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/screensaver_interface.cpp.o[ 88%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/krunner_sessions_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX shared module ../../bin/krunner_sessions.so[ 88%] Built target krunner_sessions[ 88%] Generating krunner_interface.cpp, krunner_interface.h[ 88%] Generating krunner_interface.mocScanning dependencies of target plasma_engine_powermanagement[ 89%] Building CXX object dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp: In member function 'virtual bool PowermanagementEngine::sourceRequestEvent(const QString&)':/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:211:41: warning: 'Solid::PowerManagement::Notifier* Solid::PowerManagement::notifier()' is deprecated [-Wdeprecated-declarations] connect(Solid::PowerManagement::notifier(), ::PowerManagement::Notifier::appShouldConserveResourcesChanged, ^~~~In file included from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:29:0:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:154:45: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT Notifier *notifier(); ^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:211:50: warning: 'Solid::PowerManagement::Notifier* Solid::PowerManagement::notifier()' is deprecated [-Wdeprecated-declarations] connect(Solid::PowerManagement::notifier(), ::PowerManagement::Notifier::appShouldConserveResourcesChanged, 

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 212 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/212/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 12:32:17 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 1.19 MB...]setResult(Solid::PowerManagement::stopSuppressingSleep(parameters().value(QStringLiteral("cookie")).toInt()));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:103:40: note: 'stopSuppressingSleep' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingSleep(int cookie);   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:89:43: warning: 'beginSuppressingScreenPowerManagement' is deprecated [-Wdeprecated-declarations]setResult(Solid::PowerManagement::beginSuppressingScreenPowerManagement(parameters().value(QStringLiteral("reason")).toString()));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:117:39: note: 'beginSuppressingScreenPowerManagement' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingScreenPowerManagement(const QString  = QString());  ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:92:43: warning: 'stopSuppressingScreenPowerManagement' is deprecated [-Wdeprecated-declarations]setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt()));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:129:40: note: 'stopSuppressingScreenPowerManagement' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingScreenPowerManagement(int cookie);   ^Scanning dependencies of target plasma_engine_statusnotifieritem[ 82%] Generating jobviewadaptor.cpp, jobviewadaptor.h[ 82%] Built target ion_wettercom_autogen[ 82%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o[ 82%] Generating jobview_interface.cpp, jobview_interface.h[ 82%] Generating jobviewserveradaptor.cpp, jobviewserveradaptor.hScanning dependencies of target testPlatformDetection10 warnings generated.[ 82%] Generating jobviewserver_interface.cpp, jobviewserver_interface.h[ 82%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection.cpp.o[ 82%] Generating appmenuadaptor.cpp, appmenuadaptor.h[ 82%] Generating kuiserveradaptor.cpp, kuiserveradaptor.h[ 82%] Built target appmenuplugin[ 82%] Generating menuimporteradaptor.cpp, menuimporteradaptor.h[ 82%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection_autogen/mocs_compilation.cpp.o[ 82%] Generating appmenuadaptor.moc[ 82%] Generating menuimporteradaptor.moc[ 82%] Generating jobviewadaptor.moc[ 82%] Generating jobview_interface.moc[ 82%] Generating jobviewserveradaptor.moc[ 82%] Generating jobviewserver_interface.moc[ 83%] Generating kuiserveradaptor.mocScanning dependencies of target appmenugmake[1]: *** [CMakeFiles/Makefile2:10456: dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 83%] Building CXX object appmenu/CMakeFiles/appmenu.dir/appmenu.cpp.o[ 83%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemsource.cpp.oScanning dependencies of target kdeinit_kuiserver5Scanning dependencies of target taskmanagerplugin[ 83%] Building CXX object kuiserver/CMakeFiles/kdeinit_kuiserver5.dir/main.cpp.o[ 83%] Building CXX object libtaskmanager/declarative/CMakeFiles/taskmanagerplugin.dir/taskmanagerplugin.cpp.o[ 83%] Linking CXX executable ../../bin/testPlatformDetection[ 83%] Building CXX object libtaskmanager/declarative/CMakeFiles/taskmanagerplugin.dir/taskmanagerplugin_autogen/mocs_compilation.cpp.o[ 83%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemservice.cpp.o[ 83%] Built target testPlatformDetection[ 83%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemjob.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/statusnotifieritem/statusnotifieritemsource.cpp:394:25: warning: cast from 'const char *' to 'uint *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5d65fcbf8bf9: [notifications applet] Fix two qml warnings 
about assigning [undefined] (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11743?vs=30711=30712

REVISION DETAIL
  https://phabricator.kde.org/D11743

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/Notifications.qml

To: kossebau, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 30711.
kossebau added a comment.


  fix hasConfigureAction at the right place by proper init

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11743?vs=30707=30711

BRANCH
  fixnotificationruntimewarnigs

REVISION DETAIL
  https://phabricator.kde.org/D11743

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/Notifications.qml

To: kossebau, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> mart wrote in enums.h:39
> please call this in a more generic way, like MessageSeverity, so can be used 
> for other kinds of messages if needed, like passivenotification and inline 
> dialogs

Hang on, I focused on disagreeing with Severity, but I understand now your goal 
was to drop Inline to make it more generically useful, sorry. How about 
MessageType?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  A screenshot including the new dialog-positive icon made by the VDG:
  
  F5769344: inlinemessages7.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30710.
hein marked an inline comment as done.
hein added a comment.


  - Use the new dialog-positive icon (thanks VDG!) for 
Kirigami.InlineMessageType.Positive.
  - Flesh out the Gallery example page info text and give it a nicer heading.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30692=30710

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein marked 5 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> mart wrote in InlineMessage.qml:91
> this would make opacity of contentitem 1.0 even when animationg to 0?

No, because of `enabled: !root.visible`. implicitHeight is bound to an 
expression that's recomputed when visible has changed, and returns 0 when 
visible is false. That means by the time the Behavior would kick off in 
response to the implicitHeight property changing, it's already disabled. In 
other words, under the only condition when implicitHeights goes to 0, this 
Behavior is known to be disabled and the ScriptAction will not run.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in NotificationDelegate.qml:122
> Can you do that in the place where it sets `hasConfigureAction`, I find it 
> odd that this one needs an explicit check but the other one doesn't

Actually I have not found out where model is coming from, and why it sometimes 
(?) can be undefined. Who could be the local expert to shed light onto thigs?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11743

To: kossebau, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> NotificationDelegate.qml:122
>  hasDefaultAction: model.hasDefaultAction
> -hasConfigureAction: model.hasConfigureAction
> +hasConfigureAction: model.hasConfigureAction || false
>  urls: {

Can you do that in the place where it sets `hasConfigureAction`, I find it odd 
that this one needs an explicit check but the other one doesn't

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11743

To: kossebau, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4939: Get rid of KDELibs4Support

[Alexander Volkov]

volkov added a comment.


  D11744 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4939

To: denisshienkov, #plasma, davidedmundson, volkov, afiestas, broulik, graesslin
Cc: graesslin, davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11744: Revert "Revert "Get rid of KDELibs4Support""

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  This reverts commit 55603160e9b894270a34e7d01e0aef5bbbfe8025 
.
  
  "Get rid of KDELibs4Support" was reverted because Can* methods
  of PowerManagement class returned incorrect values due to async
  DBus calls. Use blocking DBus calls now.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11744

AFFECTED FILES
  CMakeLists.txt
  daemon/CMakeLists.txt
  daemon/actions/bundled/CMakeLists.txt
  daemon/actions/bundled/handlebuttoneventsconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/org.freedesktop.PowerManagement.Inhibit.xml
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilpowermanagement.cpp
  daemon/powerdevilpowermanagement.h
  kcmodule/activities/CMakeLists.txt
  kcmodule/activities/activitywidget.cpp
  kcmodule/global/CMakeLists.txt
  kcmodule/global/GeneralPage.cpp
  kcmodule/profiles/CMakeLists.txt
  kcmodule/profiles/EditPage.cpp

To: volkov
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:cdaa40c64413: experimental support for auto mnemonics 
(authored by mart).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8827?vs=28954=30708

REVISION DETAIL
  https://phabricator.kde.org/D8827

AFFECTED FILES
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/ToolButton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: mart, #plasma
Cc: apol, hein, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Fixes
  [...]/NotificationDelegate.qml:51:26: Unable to assign [undefined] to int
  by using the correct name of the enum value.
  [...]/NotificationDelegate.qml:122:33: Unable to assign [undefined] to bool
  by catching with an alternative false if used property does not exist.

TEST PLAN
  No more warnings e.g. on notifications for new emails from akonadi.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixnotificationruntimewarnigs

REVISION DETAIL
  https://phabricator.kde.org/D11743

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> hein wrote in InlineMessage.qml:100
> Can you give me a code example of how to use this in the template code?

as Action.qml is doing:
this is how Action uses it:

property ActionIconGroup icon: ActionIconGroup {

  id: iconGroup
  }

ActionIconGroup can be renamed/moved btw, but is not important

a retrocompatibility alias iconSource: iconGroup.source could be possible, 
tough for new classes not needed, if the source of icongroup becomes a var 
instead of a string, passing qicons should stay possible.

the usage would then be:

InlineMessage {

  icon.name: "konsole"

}

again, i'm not sold on this, but if we can make it coherent qith qqc2 it 
becomes a bit easier for new developers

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein marked 4 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> mart wrote in InlineMessagesGallery.qml:61
> add some usage explanation here, like that should be added in the main layout 
> of the ui you want to put it in, that is not visible by default, needing an 
> explicit visible=true
> 
> a two rows synopsis of the ig would also be good here tough we have to wait 
> for that i guess

Will do.

> mart wrote in InlineMessage.qml:79
> what is the use case, tooltips?

e.g. setting a status bar/status tooltip text with the URL, yup

> mart wrote in InlineMessage.qml:100
> even if at the beginning not 100% supported, i would prefer it making 
> api-compatible with qqc2 (even if i don't like that api that much)
> there is a class in controls/private called ActionIconGroup which exports the 
> ptoperties that qqc2 uses for icons, so icon.name,icon.source, icon.color
> not all of those need to be supported (i prefer to ignore icon.size usially) 
> but at least name,source and color should

Can you give me a code example of how to use this in the template code?

> mart wrote in InlineMessage.qml:127
> what is the use case for exposing this property in the public api?

Consistency with OverlayDrawer.animating - it generally seems like a good idea 
to be able to know when something is fully visible/ready.

> mart wrote in enums.h:39
> please call this in a more generic way, like MessageSeverity, so can be used 
> for other kinds of messages if needed, like passivenotification and inline 
> dialogs

"Severity" is actually less generic than "Type" and semantically wrong. While 
Warning->Error perhaps are a range, "Positive" isn't "more severe" than 
"Information". This is semantically an unordered enumeration (less specific) 
while "Severity" implies a scale (more specific).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> InlineMessagesGallery.qml:61
> +wrapMode: Text.WordWrap
> +text: "Inline messages allow you to show various types of 
> messages without an overlay dialog."
> +}

add some usage explanation here, like that should be added in the main layout 
of the ui you want to put it in, that is not visible by default, needing an 
explicit visible=true

a two rows synopsis of the ig would also be good here tough we have to wait for 
that i guess

> InlineMessage.qml:91
> +// contentLayout) don't work.
> +ScriptAction { script: contentItem.opacity = 1.0 }
> +}

this would make opacity of contentitem 1.0 even when animationg to 0?

> InlineMessage.qml:182
> +id: icon
> +
> +width: Kirigami.Units.iconSizes.smallMedium

also a color: root.icon.color (no checks needed)

> InlineMessage.qml:192
> +source: {
> +if (root.icon) {
> +return root.icon;

with qqc2 api, here would return either root.icon.source or if not set 
root.icon.name

> InlineMessage.qml:276
> +
> +Repeater {
> +model: root.actions

i kindof feel we should make a private component out of that, for overflowable 
toolbars..  (or maybe even not private) but this is for the future, this is 
perfect for now

> hein wrote in InlineMessage.qml:387
> I'm not sure it's a problem it will animate when you unhide with a parent.

if you need to know if an item is visible by itself, not caring of parents 
visibility, use opacity instead, at least that's what qt docs say.

> InlineMessage.qml:79
> + */
> +signal linkHovered(string link)
> +

what is the use case, tooltips?

> InlineMessage.qml:100
> + */
> +property string icon
> +

even if at the beginning not 100% supported, i would prefer it making 
api-compatible with qqc2 (even if i don't like that api that much)
there is a class in controls/private called ActionIconGroup which exports the 
ptoperties that qqc2 uses for icons, so icon.name,icon.source, icon.color
not all of those need to be supported (i prefer to ignore icon.size usially) 
but at least name,source and color should

> InlineMessage.qml:127
> + */
> +readonly property bool animating: 
> contentItem.hasOwnProperty("animating") && contentItem.animating
> +}

what is the use case for exposing this property in the public api?

> enums.h:39
>  
> +class InlineMessageType : public QObject
> +{

please call this in a more generic way, like MessageSeverity, so can be used 
for other kinds of messages if needed, like passivenotification and inline 
dialogs

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

Minutes for meeting week 12 and 13

[Bhushan Shah]

Sorry for delay but combined notes on week 12 and 13

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
2018-03-19 16:33:26 <@bshah>kbroulik: romangg: notmart Sho_ me ?
2018-03-19 16:33:33   oki
2018-03-19 16:33:38   * Did extensive profiling on Dolphin 
startup and file dialog opening times, managed to get it from 
click--wait--hickup--there to click--there, so fast that I can now see it 
loading the custom folder icons and querying devices for a frame or two.
2018-03-19 16:33:41i'm here
2018-03-19 16:33:43   ** It now has a KFilePlacesModel 
singleton; there used to be three or four places where it would create one. 
That model queries Solid and is quite heavy to create
2018-03-19 16:33:48   ** Solid's UDev backend does more 
specific queries now. Instead of getting all devices (including your CPUs and 
RAM banks), creating a Qt wrapper class for it and then discarding 
non-interesting ones, it sets filters on UDev enumerate instead. Also saves 
70ms plasmashell startup for me (hotplug engine)
2018-03-19 16:33:52   ** KFilePlacesView queries 
KDiskFreeSpaceInfo (which queries all mount points) on-demand now. Used to 
query it for every single favorite in every paint pass (~350 times on startup). 
It still does it in paint() which is bad but at least now does it only on hover 
for mounted devices.
2018-03-19 16:33:55   ** Baloo FileIndexerConfig now queries 
external media (which are blacklisted by default) only when actually asked for. 
Most of the time it is just used to check whether Baloo itself is enabled.
2018-03-19 16:33:58   ** Avoid needless pixmap resizing in 
view engine (on high dpi), please have a look at D11319
2018-03-19 16:33:58   Diff 11319 "[KStandardItemListWidget] 
Avoid needless image resizing" [Needs Review] https://phabricator.kde.org/D11319
2018-03-19 16:34:13   * Konsole by default now shows its tab 
bar only on demand, together with new colored scroll bars makes for a cleaner 
default look
2018-03-19 16:34:13   * Fixed applets being unable to 
completely hide themselves from system tray when set to HiddenStatus (Passive 
moves to popup, Hidden completely hides it)
2018-03-19 16:34:13   * Plasma Dialog now allows to set 
outputOnly also for NoBackground dialogs (I didn't see a reason why it wouldn't)
2018-03-19 16:34:13   * Plasma ToolTip now checks the dirty 
file name in KDirWatch handler, used to needlessly reload plasmarc 100 times on 
startup
2018-03-19 16:34:13   * Media Controller now indicates 
playback progress even when media isn't seekable: 
https://phabricator.kde.org/file/data/jpun2cvsukg4fwxxrpqe/PHID-FILE-s2e7gxdrplo3lbb2lwpk/Screenshot_20180315_162240.png
2018-03-19 16:34:27   * Please check out the following open 
reviews:
2018-03-19 16:34:28   ** Bugfix for AppMenu applet getting 
confused and crashing when menu layout drastically changes (triggered by 
LibreOffice): D11350
2018-03-19 16:34:28   ** Fix PowerDevil inhibitions for e.g. 
Chrome: D11182
2018-03-19 16:34:28   ** Drop KLineEdit own clear button 
implementation and forward that to QLineEdit, saves creating a QProxyStyle 
(which creates an entire QStyle instance; Breeze widget style is quite heavy): 
D9221
2018-03-19 16:34:28   ** Support high dpi icons in 
KIconLoader (instead of just loading a 32px icon that may be hard to tell it 
can now load a 16@2x if provided by the theme): D6313
2018-03-19 16:34:29   Diff 11350 "[AppMenuModel] Don't store 
actions ourselves" [Needs Review] https://phabricator.kde.org/D11350
2018-03-19 16:34:29   Diff 11182 
"org.freedesktop.PowerManagement.Inhibit should only prevent suspend" [Needs 
Review] https://phabricator.kde.org/D11182
2018-03-19 16:34:30   Diff 9221 "[KLineEdit] Use Qt's 
built-in clear button functionality" [Needs Review] 
https://phabricator.kde.org/D9221
2018-03-19 16:34:30   Diff 6313 "Support Icon Scale from Icon 
naming specification 0.13" [Needs Review] https://phabricator.kde.org/D6313
2018-03-19 16:35:30   emit 
KMeetingRunner::nextSpeakerRequested();
2018-03-19 16:35:39 <@bshah>romangg: your turn
2018-03-19 16:36:02* Did reviews on D10750 and D1230 - we 
need to get these reviews done!
2018-03-19 16:36:02   Diff 10750 "wayland: Add support for 
zwp_linux_dmabuf" [Needs Review] https://phabricator.kde.org/D10750
2018-03-19 16:36:02   Diff 1230 "GBM remote access support 
for KWin" [Accepted] https://phabricator.kde.org/D1230
2018-03-19 16:36:03* Gave feedback to the new (more Breeze 
like) design of hig.kde.org: D11395
2018-03-19 16:36:03   Diff 11395 "Breezify hig.kde.org" 
[Needs Review] https://phabricator.kde.org/D11395
2018-03-19 16:36:05* Worked on bug 

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 503 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/503/
 Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 27 Mar 2018 07:15:17 +
 Build duration:
33 min and counting
   CONSOLE OUTPUT
  [...truncated 1.21 MB...][ 85%] Built target servicerunnertest_autogen[ 85%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/krunner_interface.cpp.o[ 85%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/screensaver_interface.cpp.o[ 85%] Building CXX object containmentactions/contextmenu/CMakeFiles/plasma_containmentactions_contextmenu.dir/plasma_containmentactions_contextmenu_autogen/mocs_compilation.cpp.o[ 86%] Generating screensaver_interface.cpp, screensaver_interface.h[ 86%] Generating screensaver_interface.mocScanning dependencies of target krunner_sessions[ 86%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o[ 86%] Linking CXX shared module ../../bin/plasma_containmentactions_contextmenu.so[ 86%] Built target plasma_containmentactions_contextmenuScanning dependencies of target krunner_kill_autogen[ 86%] Automatic MOC for target krunner_kill[ 86%] Built target krunner_kill_autogen[ 86%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/screensaver_interface.cpp.o[ 86%] Building CXX object runners/sessions/CMakeFiles/krunner_sessions.dir/krunner_sessions_autogen/mocs_compilation.cpp.oScanning dependencies of target appmenuplugin[ 86%] Building CXX object applets/appmenu/plugin/CMakeFiles/appmenuplugin.dir/appmenumodel.cpp.o[ 86%] Linking CXX shared module ../../bin/krunner_sessions.so[ 86%] Built target krunner_sessionsScanning dependencies of target plasma_engine_geolocation_autogen[ 86%] Generating plasma-dataengine-geolocation.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated  "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/build/dataengines/geolocation/plasma-dataengine-geolocation.json" [ 86%] Automatic MOC for target plasma_engine_geolocation[ 86%] Built target plasma_engine_geolocation_autogenScanning dependencies of target plasma-geolocation-ip_autogen[ 86%] Automatic MOC for target plasma-geolocation-ip[ 86%] Built target plasma-geolocation-ip_autogen[ 86%] Generating krunner_interface.cpp, krunner_interface.h[ 86%] Generating krunner_interface.mocScanning dependencies of target plasma_engine_powermanagement[ 87%] Building CXX object dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp: In member function 'virtual bool PowermanagementEngine::sourceRequestEvent(const QString&)':/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:211:41: warning: 'Solid::PowerManagement::Notifier* Solid::PowerManagement::notifier()' is deprecated [-Wdeprecated-declarations] connect(Solid::PowerManagement::notifier(), ::PowerManagement::Notifier::appShouldConserveResourcesChanged, ^~~~In file included from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:29:0:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:154:45: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT Notifier *notifier(); ^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:211:50: warning: 'Solid::PowerManagement::Notifier* Solid::PowerManagement::notifier()' is deprecated [-Wdeprecated-declarations] connect(Solid::PowerManagement::notifier(), ::PowerManagement::Notifier::appShouldConserveResourcesChanged,  ^In file included from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:29:0:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:154:45: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT Notifier *notifier(); ^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementengine.cpp:213:51: warning: 'bool Solid::PowerManagement::appShouldConserveResources()' is deprecated [-Wdeprecated-declarations] updateAcPlugState(Solid::PowerManagement::appShouldConserveResources());   ^~In file included 

D11739: Use platform detection from KWorkSpace in KCMShell

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  In a Wayland session, KCMs need to use the wayland platform plugin.

TEST PLAN
  kcmshell5 kscreen now works properly.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11739

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: fvogt, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 211 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/211/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 27 Mar 2018 07:15:17 +
 Build duration:
9 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.17 MB...]Found property definition "X-KDE-ParentApp" with type "QString"Generated  "/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/build/dataengines/weather/plasma-dataengine-weather.json" [ 86%] Automatic MOC for target plasma_engine_weather[ 86%] Linking CXX shared library ../../../bin/libappmenuplugin.so[ 86%] Built target plasma_engine_weather_autogenScanning dependencies of target ion_bbcukmet_autogen[ 86%] Generating ion-bbcukmet.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated  "/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/build/dataengines/weather/ions/bbcukmet/ion-bbcukmet.json" [ 86%] Automatic MOC for target ion_bbcukmet/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:61:33: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations]Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: 'requestSleep' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:62:43: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations]setResult(Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::SuspendState));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: 'supportedSleepStates' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:65:33: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations]Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: 'requestSleep' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:66:43: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations]setResult(Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HibernateState));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: 'supportedSleepStates' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:69:33: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations]Solid::PowerManagement::requestSleep(Solid::PowerManagement::HybridSuspendState, nullptr, nullptr);^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: 'requestSleep' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);   ^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/dataengines/powermanagement/powermanagementjob.cpp:70:43: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations]setResult(Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HybridSuspendState));  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: 'supportedSleepStates' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();   

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:032fbb83613b: [Battery Monitor] Support Gaming 
Input Battery type (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11571?vs=30197=30694

REVISION DETAIL
  https://phabricator.kde.org/D11571

AFFECTED FILES
  components/workspace/BatteryIcon.qml
  dataengines/powermanagement/powermanagementengine.cpp
  dataengines/soliddevice/soliddeviceengine.cpp

To: broulik, #plasma, dollinger, lbeltrame, davidedmundson
Cc: ngraham, anthonyfieroni, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  I've filed a bug against the Breeze icon theme to sort out the icon issues 
this new component poses: https://bugs.kde.org/show_bug.cgi?id=392391
  
  This should not affect this review, though.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in InlineMessage.qml:225-226
> I don't think either of these two lines will work as you intend as you've not 
> constrained the label height anywhere

For some reason this did "work" in the gallery in the sense that the visual 
result of the QML is that it does what I wanted/expected it to do, but you're 
right this doesn't really make sense and I should just set the Layout.alignment 
for the thing like I do for the icon. It doesn't chance the outcome in the 
gallery, but I guess it would if someone sets an explicit height for an InlMsg. 
Correcting.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30692.
hein marked an inline comment as done.
hein added a comment.


  Fix wrong approach to aligning the text as pointed out by David.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30603=30692

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein