D12086: [OSD] Enforce plain text

[Kai Uwe Broulik]

broulik added a comment.


  > where do we put third party data in an OSDItem
  
  
  
  - `mediaPlayerVolumeChanged` takes `playerName` which is shown when muted
  - `kbdLayoutChanged` takes `layoutName`
  - `virtualDesktopChanged` takes `currentVirtualDesktopName`
  
  and most importantly
  
  - `showText` takes `text`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12086

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Nathaniel Graham]

ngraham added a comment.


  Also those labels are not very descriptive; are there better strings 
available? Looking at the screenshots, I have no idea what most of those 
permissions actually do. A regular user would be even more confused.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Nathaniel Graham]

ngraham added a comment.


  +1 for the feature, but could we use checkboxes instead of toggles? I'm not 
real thrilled with the ones in those screenshots. It's not at all clear what's 
on and what's off.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Aleix Pol Gonzalez]

apol added a comment.


  F5803518: Screenshot_20180411_024622.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Aleix Pol Gonzalez]

apol added a comment.


  F5803515: Screenshot_20180411_024501.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12103

AFFECTED FILES
  discover/assets.qrc
  discover/autotests/updateandinstall.qml
  discover/qml/ApplicationPage.qml
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/SnapBackend/CMakeLists.txt
  libdiscover/backends/SnapBackend/SnapResource.cpp
  libdiscover/backends/SnapBackend/SnapResource.h

To: apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag updated this revision to Diff 31846.
zzag added a comment.


  Because this patch hasn't been landed yet, I would like to post here
  my recent work on optimizing the box shadow helper...
  
  Summary of changes:
  
  - re-write naive blur helper
  - modify only alpha channel in blur helpers
  - reserve memory for kernel in computeGaussianKernel
  
  See, benchmark results 
https://docs.google.com/spreadsheets/d/1ykAUyspF6BgCFb_U7-muLDEYzrOTNiT5CvFgqCU2xTs/edit?usp=sharing

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=31808=31846

BRANCH
  refine-shadows-libbreezecommon

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added subscribers: ngraham, abetts.
hein added a comment.


  Note: The screenshots don't look like the mockup in T7247 
 because that's outdated. The VDG channel 
had a long discussion about the KCM a few weeks ago and decided on a single 
list + modal dialog design, as per @abetts and @ngraham et all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Some shots:
  
  F5803407: Screenshot_20180411_072428.png 

  
  F5803409: Screenshot_20180411_072443.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein created this revision.
hein added reviewers: Kirigami, mart.
Restricted Application added projects: Plasma, Kirigami.
Restricted Application added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  - Changed the overall design from two lists to one list with a modal sheet to 
add more languages.
  - Replaced a modal "You need to relogin for changes" dialog with a 
MessageType.Positive InlineMessage.
  - Reworked the way missing languages are handled: The old KCM silently 
rewrote config and showed a warning. The new design shows an informative 
warning and removes the missing languages on the next save. Until then they're 
flagged as missing in the list.
  - Manages Apply button state correctly (or rather at all ...).
  
  This depends on D12097 .
  
  This implements T7247 .
  
  This is currently not final code. It's a WIP upload to give Marco
  something to work with to fix various Kirigami and SimpleKCM problems.
  
  Currently known issues:
  
  - Does not save (code is from old KCM, might have been broken there)
  - Disabled SwipeListItem actions do not show disabled
  - Placement of actions button in SwipeListItem is wonky if the contentItem is 
a RowLayout
  - SwipeListItem spews errors about positionAnimation after using an action
  - SwipeListItem is awkward to use, we need a drag-reorderable list delegate
  - OverlaySheet spews numerous warnings about not being able to find 
applicationWindow and activeFocusItem
  - The sheet is parented to the SimpleKCM's parent since there's no app window 
to be modal too
  - The footer inside an OverlaySheet sometimes moves up above the content 
instead of staying down
  - Even though SimpleKCM is just a Kirigami.ScrollablePage like Kirigami 
Gallery pages, an InlineMessage that fills the page width gets cut off on the 
left and right, so wonky code to insert margins next to them
  - List has window bg color as background instead of view background color

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 10 Apr 2018 21:42:00 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 62.54 KB...]QT_SELECT = 'qt5'HUDSON_HOME   = '/home/production/data'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'STAGE_NAME= 'Configuring Build'EXECUTOR_NUMBER   = '0'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins/bin'BLOCKSIZE = 'K'SHLVL = '1'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/19/display/redirect?page=changes'LOGNAME   = 'jenkins'BUILD_NUMBER  = '19'LANG  = 'en_US.UTF-8'MM_CHARSET= 'UTF-8'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/19/display/redirect'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'TERM  = 'su'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'NODE_NAME = 'FreeBSD Builder 1'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'_ = '/usr/local/bin/java'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/display/redirect'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.9-19'JENKINS_HOME  = '/home/production/data'XDG_CURRENT_DESKTOP   = 'KDE'JENKINS_NODE_COOKIE   = '4da161b7-2708-49a1-8bce-e9dae05edea0'BUILD_DISPLAY_NAME= '#19'MAIL  = '/var/mail/jenkins'JAVA_HOME = '/usr/local/openjdk8-jre'JENKINS_URL   = 'https://build.kde.org/'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.9'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'BUILD_ID  = '19'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'OLDPWD= '/usr/home/jenkins'USER  = 'jenkins'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'HUDSON_URL= 'https://build.kde.org/'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake 

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provider

[Friedrich W . H . Kossebau]

kossebau added a comment.


  If there are no further comments, will push on Fri, April 13th.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11978

To: kossebau, xuetianweng
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11964: [potd dataengine] Enable development of 3rd-party potd provider plugins

[Friedrich W . H . Kossebau]

kossebau added a comment.


  If noone objects, will push on Fri, April 13th.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11964

To: kossebau, xuetianweng
Cc: richardbowen, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 10 Apr 2018 21:23:40 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 62.55 KB...]BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.9-18'BUILD_NUMBER  = '18'SHLVL = '1'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'OLDPWD= '/usr/home/jenkins'TERM  = 'su'JAVA_HOME = '/usr/local/openjdk8-jre'XDG_CURRENT_DESKTOP   = 'KDE'BLOCKSIZE = 'K'JENKINS_URL   = 'https://build.kde.org/'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'USER  = 'jenkins'SHELL = '/usr/local/bin/bash'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'_ = '/usr/local/bin/java'MAIL  = '/var/mail/jenkins'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'STAGE_NAME= 'Configuring Build'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins/bin'BUILD_ID  = '18'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/18/'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.9'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'BUILD_DISPLAY_NAME= '#18'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'LOGNAME   = 'jenkins'HUDSON_HOME   = '/home/production/data'JENKINS_HOME  = '/home/production/data'QT_SELECT = 'qt5'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'MM_CHARSET= 'UTF-8'EXECUTOR_NUMBER   = '0'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/18/display/redirect'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/18/display/redirect?page=changes'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/display/redirect'HUDSON_URL= 'https://build.kde.org/'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5KIO: 

D11954: [potd dataengine] Turn prodiver plugin metadata into json files

[Friedrich W . H . Kossebau]

kossebau added a comment.


  If noone objects, will push on Fri, April 13th.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11954

To: kossebau, xuetianweng
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11957: [potd dataengine] De-pimplify potd providers for more simple code

[Friedrich W . H . Kossebau]

kossebau added a comment.


  If noone objects, will push on Fri, April 13th.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11957

To: kossebau, xuetianweng
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

String freeze exception for Plasma/5.12 (documentation)

[Luigi Toscano]

Hi,

I'd like to request an exception for the documentation of kcmsmserver in
Plasma/5.12, and namely the backport of this review:
https://phabricator.kde.org/D11817

which fixes various references to Plasma instead of KDE.

Given the LTS nature of Plasma 5.12 I think it's worth doing it.

Comments/ideas/disagreements?

Ciao
-- 
Luigi

D12097: Make room for footer and header.

[Eike Hein]

hein created this revision.
hein added reviewers: Kirigami, mart.
Restricted Application added projects: Kirigami, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
hein requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12097

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: hein, #kirigami, mart
Cc: plasma-devel, #frameworks, michaelh, ngraham, bruns, apol, davidedmundson, 
mart, hein

D12092: Add plasmashell --replace

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good otherwise.

INLINE COMMENTS

> main.cpp:107
>  
> +QCommandLineOption 
> replaceOption(QStringList({QStringLiteral("replace")}),
> + i18n("Replace an existing instance"));

QStringList() is not necessary.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12092

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D12056: Don't have a non-integral size on separators

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2c09d61d736c: Dont have a non-integral size on 
separators (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12056?vs=31795=31833

REVISION DETAIL
  https://phabricator.kde.org/D12056

AFFECTED FILES
  src/controls/Separator.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12080: Don't show the actions if they are disabled

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b22a3b0c52af: Dont show the actions if they are 
disabled (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12080?vs=31793=31831

REVISION DETAIL
  https://phabricator.kde.org/D12080

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12081: Fix warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:18228385e172: Fix warning (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12081?vs=31794=31832

REVISION DETAIL
  https://phabricator.kde.org/D12081

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 10 Apr 2018 17:24:33 +
 Build duration:
5 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 62.82 KB...]BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/17/'MM_CHARSET= 'UTF-8'MAIL  = '/var/mail/jenkins'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.9-17'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'_ = '/usr/local/bin/java'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/17/display/redirect?page=changes'XDG_CURRENT_DESKTOP   = 'KDE'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'BLOCKSIZE = 'K'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/'TERM  = 'su'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins/bin'SHLVL = '1'JENKINS_URL   = 'https://build.kde.org/'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/17/display/redirect'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'OLDPWD= '/usr/home/jenkins'BUILD_DISPLAY_NAME= '#17'HOME  = '/usr/home/jenkins'JENKINS_HOME  = '/home/production/data'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'USER  = 'jenkins'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'NODE_NAME = 'FreeBSD Builder 1'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.9'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9'LANG  = 'en_US.UTF-8'SHELL = '/usr/local/bin/bash'BUILD_NUMBER  = '17'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'QT_SELECT = 'qt5'LOGNAME   = 'jenkins'EXECUTOR_NUMBER   = '0'BUILD_ID  = '17'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/display/redirect'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: 

D12092: Add plasmashell --replace

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Calls the existing quit signal on a running plasma then tries to start
  in the normal way.
  
  It's meant partly to make my own development workflow a bit easier, but
  also to make it one less line on bugzilla when I want people to give me
  debug output.

TEST PLAN
  Ran with existing plasma running
  Ran without an existing plasma running

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12092

AFFECTED FILES
  shell/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=369676

Rog131  changed:

   What|Removed |Added

 CC||s.oosth...@xs4all.nl

--- Comment #25 from Rog131  ---
*** Bug 392964 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12086: [OSD] Enforce plain text

[David Edmundson]

davidedmundson added a comment.


  Change is fine, but where do we put third party data in an OSDItem?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12086

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

[David Edmundson]

davidedmundson added a comment.


  Same comments as the other one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12090

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12088: port the ksplash kcm to the new design

[David Edmundson]

davidedmundson added a comment.


  I like patches with more red than green. It's a very positive sign ++
  
  Minor comments below

INLINE COMMENTS

> main.qml:51
> +kcm.selectedPlugin = model.pluginName;
> +view.currentIndex = index;
> +view.forceActiveFocus();

Doing this *and* the conection on line 64 seems wrong.

> main.qml:60
> +view.currentIndex = kcm.selectedPluginIndex;
> +view.positionViewAtIndex(grid.currentIndex, GridView.Visible)
> +}

redundant given the onCurrentIndexChanged binding above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12088

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

[Marco Martin]

mart added a comment.


  F5802963: Spectacle.eJ4587.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12090

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12090: port the look and feel kcm to new design

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  use the new design for the look and feel kcm, together with
  a massive code simplification

TEST PLAN
  pply does work, as preview of themes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/lookandfeelredesign

REVISION DETAIL
  https://phabricator.kde.org/D12090

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12088: port the ksplash kcm to the new design

[Marco Martin]

mart added a comment.


  F5802937: Spectacle.E21294.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12088

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12088: port the ksplash kcm to the new design

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  redically simplifying the code, port the ksplash kcm to the new design

TEST PLAN
  selecting and preview work correctly, resize behavior is correct

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/ksplashredesign

REVISION DETAIL
  https://phabricator.kde.org/D12088

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12086: [OSD] Enforce plain text

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  5.8 branch as it's potentially security-relevant (img tag) like the 
notification fix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12086

AFFECTED FILES
  lookandfeel/contents/osd/OsdItem.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11850: modernize: use auto

[David Edmundson]

davidedmundson added a comment.


  I was saying you can push this now you've done it, but I wouldnt' go about 
changing other bits of code elsewhere.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11850

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 31810.
zzag added a comment.


  Rebase.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=30238=31810

BRANCH
  refine-shadows-kstyle

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 31809.
zzag added a comment.


  Rebase.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29540=31809

BRANCH
  refine-shadows-kdecoration

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag updated this revision to Diff 31808.
zzag added a comment.


  Rebase.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=29989=31808

BRANCH
  refine-shadows-libbreezecommon

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11981: [Image Wallpaper] Fix blur

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d34a9e23eddd: [Image Wallpaper] Fix blur (authored by 
broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11981?vs=31468=31806

REVISION DETAIL
  https://phabricator.kde.org/D11981

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11533: [kstyle] create shadow tiles more explicitly

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:a4131c5d4024: [kstyle] create shadow tiles more explicitly 
(authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11533?vs=31802=31805

REVISION DETAIL
  https://phabricator.kde.org/D11533

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11533: [kstyle] create shadow tiles more explicitly

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  explicit-shadow-creation

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12083: Show OSD when default output changes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:893ee005b120: Show OSD when default output changes 
(authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12083?vs=31800=31804

REVISION DETAIL
  https://phabricator.kde.org/D12083

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml
  src/qml/dbus/osdService.xml
  src/qml/volumeosd.cpp
  src/qml/volumeosd.h

To: broulik, #plasma, #vdg, drosca
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11533: [kstyle] create shadow tiles more explicitly

[Vlad Zagorodniy]

zzag updated this revision to Diff 31802.
zzag added a comment.


  Trigger creation of shadow tiles in `loadConfig()`.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11533?vs=31774=31802

BRANCH
  explicit-shadow-creation

REVISION DETAIL
  https://phabricator.kde.org/D11533

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12083: Show OSD when default output changes

[Kai Uwe Broulik]

broulik updated this revision to Diff 31800.
broulik edited the test plan for this revision.
broulik added a comment.


  - Use default sink instead of preferred sink as the latter also changes 
depending on where music is being played

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12083?vs=31797=31800

REVISION DETAIL
  https://phabricator.kde.org/D12083

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml
  src/qml/dbus/osdService.xml
  src/qml/volumeosd.cpp
  src/qml/volumeosd.h

To: broulik, #plasma, #vdg, drosca
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

[David Edmundson]

davidedmundson added a comment.


  Either things are consistent or not consistent with other applets.
  That is a yes/no case.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

[Henrik Fehlauer]

rkflx added a comment.


  In D11558#243632 , @davidedmundson 
wrote:
  
  > We're at an impasse then.
  
  
  Only if you make this a yes/no decision. There are still options for a 
compromise which would fit both use cases.
  
  > by default it's currently the same colour as the regular memory so 
impossible to see.
  
  The colour could be changed, or it could be made an option defaulting to off.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[David Edmundson]

davidedmundson added a comment.


  We're at an impasse then.
  
  I do like and respect having your feedback, but I'm not particularly swayed.  
It leaves this one super tiny summary applet showing more "detailed/noisy" 
information than the full on ksysguard application, which  doesn't make sense.  
We can be pretty sure there's no-one currently using it for that, based on the 
fact that by default it's currently the same colour as the regular memory so 
impossible to see.
  
  Can someone else from Plasma make a decision either way.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11986: [potd wallpaper] Add missing Messages.sh, use wallpaper catalog name

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:79377f8a206f: [potd wallpaper] Add missing Messages.sh, 
use wallpaper catalog name (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11986?vs=31495=31798

REVISION DETAIL
  https://phabricator.kde.org/D11986

AFFECTED FILES
  wallpapers/potd/Messages.sh
  wallpapers/potd/contents/ui/config.qml

To: kossebau, xuetianweng, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12083: Show OSD when default output changes

[David Edmundson]

davidedmundson added a comment.


  Very nice +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D12083

To: broulik, #plasma, #vdg, drosca
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12083: Show OSD when default output changes

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ListItemBase.qml:284
>  menuItem.clicked.connect(function() {
> +paSinkModel.pendingPreferredSinkChange = true;
>  PulseObject.default = true

It's possible that changing the sink will fail and `pendingPreferredSinkChange` 
will stay `true` until next sink change (which may not be user-initiated).

> main.qml:158
> +onPreferredSinkChanged: {
> +if (pendingPreferredSinkChange) {
> +pendingPreferredSinkChange = false;

It won't work when default sink is changed from KCM, so I think let's just show 
the OSD every time (except startup)?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D12083

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Upcoming CI changes - service disruption

[Ben Cooksley]

Hi all,

In order to allow for two replacement physical build hosts to be
rotated in and the old ones to be decommissioned, i'm scheduling some
downtime for both the CI system and the Binary Factory tomorrow.

Assuming all goes well, this downtime should be fairly short. During
the downtime Jenkins will still be accessible, however builds will not
trigger on push as they usually do. The system will perform these
builds once the changeover is completed.

To help us detect issues with the changeover, it would be appreciated
if everyone could make sure their builds, particularly on FreeBSD and
Windows are successful prior to the switch.

At this time the following projects appear to have builds which have
regressed on these platforms:
- KItinerary
- Plasma Vault
- Amarok

Thanks,
Ben

D12083: Show OSD when default output changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the default output changes because a device is plugged in or a Bluetooth 
headset is connected, show an OSD so the user knows when/that the device is 
ready to use.

TEST PLAN
  Turned on my Bluetooth headset, took a second two connect (Bluetooth Icon 
shows dots), and then took another couple of seconds for PulseAudio to 
recognize the device and then the OSD showed up.
  If a device icon is available (e.g. headset) it is shown, otherwise the 
volume icon (using the correct icon depending on volume) shows up:
  F5802585: Screenshot_20180410_123739.png 

  F5802580: Screenshot_20180410_123511.png 

  
  - Verified that no OSD is shown on startup (the default changes once from 
none to whatever is the default)
  - Verified that no OSD is shown when user explicitly changes the Default in 
the applet
  - Did not test what happens if I plug in headphone jack (where the profile on 
the same device changes from speaker to headphones)
  - Changing output configuration in volume settings might spawn the OSD when 
you disable/enable a device that used to be a default at one point
  
  There's a setting in the applet, default is enabled:
  F5802577: Screenshot_20180410_123345.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D12083

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml
  src/qml/dbus/osdService.xml
  src/qml/volumeosd.cpp
  src/qml/volumeosd.h

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12056: Don't have a non-integral size on separators

[Aleix Pol Gonzalez]

apol updated this revision to Diff 31795.
apol added a comment.


  - Don't show the actions if they are disabled

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12056?vs=31792=31795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12056

AFFECTED FILES
  src/controls/Separator.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12081: Fix warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  .../kirigami.2/ScrollablePage.qml:160: TypeError: Cannot assign to read-only 
property "parent"

REPOSITORY
  R169 Kirigami

BRANCH
  warning

REVISION DETAIL
  https://phabricator.kde.org/D12081

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12080: Don't show the actions if they are disabled

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise you get a dummy button that does nothing

REPOSITORY
  R169 Kirigami

BRANCH
  disabledActions

REVISION DETAIL
  https://phabricator.kde.org/D12080

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12056: Don't have a non-integral size on separators

[Aleix Pol Gonzalez]

apol updated this revision to Diff 31792.
apol added a comment.


  - Don't show the actions if they are disabled

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12056?vs=31711=31792

BRANCH
  disabledActions

REVISION DETAIL
  https://phabricator.kde.org/D12056

AFFECTED FILES
  src/controls/Separator.qml
  src/controls/private/ActionButton.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11533: [kstyle] create shadow tiles more explicitly

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D11533#243511 , @zzag wrote:
  
  > Well, after thinking for a while, I think shadowTiles should be called in 
loadConfig. It doesn't make much sense to create something in reset method.
  
  
  I agree

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11533

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11991: Fix warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9c0c690188a7: Fix warning (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11991?vs=31510=31789

REVISION DETAIL
  https://phabricator.kde.org/D11991

AFFECTED FILES
  org.kde.desktop/ToolBar.qml

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein