D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Nathaniel Graham]

ngraham added a comment.


  In D12252#254928 , @zzag wrote:
  
  > I've just noticed that it's calling `setMinimumSize`. Why? (especially, 
with such a big minimum size)
  >
  > What about icon based view mode, i.e. the old settings layout?
  
  
  Hmm, that's true.
  
  > The new settings layout(with sidebar) is still usable with window sizes 
smaller than 1024x700.
  
  Many KCMs are not, though.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> bruns wrote in AuthDialog.cpp:349
> According to 
> https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules
> `description` is not optional, so the correct statement is "Missing"

I was checking to see if this was still open, and would like to discuss 
"Missing". I considered "Missing" while I was originally coding this, but 
thought it sounded a little negative, like we weren't able to access the 
information. I realize that "Missing" is the official response per the FDO 
spec, could we settle on something like "Not Provided"? After all, it's not 
//our fault// the information is missing. Just an idea.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey added a comment.


  In D12252#254928 , @zzag wrote:
  
  > I've just noticed that it's calling `setMinimumSize`. Why? (especially, 
with such a big minimum size)
  >
  > What about icon based view mode, i.e. the old settings layout? The new 
settings layout(with sidebar) is still usable with window sizes smaller than 
1024x700.
  
  
  Is this issue still open? The size has been discussed a couple of times. Do I 
need to work up something else?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey updated this revision to Diff 33667.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Remove redundant size setting

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12252?vs=33208=33667

BRANCH
  arcpatch-D12252

REVISION DETAIL
  https://phabricator.kde.org/D12252

AFFECTED FILES
  app/SettingsBase.cpp

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.10/9/
 Project:
Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 04 May 2018 21:47:36 +
 Build duration:
2 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13463)19%
(1978/10657)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/470)0%
(0/263)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.10/8/
 Project:
Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 03 May 2018 14:11:57 +
 Build duration:
1 day 7 hr and counting
   CONSOLE OUTPUT
  [...truncated 232.21 KB...]^~~/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:487:20: warning: 'Plasma::Package::Package(const Plasma::Package&)' is deprecated [-Wdeprecated-declarations] return Package();^In file included from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/package.h:107:23: note: declared here PLASMA_DEPRECATED Package(const Package );   ^~~/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp: In member function 'KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString&, const QString&)':/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:532:157: warning: 'KPluginInfo::KPluginInfo(KService::Ptr)' is deprecated [-Wdeprecated-declarations] auto pi = md.metaDataFileName().endsWith(QLatin1String(".json")) ? KPluginInfo(md) : KPluginInfo(KService::serviceByStorageId(md.metaDataFileName())); ^In file included from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/package.h:25:0, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/build/src/plasma/plasma/package.h:1, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:20:/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here explicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service);  ^~~/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp: In member function 'KPluginInfo::List Plasma::PluginLoader::listContainmentActionsInfo(const QString&)':/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:754:38: warning: 'KPluginInfo::KPluginInfo(KService::Ptr)' is deprecated [-Wdeprecated-declarations] list.append(KPluginInfo(s));  ^In file included from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/package.h:25:0, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/build/src/plasma/plasma/package.h:1, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:20:/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here explicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service);  ^~~/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp: In member function 'virtual Plasma::Package Plasma::PluginLoader::internalLoadPackage(const QString&, const QString&)':/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:796:20: warning: 'Plasma::Package::Package(Plasma::PackageStructure*)' is deprecated [-Wdeprecated-declarations] return Package();^In file included from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10/src/plasma/package.h:95:32: note: declared here PLASMA_DEPRECATED explicit Package(PackageStructure *structure = nullptr);

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria updated this revision to Diff 33663.
maximilianocuria added a comment.


  A somewhat simpler version, just delay the close(2) call.
  I was testing this and trying to look for some documentation about the use of
  the fds in pam modules. I'm pretty sure that you can't keep them, but I've 
found
  anything that talks about this.

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12702?vs=33657=33663

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[David Edmundson]

davidedmundson added a comment.


  Thanks for investigating.
  
  Might be cleaner to explicitly open the stderr FD earlier and not do anything 
with it, which would force the socket() call to give us an unused one.
  
  But if that doesn't work...+1 from me.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12702

To: maximilianocuria, #plasma, aacid
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, aacid.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  The fixes for CVE-2018-10380 introduced a regression for most users not
  using kde, and some for kde sessions. In particular the reorder of the
  close calls and creating a new socket caused that the socket is always
  assigned the file descriptor 2, aka stderr.
  
  BUG: 393856

TEST PLAN
  It works

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12701: Remove D10890 workaround

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added reviewers: Plasma, broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  D10890  was a workaround related to 
KRecentDocument::add() bug (see D10863 )
  which is fixed in Frameworks 5.46. Given that Plasma 5.13 depends on that
  Frameworks version, it's safe to remove this no longer needed workaround
  without breaking anything.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove_D10890_workaround

REVISION DETAIL
  https://phabricator.kde.org/D12701

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Thomas Pfeiffer]

colomar added inline comments.

INLINE COMMENTS

> fabianr wrote in ondemand.rst:27
> My intention was to suggest switching to a navigation pattern  like 
> "Master-Detail" or "Column-based navigation", so each item has its own 
> content page where more actions could easily be displayed.
> 
> What kind of command pattern would you suggest could replace the 3+ actions?

Ah okay, now I understand what you mean. I don't think that becomes clear 
through that wording, however.

In any case, it's the command pattern that is directly affected by the number 
of actions. It is true that the command patterns that work well for for more 
than three actions usually necessitate a deeper hierarchy, but that is then the 
next step. The first decision is which command pattern to choose, and that can 
be for example a context drawer or controls within content.

So I'd still suggest to change it to a link to command patterns. Once the 
designer has chosen a suitable command pattern, //then// they have to figure 
out which navigation pattern  best suits that.

REPOSITORY
  R985 KDE Human Interface Guidelines

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12699: Don't allow showing/hiding the drawer when there's no handle

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  If there's no handle and the drawer is modal, we can understand that the
  drawer isn't meant to be closed. Disable the mouse area that is used for
  closing it when that happens.
  
  BUG: 393776

TEST PLAN
  Can't reproduce the issue in the mentioned bug report

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12699

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12694: Properly fix the native messaging host file

[Milian Wolff]

mwolff added a comment.


  It compiles, how do I test it? Can you please also add a `README` to the root 
of this project that explains what this is, does and how to use it?
  
  thanks

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12694

To: bshah, mwolff, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: D12698: WIP; advert

[David Edmundson]

​I hate arc sometimes.
I pressed control+c to cancel and it thought that meant "send anyway" with
a garbage title :(

D12698: WIP; advert

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  squashme

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  store_link_popup

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  advert/CMakeLists.txt
  advert/browserlaunchwatcher.cpp
  advert/browserlaunchwatcher.desktop
  advert/browserlaunchwatcher.h

To: davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 33631.
fabianr added a comment.


  - Fixed typo

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=33609=33631

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr marked an inline comment as done.
fabianr added inline comments.

INLINE COMMENTS

> colomar wrote in ondemand.rst:27
> Since this is a command pattern, shouldn't this link to command patterns 
> instead of navigation patterns?

My intention was to suggest switching to a navigation pattern  like 
"Master-Detail" or "Column-based navigation", so each item has its own content 
page where more actions could easily be displayed.

What kind of command pattern would you suggest could replace the 3+ actions?

REPOSITORY
  R985 KDE Human Interface Guidelines

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Thomas Pfeiffer]

colomar added a comment.


  See inline comments. Otherwise it looks good!

INLINE COMMENTS

> ondemand.rst:27
> +   on-demand controls. If you need more actions, choose a different 
> +   :doc:`navigation pattern `.
> +-  Only use on-demand controls, if the actions are the same for each item.

Since this is a command pattern, shouldn't this link to command patterns 
instead of navigation patterns?

> ondemand.rst:57
> +handle is slid back.
> +
> +

I'd add a screenshot of the swipelistitem here as well

> ondemand.rst:59
> +
> +For futher guidelines see :doc:`swip list item `.

swip -> swipe

REPOSITORY
  R985 KDE Human Interface Guidelines

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12686: Fix sidebar view regression of not prompting about unsaved changes

[David Edmundson]

davidedmundson updated this revision to Diff 33629.
davidedmundson added a comment.


  Remove debug
  
  stupid arc. Spend ages selectively choosing the hunks I want, and then it 
goes and adds them
  back anyway to "help".

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12686?vs=33628=33629

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12686

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12686: Fix sidebar view regression of not prompting about unsaved changes

[David Edmundson]

davidedmundson updated this revision to Diff 33628.
davidedmundson added a comment.


  Remove debug
  
  stupid arc.  Spend ages selectively choosing the hunks I want, and then it 
goes and adds them
  back anyway to "help".

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12686?vs=33627=33628

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12686

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12686: Fix sidebar view regression of not prompting about unsaved changes

[David Edmundson]

davidedmundson updated this revision to Diff 33627.
davidedmundson added a comment.


  Also fixes the UI on cancel
  
  Checkable property would be updated internally on clicked, breaking our 
binding and 
  becoming checked on clicked regardless
  The background color is set by if (checked || highlighted) so we can use that 
instead

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12686?vs=33566=33627

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12686

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12683: Guard BookmarksRunner thread use

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:947b03d674e8: Guard BookmarksRunner thread use (authored 
by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12683?vs=33556=33624

REVISION DETAIL
  https://phabricator.kde.org/D12683

AFFECTED FILES
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h

To: davidedmundson, #plasma, mart
Cc: rempt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12694: Properly fix the native messaging host file

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: mwolff, broulik, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  - Previous approch broke the installation for the non-root installation where 
make install was performed as user
  - Add option COPY_MESSAGING_HOST_FILE_HOME option to cmake configuration 
which allows to copy the host file to user specific paths where relevant 
applications look for.

TEST PLAN
  tested on neon system by removing package installed path and doing make
  install as normal user

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12694

AFFECTED FILES
  CMakeLists.txt

To: bshah, mwolff, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 33609.
fabianr added a comment.


  - Updated visuals for listview and folderview

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=32867=33609

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Marco Martin]

mart added a comment.


  ok for the text, the screenshots would need update:
  both of them at the moment are desktop, which is ok (i would add the mouse 
cursor)
  and one mobile is needed, provided here:
  Desktop, listview:
  F5833032: image.png 
  Mobile, listview:
  F5833036: image.png  (added a thing to 
indicate touch, no idea if it maskes sense)
  Desktop, Grid view:
  F5833039: image.png 
  
  We will need to design something for mobile gridview as well i guess as it 
would be widely used as well i guess (eg photo gallery)
  but that's for a next iteration :)

REPOSITORY
  R985 KDE Human Interface Guidelines

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> mart wrote in ondemand.rst:11
> maybe add a dolphin screenshot as well with the + on hover? (or folderview)

There is a dolphin screenshot with the hover in the desktop section, (line 48+)

REPOSITORY
  R985 KDE Human Interface Guidelines

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12686: Fix sidebar view regression of not prompting about unsaved changes

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  The current index or highlighted item in the sidebar still changes if you 
Cancel in the prompt as that's done from QML

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12686

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart