[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=349750

Andrew Crouthamel  changed:

   What|Removed |Added

   Keywords||triaged

--- Comment #11 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days.
Please provide the requested information as soon as possible and set the bug
status as REPORTED. Due to regular bug tracker maintenance, if the bug is still
in NEEDSINFO status with no change in 30 days, the bug will be closed as
RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki
located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug
status as REPORTED so that the KDE team knows that the bug is ready to be
confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=375826

Andrew Crouthamel  changed:

   What|Removed |Added

   Keywords||triaged

--- Comment #2 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days.
Please provide the requested information as soon as possible and set the bug
status as REPORTED. Due to regular bug tracker maintenance, if the bug is still
in NEEDSINFO status with no change in 30 days, the bug will be closed as
RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki
located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug
status as REPORTED so that the KDE team knows that the bug is ready to be
confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15807: Allow to disable installation of wallpapers with breeze

[Aleix Pol Gonzalez]

apol closed this revision.
apol added a comment.


  https://commits.kde.org/breeze/b97dfaff25ca2eb18099128243f3e2b2d2b56230

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15807

To: apol, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Stefan Brüns]

bruns added a comment.


  Try this one:
  F6290609: authdetails.ui 
  Also fixed up vertical alignment, should be the same for all labels.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

[James Smith]

smithjd added a comment.


  > A slightly smarter approach would be for Plasma Vaults itself to add such a 
rule for whatever mountpoint is chosen during new vault creation.
  
  What about exposing these config options on dbus? 
("includeFolders"),("excludeFolders")
  
  That would make for 4 new entries (add/remove for each) on the 
org.kde.baloo.main interface.

TASK DETAIL
  https://phabricator.kde.org/T8066

To: michaelh, smithjd
Cc: ngraham, smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeymin, 
michaelh, ashaposhnikov, astippich, spoorun, abrahams

D12498: Fully remove `Application Name` from Details panel

[Nathaniel Graham]

ngraham added a comment.


  > The XML file is auto-generated by the form editor in QtCreator. I don’t 
have any control over it. And I don’t want to mess with it by hand - too easy 
to break.
  
  You pretty much have to, or else the diff is impossible to review, and it's 
easy for unintentional changes to sneak in. `.ui` files just aren't any fun, 
and this issue is why I suggested porting it to QML in T8569 
.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> bruns wrote in authdetails.ui:20
> Can you try to restore/use the same item order in the XML file as previously?
> Should make the diff significantly smaller, and easier to review.

The XML file is auto-generated by the form editor in QtCreator. I don’t have 
any control over it. And I don’t want to mess with it by hand - too easy to 
break.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> authdetails.ui:20
>
> -   
> -
> - 
> -  
> -   75
> -   true
> -  
> +   
> +

Can you try to restore/use the same item order in the XML file as previously?
Should make the diff significantly smaller, and easier to review.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I've written you a unit test.
  
  I can either take over this or upload as a separate review that you can merge 
in.

INLINE COMMENTS

> zzag wrote in surface_interface.cpp:819
> So, it would be fine to return `true` in the following case:
> 
>   QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10));
> 
> ?

I would have said so.

But then it means sizeContains and inputContains behave differently as

QRegion(QRect(0,0,10,10)).contains(10,10);  returns false

which gives us some inconsistency.

> surface_interface.cpp:824
>  {
> -if (!isMapped()) {
> +return sizeContains(size, QRegion(), position) && 
> input.contains(position.toPoint());
> +}

This needs to be

&& (surface.inputIsInfinite() || input.contains(..))

which means either an extra arg in our function pointer or go back to the 
frankly simpler first revision. Writing N complex lines to save duplicating N 
simple lines doesn't make much sense to me, especially when they end up 
deviating.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

[plasmashell] [Bug 360339] Plasma Crash on startup

[Haris Tampakopoulos]

https://bugs.kde.org/show_bug.cgi?id=360339

Haris Tampakopoulos  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

D15807: Allow to disable installation of wallpapers with breeze

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Will make it possible to have breeze on the flatpak and snap backends
  without all of the wallpapers

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15807

AFFECTED FILES
  CMakeLists.txt

To: apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[David Rosca]

drosca added a comment.


  In D15304#332755 , @ngraham wrote:
  
  > > Plasma items should not be used in KCM.
  >
  > Hmm, what you you recommend then for showing an icon item? The old 
`QIconItem` breaks for fractional scale factors. Kirigami has a nice icon, but 
then we'd need to import Kirigami.
  
  
  I suggest to fix QIconItem, as it is used in other places too.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Marco Richetta]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #33 from Marco Richetta  ---
> Marco Richetta seems to have problem with upower, independent of this bug.
> 
> The applet not detecting battery only affects kde, other desktops seem to
> work fine.

Just restarted my laptop.

acpi -i outputs nothing.

upower -d does not detect the battery.

dmesg outputs an acpi error
===

dmesg | grep -i error
[0.109117] acpi PNP0A08:00: _OSC failed (AE_ERROR); disabling ASPM
[   63.483271] xhci_hcd: probe of :04:00.0 failed with error -110
[   63.501542] RAS: Correctable Errors collector initialized.
[   63.856116] usb 2-1.3: device descriptor read/64, error -32
[   65.840365] EXT4-fs (sda1): re-mounted. Opts: errors=remount-ro

In case you ask, my laptop was made by an embedded manufacturer from Argentina
and some components are chinese I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a comment.


  In D15011#332631 , @cfeck wrote:
  
  > David is on holidays, so maybe someone else could approve if this is urgent.
  
  
  Ah, whoops, didn't know that. No, it's not urgent. I can wait until he 
returns, then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: cfeck, acrouthamel, fabianr, huftis, rooty, sharvey, romangg, broulik, 
safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham added a comment.


  > Plasma items should not be used in KCM.
  
  Hmm, what you you recommend then for showing an icon item? The old 
`QIconItem` breaks for fractional scale factors. Kirigami has a nice icon, but 
then we'd need to import Kirigami.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15644: Provide option to hide menu bar for Ksysguard

[Nathaniel Graham]

ngraham added a comment.


  Awesome job, @lsartorelli. For your next trick, would you like to create 
`KStandardAction::showMenubarWithWarning` (or something like that)? This would 
essentially duplicate the code you've written here, but it would be in a new 
central location so we could ensure consistency between apps, and make changes 
in only one place rather than //n// places. Then we could start to port 
KSysGuard, Kate, Gwenview to use it--and also adopt it for some of the 
remaining apps that don't currently show a warning, like Konsole.
  
  The relevant code is in 
https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619. 
Wanna have a go at it?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15793: Sort keys in json encoder

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ef33a69d7ea6: Sort keys in json encoder (authored by 
davidedmundson).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15793?vs=42415=42418

REVISION DETAIL
  https://phabricator.kde.org/D15793

AFFECTED FILES
  util/convertpottojson.py

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15793: Sort keys in json encoder

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Should supress scripty noise.
  
  The previous manualy sorting above was ultimately useless as it's stored
  as a map internally inside the json blob. We need to sort when writing out,
  it turns out there's an argument for that.

TEST PLAN
  Ran script
  Still got some output.
  Running twice didn't change output

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15793

AFFECTED FILES
  util/convertpottojson.py

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14068: add -P switch to one-shot redshift call

[mat gr]

grmat added a comment.


  In D14068#332672 , @davidedmundson 
wrote:
  
  > what happens to users on older versions?
  
  
  It breaks, as redshift <1.12 will exit with "invalid option -- 'P'".
  
  I initially just thought of this as packaging responsibility, however, users 
might install those applets independently from distribution's packages.
  
  It would be possible to make a runtime check, look for the version no. with 
`redshift -V` and add the -P switch dynamically. However, I'm not familiar with 
QML or where this call would be added. I thought of something like
  
...
property string redshiftCompat: getInstalledRedshiftVersion().split(' ')[1] 
< '1.12' ? '' : '-P'
property string redshiftOneTimeCommand: 'redshift -O ' + redshiftCompat + 
...

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat, #plasma, romangg, martinkostolny
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15644: Provide option to hide menu bar for Ksysguard

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:3a3220d41ac4: Provide option to hide menu bar for 
Ksysguard (authored by lsartorelli, committed by sitter).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15644?vs=42368=42414

REVISION DETAIL
  https://phabricator.kde.org/D15644

AFFECTED FILES
  gui/ksysguard.cpp
  gui/ksysguard.h

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15644: Provide option to hide menu bar for Ksysguard

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  It's perfect now!

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> main.qml:138
>  
> -readonly property int thickness: 
> Math.ceil(Math.min(parent.width, parent.height) / units.iconSizes.small)
>  

We need to make thickness independent from length.

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain updated this revision to Diff 42413.
McPain added a comment.


  (height * 2) + spacer.height -> (height - spacer.height) / 2

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15333?vs=41157=42413

REVISION DETAIL
  https://phabricator.kde.org/D15333

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:111
> Please explain the rationale behind this.
> 
> Especially the spacer.width being divided by 2 in the second part of the 
> statement.

> Especially the spacer.width being divided by 2 in the second part of the 
> statement.

Look at all the parentheses I wrote ;)
I divide by two a *subtraction* of spacer.width from width.

Former we calculated a button size to fit the whole widget vertically (if the 
layout is horizontal) and vice versa but what if we don't have enough space to 
fit the widget horizontally?

We have a 100x100 field. Okay, let height = 90 (margins, etc)
Then, first button 90x90, spacer 5x90 (still okay), and one more button 90x90 
(oops, fail: the widget is 185x90)

Now we check the second dimension and shrink the buttons when necessary.
First button 45x45, spacer 5x45, second button 45x45. The widget if 95x45, and 
it fits now.

So, we have to subtract spacer width from parent width and divide it by 2, 
because we have two buttons and check if it's smaller than height. If so, we 
fit in the width.

Same thing when layout is vertical.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> CardListItem.qml:33
>  RowLayout {
> -QIconItem {
> +PlasmaCore.IconItem {
>  id: clientIcon

Plasma items should not be used in KCM.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Arnaud]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #32 from Arnaud  ---
Sorry, accidental post

Same problem as everyone, with kde battery plasmoid not detecting any battery
despite upower detecting it.
Battery status available on lock screen.

upower -d

Device: /org/freedesktop/UPower/devices/line_power_ADP1
  native-path:  ADP1
  power supply: yes
  updated:  mer. 26 sept. 2018 22:54:31 CEST (4056 seconds ago)
  has history:  no
  has statistics:   no
  line-power
warning-level:   none
online:  yes
icon-name:  'ac-adapter-symbolic'

Device: /org/freedesktop/UPower/devices/battery_BAT0
  native-path:  BAT0
  vendor:   LGC
  model:AC14B18J
  serial:   51866
  power supply: yes
  updated:  jeu. 27 sept. 2018 00:01:59 CEST (8 seconds ago)
  has history:  yes
  has statistics:   yes
  battery
present: yes
rechargeable:yes
state:   charging
warning-level:   none
energy:  30,3354 Wh
energy-empty:0 Wh
energy-full: 31,7034 Wh
energy-full-design:  36,708 Wh
energy-rate: 3,477 W
voltage: 12,72 V
time to full:23,6 minutes
percentage:  98%
capacity:86,3665%
technology:  lithium-ion
icon-name:  'battery-full-charging-symbolic'
  History (charge):
1537999317  98,000  charging
  History (rate):
1537999319  3,477   charging
1537999317  3,488   charging
1537999247  3,614   charging
1537999236  3,637   charging
1537999226  3,659   charging
1537999215  3,682   charging

Device: /org/freedesktop/UPower/devices/DisplayDevice
  power supply: yes
  updated:  jeu. 27 sept. 2018 00:01:59 CEST (8 seconds ago)
  has history:  no
  has statistics:   no
  battery
present: yes
state:   charging
warning-level:   none
energy:  30,3354 Wh
energy-full: 31,7034 Wh
energy-rate: 3,477 W
time to full:23,6 minutes
percentage:  98%
icon-name:  'battery-full-charging-symbolic'

Daemon:
  daemon-version:  0.99.8
  on-battery:  no
  lid-is-closed:   no
  lid-is-present:  yes
  critical-action: HybridSleep

-

acpci -i

Battery 0: Charging, 98%, 00:09:24 until charged
Battery 0: design capacity 3220 mAh, last full capacity 2715 mAh = 84%


And some other post of people experiencing the same problem here: 
https://ubuntuforums.org/showthread.php?t=2335882
https://forum.antergos.com/topic/9093/kde-battery-not-present

Marco Richetta seems to have problem with upower, independent of this bug.

The applet not detecting battery only affects kde, other desktops seem to work
fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Arnaud]

https://bugs.kde.org/show_bug.cgi?id=350365

Arnaud  changed:

   What|Removed |Added

 CC||arnaud.leh...@gmail.com

--- Comment #31 from Arnaud  ---
I'm also having this problem, same as everyone :

-- 
You are receiving this mail because:
You are the assignee for the bug.

D14068: add -P switch to one-shot redshift call

[David Edmundson]

davidedmundson added a comment.


  > since 1.12.
  
  what happens to users on older versions?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat, #plasma, romangg, martinkostolny
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[David Edmundson]

davidedmundson added a comment.


  Commits really benefit from a bit more description. Reviewers don't have the 
same context you had in your head when you wrote it.

INLINE COMMENTS

> main.qml:111
>  Plasmoid.compactRepresentation: Grid {
> -readonly property int buttonSize: root.isVertical ? width : height
> +readonly property int buttonSize: root.isVertical ? Math.min(width, 
> (height * 2) + spacer.height) : Math.min(height, (width - spacer.width) / 2)
>  

Please explain the rationale behind this.

Especially the spacer.width being divided by 2 in the second part of the 
statement.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart