D16856: [comic] Sync configuration on write

[Anthony Fieroni]

anthonyfieroni updated this revision to Diff 45556.
anthonyfieroni added a comment.


  Better not change data engine

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16856?vs=45396=45556

REVISION DETAIL
  https://phabricator.kde.org/D16856

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comicupdater.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16898: [kcm] Remove profiles code

[Aleix Pol Gonzalez]

apol added subscribers: dvratil, apol.
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  RIP
  
  I see that @dvratil removed it at some point, maybe he remembers why it's not 
necessary?

REPOSITORY
  R104 KScreen

BRANCH
  removeProfilesCode

REVISION DETAIL
  https://phabricator.kde.org/D16898

To: romangg, #plasma, apol
Cc: apol, dvratil, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

[Nathaniel Graham]

ngraham updated this revision to Diff 4.
ngraham added a comment.


  Make sure extraWidth stuff still works properly

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16901?vs=45525=4

BRANCH
  more-room-for-labels-with-tiny-icons (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D16901

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16914: [Runners KCM] Focus the search field by default

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

TEST PLAN
  Start krunner, click on the parameter button on the left.
  In the window opening, the plugin search box should have the
  focus.
  
  Depends on D16913 
  
  BUG: 399516

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_focussearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16914

AFFECTED FILES
  CMakeLists.txt
  kcms/runners/kcm.cpp

To: thsurrel, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16888: Recreate interrupted download when it is resumed

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:2b15d99afd53: Recreate interrupted download when it is 
resumed (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16888?vs=45495=45539

REVISION DETAIL
  https://phabricator.kde.org/D16888

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16888: Recreate interrupted download when it is resumed

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Gave it a quick test as well, seems to work fine.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16888

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16906: Update about KDE text

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This reflects the changes done to KAboutDialog

TEST PLAN
  - New text shows up, the three links open the correct pages

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16906

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/options.html

To: broulik, #plasma, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16690: [Baloo Runner] Filter duplicates and prefer specific type matches

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:867c864e7c07: [Baloo Runner] Filter duplicates and prefer 
specific type matches (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16690?vs=44927=45537

REVISION DETAIL
  https://phabricator.kde.org/D16690

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h

To: broulik, #plasma, ngraham, sitter, michaelh, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16887: Send all active downloads on load

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:7bb04c749f67: Send all active downloads on load (authored 
by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16887?vs=45494=45536

REVISION DETAIL
  https://phabricator.kde.org/D16887

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16889: Listen to KDE Connect device signals

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> extension.js:156
> +if (chrome.runtime.lastError) {
> +// failed to create entry, most likely visibility change before 
> device added was processed
> +return;

Can you explain how that makes the creation fail?

> kdeconnectplugin.cpp:155
> +{
> +if (!m_devices.contains(deviceId)) {
> +return;

You could just do

  if(m_devices.removeOne(deviceId))
  sendData(...)

if the order of removing and sendData is not important.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16889

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16890: [systemtray] Keep config entries after modifying

[Kai Uwe Broulik]

broulik added a comment.


  I think that's a Qt bug, i did an investigation in another systray bug report 
but can't find it right now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16901

To: ngraham, #plasma, #vdg, hein
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

[Kai Uwe Broulik]

broulik added a comment.


  Can you check the `extraWidth` stuff still works? Ie. Whether left and right 
padding of screen is equal, since you `Math.max` the entire thing to icon size

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16901

To: ngraham, #plasma, #vdg, hein
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Nathaniel Graham]

ngraham added a comment.


  In D16897#359911 , @graesslin 
wrote:
  
  > In D16897#359900 , @ngraham 
wrote:
  >
  > > Good point, guys. I'll start with `StandardKey.Close` for now and see 
about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's 
codebase!).
  >
  >
  > I would prefer if the standardKey.Close is not used. This is an 
in-application shortcut used by Qt, but not necessarily by GTK or other 
toolkits. It is not used by the window manager. Please don't mix in-application 
shortcuts and global shortcuts. It would be confusing to users.
  
  
  Isn't the in-application shortcut for window closing exactly what the user 
would expect? From another perspective, the implementation of this feature in 
other window managers and other platforms (macOS, GNOME) uses the same 
window-closing shortcut in the switcher, so it seems that this is what is 
expected and common.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Martin Flöser]

graesslin added a comment.


  In D16897#359900 , @ngraham wrote:
  
  > Good point, guys. I'll start with `StandardKey.Close` for now and see about 
making the KWin changes later (I'll admit I'm a bit intimidated by KWin's 
codebase!).
  
  
  I would prefer if the standardKey.Close is not used. This is an 
in-application shortcut used by Qt, but not necessarily by GTK or other 
toolkits. It is not used by the window manager. Please don't mix in-application 
shortcuts and global shortcuts. It would be confusing to users.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Good point, guys. I'll start with `StandardKey.Close` for now and see about 
making the KWin changes later (I'll admit I'm a bit intimidated by KWin's 
codebase!).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16859: Rename config loading function

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:af6da1146ef6: Rename config loading function (authored by 
romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16859?vs=45407=45528

REVISION DETAIL
  https://phabricator.kde.org/D16859

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements a minimum width when using on-the-desktop icon view to 
make sure that the label is never uselessly short when using very small icons.
  
  BUG: 379432
  FIXED-IN: 5.12.8

TEST PLAN
  Smallest icon size, before:
  
  Smallest icon size, after:
  
  No change for sizes corresponding to the fourth tick on the slider and beyond

REPOSITORY
  R119 Plasma Desktop

BRANCH
  more-room-for-labels-with-tiny-icons (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D16901

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Martin Flöser]

graesslin added a comment.


  I agree with David: please don't hardcode the key. Please don't use "W" - it 
has no meaning in a window manager, it's just the shortcut in some 
applications, others use Ctrl+Q and localized it could be something completely 
different.
  
  I suggest to implement this in KWin and intercept the shortcut hold by kwin - 
if it matches close the window.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[David Edmundson]

davidedmundson added a comment.


  You can do control+w with
  
  if (event.matches(StandardKey.Close)) {
  }
  
  alt+f4 would need some exposing on the kwin side as that's not a "standard 
key" exposed via the QPT

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16886: [windowswitcher] Implement keyboard navigation

[David Edmundson]

davidedmundson added subscribers: Zren, davidedmundson.
davidedmundson added a comment.


  In the previous patch @zren said:
  
  > "Breeze (Look and Feel)
  > 
  >   Works?! I guess the ListView handles the key input?"
  
  and the comments in this patch are copy pasted from the kdeplasma-addons ones 
from back when we needed the hack.
  
  Are you sure it's needed?
  /If/ focus is wrong, then we're going to have a problem with the 
accessibility reader that needs fixing regardless.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: davidedmundson, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  you can't hardcode the key combos

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg
Cc: abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16900: Don't use an icon that is only supposed for plasmoids

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: andreask, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16900

AFFECTED FILES
  notifier/plasmoid/metadata.desktop

To: apol, andreask, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16898: [kcm] Remove profiles code

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  This code seems to be unused for a long time or was never used at all.
  Introduced in 2013 there were no substantial commits to it afterwards,
  nor is the functionality exposed to the Ui.

TEST PLAN
  Compiles.

REPOSITORY
  R104 KScreen

BRANCH
  removeProfilesCode

REVISION DETAIL
  https://phabricator.kde.org/D16898

AFFECTED FILES
  kcm/src/profilesmodel.cpp
  kcm/src/profilesmodel.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Nathaniel Graham]

ngraham added a subscriber: Zren.
ngraham added a comment.


  I'm also having trouble getting the same approach to work for the default 
Breeze switcher, which lives in plasma-workspace. Keyboard navigation with the 
arrow keys works, so the event handler is functional. But I can't seem to 
target the model for some reason.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Implements the ability to close windows from the various non-default window 
switchers using the [F4] or [w] keys.
  
  CCBUG: 308331

TEST PLAN
  Apply patch, Alt+tab to activate window switcher, hit [F4] or {w}. The 
current window closes.
  
  This works for all but the "Informative" switcher, which is still broken for 
all keyboard navigation (unrelated to this patch; once that's fixed, this will 
start working).

REPOSITORY
  R114 Plasma Addons

BRANCH
  close-windows-from-windowswitcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16897

AFFECTED FILES
  windowswitchers/big_icons/contents/ui/main.qml
  windowswitchers/compact/contents/ui/main.qml
  windowswitchers/informative/contents/ui/main.qml
  windowswitchers/present_windows/contents/ui/main.qml
  windowswitchers/small_icons/contents/ui/main.qml
  windowswitchers/text/contents/ui/main.qml
  windowswitchers/thumbnails/contents/ui/main.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 116 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/116/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 15 Nov 2018 14:02:32 +
 Build duration:
3 min 50 sec and counting

D16886: [windowswitcher] Implement keyboard navigation

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4d52641657d6: [windowswitcher] Implement keyboard 
navigation (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16886?vs=45493=45517

REVISION DETAIL
  https://phabricator.kde.org/D16886

AFFECTED FILES
  lookandfeel/contents/windowswitcher/WindowSwitcher.qml

To: ngraham, #plasma, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16890: [systemtray] Keep config entries after modifying

[Anthony Fieroni]

anthonyfieroni added a comment.


  Weird. If configuration window stays open, clicks in systray work correct, 
when it's dismissed clicks are incorrect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16891: [logout-greeter] Use correct enum for logout hint to QML

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:02541b8af06e: [logout-greeter] Use correct enum for 
logout hint to QML (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16891?vs=45501=45508

REVISION DETAIL
  https://phabricator.kde.org/D16891

AFFECTED FILES
  logout-greeter/greeter.cpp

To: davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 115 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/115/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 15 Nov 2018 11:34:32 +
 Build duration:
1.8 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on FreeBSD Builder 3 in /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/plasma-workspace > git init /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/plasma-workspace > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2016)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1735)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:420)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:629)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 3		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor574.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy80.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D16890: [systemtray] Keep config entries after modifying

[Anthony Fieroni]

anthonyfieroni updated this revision to Diff 45502.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16890?vs=45500=45502

REVISION DETAIL
  https://phabricator.kde.org/D16890

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: anthonyfieroni, #plasma, broulik, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16889: Listen to KDE Connect device signals

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kdeconnectplugin.cpp:185
> +msg.setArguments({url});
> +QDBusConnection::sessionBus().call(msg, QDBus::NoBlock);
> +}

Never saw this kind of change, what's the difference?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16889

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16889: Listen to KDE Connect device signals

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM the KDE Connect parts.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16889

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16891: [logout-greeter] Use correct enum for logout hint to QMQL.

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Libkworkspace has two duplicate enum values for the same thing, with one
  marked as "//FIXME remove". My patchset is trying to kill that enum, but
  we still use it for backwards compatibility in the QML L
  
  In my split, I used the wrong one.
  
  BUG: 401046

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16891

AFFECTED FILES
  logout-greeter/greeter.cpp

To: davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16890: [systemtray] Keep config entries after modifying

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  It still has one problem, after configuration is changed in Entries MouseArea 
index is invalid, i can't understand why, @broulik ?
  
  BUG: 390890

TEST PLAN
  1. Right button on systemtray
  2. Check / uncheck extra imtem
  3. Click on Entries
  4. Show / hidden some of them
  5. Return to General
  
  again 2
  again 4
  
  All good, but after close configuration dialog clicking on item in systray is 
an invalid index.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/main.qml

To: anthonyfieroni, #plasma, broulik, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart