D17598: Improve "No internet connection!" error message

[Pino Toscano]

pino added a comment.


  The error message is still not optimal (contractions, not correct spelling of 
"the Internet", etc).
  "Could not load any application; please verify your network connectivity."

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purpose more clear

[Andras Mantia]

amantia added a comment.


  I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog 
shows a question that can be answered with Yes or No. 
  See also the HIG https://hig.kde.org/components/assistance/message.html
  
  > - Apply confirmation button labels when further interaction is required:
  > 
  >   Use buttons which match the type of statement or question made in the 
warning or error message. **For example, do no ask a Yes/No question but then 
provide OK/Cancel buttons.**
  > - Apply confirmation button labels when the user must choose between two 
actions to continue:
  > 
  >   Use descriptive button labels instead of standard Yes/No or OK/Cancel 
buttons. For example, if the user must choose to continue or stop an action, 
provide the buttons “Continue” and “Cancel”.
  
  I cannot easily do the second (and don't want to with this patch).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein added a comment.


  Apply button working for me: https://youtu.be/LvMhpCLxdWY

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski, 
ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein added a comment.


  In D14542#376846 , @zzag wrote:
  
  > Hmm, I'm no longer able to save new settings, i.e. if any option has been 
changed, the Apply button is still not enabled.
  
  
  Can you give me more specific steps? Because I can't reproduce here ...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski, 
ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, VDG, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Old message was a bit unclear. Hopefully this is better.

TEST PLAN
  Turn off internet connection and launch Discover

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, #vdg, apol
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d75a37b58992: [Folder View] make file context menu 
consistent with Dolphin's (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17393?vs=47003&id=47609

REVISION DETAIL
  https://phabricator.kde.org/D17393

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, #plasma, hein, #vdg, ndavis
Cc: ndavis, mart, janpr, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

ngraham added a comment.


  Thanks Eike! :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein, #vdg, ndavis
Cc: ndavis, mart, janpr, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17393: [Folder View] make file context menu consistent with Dolphin's

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Alrighty, I'll go in with the majority opinion then. Consistency is certainly 
an improvement by itself. Go go go!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein, #vdg, ndavis
Cc: ndavis, mart, janpr, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:185c0d38381c: [Panel Edit Mode] Change screen edge button 
hover cursor, add icons to screen… (authored by GB_2, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47058&id=47603

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, 
plasma-devel, #plasma, squeakypancakes, alexde, IohannesPetros, GB_2, ragreen, 
Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17533: Make the button's purpose more clear

[Nathaniel Graham]

ngraham added a comment.


  In D17533#376922 , @amantia wrote:
  
  > You can't change to Yes/No (that was my first try), as the question might 
be one of the following:
  >
  > - "Activate foo ?"
  > - "Deactivate foo?"
  > - "Activate foo and deactivate bar?"
  
  
  In that case, OK/Cancel would at least be better than Yes/No.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17592: Introduce a DelegateRecycler attached object

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It allows us to reach the context of the delegate from our delegate component.

TEST PLAN
  Now I can call `highlighted: 
Kirigami.DelegateRecycler.recycler.ListView.isCurrentItem`.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17592

AFFECTED FILES
  src/delegaterecycler.cpp
  src/delegaterecycler.h
  src/kirigamiplugin.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17584

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17591: Make AbstractCard.background react to AbstractCard.highlighted

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise we'd just see no change

TEST PLAN
  Keyboard navigation in Discover has feedback again

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17591

AFFECTED FILES
  src/controls/AbstractCard.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

[Björn Feber]

GB_2 requested review of this revision.
GB_2 added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:58
> This doesn't make sense..
> 
> We're re-evaulating because hasElement might have changed when switching 
> themes.

So just remove the line?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17321

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

[Andres Betts]

abetts added a comment.


  Thanks Dave!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17321

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  If Nate and Andy say to use this icon, go for it.
  
  One code change

INLINE COMMENTS

> main.qml:58
>  imagePath: "widgets/configuration-icons"
> -onRepaintNeeded: toolBoxIcon.elementId = 
> iconSvg.hasElement("menu") ? "menu" : "configure"
> +onRepaintNeeded: toolBoxIcon.elementId = "configure"
>  }

This doesn't make sense..

We're re-evaulating because hasElement might have changed when switching themes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17321

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

ngraham added a comment.


  Since this is VDG-accepted and most of the comments seem to be slightly to 
strongly positive so far, if I don't get a formal Changes Requested status from 
someone in #plasma , I'll land on 
December 19th (or earlier if I get a formal Accept status instead).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein, #vdg, ndavis
Cc: ndavis, mart, janpr, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17533: Make the button's purpose more clear

[Andras Mantia]

amantia updated this revision to Diff 47590.
amantia added a comment.


  Improve dialog title as well

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17533?vs=47441&id=47590

BRANCH
  accesbility_dialog_improvement

REVISION DETAIL
  https://phabricator.kde.org/D17533

AFFECTED FILES
  kaccess/kaccess.cpp
  kaccess/kaccess.h
  kaccess/main.cpp

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  Exactly, perfect!

REPOSITORY
  R169 Kirigami

BRANCH
  cosa

REVISION DETAIL
  https://phabricator.kde.org/D17584

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  cosa

REVISION DETAIL
  https://phabricator.kde.org/D17584

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17583: Simplify code in MnemonicAttached

[Aleix Pol Gonzalez]

apol updated this revision to Diff 47579.
apol added a comment.


  Tune in

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17583?vs=47578&id=47579

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17583

AFFECTED FILES
  src/mnemonicattached.cpp
  src/mnemonicattached.h

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17583: Simplify code in MnemonicAttached

[Aleix Pol Gonzalez]

apol updated this revision to Diff 47578.
apol added a comment.


  Polish

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17583?vs=47577&id=47578

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17583

AFFECTED FILES
  src/mnemonicattached.cpp
  src/mnemonicattached.h

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17583: Simplify code in MnemonicAttached

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Having a map of an object into a value is equivalent to having this
  value as an attribute.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17583

AFFECTED FILES
  src/mnemonicattached.cpp
  src/mnemonicattached.h

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17393: [Folder View] make file context menu consistent with Dolphin's

[Noah Davis]

ndavis added a comment.


  +1 to making the menus the same.
  
  In D17393#373155 , @hein wrote:
  
  > Can we patch Dolphin instead? I think the order there is pretty bad, with 
weird random dividers etc. (From the screenshots in the original user bug.) I 
prefer FV's.
  
  
  To me, the folder view menu is the one with seemingly random dividers, and a 
lack of dividers. In the dolphin menu, I see a clear progression:
  
  1. Open section
  2. Clipboard section
  3. options that can affect other programs (missing files due to removal or 
name change)
- It can be argued that Cut would belong here and I don't think it would be 
bad if clipboard actions, rename and delete were in the same section.
  4. Misc actions
- Better organization might be a good idea, but that's out of scope here
  5. Properties
- this option is always kind of special

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein, #vdg
Cc: ndavis, mart, janpr, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17393: [Folder View] make file context menu consistent with Dolphin's

[Marco Martin]

mart added a comment.


  important is that "open with $default" and "open with..." are grouped 
together.
  apart from that i don't have much preferences for one or the other

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: mart, janpr, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17448: Revamp README

[Aditya Mehra]

Aiix accepted this revision.
Aiix added a comment.
This revision is now accepted and ready to land.


  Looks good to me, Thanks :)

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D17448

To: marcinse, Aiix
Cc: plasma-devel, GB_2, ragreen, jackyalcine, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, clivej, abetts, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: abetts, GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, sebas, apol, 
mbohlender, mart

D17533: Make the button's purpose more clear

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  While we're here, let's change yes to Accept and No to Cancel. Also, the 
dialog's title should probably be something more descriptive than "Warning".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purpose more clear

[Andras Mantia]

amantia added a comment.


  You can't change to Yes/No (that was my first try), as the question might be 
one of the following:
  
  - "Activate foo ?"
  - "Deactivate foo?"
  - "Activate foo and deactivate bar?"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17571: Fix pixmap scaling on HiDPI screens

[David Edmundson]

davidedmundson added a comment.


  > Aren't the charts and process list handled by libksysguard instead of this 
repository?
  
  This flag affects the process not where the code comes from.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D17571

To: emateli, mlaurent, davidedmundson, broulik
Cc: broulik, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17561: Fix memory leak in notifications applet if only tracking jobs

[David Edmundson]

davidedmundson updated this revision to Diff 47565.
davidedmundson added a comment.


  cover even more cases

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17561?vs=47517&id=47565

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17561

AFFECTED FILES
  applets/notifications/package/contents/ui/Jobs.qml

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:743e5583ced0: Make Status and Notification popup 
consistent with others. (authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47562&id=47564

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:998d1a02c670: Remove period ( . ) character from the end 
(authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17574?vs=47551&id=47563

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham added a comment.


  could I go ahead pushing it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[loh tar]

loh.tar added a comment.


  Two more cents.
  
  > I feel that all the items are simply too close to the left edge.
  
  I agree but currently fit the look with all other applets (at least have 
there, Volume/Clipboard/Bluetooth). Perhaps could that changed somehow globally?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham updated this revision to Diff 47562.
shubham added a comment.


  Use units.smallSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47552&id=47562

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17533: Make the button's purprose more clear

[Andras Mantia]

amantia added a comment.


  How it looked before:  F6476429: new_dialog.jpg 

  How it looks now:  F6476432: new_dialog.jpg 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag added a comment.


  In D14542#371677 , @zzag wrote:
  
  > - if any virtual desktop is removed, then System Settings window will be 
sent to the last virtual desktop.
  
  
  Should be addressed by D17576 .

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski, 
ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag added a comment.


  Hmm, I'm no longer able to save new settings, i.e. if any option has been 
changed, the Apply button is still not enabled.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski, 
ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17347: Translate color scheme names

[Kai Uwe Broulik]

broulik added a comment.


  It seems most codepaths assume the colorscheme names are never translated...
  `KColorSchemeManager` uses the `Qt::DisplayRole` for mapping. The 
`Qt::UserRole` contains the full path to the scheme but it never stores just 
the untranslated name.
  Affects Krita, Kate, etc, which lost my "Honeycomb" colorscheme now that it's 
called "Honigwabe". Setting it again works but changing languages causes the 
mapping to fail.
  (See, that's why I didn't put it in stable branches :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17347

To: broulik, #plasma, lueck, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:98
>  topMargin: hiddenItemsView.visible ? units.smallSpacing : 0
> -leftMargin: hiddenItemsView.iconColumnWidth + units.largeSpacing;
> +leftMargin: 5
>  }

Please don't use hard coded margins, use smallSpacing instead.

See https://hig.kde.org/layout/units.html

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17571: Fix pixmap scaling on HiDPI screens

[Emirald Mateli]

emateli added a comment.


  The only difference in the process list is that the plasmashell icon becomes 
smaller. Aren't the charts and process list handled by libksysguard instead of 
this repository?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D17571

To: emateli, mlaurent, davidedmundson, broulik
Cc: broulik, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Shubham]

shubham added a comment.


  my battery drained in "After" image even though it was charging : )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham updated this revision to Diff 47552.
shubham edited the summary of this revision.
shubham removed a reviewer: hein.
shubham added a comment.


  use 5px margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47497&id=47552

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart, hein
Cc: abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Björn Feber]

GB_2 added a comment.


  The two images need to be swapped.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17574: Remove period ( . ) character from the end

[Shubham]

shubham created this revision.
shubham added reviewers: Plasma, VDG.
shubham added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Before:
  F6476200: 1.png 
  
  After:
  F6476201: 2.png 

TEST PLAN
  Hover over battery monitor in system tray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg
Cc: plasma-devel, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17571: Fix pixmap scaling on HiDPI screens

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  I didnt push D14490  yet as there are 
issues.
  For instance, `KWindowSystem::icon` returns incorrect dpr for pixmaps, so the 
application icons are glitchy: 
  F6476110: Screenshot_20181214_093032.png 

  I didn't notice any painting issues in the plotters so far at least

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D17571

To: emateli, mlaurent, davidedmundson, broulik
Cc: broulik, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart