D17706: Fix lock screen focus

[Andrey Bychkov]

andreyby added a comment.


  mrd...@altlinux.org

REVISION DETAIL
  https://phabricator.kde.org/D17706

To: andreyby, davidedmundson
Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18831: [sddm-theme] Use more precise labels for "Different User"

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bdd05f27cf5: [sddm-theme] Use more precise labels for 
Different User (authored by filipf, committed by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18831?vs=51137=51142

REVISION DETAIL
  https://phabricator.kde.org/D18831

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, #plasma, #vdg, hein
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Use more precise labels for "Different User"

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  All right, let's do it!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

To: filipf, ngraham, #plasma, #vdg, hein
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Use more precise labels for "Different User"

[Krešimir Čohar]

rooty added a comment.


  perfect I think it's ready to land now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

To: filipf, ngraham, #plasma, #vdg, hein
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Use more precise labels for "Different User"

[Filip Fila]

filipf updated this revision to Diff 51137.
filipf added a comment.


  use title case for the second label

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18831?vs=51136=51137

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, #plasma, #vdg, hein
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Use more precise labels for "Different User"

[Krešimir Čohar]

rooty added a comment.


  Also I think the title of the log in by typing screen should follow title 
capitalization, hence:
  "Type in Username and Password"

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

To: filipf, ngraham, #plasma, #vdg, hein
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Rename "Different User" to "Input User"

[Filip Fila]

filipf updated this revision to Diff 51136.
filipf added a comment.


  Better label, change the Type User screen label as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18831?vs=51135=51136

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, #plasma, #vdg
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Rename "Different User" to "Input User"

[Krešimir Čohar]

rooty added a comment.


  In D18831#407445 , @ngraham wrote:
  
  > "Input" isn't a very common verb to start a sentence with in English. How 
about just "Type User" or "Type Username"
  
  
  Type User might be better (shorter, doesn't spill over into a new line)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18831

To: filipf, ngraham, #plasma, #vdg
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Rename "Different User" to "Input User"

[Nathaniel Graham]

ngraham added a comment.


  "Input" isn't a very common verb to start a sentence with in English. How 
about just "Type User" or "Type Username"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18831

To: filipf, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18831: [sddm-theme] Rename "Different User" to "Input User"

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The "Different User" action button label is wrong. The respectivebutton 
switches to
  a screen where usernames are manually inputed. The new label reflects this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18831

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18823: Create a dynamic way to provide component information

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:d780fc1db376: Create a dynamic way to provide component 
information (authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18823?vs=51124=51133

REVISION DETAIL
  https://phabricator.kde.org/D18823

AFFECTED FILES
  src/CMakeLists.txt
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/CardsLayoutGallery.qml
  src/data/contents/ui/gallery/DrawerGallery.qml
  src/data/contents/ui/gallery/FormLayoutGallery.qml
  src/data/contents/ui/gallery/OverlaySheetGallery.qml
  src/data/contents/ui/gallery/SelectionControlsGallery.qml
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json
  src/main.cpp
  src/resources.qrc

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This is a huge improvement over what we have right now. Very nice job!
  
  A few behavioral issues:
  
  - After removing a folder, the wallpaper grid should update immediately to 
reflect that
  - The individual elements in the wallpaper grid now can't be individually 
chosen as wallpapers, so there's no need for them to be selectable anymore
  
  And a design issue: now that it's not taking up the full width, the folder 
list manages to feel space-inefficient while also eliding the text most of the 
time. And there's not so much room left for the wallpaper grid so it feels a 
bit scrunched, especially in System Settings at the default window size:
  
  F6598236: A bit scrunched.png 
  
  I would recommend showing just the folder name, not the full path. Then you 
can reduce its width a bit, so that it's say, a maximum of 25% of the total 
layout width. Right now it's more like 33-40% of the total width most of the 
time which feels too wide.
  
  Ideas for further improvement (not necessary in this patch, but nice to have)
  
  - The Remove button should show up on hover rathet than being always visible. 
If you use a Kirigami `SwipeListItem` instead of a `BasicListItem`, this will 
happen automatically if you implement the remove button as an action. Here is 
an example: 
https://cgit.kde.org/discover.git/tree/discover/qml/SourcesPage.qml#n160
  - It might be nice to add an "Open Containing Folder" action to the folder 
list items, too

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18823: Create a dynamic way to provide component information

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In some components, an action is offered that provides descriptive info about 
the component as well as links to the source code and the hig website. All this 
info has been gathered into a json file. The InfoData plugin has been created 
to serve the data to the QML code.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D18823

AFFECTED FILES
  src/CMakeLists.txt
  src/InfoData.cpp
  src/InfoData.h
  src/data/contents/ui/gallery/CardsLayoutGallery.qml
  src/data/contents/ui/gallery/DrawerGallery.qml
  src/data/contents/ui/gallery/FormLayoutGallery.qml
  src/data/contents/ui/gallery/OverlaySheetGallery.qml
  src/data/contents/ui/gallery/SelectionControlsGallery.qml
  src/data/contents/ui/gallery/components/InfoSheet.qml
  src/data/info-data.json
  src/main.cpp
  src/resources.qrc

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

[Filip Fila]

filipf added a comment.


  Excellent, thanks for the clarification. Next step is basically what @rooty 
said then, but I'd try to some more in (not just 5-6).

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18078

To: filipf, #plasma, #vdg, ngraham
Cc: jriddell, lydia, davidedmundson, abetts, mart, rooty, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  Also It looks like this now because of D18737 

  F6597907: Screenshot_20190207_192144.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51120.
davidre added a comment.


  - remove checkbox stuff

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51088=51120

BRANCH
  slideshow-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18785: Use different Font Management KCM "All Fonts" icon

[Björn Feber]

GB_2 updated this revision to Diff 51115.
GB_2 added a comment.


  Use new icon "font"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18785?vs=51032=51115

BRANCH
  use-different-font-management-all-fonts-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18785

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/GroupList.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  In D18809#407144 , @ngraham wrote:
  
  > This looks great!
  >
  > I would recommend removing the checkbox feature for now, since that's 
really a separate thing from the UI overhaul. Then we can get the UI overhaul 
in first and work on the checkbox part after that. Does that sound like a plan?
  
  
  Sounds like a good plan!

INLINE COMMENTS

> davidedmundson wrote in image.cpp:909
> You update m_uncheckedSlides  but you're not updating m_slideshowBackgrounds 
> so it does nothing till you restart

Thanks for spotting this, will try testing this.

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Tranter Madi]

trmdi added a comment.


  @davidedmundson
  
  Nice approach.
  I don't really understand the root cause though. So, could you please do it 
for me?
  
  Thank you!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Anthony Fieroni]

anthonyfieroni added a comment.


  Ok, so @trmdi you can apply exactly David suggest and discard D18804 
, i've test it and it works. Push it in 
5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as 
LTS version.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > I really don't know that sharing model between contexts cause a such 
behavior.
  
  Sorry, I used the wrong word. Sharing contexts is fine. Sharing across 
engines is problematic.
  
  QQmlData is shared between engines, but the relevant QObjectWrapper is
  not. Since 749a7212e903d8e8c6f256edb1836b9449cc7fe1 when a
  QObjectWrapper is deleted it resets the shared QQmlData propertyCache.
  
  Any code path on the first engine that use the propertycache need to rebuild 
it
  
  (In an ideal world we wouldn't have 2 engines, but that's a whole different 
topic)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

[Nathaniel Graham]

ngraham added a comment.


  @andreyby, can you let us know your email address so we can land this with 
correct authorship information? Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D17706

To: andreyby, davidedmundson
Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

[Thomas Pfeiffer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:1dc931ec70c5: Updated documentation (mention of 
QQuickControls, link to HIG, IRC channel… (authored by colomar).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18817?vs=51104=51107

REVISION DETAIL
  https://phabricator.kde.org/D18817

AFFECTED FILES
  Mainpage.dox
  metainfo.yaml

To: colomar, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18815: Sort setting grid views alphabetically

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6835000906d3: Sort setting grid views alphabetically 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18815?vs=51101=51106

REVISION DETAIL
  https://phabricator.kde.org/D18815

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/icons/iconsmodel.cpp
  kcms/ksplash/kcm.cpp
  kcms/lookandfeel/kcm.cpp

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

[Thomas Pfeiffer]

colomar created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
colomar requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  update-docs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18817

AFFECTED FILES
  Mainpage.dox
  metainfo.yaml

To: colomar
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

[Jonathan Riddell]

jriddell added a comment.


  > We need to ask Unsplash and/or the photographers to release their work into 
the public domain or if it already is in the public domain to ask for 
confirmation.
  
  Yes the copyright holder needs to give permission to copy it under public 
domain, CC0, CC-BY-SA or other suitable free licence.
  
  > Also, how strong of a document is an email confirmation to rooty or me, 
shouldn't it be something more formal?
  
  e-mail is fine if it really is sent from the person or company who hold the 
copyright

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18078

To: filipf, #plasma, #vdg, ngraham
Cc: jriddell, lydia, davidedmundson, abetts, mart, rooty, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> image.cpp:909
> +m_uncheckedSlides = uncheckedSlides;
> +emit uncheckedSlidesChanged();
> +}

You update m_uncheckedSlides  but you're not updating m_slideshowBackgrounds so 
it does nothing till you restart

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  This looks great!
  
  I would recommend removing the checkbox feature for now, since that's really 
a separate thing from the UI overhaul. Then we can get the UI overhaul in first 
and work on the checkbox part after that. Does that sound like a plan?

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  All right, let's go do it. I'll submit the inverse of this patch to 
KInfoCenter, which will make its tooltips consistent with System Settings.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: GB_2, broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Björn Feber]

GB_2 added a comment.


  In D18797#407129 , @ngraham wrote:
  
  > So if this isn't an acceptable solution, then what we need to do is remove 
all the 22px monochrome versions of icons that have colorful 32px-and-larger 
versions.
  
  
  What I proposed in T10413  :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: GB_2, broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Nathaniel Graham]

ngraham added a comment.


  So if this isn't an acceptable solution, then what we need to do is remove 
all the 22px monochrome versions of icons that have colorful 32px-and-larger 
versions.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18815: Sort setting grid views alphabetically

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  The wallpaper chooser needs this too FWIW.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18815

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Kai Uwe Broulik]

broulik added a comment.


  In D18797#407113 , @ngraham wrote:
  
  > Doesn't look terrible with Oxygen icons to me.
  >  F6596120: Screenshot_20190207_074302.png 

  
  
  That compositor icon is out of the question.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Nathaniel Graham]

ngraham added a comment.


  Doesn't look terrible with Oxygen icons to me.
  
  Here'w how it //already// looks in KInfoCenter: F6596110: 
Screenshot_20190207_071231.png 
  
  And in System Settings with this patch:
  F6596111: Screenshot_20190207_074128.png 

  F6596118: Screenshot_20190207_074229.png 

  F6596120: Screenshot_20190207_074302.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18815: Sort setting grid views alphabetically

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 400404
  FIXED-IN: 5.15.1

TEST PLAN
  - Applying icon theme still works
  - Icon preview on hover still works
  - Previewing splash screens still works
  - Applying Plasma themes still works
  - Editing Plasma themes still works
  - Applying look and feel packages still works
  - Previewing look and feel packages still works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18815

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/icons/iconsmodel.cpp
  kcms/ksplash/kcm.cpp
  kcms/lookandfeel/kcm.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo abandoned this revision.
vpilo added a comment.


  In D18814#407090 , @davidedmundson 
wrote:
  
  > What problem are we solving?
  >
  > If someone said "in a shell" I would expect to see a terminal (a shell) 
appear. That's not the case.
  
  
  I thought an inexperienced user could be helped by a more precise outlining 
of the result.
  
  In D18814#407087 , @ngraham wrote:
  
  > By making this label long, the available room for the command itself is 
correspondingly reduced, and this UI already has a limited amount of horizontal 
space. It's probably worse for other languages.
  >
  > I think the current string is fine given that it says "Command line" to the 
left.
  
  
  Fair enough.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  By making this label long, the available room for the command itself is 
correspondingly reduced, and this UI already has a limited amount of horizontal 
space. It's probably worse for other languages.
  
  I think the current string is fine given that it says "Command line" to the 
left.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[David Edmundson]

davidedmundson added a comment.


  What problem are we solving?
  
  If someone said "in a shell" I would expect to see a terminal (a shell) 
appear. That's not the case.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo added a comment.


  In D18814#407083 , @davidedmundson 
wrote:
  
  > It already says "Command line" in the group title on the left a console 
icon and unlike apps has the prefix "Run "
  
  
  "Run %1 in a shell" then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[David Edmundson]

davidedmundson added a comment.


  It already says "Command line" in the group title on the left a console icon 
and unlike apps has the prefix "Run "

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  This makes sure the end result of the consequence of clicking this runner's 
results (running a shell command).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  vpilo/clarifyKRunnerShell (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18814

AFFECTED FILES
  runners/shell/shellrunner.cpp

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.15 tars

[Jonathan Riddell]

Updated tar for better cmake for checking runtime dependencies

plasma-pa;Plasma/5.15;6b6e63a0388f3b0813295b565eda8ea003238589;plasma-pa-5.15.0.tar.xz;190a8d2d64227070082127cde98a2a3a91e30b7b16c8fd705b1e18d3cf13074f

Jonathan

On Thu, 7 Feb 2019 at 11:56, Jonathan Riddell  wrote:
>
> Plasma 5.15 tars are available for now packaging from racnoss
>
> Release is scheduled for Tuesday
>
> http://embra.edinburghlinux.co.uk/~jr/tmp/5.15.0-release-data
>
> Jonathan

D18807: find volume feedback's runtime requirements

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:9cab61adecb1: find volume feedbacks runtime 
requirements (authored by sitter).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18807?vs=51084=51096

REVISION DETAIL
  https://phabricator.kde.org/D18807

AFFECTED FILES
  CMakeLists.txt
  cmake/FindCanberra.cmake
  cmake/FindCanberraPulse.cmake
  cmake/FindSoundThemeFreedesktop.cmake

To: sitter, jriddell
Cc: jriddell, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18807: find volume feedback's runtime requirements

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  works good

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  runtime-deps

REVISION DETAIL
  https://phabricator.kde.org/D18807

To: sitter, jriddell
Cc: jriddell, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18646: [Colors KCM] Add search and filter

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:129
> why do we need a different approach from the way you've done the clear button?

If I could change the left padding of the `ComboBox` button I would have done 
that and placed an icon ontop. However, since it's all painted as a monolith by 
`KQuickStyleItem` I cannot.

It doesn't follow the `padding` properties because it's all derived from the 
`QStyle`, and changing that opens a can of worm imho.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18646

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18807: find volume feedback's runtime requirements

[Jonathan Riddell]

jriddell added a comment.


  I've not checked the logic but adding more cmake runtime dep notices is good 
and can go into Plasma/5.15 branch, I can also update the candidate tar

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D18807

To: sitter
Cc: jriddell, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51088.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51087=51088

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  This shows all the pictures inside the folders added to the Folders list. I 
also tried to make single pictures excludable via a checkbox on the thumbnail. 
This is the first time for me programming with QT/QML/Singals-Slots and I tried 
to use as much existing code as possible. The thumbnail view is the same as for 
single images and I simply subclassed the listmodel. However even if I tried to 
do everything like the code for slidePaths it doesn't work correctly. The 
checking/unchecking of images only applies on restart of plasmashell. Maybe 
it's a single mistake that is easily spotted by a more experienced programmer 
otherwise if the thumbnail view is accepted I can also revert all the checkbox 
stuff.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  slideshow-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/image.cpp
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml

To: davidre
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Anthony Fieroni]

anthonyfieroni added a comment.


  @davidedmundson it works. I really don't know that sharing model between 
contexts cause a such behavior. It's caused by some ref counting ? Did you know 
why, it's internal Qt issue that we can fix or it's expected ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18807: find volume feedback's runtime requirements

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  I'm in a good mood so there's even finders!
  
  - FindCanberra now also sets the version (this is necessary to hint 
directories for the pulse backend lookup)
  - new FindCanberraPulse attempts to find the canberra-pulse backend using 
manually constructed hinting (unfortunately canberra's pc doesn't define the 
dir so we'll basically have to guess)
  - new FindSoundThemeFreedesktop which locates the freedesktop sound theme we 
actually require for the notification sound (since we have no plasma sound 
theme :()
  
  The new finders are put to use to locate and indicate RUNTIME dependencies.
  As with all runtime deps, if the finders should proof unreliable
  CMAKE_DISABLE_FIND_PACKAGE_* can be used to easily silence the warnings.
  They may of course also be safely ignored.
  
  Getting canberra and the sound-theme dependency right has proven a
  challenge to distributions. The problem goes back even to when kde-runtime
  was still a thing and used canberra, and AFAIK wasn't even resolved by
  all distributions by the time plasma 5 came around and kde-runtime killed
  off. So, clearly we need to help things along a bit by properly codifying
  and communicating the requirements here.
  
  The volume feedback is effectively disabled when the pulse backend cannot
  be loaded, and the actual feedback sound is by default coming from the
  default xdg theme which also must be available for the feedback to work.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  runtime-deps

REVISION DETAIL
  https://phabricator.kde.org/D18807

AFFECTED FILES
  CMakeLists.txt
  cmake/FindCanberra.cmake
  cmake/FindCanberraPulse.cmake
  cmake/FindSoundThemeFreedesktop.cmake

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.15 tars

[Jonathan Riddell]

Plasma 5.15 tars are available for now packaging from racnoss

Release is scheduled for Tuesday

http://embra.edinburghlinux.co.uk/~jr/tmp/5.15.0-release-data

Jonathan

D18806: bump to cmake requirement to 3.5

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  kf5 requires 3.5, so plasma-pa effectively does too
  
  (this resolves policy deprecation warnings introduced in 3.3)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  cmake-bump

REVISION DETAIL
  https://phabricator.kde.org/D18806

AFFECTED FILES
  CMakeLists.txt

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/6/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 11:03:38 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 263 lines...]XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/6/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/'BUILD_DISPLAY_NAME= '#6'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.12-6'NODE_LABELS   = 'Docker Swarm-5cc4a43a367b SUSEQt5.12'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.55.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.55.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.55.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.55.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.55.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.55.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.55.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.55.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.55.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.55.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version 

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/2/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 11:03:30 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...]HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-9c672186a365'HOST  = '9c672186a365'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/2/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/'BUILD_DISPLAY_NAME= '#2'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-2'NODE_LABELS   = 'Docker Swarm-9c672186a365 SUSEQt5.12'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.55.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.55.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.55.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.55.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.55.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.55.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.55.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.55.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.55.0") -- Found KF5NotifyConfig: 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/7/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 07 Feb 2019 11:00:22 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 191 lines...]JAVA_HOME = '/usr/local/openjdk8-jre'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/display/redirect'MAIL  = '/var/mail/jenkins'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/7/display/redirect?page=changes'JENKINS_URL   = 'https://build.kde.org/'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.12'HUDSON_HOME   = '/home/production/data'BUILD_ID  = '7'OLDPWD= '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'_ = '/usr/local/bin/java'TERM  = 'su'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.12-7'BUILD_DISPLAY_NAME= '#7'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/7/display/redirect'USER  = 'jenkins'HOME  = '/home/jenkins'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/7/'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/'HUDSON_URL= 'https://build.kde.org/'SHELL = '/usr/local/bin/bash'WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'MM_CHARSET= 'UTF-8'STAGE_NAME= 'Configuring Build'NODE_NAME = 'FreeBSD Builder 1'BLOCKSIZE = 'K'EXECUTOR_NUMBER   = '0'SHLVL = '1'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12"-- The C compiler identification is Clang 6.0.1-- The CXX compiler identification is Clang 6.0.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.55.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.55.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.55.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.55.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.55.0") -- Found KF5KCMUtils: 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/4/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 11:00:22 +
 Build duration:
1 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...]WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'PWD   = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-abddbc23ddad'HOST  = 'abddbc23ddad'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/4/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/'BUILD_DISPLAY_NAME= '#4'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-4'NODE_LABELS   = 'Docker Swarm-abddbc23ddad SUSEQt5.12'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.55.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.55.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.55.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.55.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.55.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.55.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.55.0") -- 

D18805: Workaround for the bug 393630 - SystemTray part

[David Edmundson]

davidedmundson added a comment.


  If the only usage is the SNI model lets just rebuild the model on the 
ConfigEntries side. 
  You're right that sharing objects between contexts seems to cause issues.
  
  It's backed by a datasource so all the heavy operations are already 
implicitly shared.
  
  We should only need
  
  PlasmaCore.DataSource {
 id: statusNotifierSource
 engine: "statusnotifieritem"
 interval: 0
 onSourceAdded: {
connectSource(source)
 }
 Component.onCompleted: {
 connectedSources = sources
 }
   }


PlasmaCore.SortFilterModel {
   id: statusNotifierModel
   sourceModel: PlasmaCore.DataModel {
   dataSource: statusNotifierSource
   }
   }
  
  and then port all the plasmoid.rootItem to just our local statusNotifierModel

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18646: [Colors KCM] Add search and filter

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:129
> +
> +// HACK QQC2 doesn't support icons, so we just tamper with 
> the desktop style ComboBox's background
> +// and inject a nice little filter icon.

why do we need a different approach from the way you've done the clear button?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18646

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Tranter Madi]

trmdi added a comment.


  In D18805#406916 , @anthonyfieroni 
wrote:
  
  > I notice that something with model goes wrong. I've try to fix it in D18249 
 but unfortunately I don't see problem in.
  
  
  Does my workaround also fix your issue ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma and Qt5.12

[Aleix Pol]

On Tue, Feb 5, 2019 at 12:47 PM David Edmundson 
wrote:

> We've agreed that we want Plasma5.16 to depend on Qt5.12.
>
> Are there any objections to switching master to depend on this?
>

+1

D18805: Workaround for the bug 393630 - SystemTray part

[Anthony Fieroni]

anthonyfieroni added a comment.


  I notice that something with model goes wrong. I've try to fix it in D18249 
 but unfortunately I don't see problem in.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Thunderbolt KCM

[Daniel Vrátil]

On Thursday, February 7, 2019 6:22:59 AM CET Rajeesh K V wrote:
> First, is this something you Plasma folks would like to have in regular
> 
> > Plasma
> > releases, or should I just make it an extragear project? If you think it
> > makes
> > sense to include it in Plasma, should it go to plasma-workspace, or should
> > it
> > be a standalone thing, like plasma-nm? It does have a runtime dependency
> > on
> > the Bolt daemon, which people without Thunderbolt in their computer don't
> > really need...
> 
> FWIW, Gnome has great support for Thunderbolt devices (see [1] and blog
> posts therein, and the design [2]). With more and more devices supporting
> Thunderbolt, I suspect it would be great to offer the support in Plasma
> Workspace. Just my 2¢.

The guy who did the Thunderbolt integration for Gnome also wrote and maintains 
the Bolt daemon [0] as a Freedesktop project. My KCM is talking to this daemon 
as well, so we can easily offer the same level of functionality and 
integration as Gnome.

[0] https://gitlab.freedesktop.org/bolt/bolt
> 
> [1]
> https://christian.kellner.me/2018/04/23/the-state-of-thunderbolt-3-in-fedora
> -28/ [2]  https://wiki.gnome.org/Design/Whiteboards/ThunderboltAccess


-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

D18805: Workaround for the bug 393630 - SystemTray part

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - Require: https://phabricator.kde.org/D18804
  
  BUG: 393630

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: trmdi, #plasma, ngraham, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  Oh I understand now. These sizes are user configurable. In that case, I 
suppose it doesn't make sense to add a 24px option and hardcoding is probably 
fine as long as it's compatible with UI scaling for HiDPI screens.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Kai Uwe Broulik]

broulik added a comment.


  What about non-SVG icon themes like Oxygen? They will look awful when 
downscaled from 32 to 24.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart