D18892: Move Look and Feel KCM to top level

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  this seems like a simple enough change and we did agree to put it there, but 
maybe wait for someone else to okay it too before landing it
  
  you got my vote though

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-look-and-feel-kcm-to-top-level (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18892

To: GB_2, #plasma, #vdg, rooty
Cc: rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Moves the LnF KCM from the Workspace Theme category to the top level (to the 
Appearance section), because:
  
  - the KCM affects everything, not just workspace themes
  - then it's faster to discover the KCM and go to it
  
  It won't affect any other KCMs, so this change should be fine.
  Also see T8871 .
  F6604946: Look and Feel KCM in Top Level.png 


TEST PLAN
  Open the system settings.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-look-and-feel-kcm-to-top-level (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18892

AFFECTED FILES
  kcms/lookandfeel/kcm_lookandfeel.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  In D18766#408901 , @ngraham wrote:
  
  > Works for me, no segfault. I don't see any reason why this change could 
cause that. @shubham, does the segfault stop happening when you build Discover 
from source without this change?
  
  
  I should have told that the segafault is unrelated to this change. Even 
without this change, done kind of segafault appears, because of some 
dependencies etc maybe.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Here are a lot of bug reports of Baloo crashing caused by corrupted
  database. This patch provide a button in KCM to quickly delete and rebuild 
index 
  database.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18890

AFFECTED FILES
  kcms/baloo/configwidget.ui
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: guoyunhe
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the look of the Fonts KCM UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Nathaniel Graham]

ngraham added a comment.


  Works for me, no segfault. I don't see any reason why this change could cause 
that. @shubham, does the segfault stop happening when you build Discover from 
source without this change?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18886: Remove unused dependencies

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Probably doesn't make a dent as we still pull in all of KIOWidgets for one 
usage of KRun...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D18886

AFFECTED FILES
  CMakeLists.txt
  host/CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18802: Fix pragma once problem with process class

[patrick j pereira]

patrickelectric added a comment.


  https://stackoverflow.com/questions/17107410/qt-field-has-incomplete-type

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

[David Edmundson]

davidedmundson added a comment.


  Your comment doesn't match what the internet says about "#pragma once" 
(though it is a non-standard and some compilers are weird)
  Two files with the same filename should be included twice.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18861: Improve the look of the Fonts KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 51274.
GB_2 added a comment.


  Show pt after font size and remove seperator in the font preview. Also apply 
the KDE HIG even more.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18861?vs=51213=51274

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/kxftconfig.cpp
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  It compiles but I could not test this. When I run the plasma-discover 
segmentation fault prevails.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham updated this revision to Diff 51272.
shubham added a comment.


  Remove timeout period

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18766?vs=50977=51272

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18802: Fix pragma once problem with process class

[David Edmundson]

davidedmundson added a comment.


  > @mart commit message updated, @alexeymin I believe that you'll find the 
answer for this question in my new commit message :)
  
  It hasn't updated what phab shows.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

[patrick j pereira]

patrickelectric added a comment.


  @mart commit message updated, @alexeymin I believe that you'll find the 
answer for this question in my new commit message :)

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

[patrick j pereira]

patrickelectric updated this revision to Diff 51257.
patrickelectric added a comment.


  Update commit message

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18802?vs=51068=51257

BRANCH
  arcpatch-D18802

REVISION DETAIL
  https://phabricator.kde.org/D18802

AFFECTED FILES
  src/kdbgwin/CMakeLists.txt
  src/kdbgwin/abstract_generator.h
  src/kdbgwin/kdbgwin_process.cpp
  src/kdbgwin/kdbgwin_process.h
  src/kdbgwin/main.cpp
  src/kdbgwin/process.cpp
  src/kdbgwin/process.h

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18801: CMakeLists: Fix bfd.h include path on windows

[patrick j pereira]

patrickelectric updated this revision to Diff 51256.
patrickelectric added a comment.


  update commit message

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18801?vs=51067=51256

BRANCH
  arcpatch-D18801

REVISION DETAIL
  https://phabricator.kde.org/D18801

AFFECTED FILES
  CMakeLists.txt

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18801: CMakeLists: Fix bfd.h include path on windows

[patrick j pereira]

patrickelectric added a comment.


  @mart commit message updated.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18801

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18861: Improve the Fonts KCM UI

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  > Perhaps "Modernize" would be a more specific word than "Improve"?
  
  Not really. There's nothing "modern" about putting an icon on a button.
  
  adding "UI" helps clarify it's not behavioural changes. That'll do.
  
  From a dev POV, ship it. But get a ship it from someone in VDG too for the 
string changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Nathaniel Graham]

ngraham added a comment.


  Perhaps "Modernize" would be a more specific word than "Improve"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  In D18809#408461 , @alexde wrote:
  
  > Great work!
  >
  > Currently you have a very long folder list object. However, in my 
experience most users only have a few folders, where they store their 
wallpapers.
  >  So, what about saving space by positioning the folder list to the right of 
the controls? As we now display only folder names and not whole paths, the 
width should be fine and if you have more than 5 different folders, scrolling 
should be a good option.
  
  
  Do you mean the Controls on the top? I don't know if it's possible because as 
far as I have determined from reading the Code the topmost element that is 
painted by the imagewallpaper-plugin is the "Positioning"-row meaning less 
vertical space. Also if you look at the screenshot ngraham posted you can see 
that it is used in other where the elements are aligned differently and I don't 
know the behaviour then. I guess if the list is right to Positioning and 
"Change every..." this would cause the Positioning row to jump around when the 
mode is switched from single image to slideshow
  
  > Further, if you are about to delete a folder, the images belonging to the 
selected folder, could be highlighted somehow. That way you know what you are 
about to remove without explicitely doing arduous investigation.
  > 
  > What do you think?
  
  I guess this could be done like when you remove single images but we would 
need to think about a way to mark the removed folder in the list. Maybe in 
another patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 added a comment.


  In D18861#408459 , @davidedmundson 
wrote:
  
  > Please use more descriptive messages than "Improve the blahblah". 
  >  Practically every single commit aims to improve the product.
  
  
  I added the word UI, what do you suggest as a title?
  I can't think of anything better, because this changes many different things.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Alex Debus]

alexde added a comment.


  Great work!
  
  Currently you have a very long folder list object. However, in my experience 
most users only have a few folders, where they store their wallpapers.
  So, what about saving space by positioning the folder list to the right of 
the controls? As we now display only folder names and not whole paths, the 
width should be fine and if you have more than 5 different folders, scrolling 
should be a good option.
  
  Further, if you are about to delete a folder, the images belonging to the 
selected folder, could be highlighted somehow. That way you know what you are 
about to remove without explicitely doing arduous investigation.
  
  What do you think?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18861: Improve the Fonts KCM UI

[David Edmundson]

davidedmundson added a comment.


  Please use more descriptive messages than "Improve the blahblah". 
  Practically every single commit aims to improve the product.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18645: BasicListItem: use specified tint color when transparency is 0

[Paweł Wegner]

pwegner added a comment.


  In the current master I get 
`file:///home/lemourin/.qt/5.12.1/gcc_64/qml/org/kde/kirigami.2/private/GlobalDrawerActionItem.qml:39:5:
 Unable to assign [undefined] to QColor`
  (probably related to some other change).
  
  Anyway, tinting can be disabled now after your change.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> ngraham wrote in WallpaperDelegate.qml:40
> I just realized: setting this to false when in slideshow mode is a quick way 
> to make them non-selectable.

That doesn't work - they're still selectable but now we don't get the "open 
containing folder" action on hover

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  I just build the patch in a VM and it works as intended. Sorry I would have 
hoped that it didn't work so that I could investigate your issue.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18645: BasicListItem: use specified tint color when transparency is 0

[Marco Martin]

mart added a comment.


  can you try on kirigami master? i did a similar thing the other day with 
commit 015e1d0ac19e4 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add a TextField component

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> TextField.qml:74
> + */
> +property QtObject rightAction
> +

I would like those to actually be lists as we do have use cases for more than 
one icon
F6603228: Screenshot_20190209_110517.png 

> TextField.qml:94
> +
> +ToolButton {
> +anchors {

this should be a repeater with the toolbutton as aproperty (maybe shouldn't 
even be a toolbotton, as usually they're just icons without any button graphics)

> ognarb wrote in TextField.qml:101
> @mart I'm not sure if it's the right way to convert the icon from the action 
> to the one needed by the toolButton (don't support icon.source)

you can try to use a private class.
PrivateActionToolButton {
 kirigamiAction: the action
 background: null
}
that should already manage everything about the action (and with 
background:null to disable any kind of button background

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18796: [PassiveNotification] Don't start timer until window has focus

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PassiveNotification.qml:65
> +//be working with multiple windows at once
> +timer.running = Qt.binding(function() {
> +return root.Window.active;

this will probably mke the timer always running when the window has focus 
whether or not there is a notificationshown or not?
something like:

Connections {
target:root.Window
onActiveChanged: {
if(root.opacity == 1) {
timer.restart();
}
}
}

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18796

To: ngraham, #kirigami, mart, broulik, apol
Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein

D18640: Reset tooltip delegate label height to defaults

[Marco Martin]

mart added a comment.


  In D18640#403147 , @broulik wrote:
  
  > Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684
  
  
  with 5.12.1 the patch woudn't be necessary anymore?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18640

To: broulik, #plasma, #vdg
Cc: mart, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18640: Reset tooltip delegate label height to defaults

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:227
> If we do end up going with this patch, I'd like to see comments explaining 
> why these are set to `undefined`.

look at https://doc.qt.io/qt-5/properties.html
at the RESET function (basically, properties that provide it, setting to 
undefined will reset to a default)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18640

To: broulik, #plasma, #vdg
Cc: mart, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

[Alexey Min]

alexeymin added a comment.


  Is it because process.h exists somewhere else?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18801: CMakeLists: Fix bfd.h include path on windows

[Marco Martin]

mart added a comment.


  needs longer commit message

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18801

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

[Marco Martin]

mart added a comment.


  needs better commit message

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:d8ce1591e861: Port Cards Grid, Cards List and Inline 
Messages extra information to json-based… (authored by dkardarakos).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18839?vs=51172=51239

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18867: Remove redundant DNS field per bug 403546

[Luca Beltrame]

lbeltrame added a comment.


  Migrating sounds like a good idea. I don't think popups are necessary for 
this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18867

To: andersonbruce, jgrulich
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart