D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 53856.
kossebau added a comment.


  On a second look, of course the normalized margins should be also used for
  the content shown in the widget

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19748?vs=53855=53856

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf planned changes to this revision.
filipf added a comment.


  Unforunately I'm getting bad stepSize behavior with the QQC2.Slider. It's 
reproducible even when keeping the original code and only porting the slider to 
QQC2 (that entails "from", "to", and removing "tickmarks"). If we can't get it 
to work we probably still need to document the issue better.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  The hack for "Air" was especially annoying as it fails for themes inheriting 
"Air" and reusing the widget background, like "Air openSUSE" 
  Before:
  F6690445: Screenshot_20190314_060226.png 

  After:
  F6690447: Screenshot_20190314_062422.png 

  Looks in average better IMHO, and makes things more comparaible, unless one 
is out to know the transparent margin size perhaps.
  Something still strange with "openSUSE dark", but that might be an issue with 
the theme itself.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Instead of a hard-coded hack for a single theme ("Air") to deal with themes
  with large margins, having a generic hack based on heuristics makes
  non-default themes look better in the preview.
  Not using "widgets/panel-background" for "Air" also results in a better
  preview for Air.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  In D19745#430695 , @anthonyfieroni 
wrote:
  
  > Video or screenshot will be helpful.
  
  
  Here they are, "debug" mode via colored rectangles with `anchors.fill: 
parent`.
  
  F6690427: old.mp4 
  F6690428: new.mp4 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf marked an inline comment as done.
filipf added a comment.


  Forgot about that :)
  
  There's still strings to fix in the main qml file for this applet 
(lockout.qml).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19746

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53853.
filipf added a comment.


  suspend -> sleep

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19746?vs=53852=53853

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19746

AFFECTED FILES
  applets/lock_logout/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigGeneral.qml:72
> +id: sleep
> +text: i18n("Suspend")
> +enabled: iconsPage.canSuspend && (checkedOptions > 1 || !checked)

The original was correct :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19746

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19746

AFFECTED FILES
  applets/lock_logout/contents/ui/ConfigGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Anthony Fieroni]

anthonyfieroni added reviewers: VDG, Plasma, broulik.
anthonyfieroni added a comment.


  Video or screenshot will be helpful.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ratijastk requested review of this revision.

REVISION SUMMARY
  System tray widget had the following UX problem:
  Icons are laid out in a Flow QML layout, using minimal amount of
  space, thus not filling the height/width of the task bar. In other
  words: user can only click directly on an icon, not over or under it.
  
  Consider the following scenario:
  
  Given icon size X and task bar of height 1.5 * X located at the bottom;
  User moves pointer down to the limit and tries to click the icon.
  Expected outcome: applet is activated.
  Actual outcome: nothing happens, because icon (together with mouse
  area) floats slightly above the bottom.
  
  Which is inconvenient, especially when most other widgets tend to fill
  up the space.
  
  This patch fixes aforementioned problem by refactoring layouts using
  modern GridLayout, RowLayout et al., so that icons are arranged in
  rows and columns based on their number, and each one fills up its
  cell. I also made a handful of minor internal refactorings and fixes.
  Unfortunately, due to tight coupling, almost all files needed changes
  anyway.
  
  Special note on 'CompactApplet.location': it didn't seem to affect
  anything at all, so removed it.
  
  At the end of the day no visual changes should be noticeable. Layout
  works in both vertical and horizontal form-factor an all four sides of
  the desktop.

TEST PLAN
  Please, check whether 'LayoutMirroring' works properly.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19745

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/StatusNotifierItemModel.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: ratijastk
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19744: [taskmanager] Fix desktop file mapping for some apps

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, hein, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Some apps (e.g. Nautilus) have more complex commands in their desktop file's 
Exec line (e.g. 'nautilus --new-window'). This breaks the cmd to desktop path 
mapping because =~ checks 
  for equality, but 'nautilus' isn't equal to 'nautilus --new-window'. Use ~~ 
instead which checks whether one string is contained in another 
  
(https://techbase.kde.org/Development/Tutorials/Services/Traders#String_Matching_Operators).
  
  The fault can be reproduced with:
  ktraderclient5 --servicetype Application --constraint "exist Exec and 
('nautilus' =~ Exec)" returns no matches
  
  ktraderclient5 --servicetype Application --constraint "exist Exec and 
('nautilus' ~~ Exec)" matches org.gnome.Nautilus
  
  Same applies to Gedit and probably countless other apps.
  
  As a result jumplist actions for Nautilus and Gedit are working in the 
taskmanager now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixnautilus

REVISION DETAIL
  https://phabricator.kde.org/D19744

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:1a171706e7b3: [quickshare] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19664?vs=53824=53843

REVISION DETAIL
  https://phabricator.kde.org/D19664

AFFECTED FILES
  applets/quickshare/plasmoid/contents/config/config.qml
  applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml

To: filipf, #vdg, #plasma, apol, ngraham
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:7437b39cf8d0: [binary-clock] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19669?vs=53821=53842

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08feca1f6859: [appmenu] Port configuration window to QQC2 
and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19670?vs=53823=53841

REVISION DETAIL
  https://phabricator.kde.org/D19670

AFFECTED FILES
  applets/appmenu/package/contents/config/config.qml
  applets/appmenu/package/contents/ui/configGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  ^ Also I may have may the window wider in the pic than it would be normally

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

To: filipf, #vdg, #plasma, apol, ngraham
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1daf42d9d734: [Task Manager] Reorganize and improve 
presentation of context menu (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19606?vs=53832=53833#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19606?vs=53832=53833

REVISION DETAIL
  https://phabricator.kde.org/D19606

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/plugin/backend.cpp

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham updated this revision to Diff 53832.
ngraham added a comment.


  Rebase and fix merge conflicts

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19606?vs=53804=53832

BRANCH
  reorganize-task-manager-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19606

AFFECTED FILES
  applets/kimpanel/backend/scim/main.cpp
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/plugin/backend.cpp
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/hardware/joystick/joywidget.cpp
  kcms/krdb/krdb.cpp

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  In D17073#430519 , @ngraham wrote:
  
  > Just use a real bold if you want it bold. :) In which case, the label below 
it should have normal 100% opacity instead of 75%.
  
  
  +1 for the Bold. In for a penny in for a pound :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  I think it looks fine, actually. Visually, the only change  is centering the 
controls rather than left-aligning them. And the page already has a title.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

To: filipf, #vdg, #plasma, apol, ngraham
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham added a comment.


  Just use a real bold if you want it bold. :) In which case, the label below 
it should have normal 100% opacity instead of 75%.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty requested changes to this revision.
rooty added a comment.
This revision now requires changes to proceed.


  We still need to resolve the DemiBold issue.
  DemiBold fonts either aren't present or don't work in neon. (Or both...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19340: Search new knsrc locations

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in KNSBackend.cpp:68
> Needs to be 57 now (we'll get all of this landed soon, not to worry!)
> 
> Also, should the second one be `KNEWSTUFFCORE_VERSION_MINOR`? Seems weird 
> that both conditions are checking the major version.

It does indeed! Good catch before landing time, too :)

w... yes, yes it should, not sure how i missed that :D

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  While it makes sense to change it to the new form, the alignment feels odd 
because there are just a couple of items in the kcm. I wonder if having a title 
label would help ground the elements on the page.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

To: filipf, #vdg, #plasma, apol, ngraham
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53824.
filipf added a comment.


  be conservative with imports and don't use a top level Item

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19664?vs=53623=53824

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

AFFECTED FILES
  applets/quickshare/plasmoid/contents/config/config.qml
  applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml

To: filipf, #vdg, #plasma, apol, ngraham
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53823.
filipf added a comment.


  be conservative with imports & don't use a top-level Item

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19670?vs=53629=53823

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19670

AFFECTED FILES
  applets/appmenu/package/contents/config/config.qml
  applets/appmenu/package/contents/ui/configGeneral.qml

To: filipf, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53821.
filipf added a comment.


  fix anchors & imports

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19669?vs=53760=53821

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Awesome!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  In D17073#430382 , @trmdi wrote:
  
  > Increase the contrast between the song name and the artist.
  >  F6689279: image.png 
  
  
  I would avoid using "Font.DemiBold" because
  
  - it doesn't always work - for example, on both Manjaro/Arch and neon, 
Font.DemiBold looks the same to me as Font.Normal (I think that's a bug though!)
  - many fonts don't have a semibold/medium variant (and it just uses Normal 
instead)
  - I don't think Noto Sans has a semibold variant, only medium (I could be 
mistaken)
  
  Also I could swear that it looks bold in that screenshot, not semibold.
  But it's a step in the right direction :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Tranter Madi]

trmdi updated this revision to Diff 53812.
trmdi added a comment.


  Increase the contrast between the song name and the artist.
  F6689279: image.png 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=53770=53812

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8f1b10b23a96: Adjust date string height to match time 
string with vertical panel (authored by antnyzilla, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19194?vs=52187=53810

REVISION DETAIL
  https://phabricator.kde.org/D19194

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren, ngraham, rooty
Cc: rooty, cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D19500: [KDirModel] Fix job urls change signal connection

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19340: Search new knsrc locations

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> KNSBackend.cpp:68
>  QVector ret;
> -for (const QString : 
> QStandardPaths::standardLocations(QStandardPaths::GenericConfigLocation)) {
> +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MAJOR>=56
> +QStringList locations = KNSCore::Engine::configSearchLocations();

Needs to be 57 now (we'll get all of this landed soon, not to worry!)

Also, should the second one be `KNEWSTUFFCORE_VERSION_MINOR`? Seems weird that 
both conditions are checking the major version.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> cfeck wrote in DigitalClock.qml:305
> Could you please clarify? Are changes needed?

No changes are needed; that comment was indicating why @anthonyfieroni's 
comment was not applicable.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  newclock2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren, ngraham, rooty
Cc: rooty, cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D19194: Adjust date string height to match time string with vertical panel

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  +1 from me too

REPOSITORY
  R120 Plasma Workspace

BRANCH
  newclock2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren, ngraham, rooty
Cc: rooty, cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Kai Uwe Broulik]

broulik added a comment.


  +1!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reorganize-task-manager-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham added a comment.


  All good now, @hein?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reorganize-task-manager-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a946944edb20: Improve the look of the Application Style 
KCM UI (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53803=53806

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg, rooty, ngraham
Cc: ngraham, broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks! Code is sane too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg, rooty, ngraham
Cc: ngraham, broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham updated this revision to Diff 53804.
ngraham added a comment.


  Put the Task-Manager-Specific actions in the "More Actions" submenu

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19606?vs=53750=53804

BRANCH
  reorganize-task-manager-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19606

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/plugin/backend.cpp

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> configGeneral.qml:23
>  
> -import QtQuick 2.0
> -import QtQuick.Controls 1.0 as QtControls
> -import QtQuick.Layouts 1.1
> +import QtQuick 2.12
> +import QtQuick.Controls 2.5 as QtControls

Is this actually necessary for anything in the diff? If not, I would recommend 
against changing it.

> configGeneral.qml:31
>  id: generalConfigPage
> +anchors.horizontalCenter: parent.horizontalCenter
>  

Anchor left and right to the parent's left and right, or else if we ever decide 
to make the formlayout not horizontally centered, this layout won't get that 
change automatically.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 53803.
GB_2 added a comment.


  Update Quick Help text

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53798=53803

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg, rooty, ngraham
Cc: ngraham, broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  No, changes are not needed.
  
  This works great for me and the code makes sense. I could not find any 
regressions in my testing. I recommend landing it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  newclock2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren, ngraham
Cc: cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D19651: Improve the look of the Application Style KCM UI

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmstyle.cpp:174
> +setQuickHelp( i18n("This module allows you to modify the visual 
> appearance "
> +   "of user interface elements, such as the application 
> style "
> +   "and effects."));

"the application style" isn't an example of "user interface elements" so the 
sentence does not make sense. This would be better:

"This module allows you to modify the visual appearance of  applications' user 
interface elements"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg, rooty, ngraham
Cc: ngraham, broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 53798.
GB_2 added a comment.


  Update preview

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53792=53798

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

Re: Upgrading Widgets from plasma-workspace

[Pavel]

Hello,

Thanks for your response!

I tried to fix this once but unfortunately the systemactivity 
dataengine uses ksysguard which then probes kernel interfaces directly 
through some C code. It doesn't use Solid, where filtering out those 
interfaces would be easy. I'm not knowledgable enough in that codebase 
to comment on how that could be achieved there.


I'm working on a temporary solution to the problem - I implement 
filtering by device name (sd*, sr*, vd*,..). This should work until 
another solution is found.


I guess the sources is stored as a StringList and the widget assumes 
that when the list is empty, it uses the default set of all sources. 
Perhaps you can store a pseudo "EMPTY!" entry in the list to denote 
nothing is checked. However, I don't see why you would want to place a 
widget that then does not show anything?


Sometimes the user may try to disable the last checkbox and all 
checkboxes will turn on immediately in the settings.

It may be inconvenient for users to uncheck a large number of checkboxes.

There are two possible solutions:
1) Not allow to uncheck the last checkbox. There will always be at least 
one graph.
2) Allow to uncheck the last checkbox. In this case, the widget will be 
empty.


Now I have implemented the first option - I have forbidden to disable 
the last enabled checkbox.


--
Best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 53792.
GB_2 added a comment.


  Implement Rooty's suggestions and update preview

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53747=53792

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 added a comment.


  In D19651#430117 , @rooty wrote:
  
  > Please consider abbreviating the labels:
  >
  > - dropping text in the last two dropdown menu items (No Text, Text Only, 
Beside Icons, Below Icons)
  > - dropping the word location (it's implicit)
  > - substituting the word text with the word label (it's more accurate)
  >
  >   One more concern: Why are there two seemingly unrelated radio buttons in 
the preview? Wouldn't just one button be enough?
  
  
  Ok, will do.
  The first radio button should be activated, thanks for noticing that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D19651: Improve the look of the Application Style KCM UI

[Kai Uwe Broulik]

broulik added a comment.


  +1 on the new clean layout and for getting rid of tabs

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  
  
  > @rooty is right though that usually there is always a hierarchy between the 
song and the artist. I'd also prefer a level 5 bold song title, but yeah it's a 
controversial topic these days.
  
  F6688452: Screenshot_20190313-134318_Spotify.jpg 

  
  It's almost universal nowadays - song names in boldface. The 
applications/services that use it include but aren't limited to: Lollypop, 
Spotify, Tidal, iTunes, Deezer, and Soundcloud.
  
  The only potential hurdle might be the track name on the lock screen.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Krešimir Čohar]

rooty added a comment.


  Please consider abbreviating the labels:
  
  - dropping text in the last two dropdown menu items (No Text, Text Only, 
Beside Icons, Below Icons)
  - dropping the word location (it's implicit)
  - substituting the word text with the word label (it's more accurate)
  
  One more concern: Why are there two seemingly unrelated radio buttons in the 
preview? Wouldn't just one button be enough?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17073: Do not crop albumArt

[Filip Fila]

filipf added a comment.


  Nothing's a deal-breaker for me. I'm happy with the padding as it is.
  
  @rooty is right though that usually there is always a hierarchy between the 
song and the artist. I'd also prefer a level 5 bold song title, but yeah it's a 
controversial topic these days.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  F6688411: image.png 
  
  Level 5 for both labels would be acceptable to me if you make the song name 
bold.
  I would actually prefer this. However, it's likely that mart would throw a 
hissy fit over this change :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19589: [DownloadJob] Set destUrl and total amount

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:b09312ad384b: [DownloadJob] Set destUrl and total amount 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19589?vs=53351=53779

REVISION DETAIL
  https://phabricator.kde.org/D19589

AFFECTED FILES
  host/downloadjob.cpp

To: broulik, #plasma, #vdg, dfaure
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  > - Using a bigger font size means less characters could be display.
  
  The song name is always going to be elided, so that doesn't matter.
  
  > I don't see what is more important between artist/song.
  
  The song name is more important (more 'current' and calls for more attention, 
especially when skipping through an album).
  
  > - I don't think the topMargin is needed because there is already a space 
between the song name and the cover image. My goal is to keep the cover image 
as big as possible.
  
  F6688201: image.png 
  
  It looks stuck on. And considering that this patch shrinks the album art a 
great deal already (and we seem to deem that to be an acceptable side effect), 
sacrificing the margins to get more album art size doesn't make sense.
  
  F6688214: image.png 
  
  I'd even go so far as to say you should use "Layout.margins: 2", but I'll 
leave that decision to you.
  I propose that you also add a right margin (2 px) to offset the one on the 
left.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Tranter Madi]

trmdi added a comment.


  - Using a bigger font size means less characters could be display. I don't 
see what is more important between artist/song.
  - I don't think the topMargin is needed because there is already a space 
between the song name and the cover image. My goal is to keep the cover image 
as big as possible.
  
  How do others think ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty requested changes to this revision.
rooty added a comment.
This revision now requires changes to proceed.


  How about adding a little bit of a margin above the song name 
(Layout.topMargin 2, same as the left margin)
  And why not keep the level of the track name at 4? It's more important than 
the artist name (subheading)
  
  Before:
  
  F6688168: after.png 
  
  After:
  
  F6688175: after-2.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4c28cc3346d7: [Logout Screen] Show info that rebooting 
will enter firmware setup (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19562?vs=53660=53773

REVISION DETAIL
  https://phabricator.kde.org/D19562

AFFECTED FILES
  logout-greeter/shutdowndlg.cpp
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Upgrading Widgets from plasma-workspace

[Kai Uwe Broulik]

Hi Pavel,

first of all thanks for your efforts!

   - It is necessary to make the widget display only real disk devices 
(not virtual, not loop or ram) by default.


I tried to fix this once but unfortunately the systemactivity dataengine 
uses ksysguard which then probes kernel interfaces directly through some 
C code. It doesn't use Solid, where filtering out those interfaces would 
be easy. I'm not knowledgable enough in that codebase to comment on how 
that could be achieved there.
   - I need to make sure that after disabling all settings the widget is 
empty.


I guess the sources is stored as a StringList and the widget assumes 
that when the list is empty, it uses the default set of all sources. 
Perhaps you can store a pseudo "EMPTY!" entry in the list to denote 
nothing is checked. However, I don't see why you would want to place a 
widget that then does not show anything?


Cheers
Kai Uwe

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0f5c7ede9da2: [Desktop Sessions KCM] Add Restart to 
BIOS/UEFI checkbox (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19560?vs=53661=53772#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53661=53772

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.desktop
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/org.freedesktop.login1.Manager.xml
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp

To: broulik, #plasma, #vdg, sitter, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Upgrading Widgets from plasma-workspace

[Pavel]

Any ideas would be greatly appreciated!


04.03.2019 15:55, Pavel:

Good day. Need your help.
 I am Upgrading Widgets from plasma-workspace and faced a number of 
problems.
 I will show the modernization goals using the example of the 
diskactivity widget, designed to visualize hard drive activity:


 1) At the moment when the widget is first loaded after installation, 
all the checkboxes are selected in the settings (checked = true).
  - It is necessary to make the widget display only real disk devices 
(not virtual, not loop or ram) by default.


 2) When the user tries to disable all checkboxes in the widget 
settings, this does not work. After the last checkbox is turned off, 
all checkboxes are turned on again (the default mode). I can’t disable 
all checkboxes at the same time.
  - I need to make sure that after disabling all settings the widget 
is empty.


  I decided to do this using the widget's initialization flag 
(widget_initialized). By default, widget_initialized = false.
When you first start the widget, when it has loaded all its settings, 
the value of the flag widget_initialized = true is set to 
Component.onCompleted.
And if the widget_initialized flag is set to true, then all subsequent 
changes are considered to be made by the user.
The widget_initialized flag allows to distinguish the first launch of 
the widget from the case when the user cleared all settings.


 Is there any other way to do this? Suppose using the API? Is there 
any specialized API that allows you to achieve a similar result? 
Preferably available from QML. Or maybe this API can be added somewhere?


 Thank you!



--
With best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

D17073: Do not crop albumArt

[Tranter Madi]

trmdi updated this revision to Diff 53770.
trmdi added a comment.


  Remove duplicated "ToolTipWindowMouseArea"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=53769=53770

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg, filipf
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Tranter Madi]

trmdi updated this revision to Diff 53769.
trmdi added a comment.


  - Add 2px to leftMargin of track/artist. I don't set the margin of the Next 
button because it has its own padding.
  - Resize the player icon when "minimized, we don't have a preview"
  
  Is it fine enough to commit now ?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=53710=53769

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg, filipf
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Plasma 5.15.3.1 updated tars

[Jonathan Riddell]

These have been further updated to use the correct compression method
and to remove more broken docs

3c7b5ced440cf9ecd23b5905727cea4730188fbfe6388b4fcdb5eb3f52323147
kwin-5.15.3.2.tar.xz
21e54d489817751173049122410737db641a8e58955b84264a4ec861e302ff8a
plasma-desktop-5.15.3.2.tar.xz
42095b95a7866aa667e30c15a7ebc9b00225fdb4f06668510fdf63a18573102f
systemsettings-5.15.3.2.tar.xz

On Tue, 12 Mar 2019 at 22:41, Jonathan Riddell  wrote:
>
> Three tars have been updated for Plasma 5.15.3.1 updated.  They have
> the "id" docs manually removed as they do not compile.
>
> d9177bc7b9a884e5e85cb90f20b6858a17d87085c4b3f34050f4c863f9aaf86c
> kwin-5.15.3.1.tar.xz
> 6972769b7f63467a5cf0fe8960051c46b43a01d2b9ab89bb99a873f693383657
> plasma-desktop-5.15.3.1.tar.xz
> c54e276b57426199827293c9d0d874401cae89ceaa14f64df40bb942e3ac85d2
> systemsettings-5.15.3.1.tar.xz
>
> https://kde.org/info/plasma-5.15.3.php