D19096: [Kicker] Fix "Tooltip can not be displayed"

[Tranter Madi]

trmdi requested review of this revision.
trmdi added a comment.


  Are you ok with the new implementation? @hein

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Nathaniel Graham]

ngraham added a comment.


  Ping. :) Would be nice to get T10325  
closed out.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19899: Adapt leaf Category names for kns backend, and ensure correct filters

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:c4e8f04a2489: Adapt leaf Category names for kns backend, 
and ensure correct filters (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19899?vs=54366=54378#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19899?vs=54366=54378

REVISION DETAIL
  https://phabricator.kde.org/D19899

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19880: Fix crash in category comparison caused by incorrect filters

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:356fe5019436: Fix crash in category comparison caused by 
incorrect filters (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19880?vs=54373=54377

REVISION DETAIL
  https://phabricator.kde.org/D19880

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19880: Fix crash in category comparison caused by incorrect filters

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 54373.
leinir added a comment.


  Remove some future-leftovers

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19880?vs=54302=54373

REVISION DETAIL
  https://phabricator.kde.org/D19880

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:4665d0b41aac: [Media Frame] Set sourceSize for higher 
quality and lower memory consumption (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=54370=54372

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham added a comment.


  @d_ed told me to shipit!

REPOSITORY
  R114 Plasma Addons

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

To: ngraham, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham updated this revision to Diff 54370.
ngraham added a comment.


  Improve comment

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=54364=54370

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 171 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/171/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 19 Mar 2019 21:29:01 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 2138 lines...][2019-03-19T21:30:43.881Z] FaceUp,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:81:18: error: use of undeclared identifier 'FaceDown'; did you mean 'QOrientationReading::FaceDown'?[2019-03-19T21:30:43.881Z] case FaceDown:[2019-03-19T21:30:43.881Z]  ^~~~[2019-03-19T21:30:43.881Z]  QOrientationReading::FaceDown[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:63:9: note: 'QOrientationReading::FaceDown' declared here[2019-03-19T21:30:43.881Z] FaceDown[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:82:18: error: use of undeclared identifier 'Undefined'; did you mean 'QOrientationReading::Undefined'?[2019-03-19T21:30:43.881Z] case Undefined:[2019-03-19T21:30:43.881Z]  ^[2019-03-19T21:30:43.881Z]  QOrientationReading::Undefined[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:57:9: note: 'QOrientationReading::Undefined' declared here[2019-03-19T21:30:43.881Z] Undefined = 0,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:85:18: error: use of undeclared identifier 'TopUp'; did you mean 'QOrientationReading::TopUp'?[2019-03-19T21:30:43.881Z] case TopUp:[2019-03-19T21:30:43.881Z]  ^[2019-03-19T21:30:43.881Z]  QOrientationReading::TopUp[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:58:9: note: 'QOrientationReading::TopUp' declared here[2019-03-19T21:30:43.881Z] TopUp,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:86:18: error: use of undeclared identifier 'TopDown'; did you mean 'QOrientationReading::TopDown'?[2019-03-19T21:30:43.881Z] case TopDown:[2019-03-19T21:30:43.881Z]  ^~~[2019-03-19T21:30:43.881Z]  QOrientationReading::TopDown[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:59:9: note: 'QOrientationReading::TopDown' declared here[2019-03-19T21:30:43.881Z] TopDown,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:89:18: error: use of undeclared identifier 'LeftUp'; did you mean 'QOrientationReading::LeftUp'?[2019-03-19T21:30:43.881Z] case LeftUp:[2019-03-19T21:30:43.881Z]  ^~[2019-03-19T21:30:43.881Z]  QOrientationReading::LeftUp[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:60:9: note: 'QOrientationReading::LeftUp' declared here[2019-03-19T21:30:43.881Z] LeftUp,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:90:18: error: use of undeclared identifier 'RightUp'; did you mean 'QOrientationReading::RightUp'?[2019-03-19T21:30:43.881Z] case RightUp:[2019-03-19T21:30:43.881Z]  ^~~[2019-03-19T21:30:43.881Z]  QOrientationReading::RightUp[2019-03-19T21:30:43.881Z] /usr/local/include/qt5/QtSensors/qorientationsensor.h:61:9: note: 'QOrientationReading::RightUp' declared here[2019-03-19T21:30:43.881Z] RightUp,[2019-03-19T21:30:43.881Z] ^[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:90:18: warning: comparison of two values with different enumeration types in switch statement ('KWin::OrientationSensor::Orientation' and 'QOrientationReading::Orientation') [-Wenum-compare-switch][2019-03-19T21:30:43.881Z] case RightUp:[2019-03-19T21:30:43.881Z]  ^~~[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:90:18: error: value of type 'QOrientationReading::Orientation' is not implicitly convertible to 'KWin::OrientationSensor::Orientation'[2019-03-19T21:30:43.881Z] case RightUp:[2019-03-19T21:30:43.881Z]  ^~~[2019-03-19T21:30:43.881Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/orientation_sensor.cpp:89:18: warning: comparison of two values with different enumeration types in switch statement 

D19899: Adapt leaf Category names for kns backend, and ensure correct filters

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Previously, categories would use the name in KNSRC files (which was not 
intended as a display name as much as a handy human friendly index, in place of 
the database indices used on the remote server), and this patch adapts the 
categories to reflect the intended display name for those categories after the 
knewstuff engine has been initialised. It further ensures that categories are 
set correctly for kns resources upon creation.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19899

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham updated this revision to Diff 54364.
ngraham added a comment.


  Don't initially reload twice

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=54155=54364

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma, broulik
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19894: Use https for links in the UI

[Volker Krause]

vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19894

AFFECTED FILES
  src/aboutbugreportingdialog.cpp
  src/bugzillaintegration/reportassistantpages_base.cpp

To: vkrause
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19454: Fix errors in kirigami example files

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8dc09a000125: Fix errors in kirigami example files 
(authored by ognarb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19454?vs=54124=54354#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=54124=54354

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami, mart
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:546f82f9e645: Add a SearchField and PasswordField 
component (authored by ognarb).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=54119=54353

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19893: Fix "Tooltip can not be displayed"

[Tranter Madi]

trmdi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19893

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemGridView.qml

To: trmdi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Tranter Madi]

trmdi added a comment.


  In D19096#434638 , @abetts wrote:
  
  > Does this patch only concern itself with the icons and labels below them or 
also the categories on the right? If so, it feels like the category labels on 
the right are huge in comparison to the icon labels. Maybe those also need some 
touch up?
  
  
  Now this patch only fix the tooltip bug.
  The other issues should be in another one.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

[David Hallas]

hallas added a comment.


  Hi @ngraham ,
  
  I have made this separate change to discuss the redesign of the indicator 
arrows. The current patch changes the indicator arrow so that the toolbutton 
stays the same size and the indicator arrow is drawn as a two pixel arrow with 
one pixel margin to the border. Below is some screen shots:
  
  Indicator arrow size 2 pixels:
  
  F6702221: two_pixels_wide_one_pixel_margin_big.png 

  
  F6702225: two_pixels_wide_one_pixel_margin.png 

  
  I also did a test with a 3 pixel arrow size:
  
  F6702227: three_pixels_wide_big.png 
  
  F6702229: three_pixels_wide.png 
  
  Finally, the before picture:
  
  F6702233: original.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Andres Betts]

abetts added a comment.


  Does this patch only concern itself with the icons and labels below them or 
also the categories on the right? If so, it feels like the category labels on 
the right are huge in comparison to the icon labels. Maybe those also need some 
touch up?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Tranter Madi]

trmdi updated this revision to Diff 54349.
trmdi added a comment.
This revision is now accepted and ready to land.


  Update code style, only fix the tooltip bug.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19096?vs=52321=54349

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19096

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemGridView.qml

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

[David Hallas]

hallas created this revision.
hallas added reviewers: VDG, Breeze, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Changes the drawing of inline indicators with QToolButtons so that it
  is drawn as a small arrow in the lower right corner.

TEST PLAN
  Show QToolButton with Menu and PopupDelay enabled

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19166: Add application path as valid path for debuggers

[patrick j pereira]

patrickelectric updated this revision to Diff 54345.
patrickelectric added a comment.


  Update style again

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19166?vs=54316=54345

BRANCH
  arcpatch-D19166

REVISION DETAIL
  https://phabricator.kde.org/D19166

AFFECTED FILES
  src/debugger.cpp
  src/drkonqibackends.cpp

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  In D19873#434571 , @davidre wrote:
  
  > It seems it was changed in this commit to explicitly use Kirigami units:  
98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e 

  >  Was the Color wallpaper forgotten or did this reason not apply to it? 
Should we revert it?
  
  
  I think the rationale was "we're already importing Kirigami, so let's not 
import PlasmaCore as well solely for its units when Kirigami can provide 
units". As for why it wasn't ported elsewhere, maybe those plugins weren't 
using Kirigami yet.
  
  Bottom line though is we can either tweak Kirigami's units or just go back to 
the old ones (although they need tweaking as well). It's more or less the same 
to me, the best solution would be to use FormLayout in specific plugins.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[David Redondo]

davidre added a comment.


  It seems it was changed in this commit to explicitly use Kirigami units:  
98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e 

  Was the Color wallpaper forgotten or did this reason not apply to it? Should 
we revert it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  In D19873#434568 , @davidre wrote:
  
  > Mhm if I change it to use units like Color instead of Kirigami units it 
seems aligned properly:
  >  F6702138: grafik.png 
  
  
  The spacing in the row is still too big though. Notice how ":" is more left 
than above. But it's like this in 5.15 anyway. I think you uncovered what 
messed up the alignment - the port to Kirigami units.
  
  This aligns everything nicely: 
  F6702149: image.png 
  
  F6702152: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[David Redondo]

davidre added a comment.


  Mhm if I change it to use units like Color instead of Kirigami units it seems 
aligned properly:
  F6702138: grafik.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Robert Hoffmann]

hoffmannrobert marked an inline comment as done.
hoffmannrobert added a comment.


  In D19784#431683 , @ngraham wrote:
  
  > Nice, kinda sounds like this fixes 
https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm?
  
  
  No, unfortunately it doesn't fix this. If the network isn't available, the 
file dialog waits for KCoreDirLister ("Iterating over dirs").

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[David Redondo]

davidre added a comment.


  Maybe it would be worth it to check out how  the other wallpaper plugins that 
don't suffer from this issue align their controls ?
  potd: F6702121: grafik.png  color: 
F6702124: grafik.png 
  Color seems to do:
  
Row {
spacing: units.largeSpacing / 2

QtControls.Label {
width: formAlignment - units.largeSpacing
[...]
}
KQuickControls.ColorButton {

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Robert Hoffmann]

hoffmannrobert marked 3 inline comments as done.
hoffmannrobert added a comment.


  See https://phabricator.kde.org/D19887

INLINE COMMENTS

> dfaure wrote in recentusagemodel.cpp:261
> How do you expect isFile() and isDir() to work without a QT_LSTAT call?

A document should always be a file, so not needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 54339.
hoffmannrobert added a comment.


  - Use new KFileItem constructor with skipStat set to true

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19784?vs=53951=54339

BRANCH
  fix_recent_documents_kicker_hang

REVISION DETAIL
  https://phabricator.kde.org/D19784

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

[Noah Davis]

ndavis added a comment.


  Another thing is the ratio between the left/right margins and the top/bottom 
margins varies with font size, so maybe Kickoff really does need some fixing up.
  
  The height is `2 * units.smallSpacing`, plus the maximum value of the icon, 
title+subtile or arrow height. It should always be the needed height with a 
smallSpacing margin on both sides if that math is correct. This means that the 
fact that margins are needed to keep the icons an text within the highlight 
must be the cause of the inconsistency.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

[Noah Davis]

ndavis added a comment.


  In D19874#434319 , @ngraham wrote:
  
  > +1 conceptually. Since Kickoff has its own side margins, these additional 
margins in the items themselves are just unnecessary.
  
  
  I tried to see how they would look with no margins and rather than simply 
filling the entire area where the item highlight is supposed to be, they 
extended past it.F6702059: Screenshot_20190319_120244.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a subscriber: mart.
filipf added a comment.


  @mart would you happen to know how to trick one FormLayout into thinking its 
content is as wide as another FormLayout's content?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  In D19873#434468 , @ngraham wrote:
  
  > In D19873#434441 , @filipf wrote:
  >
  > > I just have to figure out how trick the image wallpaper's FormLayout into 
thinking its form is as wide as the main one's.
  >
  >
  > That's why. :) They come from different sources, so the plugin's formLayout 
doesn't have access to the width data for the chooser's formLayout. However if 
you can figure out how to make this work, I think that would definitely be the 
ideal solution because then it wouldn't need any hacks.
  
  
  Good news! `config.qml` is already grabbing `property int formAlignment` from 
`ConfigurationContainmentAppearance.qml` so snatching something is not an 
issue. It's just a matter of figuring out which property to take and to then 
use for our FormLayout in `config.qml`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Nathaniel Graham]

ngraham added a comment.


  In D19873#434441 , @filipf wrote:
  
  > I just have to figure out how trick the image wallpaper's FormLayout into 
thinking its form is as wide as the main one's.
  
  
  That's why. :) They come from different sources, so the plugin's formLayout 
doesn't have access to the width data for the chooser's formLayout. However if 
you can figure out how to make this work, I think that would definitely be the 
ideal solution because then it wouldn't need any hacks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  In D19873#434426 , @ngraham wrote:
  
  > In D19873#434232 , @filipf wrote:
  >
  > > This is just theoretical, but what are the obstacles with adding this 
whole row to the actual FormLayout file and just setting `visible: 
when_image_wallpaper_is_used` ?
  >
  >
  > Because the wallpaper chooser is plugin-based, and the image wallpaper is 
just one plugin out of many. In principle a wallpaper plugin could have 
whatever UI it wants, and its configuration UI has to live in a different 
place. It's **just a visual trick** that they look integrated together in the 
page.
  
  
  It seems like we're doing too many tricks. We even have to vertically align 
the label with the combobox because we're using a Row instead of RowLayout. In 
this file, why not just do:
  
Kirigami.FormLayout {
   width: MainFormLayout.width // grab geometry from 
ConfigurationContainmentAppearance.qml so that this form layout thinks it's 
working with the same elements as the main one

   Combobox {
  Kirigami.FormData.label: ("Positioning:")
   }
 }
  
  This would make the code much cleaner, I just have to figure out how trick 
the image wallpaper's FormLayout into thinking its form is as wide as the main 
one's.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Nathaniel Graham]

ngraham added a comment.


  In D19873#434232 , @filipf wrote:
  
  > This is just theoretical, but what are the obstacles with adding this whole 
row to the actual FormLayout file and just setting `visible: 
when_image_wallpaper_is_used` ?
  
  
  Because the wallpaper chooser is plugin-based, and the image wallpaper is 
just one plugin out of many. In principle a wallpaper plugin could have 
whatever UI it wants, and its configuration UI has to live in a different 
place. It's just a visual trick that they look integrated together in the page.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Andres Betts]

abetts added a comment.


  +1 visually

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

[Krešimir Čohar]

rooty added a comment.


  You should test this with all four orientations.
  And if you redo the screenshots do them like this:
  
  Category - before
  after
  Long description - before
  after
  
  It's really hard to appreciate the differences this way.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#434410 , @fvogt wrote:
  
  > In D19821#434405 , @rooty wrote:
  >
  > > This wasn't supposed to land in Plasma 5.15 as well as master?
  >
  >
  > Plasma Framework is (in this case unfortunately) a Framework, so no stable 
branches.
  
  
  My bad!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434405 , @rooty wrote:
  
  > This wasn't supposed to land in Plasma 5.15 as well as master?
  
  
  Plasma Framework is (in this case unfortunately) a Framework, so no stable 
branches.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  This wasn't supposed to land in Plasma 5.15 as well as master?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434371 , @rikmills wrote:
  
  > I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.
  
  
  I agree - as this touches binary files, applying a patch wouldn't work 
(unless using git apply).
  
  I just gave this diff a try again and could not find any place with broken 
SVG colors anymore.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 
(authored by fvogt).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54176=54319

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/widgets/tooltip.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19166: Add application path as valid path for debuggers

[patrick j pereira]

patrickelectric updated this revision to Diff 54316.
patrickelectric added a comment.


  Update style

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19166?vs=52099=54316

BRANCH
  arcpatch-D19166

REVISION DETAIL
  https://phabricator.kde.org/D19166

AFFECTED FILES
  src/debugger.cpp
  src/drkonqibackends.cpp

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Rik Mills]

rikmills added a comment.


  I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434345 , @acooligan 
wrote:
  
  > Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ?
  
  
  Yes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19851: [kirigami] make it compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:12fb6c5de392: [kirigami] make it compile without foreach 
(authored by mlaurent).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19851?vs=54207=54311

REVISION DETAIL
  https://phabricator.kde.org/D19851

AFFECTED FILES
  CMakeLists.txt
  src/kirigamiplugin.cpp

To: mlaurent, dfaure, mart
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19855: Fix bugzilla login page widgets tab order

[Marcelo Mariano]

marcelomariano added reviewers: sitter, cfeck, Plasma.
marcelomariano added a comment.


  That is true.
  I will consider taking a look at KPasswordLineEdit implementation.
  Thanks a lot!

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, sitter, cfeck, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19855: Fix bugzilla login page widgets tab order

[Marcelo Mariano]

marcelomariano removed reviewers: patrickelectric, sitter, cfeck, Plasma.
marcelomariano added a comment.


  That is true.
  I will consider taking a look at KPasswordLineEdit implementation.
  Thanks a lot!

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, patrickelectric, sitter, cfeck, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Andrew Cooligan]

acooligan added a comment.


  Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

Re: Plasma distro-specific installation path?

[Michail Vourlakos]

I am trying to find a way to access some application data. Examples are,
plasma desktopthemes and kwin colorschemes...

In the future this will also be needed because Latte will provide
installable qml indicators (something like plasma qml applets currently
do but these are going to be used only to draw the task/applet
activeORstate indicator

what I did is the following:

///
//! returns the standard path found that contains the subPath
//! local paths have higher priority by default
QString Importer::standardPath(QString subPath, bool localfirst)
{
QStringList paths =
QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);

if (localfirst) {
foreach (auto pt, paths) {
QString ptF = pt + "/" +subPath;
if (QFileInfo(ptF).exists()) {
return ptF;
}
}
} else {
for (int i=paths.count()-1; i>=0; i--) {
QString ptF = paths[i] + "/" +subPath;
if (QFileInfo(ptF).exists()) {
return ptF;
}
}
}

//! in any case that above fails
if (QFileInfo("/usr/share/"+subPath).exists()) {
return "/usr/share/"+subPath;
}

return "";
}

///

In my code I can use it for example as:
Importer::standardPath("color-schemes");

OR if I know the name I am searching
Importer::standardPath("color-schemes/" + schemeName + ".colors");


BUT I dont think this approach works when user has installed Plasma on its
local directory and how that directory can be KNOWN.

regards,
michail


Στις Τρί, 19 Μαρ 2019 στις 11:34 π.μ., ο/η David Edmundson <
da...@davidedmundson.co.uk> έγραψε:

> Can you elaborate on what you're trying to accomplish?
>

D19874: [Kickoff] Reduce the margins of KickoffItem

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 conceptually. Since Kickoff has its own side margins, these additional 
margins in the items themselves are just unnecessary. I think there's already 
enough indentation with category headers:
  
  F6701608: Screenshot_20190319_122933.png 

  
  Please fix the code issues I've highlighted and then let's do more testing 
and get it done. :)

INLINE COMMENTS

> KickoffItem.qml:102
>  left: parent.left
> -leftMargin: (units.gridUnit * 4) - units.iconSizes.medium
> +leftMargin: units.gridUnit * 1.5
>  verticalCenter: parent.verticalCenter

Don't multiply by non-integer values. `units.gridUnit * 1.5` is 27, so to get 
roughly this value without hardcoding anything, you could use 
`units.smallSpacing * 7` (28).

> KickoffItem.qml:155
>  right: parent.right
> -rightMargin: units.gridUnit * 2
> +rightMargin: units.gridUnit * 1.5
>  verticalCenter: parent.verticalCenter

Ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19880: Fix crash in category comparison caused by incorrect filters

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Prior to this, we would crash when attempting to create our own Applications 
Category instance in KNSBackend. We can now set the and filters 
programmatically and no longer crash. The patch further outputs the entirety of 
the comparison conditions we're using, for easier debuggings.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19880

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D19748#432027 , @broulik wrote:
  
  > F6696238: Screenshot_20190316_121442.png 

  >  Seems it does break things here (both with and without Qt scaling :/)
  
  
  @broulik Any chance you could retry soon, with caches cleaned before? For me 
any such misrenderings disappeared and have not come back since I cleaned the 
cache. Also would I have no explanation code-wise why that would happen (though 
also no idea how the caching works, ideally that would not happen at all).
  
  Also happy to have somebody else try this :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma distro-specific installation path?

[David Edmundson]

Can you elaborate on what you're trying to accomplish?

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  If it works for you ship it, I'm nowhere near a computer right now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  Is anyone able to review this? If there's no review in 24h I'll merge it as 
it affects users severely and the fix is trivial.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma
Cc: filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  This is just theoretical, but what are the obstacles with adding this whole 
row to the actual FormLayout file and just setting `visible: 
when_image_wallpaper_is_used` ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

[Filip Fila]

filipf added a comment.


  I actually like the right margin because it contributes to visual hierarchy 
when headings are present:
  
  F6701391: image.png 
  
  As for long descriptions, how often would you say it occurs that you have 
one? From my experience, a lot of horizontal space is still just left empty in 
Kickoff with only minor exceptions(entries). Although I am guessing you raised 
the font sizes in your case so that's why the issues is a bit more prominent?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg
Cc: filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R131:484ff7c7c3d3: [plasma-workspace-wallpapers] Add the 
Elarun wallpaper (authored by filipf).

REPOSITORY
  R131 Plasma Wallpapers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19872?vs=54283=54297

REVISION DETAIL
  https://phabricator.kde.org/D19872

AFFECTED FILES
  CMakeLists.txt
  Elarun/contents/images/2560x1600.png
  Elarun/contents/screenshot.jpg
  Elarun/metadata.desktop

To: filipf, ngraham, #vdg, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

[Krešimir Čohar]

rooty added a comment.


  Looks a lot better, +1.
  
  Please check whether there is subpixel placement of either the fonts or the 
selection rectangle with some other fonts (because gridUnit is being multiplied 
by a non-integer). I know it doesn't make sense but @flipwise and I have had to 
modify our patches too many times to count because of this.
  
  The font that might be most sensitive to this: Lato at 11 pt

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19874

To: ndavis, #plasma, #vdg
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart