D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57790.
andersonbruce added a comment.


  - Update labels on Add and Remove peer buttons

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57741=57790

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce added a comment.


  In D20930#462775 , @ngraham wrote:
  
  > In D20930#462774 , 
@andersonbruce wrote:
  >
  > > Personally I like the Add and Remove buttons to be together where they 
were, and to simply change the wording to "Add New Peer" and "Remove This 
Peer". I think this still makes it clear that the peer in the tab currently 
being displayed in the dialog is the one that will be removed
  >
  >
  > All right, let's do that, then!
  
  
  I'll update to this.
  
  >> I haven't set up a large multi-user server but I imagine one could contain 
dozens if not hundreds of peers.
  > 
  > Hmm, if that's the case, then a tabbed UI may not actually be optimal. A 
list view, with a list of peers on the left side, a search above the list, and 
the peer information on the right, would be better if there may be enough peers 
to make access via tab view awkward. If so, I apologize for leading you down a 
bad path out of ignorance of the underlying technology. What do you think?
  
  I attempted to make a list view awhile ago and because of the length of some 
of the fields (in particular the key fields which are each 44 characters long) 
I couldn't come up with anything that looked decent. I think the tabbed 
interface will be fine in the vast majority of cases, especially in a desktop 
environment where typically there will only be one peer. Considering that the 
previous version only allowed one peer to be specified, this is a big 
improvement so I think at least for now and probably the foreseeable future, 
the tabbed interface is the way to go.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Nathaniel Graham]

ngraham added a comment.


  In D20930#462774 , @andersonbruce 
wrote:
  
  > Personally I like the Add and Remove buttons to be together where they 
were, and to simply change the wording to "Add New Peer" and "Remove This 
Peer". I think this still makes it clear that the peer in the tab currently 
being displayed in the dialog is the one that will be removed
  
  
  All right, let's do that, then!
  
  > The wording should definitely not be "Connect to" because this form is used 
to edit a configuration not to actually make a connection.
  
  Gotcha, thanks for explaining!
  
  > I haven't set up a large multi-user server but I imagine one could contain 
dozens if not hundreds of peers.
  
  Hmm, if that's the case, then a tabbed UI may not actually be optimal. A list 
view, with a list of peers on the left side, a search above the list, and the 
peer information on the right, would be better if there may be enough peers to 
make access via tab view awkward. If so, I apologize for leading you down a bad 
path out of ignorance of the underlying technology. What do you think?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce added a comment.


  In D20930#462547 , @ngraham wrote:
  
  > So much better!
  >
  > I have one more little suggestion for the buttons: move the "Remove Peer" 
button into the bottom of the tab for that peer to make it clear what it 
applies to, and change the text to say, "Remove this Peer". The Remove button 
can stay where it is, but maybe should say, "Add New Peer". Actually, is "Add" 
the correct verb? Would "Connect to" be more appropriate?
  
  
  Here is a proposed version of what you asked for.  It also contains a little 
more context showing the parent dialog where the rest of the configuration is 
entered, behind the Peers dialog under discussion.
  
  Personally I like the Add and Remove buttons to be together where they were, 
and to simply change the wording to "Add New Peer" and "Remove This Peer". I 
think this still makes it clear that the peer in the tab currently being 
displayed in the dialog is the one that will be removed but am willing to do it 
the way shown below if the VDG considers it to be more consistent with the rest 
of KDE.
  
  The wording should definitely not be "Connect to" because this form is used 
to edit a configuration not to actually make a connection. Hitting "Connect" on 
a WireGuard configuration activates all the peers in that configuration at one 
time. I haven't set up a large multi-user server but I imagine one could 
contain dozens if not hundreds of peers.
  F6815862: RemoveBtnMoved.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20265: Introduce libnotificationmanager

[David Edmundson]

davidedmundson added a comment.


  I have a bunch of minor comments, but nothing that's a big show-stopper. 
  Then I think we're probably best shipping it soon.

INLINE COMMENTS

> notificationmanagerplugin.cpp:36
> +qmlRegisterType(uri, 1, 0, "Notifications");
> +qmlRegisterType();
> +qmlRegisterType(uri, 1, 0, "Settings");

uncreatabletype?

> job_p.cpp:290
> +updateField(value, m_descriptionValue2, 
> ::descriptionValue2Changed);
> +}
> +updateHasDetails();

descriptionUrlChanged

> jobsmodel.cpp:162
> +if (dirty) {
> +emit dataChanged(index, index, {role});
> +}

Why?

job::setDismissed has a signal that should propagate through

> jobsmodel.cpp:201
> +if (checkIndex(idx)) {
> +emit d->m_jobViews.at(idx.row())->resume();
> +}

emit is wrong

> jobsmodel_p.cpp:80
> +qCDebug(NOTIFICATIONMANAGER) << "By the time we wanted to 
> show JobView" << job->id() << "from" << job->applicationName() << ", it was 
> already stopped";
> +remove(job);
> +continue;

If it's pending then it won't be in the model, which means we won't call 
removeAt

which means we won't actually delete it.

Possible fix

  void JobsModelPrivate::remove(Job *job)
  {
  const int row = m_jobViews.indexOf(job);
  if (row > -1) {
  removeAt(row);
  } else {
   delete job;
  }
  }

> jobsmodel_p.cpp:138
> +
> +m_serviceWatcher = new QDBusServiceWatcher(this);
> +m_serviceWatcher->setConnection(sessionBus);

can you move this to the ctor for the same reason as the other code

> jobsmodel_p.cpp:422
> +}
> +job->setError(127); // KIO::ERR_SLAVE_DIED
> +job->setErrorText(i18n("Application closed unexpectedly."));

you  can use the enum, AFAIK it was hardcoded so we could backport this patch 
into 5.8 where anything non-zero was enough for what we wanted.

> limitedrowcountproxymodel.cpp:25
> +
> +using namespace NotificationManager;
> +

This is a good candidate for KItemModels

> limitedrowcountproxymodel.cpp:44
> +if (sourceModel) {
> +connect(sourceModel, ::rowsInserted, this, 
> ::invalidateFilter);
> +connect(sourceModel, ::rowsRemoved, this, 
> ::invalidateFilter);

I assume we need this as a row being inserted earlier in the list doesn't cause 
us to re-evaluate existing rows that previously passed the filter and are 
unchanged?

We should have this for rowsMoved

> notification.h:52
> +
> +// should this be virtual for good measure?
> +~Notification();

yes

> server_p.cpp:70
> +
> +m_inhibitionWatcher = new QDBusServiceWatcher(this);
> +m_inhibitionWatcher->setConnection(QDBusConnection::sessionBus());

there's a very obscure crash here.

If we fail to register the service, we don't create m_inhibitionWatcher and 
usages later will crash.

It's possible we'd still get into this code as one could call this the notify 
method on our existing service name.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Everything looks good to me now!

REPOSITORY
  R114 Plasma Addons

BRANCH
  quicklaunch-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21088

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:12eba77542c1: [quicklaunch] Port settings window to 
QQC2+Kirigami FormLayout and modernize UI (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21088?vs=57784=57786

REVISION DETAIL
  https://phabricator.kde.org/D21088

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf updated this revision to Diff 57785.
filipf added a comment.


  - add space after comment slashes
  - add punctuation in the comments for the added function

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21027?vs=57776=57785

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  Oops, how embarrassing. I had misunderstood the feature somehow. Fixed!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21088

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham updated this revision to Diff 57784.
ngraham added a comment.


  Fix embarrassing error

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21088?vs=57779=57784

BRANCH
  quicklaunch-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21088

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1a980bedc4d1: [System Monitor] Port settings window to 
QQC2+Kirigami FormLayout and modernize… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21074?vs=57780=57783

REVISION DETAIL
  https://phabricator.kde.org/D21074

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham updated this revision to Diff 57780.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21074?vs=57737=57780

BRANCH
  systemmonitor-modernize-settings-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21074

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf added a comment.


  Hmm I can't set the number of columns anymore when in vertical position.
  
  Before:
  F6815689: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21088

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:60
>  
> +//define colors used for icons in ToolButtons and for text in TextArea
> +//this is deliberately _NOT_ the theme color as we are over a known 
> bright background

Add a space between the slashes and the text. Also since each line is a 
sentence here, some punctuation might make that more clear!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21027

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style
  - Use standard import names
  - Adjust some strings to sound a bit more natural
  - Use Kirigami ActionTextField so that the text field can have a clear button
  - Fix a bug preventing the text field from being disabled once enabled

TEST PLAN
  - All features still work
  - Settings are saved and loaded correctly
  
  On the desktop: F6815666: On desktop.png 

  
  In a horizontal panel: F6815665: In a horizontal panel.png 

  
  In a vertical panel: F6815667: In a vertical panel.png 


REPOSITORY
  R114 Plasma Addons

BRANCH
  quicklaunch-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21088

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ConfigGeneral.qml:113
> +Kirigami.FormLayout {
> +id: formLayout
> +

We should do `anchors.left: parent.left` and `anchors.right: parent.right` here 
so the layout is horizontally centered.

> ConfigGeneral.qml:121
> +
> +Kirigami.FormData.label: i18n("Update Interval:")
> +decimals: 1

Should be `"Update interval:"` afaik

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21074

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf updated this revision to Diff 57776.
filipf added a comment.


  remove some hack I was working on for scrollbar color

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21027?vs=57775=57776

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf updated this revision to Diff 57775.
filipf added a comment.


  write a function for text and icon colors so as to not duplicate code 
everywhere

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21027?vs=57578=57775

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21026: Fix ToolButton remaining in a pressed state after press

[Filip Fila]

filipf added a comment.


  @mart does this look good to you? As you're the author I wouldn't want to 
merge without your approval.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  no-highlight-color-after-press (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21026

To: filipf, mart, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

[Filip Fila]

filipf marked an inline comment as done.
filipf added a comment.


  Here's what I'm trying to avoid:
  
  F6815617: ActionButtonPressedEffect 
  
  When pressing fast and in the lock screen we can see the circle is still in 
the process of being scaled to 1. I have some easing types shortlisted which 
behave better than `InOutQuad`, but have to do round 2 of testing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-pressed-state-to-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21062

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Filip Fila]

filipf added a comment.


  So I looked up Google's documentation and it turns out sliders do have to be 
mirrored:
  https://material.io/design/usability/bidirectionality.html#mirroring-elements
  https://material.io/design/components/sliders.html#usage
  
  As for the implementation, @broulik mentioned it would be better to use 
`controlRoot.mirrored` for mirroring and `controlRoot.visualPosition` for 
value. I couldn't come up with something that would work well, but if anyone 
has ideas I'll change the current code.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21075

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Nathaniel Graham]

ngraham added a comment.


  So much better!
  
  I have one more little suggestion for the buttons: move the "Remove Peer" 
button into the bottom of the tab for that peer to make it clear what it 
applies to, and change the text to say, "Remove this Peer". The Remove button 
can stay where it is, but maybe should say, "Add New Peer". Actually, is "Add" 
the correct verb? Would "Connect to" be more appropriate?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21082: Fix lid open/closed configurations

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Screen configurations on notebooks couldn't distinguish
  properly between open lid and closed lid configurations. The
  open lid config was only created if the lid was closed and
  deleted if the lid was opened again. Known configurations
  were ignored.
  This is fixed by keeping open and closed lid configurations
  permanently in different config files.

TEST PLAN
  Use a notebook in a docking station with two external screens
  connected. Configure the screens differently for open and closed
  lid. Particularly for closed lid configure the screen connected to
  the higher output number to the left (e.g. DP-1-2), the lower to
  the right (e.g. DP-1-1). Open and close the lid.
  
  With this patch applied screen configurations remain as previously
  configured. Without, the higher output number is shown on the
  right and the lower on the left.

REPOSITORY
  R104 KScreen

BRANCH
  fix_lid_open_closed_configs

REVISION DETAIL
  https://phabricator.kde.org/D21082

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp

To: hoffmannrobert
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Méven Car]

meven added a comment.


  In D16425#449330 , @avaldes wrote:
  
  > This is how the module looks with the new option:
  >  F6770639: image.png 
  >  It looks the same as the "Even when an external monitor is connected", I 
tried using a HBox but it didn't change the alignment, maybe there is a 
restriction on how powerdevil builds the UI, but I'm no expert on that. if 
anyone has any idea on how to change it I'm open to suggestions.
  
  
  The feature looks great.
  
  But I wonder if #vdg  could suggest the 
improvement.
  "Even when an external monitor is connected" is already misaligned.
  But perhaps this setting window would need some redesign later on.
  Do you have an opinion @ngraham ?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20576: Add new notifications KCM

[Kai Uwe Broulik]

broulik updated this revision to Diff 57758.
broulik added a comment.


  - Don't leak `KNotification`
  - Ensure proper transient

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20576?vs=57652=57758

REVISION DETAIL
  https://phabricator.kde.org/D20576

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/notifications/CMakeLists.txt
  kcms/notifications/Messages.sh
  kcms/notifications/filterproxymodel.cpp
  kcms/notifications/filterproxymodel.h
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/kcm_notifications.desktop
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/ScreenPositionSelector.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/package/metadata.desktop
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: broulik, #plasma, #vdg, davidedmundson
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/20/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 08 May 2019 10:55:22 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D20576: Add new notifications KCM

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I don't like this thing with source proxy. But I can kinda see what it's 
doing and it looks like it'll work.
  
  Lets go for it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20576

To: broulik, #plasma, #vdg, davidedmundson
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/18/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 08 May 2019 10:55:21 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2554)14%
(212/1483)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1247)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/232)0%
(0/118)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Filip Fila]

filipf updated this revision to Diff 57752.
filipf added a comment.


  fix handle behavior for right to left layouts

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21075?vs=57738=57752

BRANCH
  fix-qqc2-slider-when-from-is-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21075

AFFECTED FILES
  org.kde.desktop/Slider.qml

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/19/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 08 May 2019 10:55:17 +
 Build duration:
4 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4005)0%
(0/2740)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1413)0%
(0/1116)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1018)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/25/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 08 May 2019 10:55:16 +
 Build duration:
3 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1836)0%
(0/720)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/25)classic0%
(0/2)0%
(0/2)0%
(0/189)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/505)0%
(0/238)icons0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/48)sidebar0%
(0/4)0%
(0/4)0%
(0/426)0%
(0/202)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/29)

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Filip Fila]

filipf added a comment.


  In D21075#462419 , @broulik wrote:
  
  > Hm, right, seems the slider behaves incorrectly without this patch, too :/ 
Still I think `visualPosition` is what we want to be using
  
  
  About Qt's unmodified slider, isn't that one wrong as well ie. shouldn't the 
values be reversed? So that 1 is on the right, 5 is on the left? But when we 
fire it up it behaves exactly the same as if there is no reverse flag.
  
  So from my understanding our slider should fix both that and then the drag 
behavior.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21075

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Kai Uwe Broulik]

broulik added a comment.


  Hm, right, seems the slider behaves incorrectly without this patch, too :/ 
Still I think `visualPosition` is what we want to be using

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21075

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Filip Fila]

filipf added a comment.


  In D21075#462393 , @broulik wrote:
  
  > -1
  >  This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to 
see
  
  
  Hmm seems to be behaving the same as before, just that the handle is now on 
the tickmark.
  
  But the problem with reverse is that if I drag it right it goes left? And we 
see proper behavior with `XDG_CURRENT_DESKTOP=QT qmlscene SliderTest.qml 
-reverse` then?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21075

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17007: Do hash and hex name based output hashes

[Roman Gilg]

romangg updated this revision to Diff 57751.
romangg added a comment.


  Deprecate hash function instead of altering its behavior. This way we can
  use the new function, which does hash the output names correctly, in cases
  where it makes sense and no user configs break.

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17007?vs=45787=57751

BRANCH
  hashOutputNameHash

REVISION DETAIL
  https://phabricator.kde.org/D17007

AFFECTED FILES
  src/output.cpp
  src/output.h

To: romangg, #plasma, lbeltrame
Cc: lbeltrame, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16898: [kcm] Remove profiles code

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:7283fb5630df: [kcm] Remove profiles code (authored by 
romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16898?vs=45519=57748

REVISION DETAIL
  https://phabricator.kde.org/D16898

AFFECTED FILES
  kcm/src/profilesmodel.cpp
  kcm/src/profilesmodel.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: romangg, #plasma, apol, davidedmundson
Cc: davidedmundson, afiestas, apol, dvratil, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Kai Uwe Broulik]

broulik added a comment.


  -1
  This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to see

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  fix-qqc2-slider-when-from-is-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21075

To: filipf, mart, #plasma, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 08 May 2019 07:01:10 +
 Build duration:
3 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 379 lines...][2019-05-08T07:03:43.776Z] **[2019-05-08T07:03:43.776Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-05-08T07:03:43.776Z] ** Copyright (c) 2019 Microsoft Corporation[2019-05-08T07:03:43.776Z] **[2019-05-08T07:03:49.603Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-05-08T07:03:51.048Z] [2019-05-08T07:03:51.048Z] jom 1.1.2 - empower your cores[2019-05-08T07:03:51.048Z] [2019-05-08T07:03:51.374Z] jom: parallel job execution disabled for Makefile[2019-05-08T07:03:51.374Z] Scanning dependencies of target kdbgwin_autogen[2019-05-08T07:03:51.374Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-05-08T07:03:52.041Z] Scanning dependencies of target crashtest_autogen[2019-05-08T07:03:52.041Z] Scanning dependencies of target bugzillalibtest_autogen[2019-05-08T07:03:52.041Z] [  2%] Automatic MOC for target drkonqi_backtrace_parser[2019-05-08T07:03:52.717Z] [  3%] Automatic MOC for target crashtest[2019-05-08T07:03:53.144Z] [  1%] Automatic MOC for target kdbgwin[2019-05-08T07:03:53.144Z] [  4%] Built target crashtest_autogen[2019-05-08T07:03:53.144Z] [  4%] Built target kdbgwin_autogen[2019-05-08T07:03:54.581Z] [  4%] Built target drkonqi_backtrace_parser_autogen[2019-05-08T07:03:54.581Z] [  4%] Automatic MOC for target bugzillalibtest[2019-05-08T07:03:55.579Z] Scanning dependencies of target kdbgwin[2019-05-08T07:03:55.579Z] [  5%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-05-08T07:03:55.579Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-05-08T07:03:55.579Z] [  7%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/process.cpp.obj[2019-05-08T07:03:55.579Z] main.cpp[2019-05-08T07:03:56.171Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-05-08T07:03:56.467Z] [ 16%] Built target bugzillalibtest_autogen[2019-05-08T07:03:56.467Z] [ 16%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-05-08T07:03:56.467Z] [ 16%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-05-08T07:03:56.467Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-05-08T07:03:56.762Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-05-08T07:03:56.762Z] [ 16%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-05-08T07:03:56.762Z] backtraceparser.cpp[2019-05-08T07:03:56.762Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/__/drkonqi_debug.cpp.obj[2019-05-08T07:03:56.762Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/msvc_generator.cpp.obj[2019-05-08T07:03:57.850Z] [ 17%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_autogen/mocs_compilation.cpp.obj[2019-05-08T07:04:00.020Z] drkonqi_debug.cpp[2019-05-08T07:04:00.020Z] c:\ci\workspace\plasma\drkonqi\stable-kf5-qt5 windowsmsvcqt5.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-08T07:04:00.717Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.obj[2019-05-08T07:04:01.359Z] Scanning dependencies of target crashtest[2019-05-08T07:04:02.045Z] [ 20%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-05-08T07:04:02.330Z] crashtest.cpp[2019-05-08T07:04:04.606Z] abstract_generator.cpp[2019-05-08T07:04:04.606Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-08T07:04:04.606Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-08T07:04:04.606Z] jom: C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11\build\src\kdbgwin\CMakeFiles\kdbgwin.dir\build.make [src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj] Error 2[2019-05-08T07:04:04.606Z] process.cpp[2019-05-08T07:04:04.606Z] callbacks.cpp[2019-05-08T07:04:04.606Z] outputters.cpp[2019-05-08T07:04:04.606Z] msvc_generator.cpp[2019-05-08T07:04:04.606Z] mocs_compilation.cpp[2019-05-08T07:04:04.881Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or