D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 59842.
cblack added a comment.


  Looks like this change managed to hide from Arcanist's gaze. Should have been 
there in the first place.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59841=59842

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Components that used QQC1 in `sddm-theme/` (excluding the symlinked 
`components` folder) have been changed to use QQC2.

TEST PLAN
  Ensure no loss of functionality, style, or bugs from the port of QQC1 to QQC2.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c11527c04b1a: [desktoppackage] Re-add spacing between 
inline message and first UI element (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21810?vs=59831=59834

REVISION DETAIL
  https://phabricator.kde.org/D21810

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21690: Only show system total cpu usage by default on high core count machines

[Nathaniel Graham]

ngraham added a comment.


  @rappelman can you please provide your email address so we can land this 
patch with correct authorship information? Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21690

To: rappelman, #plasma, #vdg, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

[Filip Fila]

filipf updated this revision to Diff 59831.
filipf added a comment.


  - better solution: Layout.bottomMargin
  - remove string change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21810?vs=59829=59831

BRANCH
  fix-glued-msg-and-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21810

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

[Nathaniel Graham]

ngraham added a comment.


  Patch to fix: D21811 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21503

To: ngraham, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21811: [Calculator] Fix popup size and minimum size for expanded version

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In D21503 , I messed up the popup size 
and made it iconify at too small a size. This
  patch aims to fix that.

TEST PLAN
  I'm not super familiar with this code so I'm not sure it's the right 
approach, but
  it does seem to work:
  
  F6890392: Pop-up.png  
  F6890391: Iconified large size.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  fix-calculator-popup (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21811

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  TBH I really don't like this message anyway. It's so in-your-face. But while 
it exists, I guess we should make it look prettier. :)

INLINE COMMENTS

> ConfigurationContainmentAppearance.qml:83
>  
> +Item { // spacer; we need it because we set ColumnLayout's spacing to 0
> +visible: lockedWidgetsMessage.visible

Instead of adding a whole new item with conditional visibility, you could just 
add `Layout.bottomMargin: Kirigami.Units.smallSpacing * 2` to the InlineMessage 
itself

> ConfigurationContainmentAppearance.qml:110
>  visible: !switchContainmentWarning.visible
> -Kirigami.FormData.label: 
> i18nd("plasma_shell_org.kde.plasma.desktop", "Wallpaper Type:")
> +Kirigami.FormData.label: 
> i18nd("plasma_shell_org.kde.plasma.desktop", "Wallpaper type:")
>  QtControls.ComboBox {

This is a string change which means it can't go into 5.16.1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21810

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

[Filip Fila]

filipf added a comment.


  I added double the smallSpacing because it seemed to more closely match the 
gap between the form layout and the image frame. Thoughts?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21810

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch fixes the lack of spacing between the inline message that shows up 
when widgets and locked and the first UI element present in the layout.
  
  Included is also one minor wrong title case fix.
  
  BUG: 408712

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-glued-msg-and-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21810

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 272 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/272/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 14 Jun 2019 18:50:27 +
 Build duration:
8 min 8 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze

[Filip Fila]

filipf added a comment.


  @cblack great patch, keep it up!
  
  I pushed it to the 5.16 branch so we should already see this improvement in 
5.16.1.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:16d3eb60a984: [sddm-theme] Style the session and keyboard 
layout selectors to be more Breeze (authored by cblack, committed by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21794?vs=59809=59813

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: 5.17 Kickoff Meeting

[Aleix Pol]

On Fri, Jun 14, 2019 at 7:08 PM Jonathan Riddell  wrote:
>
> We would typically have a start of cycle Kickoff meeting sometime in the 
> coming week.  But there is a Sprint happening next Wednesday to the following 
> Wednesday.  I'm also aware that plenty people who normally spend time on 
> Plasma are otherwise engaged and won't be able to take on so much in the 
> coming cycle.
>
> So it is still useful to schedule a Kickoff meeting?  It could be while the 
> Sprint was happening but held online still.
>
> Or is it better for people at the sprint to have a group discussion in person 
> going over the Todo items and then I can chase up anyone else for Todo items 
> outside that discussion?

It could make sense to have a 5.17 discussion in the sprint and report
it to the mailing list, then further discussions can happen here or
the different phabricator tasks.

Aleix

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Thanks for restoring my sanity & faith in panels, this annoyed me for weeks :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  alignpanelmaskhandlingtodialog

REVISION DETAIL
  https://phabricator.kde.org/D21803

To: kossebau, #plasma, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19389: Rewrite kworkspace logout, shutdown and suspend API

[David Edmundson]

davidedmundson updated this revision to Diff 59811.
davidedmundson added a comment.


  Update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19389?vs=55363=59811

REVISION DETAIL
  https://phabricator.kde.org/D19389

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace_p.h
  libkworkspace/login1_manager_interface.cpp
  libkworkspace/loginddbustypes.h
  libkworkspace/org.freedesktop.ConsoleKit.Manager.xml
  libkworkspace/org.freedesktop.UPower.xml
  libkworkspace/org.freedesktop.login1.Manager.xml
  libkworkspace/org.freedesktop.login1.Seat.xml
  libkworkspace/org.freedesktop.login1.Session.xml
  libkworkspace/org.freedesktop.login1.User.xml
  libkworkspace/sessionmanagement.cpp
  libkworkspace/sessionmanagement.h
  libkworkspace/sessionmanagementbackend.cpp
  libkworkspace/sessionmanagementbackend.h
  libkworkspace/tests/CMakeLists.txt
  libkworkspace/tests/sessiontest.cpp

To: davidedmundson, #plasma
Cc: pino, broulik, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in BreezeMenuStyle.qml:6
> Why does this have to be QQC1?

AFAIK we can't style QQC2 Menus :/

There's also another non-style error that pops up.

I would suggest to consider import porting for some future date.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Thanks again :)
  
  Do you have commit access?

INLINE COMMENTS

> BreezeMenuStyle.qml:11
> +color: PlasmaCore.ColorScope.backgroundColor
> +property color borderColor: PlasmaCore.ColorScope.textColor
> +border.color: Qt.tint(PlasmaCore.ColorScope.textColor, 
> Qt.rgba(color.r, color.g, color.b, 0.7))

This can be removed now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> BreezeMenuStyle.qml:6
> +import QtQuick.Controls.Styles 1.4 as QQCS
> +import QtQuick.Controls 1.3 as QQC
> +

Why does this have to be QQC1?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: ngraham, apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack added a comment.


  @filipf Don't know but the answer is probably a no.

INLINE COMMENTS

> ngraham wrote in BreezeMenuStyle.qml:6
> Why does this have to be QQC1?

1. Styles are a QQC1 thing (QQC2 components can't take them)
2. The PlasmaComponents.ToolButton's `menu` property won't accept a QQC2 menu 
(tried it).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack updated this revision to Diff 59809.
cblack removed a subscriber: ngraham.
cblack added a comment.


  Remove unneeded property.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21794?vs=59808=59809

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, ngraham

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack updated this revision to Diff 59808.
cblack added a comment.


  Tweak border coloration (steal it from Kirigami) and remove whitespace

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21794?vs=59806=59808

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added a comment.


  Final comments and then it's a ship it from me!

INLINE COMMENTS

> BreezeMenuStyle.qml:12
> +property color borderColor: PlasmaCore.ColorScope.textColor
> +border.color: Qt.rgba(borderColor.r, borderColor.g, borderColor.b, 
> 0.3)
> +border.width: 1

It's still not working right with dark themes:

F6889724: image.png 

What do you say we steal the code for kirigami's separator color?

- first we remove the `property color ...` line above, and then do:

`border.color: Qt.tint(PlasmaCore.ColorScope.textColor, Qt.rgba(color.r, 
color.g, color.b, 0.7))`

looks good now IMO:

F6889733: image.png 

> BreezeMenuStyle.qml:18
> +verticalAlignment: Text.AlignVCenter
> +
> +color: styleData.selected ? 
> PlasmaCore.ColorScope.highlightedTextColor : PlasmaCore.ColorScope.textColor

there's whitespace here

> BreezeMenuStyle.qml:21
> +font.pointSize: config.fontSize
> +
> +text: styleData.text

whitespace here as well

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack updated this revision to Diff 59806.
cblack added a comment.


  Menu border, less hardcoding, and moving the menu style into a seperate file 
to reduce duplicated code.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21794?vs=59803=59806

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added a comment.


  Thanks for the new version, almost there.

INLINE COMMENTS

> KeyboardButton.qml:25
> +style: QQCS.MenuStyle {
> +frame: Rectangle {
> +color: PlasmaCore.ColorScope.backgroundColor

One more thing that I realized is missing here and that would make everything 
look like the desktop menus is a 1px border.

Now the stolen code should sort of look like this:

  property color borderColor: PlasmaCore.ColorScope.textColor
  border.color: Qt.rgba(borderColor.r, borderColor.g, borderColor.b, 0.3)
  border.width: 1

Unfortunately for some reason rgba fails when using dark themes and the border 
just turns white. Maybe you could figure out something better, but if you get 
stuck it's not super important.

> KeyboardButton.qml:39
> +visible: styleData.selected
> +color: "#3daee9"
> +}

We still need to remove this bit of hardcoding:

`color: PlasmaCore.ColorScope.highlightColor`

and in the other file as well, of course.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

5.17 Kickoff Meeting

[Jonathan Riddell]

We would typically have a start of cycle Kickoff meeting sometime in the
coming week.  But there is a Sprint happening next Wednesday to the
following Wednesday.  I'm also aware that plenty people who normally spend
time on Plasma are otherwise engaged and won't be able to take on so much
in the coming cycle.

So it is still useful to schedule a Kickoff meeting?  It could be while the
Sprint was happening but held online still.

Or is it better for people at the sprint to have a group discussion in
person going over the Todo items and then I can chase up anyone else for
Todo items outside that discussion?

Jonathan

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack added a comment.


  As requested by @apol, here is a screenshot of the menu with the new styling 
(I'm using a custom colorscheme currently, which is why the menu appears black 
in this screenshot). F6889655: image.png 

INLINE COMMENTS

> filipf wrote in SessionButton.qml:51
> Also, do we need this?

The extra padding makes it resemble the Breeze menus found in normal 
applications a bit more. (Also larger space to click on)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack updated this revision to Diff 59803.
cblack added a comment.


  Less harcoding & style keyboard button as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21794?vs=59771=59803

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/KeyboardButton.qml
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21797: do not set a hardcoded minimum size

[Christoph Feck]

cfeck added a comment.


  If the backtrace is filled later, and that would cause the minimumSize to 
change, then it will automatically get propagated to the window.
  
  A wordwrapped label is supposed to adapt to any with _or_ any height, so its 
minimum size is its minimum with and its minimum height, but that of course 
cannot accomodate the complete text.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 59800.
kossebau added a comment.


  for completeness also remove mask for m_backgroundHints == 
Plasma::Types::NoBackground

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21803?vs=59798=59800

BRANCH
  alignpanelmaskhandlingtodialog

REVISION DETAIL
  https://phabricator.kde.org/D21803

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Compare with DialogPrivate::updateTheme(): 
https://phabricator.kde.org/source/plasma-framework/browse/master/src/plasmaquick/dialog.cpp$229

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21803

To: kossebau, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  With Plasma dialogs & tooltips the mask is only set on the widget itself
  if compositing is off. Instead is the mask explicitly passed for the
  KWindowEffects.
  The recent changes to fix the blurbehind & contrast mask with panels
  instead turned to always set the mask on the widget. For some reason
  yet to be understood this can sometimes result in an offset by a pixel
  between the mask used for painting and the mask used for the window effects.
  
  Aligning the mask setting code with the one for dialogs & tooltips makes
  the symptom go away for now, and also delivers consistency.
  
  CCBBUG: 406380

TEST PLAN
  Using different themes, including Adapta & Arc Dark, a gap can no longer
  been seen. Only with compositing turned off, which is old behaviour due to
  the real bug yet to understand completly.
  Resizing panels or changing screen resolution also works without breaking
  rendering or panel contents interaction.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  alignpanelmaskhandlingtodialog

REVISION DETAIL
  https://phabricator.kde.org/D21803

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 271 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/271/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 14 Jun 2019 15:00:42 +
 Build duration:
2 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 2162 lines...][2019-06-14T15:02:56.583Z] #include [2019-06-14T15:02:56.583Z]  ^~~~[2019-06-14T15:02:56.583Z] 1 error generated.[2019-06-14T15:02:56.583Z] gmake[2]: *** [startkde/CMakeFiles/startplasma-x11.dir/build.make:113: startkde/CMakeFiles/startplasma-x11.dir/kcheckrunning/kcheckrunning.cpp.o] Error 1[2019-06-14T15:02:56.583Z] gmake[2]: *** Waiting for unfinished jobs[2019-06-14T15:02:56.583Z] Scanning dependencies of target plasma_containmentactions_switchdesktop_autogen[2019-06-14T15:02:56.583Z] [ 42%] Generating plasma-containmentactions-switchdesktop.json[2019-06-14T15:02:56.583Z] [ 42%] Building CXX object kcms/translations/CMakeFiles/kcm_translations.dir/translations.cpp.o[2019-06-14T15:02:56.583Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-containmentactions.desktop"[2019-06-14T15:02:56.583Z] Found property definition "X-Plasma-HasConfigurationInterface" with type "bool"[2019-06-14T15:02:56.583Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12/build/containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.json" [2019-06-14T15:02:56.583Z] [2019-06-14T15:02:56.583Z] [ 42%] Automatic MOC for target plasma_containmentactions_switchdesktop[2019-06-14T15:02:56.583Z] [ 42%] Building CXX object kcms/translations/CMakeFiles/kcm_translations.dir/translationsmodel.cpp.o[2019-06-14T15:02:57.170Z] [ 42%] Built target plasma_containmentactions_contextmenu_autogen[2019-06-14T15:02:57.170Z] Scanning dependencies of target plasma_containmentactions_switchactivity_autogen[2019-06-14T15:02:57.170Z] [ 42%] Generating plasma-containmentactions-switchactivity.json[2019-06-14T15:02:57.170Z] [ 42%] Linking CXX executable ../../bin/plasma_waitforname[2019-06-14T15:02:57.170Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-containmentactions.desktop"[2019-06-14T15:02:57.170Z] Found property definition "X-Plasma-HasConfigurationInterface" with type "bool"[2019-06-14T15:02:57.170Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12/build/containmentactions/switchactivity/plasma-containmentactions-switchactivity.json" [2019-06-14T15:02:57.170Z] [2019-06-14T15:02:57.170Z] [ 42%] Automatic MOC for target plasma_containmentactions_switchactivity[2019-06-14T15:02:57.170Z] [ 42%] Built target plasma_waitforname[2019-06-14T15:02:57.170Z] [ 42%] Built target plasma_containmentactions_switchdesktop_autogen[2019-06-14T15:02:57.170Z] Scanning dependencies of target plasma_containmentactions_switchwindow_autogen[2019-06-14T15:02:57.170Z] [ 42%] Generating plasma-containmentactions-switchwindow.json[2019-06-14T15:02:57.436Z] Scanning dependencies of target plasma_containmentactions_paste[2019-06-14T15:02:57.436Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-containmentactions.desktop"[2019-06-14T15:02:57.436Z] Found property definition "X-Plasma-HasConfigurationInterface" with type "bool"[2019-06-14T15:02:57.436Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12/build/containmentactions/switchwindow/plasma-containmentactions-switchwindow.json" [2019-06-14T15:02:57.436Z] [2019-06-14T15:02:57.436Z] [ 42%] Automatic MOC for target plasma_containmentactions_switchwindow[2019-06-14T15:02:57.436Z] [ 42%] Building CXX object containmentactions/paste/CMakeFiles/plasma_containmentactions_paste.dir/plasma_containmentactions_paste_autogen/mocs_compilation.cpp.o[2019-06-14T15:02:57.436Z] [ 42%] Linking CXX executable ../bin/startplasma-wayland[2019-06-14T15:02:57.436Z] [ 42%] Built target startplasma-wayland[2019-06-14T15:02:57.436Z] [ 42%] Building CXX object containmentactions/paste/CMakeFiles/plasma_containmentactions_paste.dir/paste.cpp.o[2019-06-14T15:02:58.028Z] [ 42%] Generating ui_config.h[2019-06-14T15:02:58.028Z] [ 42%] Built target plasma_containmentactions_switchactivity_autogen[2019-06-14T15:02:58.028Z] [ 42%] Built target plasma_containmentactions_switchwindow_autogen[2019-06-14T15:02:58.028Z] [ 42%] Generating krunner1adaptor.cpp, krunner1adaptor.h[2019-06-14T15:02:58.028Z] [ 42%] Generating krunner1adaptor.moc[2019-06-14T15:02:58.028Z] Scanning dependencies of target plasma_containmentactions_applauncher[2019-06-14T15:02:58.028Z] [ 42%] Building CXX object containmentactions/applauncher/CMakeFiles/plasma_containmentactions_applauncher.dir/plasma_containmentactions_applauncher_autogen/mocs_compilation.cpp.o[2019-06-14T15:02:58.028Z] Scanning dependencies of target krunner_activities[2019-06-14T15:02:58.028Z] [ 43%] Building CXX object 

D21802: move various properties away from qapp and to kaboutdata

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:b428aa049ee6: move various properties away from qapp and 
to kaboutdata (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21802?vs=59796=59797

REVISION DETAIL
  https://phabricator.kde.org/D21802

AFFECTED FILES
  src/main.cpp

To: sitter, kossebau
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21802: move various properties away from qapp and to kaboutdata

[Harald Sitter]

sitter updated this revision to Diff 59796.
sitter added a comment.


  ditch explicit values

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21802?vs=59792=59796

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21802

AFFECTED FILES
  src/main.cpp

To: sitter, kossebau
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21797: do not set a hardcoded minimum size

[Harald Sitter]

sitter added a comment.


  Pre-computation is not going to work 100% because the backtracewidget is 
actually changing its content based on state (a whole other can of worms that 
:S).
  
  What's the specific problem with wrapped qlabels though? Shouldn't they still 
correctly hint? I mean, the thing is, the dialog having a minimum size 
explicitly or not should not matter, each individual page should have a 
(correct) minimum size based on layout negotiation. If that doesn't work I 
would suspect that either the layout of that page is bugged or 
stretchyness/policy is off, no?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 214 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/214/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 14 Jun 2019 14:17:10 +
 Build duration:
1 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 452 lines...][2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z]  * KF5NetworkManagerQt (required version >= 5.58.0), Qt wrapper for NetworkManager API[2019-06-14T14:18:31.568Z]Needed by geolocation data engine.[2019-06-14T14:18:31.568Z]  * KF5Parts (required version >= 5.59.0)[2019-06-14T14:18:31.568Z]  * KF5TextEditor[2019-06-14T14:18:31.568Z]  * KF5Holidays, Holidays provider for Plasma calendar[2019-06-14T14:18:31.568Z]Needed to for holidays plugin for Plasma Calendar.[2019-06-14T14:18:31.568Z]  * KF5Activities (required version >= 5.58.0), management of Plasma activities[2019-06-14T14:18:31.568Z]Needed by activity related plasmoids.[2019-06-14T14:18:31.568Z]  * X11, X11 libraries, [2019-06-14T14:18:31.568Z]Required for building the X11 based workspace[2019-06-14T14:18:31.568Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2019-06-14T14:18:31.568Z]  * KF5Prison (required version >= 5.58.0), Prison library, [2019-06-14T14:18:31.568Z]Needed to create mobile barcodes from clipboard data[2019-06-14T14:18:31.568Z]  * Phonon4Qt5Experimental (required version == 4.10.2)[2019-06-14T14:18:31.568Z]  * PkgConfig[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z] -- The following RECOMMENDED packages have been found:[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z]  * KF5Baloo, File Searching[2019-06-14T14:18:31.568Z]Needed for the File Search runner.[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z] -- The following REQUIRED packages have been found:[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z]  * Qt5Gui (required version >= 5.12.3)[2019-06-14T14:18:31.568Z]  * Qt5Widgets[2019-06-14T14:18:31.568Z]  * Qt5Qml (required version >= 5.12.3)[2019-06-14T14:18:31.568Z]  * Qt5Quick[2019-06-14T14:18:31.568Z]  * Qt5QuickWidgets[2019-06-14T14:18:31.568Z]  * Qt5Concurrent[2019-06-14T14:18:31.568Z]  * Qt5Test[2019-06-14T14:18:31.568Z]  * Qt5Network[2019-06-14T14:18:31.568Z]  * KF5Plasma (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5DocTools (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Runner (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5JsEmbed (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Su (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5NewStuff (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Wallet (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5IdleTime (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Declarative (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * Gettext[2019-06-14T14:18:31.568Z]  * KF5I18n (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5KCMUtils (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5TextWidgets (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Crash (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5GlobalAccel (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5Wayland (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-06-14T14:18:31.568Z]  * KDED[2019-06-14T14:18:31.568Z]  * KF5PlasmaQuick[2019-06-14T14:18:31.568Z]  * KF5SysGuard[2019-06-14T14:18:31.568Z]  * ECM (required version >= 1.6.0)[2019-06-14T14:18:31.568Z]  * KF5Package[2019-06-14T14:18:31.568Z]  * KF5[2019-06-14T14:18:31.568Z]  * KWinDBusInterface[2019-06-14T14:18:31.568Z]  * KScreenLocker (required version >= 5.13.80)[2019-06-14T14:18:31.568Z]  * ScreenSaverDBusInterface[2019-06-14T14:18:31.568Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-06-14T14:18:31.568Z]  * Qt5X11Extras[2019-06-14T14:18:31.568Z]  * Qt5Core[2019-06-14T14:18:31.568Z]  * Qt5Sql[2019-06-14T14:18:31.568Z]  * Qt5[2019-06-14T14:18:31.568Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-06-14T14:18:31.568Z]  * XCB, X protocol C-language Binding, [2019-06-14T14:18:31.568Z]Required for enabling special X11 multihead mode[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z] -- The following RUNTIME packages have not been found:[2019-06-14T14:18:31.568Z] [2019-06-14T14:18:31.568Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-06-14T14:18:31.568Z]  * IsoCodes, ISO language, territory, currency, script codes and their translations, [2019-06-14T14:18:31.568Z]Translation of country names in digital clock applet[2019-06-14T14:18:31.568Z]  

D21725: Use a native application for starting plasma

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f0647b712c52: Use a native application for starting 
plasma (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21725?vs=59752=59793#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21725?vs=59752=59793

REVISION DETAIL
  https://phabricator.kde.org/D21725

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/startplasma-wayland.cpp
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp

To: apol, #plasma, fvogt, davidedmundson
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21797: do not set a hardcoded minimum size

[Christoph Feck]

cfeck added a comment.


  I guess sizeHint() from a paged dialog doesn't pick all pages, so the correct 
way to resolve this issue is to iterate over all pages, compute their 
sizeHint(), and use the combined size as the minium size, see 
`QSize::expandedTo()`.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21797: do not set a hardcoded minimum size

[Christoph Feck]

cfeck added a comment.


  I think I now see why we messed with sizes. There are wrapped QLabels in the 
dialog, and these break minimum size hints.
  
  What we generally do to resolve this issue is to use 
`setMinimumSize(sizeHint())`.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21802: move various properties away from qapp and to kaboutdata

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  I would leave out the explicit setting of otherwise default values, but 
people's preferences differ :)

INLINE COMMENTS

> main.cpp:78
>   i18n("(C) 2000-2018, The DrKonqi Authors"));
> +aboutData.setOrganizationDomain(QByteArrayLiteral("kde.org"));
> +aboutData.setDesktopFileName(QStringLiteral("org.kde.drkonqi"));

That is the default (in case no homepage is given)., other places then do not 
set it explicitly, for consistency might also do this here.

> main.cpp:79
> +aboutData.setOrganizationDomain(QByteArrayLiteral("kde.org"));
> +aboutData.setDesktopFileName(QStringLiteral("org.kde.drkonqi"));
>  aboutData.addAuthor(i18nc("@info:credit","Hans Petter Bieker"), 
> QString(),

This also is the implicit value, composed from (default) organization domain 
and the component name (as defined in the API docs contract). Other places also 
do not set it explicitly, so one might also not do this here.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21802

To: sitter, kossebau
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21797: do not set a hardcoded minimum size

[Harald Sitter]

sitter added a comment.


  Practically right now nothing, technically I think (?) Qt goes for the 
sizeHint() by default, so in theory the resize may have an effect. That said, I 
am not opposed to dropping that call as well if we can agree on that.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21802: move various properties away from qapp and to kaboutdata

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this is possible now that we actually call KAboutData::setApplicationData
  which forwards a whole bunch of settings to the qapp
  
  - setApplicationName is replaced by KAboutData::setApplicationData
  - setApplicationVersion is replaced by KAboutData::setApplicationData
  - setOrganizationDomain is now called on the kaboutdata instead
  - setDesktopFileName is now called on the kaboutdata instead

TEST PLAN
  `--version|author|help` work as expected

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21802

AFFECTED FILES
  src/main.cpp

To: sitter, kossebau
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21797: do not set a hardcoded minimum size

[Christoph Feck]

cfeck added a comment.


  What happens if you (instead/also) remove the next line?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma
Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21799: actually set kaboutdata as application aboutdata

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:bd205d4d2b75: actually set kaboutdata as application 
aboutdata (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21799?vs=59784=59791

REVISION DETAIL
  https://phabricator.kde.org/D21799

AFFECTED FILES
  src/main.cpp

To: sitter, #plasma, davidedmundson
Cc: kossebau, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21801: force the backtracewidget into loading state when the generator is loading

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this specifically unsets the m_highlighter which absolutely must not be
  present when in loading state (or more specifically: when receiving lines
  as-they-appear as opposed to the finished backtrace).
  also assert that the widget has no highlighter when loading lines
  
  the highlighter design is fairly wonky, it actually highlights off of the
  qtextdocument, but to highlight it needs to know the actual parsed trace
  Line entities and they are of course no longer present because the
  document only has a text blob. to bridge that disconnect the highlighter
  needs to match up the textual lines to the Line entities by their index.
  naturally this is a potential bundle of segfault sources when the two
  sources no longer align.
  
  unfortunately that is exactly what could happen:
  technically speaking drkonqi has two instances of backtracewidget. one
  in the main dialog and one in the report dialog. they both use the same
  generator though. so what happened was a confusion over which state the
  widget needs to be in vis a vis the generator. if the first widget already
  loaded a backtrace the generator would be in Loaded state and so would the
  widget (i.e. it'd have a highlighter). if the user then proceeds to the
  report dialog and they'd get a new widget with a reload button. if the user
  then would use the reload button the new widget would be fine, it would
  trigger a "reload". the old widget however would not know anything about
  the reload and continue to be in Loaded state with a highlighter attached.
  as the generator now sends lines to the old and the new widget, the old
  widget would receive the lines with a highlighter attached.
  bang! the (new) lines disalign with the Line entities in the highlighter
  and all hell breaks loose.
  
  this quite possibly fixes all occurrences of the #381644 crasher, but I
  wouldn't exclude other points of frailty. as mentioned, the way the
  highlighter's connecting textual lines to Line entities is fairly
  fragile in of itself.
  
  CHANGELOG: No longer crashes when reloading backtraces under certain 
circumstances
  BUG: 381644
  FIXED-IN: 5.16.1

TEST PLAN
  - killall -SEGV dolphin
  - open drkonqi
  - go to backtrace tab
  - let backtrace
  - click report bug
  - proceed to backtrace page
  - click reload
  - no crashy

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21801

AFFECTED FILES
  src/backtracewidget.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21605: Don't give up if no results arrive after 500ms

[Fabian Vogt]

fvogt updated this revision to Diff 59789.
fvogt marked an inline comment as done.
fvogt added a comment.


  Remove whitespace change. Will land on Monday if no objections.

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21605?vs=59204=59789

BRANCH
  dontgiveup

REVISION DETAIL
  https://phabricator.kde.org/D21605

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

To: fvogt, #plasma
Cc: broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21799: actually set kaboutdata as application aboutdata

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> main.cpp:89
>   QStringLiteral("sp...@kde.org"));
> +KAboutData::setApplicationData(aboutData);
>  qa.setWindowIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"), 
> qa.windowIcon()));

This is partially redundant though with all the QCoreApplication::set* above, 
as well as qa.setDesktopFileName below. Those should be removed then for clean 
code.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21799

To: sitter, #plasma, davidedmundson
Cc: kossebau, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21799: actually set kaboutdata as application aboutdata

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  otherwise kcrash won't be able to determine the bugaddress and without
  bugaddress the drkonqi catching drkonqi won't know what to do with the
  crash.
  
  it ought to be noted that drkonqi will not allow reporting bugs against
  drkonqi (not that I fully agree with the rationale)
  
  BUG: 383842
  FIXED-IN: 5.16.1

TEST PLAN
  - killall -SEGV dolphin
  - open drkonqi
  - killall -SEGV drkonqi
  - open drkonqi
  - offers instructions on how to proceed reporting a bug against drkonqi

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21799

AFFECTED FILES
  src/main.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21797: do not set a hardcoded minimum size

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  setting the minimum size manually like this is overriding the actual
  calculated minimum size (as per child widgets) which ultimately means that
  when a child's effective minimum is larger than the manually set one you
  can resize the widget such that the child no longer fits in.
  this is most notably observed with the page title widget. it doesn't word
  wrap, so it has a specific minimum size: the amount of space it requires to
  render the text in one line if its minimum width then exceeds the
  600 pixels we had manually set, the widget would get cut off.
  
  setting the minimum size should be entirely unnecessary. if all widgets
  have a suitable sizing policy and sizehint the dialog will calculate a
  suitable overall sizehint and minimum. getting rid of the manually set
  minimum means the dialog can be shrunk exactly as far as the page content
  allows it to shrink and no further.
  
  I chased the the minimum size back to kde-runtime in git but it even seems
  to predate that, so I have no clue what it was meant to achieve, but I am
  almost certain that it was a hacky attempt at hiding bad size policies
  or lack of size adjustments elsewhere in the dialog stack.
  
  CHANGELOG: The bug report dialog can no longer be resized to cut off text
  FIXED-IN: 5.16.1
  BUG: 403408

TEST PLAN
  - set general font size to 16pt
  - start drkonqi with LANGUAGE=pt_BR
  - report bug
  - observe all pages suffering from being cut off, up until the backtrace page 
which has manual adjustment logic as of a couple of commits ago (due to its 
actual sizing changing)

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21797

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21785: Don't track subsystem status

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:37f48b7e4fde: Dont track subsystem status (authored 
by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21785?vs=59740=59776

REVISION DETAIL
  https://phabricator.kde.org/D21785

AFFECTED FILES
  extension/extension.js
  host/abstractbrowserplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21785: Don't track subsystem status

[Kai Uwe Broulik]

broulik added a comment.


  I think in the options page we don't really have a choice since it's a 
separate page opened by the user when the extension is already running. 
  If we ever do breaking changes in the extension script and need to check it, 
we can still reintroduce something.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21785

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart