D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis added a comment.


  I feel like these names should be localized, but the gallery gets the sames 
from the file names. No translations unless that gets fixed.

REPOSITORY
  R128 User Manager

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma, ngraham, filipf
Cc: filipf, GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis added a comment.


  In D21939#482934 , @filipf wrote:
  
  > Agreed with all the removals.
  >
  > New ones should be sufficient for just about any screen and they look 
great. I'm okay with the namings. Good work!
  >
  > If it's doable, I would only possibly consider replacing PC Builder Konqi 
with Guitar Player Konqi 
. It's might 
not be super clear what's happening in the former, but that latter is pretty 
obvious.
  
  
  Actually, I meant to include the guitar konqi. Not sure why it isn't there, 
but I'll blame it on Imagemagick being confusing to work with.

REPOSITORY
  R128 User Manager

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma, ngraham, filipf
Cc: filipf, GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#482950 , @ngraham wrote:
  
  > Actually maybe it just needs a rebase on master...
  
  
  Let me give it a rebase then :D

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D21944: Show shortcut in menu item when specified

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> MenuItem.qml:98
> +font: controlRoot.font
> +color: (controlRoot.highlighted || controlRoot.hovered) ? 
> Kirigami.Theme.highlightedTextColor : Kirigami.Theme.textColor
> +horizontalAlignment: Text.AlignRight

label.color?

> MenuItem.qml:103
> +Item {
> +   Layout.preferredWidth: Kirigami.Units.smallSpacing
> +}

Use Layout.rightMargin on the shortcut object.
https://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#rightMargin-attached-prop

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_item

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Filip Fila]

filipf added a comment.


  That's what I thought, but it doesn't work :/
  
  What we know is the gap was there before. Since we've now got a 
Kirigami.ScrollablePage, we can scroll all the content up by holding the mouse. 
And we can also just make the ScrollablePage the top item. Regardless of that, 
it shows a gap at the top. I don't see where in the QML code this is coming 
from.
  
  BTW I think the errors were due to using a non-existent QQC2 import (2.12), 
so we're good on that front.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: jbbgameich, filipf, davidre, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Vision on web page

[Nate Graham]

Personally I like the faux window, but if so, it should be centered.

Maybe it could be in a sticky note widget!



On 6/20/19 3:37 PM, David Edmundson wrote:

At the bottom, not as a faux window.

David

D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham added a comment.


  Actually maybe it just needs a rebase on master...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Nathaniel Graham]

ngraham added a comment.


  Hey that looks pretty good!
  
  To fix the top gap, I wonder if it would suffice to add `anchors.fill: 
parent` or some other positioning mechanism to the top-most `ColumnLayout` 
inside the `Kirigami.ScrollablePage`.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21942: Add gitignore

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah ok, makes sense.

REPOSITORY
  R134 Discover Software Store

BRANCH
  gitignore

REVISION DETAIL
  https://phabricator.kde.org/D21942

To: nicolasfella, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Filip Fila]

filipf added a comment.


  What I've got right now is:
  
  F6918999: image.png 
  
  F6919002: main.qml 
  
  The most notable UI change is probably the fact that I added an inline 
message to waste less space.
  
  So we still need to get rid of the top gap, have the window actually have 
correct minimum width, and look into that crash bug.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21926: Have more contrast in circle-style user avatars

[Filip Fila]

filipf planned changes to this revision.
filipf added a comment.


  Good catch. I'll need a bit of help with that but should be doable.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21926

To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Agreed with all the removals.
  
  New ones should be sufficient for just about any screen and they look great. 
I'm okay with the namings. Good work!
  
  If it's doable, I would only possibly consider replacing PC Builder Konqi 
with Guitar Player Konqi 
. It's might 
not be super clear what's happening in the former, but that latter is pretty 
obvious.

REPOSITORY
  R128 User Manager

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma, ngraham, filipf
Cc: filipf, GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I might prefer "Business Konqi", but "Boss" is probably fine.
  
  Let's make sure to add some new avatars too, or else most of what we have 
will be Konqis. :) Also we need to make the avatar selection window a little 
bit wider by default so it shows three columns rather than two.

REPOSITORY
  R128 User Manager

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma, ngraham
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21944: Show shortcut in menu item when specified

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent. Looks like a sane way to do it.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_item

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This patch doesn't seem to make the back and forward buttons lose their 
arrows once I've applied D19311 , and it 
also makes all KDE apps crash like so:
  
(gdb) bt
#0  QObject::property (this=0x0, 
name=0x7fffe0ab28d0  
"_kde_toolButton_noMenuArrow") at kernel/qobject.cpp:3961
#1  0x7fffe0a8cd3f in BreezePrivate::hasInlineIndicator (
toolButtonOption=0x55c2e9e0, toolButton=)
at /home/dev/kde/src/breeze/kstyle/breezestyle.cpp:160
#2  0x7fffe0a8df30 in Breeze::Style::toolButtonSizeFromContents (
this=, option=, contentsSize=..., 
widget=) at 
/home/dev/kde/src/breeze/kstyle/breezestyle.cpp:2739

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Vision on web page

[David Edmundson]

At the bottom, not as a faux window.

David

Vision on web page

[Jonathan Riddell]

How's this for the plasma vision on web page? Which of the two positions do
you prefer?

http://apps.kde.org.uk/plasma-desktop

Jonathan

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari added a comment.


  In D21860#481370 , @broulik wrote:
  
  > Actually, for most appearance settings (color scheme, widget style, icon 
settings) it should already be signalled automatically via DBus through 
plasma-integration with no config reading on its own.
  
  
  I have found those lines in colorscheme config (and the similar in icon 
settings, but nothing in widget style):
  
QDBusMessage message = 
QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"),
  
QStringLiteral("org.kde.KGlobalSettings"),
  
QStringLiteral("notifyChange"));
message.setArguments({
0, //previous KGlobalSettings::PaletteChanged. This is now private API 
in khintsettings
0  //unused in palette changed but needed for the DBus signature
});
QDBusConnection::sessionBus().send(message);
  
  Is this it? Should my daemon use the similar DBus signatures for fonts?
  
  If I understand correctly, what I need to do is:
  
  1. Write similar to above lines in fonts kcm code (No sure about arguments 
actually - what they should be?)
  2. Write a daemon that listens DBus with those signatures and when specific 
setting changes (for now it's only fonts, then it will be cursors or something 
else) it changes corresponding setting in gtk via GSettings

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol
Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21926: Have more contrast in circle-style user avatars

[Noah Davis]

ndavis added a comment.


  Unless you want to get rid of the SVG these avatars were created from, you 
should also update `pics_sources/avatar.svg`.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21926

To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21915: Fix crash in the touchpad kded

[Albert Astals Cid]

aacid added a subscriber: atulbi.
aacid added a comment.


  In D21915#482182 , @knambiar wrote:
  
  > In D21915#482145 , @aacid wrote:
  >
  > > The other question is if "enabled" was ever the correct atom to check for
  > >
  > > libinput Tapping Enabled
  >
  >
  > I'm fairly sure we were checking for `libinput Tapping Enabled` atom in the 
past, and so does GNOME: 
https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410
  
  
  I can't find any use of that, the current use of "enabled" was added by 
@atulbi

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21915

To: aacid
Cc: atulbi, knambiar, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis added a comment.


  In D21939#482800 , @GB_2 wrote:
  
  > Great! I'd only change the name of these avatars:
  >  Boss Konqi -> Banker Konqi
  >  Hacker Konqi -> Developer Konqi / Programmer Konqi
  
  
  I chose boss and hacker because I want the names to be things that people 
want to identify as and I'm using the traditional definition of hacker.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis updated this revision to Diff 60165.
ndavis added a comment.


  Rename duelist to card shark

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21939?vs=60164=60165

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

AFFECTED FILES
  src/pics/bluesstyle/Ada Lovelace.png
  src/pics/bluesstyle/Alice in Wonderland.png
  src/pics/bluesstyle/Grace Hopper.png
  src/pics/bluesstyle/Leonardo da Vinci.png
  src/pics/bluesstyle/Mahatma Gandhi.png
  src/pics/bluesstyle/Man.png
  src/pics/bluesstyle/Mowgli jungle book.png
  src/pics/classic/Blackbox.png
  src/pics/classic/Bomb.png
  src/pics/classic/Dragon.png
  src/pics/classic/Green.png
  src/pics/classic/Happy.png
  src/pics/classic/Listening.png
  src/pics/classic/Notme.png
  src/pics/classic/TV.png
  src/pics/konqui/Artist Konqi.png
  src/pics/konqui/Bookworm Konqi.png
  src/pics/konqui/Boss Konqi.png
  src/pics/konqui/Bug Catcher Konqi.png
  src/pics/konqui/Card Shark Konqi.png
  src/pics/konqui/Hacker Konqi.png
  src/pics/konqui/Journalist Konqi.png
  src/pics/konqui/Kati.png
  src/pics/konqui/Katie.png
  src/pics/konqui/Konqi.png
  src/pics/konqui/Konqui.png
  src/pics/konqui/Logger.png
  src/pics/konqui/Mechanic Konqi.png
  src/pics/konqui/Messenger Konqi.png
  src/pics/konqui/Office Worker Konqi.png
  src/pics/konqui/PC Builder Konqi.png
  src/pics/konqui/Parley.png
  src/pics/konqui/Rekonqui.png
  src/pics/konqui/Scientist Konqi.png
  src/pics/konqui/Teacher Konqi.png
  src/pics/konqui/Virtual Reality Konqi.png
  src/pics_sources/Ada Lovelace.svg
  src/pics_sources/Alice in Wonderland.svg
  src/pics_sources/Dragon.svg
  src/pics_sources/Grace Hopper.svg
  src/pics_sources/Kati.svg
  src/pics_sources/Konqui.svg
  src/pics_sources/Leonardo da Vinci.svg
  src/pics_sources/Logger.svg
  src/pics_sources/Mahatma Gandhi.svg
  src/pics_sources/Man.svg
  src/pics_sources/Mowgli jungle book.svg
  src/pics_sources/Parley.svg
  src/pics_sources/Rekonqui.svg
  src/pics_sources/blackbox.svgz
  src/pics_sources/bomb.svgz
  src/pics_sources/green.svgz
  src/pics_sources/happy.svgz
  src/pics_sources/listening.svgz
  src/pics_sources/notme.svgz
  src/pics_sources/tv.svgz

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis added a comment.


  Saying i
  
  In D21939#482861 , @ngraham wrote:
  
  > Hmm, I don't think "duelist" is the right word. That one makes me think 
"card shark".
  
  
  Yeah, it was just a dumb Yu-Gi-Oh reference that doesn't really make sense in 
context.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I don't think "duelist" is the right word. That one makes me think "card 
shark".

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis updated this revision to Diff 60164.
ndavis added a comment.


  Fix spelling of dualist

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21939?vs=60163=60164

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

AFFECTED FILES
  src/pics/bluesstyle/Ada Lovelace.png
  src/pics/bluesstyle/Alice in Wonderland.png
  src/pics/bluesstyle/Grace Hopper.png
  src/pics/bluesstyle/Leonardo da Vinci.png
  src/pics/bluesstyle/Mahatma Gandhi.png
  src/pics/bluesstyle/Man.png
  src/pics/bluesstyle/Mowgli jungle book.png
  src/pics/classic/Blackbox.png
  src/pics/classic/Bomb.png
  src/pics/classic/Dragon.png
  src/pics/classic/Green.png
  src/pics/classic/Happy.png
  src/pics/classic/Listening.png
  src/pics/classic/Notme.png
  src/pics/classic/TV.png
  src/pics/konqui/Artist Konqi.png
  src/pics/konqui/Bookworm Konqi.png
  src/pics/konqui/Boss Konqi.png
  src/pics/konqui/Bug Catcher Konqi.png
  src/pics/konqui/Duelist Konqi.png
  src/pics/konqui/Hacker Konqi.png
  src/pics/konqui/Journalist Konqi.png
  src/pics/konqui/Kati.png
  src/pics/konqui/Katie.png
  src/pics/konqui/Konqi.png
  src/pics/konqui/Konqui.png
  src/pics/konqui/Logger.png
  src/pics/konqui/Mechanic Konqi.png
  src/pics/konqui/Messenger Konqi.png
  src/pics/konqui/Office Worker Konqi.png
  src/pics/konqui/PC Builder Konqi.png
  src/pics/konqui/Parley.png
  src/pics/konqui/Rekonqui.png
  src/pics/konqui/Scientist Konqi.png
  src/pics/konqui/Teacher Konqi.png
  src/pics/konqui/Virtual Reality Konqi.png
  src/pics_sources/Ada Lovelace.svg
  src/pics_sources/Alice in Wonderland.svg
  src/pics_sources/Dragon.svg
  src/pics_sources/Grace Hopper.svg
  src/pics_sources/Kati.svg
  src/pics_sources/Konqui.svg
  src/pics_sources/Leonardo da Vinci.svg
  src/pics_sources/Logger.svg
  src/pics_sources/Mahatma Gandhi.svg
  src/pics_sources/Man.svg
  src/pics_sources/Mowgli jungle book.svg
  src/pics_sources/Parley.svg
  src/pics_sources/Rekonqui.svg
  src/pics_sources/blackbox.svgz
  src/pics_sources/bomb.svgz
  src/pics_sources/green.svgz
  src/pics_sources/happy.svgz
  src/pics_sources/listening.svgz
  src/pics_sources/notme.svgz
  src/pics_sources/tv.svgz

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Felix Ernst]

felixernst added a comment.


  I don't think Konqi should be called a banker when wearing a suit. It doesn't 
fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. 
Business Konqi can work too.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: felixernst, GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis updated this revision to Diff 60163.
ndavis removed a subscriber: felixernst.
ndavis added a comment.


  Change names of Bugcatcher and Officeworker to be more grammatically correct

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21939?vs=60153=60163

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

AFFECTED FILES
  src/pics/bluesstyle/Ada Lovelace.png
  src/pics/bluesstyle/Alice in Wonderland.png
  src/pics/bluesstyle/Grace Hopper.png
  src/pics/bluesstyle/Leonardo da Vinci.png
  src/pics/bluesstyle/Mahatma Gandhi.png
  src/pics/bluesstyle/Man.png
  src/pics/bluesstyle/Mowgli jungle book.png
  src/pics/classic/Blackbox.png
  src/pics/classic/Bomb.png
  src/pics/classic/Dragon.png
  src/pics/classic/Green.png
  src/pics/classic/Happy.png
  src/pics/classic/Listening.png
  src/pics/classic/Notme.png
  src/pics/classic/TV.png
  src/pics/konqui/Artist Konqi.png
  src/pics/konqui/Bookworm Konqi.png
  src/pics/konqui/Boss Konqi.png
  src/pics/konqui/Bug Catcher Konqi.png
  src/pics/konqui/Dualist Konqi.png
  src/pics/konqui/Hacker Konqi.png
  src/pics/konqui/Journalist Konqi.png
  src/pics/konqui/Kati.png
  src/pics/konqui/Katie.png
  src/pics/konqui/Konqi.png
  src/pics/konqui/Konqui.png
  src/pics/konqui/Logger.png
  src/pics/konqui/Mechanic Konqi.png
  src/pics/konqui/Messenger Konqi.png
  src/pics/konqui/Office Worker Konqi.png
  src/pics/konqui/PC Builder Konqi.png
  src/pics/konqui/Parley.png
  src/pics/konqui/Rekonqui.png
  src/pics/konqui/Scientist Konqi.png
  src/pics/konqui/Teacher Konqi.png
  src/pics/konqui/Virtual Reality Konqi.png
  src/pics_sources/Ada Lovelace.svg
  src/pics_sources/Alice in Wonderland.svg
  src/pics_sources/Dragon.svg
  src/pics_sources/Grace Hopper.svg
  src/pics_sources/Kati.svg
  src/pics_sources/Konqui.svg
  src/pics_sources/Leonardo da Vinci.svg
  src/pics_sources/Logger.svg
  src/pics_sources/Mahatma Gandhi.svg
  src/pics_sources/Man.svg
  src/pics_sources/Mowgli jungle book.svg
  src/pics_sources/Parley.svg
  src/pics_sources/Rekonqui.svg
  src/pics_sources/blackbox.svgz
  src/pics_sources/bomb.svgz
  src/pics_sources/green.svgz
  src/pics_sources/happy.svgz
  src/pics_sources/listening.svgz
  src/pics_sources/notme.svgz
  src/pics_sources/tv.svgz

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart, felixernst

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich added a comment.


  This is required to port the menu of Elisa to qqc2 (D21943 
)
  
  qqc1 version
  F6918483: menu_qqc1.png 
  
  qqc2 version without this patch
   F6918485: menu_before.png 
  
  qqc2 with this patch
  F6918491: menu_after.png 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mart, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Show the shortcut as text for menu items when 
  they are given via an action

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_item

REVISION DETAIL
  https://phabricator.kde.org/D21944

AFFECTED FILES
  org.kde.desktop/MenuItem.qml

To: astippich, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21927: Use window.postMessage instead of creating a wrapper item

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  > Also do some more sanity checks on the input data.
  
  Are those even necessary at that point? Considering  that the referenced 
payload properties can still be literally anything and now even direct objects 
instead of just stuff converted to JSON and back.

INLINE COMMENTS

> content-script.js:640
> +case "playbackState":
> +
> +if (!["none", "paused", "playing"].includes(payload)) {

Whitespace

> broulik wrote in content-script.js:642
> Oops :)

Yeah, let's keep it "family friendly" ;-)

> content-script.js:661
> +case "callbacks":
> +
> +if (Array.isArray(payload)) {

Whitespace

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21927

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21934: Ensure no one but us writes to stdout

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> connection.cpp:39
> +int newStdout = dup(STDOUT_FILENO);
> +close(STDOUT_FILENO);
> +m_stdOut.open(newStdout, QIODevice::WriteOnly);

I'd `dup2(STDERR_FILENO, STDOUT_FILENO);` instead to ensure that if something 
tries to write to it or query something, there aren't unexpected errors.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21934

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Björn Feber]

GB_2 added a comment.


  Great! I'd only change the name of these avatars:
  Boss Konqi -> Banker Konqi
  Hacker Konqi -> Developer Konqi / Programmer Konqi

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21942: Add gitignore

[Nicolas Fella]

nicolasfella added a comment.


  In D21942#482796 , @ngraham wrote:
  
  > Where do `*.kdev4` files come from?
  
  
  Those are KDevelop project files

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21942

To: nicolasfella, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21942: Add gitignore

[Nathaniel Graham]

ngraham added a comment.


  Where do `*.kdev4` files come from?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21942

To: nicolasfella, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Nathaniel Graham]

ngraham added a comment.


  Very nice! What happens to a user who was using one of the old images though? 
Is it preserved, or does their user avatar suddenly become blank?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21942: Add gitignore

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  gitignore

REVISION DETAIL
  https://phabricator.kde.org/D21942

AFFECTED FILES
  .gitignore

To: nicolasfella, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham added a comment.


  In D21935#482746 , @broulik wrote:
  
  > Not sure how useful it actually is to show non removable drives there. I 
only use that for testing, if ever. +/-0 from my side
  
  
  If you opt to make it show all drives, then it would have > 0 items and would 
show up, right?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21941: Hide update notifier completely when no updates are available

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f6ac17b54b8d: Hide update notifier completely when no 
updates are available (authored by nicolasfella).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21941?vs=60155=60156

REVISION DETAIL
  https://phabricator.kde.org/D21941

AFFECTED FILES
  notifier/plasmoid/contents/ui/main.qml

To: nicolasfella, ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21941: Hide update notifier completely when no updates are available

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: ngraham, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The applet isn't particularly useful when no updates are available. Hide it 
to reduce the clutter

REPOSITORY
  R134 Discover Software Store

BRANCH
  hide

REVISION DETAIL
  https://phabricator.kde.org/D21941

AFFECTED FILES
  notifier/plasmoid/contents/ui/main.qml

To: nicolasfella, ngraham, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The Konqi mascots are so good, we might as well use them. Our existing 
avatars are not so good, so I'm removing them.

REPOSITORY
  R128 User Manager

BRANCH
  user-pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21939

AFFECTED FILES
  src/pics/bluesstyle/Ada Lovelace.png
  src/pics/bluesstyle/Alice in Wonderland.png
  src/pics/bluesstyle/Grace Hopper.png
  src/pics/bluesstyle/Leonardo da Vinci.png
  src/pics/bluesstyle/Mahatma Gandhi.png
  src/pics/bluesstyle/Man.png
  src/pics/bluesstyle/Mowgli jungle book.png
  src/pics/classic/Blackbox.png
  src/pics/classic/Bomb.png
  src/pics/classic/Dragon.png
  src/pics/classic/Green.png
  src/pics/classic/Happy.png
  src/pics/classic/Listening.png
  src/pics/classic/Notme.png
  src/pics/classic/TV.png
  src/pics/konqui/Artist Konqi.png
  src/pics/konqui/Bookworm Konqi.png
  src/pics/konqui/Boss Konqi.png
  src/pics/konqui/Bugcatcher Konqi.png
  src/pics/konqui/Dualist Konqi.png
  src/pics/konqui/Hacker Konqi.png
  src/pics/konqui/Journalist Konqi.png
  src/pics/konqui/Kati.png
  src/pics/konqui/Katie.png
  src/pics/konqui/Konqi.png
  src/pics/konqui/Konqui.png
  src/pics/konqui/Logger.png
  src/pics/konqui/Mechanic Konqi.png
  src/pics/konqui/Messenger Konqi.png
  src/pics/konqui/Officeworker Konqi.png
  src/pics/konqui/PC Builder Konqi.png
  src/pics/konqui/Parley.png
  src/pics/konqui/Rekonqui.png
  src/pics/konqui/Scientist Konqi.png
  src/pics/konqui/Teacher Konqi.png
  src/pics/konqui/Virtual Reality Konqi.png
  src/pics_sources/Ada Lovelace.svg
  src/pics_sources/Alice in Wonderland.svg
  src/pics_sources/Dragon.svg
  src/pics_sources/Grace Hopper.svg
  src/pics_sources/Kati.svg
  src/pics_sources/Konqui.svg
  src/pics_sources/Leonardo da Vinci.svg
  src/pics_sources/Logger.svg
  src/pics_sources/Mahatma Gandhi.svg
  src/pics_sources/Man.svg
  src/pics_sources/Mowgli jungle book.svg
  src/pics_sources/Parley.svg
  src/pics_sources/Rekonqui.svg
  src/pics_sources/blackbox.svgz
  src/pics_sources/bomb.svgz
  src/pics_sources/green.svgz
  src/pics_sources/happy.svgz
  src/pics_sources/listening.svgz
  src/pics_sources/notme.svgz
  src/pics_sources/tv.svgz

To: ndavis, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Kai Uwe Broulik]

broulik added a comment.


  Not sure how useful it actually is to show non removable drives there. I only 
use that for testing, if ever. +/-0 from my side

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, it's pointless to show something that can't be interacted with. I suppose 
technically you could right-click on it and configure it, but that seems like a 
niche use case (I doubt more than a dozen people even know the Devices Notifier 
plasmoid is configurable) and in any event you can always configure it when 
it's visible.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When no device is present the plasmoid doesn't do anything interactive. It 
merely says that no device is available.
  By hiding it completely from the systray we reduce the visual clutter in the 
expanded system tray

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: nicolasfella, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21934: Ensure no one but us writes to stdout

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I originally didn't consider this neccessary because we have a 
`qMessageHandler`, so every `qDebug` goes through the proper formatting. 
However, if an external application is launched, it might blatantly print to 
stdout.

TEST PLAN
  - Triggered Purpose menu from a website, chose "send via email" which 
triggered Thunderbird and then quit Thunderbird. Previously the host was killed 
by printing
  
*** UTM:SVC TimerManager:registerTimer called after profile-before-change 
notification. Ignoring timer registration for id: telemetry_modules_ping
  
  on stdout. Now the host continues to run smoothly. Everything else is 
unaffected

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21934

AFFECTED FILES
  host/connection.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  For positioning the menu maybe you could have a look at how it was done in 
Kickoff config window: 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:10
>  PlasmaComponents.ToolButton {
> -id: keyboardButton
> +id: toolBtn
>  

Prefer descriptive variable names; `toolButton` is better than `toolBtn`, but 
even better would be a description of what this button is actually for. The 
original was better and didn't need to be changed IMO.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21927: Use window.postMessage instead of creating a wrapper item

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> content-script.js:642
> +if (!["none", "paused", "playing"].includes(payload)) {
> +console.log("shit playback state", payload);
> +return;

Oops :)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21927

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 60136.
cblack added a comment.


  - Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{}
  - If toolbutton is larger than largest menu item, resize menu to size of 
toolbutton
  - Other minor things

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59884=60136

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> filipf wrote in SessionButton.qml:47
> While we're doing this, can you perhaps make the menu pop up *above* the 
> button?

It seems that changing the `y` value doesn't affect its y position for whatever 
reason.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:89b9f8768ee4: Remove accidentally slipped back traces of 
cmake code for Plasma style (authored by kossebau).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21784?vs=59739=60133

REVISION DETAIL
  https://phabricator.kde.org/D21784

AFFECTED FILES
  src/CMakeLists.txt

To: kossebau, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/26/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 20 Jun 2019 14:11:59 +
 Build duration:
6 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4014)0%
(0/2728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1420)0%
(0/1104)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1019)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/196)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

D21918: [powerdevil] Connect to battery source events

[Anthony Fieroni]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:a1f9e365a5b4: [powerdevil] Return battery source 
monitoring (authored by anthonyfieroni).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21918?vs=60098=60131

REVISION DETAIL
  https://phabricator.kde.org/D21918

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: anthonyfieroni, broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21895: print a warning when invoking the scripting API's sleep()

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  we could make it a no op even?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21895

To: sitter, mart
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21918: [powerdevil] Connect to battery source events

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Oh, shit. Thanks! 5.16 branch please

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D21918

To: anthonyfieroni, broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21926: Have more contrast in circle-style user avatars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go, much better. Thanks!

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21926

To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21926: Have more contrast in circle-style user avatars

[Filip Fila]

filipf updated this revision to Diff 60122.
filipf added a comment.


  fix permissions, take 2

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21926?vs=60120=60122

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21926

AFFECTED FILES
  src/pics/circles/Cat.png
  src/pics/circles/Female.png
  src/pics/circles/Konqui.png
  src/pics/circles/Male.png
  src/pics/circles/Penguin.png
  src/pics/circles/Zebra.png

To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21927: Use window.postMessage instead of creating a wrapper item

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This should make it less invasive by not messing with the website DOM.
  Also do some more sanity checks on the input data.

TEST PLAN
  Still get album art, artist info, and callbacks on both Chrome and Firefox

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21927

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21926: Have more contrast in circle-style user avatars

[Filip Fila]

filipf updated this revision to Diff 60120.
filipf edited the test plan for this revision.
filipf added a comment.


  fix permissions

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21926?vs=60118=60120

BRANCH
  circle-avatars-better-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21926

AFFECTED FILES
  src/pics/circles/Cat.png
  src/pics/circles/Female.png
  src/pics/circles/Konqui.png
  src/pics/circles/Male.png
  src/pics/circles/Penguin.png
  src/pics/circles/Zebra.png

To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21926: Have more contrast in circle-style user avatars

[Nathaniel Graham]

ngraham added a comment.


  Looks like the permissions have changed too?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21926

To: filipf
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21926: Have more contrast in circle-style user avatars

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Our circular avatar currently don't have the best contrast between their 
background and main element, which is especially evident when using light 
themes.
  
  This patch raises the opacity of the background circle, making it more 
prominent.

REPOSITORY
  R128 User Manager

BRANCH
  circle-avatars-better-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21926

AFFECTED FILES
  src/pics/circles/Cat.png
  src/pics/circles/Female.png
  src/pics/circles/Konqui.png
  src/pics/circles/Male.png
  src/pics/circles/Penguin.png
  src/pics/circles/Zebra.png

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go, much better.
  
  F6917696: Screenshot_20190620_151607.png 

  
  This is so nice. Let's not commit it until @mart's companion patch for Breeze 
has been submitted and accepted.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D21925: Update joystick kcm documentation for game controllers

[Yuri Chornoivan]

yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks. Please answer the comment then push if you want to.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21925

To: ndavis, #plasma, #documentation, yurchor
Cc: yurchor, ngraham, plasma-devel, kde-doc-english, LeGast00n, jraleigh, 
gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  Added some comments that apply to both button files.
  
  On a final note, watch out for whitespace because there's lots of it that's 
been added. You can turn on whitespace displaying in Kate:
  
  F6894460: image.png 

INLINE COMMENTS

> SessionButton.qml:47
> +onClicked: {
> +sessionMenu.popup(x, y)
> +}

While we're doing this, can you perhaps make the menu pop up *above* the button?

> SessionButton.qml:65
> +implicitHeight: 40
> +implicitWidth: sessionMenu.largestWidth
> +color: PlasmaCore.ColorScope.backgroundColor

This can be up for debate, but I sort of liked the older behavior more when the 
menu's width would be determined by the size of the ToolButton at a particular 
point.

> SessionButton.qml:87
> +text: model.name
> +font: menuItem.font
> +color: PlasmaCore.ColorScope.textColor

Why do we need to set this?

> cblack wrote in SessionButton.qml:27
> QML files can only have one root, and the ToolButton's `menu` property 
> doesn't accept QQC2 menus, meaning they have to be separated.

It seems to be running fine without the Item wrapper for me. What I did though 
was but the QQC2 menu inside the button, I didn't split them up.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21925: Update joystick kcm documentation for game controllers

[Nathaniel Graham]

ngraham added a reviewer: Documentation.
ngraham added inline comments.

INLINE COMMENTS

> index.docbook:71
>  
>  The plotted location of the X and Y axes of the joystick. Enable 
> Show trace
>  to plot the path of the joystick from one point to another.

`of the joystick` -> `of the game controller's joystick`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21925

To: ndavis, #plasma, #documentation
Cc: ngraham, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21922: Rename Joystick KCM to Game Controller

[Nathaniel Graham]

ngraham added a comment.


  Looks like that's in D21925 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21922

To: ndavis, #plasma, #vdg, ngraham
Cc: ltoscano, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Nathaniel Graham]

ngraham added a comment.


  So is this unnecessary, and the string should be translated somewhere over in 
FreeDesktop-land?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: pshinjo, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, now the name shows up in the combobox. However I'm not sure the 
images are fetched properly. I get a black background, rather than an image.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

To: tagorechandanreddy, #plasma, ngraham
Cc: ngraham, jriddell, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21925: Update joystick kcm documentation

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
ndavis requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21925

AFFECTED FILES
  doc/kcontrol/joystick/index.docbook

To: ndavis, #plasma
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60115.
filipf added a comment.


  fix wrong sidebar width

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60101=60115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  Instead of adding another tab, how about putting the shortcuts editor below 
the plugins list?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, something's not right anymore:
  
  F6917589: Screenshot_20190620_143140.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D21909: [Colors KCM] Assign properties in a binding

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b72df235a0a: [Colors KCM] Assign properties in a binding 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21909?vs=60075=60114

REVISION DETAIL
  https://phabricator.kde.org/D21909

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21922: Rename Joystick KCM to Game Controller

[Luigi Toscano]

ltoscano added a comment.


  The documentation should have been changed as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21922

To: ndavis, #plasma, #vdg, ngraham
Cc: ltoscano, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21922: Rename Joystick KCM to Game Controller

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1c24138b481a: Rename Joystick KCM to Game Controller 
(authored by ndavis).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21922?vs=60106=60110

REVISION DETAIL
  https://phabricator.kde.org/D21922

AFFECTED FILES
  kcms/hardware/joystick/joystick.desktop

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21922: Rename Joystick KCM to Game Controller

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21922

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D14490: [System Monitor] Enable high dpi pixmaps

[Nathaniel Graham]

ngraham added a comment.


  @broulik can this land?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14490

To: broulik, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21922: Rename Joystick KCM to Game Controller

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Most people will use it for calibrating game controllers and the icon was 
recently changed to a game controller.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21922

AFFECTED FILES
  kcms/hardware/joystick/joystick.desktop

To: ndavis, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19612: RFC port to bugzilla REST API

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good!

REPOSITORY
  R871 DrKonqi

BRANCH
  webservice

REVISION DETAIL
  https://phabricator.kde.org/D19612

To: sitter, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21918: [powerdevil] Connect to battery source events

[Anthony Fieroni]

anthonyfieroni added a reviewer: davidedmundson.
anthonyfieroni added a comment.


  it's removed in D20157 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D21918

To: anthonyfieroni, broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60101.
filipf added a comment.


  line 218: width -> implicitWidth

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60100=60101

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60100.
filipf added a comment.


  rebase on master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57680=60100

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Technical Advise for PlasmaQuick::ContainmentView [Latte]

[Michail Vourlakos]

Hello everyone,

I need some help, Latte::Indicators (https://store.kde.org/browse/cat/563/)
are standalone qml only packages like plasma applets which are loaded in
order to show Tasks indication/information

My issue is that when an indicator's qml code is updated I would like the
user to notice the update runtime in Latte Dock/Panels. Latte is using
"Plasma::ContainmentView" for docks and panels which derives from
"KQuickAddons::QuickViewSharedEngine". Searching the Internet for
QQuickView a solutions is to do:

setSouce(QUrl));
engine()->clearComponentCache();
setSource(corona()->kPackage().filePath("lattedockui"));

but that does not work, it just destroys QQmlComponent of ContainmentView,

Do you have any ideas?

regards,
michail
-Latte Developer-

D21918: [powerdevil] Connect to battery source events

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  I don't know how this works till now, but without monitor battery percentage 
changes we are unable to trigger low battery level notification nor critical 
battery level action.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D21918

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: anthonyfieroni, broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21915: Fix crash in the touchpad kded

[Rajeesh K Nambiar]

knambiar added a comment.


  In D21915#482145 , @aacid wrote:
  
  > The other question is if "enabled" was ever the correct atom to check for
  >
  > libinput Tapping Enabled
  
  
  I'm fairly sure we were checking for `libinput Tapping Enabled` atom in the 
past, and so does GNOME: 
https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21915

To: aacid
Cc: knambiar, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart