KDE CI: Plasma » plasma-thunderbolt » stable-kf5-qt5 FreeBSDQt5.13 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-thunderbolt/job/stable-kf5-qt5%20FreeBSDQt5.13/1/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 07 Jul 2019 15:38:02 +
 Build duration:
10 hr and counting
   CONSOLE OUTPUT
  Started by upstream project "Administration/Global Rebuild Plasma stable-kf5-qt5 FreeBSDQt5.13" build number 1originally caused by: Started by user Ben CooksleyRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Plasma/plasma-thunderbolt/stable-kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2019-07-08T01:54:08.285Z] No credentials specified[2019-07-08T01:54:08.293Z] Cloning the remote Git repository[2019-07-07T16:49:40.449Z] Cloning repository git://anongit.kde.org/plasma-thunderbolt[2019-07-07T16:49:40.449Z]  > git init /usr/home/jenkins/workspace/Plasma/plasma-thunderbolt/stable-kf5-qt5 FreeBSDQt5.13 # timeout=10[2019-07-07T16:49:40.460Z] Fetching upstream changes from git://anongit.kde.org/plasma-thunderbolt[2019-07-07T16:49:40.460Z]  > git --version # timeout=10[2019-07-07T16:49:40.469Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-thunderbolt +refs/heads/*:refs/remotes/origin/* # timeout=120[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-07-07T16:49:42.787Z]  > git config remote.origin.url git://anongit.kde.org/plasma-thunderbolt # timeout=10[2019-07-07T16:49:42.795Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-07-07T16:49:42.823Z]  > git config remote.origin.url git://anongit.kde.org/plasma-thunderbolt # timeout=10[2019-07-07T16:49:42.835Z] Fetching upstream changes from git://anongit.kde.org/plasma-thunderbolt[2019-07-07T16:49:42.835Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-thunderbolt +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-07-07T16:49:43.035Z]  > git rev-parse Plasma/5.16^{commit} # timeout=10[2019-07-07T16:49:43.055Z]  > git rev-parse refs/remotes/origin/Plasma/5.16^{commit} # timeout=10[2019-07-07T16:49:43.075Z]  > git rev-parse Plasma/5.16^{commit} # timeout=10[2019-07-08T01:54:11.507Z] ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik added a comment.


  I don't know why it is not showing the context of the patch 路‍♂️
  I selected the plasma-pa project

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #vdg
Cc: plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik created this revision.
kezik added a reviewer: VDG.
kezik added a project: Plasma.
Herald added a subscriber: plasma-devel.
kezik requested review of this revision.

REVISION SUMMARY
  I think that the audio should not be garbled if you move fast the audio 
slider  (it distorts because it stops and plays the feedback sound every few 
milliseconds)
  
  An alternative approach is to `return`; if the `ca_context_playing` says that 
the sound is still playing, but that gives less "resolution"

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

AFFECTED FILES
  src/qml/volumefeedback.cpp
  src/qml/volumefeedback.h

To: kezik, #vdg
Cc: plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added a comment.


  @ratijastk please feel free to submit another patch that does the same thing, 
but addresses @broulik's concerns. Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22312: [DeviceNotifications] Keep last message for each device

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf811e448c76: [DeviceNotifications] Keep last message for 
each device (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22312?vs=61292=61294

REVISION DETAIL
  https://phabricator.kde.org/D22312

AFFECTED FILES
  dataengines/devicenotifications/ksolidnotify.cpp

To: bruns, #plasma, broulik, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19745: Fix system tray UI/UX & refactor

[Kai Uwe Broulik]

broulik added a comment.


  Fyi I reverted this change now 
https://cgit.kde.org/plasma-workspace.git/commit/?id=2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Nathaniel Graham]

ngraham added a reviewer: Plasma.
ngraham accepted this revision.
ngraham added a subscriber: hein.
ngraham added a comment.
This revision is now accepted and ready to land.


  I tested this with both mouse and touch. Though I could not reproduce the 
original issue, this patch does not introduce any regressions for me; in all 
cases, clicking/tapping and dragging both work correctly 100% of the time. The 
code change looks sensible as well.
  
  I'd like at least one #plasma  
review before we land this. Preferably @hein since he's most familiar with the 
code, but IIRC he's on vacation right now so I think anyone else would be fine 
too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22312: [DeviceNotifications] Keep last message for each device

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I just noticed this a few days ago and it was annoying me. I tested with 
three flash drives and an external hard drive. Three correctly removed the 
notice after the disk was actually physically removed, and one removed it after 
the 5 second timeout. So I think the logic there seems robust enough.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cleanup_devicenotifier

REVISION DETAIL
  https://phabricator.kde.org/D22312

To: bruns, #plasma, broulik, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  Is it more efficient from the performance point of view to have a 
QSortFilterProxyModel class per sorting method? I have a 6000 images case, 
would that be consuming compared to setting the sort class once according to 
the sorting method?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  In D22256#491942 , @davidedmundson 
wrote:
  
  > The fundamental problem with this approach is you only sort through the 
dirs correctly, but not the total across multiple paths.
  >
  > i.e
  >  If I have two paths dirA and dirB and want things sorted by date this 
patch will have all the images in dirA sorted by date, followed by all the 
images in dirB sorted by date.
  >
  > So for those reasons I think the other patch addresses works a bit better 
handling it dynamically, also allowing us to get rid of one of the model 
instances.
  
  
  Thank you! I agree with you, although it is not intended so.
  The other approach is more elegant, but I need also sorting as you have 
described. Perhaps some combined solution would be better.
  Still, being a QT newbie, I have no clear idea of the complexity of sorting 
for the other solution. Would it sort each time it looks for the next image? 
Would that cost? I'm running a big number of images, around 6000. What do you 
think?

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[David Edmundson]

davidedmundson added a comment.


  The fundamental problem with this approach is you only sort through the dirs 
correctly, but not the total across multiple paths.
  
  i.e
  If I have two paths dirA and dirB and want things sorted by date this patch 
will have all the images in dirA sorted by date, followed by all the images in 
dirB sorted by date.
  
  So for those reasons I think the other patch addresses works a bit better 
handling it dynamically, also allowing us to get rid of one of the model 
instances.

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22312: [DeviceNotifications] Keep last message for each device

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Ejecting e.g. a USB stick removes it from the bus (bus power is removed),
  but the last notification should be kept, otherwise a message like
  "The device can be savely removed" immediately disappears.
  
  Unfortunately it is almost impossible to tell when a device has been
  physically removed (only indirectly, when a new device is plugged into
  the same port), so allow some small leakage - in case the same device is
  later replugged, no leakage happens.

TEST PLAN
  Card reader:
  1.insert medium, mount, unmount
  
-> message "Device can be savely removed" is shown in device notifier
  
  for 5 seconds
  
  2. eject medium, reinsert -> device appears without message and with default 
label

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cleanup_devicenotifier

REVISION DETAIL
  https://phabricator.kde.org/D22312

AFFECTED FILES
  dataengines/devicenotifications/ksolidnotify.cpp

To: bruns, #plasma, broulik, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham added a comment.


  No worries!
  
  When landing a patch that was originally branched from master onto a 
different branch, I find that the following works well for me: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  IMHO, for lines like these, 'm_currentSlide = 
m_slideFilterModel->indexOf(path) - 1;', checks must be added because it is 
transparent to the QML code and let room for failure.
  
  Besides that, did you know that if there are no wallpapers, could be added 
one or more by drag and drop?
  Image files could be added by drag and drop, but never appear, although they 
are in the list, where should be folders only IMHO.
  They stay there, nothing happens, no background change on the desktop.
  Also, if a folder is added, 'Apply' button pressed, then removed, after 
'Apply', the background remains set to the last image, although I would have 
expected to have no image set as wallpaper.

INLINE COMMENTS

> davidre wrote in image.cpp:600
> Currently the slideshow would restart. I guess we could check here if the 
> index is -1. Or alternatively don't trigger this from the qml side if the 
> image is unchecked. In my mind this even better because then we enable the 
> apply button, too.

IMHO, here must be checked because it is transparent to the QML code and lets 
room for failure.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  In D22121#491833 , @davidedmundson 
wrote:
  
  > Nate's crash is due to data not code.
  >
  >   for (int i = 0; i < m_packages.size(); i++) {
  >   QString package = m_packages[i].path();
  >   if (package.at(package.length() - 1) == QChar::fromLatin1('/')) {   
<--- you know you crash on this line
  >   
  >   
  >
  > we're calling .at(length -1) unconditionally
  >
  > For an empty string our index will be -1.
  >
  > This hints towards an insertion bug rather than saying we should just add a 
guard here.
  
  
  Thanks for the hint David. @ngraham could you maybe try to get the path for 
which the crash happens (if package.length == 0) and how the folder structure 
for that image is added to your slideshow. Also it would be good to know if it 
happens if you start fresh and add it in the same way (then I could reproduce 
it) or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Albert Astals Cid]

aacid added a comment.


  In D22302#491786 , @ngraham wrote:
  
  > Oh, this was already landed, but Phab didn't notice because its commit 
message was altered to no longer include the `Differential Revision: 
https://phabricator.kde.org/D22302` text. Closing manually.
  
  
  Yeah, sorry about that, arc patch failed because of how the diff file was 
created and i forgot to manually add the differential line when recreating the 
commit

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  Indeed, at should crash, but when is that string empty?
  I can't crash mine, although inherits the same code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Nate's crash is due to data not code.
  
for (int i = 0; i < m_packages.size(); i++) {
QString package = m_packages[i].path();
if (package.at(package.length() - 1) == QChar::fromLatin1('/')) {   
<--- you know you crash on this line
  
  we're calling .at(length -1) unconditionally
  
  For an empty string our index will be -1.
  
  This hints towards an insertion bug rather than saying we should just add a 
guard here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  Ha Ha Ha! I know! I have asked you about, remember?
  Sometimes the actual build goes bananas and needs a reset.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 created this revision.
luc4 added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REVISION SUMMARY
  Since Plasma 5.16, clicks over the icons are frequently ignored. See 
https://bugs.kde.org/show_bug.cgi?id=408748 for more info. This patch is an 
attempt to fix that seems to work for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: luc4, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22302: fix kstart5 crash on wayland

[Igor Kovalenko]

garrison added a comment.


  anyway I confirm email address is correct - and will use git next time

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a subscriber: aacid.
ngraham added a comment.


  Oh, this was already landed, but Phab didn't notice because its commit 
message was altered to no longer include the `Differential Revision: 
https://phabricator.kde.org/D22302` text. Closing manually.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham added a comment.


  @garrison, can you provide your email address so we can land this patch with 
correct authorship information? Thanks!

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Nathaniel Graham]

ngraham added a comment.


  In D22121#491723 , @msdobrescu 
wrote:
  
  > In D22121#491369 , @ngraham 
wrote:
  >
  > > Huh, in a VM everything works for me too. I wonder if there's some subtle 
issue with the fact that I'm running a custom-compiled Plasma at a different 
path on bare metal.
  >
  >
  > Hi, I have followed this one, the new version, step by step: 
https://community.kde.org/Get_Involved/development#Plasma
  >  Before, some custom script was necessary, but did not work and all my 
crashes, I have experienced and told you about, were due to that. Could be some 
environment variable that pointed to something from the main install.
  >  I recommend to perform a full cleanup, follow again the testing setup, 
rebuild all the deps (kdesrc-build plasma-desktop plasma-workspace 
plasma-framework plasma-nm plasma-pa plasma-thunderbolt plasma-vault 
plasma-workspace-wallpapers kdeplasma-addons kwin systemsettings kscreen breeze 
discover kinfocenter --include-dependencies ~ and maybe add ~ --refresh-build), 
then test and see if it works. This was the way I've got rid of the errors that 
should not come in the first place, before developing and correcting it for 
real.
  
  
  Yes, that's how I do it. In fact, I'm one who wrote  that part of the 
documentation. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  In D22121#491369 , @ngraham wrote:
  
  > Huh, in a VM everything works for me too. I wonder if there's some subtle 
issue with the fact that I'm running a custom-compiled Plasma at a different 
path on bare metal.
  
  
  Hi, I have followed this one, the new version, step by step: 
https://community.kde.org/Get_Involved/development#Plasma
  Before, some custom script was necessary, but did not work and all my 
crashes, I have experienced and told you about, were due to that. Could be some 
environment variable that pointed to something from the main install.
  I recommend to perform a full cleanup, follow again the testing setup, 
rebuild all the deps (kdesrc-build plasma-desktop plasma-workspace 
plasma-framework plasma-nm plasma-pa plasma-thunderbolt plasma-vault 
plasma-workspace-wallpapers kdeplasma-addons kwin systemsettings kscreen breeze 
discover kinfocenter --include-dependencies ~ and maybe add ~ --refresh-build), 
then test and see if it works. This was the way I've got rid of the errors that 
should not come in the first place, before developing and correcting it for 
real.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Igor Kovalenko]

garrison created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
garrison requested review of this revision.

REVISION SUMMARY
  Make kstart query NETRootInfo only if it is running o QX11Info::isPlatformX11 
following porting guidelines.
  Verified by starting just crashed plasmashell via 'kstart5 plasmashell'
  BUG: 403965

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

AFFECTED FILES
  kstart/kstart.cpp

To: garrison
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart