D22344: Expose some more settings in an Advanced dialog

[Jan Grulich]

jgrulich added a comment.


  Don't you miss loading/saving of those properties in loadConfig() and 
setting() methods?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Continuation of D22191  and is built on 
top of it. Instead of having a niche option for a cursor theme with all the 
underlying infrastructure having to support it, grab it from a KDE config file 
and write to the SDDM config file.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  remove-cursor-theme-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22363

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/cursortheme/cursortheme.cpp
  src/cursortheme/cursortheme.h
  src/cursortheme/dummytheme.cpp
  src/cursortheme/dummytheme.h
  src/cursortheme/sortproxymodel.cpp
  src/cursortheme/sortproxymodel.h
  src/cursortheme/thememodel.cpp
  src/cursortheme/thememodel.h
  src/cursortheme/xcursortheme.cpp
  src/cursortheme/xcursortheme.h
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 61480.
filipf added a comment.


  .

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=61479=61480

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 61479.
filipf added a comment.


  better solution for fontconfig copy operations check

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=61411=61479

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7fa46fa74987: [ksmserver] Remove obsolete KDELibs4Support 
dependency (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22296?vs=61475=61476

REVISION DETAIL
  https://phabricator.kde.org/D22296

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/server.h

To: bruns, #plasma, broulik, davidedmundson
Cc: apol, sitter, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

[Stefan Brüns]

bruns updated this revision to Diff 61475.
bruns marked an inline comment as done.
bruns retitled this revision from "Port KSMServer to Solid::Power, drop 
KDELibs4Support requirement" to "[ksmserver] Remove obsolete KDELibs4Support 
dependency".
bruns edited the summary of this revision.
bruns removed subscribers: anthonyfieroni, sitter, apol.
bruns added a comment.


  remove inhibition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22296?vs=61249=61475

BRANCH
  ksmserver_no_kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D22296

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/server.h

To: bruns, #plasma, broulik, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart, anthonyfieroni, sitter

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61474.
apol added a comment.


  Addressed comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22344?vs=61426=61474

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22344

AFFECTED FILES
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv4widget.h
  libs/editor/settings/ui/ipv4.ui

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol marked 4 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in ipv4widget.cpp:455
> Doesn't seem to work? Or did you disable the dimming effect or is that a 
> quirk in conjunction with `QQuickWidget` in systemsettings?

Worked for me, I've seen issues with the list view on the left though. :/

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's do this!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21995

To: davidedmundson, #plasma, apol
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This reverts the following commits:
  fff556af1939d17453540f4388b27650359258dd 

  5de082c39b91f804fa6d50bfa9df9f7463d286dd 

  33be0f5b8b877a8a3bf99752ababf38b54d9145d 

  
  I think I did this change the wrong way. What we really need is a way to use 
different sizes for different panel widgets by default without making it 
impossible for users to configure the size.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-showdesktop-minimizall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22359

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/showdesktop/package/contents/ui/main.qml

To: ndavis, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18245: Create QApplication in a scope to work around possible deadlock

[Christoph Roick]

croick abandoned this revision.
croick added a comment.


  I can no longer reproduce the deadlock, so I'll abandon this.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Nathaniel Graham]

ngraham added a comment.


  I'd like to revisit this. Can we get back to it and fix the outstanding 
issues?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: mart, davidedmundson, bruns, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, domson, ashaposhnikov, astippich, spoorun, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, 
sebas, apol

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick added a comment.


  Thanks for your review. It was the last in a series of patches and I'll try 
to advertise the whole "Debug your KDE application with KDevelop"-feature 
somewhere.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 58 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/58/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 09 Jul 2019 20:40:24 +
 Build duration:
1 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-09T20:41:55.709Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-09T20:41:55.709Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-09T20:41:55.709Z] PROCESSOR_LEVEL   = '6'[2019-07-09T20:41:55.709Z] PROCESSOR_REVISION= '5e03'[2019-07-09T20:41:55.709Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-09T20:41:55.709Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-09T20:41:55.709Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-09T20:41:55.709Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-09T20:41:55.709Z] PROMPT= '$P$G'[2019-07-09T20:41:55.709Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-09T20:41:55.709Z] PUBLIC= 'C:\Users\Public'[2019-07-09T20:41:55.709Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/58/display/redirect?page=changes'[2019-07-09T20:41:55.709Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/58/display/redirect'[2019-07-09T20:41:55.709Z] STAGE_NAME= 'Configuring Build'[2019-07-09T20:41:55.709Z] SYSTEMDRIVE   = 'C:'[2019-07-09T20:41:55.709Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-09T20:41:55.709Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T20:41:55.709Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T20:41:55.709Z] UCRTVERSION   = '10.0.17763.0'[2019-07-09T20:41:55.709Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T20:41:55.709Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-07-09T20:41:55.709Z] USERNAME  = 'Jenkins'[2019-07-09T20:41:55.709Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-09T20:41:55.709Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-09T20:41:55.709Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-09T20:41:55.709Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-09T20:41:55.709Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-09T20:41:55.709Z] VCTOOLSVERSION= '14.16.27023'[2019-07-09T20:41:55.709Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-09T20:41:55.709Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-09T20:41:55.709Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-09T20:41:55.709Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-09T20:41:55.709Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-09T20:41:55.709Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-09T20:41:55.709Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-09T20:41:55.709Z] VSCMD_VER = '16.0.3'[2019-07-09T20:41:55.709Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-09T20:41:55.709Z] WINDIR= 'C:\WINDOWS'[2019-07-09T20:41:55.709Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-09T20:41:55.709Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-09T20:41:55.709Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T20:41:55.709Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-09T20:41:55.709Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-09T20:41:55.709Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-09T20:41:55.709Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-09T20:41:55.709Z] __DOTNET_ADD_64BIT= '1'[2019-07-09T20:41:55.709Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-09T20:41:55.709Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-09T20:41:55.709Z] 

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:95b6b8b613c2: Show debug button when KDevelop session is 
running (authored by croick).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11234?vs=61377=61456

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp
  src/drkonqidialog.h

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22344: Expose some more settings in an Advanced dialog

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ipv4widget.cpp:424
> +{
> +QPointer dlg = new QDialog(this);
> +

What's that `QPointer` for?
You might want to `dlg->setAttribute(Qt::WA_DeleteOnClose);`

> ipv4widget.cpp:427
> +auto layout = new QFormLayout(dlg);
> +dlg->setLayout(layout);
> +

I would prefer that you used a UI file for all of this

> ipv4widget.cpp:455
> +
> +dlg->setModal(true);
> +dlg->show();

Doesn't seem to work? Or did you disable the dimming effect or is that a quirk 
in conjunction with `QQuickWidget` in systemsettings?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham added a comment.


  Sorry for the delayed response! Let me block out some time to give it a 
whirl. I am left wondering if there's any simpler way we can do it though. 
KWidgetsAddons, Breeze, and Dolphin each have different release cycles, so 
making sure everything gets in at the right time and things work without other 
bits already present may be challenging.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22344: Expose some more settings in an Advanced dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ipv4widget.cpp:431
> +sendHostname->setChecked(m_tmpIpv4Setting.dhcpSendHostname());
> +layout->addRow(i18n("Send Hostname"), sendHostname);
> +

Add a colon and don't use Title Case: "Send hostname:"

> ipv4widget.cpp:435
> +dhcpHostname->setText(m_tmpIpv4Setting.dhcpHostname());
> +layout->addRow(i18n("DHCP Hostname"), dhcpHostname);
> +

Add a colon and don't use Title Case: "DHCP hostname:"

> ipv4widget.cpp:440
> +dadTimeout->setValue(m_tmpIpv4Setting.dadTimeout());
> +layout->addRow(i18n("DAD Timeout"), dadTimeout);
> +

Add a colon and don't use Title Case: "DAD timeout:"

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Plasma 5.16.3

[Jonathan Riddell]

Plasma 5.16.3 is now released
https://www.kde.org/announcements/plasma-5.16.3.php

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol added a comment.


  F6997365: Screenshot_20190709_183955.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  Was requested by some users who needed these fields and which are already 
offered by NM.

TEST PLAN
  Changed them, then changed them back.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22344

AFFECTED FILES
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv4widget.h
  libs/editor/settings/ui/ipv4.ui

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/28/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 09 Jul 2019 15:01:42 +
 Build duration:
4 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2019-07-09T15:06:14.828Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/28/display/redirect'[2019-07-09T15:06:14.828Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-07-09T15:06:14.828Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2019-07-09T15:06:14.828Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-09T15:06:14.828Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-07-09T15:06:14.828Z] NODE_NAME = 'Docker Swarm-4d7b7a264d63'[2019-07-09T15:06:14.828Z] HOST  = '4d7b7a264d63'[2019-07-09T15:06:14.828Z] LESSOPEN  = 'lessopen.sh %s'[2019-07-09T15:06:14.828Z] USER  = 'jenkins'[2019-07-09T15:06:14.828Z] MORE  = '-sl'[2019-07-09T15:06:14.828Z] CSHEDIT   = 'emacs'[2019-07-09T15:06:14.828Z] SHLVL = '2'[2019-07-09T15:06:14.828Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-28'[2019-07-09T15:06:14.828Z] WINDOWMANAGER = 'xterm'[2019-07-09T15:06:14.828Z] PAGER = 'less'[2019-07-09T15:06:14.828Z] EXECUTOR_NUMBER   = '0'[2019-07-09T15:06:14.828Z] CVS_RSH   = 'ssh'[2019-07-09T15:06:14.828Z] LIBGL_DEBUG   = 'quiet'[2019-07-09T15:06:14.828Z] STAGE_NAME= 'Configuring Build'[2019-07-09T15:06:14.828Z] NODE_LABELS   = 'Docker Swarm-4d7b7a264d63 SUSEQt5.12'[2019-07-09T15:06:14.828Z] XCURSOR_THEME = 'DMZ-Black'[2019-07-09T15:06:14.828Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-07-09T15:06:14.828Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-07-09T15:06:14.828Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-07-09T15:06:14.828Z] PROFILEREAD   = 'true'[2019-07-09T15:06:14.828Z] MAIL  = '/var/mail/jenkins'[2019-07-09T15:06:14.828Z] HOSTTYPE  = 'x86_64'[2019-07-09T15:06:14.828Z] BUILD_ID  = '28'[2019-07-09T15:06:14.828Z] LESSKEY   = '/etc/lesskey.bin'[2019-07-09T15:06:14.828Z] OLDPWD= '/home/jenkins'[2019-07-09T15:06:14.828Z] LC_CTYPE  = 'C.UTF-8'[2019-07-09T15:06:14.828Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-09T15:06:14.828Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-07-09T15:06:14.828Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-07-09T15:06:14.828Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-07-09T15:06:14.828Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-07-09T15:06:14.828Z] QT_SELECT = 'qt5'[2019-07-09T15:06:14.828Z] LANG  = 'en_US.UTF-8'[2019-07-09T15:06:14.828Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-09T15:06:14.828Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-07-09T15:06:14.828Z] [2019-07-09T15:06:14.828Z] [2019-07-09T15:06:14.828Z] == Commencing Configuration:[2019-07-09T15:06:14.828Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2019-07-09T15:06:15.391Z] -- The C compiler identification is GNU 9.1.1[2019-07-09T15:06:15.391Z] -- The CXX compiler identification is GNU 9.1.1[2019-07-09T15:06:15.391Z] -- Check for working C compiler: /usr/bin/cc[2019-07-09T15:06:15.391Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-09T15:06:15.391Z] -- Detecting C compiler ABI info[2019-07-09T15:06:16.332Z] -- Detecting C compiler ABI info - done[2019-07-09T15:06:16.332Z] -- Detecting C compile features[2019-07-09T15:06:18.240Z] -- Detecting C compile features - done[2019-07-09T15:06:18.240Z] -- Check for working CXX compiler: /usr/bin/c++[2019-07-09T15:06:18.240Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-07-09T15:06:18.240Z] -- Detecting CXX compiler ABI info[2019-07-09T15:06:19.944Z] -- Detecting CXX compiler ABI info - done[2019-07-09T15:06:19.944Z] 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/2/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 09 Jul 2019 14:50:52 +
 Build duration:
4 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 192 lines...][2019-07-09T14:55:27.280Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/display/redirect'[2019-07-09T14:55:27.280Z] MAIL  = '/var/mail/jenkins'[2019-07-09T14:55:27.280Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/2/display/redirect?page=changes'[2019-07-09T14:55:27.280Z] JENKINS_URL   = 'https://build.kde.org/'[2019-07-09T14:55:27.280Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-07-09T14:55:27.280Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2019-07-09T14:55:27.280Z] HUDSON_HOME   = '/home/production/data'[2019-07-09T14:55:27.280Z] BUILD_ID  = '2'[2019-07-09T14:55:27.280Z] OLDPWD= '/usr/home/jenkins'[2019-07-09T14:55:27.280Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-07-09T14:55:27.280Z] _ = '/usr/local/bin/java'[2019-07-09T14:55:27.280Z] TERM  = 'su'[2019-07-09T14:55:27.280Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.13'[2019-07-09T14:55:27.280Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-2'[2019-07-09T14:55:27.280Z] BUILD_DISPLAY_NAME= '#2'[2019-07-09T14:55:27.280Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/2/display/redirect'[2019-07-09T14:55:27.280Z] USER  = 'jenkins'[2019-07-09T14:55:27.280Z] HOME  = '/home/jenkins'[2019-07-09T14:55:27.280Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/2/'[2019-07-09T14:55:27.280Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2019-07-09T14:55:27.280Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-09T14:55:27.280Z] SHELL = '/usr/local/bin/bash'[2019-07-09T14:55:27.280Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-07-09T14:55:27.280Z] MM_CHARSET= 'UTF-8'[2019-07-09T14:55:27.280Z] STAGE_NAME= 'Configuring Build'[2019-07-09T14:55:27.280Z] NODE_NAME = 'FreeBSD Builder 1'[2019-07-09T14:55:27.280Z] BLOCKSIZE = 'K'[2019-07-09T14:55:27.280Z] EXECUTOR_NUMBER   = '0'[2019-07-09T14:55:27.280Z] SHLVL = '0'[2019-07-09T14:55:27.280Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-09T14:55:27.280Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-07-09T14:55:27.280Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-07-09T14:55:27.280Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-07-09T14:55:27.280Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-07-09T14:55:27.280Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-07-09T14:55:27.280Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-07-09T14:55:27.280Z] QT_SELECT = 'qt5'[2019-07-09T14:55:27.280Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-09T14:55:27.280Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-07-09T14:55:27.280Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-07-09T14:55:27.280Z] [2019-07-09T14:55:27.280Z] [2019-07-09T14:55:27.280Z] == Commencing Configuration:[2019-07-09T14:55:27.280Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2019-07-09T14:55:27.536Z] -- The C compiler identification is Clang 6.0.1[2019-07-09T14:55:27.536Z] -- The CXX compiler identification is Clang 6.0.1[2019-07-09T14:55:27.536Z] -- Check for working C compiler: /usr/bin/cc[2019-07-09T14:55:27.536Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-09T14:55:27.536Z] -- 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/28/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 09 Jul 2019 14:50:53 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 256 lines...][2019-07-09T14:51:42.719Z] OSTYPE= 'linux'[2019-07-09T14:51:42.719Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-07-09T14:51:42.719Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-07-09T14:51:42.719Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/28/display/redirect'[2019-07-09T14:51:42.719Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-07-09T14:51:42.719Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-07-09T14:51:42.719Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-09T14:51:42.719Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-07-09T14:51:42.719Z] NODE_NAME = 'Docker Swarm-57251b8e83bf'[2019-07-09T14:51:42.719Z] HOST  = '57251b8e83bf'[2019-07-09T14:51:42.719Z] LESSOPEN  = 'lessopen.sh %s'[2019-07-09T14:51:42.719Z] USER  = 'jenkins'[2019-07-09T14:51:42.719Z] MORE  = '-sl'[2019-07-09T14:51:42.719Z] CSHEDIT   = 'emacs'[2019-07-09T14:51:42.719Z] SHLVL = '2'[2019-07-09T14:51:42.719Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-28'[2019-07-09T14:51:42.720Z] WINDOWMANAGER = 'xterm'[2019-07-09T14:51:42.720Z] PAGER = 'less'[2019-07-09T14:51:42.720Z] EXECUTOR_NUMBER   = '0'[2019-07-09T14:51:42.720Z] CVS_RSH   = 'ssh'[2019-07-09T14:51:42.720Z] LIBGL_DEBUG   = 'quiet'[2019-07-09T14:51:42.720Z] STAGE_NAME= 'Configuring Build'[2019-07-09T14:51:42.720Z] NODE_LABELS   = 'Docker Swarm-57251b8e83bf SUSEQt5.12'[2019-07-09T14:51:42.720Z] XCURSOR_THEME = 'DMZ-Black'[2019-07-09T14:51:42.720Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-07-09T14:51:42.720Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-07-09T14:51:42.720Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-07-09T14:51:42.720Z] PROFILEREAD   = 'true'[2019-07-09T14:51:42.720Z] MAIL  = '/var/mail/jenkins'[2019-07-09T14:51:42.720Z] HOSTTYPE  = 'x86_64'[2019-07-09T14:51:42.720Z] BUILD_ID  = '28'[2019-07-09T14:51:42.720Z] LESSKEY   = '/etc/lesskey.bin'[2019-07-09T14:51:42.720Z] OLDPWD= '/home/jenkins'[2019-07-09T14:51:42.720Z] LC_CTYPE  = 'C.UTF-8'[2019-07-09T14:51:42.720Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-09T14:51:42.720Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-07-09T14:51:42.720Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-07-09T14:51:42.720Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-07-09T14:51:42.720Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-07-09T14:51:42.720Z] QT_SELECT = 'qt5'[2019-07-09T14:51:42.720Z] LANG  = 'en_US.UTF-8'[2019-07-09T14:51:42.720Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-09T14:51:42.720Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-07-09T14:51:42.720Z] [2019-07-09T14:51:42.720Z] [2019-07-09T14:51:42.720Z] == Commencing Configuration:[2019-07-09T14:51:42.720Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2019-07-09T14:51:42.978Z] -- The C compiler identification is GNU 9.1.1[2019-07-09T14:51:43.234Z] -- The CXX compiler identification is GNU 9.1.1[2019-07-09T14:51:43.234Z] -- Check for working C compiler: /usr/bin/cc[2019-07-09T14:51:43.234Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-09T14:51:43.234Z] -- Detecting C compiler ABI info[2019-07-09T14:51:43.490Z] -- Detecting C compiler ABI info - done[2019-07-09T14:51:43.490Z] -- Detecting C compile features[2019-07-09T14:51:44.419Z] -- Detecting C compile features - done[2019-07-09T14:51:44.419Z] -- Check for working CXX compiler: 

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 61411.
filipf added a comment.


  - Merge branch 'master' into sddm-theme-syncing

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=61109=61411

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22341: [mobile/wifi] Port to SimpleKCM

[Marco Martin]

mart accepted this revision.
mart added a comment.


  LGTM,
  still needs approval by Jan

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22341

To: nicolasfella, #plasma, mart, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22341: [mobile/wifi] Port to SimpleKCM

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The plasma-settings app assumes all KCMs to be based on the types from 
KDeclarative

TEST PLAN
  Runs in plasma-settings

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  simple

REVISION DETAIL
  https://phabricator.kde.org/D22341

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkListView.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, #plasma, mart, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:93
> +// copy kdeglobals (color scheme)
> +if (!args[QStringLiteral("kdeglobals")].isNull()) {
> +QDir kdeglobalsSource(args[QStringLiteral("kdeglobals")].toString());

what would happen if:

- there is no /var/lib/sddm/.config yet
- the user hasn't got a fontconfig to copy
- they do have a kdeglobals

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61407.
apol added a comment.


  Don't move Solid::Device instances between threads

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22333?vs=61379=61407

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22333

AFFECTED FILES
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/hotplug/hotplugengine.cpp
  dataengines/hotplug/hotplugengine.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22122: use pwquality_strerror to get error strings

[Harald Sitter]

sitter added a comment.


  In D22122#487601 , @davidedmundson 
wrote:
  
  > Concept makes sense.
  >  +1
  >
  > @ltoscano can you confirm you're ok from an i18n side.
  
  
  ping @ltoscano

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma
Cc: davidedmundson, ltoscano, anthonyfieroni, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  some style annoyances. fix it then ship it 

INLINE COMMENTS

> drkonqi.cpp:254
> +
> +QObject::connect(btGenerator, ::done, 
> );
> +QObject::connect(btGenerator, ::someError, 
> );

I think three-argument connects are considered bad form, you may want to add a 
scoping object for the slot.

> main.cpp:37
>  #include 
> +#include 
> +#include 

these two includes look unused

> main.cpp:56
>  #include "statusnotifier.h"
> +#include "debuggermanager.h"
> +#include "backtracegenerator.h"

these 2 includes look unused

REPOSITORY
  R871 DrKonqi

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 57 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/57/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 09 Jul 2019 10:05:40 +
 Build duration:
9 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-09T10:14:54.776Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-09T10:14:54.776Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 42 Stepping 1, GenuineIntel'[2019-07-09T10:14:54.776Z] PROCESSOR_LEVEL   = '6'[2019-07-09T10:14:54.776Z] PROCESSOR_REVISION= '2a01'[2019-07-09T10:14:54.776Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-09T10:14:54.776Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-09T10:14:54.776Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-09T10:14:54.776Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-09T10:14:54.776Z] PROMPT= '$P$G'[2019-07-09T10:14:54.776Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-09T10:14:54.776Z] PUBLIC= 'C:\Users\Public'[2019-07-09T10:14:54.776Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/57/display/redirect?page=changes'[2019-07-09T10:14:54.776Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/57/display/redirect'[2019-07-09T10:14:54.776Z] STAGE_NAME= 'Configuring Build'[2019-07-09T10:14:54.776Z] SYSTEMDRIVE   = 'C:'[2019-07-09T10:14:54.776Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-09T10:14:54.776Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T10:14:54.776Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T10:14:54.776Z] UCRTVERSION   = '10.0.17763.0'[2019-07-09T10:14:54.776Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T10:14:54.776Z] USERDOMAIN= 'DESKTOP-V7LQR8M'[2019-07-09T10:14:54.776Z] USERNAME  = 'Jenkins'[2019-07-09T10:14:54.776Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-09T10:14:54.776Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-09T10:14:54.776Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-09T10:14:54.776Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-09T10:14:54.776Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-09T10:14:54.776Z] VCTOOLSVERSION= '14.16.27023'[2019-07-09T10:14:54.776Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-09T10:14:54.776Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-09T10:14:54.777Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-09T10:14:54.777Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-09T10:14:54.777Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-09T10:14:54.777Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-09T10:14:54.777Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-09T10:14:54.777Z] VSCMD_VER = '16.0.3'[2019-07-09T10:14:54.777Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-09T10:14:54.777Z] WINDIR= 'C:\WINDOWS'[2019-07-09T10:14:54.777Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-09T10:14:54.777Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-09T10:14:54.777Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T10:14:54.777Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-09T10:14:54.777Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-09T10:14:54.777Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-09T10:14:54.777Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-09T10:14:54.777Z] __DOTNET_ADD_64BIT= '1'[2019-07-09T10:14:54.777Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-09T10:14:54.777Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-09T10:14:54.777Z] 

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Heh. Fair enough, I too ran down the wrong rabbit hole with the size issue 
until I noticed the policy was wrong.
  
  Diff looks good now. Works very well too. 

REPOSITORY
  R871 DrKonqi

BRANCH
  nicebutton

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/16/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 09 Jul 2019 10:05:40 +
 Build duration:
12 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Windows Builder 1 in C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2019-07-09T10:05:43.067Z] [2019-07-09T10:05:43.067Z] C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11>if exist "C:\CI\Software Installs\drkonqi" rmdir /s /q "C:\CI\Software Installs\drkonqi" [Pipeline] checkout[2019-07-09T10:05:43.279Z] No credentials specified[2019-07-09T10:05:43.282Z] Cloning the remote Git repository[2019-07-09T10:05:43.826Z] Cloning repository git://anongit.kde.org/drkonqi[2019-07-09T10:05:43.826Z]  > git init C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11 # timeout=10[2019-07-09T10:05:43.888Z] Fetching upstream changes from git://anongit.kde.org/drkonqi[2019-07-09T10:05:43.889Z]  > git --version # timeout=10[2019-07-09T10:05:43.923Z]  > git fetch --tags --progress git://anongit.kde.org/drkonqi +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-07-09T10:05:50.353Z]  > git config remote.origin.url git://anongit.kde.org/drkonqi # timeout=10[2019-07-09T10:05:50.386Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-07-09T10:05:50.425Z]  > git config remote.origin.url git://anongit.kde.org/drkonqi # timeout=10[2019-07-09T10:05:50.467Z] Fetching upstream changes from git://anongit.kde.org/drkonqi[2019-07-09T10:05:50.467Z]  > git fetch --tags --progress git://anongit.kde.org/drkonqi +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-07-09T10:05:50.674Z] Checking out Revision 1d7464b58f59116e5ff6771b4d0a5e1b0f0a8762 (refs/remotes/origin/Plasma/5.16)[Pipeline] }[Pipeline] // stage[2019-07-09T10:05:51.131Z]  > git rev-parse "Plasma/5.16^{commit}" # timeout=10[2019-07-09T10:05:51.176Z]  > git rev-parse "refs/remotes/origin/Plasma/5.16^{commit}" # timeout=10[2019-07-09T10:05:51.215Z]  > git config core.sparsecheckout # timeout=10[2019-07-09T10:05:51.248Z]  > git checkout -f 1d7464b58f59116e5ff6771b4d0a5e1b0f0a8762 # timeout=10[Pipeline] }[2019-07-09T10:05:51.653Z] hudson.plugins.git.GitException: Command "git checkout -f 1d7464b58f59116e5ff6771b4d0a5e1b0f0a8762" returned status code 1:[2019-07-09T10:05:51.653Z] stdout: [2019-07-09T10:05:51.653Z] stderr: error: unable to create file src/tests/integration/xml-data/show_bug.cgi?id=375161=xml: Invalid argument[2019-07-09T10:05:51.653Z] Note: checking out '1d7464b58f59116e5ff6771b4d0a5e1b0f0a8762'.[2019-07-09T10:05:51.653Z] [2019-07-09T10:05:51.653Z] You are in 'detached HEAD' state. You can look around, make experimental[2019-07-09T10:05:51.653Z] changes and commit them, and you can discard any commits you make in this[2019-07-09T10:05:51.653Z] state without impacting any branches by performing another checkout.[2019-07-09T10:05:51.653Z] [2019-07-09T10:05:51.653Z] If you want to create a new branch to retain commits you create, you may[2019-07-09T10:05:51.653Z] do so (now or later) by using -b with the checkout command again. Example:[2019-07-09T10:05:51.653Z] [2019-07-09T10:05:51.653Z]   git checkout -b [2019-07-09T10:05:51.653Z] [2019-07-09T10:05:51.653Z] HEAD is now at 1d7464b5 update integration test[2019-07-09T10:05:51.653Z] [2019-07-09T10:05:51.653Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-07-09T10:05:51.653Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$900(CliGitAPIImpl.java:81)[2019-07-09T10:05:51.653Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2627)[2019-07-09T10:05:51.653Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from aranea.kde.org/195.201.167.114:62799[2019-07-09T10:05:51.653Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)[2019-07-09T10:05:51.653Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)[2019-07-09T10:05:51.653Z] 		at hudson.remoting.Channel.call(Channel.java:957)[2019-07-09T10:05:51.653Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2019-07-09T10:05:51.653Z] 		at sun.reflect.GeneratedMethodAccessor309.invoke(Unknown Source)[2019-07-09T10:05:51.653Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2019-07-09T10:05:51.653Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2019-07-09T10:05:51.653Z] 		at 

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  Could it be some threading issue?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  So I'm crashing when I hit apply and then ok because `addURL` is called from 
qml with an empty string and I don't understand why. In main.qml I have
  
onConfiguredImageChanged: {
  if (modelImage != configuredImage) {
  console.log("configured Image" + wallpaper.configuration.Image);
  console.log(configuredImage + "!=" + modelImage)
  imageWallpaper.addUrl(configuredImage);
  }
  }
  onModelImageChanged:{
  Qt.callLater(loadImage);
  console.log("mic to "+modelImage);
  wallpaper.configuration.Image = modelImage;
  console.log("mic:" + wallpaper.configuration.Image +" configimage:" 
+configuredImage);

  }
  
  On apply :
  
qml: mic to file:///home/david/testimages/hk5lmt9qxfw21.jpg
qml: mic:file:///home/david/testimages/hk5lmt9qxfw21.jpg 
configimage:file:///home/david/testimages/hk5lmt9qxfw21.jpg
  
  Then clicking on OK
  
qml: configured Image
qml: !=file:///home/david/testimages/hk5lmt9qxfw21.jpg
  
  What I dont understand is why this happens. When pressing OK without apply 
everything works as I would expect it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 56 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/56/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 09 Jul 2019 09:13:19 +
 Build duration:
1 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-09T09:14:58.507Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-09T09:14:58.507Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-09T09:14:58.507Z] PROCESSOR_LEVEL   = '6'[2019-07-09T09:14:58.507Z] PROCESSOR_REVISION= '5e03'[2019-07-09T09:14:58.507Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-09T09:14:58.507Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-09T09:14:58.507Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-09T09:14:58.507Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-09T09:14:58.507Z] PROMPT= '$P$G'[2019-07-09T09:14:58.507Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-09T09:14:58.507Z] PUBLIC= 'C:\Users\Public'[2019-07-09T09:14:58.507Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/56/display/redirect?page=changes'[2019-07-09T09:14:58.507Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/56/display/redirect'[2019-07-09T09:14:58.507Z] STAGE_NAME= 'Configuring Build'[2019-07-09T09:14:58.507Z] SYSTEMDRIVE   = 'C:'[2019-07-09T09:14:58.507Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-09T09:14:58.507Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T09:14:58.507Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T09:14:58.507Z] UCRTVERSION   = '10.0.17763.0'[2019-07-09T09:14:58.507Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T09:14:58.507Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-07-09T09:14:58.507Z] USERNAME  = 'Jenkins'[2019-07-09T09:14:58.507Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-09T09:14:58.507Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-09T09:14:58.507Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-09T09:14:58.507Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-09T09:14:58.507Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-09T09:14:58.507Z] VCTOOLSVERSION= '14.16.27023'[2019-07-09T09:14:58.507Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-09T09:14:58.507Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-09T09:14:58.507Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-09T09:14:58.507Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-09T09:14:58.507Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-09T09:14:58.507Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-09T09:14:58.507Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-09T09:14:58.507Z] VSCMD_VER = '16.0.3'[2019-07-09T09:14:58.507Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-09T09:14:58.507Z] WINDIR= 'C:\WINDOWS'[2019-07-09T09:14:58.507Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-09T09:14:58.507Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-09T09:14:58.507Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T09:14:58.507Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-09T09:14:58.507Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-09T09:14:58.507Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-09T09:14:58.507Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-09T09:14:58.507Z] __DOTNET_ADD_64BIT= '1'[2019-07-09T09:14:58.507Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-09T09:14:58.507Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-09T09:14:58.507Z] 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 55 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/55/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 09 Jul 2019 06:52:59 +
 Build duration:
1 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-09T06:54:27.607Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-09T06:54:27.607Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-09T06:54:27.607Z] PROCESSOR_LEVEL   = '6'[2019-07-09T06:54:27.607Z] PROCESSOR_REVISION= '5e03'[2019-07-09T06:54:27.607Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-09T06:54:27.607Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-09T06:54:27.607Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-09T06:54:27.607Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-09T06:54:27.607Z] PROMPT= '$P$G'[2019-07-09T06:54:27.607Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-09T06:54:27.607Z] PUBLIC= 'C:\Users\Public'[2019-07-09T06:54:27.607Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/55/display/redirect?page=changes'[2019-07-09T06:54:27.607Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/55/display/redirect'[2019-07-09T06:54:27.607Z] STAGE_NAME= 'Configuring Build'[2019-07-09T06:54:27.607Z] SYSTEMDRIVE   = 'C:'[2019-07-09T06:54:27.607Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-09T06:54:27.607Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T06:54:27.607Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-09T06:54:27.607Z] UCRTVERSION   = '10.0.17763.0'[2019-07-09T06:54:27.607Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T06:54:27.607Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-09T06:54:27.607Z] USERNAME  = 'Jenkins'[2019-07-09T06:54:27.607Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-09T06:54:27.607Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-09T06:54:27.607Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-09T06:54:27.607Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-09T06:54:27.607Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-09T06:54:27.607Z] VCTOOLSVERSION= '14.16.27023'[2019-07-09T06:54:27.607Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-09T06:54:27.607Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-09T06:54:27.608Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-09T06:54:27.608Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-09T06:54:27.608Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-09T06:54:27.608Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-09T06:54:27.608Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-09T06:54:27.608Z] VSCMD_VER = '16.0.3'[2019-07-09T06:54:27.608Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-09T06:54:27.608Z] WINDIR= 'C:\WINDOWS'[2019-07-09T06:54:27.608Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-09T06:54:27.608Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-09T06:54:27.608Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-09T06:54:27.608Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-09T06:54:27.608Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-09T06:54:27.608Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-09T06:54:27.608Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-09T06:54:27.608Z] __DOTNET_ADD_64BIT= '1'[2019-07-09T06:54:27.608Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-09T06:54:27.608Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-09T06:54:27.608Z]