D22306: Do not skip code launching application in application dashboard

[Eike Hein]

hein added a comment.


  First of, run `kdebugsettings` and make sure that debug output isn't disabled 
on your system.
  
  Then you can e.g. stop plasmashell from a terminal with: `kquitapp5 
plasmashell`
  
  And restart it with `plasmashell`, and you'll see `console.log` output on the 
terminal.
  
  If you don't want to muck with your plasmashell, you can also run a seperate 
instance of just Dashboard, which will also cut down on unrelated debug output 
noise: `plasmawindowed org.kde.plasma.kickerdash`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Eike Hein]

hein added a comment.


  How about - and sorry if you're tired of the patch by now - "Change workspace 
and application languages"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

[Eike Hein]

hein added a comment.


  The idea and approach are good.
  
  But disk I/O in a UI hotpath is pretty scary. I do think a cache would be a 
good addition.
  
  In general I think libtm could use some improvements on its currently very 
coarse cache eviction scheme. It's mostly fine but there are some edge cases 
where we end up doing I/O on things we know we haven't changed. Unfortunately 
though improving that just means doing the legwork of going case-by-case and 
the complexity it invites ... i.e. a cache here.
  
  (Slightly unrelated: I have the beginnings of a patch set that uses 
KUserFeedback to gather telemetry on how often we use which identification 
means and why. I have this persistent feeling that we're falling through to the 
suboptimal/expensive code paths way more than we should currently, and there 
are probably minor changes to do "higher up in the file" to fix that. One is 
probably the neverending woes around normalizing for reverse DNS vs. plain 
.desktop file names. But in general I'd love for my system to be able go give 
me a trend curve for "Task Manager app identification expensiveness over time" 
to I can see when there's new regressions and/or changes in the app landscape.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22506

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Eike Hein]

hein added a comment.


  Sorry, the cryptic comment can be safely ignored. I had a concern at first, 
then looked into it, decided I'm OK with the patch and forgot the started 
sentence. :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yep, that did it!

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61944.
apol added a comment.


  Hopefully address Nate's complaint on how it ends up behind the expanded 
plasmoid

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61885=61944

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf planned changes to this revision.
filipf added a comment.


  This should now be completely functional. In order to proceed further, the 
dependent revision needs to be landed and then this patch rebased on master.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22363

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf updated this revision to Diff 61940.
filipf added a comment.


  remove CursorTheme entry in config file when resetting theme syncing

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22363?vs=61481=61940

BRANCH
  remove-cursor-theme-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22363

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/cursortheme/cursortheme.cpp
  src/cursortheme/cursortheme.h
  src/cursortheme/dummytheme.cpp
  src/cursortheme/dummytheme.h
  src/cursortheme/sortproxymodel.cpp
  src/cursortheme/sortproxymodel.h
  src/cursortheme/thememodel.cpp
  src/cursortheme/thememodel.h
  src/cursortheme/xcursortheme.cpp
  src/cursortheme/xcursortheme.h
  src/ui/advanceconfig.ui

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22517: kcms: translations: Make list separator translatable

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R120 Plasma Workspace

BRANCH
  i18n-sep

REVISION DETAIL
  https://phabricator.kde.org/D22517

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml

To: aspotashev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08a802656df5: kcms: translations: use 
availableDomainTranslations from plasmashell instead of… (authored by 
jbbgameich).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22503?vs=61894=61931

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Jonah Brüchert]

jbbgameich updated this revision to Diff 61930.
jbbgameich added a comment.


  Update description once again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=51321=61930

BRANCH
  arcpatch-D18860

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Bhushan Shah]

bshah added a comment.


  (me confused by cryptic comment) :P

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  This creayes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Shows a busy indicator in the TextField.
  
  Depends on D22513 

TEST PLAN
  Searched things, eventually it disappears, I sometimes don't really know 
what's still doing, maybe we could add some more information at some point.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22514

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22513: Expose if we're still searching for more results

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Tested with a patch in plasma-workspace I'll upload shortly

REPOSITORY
  R112 Milou

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22513

AFFECTED FILES
  lib/qml/ResultsView.qml
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Stefan Brüns]

bruns added a comment.


  In D22333#496544 , @davidedmundson 
wrote:
  
  > Kinda, you're summary missing a key part.
  >  (the commit description is a bit poor)
  >
  > This patch does the following:
  >
  > - It does the search in the other thread. That creates and iterates every 
possible device. This is expensive as there are lots of potential devices. We 
fetch pretty much everything udisks knows.
  > - From the given list we recreate the select few devices that are relevant. 
This is relatively cheap. It does still block as you point out, but now for a 
much much smaller set of objects compared to before.
  >
  >   (on my laptop that's 56 devices created when searching, resulting in 8 
useful devices).
  
  
  Just for clarification:
  
  On my system, `solid-hardware5 list` returns 77 devices, but with the 
Predicate Filter I am down to 10, and this is filtered by the hotplug engine 
down to 7.
  
  Half of the devices (32) are serial ports. These are returned by the udev 
backend, but when combined with the "Camera | PortableMediaPlayer" predicate, 
the udev backend returns an empty list and nothing is instantiated.
  
  The enumeration in the udev backend, especially 'PortableMediaPlayer' has 
become much cheaper since https://phabricator.kde.org/D21379.
  
  The Udisks backend indeed returns to much, and unfortunately it creates a 
backend device for each block device, which implies a number of DBus 
roundtrips. But this would come down to a single DBus call when D19677 
 lands.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: anthonyfieroni, bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22034: Introduce ContainmentLayoutManager QML plugin

[David Edmundson]

davidedmundson added a comment.


  Concept makes sense. I mostly like the layering and architecture, except for 
all the cases where we end up searching up the hierarchy to find objects. That 
doesn't seem quite as nicely layered.
  
  I'm not finished, it's a big patch - but I thought I should submit what I 
have for now.

INLINE COMMENTS

> abstractlayoutmanager.cpp:110
> +QRectF candidate = candidateGeometry(item);
> +item->setX(candidate.x());
> +item->setY(candidate.y());

setPosition

setSize

> abstractlayoutmanager.h:44
> + */
> +QSizeF cellAlignedContainingSize(const QSizeF ) const;
> +

I don't fully understand the split between AbstractLayoutManager and 
GridLayoutManager when AbstractLayoutManager effectively enforces a grid by 
having cell sizes.

> appletcontainer.cpp:32
> +{
> +connect(this, ::contentItemChanged, this, [this]() {
> +if (m_appletItem) {

How do we know this happens after the busy component is set?

> itemcontainer.cpp:364
> +
> +QQuickItem *item;
> +for (auto *o : m_contentData) {

scope this in the loop

> itemcontainer.cpp:370
> +} else {
> +o->setParent(this);
> +}

why?

> itemcontainer.cpp:375
> +// Search for the Layout attached property
> +// Qt6: this should become public api
> +for (auto *o : children()) {

no point just wishing, we need to open a bug report at least

> itemcontainer.cpp:438
> +if (newPreferredHeight > height()) {
> +setHeight(layout()->cellHeight() * ceil(newPreferredHeight / 
> layout()->cellHeight()));
> +changed = true;

why?

We're above the minimum size, the user could have resized it smaller than this

> BasicResizeHandle.qml:26
> +ContainmentLayoutManager.ResizeHandle {
> +resizeCorner: ContainmentLayoutManager.ResizeHandle2.Right
> +

ResizeHandle2?

> resizehandle.cpp:42
> +
> +connect(this, ::parentChanged, this, [this]() {
> +QQuickItem *candidate = parentItem();

we monitor the direct parent, but ConfigOverlay could be anywhere on the 
ancestory tree.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22034

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

[Nathaniel Graham]

ngraham added a comment.


  I'm not seeing any change from this patch in the wallpaper chooser page for 
example. Clicking on the combobox while the popup is open still doesn't close 
it.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22509

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61916.
cblack added a comment.


  Hide logo by default

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61859=61916

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma, filipf, ngraham
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10750: [wayland] Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg updated this revision to Diff 61915.
romangg marked 2 inline comments as done.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10750?vs=60898=61915

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10750

AFFECTED FILES
  platformsupport/scenes/opengl/CMakeLists.txt
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/drm_fourcc.h
  platformsupport/scenes/opengl/linux_dmabuf.cpp
  platformsupport/scenes/opengl/linux_dmabuf.h

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
fmonteiro, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

D10750: [wayland] Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg marked an inline comment as done.
romangg added inline comments.

INLINE COMMENTS

> romangg wrote in abstract_egl_backend.cpp:405
> rm

Nope, better not. Overlooked the `m_`.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
fmonteiro, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg added a comment.


  If there are no objections I would push this soon.
  
  There is one remaining annoyance I have with the current version: the name of 
the class inside the interface the compositor has to subclass for interfacing 
with KWayland. I changed the name from Bridge to Impl since Bridge can be 
anything and as we use the name Impl in KWin already for stuff like this. But 
there it's used for the subclass and not for the abstract implementation base 
class. Any other idea for a good name?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, fmonteiro, 
sbergeron, hannahk, jraleigh, sgureev, fbampaloukas, GB_2, ragreen, Pitel, 
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 61912.
romangg added a comment.


  - Rebase on master
  - Use packaged dma-buf xml

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60654=61912

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, fmonteiro, 
sbergeron, hannahk, jraleigh, sgureev, fbampaloukas, GB_2, ragreen, Pitel, 
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D22493: [Notifications] Move history items' icons over to the left a bit

[Kai Uwe Broulik]

broulik added a comment.


  No, no, leave the popup :P I was asking to make sure it doesn't accidentally 
change the popups.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Nathaniel Graham]

ngraham added a comment.


  Yeah, this patch touches only the history items, not the popups. I can do 
that too, if you'd like.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> broulik wrote in OutputPanel.qml:41
> Try `Kirigami.FormData.checkable: true` to make the checkbox to the left 
> instead of having a lonely tiny checkbox floating there

Then there are two checkboxes. Looked at Night Color KCM, which does it by just 
setting the text instead of the FormData.label. Changed it to that for now

> broulik wrote in Panel.qml:34
> Have you tried `twinFormLayouts`?

Nice!

> broulik wrote in Panel.qml:98
> Can we make it not show all the tick marks but only the integer ones like in 
> the current scale UI?

Not with the default Slider style. Maybe needs a custom slider style or 
something?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg updated this revision to Diff 61910.
romangg marked 23 inline comments as done.
romangg added a comment.


  - Message on backend error
  - Use switch statements in OutputModel
  - Initialize roleNames from super class
  - i18n labels
  - Checkboxes to the left
  - Set onClicked
  - Combobox for resolutions
  - Use 0.1 scale step size
  - Name label Global scale
  - Button group for orientations
  - Use Rotation enum
  - Do not fill width on comboboxes
  - Refresh rate formatting
  - Use twinFormLayouts property
  - Use onMoved and onClicked
  - Output retention enum in QML
  - Do not use PlasmaComponents
  - Pretty-format scale text
  - Change retention description
  - Add colons to labels

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22468?vs=61775=61910

BRANCH
  qmlize

REVISION DETAIL
  https://phabricator.kde.org/D22468

AFFECTED FILES
  CMakeLists.txt
  common/control.h
  common/utils.cpp
  common/utils.h
  kcm/CMakeLists.txt
  kcm/Messages.sh
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kscreen.desktop
  kcm/kcm_kscreen.desktop.cmake
  kcm/output_identifier.cpp
  kcm/output_identifier.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/RotationButton.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml
  kcm/package/metadata.desktop
  kcm/qml/CMakeLists.txt
  kcm/qml/Output.qml
  kcm/qml/OutputIdentifier.qml
  kcm/qml/Tip.qml
  kcm/qml/main.qml
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmloutput.h
  kcm/src/declarative/qmloutputcomponent.cpp
  kcm/src/declarative/qmloutputcomponent.h
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/declarative/qmlscreen.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h
  kcm/src/kcm_testapp.cpp
  kcm/src/kscreen_widget.ui
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/previewwidget.cpp
  kcm/src/previewwidget.h
  kcm/src/resolutionslider.cpp
  kcm/src/resolutionslider.h
  kcm/src/scaling.ui
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/stylepreview.ui
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/utils.cpp
  kcm/src/utils.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/CMakeLists.txt
  kded/osd.cpp
  tests/osd/CMakeLists.txt

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures clicking the `ComboBox` itself closes the popup as it does with 
widget `QComboBox`.
  While Qt documentation for `Popup` says that is the default, `QQuickComboBox` 
explicitly overwrites it to be `CloseOnPressOutsideParent` instead for whatever 
reason.
  For our usecase the `CloseOnPressOutside` behavior makes more sense.
  
  BUG: 408950

TEST PLAN
  - Opened QQC2 combobox, clicked on it again, it closed :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22509

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 added a comment.


  Unfortunately I'm not able to get logs from plasma-desktop. Can someone 
explain how (assuming this is possible) to write logs in this portion of code 
and read? Or can you point me to docs? I tried to add console.log calls and 
read using journalctl but I don't see the logs. Can someone help so I can check 
the values of those variables? Thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61901.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Change default collectionId to all wallpapers instead of desktop wallpaper

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61899=61901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/generate_unsplash_provider.sh
  dataengines/potd/unsplashanimalprovider.cpp
  dataengines/potd/unsplashanimalprovider.h
  dataengines/potd/unsplashanimalprovider.json
  dataengines/potd/unsplashbackgroundprovider.cpp
  dataengines/potd/unsplashbackgroundprovider.h
  dataengines/potd/unsplashbackgroundprovider.json
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashbeachprovider.cpp
  dataengines/potd/unsplashbeachprovider.h
  dataengines/potd/unsplashbeachprovider.json
  dataengines/potd/unsplashblackprovider.cpp
  dataengines/potd/unsplashblackprovider.h
  dataengines/potd/unsplashblackprovider.json
  dataengines/potd/unsplashcarprovider.cpp
  dataengines/potd/unsplashcarprovider.h
  dataengines/potd/unsplashcarprovider.json
  dataengines/potd/unsplashchristmasprovider.cpp
  dataengines/potd/unsplashchristmasprovider.h
  dataengines/potd/unsplashchristmasprovider.json
  dataengines/potd/unsplashcoolprovider.cpp
  dataengines/potd/unsplashcoolprovider.h
  dataengines/potd/unsplashcoolprovider.json
  dataengines/potd/unsplashcuteprovider.cpp
  dataengines/potd/unsplashcuteprovider.h
  dataengines/potd/unsplashcuteprovider.json
  dataengines/potd/unsplashdesignprovider.cpp
  dataengines/potd/unsplashdesignprovider.h
  dataengines/potd/unsplashdesignprovider.json
  dataengines/potd/unsplashfallprovider.cpp
  dataengines/potd/unsplashfallprovider.h
  dataengines/potd/unsplashfallprovider.json
  dataengines/potd/unsplashflowerprovider.cpp
  dataengines/potd/unsplashflowerprovider.h
  dataengines/potd/unsplashflowerprovider.json
  dataengines/potd/unsplashfunnyprovider.cpp
  dataengines/potd/unsplashfunnyprovider.h
  dataengines/potd/unsplashfunnyprovider.json
  dataengines/potd/unsplashgalaxyprovider.cpp
  dataengines/potd/unsplashgalaxyprovider.h
  dataengines/potd/unsplashgalaxyprovider.json
  dataengines/potd/unsplashloveprovider.cpp
  dataengines/potd/unsplashloveprovider.h
  dataengines/potd/unsplashloveprovider.json
  dataengines/potd/unsplashmusicprovider.cpp
  dataengines/potd/unsplashmusicprovider.h
  dataengines/potd/unsplashmusicprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashpeopleprovider.cpp
  dataengines/potd/unsplashpeopleprovider.h
  dataengines/potd/unsplashpeopleprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashsportsprovider.cpp
  dataengines/potd/unsplashsportsprovider.h
  dataengines/potd/unsplashsportsprovider.json
  dataengines/potd/unsplashsummerprovider.cpp
  dataengines/potd/unsplashsummerprovider.h
  dataengines/potd/unsplashsummerprovider.json
  dataengines/potd/unsplashtravelprovider.cpp
  dataengines/potd/unsplashtravelprovider.h
  dataengines/potd/unsplashtravelprovider.json
  dataengines/potd/unsplashtumblrprovider.cpp
  dataengines/potd/unsplashtumblrprovider.h
  dataengines/potd/unsplashtumblrprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This contains the actual name of the desktop file which might be different 
from the one the application got built with.

TEST PLAN
  5.16?
  Not sure if this needs to be cached. The codepath is only hit for 
unidentified apps but when I e.g. launch plasmoidviewer which doesn't have a 
desktop file it ends up calling into this 5 times (first when PID "changes"/is 
set, then for window icon, etc)
  
  Chromium snap can be pinned and launched properly now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22506

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61899.
guoyunhe added a comment.


  Add all Unsplash Wallpaper collections

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61877=61899

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/generate_unsplash_provider.sh
  dataengines/potd/unsplashanimalprovider.cpp
  dataengines/potd/unsplashanimalprovider.h
  dataengines/potd/unsplashanimalprovider.json
  dataengines/potd/unsplashbackgroundprovider.cpp
  dataengines/potd/unsplashbackgroundprovider.h
  dataengines/potd/unsplashbackgroundprovider.json
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashbeachprovider.cpp
  dataengines/potd/unsplashbeachprovider.h
  dataengines/potd/unsplashbeachprovider.json
  dataengines/potd/unsplashblackprovider.cpp
  dataengines/potd/unsplashblackprovider.h
  dataengines/potd/unsplashblackprovider.json
  dataengines/potd/unsplashcarprovider.cpp
  dataengines/potd/unsplashcarprovider.h
  dataengines/potd/unsplashcarprovider.json
  dataengines/potd/unsplashchristmasprovider.cpp
  dataengines/potd/unsplashchristmasprovider.h
  dataengines/potd/unsplashchristmasprovider.json
  dataengines/potd/unsplashcoolprovider.cpp
  dataengines/potd/unsplashcoolprovider.h
  dataengines/potd/unsplashcoolprovider.json
  dataengines/potd/unsplashcuteprovider.cpp
  dataengines/potd/unsplashcuteprovider.h
  dataengines/potd/unsplashcuteprovider.json
  dataengines/potd/unsplashdesignprovider.cpp
  dataengines/potd/unsplashdesignprovider.h
  dataengines/potd/unsplashdesignprovider.json
  dataengines/potd/unsplashfallprovider.cpp
  dataengines/potd/unsplashfallprovider.h
  dataengines/potd/unsplashfallprovider.json
  dataengines/potd/unsplashflowerprovider.cpp
  dataengines/potd/unsplashflowerprovider.h
  dataengines/potd/unsplashflowerprovider.json
  dataengines/potd/unsplashfunnyprovider.cpp
  dataengines/potd/unsplashfunnyprovider.h
  dataengines/potd/unsplashfunnyprovider.json
  dataengines/potd/unsplashgalaxyprovider.cpp
  dataengines/potd/unsplashgalaxyprovider.h
  dataengines/potd/unsplashgalaxyprovider.json
  dataengines/potd/unsplashloveprovider.cpp
  dataengines/potd/unsplashloveprovider.h
  dataengines/potd/unsplashloveprovider.json
  dataengines/potd/unsplashmusicprovider.cpp
  dataengines/potd/unsplashmusicprovider.h
  dataengines/potd/unsplashmusicprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashpeopleprovider.cpp
  dataengines/potd/unsplashpeopleprovider.h
  dataengines/potd/unsplashpeopleprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashsportsprovider.cpp
  dataengines/potd/unsplashsportsprovider.h
  dataengines/potd/unsplashsportsprovider.json
  dataengines/potd/unsplashsummerprovider.cpp
  dataengines/potd/unsplashsummerprovider.h
  dataengines/potd/unsplashsummerprovider.json
  dataengines/potd/unsplashtravelprovider.cpp
  dataengines/potd/unsplashtravelprovider.h
  dataengines/potd/unsplashtravelprovider.json
  dataengines/potd/unsplashtumblrprovider.cpp
  dataengines/potd/unsplashtumblrprovider.h
  dataengines/potd/unsplashtumblrprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22505: [SpinBox] Set renderType

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures it uses the system's font rendering settings
  
  BUG: 409888

TEST PLAN
  Fonts KCM still works fine, didn't actually test the anti aliasing setings 
mentioned in the bug

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22505

AFFECTED FILES
  org.kde.desktop/SpinBox.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Bhushan Shah]

bshah added subscribers: hein, bshah.
bshah added a comment.


  Personally speaking, +1, would love opinion of @hein

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Noah Davis]

ndavis added a comment.


  In D22493#496618 , @broulik wrote:
  
  > Is it just me or does vertical alignment look off now? How does it affect 
the popup layout?
  
  
  Doesn't seem different from the current vertical alignment.
  F7037286: Screenshot_20190717_053450.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  The kcm might be used with different settings apps like plasma-settings, in 
that case systemsettings is not installed.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22482: WIP: Show file dialog in directory mode when only directory is requested

[Jan Grulich]

jgrulich added a comment.


  What would be the usecase here? I can think of Firefox only, but as I 
mentioned, it won't work with Firefox, because it behaves exactly the same way 
as Qt, which means a dialog inside sandbox is opened when requesting to open a 
folder.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22482

To: volkov, apol, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Kai Uwe Broulik]

broulik added a comment.


  Is it just me or does vertical alignment look off now? How does it affect the 
popup layout?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: how about a developer KCM

[Kai Uwe Broulik]

Am 17.07.19 um 08:50 schrieb Eike Hein:
I think DrKonqi-related options are natural fit in 'kdebugsettings' 
however. This app already exists, is essentially for devs, and has 
domain overlap with what DrKonqi does.


That is exactly where I wanted to put said option but got rejected.

Cheers
Kai Uwe

D22306: Do not skip code launching application in application dashboard

[Eike Hein]

hein added a comment.


  I see what this is trying to do, but some of the details seem a bit wrong.
  
  E.g. you're only setting `dragging` to false in a code branch that's only 
executed when it already is false, which means it's not going to be set to 
false on a drag release, and pressX/Y also won't be unset on a release that 
doesn't happen above an iten anymore. You can keep the code flow change (the 
main thing this is probably fixing is that wrong check for the return value of 
`updatePositionProperties`), but please rework the patch a bit to make sure 
that the state of these variables still gets updated in the way they should on 
a release.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Eike Hein]

hein added a comment.


  Agreed with Harald, the wording's misleading sorry :)

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

Re: how about a developer KCM

[Eike Hein]

On 7/16/19 11:36 PM, Nate Graham wrote:

On 7/16/19 8:32 AM, David Edmundson wrote:

However, I fear it will end up becoming some sort of hidden
plasma-tweaks, where we dump general aesthetic/behaviour settings in
here which we think are too niche for the main UI.
I don't want that to happen.


Strongly agreed.


Same.

I think DrKonqi-related options are natural fit in 'kdebugsettings' 
however. This app already exists, is essentially for devs, and has 
domain overlap with what DrKonqi does.





Nate


Cheers,
Eike