KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 70 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/70/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 20 Jul 2019 22:35:08 +
 Build duration:
6 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-20T22:41:06.077Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-20T22:41:06.077Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 42 Stepping 1, GenuineIntel'[2019-07-20T22:41:06.077Z] PROCESSOR_LEVEL   = '6'[2019-07-20T22:41:06.077Z] PROCESSOR_REVISION= '2a01'[2019-07-20T22:41:06.077Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-20T22:41:06.077Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-20T22:41:06.077Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-20T22:41:06.077Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-20T22:41:06.077Z] PROMPT= '$P$G'[2019-07-20T22:41:06.077Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-20T22:41:06.077Z] PUBLIC= 'C:\Users\Public'[2019-07-20T22:41:06.077Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/70/display/redirect?page=changes'[2019-07-20T22:41:06.077Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/70/display/redirect'[2019-07-20T22:41:06.077Z] STAGE_NAME= 'Configuring Build'[2019-07-20T22:41:06.077Z] SYSTEMDRIVE   = 'C:'[2019-07-20T22:41:06.077Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-20T22:41:06.077Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-20T22:41:06.077Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-20T22:41:06.077Z] UCRTVERSION   = '10.0.17763.0'[2019-07-20T22:41:06.077Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-20T22:41:06.077Z] USERDOMAIN= 'DESKTOP-V7LQR8M'[2019-07-20T22:41:06.077Z] USERNAME  = 'Jenkins'[2019-07-20T22:41:06.077Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-20T22:41:06.077Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-20T22:41:06.077Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-20T22:41:06.077Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-20T22:41:06.077Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-20T22:41:06.077Z] VCTOOLSVERSION= '14.16.27023'[2019-07-20T22:41:06.077Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-20T22:41:06.077Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-20T22:41:06.077Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-20T22:41:06.077Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-20T22:41:06.077Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-20T22:41:06.077Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-20T22:41:06.077Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-20T22:41:06.077Z] VSCMD_VER = '16.0.3'[2019-07-20T22:41:06.077Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-20T22:41:06.077Z] WINDIR= 'C:\WINDOWS'[2019-07-20T22:41:06.077Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-20T22:41:06.077Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-20T22:41:06.077Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-20T22:41:06.077Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-20T22:41:06.077Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-20T22:41:06.077Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-20T22:41:06.077Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-20T22:41:06.077Z] __DOTNET_ADD_64BIT= '1'[2019-07-20T22:41:06.077Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-20T22:41:06.077Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-20T22:41:06.077Z] 

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:5a59721d7efe: wrap the details example label+spacer in a 
container widget (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22485?vs=62038=62158

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter added a comment.


  bug had one. but true enough
  
  FTR:
  
  without this diff
  F7062349: Screenshot_20190721_002927.png 

  
  with this diff
  F7062351: Screenshot_20190721_003021.png 


REPOSITORY
  R871 DrKonqi

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21667: Optionally display threads as if they were processes

[Topi Miettinen]

topimiettinen updated this revision to Diff 62153.
topimiettinen added a comment.


  untabify

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21667?vs=59398=62153

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

[Kai Uwe Broulik]

broulik updated this revision to Diff 62151.
broulik added a comment.


  - Ensure we always disconnect the initial fetch finished signal

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22596?vs=62148=62151

REVISION DETAIL
  https://phabricator.kde.org/D22596

AFFECTED FILES
  dataengines/mpris2/mpris2engine.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Christoph Cullmann]

cullmann added a comment.


  Thanks!

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[David Faure]

dfaure added a comment.


  Backported. 
https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Properties like `Identity`, `SupportedUriSchemes`, `SupportedMimeTypes` are 
mandatory. Ignore the player if it's clearly violating the spec.

TEST PLAN
  Chrome's own unfinished mpris implementation no longer steals the show from 
p-b-i
  VLC still works
  Will probably hold off merging it until I have tested with some more players

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22596

AFFECTED FILES
  dataengines/mpris2/mpris2engine.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22588: [Pager] Don't link kdelibs4support

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e75f1e5039a3: [Pager] Dont link kdelibs4support 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22588?vs=62127=62147

REVISION DETAIL
  https://phabricator.kde.org/D22588

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: broulik, #plasma, hein, davidedmundson
Cc: pino, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  I'm not familiar with KDE release engineering, so I'm asking to do merging 
someone else.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 
'Gnome' for the wayland session).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Wolfgang Bauer]

wbauer added a comment.


  What about the stable 5.16 branch?
  It has only be committed to master so far AFAICS, so the fix would only end 
up in Plasma 5.17 which is still 3 months away...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21112: Support message response and reply callbacks

[Fabian Vogt]

fvogt added a comment.


  Code looks good and seems to work fine in vivaldi, but I get an error in 
firefox:
  
Promise resolved after context unloaded
extension.js:78
sendSettings 
moz-extension://d1f34b4e-4e97-40a5-b4ac-03dc2fea30a9/extension.js:78
  
  appears to be harmless though?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Requests several KWin-specific interfaces to be used on KRunner and
  Plasma Shell.

TEST PLAN
  See D22571 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22589

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop
  krunner/krunner.desktop.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop
  shell/org.kde.plasmashell.desktop.cmake

To: apol, #plasma, #kwin
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21112: Support message response and reply callbacks

[Kai Uwe Broulik]

broulik updated this revision to Diff 62129.
broulik added a comment.


  - Use promises

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21112?vs=57839=62129

REVISION DETAIL
  https://phabricator.kde.org/D21112

AFFECTED FILES
  extension/content-script.js
  extension/content-utils.js
  extension/extension.js
  extension/manifest.json
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22588: [Pager] Don't link kdelibs4support

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> shubham wrote in CMakeLists.txt:18
> Could you please remove this or the occurrence below at line 21?

In a separate patch, not in this one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

To: broulik, #plasma, hein
Cc: pino, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

[Fabian Vogt]

fvogt added a comment.


  Still can't reproduce, but doesn't seem to intruduce a regression either

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20830

To: broulik, #plasma, fvogt
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22588: [Pager] Don't link kdelibs4support

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:18
>Qt5::Core
>Qt5::DBus
>Qt5::Qml

Could you please remove this or the occurrence below at line 21?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

To: broulik, #plasma, hein
Cc: shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22588: [Pager] Don't link kdelibs4support

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's not used

TEST PLAN
  Compiles

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:6d86fd453417: kioclient: Dont convert `:x:y` to 
`?line=xcolumn=y` for URLs starting with… (authored by arrowd).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22525?vs=61957=62126

REVISION DETAIL
  https://phabricator.kde.org/D22525

AFFECTED FILES
  kioclient/urlinfo.h

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22418: WIP [wayland] make automatic backend selection truly automatic

[Martin Flöser]

graesslin added a comment.


  I'm not convinced that removing the ifdef is the solution to the problem. 
What you basically want is being able to do an out-of-tree build of a backend. 
Ideally you would want to install all the variants next to each other and be 
able to pick the correct one.
  
  So what about the following idea: The plugins provide the command line 
arguments themselves (e.g. a static method that's queried) and specify the 
checks themselves. Thus we would externalize the resolution to the plugin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22418

To: alexeymin, romangg, #kwin
Cc: PureTryOut, graesslin, kwin, plasma-devel, LeGast00n, fmonteiro, sbergeron, 
jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

[Aleix Pol Gonzalez]

apol added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22564

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22579: Load QtQuickSettings from ksplashqml

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Then please improve a better commit message (and possibly close using BUG?).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22579

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

[Nathaniel Graham]

ngraham updated this revision to Diff 62116.
ngraham marked an inline comment as done.
ngraham added a comment.


  Remove unnecessary `!settings.isMobile` checks

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22564?vs=62068=62116

BRANCH
  respect-scrollbar-visibility-for-swipelistitem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22564

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22579: Load QtQuickSettings from ksplashqml

[David Edmundson]

davidedmundson added a comment.


  > What does this fix?
  
  Fabian's laptop :D
  
  It means the ksplash will apply software rendering/which render loop/GL 
profile as determined by your settings in "kcmshell5 qtquicksettings".
  plasma-workspace, systemsettings etc apply it, I missed ksplash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22579

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21517: Fix "Type error" when creating a TextField with focus: true

[David Faure]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:e419e9b42287: Fix Type error when creating a 
TextField with focus: true (authored by dfaure).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21517?vs=62107=62111

REVISION DETAIL
  https://phabricator.kde.org/D21517

AFFECTED FILES
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  tests/LineEditWithClearButton.qml

To: dfaure, mart, davidedmundson, apol, broulik
Cc: plasma-devel, broulik, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22579: Load QtQuickSettings from ksplashqml

[Aleix Pol Gonzalez]

apol added a comment.


  What does this fix?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22579

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22363: Remove cursor theme option

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> filipf wrote in advanceconfig.cpp:205
> I need the identifier to delete the entry in the config file (done in 
> sddmauthhelper.cpp), the value is not important so I just set whatever. Any 
> smarter way of doing this?

args[QStringLiteral("kde_settings.conf/Theme/CursorTheme")] = QVariant();

Then in sddmauthhelper, something like

  if (fileName == QLatin1String("kde_settings.conf")) {
  if (iterator.value().isValid()) {
  sddmConfig->group(groupName).writeEntry(keyName, 
iterator.value());
  } else {
 
sddmConfig->group(groupName).deleteEntry(keyName);
  
}
  sddmOldConfig->group(groupName).deleteEntry(keyName);
  }
  }

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22363

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22579: Load QtQuickSettings from ksplashqml

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Code is copy/paste

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22579

AFFECTED FILES
  ksplash/ksplashqml/CMakeLists.txt
  ksplash/ksplashqml/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, I'm wrong (not the first time this happens) :-)
  
  `kwrite /home/dfaure/.zshrc:20` works
  `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed.
  
  The patch looks fine then.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  In D22525#498393 , @dfaure wrote:
  
  > I suppose the kate developers like the fact that this currently works over 
FTP, SFTP, FISH, SMB, etc.
  >  So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries 
have a different meaning, one that we can't know client-side).
  
  
  I'm confused. I just tried SFTP and SMB without the patch and it also doesn't 
work. As I said, it is invalid to rewrite URLs for remote schemas.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I suppose the kate developers like the fact that this currently works over 
FTP, SFTP, FISH, SMB, etc.
  So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries 
have a different meaning, one that we can't know client-side).

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf updated this revision to Diff 62101.
filipf added a comment.


  remove weird stuff from the .ui file

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22363?vs=62075=62101

BRANCH
  remove-cursor-theme-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22363

AFFECTED FILES
  sddmauthhelper.cpp
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/cursortheme/cursortheme.cpp
  src/cursortheme/cursortheme.h
  src/cursortheme/dummytheme.cpp
  src/cursortheme/dummytheme.h
  src/cursortheme/sortproxymodel.cpp
  src/cursortheme/sortproxymodel.h
  src/cursortheme/thememodel.cpp
  src/cursortheme/thememodel.h
  src/cursortheme/xcursortheme.cpp
  src/cursortheme/xcursortheme.h
  src/ui/advanceconfig.ui

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sddmauthhelper.cpp:119
> Task for another day, we don't need to pass this in every time.
> 
> We can set this at compile time, using the same values from config.h as the 
> KCM would use

+1

> davidedmundson wrote in advanceconfig.cpp:205
> why?

I need the identifier to delete the entry in the config file (done in 
sddmauthhelper.cpp), the value is not important so I just set whatever. Any 
smarter way of doing this?

> davidedmundson wrote in advanceconfig.ui:220
> that seems odd?

Definitely does, QtDesigner can be weird. Going to undo that.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22363

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> SwipeListItem.qml:241
>  verticalCenter: parent.verticalCenter
> -rightMargin: Units.gridUnit
> +rightMargin: !Settings.isMobile && behindItem.view && 
> behindItem.view.T2.ScrollBar && behindItem.view.T2.ScrollBar.vertical && 
> behindItem.view.T2.ScrollBar.vertical.visible ? 
> behindItem.view.T2.ScrollBar.vertical.width : Units.smallSpacing
>  }

Wouldn't checking for scrollbar visibility be enough? if there's a scrollbar 
but isMobile we still want the different spacing.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22564

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22485: wrap the details example label+spacer in a container widget

[Aleix Pol Gonzalez]

apol added a comment.


  When doing this kind of changes it would be useful to have a screenshot by it.

REPOSITORY
  R871 DrKonqi

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 69 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/69/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 20 Jul 2019 07:50:28 +
 Build duration:
7 min 54 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-20T07:58:08.792Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-20T07:58:08.792Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 42 Stepping 1, GenuineIntel'[2019-07-20T07:58:08.792Z] PROCESSOR_LEVEL   = '6'[2019-07-20T07:58:08.792Z] PROCESSOR_REVISION= '2a01'[2019-07-20T07:58:08.792Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-20T07:58:08.792Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-20T07:58:08.792Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-20T07:58:08.792Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-20T07:58:08.792Z] PROMPT= '$P$G'[2019-07-20T07:58:08.792Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-20T07:58:08.792Z] PUBLIC= 'C:\Users\Public'[2019-07-20T07:58:08.792Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/69/display/redirect?page=changes'[2019-07-20T07:58:08.792Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/69/display/redirect'[2019-07-20T07:58:08.792Z] STAGE_NAME= 'Configuring Build'[2019-07-20T07:58:08.792Z] SYSTEMDRIVE   = 'C:'[2019-07-20T07:58:08.792Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-20T07:58:08.792Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-20T07:58:08.792Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-20T07:58:08.792Z] UCRTVERSION   = '10.0.17763.0'[2019-07-20T07:58:08.792Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-20T07:58:08.792Z] USERDOMAIN= 'DESKTOP-V7LQR8M'[2019-07-20T07:58:08.792Z] USERNAME  = 'Jenkins'[2019-07-20T07:58:08.792Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-20T07:58:08.792Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-20T07:58:08.792Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-20T07:58:08.792Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-20T07:58:08.792Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-20T07:58:08.792Z] VCTOOLSVERSION= '14.16.27023'[2019-07-20T07:58:08.792Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-20T07:58:08.792Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-20T07:58:08.792Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-20T07:58:08.792Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-20T07:58:08.792Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-20T07:58:08.792Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-20T07:58:08.792Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-20T07:58:08.792Z] VSCMD_VER = '16.0.3'[2019-07-20T07:58:08.792Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-20T07:58:08.792Z] WINDIR= 'C:\WINDOWS'[2019-07-20T07:58:08.792Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-20T07:58:08.792Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-20T07:58:08.792Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-20T07:58:08.792Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-20T07:58:08.792Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-20T07:58:08.792Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-20T07:58:08.792Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-20T07:58:08.792Z] __DOTNET_ADD_64BIT= '1'[2019-07-20T07:58:08.792Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-20T07:58:08.792Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-20T07:58:08.792Z]