D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Shubham]

shubham added a comment.


  +1
  Personally I had faced this issue when I had bought a new monitor and tried 
to listen to music through its speakers. I couldn't figure out how to switch 
play back devices for couple of days or so.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 24 Aug 2019 03:12:56 +
 Build duration:
3 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 322 lines...][2019-08-24T03:16:01.958Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-08-24T03:16:01.958Z] [2019-08-24T03:16:02.910Z] C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- atspi (LoadError)[2019-08-24T03:16:02.910Z] 	from C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'[2019-08-24T03:16:02.910Z] 	from -e:1:in `'[2019-08-24T03:16:02.910Z] -- The following REQUIRED packages have been found:[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z]  * ECM (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * Qt5Core[2019-08-24T03:16:02.910Z]  * Qt5Gui (required version >= 5.13.0)[2019-08-24T03:16:02.910Z]  * Qt5Widgets[2019-08-24T03:16:02.910Z]  * Qt5DBus[2019-08-24T03:16:02.910Z]  * Qt5Concurrent[2019-08-24T03:16:02.910Z]  * Qt5 (required version >= 5.12.0)[2019-08-24T03:16:02.910Z]  * Gettext[2019-08-24T03:16:02.910Z]  * KF5I18n (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5Service (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5ConfigWidgets (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5JobWidgets (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5KIO (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5Crash (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5Completion (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5WidgetsAddons (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5Wallet (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5Notifications (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5IdleTime (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KF5 (required version >= 5.58.0)[2019-08-24T03:16:02.910Z]  * KDEWin[2019-08-24T03:16:02.910Z]  * Qt5Test[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z] -- The following features have been disabled:[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z] -- The following RECOMMENDED packages have not been found:[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z]  * Qt5X11Extras (required version >= 5.12.0)[2019-08-24T03:16:02.910Z]Recommended for better integration on X11.[2019-08-24T03:16:02.910Z] [2019-08-24T03:16:02.910Z] -- Configuring done[2019-08-24T03:16:08.259Z] -- Generating done[2019-08-24T03:16:08.259Z] -- Build files have been written to: C:/CI/workspace/Plasma/drkonqi/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-08-24T03:16:09.286Z] [2019-08-24T03:16:09.286Z] C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-08-24T03:16:09.856Z] **[2019-08-24T03:16:09.856Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-08-24T03:16:09.856Z] ** Copyright (c) 2019 Microsoft Corporation[2019-08-24T03:16:09.856Z] **[2019-08-24T03:16:14.117Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-08-24T03:16:14.117Z] [2019-08-24T03:16:14.117Z] jom 1.1.3 - empower your cores[2019-08-24T03:16:14.117Z] [2019-08-24T03:16:14.117Z] jom: parallel job execution disabled for Makefile[2019-08-24T03:16:14.117Z] Scanning dependencies of target qbugzilla_autogen[2019-08-24T03:16:14.117Z] Scanning dependencies of target kdbgwin_autogen[2019-08-24T03:16:14.117Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-08-24T03:16:14.117Z] Scanning dependencies of target lsb_release_autogen[2019-08-24T03:16:14.118Z] Scanning dependencies of target crashtest_autogen[2019-08-24T03:16:14.118Z] [  1%] Automatic MOC for target qbugzilla[2019-08-24T03:16:14.436Z] [  4%] Automatic MOC for target crashtest[2019-08-24T03:16:14.436Z] [  4%] Automatic MOC for target lsb_release[2019-08-24T03:16:14.436Z] [  4%] Built target crashtest_autogen[2019-08-24T03:16:14.436Z] [  4%] Built target lsb_release_autogen[2019-08-24T03:16:14.708Z] Scanning dependencies of target lsb_release[2019-08-24T03:16:16.133Z] [  4%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.obj[2019-08-24T03:16:16.133Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 

D23386: [Applet] Double-click on icon to make it the default

[Nathaniel Graham]

ngraham added a comment.


  If nobody likes this, here's an alternative: D23389: [Applet] Move "Make 
default" action out of the context menu and into a discoverable button 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23386

To: ngraham, drosca, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23389: Move "Make default" action out of the context menu and into a discoverable button

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: drosca, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We get numerous complaints that it's hard to figure out how to make an audio 
device the
  default for playback or output. Despite the multiple methods (drag-and-drop, 
hamburger
  menu item), it still seems un-discoverable for many users.
  
  This patch attempts to address the issue by adding a big, obvious Make default
  button right there on the device's list item. The button is only shown when 
there is
  more than one device that could be the default.
  
  Various elements of the UI are adjusted to adape to and accommodate this 
change:
  
  - The hamburger menu button is given a buttonlike appearance so as to not 
look weird next to the other button
  - The Default menu item is removed because the button makes it unnecessary
  - The Mute menu item is removed for the same logic: because there's already a 
visible UI for it
  
  This is an alternative to D23386 , which, 
upon reflection, is kind of clunky.
  
  FEATURE: 411065
  FIXED-IN: 5.17.0

TEST PLAN
  Connected my Bluetooth speaker and toggled between it and the internal 
speakers using
  the new button: F7275007: BIG BUTTONS.png 

  
  My wife was impressed by how easy it was and how the audio instantly switched.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, drosca, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21524: Keep existing configurations' strings

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's see how this goes. Do you have push powers?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D21524

REVISION DETAIL
  https://phabricator.kde.org/D21524

To: gikari, apol, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22176: Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  @nicolasfella would you be able to move forward with this? I have some 
additions in mind for the config UI but I don't think it makes to start work on 
them while this very desirable cleanup is still in flight.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Nathaniel Graham]

ngraham updated this revision to Diff 64447.
ngraham added a comment.


  Slightly cleaner code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23387?vs=64446=64447

BRANCH
  folderview-buttons-scale-with-item-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23387

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemActionButton.qml

To: ngraham, hein, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the selection and preview buttons that appear on hover are very 
very tiny,
  and remain very very tiny even when the icon size is large.
  
  This patch increases the size--and therefore visibility and clickability--of 
the buttons
  as the icon size increases.
  
  BUG: 411073
  FIXED-IN: 5.17.0

TEST PLAN
  No change for icon sizes at slider positions 1, 2, and 3, where items are 
quite small.
  
  Slider position 4: F7274552: Slider tick 4.png 

  
  Slider position 5: F7274551: Slider tick 5.png 

  
  Slider position 6: F7274549: Slicer tick 6.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  folderview-buttons-scale-with-item-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23387

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemActionButton.qml

To: ngraham, hein, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23386: [Applet] Double-click on icon to make it the default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: drosca, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Requested in https://bugs.kde.org/show_bug.cgi?id=411065. This is hidden, but 
can be a
  nice little accelerator. If we don't want to do this, IMO it would be worth 
revisiting
  how items are made the default, as it is rather fiddly right now.
  
  FEATURE: 411065
  FIXED-IN: 5.17.0

TEST PLAN
  Double-clicked on a different item and music started coming out of it

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  double-click-to-make-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23386

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, drosca, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23382: Add vmPSS to Process and display it as "total memory" column

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "proportional state set" value to ProcessCore::Process, that is 
then
  exposed as "Total Memory" column in KSysGuard. This column is hidden by 
default.
  
  PSS is the amount of memory a process uses privately + the amount of shared 
memory
  divided by the amount of processes sharing that memory. It is, as far as I 
know, the
  closest we can get to "total physical memory usage" for a process.
  
  The value for PSS is read from /proc/{pid}/smaps_rollup . This unfortunately 
means
  we cannot currently display PSS for processes not owned by the current user, 
as 
  smaps_rollup is not world-readable.
  
  For some background on this, see https://lkml.org/lkml/2017/8/9/1073 , which 
is the
  patch that adds smaps_rollup and talks about what Android uses it for.

TEST PLAN
  Run ksysguard, then toggle display of the "Total Memory" column. Values 
should be
  higher than the "Memory" column.

REPOSITORY
  R111 KSysguard Library

BRANCH
  pss

REVISION DETAIL
  https://phabricator.kde.org/D23382

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23378: Check if sddm user exists

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:80
>  // create SDDM config directory if it does not exist
>  QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>  if (!sddmConfigLocation.exists()) {

can we use sddmHomeDirPath + "whatever"

instead now

and get rid of this sddmUserConfig map entry

> sddmauthhelper.cpp:172
> +
>  QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>  QDir fontconfigDir(args[QStringLiteral("sddmUserConfig")].toString() + 
> QStringLiteral("/fontconfig"));

and here

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23379: Improve charge capacity/level strings

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:41aa7f4726cc: Improve charge capacity/level strings 
(authored by ngraham).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23379?vs=64430=64431

REVISION DETAIL
  https://phabricator.kde.org/D23379

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, broulik, filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Nathaniel Graham]

ngraham added a comment.


  How about refactoring this "does SDDM user exist?" check into a function so 
we don't have to write virtually the same code three times?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23379: Improve charge capacity/level strings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In particular, the string "Full design" is ambigious, bordering on 
nonsensical.

TEST PLAN
  F7274016: new strings.png 

REPOSITORY
  R102 KInfoCenter

BRANCH
  better-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23379

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 64429.
filipf added a comment.


  add qDebug info in auth helper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=64428=64429

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 64428.
filipf edited the summary of this revision.
filipf added a comment.


  also apply the check for the auth helper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=64425=64428

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[David Edmundson]

davidedmundson added a comment.


  Whilst client checks are nice, for the reason you're changing it this should 
(also?) be in the authhelper.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Sddm-kcm should depend on sddm.
  Sddm sets up an sddm user which is used to run the greeter.
  Therefore it should not be possible to run sddm-kcm without an sddm user 
existing.
  
  But if it should happen that's the case, this patch adds a check for the sddm 
user.
  If the user is not present, everything will be aborted and an error message 
will pop-up.
  
  openSUSE BUG: https://bugzilla.opensuse.org/show_bug.cgi?id=1146817, 
https://bugzilla.opensuse.org/show_bug.cgi?id=1146831

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  src/advanceconfig.cpp

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven updated this revision to Diff 64424.
meven marked 2 inline comments as done.
meven added a comment.


  Make code more generic

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23152?vs=64390=64424

BRANCH
  arcpatch-D23152

REVISION DETAIL
  https://phabricator.kde.org/D23152

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in batterymodel.h:47
> As a cleanup measure (before or after, but separate of this patch), can you 
> remove those separate invokables
> 
> 1. Add `Q_ENUM(Roles)`
> 2. `qmlRegisterUncreatableType` the `BatteryModel`
> 3. from QML use `data()` which is invokable since Qt 5.5 (after this code was 
> written iirc):
> 
>   kcm.batteries.data(kcm.batteries.index(0, 0), BatteryModel.VendorRole)

I will do it as a followup.

> broulik wrote in main.qml:432
> Can you make this more generic, e.g.
> 
>   value = root["current" + uppercasefirst(modelData.source)]

Nice suggestion :)

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D23152

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Can you please add the delay for when the spinner shows up. (And the opacity 
animation perhaps)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22514: Show if KRunner is still searching for more things

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  Then again, now that I'm trying that out, it might be kind of annoying, and 
it wouldn't show up well when using a dark theme.
  
  All right, let's go with this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:52ea204e39d5: Replace the PasswordEdit field by a 
changePassword QPushButton, remove foreach… (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64420=64421

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/lib/accountmodel.cpp
  src/lib/usersessions.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64420.
meven added a comment.


  Rebase

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64402=64420

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/lib/accountmodel.cpp
  src/lib/usersessions.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22514: Show if KRunner is still searching for more things

[Nathaniel Graham]

ngraham added a comment.


  Never mind, I didn't have the whole stack built. This works well.
  
  I feel like I might prefer to have the spinner overlaid on top of the results 
view like @aspotashev suggested, inside a dark transparent rounded rectangle, 
maybe. That would visually connect the spinner to the results, rather than 
implying that the text field itself is still processing things.
  
  Not a huge deal though, and I can see how that might be kind of annoying if 
it's obscuring the results that you want to look at.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22514: Show if KRunner is still searching for more things

[Nathaniel Graham]

ngraham added a comment.


  Testing this out, the spinner never seems to go away, even after the results 
list has stopped changing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22514: Show if KRunner is still searching for more things

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in RunCommand.qml:86
> There was some code to make that magically work.
> 
> (maybe it was that URLInterceptor we removed?)
> 
> If it doesn't work, then just ignore me.

>   (maybe it was that URLInterceptor we removed?)

yep :)

(there may be things in the systemmotitor applets that *may* break if the 
urlinterceptor stuff is reintroduced tough (would need to be tested)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> mart wrote in CategoriesPage.qml:71
> I would prefer overflow-menu

This is just moving the existing item around, which already uses the hamburger 
menu icon (appropriately IMO).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  there *may* be some changes needing to be done on 
SidebarMode::setActiveCategory for that to work, but try to do that, then 
wel'll see

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  when the intro page gets shown, (again binded from a bool property arriving 
from c++)
  categoryView.currentIndex should be set to -1,
  and systemsettings.activeCategory to -1 as well

INLINE COMMENTS

> SidebarMode.cpp:424
>  
> +void SidebarMode::showIntroPage()
> +{

this should be a bool property setter

> CategoriesPage.qml:43
>  
>  QQC2.ToolButton {
> +id: showIntroPageButton

would be nice to have this disabled when on intro page.
the systemsettings context property should expose a bool property true when the 
intro page is shown

> CategoriesPage.qml:71
> +id: menuButton
> +icon.name: "application-menu"
> +checkable: true

I would prefer overflow-menu

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Nathaniel Graham]

ngraham updated this revision to Diff 64414.
ngraham added a comment.


  - Add charging indicator to icon when possible
  - Clean up layout
  - Add more text to make things clearer

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23368?vs=64382=64414

BRANCH
  port-away-from-WorkspaceComponents.BatteryIcon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23368

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, meven
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Nathaniel Graham]

ngraham updated this revision to Diff 64415.
ngraham added a comment.


  Remove debug thingy

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23368?vs=64414=64415

BRANCH
  port-away-from-WorkspaceComponents.BatteryIcon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23368

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, meven
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> batterymodel.h:47
>  Q_INVOKABLE Solid::Battery *get(int index) const;
> +Q_INVOKABLE QString vendor(int index) const;
> +Q_INVOKABLE QString product(int index) const;

As a cleanup measure (before or after, but separate of this patch), can you 
remove those separate invokables

1. Add `Q_ENUM(Roles)`
2. `qmlRegisterUncreatableType` the `BatteryModel`
3. from QML use `data()` which is invokable since Qt 5.5 (after this code was 
written iirc):

  kcm.batteries.data(kcm.batteries.index(0, 0), BatteryModel.VendorRole)

> main.qml:432
> +if (modelData.source) {
> +if (modelData.source == "vendor") {
> +value = currentVendor;

Can you make this more generic, e.g.

  value = root["current" + uppercasefirst(modelData.source)]

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D23152

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:156
> Can use the following
> 
>   var iconNameParts = ["battery"];
>   // Round percentage to the nearest 10% and pad it with leading zeroes to 
> match the icon names
>   iconNameParts.push(String(Math.round(model.battery.chargePercent / 10) * 
> 10).padStart(3, "0"));
>   if (model.battery.chargeState === 1) { // charging
>   iconNameParts.push("charging");
>   }
>   return iconNameParts.join("-");

My thought was that the battery level indicator inside the icon wasn't 
necessary because this UI has a current charge level indicator below the icon. 
Might be nice to show the plugged-in status though.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit!

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23375: [Tabs Runner] Show URL as result subtext

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:116ee0b607d3: [Tabs Runner] Show URL as result subtext 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23375?vs=64409=64412

REVISION DETAIL
  https://phabricator.kde.org/D23375

AFFECTED FILES
  tabsrunner/tabsrunner.cpp

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23374: [Tabs Runner] Reply to all requests

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:77f702bf38a8: [Tabs Runner] Reply to all requests 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23374?vs=64408=64411

REVISION DETAIL
  https://phabricator.kde.org/D23374

AFFECTED FILES
  host/tabsrunnerplugin.cpp
  host/tabsrunnerplugin.h
  tabsrunner/tabsrunner.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23375: [Tabs Runner] Show URL as result subtext

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Absolutely, makes sense to me.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23375

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  D23274  makes this unnecessary.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D23356: Add ksysguard plugin for taskmanager integration

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in taskmanager.cpp:99
> This role is a `QIcon`, potentially created from the window pixmap in case 
> window mapping failed.
> Or is that what the "tiny mods in ProcessModel" is about?

Yeah, and I need to map it to there decoration role on a different row.
Kinda messy and against the spirit of plugins, but it still helps the code

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23356

To: davidedmundson, #plasma
Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23356: Add ksysguard plugin for taskmanager integration

[David Edmundson]

davidedmundson updated this revision to Diff 64410.
davidedmundson added a comment.


  update

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23356?vs=64326=64410

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23356

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/process/taskmanager/CMakeLists.txt
  plugins/process/taskmanager/taskmanager.cpp
  plugins/process/taskmanager/taskmanager.h
  plugins/process/taskmanager/taskmanager.json

To: davidedmundson, #plasma
Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23375: [Tabs Runner] Show URL as result subtext

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes it consistent with what e.g. the bookmarks runner does

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23375

AFFECTED FILES
  tabsrunner/tabsrunner.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23374: [Tabs Runner] Reply to all requests

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes the tabsrunner work more reliably, especially initially when it 
first has to figure out the browser settings.
  Also check if the context has been invalidated by the time the reply came in.

TEST PLAN
  5.16 branch?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23374

AFFECTED FILES
  host/tabsrunnerplugin.cpp
  host/tabsrunnerplugin.h
  tabsrunner/tabsrunner.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in RunCommand.qml:86
> There was some code to make that magically work.
> 
> (maybe it was that URLInterceptor we removed?)
> 
> If it doesn't work, then just ignore me.

F7273406: Screenshot_20190823_121250.png 

We need more magic.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: davidedmundson, ngraham, aspotashev, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson updated this revision to Diff 64404.
davidedmundson added a comment.


  q_decl_hidden
  ran clang-format over new files

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23287?vs=64291=64404

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23287

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processcore/process_data_provider.cpp
  processcore/process_data_provider.h
  processcore/processes.cpp
  processcore/processes.h
  processcore/unit.cpp
  processcore/unit.h
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

To: davidedmundson, #plasma, ahiemstra
Cc: zzag, ahiemstra, alexde, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> extended_process_list.cpp:31
> +
> +class ExtendedProcesses::Private
> +{

Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN.

> process_data_provider.h:42-52
> +/**
> + * Accessors for process information matching
> + */
> +KSysGuard::Processes* processes() const;
> +
> +/**
> + * Returns a new process object for a given PID

Coding style inconsistency: pointer alignment.

Such inconsistency can be noticed in other parts of this patch too, e.g. 
QVector and QVector, etc.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23287

To: davidedmundson, #plasma, ahiemstra
Cc: zzag, ahiemstra, alexde, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven added a comment.


  In D23337#516758 , @ngraham wrote:
  
  > The text "change password" is not accurate when you're setting up a new 
user. For that case, it should say "set password". But the new user creation 
process is really weird and needs to be redone anyway, so maybe that's the 
better approach.
  
  
  The "change password" is now set to "set password" for the new user form.
  
  > Speaking of which, IIRC @nicolasfella was redoing this KCM from scratch 
with QML. How's that going, Nico?
  
  Since this code is close to ready and if this new QML KCM is not guaranteed 
to land before 5.17 we might as well land this in the meantime.

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64402.
meven added a comment.


  Change the change password button text to Set Password for new users

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64279=64402

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/lib/accountmodel.cpp
  src/lib/usersessions.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:156
> Now you lost the battery level and charging state in the icon.

Can use the following

  var iconNameParts = ["battery"];
  // Round percentage to the nearest 10% and pad it with leading zeroes to 
match the icon names
  iconNameParts.push(String(Math.round(model.battery.chargePercent / 10) * 
10).padStart(3, "0"));
  if (model.battery.chargeState === 1) { // charging
  iconNameParts.push("charging");
  }
  return iconNameParts.join("-");

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Filip Fila]

filipf resigned from this revision.
filipf added a comment.


  I forgot I was using the La Capitaine icon theme so the above doesn't apply 
in the sense of now working well with defaults. Seems OK with Breeze.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:156
>  switch(model.battery.type) {
> -case 3: return "Battery"
> -case 2: return "Ups"
> -case 9: return "Monitor"
> -case 4: return "Mouse"
> -case 5: return "Keyboard"
> -case 1: return "Pda"
> -case 7: return "Phone"
> -default: return "Unknown"
> +case 3: return "battery-full"
> +case 2: return "battery-ups"

Now you lost the battery level and charging state in the icon.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  Tested on 5.16 so disregard the other changes:
  
  **Before (dark Plasma theme, light color scheme):**
  F7273034: image.png 
  
  **After (dark Plasma theme, light color scheme):**
  F7273045: image.png 
  
  **Before (light Plasma theme, light color scheme):**
  F7273037: image.png 
  
  **After (light Plasma theme, light color scheme):**
  F7273048: image.png 
  
  **Before (color-aware Plasma theme, dark color scheme):**
  F7273039: image.png 
  
  **After (color-aware Plasma theme, dark color scheme):**
  F7273042: image.png 
  
  ___
  
  +1 for the idea, but two problems are evident:
  
  - at least one new Kirigami icon is not monochrome -> `input-mouse`
  - at least one new Kirigami icon is not color scheme-aware -> `battery-full`
  
  Other icons should also be checked, wouldn't hurt to see what support in 
other icons themes is like as well.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven updated this revision to Diff 64390.
meven added a comment.


  Removes the Manufacturer section, add Current Charge

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23152?vs=63720=64390

BRANCH
  arcpatch-D23152

REVISION DETAIL
  https://phabricator.kde.org/D23152

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23130: [energy kcm] Remove bogus Has power supply property from UI

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:b154d70f320a: [energy kcm] Remove bogus Has power supply 
property from UI (authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23130?vs=63718=64389

REVISION DETAIL
  https://phabricator.kde.org/D23130

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart