D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:607
> Are you sure `parent` is a `QGuiApplication`? I don't think so. Perhaps you 
> want to connect to `QGuiApplication::instance()` instead.

Just tested. It works. So the plan is to remove explicit call from the font kcm 
and replace it with that signal binding? For fonts it sure will work, but what 
about other settings, that will be in the future, like color schemes, icons 
etc? Whose signals we will receive?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D5961: PoC: Generic adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 66273.
apol added a comment.


  Remove the dialog and read the settings globally for Plasma.
  Moved the feedback settings to the About page.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=65968=66273

BRANCH
  arcpatch-D5961_1

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/CMakeLists.txt
  discover/DiscoverObject.cpp
  discover/discover.schema
  discover/plasmauserfeedback.kcfg
  discover/plasmauserfeedback.kcfgc
  discover/qml/AboutPage.qml
  discover/qml/DiscoverWindow.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, vkrause.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It offers 2 main features:
  
  - Configure the system-wide KUserFeedback kill-switch
  - Provide a setting for how much information we want our Plasma to be sending

TEST PLAN
  Tested it together with Discover, works fine

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24011

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/feedback/CMakeLists.txt
  kcms/feedback/Messages.sh
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/kcm_feedback.desktop
  kcms/feedback/package/contents/ui/main.qml
  kcms/feedback/package/metadata.desktop

To: apol, #plasma, vkrause
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23798: Polish Displays KCM UI

[Noah Davis]

ndavis added a comment.


  The orientation toolbuttons seem oversized.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham added a comment.


  Need a hand with the `TODO:` in main.qml. Otherwise, this is ready for 
re-review, @romangg and #vdg 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 66269.
ngraham added a comment.


  - Reduce height of screen visualizations
  - Conditionalize height of kcmshell window
  - Harmonize paddings

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=66267=66269

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/output_model.cpp
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24009: RFC: Make Breeze Dark darker

[Carson Black]

cblack added a comment.


  Looks like an improvement to me.
  
  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24009: RFC: Make Breeze Dark darker

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Discussions in #VDG  and in Phabricator 
tasks have been hinting at the conclusion that our dark theme is fairly light 
and might stand to become more attractive by being made somewhat darker.
  
  At this point the patch is just meant to encourage discussion. A proper 
overhaul requires changes in other places too.

REPOSITORY
  R31 Breeze

BRANCH
  darker-breeze-dark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24009

AFFECTED FILES
  colors/BreezeDark.colors

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24005: Show a new version string description for updates where the old and new versions are identical

[Aleix Pol Gonzalez]

apol added a comment.


  Having 3 identical labels with slightly different conditions feels odd, maybe 
we should just take it into account if when assigning the property?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24005

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 66267.
ngraham added a comment.


  Fix FormLayout alignment

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=66266=66267

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 66266.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  Fix the model count binding in main.qml

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=66265=66266

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

[Noah Davis]

ndavis added a comment.


  In D24008#532936 , @ngraham wrote:
  
  > Doesn't this mean that the visual appearance of the dial will change 
depending on what the maximum value is?
  
  
  No, you can apply this patch and apply whatever maximum value you want to a 
dial in Qt Designer and the appearance will be the same. This is because the 
minimum and maximum values are converted to degrees.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24008

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23257: Allow for easier syncing of Plasma font

[Filip Fila]

filipf added a comment.


  So the SDDM patch has been merged, but I don't know when the next SDDM 
release will be. I would keep this on hold until this happens, just to be 
safe... does that make sense?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  easier-font-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/10/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 20:52:29 +
 Build duration:
3 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 323 lines...][2019-09-16T20:55:20.281Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-09-16T20:55:20.281Z] [2019-09-16T20:55:20.555Z] C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- atspi (LoadError)[2019-09-16T20:55:20.555Z] 	from C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'[2019-09-16T20:55:20.555Z] 	from -e:1:in `'[2019-09-16T20:55:20.818Z] -- The following REQUIRED packages have been found:[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z]  * ECM (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * Qt5Core[2019-09-16T20:55:20.818Z]  * Qt5Gui (required version >= 5.13.0)[2019-09-16T20:55:20.818Z]  * Qt5Widgets[2019-09-16T20:55:20.818Z]  * Qt5DBus[2019-09-16T20:55:20.818Z]  * Qt5Concurrent[2019-09-16T20:55:20.818Z]  * Qt5 (required version >= 5.12.0)[2019-09-16T20:55:20.818Z]  * Gettext[2019-09-16T20:55:20.818Z]  * KF5I18n (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5Service (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5ConfigWidgets (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5JobWidgets (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5KIO (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5Crash (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5Completion (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5WidgetsAddons (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5Wallet (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5Notifications (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5IdleTime (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KF5 (required version >= 5.58.0)[2019-09-16T20:55:20.818Z]  * KDEWin[2019-09-16T20:55:20.818Z]  * Qt5Test[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z] -- The following features have been disabled:[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z] -- The following RECOMMENDED packages have not been found:[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z]  * Qt5X11Extras (required version >= 5.12.0)[2019-09-16T20:55:20.818Z]Recommended for better integration on X11.[2019-09-16T20:55:20.818Z] [2019-09-16T20:55:20.818Z] -- Configuring done[2019-09-16T20:55:27.520Z] -- Generating done[2019-09-16T20:55:27.520Z] -- Build files have been written to: C:/CI/workspace/Plasma/drkonqi/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-09-16T20:55:32.212Z] [2019-09-16T20:55:32.212Z] C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-09-16T20:55:32.483Z] **[2019-09-16T20:55:32.483Z] ** Visual Studio 2019 Developer Command Prompt v16.2.4[2019-09-16T20:55:32.483Z] ** Copyright (c) 2019 Microsoft Corporation[2019-09-16T20:55:32.483Z] **[2019-09-16T20:55:34.389Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-09-16T20:55:34.988Z] [2019-09-16T20:55:34.988Z] jom 1.1.3 - empower your cores[2019-09-16T20:55:34.988Z] [2019-09-16T20:55:35.609Z] jom: parallel job execution disabled for Makefile[2019-09-16T20:55:35.609Z] Scanning dependencies of target qbugzilla_autogen[2019-09-16T20:55:35.609Z] Scanning dependencies of target kdbgwin_autogen[2019-09-16T20:55:35.609Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-09-16T20:55:35.609Z] Scanning dependencies of target lsb_release_autogen[2019-09-16T20:55:35.609Z] Scanning dependencies of target crashtest_autogen[2019-09-16T20:55:35.609Z] [  1%] Automatic MOC for target qbugzilla[2019-09-16T20:55:36.175Z] [  4%] Automatic MOC for target lsb_release[2019-09-16T20:55:36.175Z] [  4%] Automatic MOC for target crashtest[2019-09-16T20:55:36.175Z] [  4%] Built target lsb_release_autogen[2019-09-16T20:55:36.175Z] [  4%] Built target crashtest_autogen[2019-09-16T20:55:36.446Z] Scanning dependencies of target lsb_release[2019-09-16T20:55:37.041Z] [  4%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.obj[2019-09-16T20:55:37.041Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

[Nathaniel Graham]

ngraham added a comment.


  Doesn't this mean that the visual appearance of the dial will change 
depending on what the maximum value is?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24008

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Noah Davis]

ndavis added a comment.


  > F7256235: image.png 
  
  Is this screenshot outdated? Why does the selected item extend outside the 
width of the list?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 66265.
ngraham marked an inline comment as done.
ngraham added a comment.


  Remove unneeded accessor and use `kcm.outputModel.rowCount()` instead

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65779=66265

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added a comment.


  @davidedmundson any objections?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Filip Fila]

filipf added a comment.


  What I'm seeing in the screenshot is that the two form layouts aren't 
aligned. Can you interlink them with `twinFormLayouts`?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  It bothered me that the groove for dials doesn't match the maximum area that 
the contents can use.

REPOSITORY
  R31 Breeze

BRANCH
  dial1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24008

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23798: Polish Displays KCM UI

[Roman Gilg]

romangg added a comment.


  Reducing the screen area height makes it difficult to place outputs on top of 
each other. Making it a bit smaller is fine (and improving the logic of how 
much this it in comparison to overall kcm size) but I think this is too much. 
Alternatively the size of the outputs could be reduced.

INLINE COMMENTS

> GB_2 wrote in OutputPanel.qml:33
> `element.count > 1`

`element` or `model` is not the whole model but only the current element of the 
model displayed by the view delegate. So it's a single element of the model 
without a count.

What you need is to take the count on the overall model. As the OutputPanel is 
part of Panel you can use for example here `panelView.count`. This way an 
additional getter is not required. Also you could use `OutputModel::rowCount` 
as in: `kcm.outputModel.rowCount()` (it is already Q_INVOKABLE, see docs 
).

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  Yo @cblack I think you can land this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24007

To: dfaure, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  FWIW, it would be good to fix some of the bugs listed here as part of the 
port: 
https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1663634=systemsettings=---

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/9/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 20:02:14 +
 Build duration:
6 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 413 lines...][2019-09-16T20:08:08.772Z] LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64\link.exe /nologo @CMakeFiles\lsb_release.dir\objects1.rsp /out:..\..\bin\lsb_release.exe /implib:..\..\lib\lsb_release.lib /pdb:C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\bin\lsb_release.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\lsb_release.dir/intermediate.manifest CMakeFiles\lsb_release.dir/manifest.res" failed (exit code 1120) with the following output:[2019-09-16T20:08:08.772Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)[2019-09-16T20:08:08.772Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\src\tests\CMakeFiles\lsb_release.dir\build.make [bin\lsb_release.exe] Error 2[2019-09-16T20:08:08.772Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\tests\CMakeFiles\lsb_release.dir\all] Error 2[2019-09-16T20:08:08.772Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-09-16T20:08:08.772Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-09-16T20:08:08.772Z] backtraceparser.cpp[2019-09-16T20:08:08.772Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-09-16T20:08:08.772Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.obj[2019-09-16T20:08:08.772Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_process.cpp.obj[2019-09-16T20:08:08.772Z] [ 13%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.obj[2019-09-16T20:08:08.772Z] [ 14%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-09-16T20:08:08.772Z] main.cpp[2019-09-16T20:08:08.772Z] [ 14%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.obj[2019-09-16T20:08:08.772Z] [ 15%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-09-16T20:08:09.061Z] Scanning dependencies of target qbugzilla[2019-09-16T20:08:09.328Z] [ 15%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.obj[2019-09-16T20:08:09.613Z] apijob.cpp[2019-09-16T20:08:11.031Z] backtraceparsergdb.cpp[2019-09-16T20:08:11.031Z] backtraceparserkdbgwin.cpp[2019-09-16T20:08:11.031Z] backtraceparsernull.cpp[2019-09-16T20:08:11.031Z] backtraceparserlldb.cpp[2019-09-16T20:08:11.031Z] backtraceparsercdb.cpp[2019-09-16T20:08:11.031Z] [ 15%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-09-16T20:08:11.031Z] [ 16%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.obj[2019-09-16T20:08:11.031Z] [ 17%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/bugzilla.cpp.obj[2019-09-16T20:08:11.031Z] drkonqi_parser_debug.cpp[2019-09-16T20:08:11.031Z] [ 18%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/__/drkonqi_debug.cpp.obj[2019-09-16T20:08:11.302Z] [ 19%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.obj[2019-09-16T20:08:11.565Z] [ 19%] Linking CXX executable ..\..\..\bin\crashtest.exe[2019-09-16T20:08:11.565Z] mocs_compilation.cpp[2019-09-16T20:08:11.836Z] [ 20%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/connection.cpp.obj[2019-09-16T20:08:12.916Z] bugzilla.cpp[2019-09-16T20:08:12.916Z] connection.cpp[2019-09-16T20:08:12.916Z] [ 21%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/msvc_generator.cpp.obj[2019-09-16T20:08:15.638Z] [ 21%] Built target crashtest[2019-09-16T20:08:17.661Z] kdbgwin_process.cpp[2019-09-16T20:08:17.661Z] abstract_generator.cpp[2019-09-16T20:08:17.661Z] callbacks.cpp[2019-09-16T20:08:17.661Z] outputters.cpp[2019-09-16T20:08:17.661Z] drkonqi_debug.cpp[2019-09-16T20:08:17.661Z] msvc_generator.cpp[2019-09-16T20:08:18.267Z] [ 21%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_autogen/mocs_compilation.cpp.obj[2019-09-16T20:08:18.267Z] [ 21%] Building CXX object 

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  Getting there!
  
  Use an actual framed list view for the list of folders to not index, like the 
current one has.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added a reviewer: mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24007

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: dfaure, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 66260.
Pitel added a comment.


  Reabse & polish UI

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=31036=66260

BRANCH
  fixedSizeOverride2

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23897: Port mobile_wifi kcm to newer APIs

[Jonah Brüchert]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs 
(authored by jbbgameich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23897?vs=65902=66259

REVISION DETAIL
  https://phabricator.kde.org/D23897

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66258.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65378=66258

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23897: Port mobile_wifi kcm to newer APIs

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.


  Looks good to me.
  
  Jan agreed that we can land patches to the mobile stuff without his approval

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D23897

To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24005: Show a new version string description for updates where the old and new versions are identical

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is common for Flatpak runtime updates, where it seems weird to show 
"3.34 -> 3.34".
  
  With this patch, instead Discover will show "Update to version 3.34", which 
is more
  accurate.

TEST PLAN
  No change for updates where old and new are different or only new version is 
available
  
  Could not test with an update where old and new are the same (only got the 
idea after 
  applying an update today where this happened); will test with the next such 
update

REPOSITORY
  R134 Discover Software Store

BRANCH
  new-version-string-presentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24005

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

[Nathaniel Graham]

ngraham updated this revision to Diff 66253.
ngraham added a comment.


  Check for `task.isWindow` instead

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24001?vs=66249=66253

BRANCH
  dont-show-progress-indicator-for-non-running-apps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24001

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

[Nathaniel Graham]

ngraham added a comment.


  Yeah I was looking for something simple like `task.isRunning` but had to 
settle for checking for a pid in the absence of anything like that. If there's 
a better way to query for whether or not it's open, I'm all ears.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24001

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23984: Redesign intro page

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:9af5acd5aaa7: Redesign intro page (authored by tienisto, 
committed by ngraham).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66251=66252

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66251.
tienisto added a comment.


  use Kirigami units for vertical margin

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66250=66251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

[Kai Uwe Broulik]

broulik added a comment.


  Technically, it could be updated by a background service but I guess this is 
more likely got badges. +1
  You might want to check for isWindow or something instead?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24001

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> introPage.qml:28
>  color: Kirigami.Theme.backgroundColor
> +property int verticalMargin: 50
>  

How about `Kirigami.Units.gridUnit * 3` instead?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66250.
tienisto added a comment.


  change "Frequently used:" to "Frequently Used"

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66246=66250

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, Pinned Icons-Only Task Manager launchers are capable of showing 
progress
  information even when they're not running, because the app didn't unset the 
progress
  information before quitting, or crashed in the middle of an operation. But 
the concept
  of an in-progress operation for an app that isn't running doesn't make 
logical sense.
  
  This patch fixes that UI issue by only allowing pinned IOTM apps to show 
progress
  information while they're actually running.
  
  BUG: 409687
  FIXED-IN: 5.17.0

TEST PLAN
  Pinned Elisa app no longer shows progress information on its icon after 
quitting while
  playing a song
  
  Pinned Discover app no longer shows progress information on its icon after 
crashing in 
  the middle of an update
  
  IOTM apps still shows progress information while running
  
  No change for regular Task Manager

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-show-progress-indicator-for-non-running-apps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24001

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> introPage.qml:92
>  wrapMode: Text.NoWrap
>  text: i18n("Frequently used:")
>  }

Maybe change to "Frequently Used", so it's a header?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23897: Port mobile_wifi kcm to newer APIs

[Jonah Brüchert]

jbbgameich added a comment.


  ping

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D23897

To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:1c7f121073a7: Add time line to X axis (authored by 
alexde, committed by ngraham).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66063=66248

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto added a comment.


  What do other people think about the light rectangle around the "frequently 
used" icons?
  Because I am in favor of this :)

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. Everyone else fine with this?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66246.
tienisto added a comment.


  use rounding again and delete unused id

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66245=66246

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> introPage.qml:85
>  }
> -width: Math.round(parent.width * 0.8)
> +width: parent.width * 0.8
> +

Why change this? Rounding generally fixes the problem of blurriness with 
fractional scaling due to non-integer pixels.

> introPage.qml:88
>  Kirigami.Heading {
> +id: frequentlyUsed
>  Layout.alignment: Qt.AlignHCenter

No need to add an id since nothing references it

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66245.
tienisto added a comment.


  move Kirigami.Heading inside ColumnLayout

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66244=66245

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added a comment.


  TBH I kind of liked the rectangle too.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto added a comment.


  In D23984#532719 , @GB_2 wrote:
  
  > What about a design like this? F7363944: System Settings Intro Page 
Mockup.png 
  
  
  I actually like the light rectangle more because it increase the connection 
between the icons. However if you think so ^^
  What I don't like about your version is that there is so much empty space 
around the content...
  Here is my new version, what do you think?
  
  F7364198: Compromise #1.png 

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> introPage.qml:78
>  }
> -Kirigami.Separator {
> -id: separator
> -anchors.centerIn: parent
> -width: Math.round(parent.width * 0.8)
> +Kirigami.Heading {
> +id: frequentlyUsed

Why move this heading out of the ColumnLayout?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66244.
tienisto added a comment.


  Remove light rectangle; add Plasma icon; more Kirigami units

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66205=66244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23389: Use visible buttons to switch the default device

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:4a13cbf391b4: Use visible buttons to switch the default 
device (authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=65892=66242

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/MuteButton.qml

To: ngraham, drosca, #plasma, #vdg, ndavis
Cc: broulik, GB_2, alexde, ndavis, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use visible buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  Since it seems that there are no formal objections or change requests, I will 
land this in time for the 5.17 beta.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D23389

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg, ndavis
Cc: broulik, GB_2, alexde, ndavis, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Björn Feber]

GB_2 added a comment.


  As you can see in my design, I'd not add a rectangle in the backround, it 
looks weird to me and less clean than before.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added a comment.


  Always good to add the plasma logo in more Plasma places, so I do like that 
part.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Björn Feber]

GB_2 added a comment.


  What about a design like this? F7363944: System Settings Intro Page 
Mockup.png 

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23950: Only show "Add Widgets..." panel context menu option in panel edit mode

[Nathaniel Graham]

ngraham added a comment.


  In my mind, "locked" should be a semi-hidden state really only used by admins 
for locking down a machine's panel and widget configuration. The only reason 
why I currently use Locked mode is to get rid of the visible configure button 
in the panel. If it was hidden by default, and editing was accomplished by 
clicking on something else, speaking personally I would have no need to enter 
locked mode.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23950

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  I agree that we can't only have this UI be in a context menu, and we need to 
expose it somewhere visible too (i.e. in System Settings like we discussed at 
the Plasma + Usability & Productivity sprint.
  
  I kind of like not showing the configure button in the panel though. It bugs 
the heck out of me and break's Fitts' law for the screen corner pixel that it 
appears next to, which is particularly unfortunate as we now do ship a widget 
that benefits from being activated by a screen corner pixel (Show Desktop).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Nathaniel Graham]

ngraham added a comment.


  Cool, will do!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart, ngraham
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Marco Martin]

mart added a comment.


  ok for me at beginning of 5.18 cycle, not yet for 5.17

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart, ngraham
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23997: Add document-share* icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:abb875246a30: Add document-share* icons (authored by 
ndavis).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23997?vs=66238=66239

REVISION DETAIL
  https://phabricator.kde.org/D23997

AFFECTED FILES
  extension/icons/document-share-failed.png
  extension/icons/document-share-failed.svg
  extension/icons/document-share.png
  extension/icons/document-share.svg

To: ndavis, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This seems sensible enough to me. @mart, do you think we can do this for 
5.17, or should we wait until 5.18?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart, ngraham
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23997: Add document-share* icons

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Lovely!

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  document-share (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23997

To: ndavis, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Nathaniel Graham]

ngraham added a comment.


  +1, nice visual improvement. Needs a bit of code polishing first before it 
can land though. See inline comments:

INLINE COMMENTS

> introPage.qml:31
> +property int iconsRectRadius: 10
>  
>  signal focusNextRequest()

Don't hardcode values here; instead use multiples of Kirigami.Units.gridUnit 
(or some other defined unit)

> introPage.qml:57
> +Item {
> +// spacer item
> +width: Kirigami.Units.largeSpacing

Comment not really necessary; it's obvious that this is a spacer

> introPage.qml:63
> +text: i18n("KDE Plasma")
> +font.pointSize: 24 // largest level is too small, so we use 
> pointSize
> +}

Just use level 1, it's big enough IMO (or make the icon next to the text 
smaller to compensate for the smaller text size)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23997: Add document-share* icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 410840

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  document-share (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23997

AFFECTED FILES
  extension/icons/document-share-failed.png
  extension/icons/document-share-failed.svg
  extension/icons/document-share.png
  extension/icons/document-share.svg

To: ndavis, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik updated this revision to Diff 66236.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23151?vs=65650=66236

REVISION DETAIL
  https://phabricator.kde.org/D23151

AFFECTED FILES
  CMakeLists.txt
  extension/_locales/en/messages.json
  extension/constants.js
  extension/content-script.js
  extension/extension-purpose.js
  extension/manifest.json
  extension/options.html
  host/CMakeLists.txt
  host/main.cpp
  host/purposeplugin.cpp
  host/purposeplugin.h

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23996: Port away from deprecated KIO::suggestName

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  KFileUtils::suggestName() is a drop-in replacement, just moved to another 
library

TEST PLAN
  builds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kfu

REVISION DETAIL
  https://phabricator.kde.org/D23996

AFFECTED FILES
  CMakeLists.txt
  applets/icon/iconapplet.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:21d962fe33c8: [kfontinst] Port to use icons from the icon 
theme and make HiDPI aware (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23868?vs=66229=66232

REVISION DETAIL
  https://phabricator.kde.org/D23868

AFFECTED FILES
  kcms/kfontinst/apps/Installer.cpp
  kcms/kfontinst/kcmfontinst/16-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/16-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/22-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/22-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/kcmfontinst/GroupList.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.h
  kcms/kfontinst/viewpart/FontPreview.cpp

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23845: Add a mode to center actions and omit the title when using a ToolBar style

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:872cfbcbd7cf: Add a mode to center actions and omit the 
title when using a ToolBar style (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23845?vs=65866=66230

REVISION DETAIL
  https://phabricator.kde.org/D23845

AFFECTED FILES
  src/controls/PageRow.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ngraham, #kirigami, #vdg, mart, ndavis
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe updated this revision to Diff 66229.
guoyunhe added a comment.


  Rename and move the find duplicate button

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23868?vs=66193=66229

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23868

AFFECTED FILES
  kcms/kfontinst/apps/Installer.cpp
  kcms/kfontinst/kcmfontinst/16-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/16-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/22-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/22-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/kcmfontinst/GroupList.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.h
  kcms/kfontinst/viewpart/FontPreview.cpp

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham added a comment.


  Rename Scan Duplicates... to Find Duplicates... and move the button to the 
left of Install from File... and then I think this will be good.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23980: [Folder View] Don't explicitly initialize fontMetrics

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Oh boy, wow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23980

To: broulik, #plasma, hein, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

5.17 beta announce

[Jonathan Riddell]

First draft of announce is up, improvements welcome
http://apps.kde.org.uk/announcements/plasma-5.16.90.php

Jonathan

D21860: Set a font for gtk applications in the fonts kcm

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> gikari wrote in fonts.cpp:607
> So, I wrote this:
> 
>   GtkConfig::GtkConfig(QObject *parent, const QVariantList&) :
>   KDEDModule(parent), configEditor {new ConfigEditor()}
>   {
>   qDebug() << "Parent: " << parent;
>   QGuiApplication *qapp = static_cast(parent);
>   qDebug() << "Qapp: " << qapp;
>   connect(qapp, ::fontChanged, this, [this](const QFont 
> ) {
>   qDebug() << "Font recieved";
>   qDebug() << font;
>   });
>   qDebug() << "GTK configuration module loaded";
>   }
> 
> And when I save fonts via KCM nothing (Except the "parent", "qapp" and "GTK 
> ..." lines) was printed in konsole, where I run Kded5.  So, it means signal 
> was not send?

Are you sure `parent` is a `QGuiApplication`? I don't think so. Perhaps you 
want to connect to `QGuiApplication::instance()` instead.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23727: Provide a simple test tool to see what autostart will look like

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e7cc46fad0c2: Provide a simple test tool to see what 
autostart will look like (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23727?vs=65441=66224#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23727?vs=65441=66224

REVISION DETAIL
  https://phabricator.kde.org/D23727

AFFECTED FILES
  shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/plasma-autostart-list/CMakeLists.txt
  startkde/plasma-session/plasma-autostart-list/main.cpp

To: apol, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23845: Add a mode to center actions and omit the title when using a ToolBar style

[Nathaniel Graham]

ngraham added a comment.


  In D23845#532373 , @mart wrote:
  
  > One thing i forgot: how does this look when a title is present?
  
  
  It doesn't; `titleLoader` doesn't load the title when using centered 
alignment.

REPOSITORY
  R169 Kirigami

BRANCH
  optional-centered-actions-with-no-title (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23845

To: ngraham, #kirigami, #vdg, mart, ndavis
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 391 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/391/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Sep 2019 13:04:37 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.16.80.xmlacc/LibKWorkspace-5.16.80.xmlacc/LibNotificationManager-5.16.80.xmlacc/LibTaskManager-5.16.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.16.80/log.txtlogs/LibKWorkspace/5.16.80/log.txtlogs/LibNotificationManager/5.16.80/log.txtlogs/LibTaskManager/5.16.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/123)11%
(51/458)11%
(51/458)6%
(2566/41227)4%
(1260/28356)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.kicker.plugin0%
(0/38)0%
(0/38)0%
(0/3347)0%
(0/2591)applets.notifications0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%
(0/1391)0%

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

[Vlad Zahorodnii]

zzag added a comment.


  @jfranklin Ping me if you don't get any feedback in a day or two.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23849

To: jfranklin, #kwin, #plasma, zzag
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

[Vlad Zahorodnii]

zzag added a comment.


  This change looks good to me, however I know only general bits of 
KScreenLocker.
  
  Perhaps someone else from #KWin  or 
#Plasma  could review this patch.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23849

To: jfranklin, #kwin, #plasma, zzag
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 129 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/129/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 13:04:48 +
 Build duration:
4 min 57 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

[Jason Franklin]

jfranklin added a comment.


  Friendly ping concerning this issue.  Has anyone related to the screen locker 
project had some time to take a quick look at this?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23849

To: jfranklin, #kwin, #plasma, zzag
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 128 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/128/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 12:55:44 +
 Build duration:
4 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 3905 lines...][2019-09-16T13:00:00.832Z] [ 94%] Built target plasma_engine_statusnotifieritem[2019-09-16T13:00:00.832Z] Scanning dependencies of target ksmserver_autogen[2019-09-16T13:00:00.832Z] [ 94%] Automatic MOC for target ksmserver[2019-09-16T13:00:00.832Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/plasmashell_autogen/mocs_compilation.cpp.o[2019-09-16T13:00:00.832Z] [ 94%] Built target ksmserver_autogen[2019-09-16T13:00:00.832Z] Scanning dependencies of target kcminit_autogen[2019-09-16T13:00:00.832Z] [ 95%] Automatic MOC for target kcminit[2019-09-16T13:00:00.832Z] [ 95%] Built target kcminit_autogen[2019-09-16T13:00:00.832Z] Scanning dependencies of target krunner[2019-09-16T13:00:00.832Z] Scanning dependencies of target kcminit_startup_autogen[2019-09-16T13:00:00.832Z] [ 95%] Building CXX object krunner/CMakeFiles/krunner.dir/krunner_autogen/mocs_compilation.cpp.o[2019-09-16T13:00:00.832Z] [ 95%] Automatic MOC for target kcminit_startup[2019-09-16T13:00:00.832Z] [ 95%] Built target kcminit_startup_autogen[2019-09-16T13:00:01.088Z] [ 95%] Building CXX object krunner/CMakeFiles/krunner.dir/main.cpp.o[2019-09-16T13:00:01.088Z] [ 96%] Linking CXX shared module ../bin/appmenu.so[2019-09-16T13:00:01.088Z] [ 96%] Built target appmenu[2019-09-16T13:00:01.088Z] [ 96%] Building CXX object krunner/CMakeFiles/krunner.dir/view.cpp.o[2019-09-16T13:00:01.351Z] [ 96%] Building CXX object krunner/CMakeFiles/krunner.dir/appadaptor.cpp.o[2019-09-16T13:00:01.634Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemmodel.cpp.o[2019-09-16T13:00:01.634Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemsettings.cpp.o[2019-09-16T13:00:01.895Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/components/sessionsprivate/sessionsmodel.cpp:212:74: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2019-09-16T13:00:01.895Z] QObject::connect(watcher, ::finished, this, [this, cb](QDBusPendingCallWatcher *watcher) {[2019-09-16T13:00:01.895Z]  ^[2019-09-16T13:00:02.160Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/wheelinterceptor.cpp.o[2019-09-16T13:00:02.417Z] [ 96%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.o[2019-09-16T13:00:02.417Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/windowsystem.cpp.o[2019-09-16T13:00:02.417Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:33:10: fatal error: 'kworkspace5/kdisplaymanager.h' file not found[2019-09-16T13:00:02.417Z] #include [2019-09-16T13:00:02.417Z]  ^~~[2019-09-16T13:00:02.417Z] 1 error generated.[2019-09-16T13:00:02.417Z] gmake[2]: *** [applets/kicker/CMakeFiles/kickerplugin.dir/build.make:423: applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systementry.cpp.o] Error 1[2019-09-16T13:00:02.417Z] gmake[2]: *** Waiting for unfinished jobs[2019-09-16T13:00:02.680Z] 1 warning generated.[2019-09-16T13:00:02.680Z] Scanning dependencies of target testChromeBookmarks[2019-09-16T13:00:02.680Z] [ 96%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o[2019-09-16T13:00:02.680Z] [ 96%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testChromeBookmarks_autogen/mocs_compilation.cpp.o[2019-09-16T13:00:02.938Z] [ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2019-09-16T13:00:02.938Z] [ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2019-09-16T13:00:03.202Z] [ 96%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testchromebookmarks.cpp.o[2019-09-16T13:00:03.458Z] [ 96%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o[2019-09-16T13:00:03.459Z] Scanning dependencies of target servicerunnertest[2019-09-16T13:00:03.459Z] [ 96%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest_autogen/mocs_compilation.cpp.o[2019-09-16T13:00:03.459Z] [ 96%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest.cpp.o[2019-09-16T13:00:03.459Z] [ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2019-09-16T13:00:03.722Z] [ 96%] Linking CXX executable ../bin/krunner[2019-09-16T13:00:03.722Z] [ 96%] Built target 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 127 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/127/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 12:26:47 +
 Build duration:
28 min and counting
   CONSOLE OUTPUT
  [...truncated 3879 lines...][2019-09-16T12:55:23.270Z] [ 92%] Building CXX object libcolorcorrect/autotests/CMakeFiles/nightcolortest.dir/nightcolortest_autogen/mocs_compilation.cpp.o[2019-09-16T12:55:23.270Z] [ 93%] Generating screensaver_interface.cpp, screensaver_interface.h[2019-09-16T12:55:23.270Z] [ 93%] Built target colorcorrectlocationupdater[2019-09-16T12:55:23.270Z] [ 93%] Generating screensaver_interface.moc[2019-09-16T12:55:23.270Z] [ 93%] Generating krunner_interface.cpp, krunner_interface.h[2019-09-16T12:55:23.270Z] [ 93%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/recentusagemodel.cpp.o[2019-09-16T12:55:23.270Z] [ 94%] Generating plasmashelladaptor.cpp, plasmashelladaptor.h[2019-09-16T12:55:23.270Z] [ 94%] Generating krunner_interface.moc[2019-09-16T12:55:23.270Z] [ 94%] Generating plasmashelladaptor.moc[2019-09-16T12:55:23.270Z] [ 94%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/submenu.cpp.o[2019-09-16T12:55:23.270Z] Scanning dependencies of target sessionsprivateplugin[2019-09-16T12:55:23.270Z] 1 warning generated.[2019-09-16T12:55:23.270Z] [ 94%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin_autogen/mocs_compilation.cpp.o[2019-09-16T12:55:23.270Z] [ 94%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systementry.cpp.o[2019-09-16T12:55:24.894Z] Scanning dependencies of target plasmashell[2019-09-16T12:55:24.894Z] [ 94%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemmodel.cpp.o[2019-09-16T12:55:24.894Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/plasmashell_autogen/mocs_compilation.cpp.o[2019-09-16T12:55:24.894Z] [ 94%] Linking CXX shared module ../../bin/plasma_engine_statusnotifieritem.so[2019-09-16T12:55:25.172Z] [ 94%] Building CXX object libcolorcorrect/autotests/CMakeFiles/nightcolortest.dir/nightcolortest.cpp.o[2019-09-16T12:55:25.471Z] [ 94%] Built target plasma_engine_statusnotifieritem[2019-09-16T12:55:25.471Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2019-09-16T12:55:25.790Z] [ 94%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsmodel.cpp.o[2019-09-16T12:55:26.069Z] [ 94%] Building CXX object libcolorcorrect/autotests/CMakeFiles/nightcolortest.dir/mock_kwin.cpp.o[2019-09-16T12:55:27.055Z] [ 94%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemsettings.cpp.o[2019-09-16T12:55:27.055Z] [ 94%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.o[2019-09-16T12:55:27.335Z] [ 94%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o[2019-09-16T12:55:27.335Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:33:10: fatal error: 'kworkspace5/kdisplaymanager.h' file not found[2019-09-16T12:55:27.335Z] #include [2019-09-16T12:55:27.335Z]  ^~~[2019-09-16T12:55:27.335Z] 1 error generated.[2019-09-16T12:55:27.335Z] gmake[2]: *** [applets/kicker/CMakeFiles/kickerplugin.dir/build.make:423: applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systementry.cpp.o] Error 1[2019-09-16T12:55:27.335Z] gmake[2]: *** Waiting for unfinished jobs[2019-09-16T12:55:27.335Z] Scanning dependencies of target klipper[2019-09-16T12:55:27.335Z] [ 94%] Building CXX object klipper/CMakeFiles/klipper.dir/klipper_autogen/mocs_compilation.cpp.o[2019-09-16T12:55:27.623Z] [ 94%] Building CXX object klipper/CMakeFiles/klipper.dir/klipper_dummy.cpp.o[2019-09-16T12:55:27.623Z] [ 94%] Linking CXX executable ../bin/klipper[2019-09-16T12:55:27.623Z] [ 94%] Built target klipper[2019-09-16T12:55:27.623Z] [ 95%] Generating appadaptor.cpp, appadaptor.h[2019-09-16T12:55:27.623Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2019-09-16T12:55:27.917Z] [ 95%] Generating appadaptor.moc[2019-09-16T12:55:27.917Z] gmake[1]: *** [CMakeFiles/Makefile2:9188: applets/kicker/CMakeFiles/kickerplugin.dir/all] Error 2[2019-09-16T12:55:27.917Z] gmake[1]: *** Waiting for unfinished jobs[2019-09-16T12:55:27.917Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2019-09-16T12:55:28.199Z] Scanning dependencies of target krunner[2019-09-16T12:55:28.199Z] [ 95%] Building CXX object krunner/CMakeFiles/krunner.dir/krunner_autogen/mocs_compilation.cpp.o[2019-09-16T12:55:28.199Z] [ 95%] Building CXX object 

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 390 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/390/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Sep 2019 12:40:02 +
 Build duration:
4 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 3656 lines...][2019-09-16T12:44:21.855Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-09-16T12:44:21.855Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/dataengines/powermanagement/powermanagementjob.cpp:33:[2019-09-16T12:44:21.855Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:129:40: note: declared here[2019-09-16T12:44:21.855Z]   129 | KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingScreenPowerManagement(int cookie);[2019-09-16T12:44:21.855Z]   |^~~~[2019-09-16T12:44:21.855Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/dataengines/powermanagement/powermanagementjob.cpp:92:132: warning: ���bool Solid::PowerManagement::stopSuppressingScreenPowerManagement(int)��� is deprecated [-Wdeprecated-declarations][2019-09-16T12:44:21.855Z]92 | setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt()));[2019-09-16T12:44:21.855Z]   |^[2019-09-16T12:44:21.855Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-09-16T12:44:21.855Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/dataengines/powermanagement/powermanagementjob.cpp:33:[2019-09-16T12:44:21.855Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:129:40: note: declared here[2019-09-16T12:44:21.855Z]   129 | KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingScreenPowerManagement(int cookie);[2019-09-16T12:44:21.855Z]   |^~~~[2019-09-16T12:44:21.855Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/dataengines/powermanagement/powermanagementjob.cpp:92:132: warning: ���bool Solid::PowerManagement::stopSuppressingScreenPowerManagement(int)��� is deprecated [-Wdeprecated-declarations][2019-09-16T12:44:21.855Z]92 | setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt()));[2019-09-16T12:44:21.855Z]   |^[2019-09-16T12:44:21.855Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-09-16T12:44:21.855Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/dataengines/powermanagement/powermanagementjob.cpp:33:[2019-09-16T12:44:21.855Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:129:40: note: declared here[2019-09-16T12:44:21.855Z]   129 | KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingScreenPowerManagement(int cookie);[2019-09-16T12:44:21.855Z]   |^~~~[2019-09-16T12:44:21.855Z] [ 89%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemjob.cpp.o[2019-09-16T12:44:21.855Z] [ 89%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/systemtraytypes.cpp.o[2019-09-16T12:44:22.111Z] [ 89%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/runnermatchesmodel.cpp.o[2019-09-16T12:44:22.367Z] [ 89%] Built target plasmashell[2019-09-16T12:44:22.367Z] [ 89%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/recentcontactsmodel.cpp.o[2019-09-16T12:44:22.367Z] [ 89%] Building CXX object dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementservice.cpp.o[2019-09-16T12:44:22.367Z] [ 89%] Building CXX object dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/krunner_interface.cpp.o[2019-09-16T12:44:23.296Z] Scanning dependencies of target testPlatformDetection[2019-09-16T12:44:23.296Z] [ 89%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection_autogen/mocs_compilation.cpp.o[2019-09-16T12:44:23.296Z] [ 89%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection.cpp.o[2019-09-16T12:44:23.296Z] [ 89%] Building CXX object 

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 389 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/389/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Sep 2019 12:26:47 +
 Build duration:
1 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 280 lines...][2019-09-16T12:27:53.557Z] BUILD_ID  = '389'[2019-09-16T12:27:53.557Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-16T12:27:53.557Z] OLDPWD= '/home/jenkins'[2019-09-16T12:27:53.557Z] LC_CTYPE  = 'C.UTF-8'[2019-09-16T12:27:53.557Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-16T12:27:53.557Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-16T12:27:53.557Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-16T12:27:53.557Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-16T12:27:53.557Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-16T12:27:53.557Z] QT_SELECT = 'qt5'[2019-09-16T12:27:53.557Z] LANG  = 'en_US.UTF-8'[2019-09-16T12:27:53.557Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-16T12:27:53.557Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-16T12:27:53.557Z] [2019-09-16T12:27:53.557Z] [2019-09-16T12:27:53.557Z] == Commencing Configuration:[2019-09-16T12:27:53.557Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12"[2019-09-16T12:27:55.444Z] -- The C compiler identification is GNU 9.2.1[2019-09-16T12:27:56.003Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-16T12:27:56.003Z] -- Check for working C compiler: /usr/bin/cc[2019-09-16T12:27:56.003Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-16T12:27:56.003Z] -- Detecting C compiler ABI info[2019-09-16T12:27:56.003Z] -- Detecting C compiler ABI info - done[2019-09-16T12:27:56.003Z] -- Detecting C compile features[2019-09-16T12:27:56.003Z] -- Detecting C compile features - done[2019-09-16T12:27:56.003Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-16T12:27:56.003Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-16T12:27:56.259Z] -- Detecting CXX compiler ABI info[2019-09-16T12:27:56.259Z] -- Detecting CXX compiler ABI info - done[2019-09-16T12:27:56.259Z] -- Detecting CXX compile features[2019-09-16T12:27:56.259Z] -- Detecting CXX compile features - done[2019-09-16T12:27:56.259Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:27:56.259Z] -- Looking for __GLIBC__[2019-09-16T12:27:56.259Z] -- Looking for __GLIBC__ - found[2019-09-16T12:27:56.259Z] -- Performing Test _OFFT_IS_64BIT[2019-09-16T12:27:56.259Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-16T12:27:56.259Z] -- Performing Test HAVE_DATE_TIME[2019-09-16T12:27:56.515Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-16T12:27:56.515Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:27:56.515Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:27:56.515Z] -- Found KF5Plasma: /home/jenkins/install-prefix/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.63.0") [2019-09-16T12:27:56.515Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.62.0") [2019-09-16T12:27:56.515Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:27:56.515Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:27:56.515Z] -- Found KF5Runner: /home/jenkins/install-prefix/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake (found version "5.62.0") [2019-09-16T12:27:56.515Z] -- Found KF5NotifyConfig: /home/jenkins/install-prefix/lib64/cmake/KF5NotifyConfig/KF5NotifyConfigConfig.cmake (found version "5.62.0") [2019-09-16T12:27:56.515Z] -- Found KF5Su: /home/jenkins/install-prefix/lib64/cmake/KF5Su/KF5SuConfig.cmake (found version "5.62.0") [2019-09-16T12:27:56.515Z] -- Found KF5NewStuff: 

D23982: [Notifications] Kill job after 2 seconds if application doesn't react to cancel request

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:49519b7a0691: [Notifications] Kill job after 2 seconds if 
application doesnt react to cancel… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23982?vs=66188=66211

REVISION DETAIL
  https://phabricator.kde.org/D23982

AFFECTED FILES
  libnotificationmanager/job.cpp
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[plasma-desktop] /: applets/kicker: remove the plugin

[Bhushan Shah]

Git commit 84c8dade3ce0c9cad9da26b083c954655266c639 by Bhushan Shah.
Committed on 16/09/2019 at 12:22.
Pushed by bshah into branch 'master'.

applets/kicker: remove the plugin

plugin is now part of plasma-workspace, so other launcher can easily
re-use models.

CCMAIL: h...@kde.org
CCMAIL: plasma-devel@kde.org

M  +0-10   CMakeLists.txt
M  +0-88   applets/kicker/CMakeLists.txt
D  +0-108  applets/kicker/plugin/abstractentry.cpp
D  +0-79   applets/kicker/plugin/abstractentry.h
D  +0-164  applets/kicker/plugin/abstractmodel.cpp
D  +0-86   applets/kicker/plugin/abstractmodel.h
D  +0-420  applets/kicker/plugin/actionlist.cpp
D  +0-75   applets/kicker/plugin/actionlist.h
D  +0-303  applets/kicker/plugin/appentry.cpp
D  +0-95   applets/kicker/plugin/appentry.h
D  +0-748  applets/kicker/plugin/appsmodel.cpp
D  +0-158  applets/kicker/plugin/appsmodel.h
D  +0-301  applets/kicker/plugin/computermodel.cpp
D  +0-119  applets/kicker/plugin/computermodel.h
D  +0-143  applets/kicker/plugin/contactentry.cpp
D  +0-55   applets/kicker/plugin/contactentry.h
D  +0-252  applets/kicker/plugin/containmentinterface.cpp
D  +0-58   applets/kicker/plugin/containmentinterface.h
D  +0-235  applets/kicker/plugin/dashboardwindow.cpp
D  +0-81   applets/kicker/plugin/dashboardwindow.h
D  +0-113  applets/kicker/plugin/draghelper.cpp
D  +0-60   applets/kicker/plugin/draghelper.h
D  +0-123  applets/kicker/plugin/fileentry.cpp
D  +0-53   applets/kicker/plugin/fileentry.h
D  +0-265  applets/kicker/plugin/forwardingmodel.cpp
D  +0-77   applets/kicker/plugin/forwardingmodel.h
D  +0-98   applets/kicker/plugin/funnelmodel.cpp
D  +0-36   applets/kicker/plugin/funnelmodel.h
D  +0-719  applets/kicker/plugin/kastatsfavoritesmodel.cpp
D  +0-116  applets/kicker/plugin/kastatsfavoritesmodel.h
D  +0-65   applets/kicker/plugin/kickerplugin.cpp
D  +0-35   applets/kicker/plugin/kickerplugin.h
D  +0-68   applets/kicker/plugin/menuentryeditor.cpp
D  +0-39   applets/kicker/plugin/menuentryeditor.h
D  +0-407  applets/kicker/plugin/placeholdermodel.cpp
D  +0-94   applets/kicker/plugin/placeholdermodel.h
D  +0-35   applets/kicker/plugin/processrunner.cpp
D  +0-36   applets/kicker/plugin/processrunner.h
D  +0-2applets/kicker/plugin/qmldir
D  +0-246  applets/kicker/plugin/recentcontactsmodel.cpp
D  +0-59   applets/kicker/plugin/recentcontactsmodel.h
D  +0-491  applets/kicker/plugin/recentusagemodel.cpp
D  +0-115  applets/kicker/plugin/recentusagemodel.h
D  +0-453  applets/kicker/plugin/rootmodel.cpp
D  +0-127  applets/kicker/plugin/rootmodel.h
D  +0-255  applets/kicker/plugin/runnermatchesmodel.cpp
D  +0-64   applets/kicker/plugin/runnermatchesmodel.h
D  +0-337  applets/kicker/plugin/runnermodel.cpp
D  +0-108  applets/kicker/plugin/runnermodel.h
D  +0-333  applets/kicker/plugin/simplefavoritesmodel.cpp
D  +0-91   applets/kicker/plugin/simplefavoritesmodel.h
D  +0-98   applets/kicker/plugin/submenu.cpp
D  +0-56   applets/kicker/plugin/submenu.h
D  +0-350  applets/kicker/plugin/systementry.cpp
D  +0-66   applets/kicker/plugin/systementry.h
D  +0-135  applets/kicker/plugin/systemmodel.cpp
D  +0-52   applets/kicker/plugin/systemmodel.h
D  +0-46   applets/kicker/plugin/systemsettings.cpp
D  +0-36   applets/kicker/plugin/systemsettings.h
D  +0-72   applets/kicker/plugin/wheelinterceptor.cpp
D  +0-52   applets/kicker/plugin/wheelinterceptor.h
D  +0-91   applets/kicker/plugin/windowsystem.cpp
D  +0-53   applets/kicker/plugin/windowsystem.h
D  +0-1config-appstream.h.cmake

https://commits.kde.org/plasma-desktop/84c8dade3ce0c9cad9da26b083c954655266c639

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/126/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 12:14:12 +
 Build duration:
8 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 230 lines...][2019-09-16T12:22:59.455Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-09-16T12:22:59.455Z] [2019-09-16T12:22:59.455Z] [2019-09-16T12:22:59.455Z] == Commencing Configuration:[2019-09-16T12:22:59.455Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13"[2019-09-16T12:22:59.711Z] -- The C compiler identification is Clang 6.0.1[2019-09-16T12:22:59.711Z] -- The CXX compiler identification is Clang 6.0.1[2019-09-16T12:22:59.711Z] -- Check for working C compiler: /usr/bin/cc[2019-09-16T12:22:59.711Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-16T12:22:59.711Z] -- Detecting C compiler ABI info[2019-09-16T12:22:59.968Z] -- Detecting C compiler ABI info - done[2019-09-16T12:22:59.968Z] -- Detecting C compile features[2019-09-16T12:22:59.968Z] -- Detecting C compile features - done[2019-09-16T12:22:59.968Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-16T12:23:00.226Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-16T12:23:00.226Z] -- Detecting CXX compiler ABI info[2019-09-16T12:23:00.226Z] -- Detecting CXX compiler ABI info - done[2019-09-16T12:23:00.226Z] -- Detecting CXX compile features[2019-09-16T12:23:00.482Z] -- Detecting CXX compile features - done[2019-09-16T12:23:00.482Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:23:00.482Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-09-16T12:23:00.482Z] -- Looking for __GLIBC__[2019-09-16T12:23:00.738Z] -- Looking for __GLIBC__ - not found[2019-09-16T12:23:00.738Z] -- Performing Test _OFFT_IS_64BIT[2019-09-16T12:23:00.738Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-16T12:23:00.738Z] -- Performing Test HAVE_DATE_TIME[2019-09-16T12:23:00.738Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-16T12:23:00.738Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:23:00.738Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:23:00.738Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.63.0") [2019-09-16T12:23:00.738Z] -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5Runner: /usr/home/jenkins/install-prefix/lib/cmake/KF5Runner/KF5RunnerConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5NotifyConfig: /usr/home/jenkins/install-prefix/lib/cmake/KF5NotifyConfig/KF5NotifyConfigConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5Su: /usr/home/jenkins/install-prefix/lib/cmake/KF5Su/KF5SuConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5NewStuff: /usr/home/jenkins/install-prefix/lib/cmake/KF5NewStuff/KF5NewStuffConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5Wallet: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wallet/KF5WalletConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-09-16T12:23:00.738Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.738Z] -- Found KF5TextWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.999Z] -- Found KF5KDELibs4Support: /usr/home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (found version "5.62.0") [2019-09-16T12:23:00.999Z] -- Found KF5Crash: 

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 66209.
Pitel added a comment.


  Rebase on current master and squash

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=30859=66209

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b159222aa558: Take in consideration flat() for the All 
Applications menu (authored by tcanabrava).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22762?vs=62606=66207#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22762?vs=62606=66207

REVISION DETAIL
  https://phabricator.kde.org/D22762

AFFECTED FILES
  rootmodel.cpp

To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 388 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/388/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Sep 2019 12:14:12 +
 Build duration:
4 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 280 lines...][2019-09-16T12:18:24.226Z] BUILD_ID  = '388'[2019-09-16T12:18:24.226Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-16T12:18:24.226Z] OLDPWD= '/home/jenkins'[2019-09-16T12:18:24.226Z] LC_CTYPE  = 'C.UTF-8'[2019-09-16T12:18:24.226Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-16T12:18:24.226Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-16T12:18:24.226Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-16T12:18:24.226Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-16T12:18:24.226Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-16T12:18:24.226Z] QT_SELECT = 'qt5'[2019-09-16T12:18:24.226Z] LANG  = 'en_US.UTF-8'[2019-09-16T12:18:24.226Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-16T12:18:24.226Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-16T12:18:24.226Z] [2019-09-16T12:18:24.226Z] [2019-09-16T12:18:24.226Z] == Commencing Configuration:[2019-09-16T12:18:24.226Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12"[2019-09-16T12:18:24.735Z] -- The C compiler identification is GNU 9.2.1[2019-09-16T12:18:24.735Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-16T12:18:24.735Z] -- Check for working C compiler: /usr/bin/cc[2019-09-16T12:18:25.242Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-16T12:18:25.242Z] -- Detecting C compiler ABI info[2019-09-16T12:18:25.242Z] -- Detecting C compiler ABI info - done[2019-09-16T12:18:25.242Z] -- Detecting C compile features[2019-09-16T12:18:25.242Z] -- Detecting C compile features - done[2019-09-16T12:18:25.242Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-16T12:18:25.242Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-16T12:18:25.242Z] -- Detecting CXX compiler ABI info[2019-09-16T12:18:25.745Z] -- Detecting CXX compiler ABI info - done[2019-09-16T12:18:25.745Z] -- Detecting CXX compile features[2019-09-16T12:18:25.745Z] -- Detecting CXX compile features - done[2019-09-16T12:18:26.250Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:18:26.250Z] -- Looking for __GLIBC__[2019-09-16T12:18:26.250Z] -- Looking for __GLIBC__ - found[2019-09-16T12:18:26.250Z] -- Performing Test _OFFT_IS_64BIT[2019-09-16T12:18:26.762Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-16T12:18:26.762Z] -- Performing Test HAVE_DATE_TIME[2019-09-16T12:18:28.418Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-16T12:18:34.546Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:18:35.594Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:18:35.594Z] -- Found KF5Plasma: /home/jenkins/install-prefix/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.63.0") [2019-09-16T12:18:35.594Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.62.0") [2019-09-16T12:18:36.093Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:18:36.093Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-workspace.[2019-09-16T12:18:36.093Z] -- Found KF5Runner: /home/jenkins/install-prefix/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake (found version "5.62.0") [2019-09-16T12:18:36.093Z] -- Found KF5NotifyConfig: /home/jenkins/install-prefix/lib64/cmake/KF5NotifyConfig/KF5NotifyConfigConfig.cmake (found version "5.62.0") [2019-09-16T12:18:36.093Z] -- Found KF5Su: /home/jenkins/install-prefix/lib64/cmake/KF5Su/KF5SuConfig.cmake (found version "5.62.0") [2019-09-16T12:18:37.141Z] -- Found KF5NewStuff: 

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto marked 4 inline comments as done.
tienisto added a comment.


  Okay. Now I am using more Kirigami units now. About "KDE Plasma" vs "Plasma" 
I am not sure because Plasma is less known than KDE.
  Regarding the round corners, I have decreased the radius a little bit. Hope 
it is better now? :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D6813: Use customized font size for Digital Clock applet

[Yunhe Guo]

guoyunhe abandoned this revision.
guoyunhe added a comment.


  It seems not possible to set font size because others insist the font size 
should grow with panel. Another alternative widget might be better way to push 
forward.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6813

To: guoyunhe, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66205.
tienisto added a comment.


  less rounded corners and decrease use of hard coded numbers

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66201=66205

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D17704: Copy to clipboard always copy English texts

[Yunhe Guo]

guoyunhe added a comment.


  Yes, this can be closed because another approach is more useful.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23984: [System Settings] redesign intro page

[Filip Fila]

filipf added a comment.


  +1 for redesigning the page a bit. What I really dislike about it right now 
is that there is no hover effect for the icons.
  
  Regarding the changes here, I'm unsure about the rounded rectangle. Doesn't 
seem like it fits with design everywhere else.
  
  Will comment more extensively once I test the patch though.
  
  And yeah hardcoding should be avoided, check out the HIG pages on 
units.smallSpacing/units.largeSpacing and units.gridUnit.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23941: Compensate smaller icon sizes on mobile in the ActionButton

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:eb364c963630: Compensate smaller icon sizes on mobile in 
the ActionButton (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23941?vs=66040=66202

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto marked 3 inline comments as done.
tienisto added a comment.


  Thanks for your feedback. I was actually lighten the background instead of 
darken it :)
  But still, Qt.darker/Qt.lighter is much simpler!

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender