D25100: Mark all wallpaper plugins as addons

[Aleix Pol Gonzalez]

apol added a comment.


  > But the distro-provided version (openSUSE Tumbleweed) does not:
  
  Yes, this happens because distros don't take plasma-workspace as a 
dependency, but in your computer you do have plasma-workspace installed.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[Nathaniel Graham]

ngraham added a comment.


  In D25100#557494 , @apol wrote:
  
  > One thing we could do is update this patch to have 
`X-KDE-ParentApp=org.kde.plasmashell` instead of the .plasma (which I'm pretty 
sure it doesn't make a difference, you can check by reading the top of the 
appdata.xml file and see if it starts with ``.
  
  
  The local version that I've built seems to be an addon, even without this 
patch:
  
grep -i extends -B 2 
/home/nate/kde/usr/share/metainfo/org.kde.haenau.appdata.xml

org.kde.haenau
org.kde.plasmashell
  
  But the distro-provided version (openSUSE Tumbleweed) does not:
  
grep -i extends -B 2 /usr/share/metainfo/org.kde.haenau.appdata.xml
[nothing]

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[Aleix Pol Gonzalez]

apol added a comment.


  I just looked into it, the problem is that 
`plasma_packagestructure_wallpaper.so` is installed by plasma-workspace, which 
isn't a dependency of kdeplasma-addons.
  
  One thing we could do is update this patch to have 
`X-KDE-ParentApp=org.kde.plasmashell` instead of the .plasma (which I'm pretty 
sure it doesn't make a difference, you can check by reading the top of the 
appdata.xml file and see if it starts with ``.
  Alternatively we could move the qmlWallpaper bit to plasma-framework and then 
plasma wallpapers should always be detected properly.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22967: Let KDBusService deal with the replace option

[Aleix Pol Gonzalez]

apol updated this revision to Diff 69146.
apol added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22967?vs=63186=69146

BRANCH
  arcpatch-D22967

REVISION DETAIL
  https://phabricator.kde.org/D22967

AFFECTED FILES
  krunner/main.cpp
  shell/main.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Yes, it's the wrong fix.
  
  For reference, it's not about discover, it's about generating the appstream 
file properly.
  Will try to provide a patch next week.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[David Redondo]

davidre added a comment.


  I don't know how Discover works but to me looks the wrong fix. Does every 
third party wallpaper then also need to have a name with plasma in it?
  In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as 
add-on and not having plasma in it's name.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 197 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/197/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 22:50:04 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 3461 lines...][2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T22:52:09.469Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T22:52:09.469Z]   ^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T22:52:09.469Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T22:52:09.469Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T22:52:09.469Z]  ^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T22:52:09.469Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-31T22:52:09.469Z]  ^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T22:52:09.469Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T22:52:09.469Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T22:52:09.469Z]  ^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T22:52:09.469Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T22:52:09.469Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T22:52:09.469Z]   ^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T22:52:09.469Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.469Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T22:52:09.469Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T22:52:09.469Z]  ^[2019-10-31T22:52:09.469Z] [ 53%] Linking CXX shared module ../../bin/kcm_style.so[2019-10-31T22:52:09.469Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T22:52:09.469Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T22:52:09.469Z]^[2019-10-31T22:52:09.470Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T22:52:09.470Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T22:52:09.470Z]   ^[2019-10-31T22:52:09.470Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T22:52:09.470Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT 

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:da268696a6af: [Task Manager] Toggle mute when the audio 
indicator is clicked (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=69128=69145

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: GB_2, #plasma, #vdg, ngraham, hein, faridb
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25100: Mark all wallpaper plugins as addons

[Nathaniel Graham]

ngraham added a comment.


  Hmm so if this is the correct solution to the indicated problem, I guess we 
would need a kconf update script to change the IDs in 
`plasma-org.kde.plasma.desktop-appletsrc`?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[David Edmundson]

davidedmundson added a comment.


  What happens if a user has their setup to use potd or hunyango and we change 
this ID?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Alright, will disable those

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Nathaniel Graham]

ngraham added a comment.


  If there are any settings that have no effect while something else is 
handling notifications or there's no widget, I think it makes sense to disable 
those. Other settings that are more universal can stay enabled for sure.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik added a comment.


  > Would it makes sense to also disable all the controls in the KCM when 
either of these messages are open?
  
  I was wondering that, too, but not sure I want to artificially block those 
settings. Perhaps for the upper check boxes. Progress reporting is unaffected 
and KNotification settings would still work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, mak, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Heanau, Hunyango, and POTD wallpaper plugins still show up in Discover as 
apps because
  they aren't getting marked as addons properly.
  
  I *think* this is because their IDs aren't prefixed with `org.kde.plasma` 
such that this
  patch will fix the issue.
  
  BUG: 413688
  FIXED-IN: 5.17.3

TEST PLAN
  Can't test these kinds of AppStream changes. :/ Please let me know if this is 
dumb. :)

REPOSITORY
  R114 Plasma Addons

BRANCH
  mark-all-wallpaper-plugins-as-addons (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D25100

AFFECTED FILES
  wallpapers/haenau/metadata.desktop
  wallpapers/hunyango/metadata.desktop
  wallpapers/potd/metadata.desktop

To: ngraham, apol, mak, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69141.
gikari added a comment.


  - Transform ConfigEditor to namespace
  - Make `KSharedConfigPtr`s of kdeglobals and input configs the 
`ConfigValueProvider` members

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69133=69141

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Sorry, currently no time for Plasma available: see also 
https://mail.kde.org/pipermail/plasma-devel/2019-October/105088.html

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25082

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25019: Ensure that GlobalDrawer topContent always stays on top

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cae9d9cdbd71: Ensure that GlobalDrawer topContent always 
stays on top (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25019?vs=69116=69139

REVISION DETAIL
  https://phabricator.kde.org/D25019

AFFECTED FILES
  src/controls/GlobalDrawer.qml

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25019: Ensure that GlobalDrawer topContent always stays on top

[Nathaniel Graham]

ngraham added a comment.


  Got confirmation from @notmart in chat that this is good to go. Landing it!

REPOSITORY
  R169 Kirigami

BRANCH
  topContent-always-on-top (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25019

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69133.
gikari marked 8 inline comments as done.
gikari edited the summary of this revision.
gikari added a comment.


  - Replace `()` initialization with `=` one
  - Embrace QStringLiteral madness even more
  - Rename some variables and method names

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=68260=69133

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> gikari wrote in configeditor.cpp:49
> Where generally should I use equals sign (`=`), where parenthesis (`()`) and 
> where braces (`{}`) for initialization? I didn't find any note about that in 
> coding style .

I believe in general use equals, but you can use braces for lists.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> ervin wrote in configeditor.cpp:49
> Better wrap the const char* in a QStringLiteral.
> 
> Also, but more of a nitpick this time: style wise I'd favor using = for those 
> initialization (and others in the file) than parenthesis. It gets too close 
> the most vexing parse territory, I'd rather not potentially expose a future 
> developer touching that file to it.

Where generally should I use equals sign (`=`), where parenthesis (`()`) and 
where braces (`{}`) for initialization? I didn't find any note about that in 
coding style .

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Nathaniel Graham]

ngraham added a comment.


  +1 conceptually. Would it makes sense to also disable all the controls in the 
KCM when either of these messages are open?

INLINE COMMENTS

> main.qml:56
> +type: Kirigami.MessageType.Error
> +text: i18n("Could not find a 'Notifications' widget.");
> +visible: kcm.serverStatus === Private.KCM.NotRunning

Maybe connect this with the reason why one the widget is needed:

"Could not find a 'Notifications' widget which is required for displaying 
notifications."

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 updated this revision to Diff 69128.
GB_2 added a comment.


  Remove unneeded properties

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=69127=69128

BRANCH
  arcpatch-D19822

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: GB_2, #plasma, #vdg, ngraham, hein, faridb
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 updated this revision to Diff 69127.
GB_2 added a comment.


  Move into AudioStream

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=65691=69127

BRANCH
  arcpatch-D19822

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: GB_2, #plasma, #vdg, ngraham, hein, faridb
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25096: [Digital Clock] Disable custom format input when date option is unchecked

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e477d80bbbc7: [Digital Clock] Disable custom format input 
when date option is unchecked (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25096?vs=69122=69124

REVISION DETAIL
  https://phabricator.kde.org/D25096

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I've seen people complaining about ugly notification popups when they were in 
fact running Dunst instead of Plasma.
  Since the KCM won't work with notifications other than Plasma's, this patch 
adds a hint informing the user when there is no notification widget or 
notifications are provided by another service than Plasma.
  Notification API provides a way to query server identity which is used to 
determine if it's Plasma or not. The process name isn't used as you could have 
a notifications widget in e.g. Latte Dock.

TEST PLAN
  Actually the notification service isn't running/registered but from a user's 
POV they might just not have a notification widget.
  F7703382: Screenshot_20191031_174724.png 

  Service owned by someone else
  F7703383: Screenshot_20191031_174732.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

AFFECTED FILES
  kcms/notifications/CMakeLists.txt
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25096: [Digital Clock] Disable custom format input when date option is unchecked

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The `ComboBox` was disabled in this case but not the other options.

TEST PLAN
  F7703371: Screenshot_20191031_174304.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25096

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Marco Martin]

mart added a comment.


  In D22359#536077 , @ndavis wrote:
  
  > In D22359#536055 , @ngraham 
wrote:
  >
  > > Is there any way we can preserve the original goal of using a monochrome 
icon here for small sizes?
  >
  >
  > Maybe we could add an option to force a specific icon size. It would be 
literally the only option in the widget, but it would do the job and we could 
set a monochrome icon size by default. These applets should probably still get 
refactored some day though.
  >
  > It seems like setting specific sizes for specific widgets should be a 
feature of the panel editing mode though. That way people could set any size 
for any widget. I don't think our current way of allowing users to set the 
global panel icon size is very discoverable and it's quite limiting.
  
  
  I hope it doesn't come to that, add an option is a very KDE3 solution.
  that icon kinda needs to be smaller when it's placed in its intended default 
position.
  perhaps not when is somewhere else, i don't know
  
  but this revert makes the default just appear... broken

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma, davidedmundson
Cc: mart, KonqiDragon, ngraham, davidedmundson, filipf, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 196 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/196/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 15:38:53 +
 Build duration:
2 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 3196 lines...][2019-10-31T15:40:50.389Z] [ 45%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/previewwidget.cpp.o[2019-10-31T15:40:50.389Z] [ 45%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/stylesmodel.cpp.o[2019-10-31T15:40:50.389Z] [ 45%] Built target kcm_standard_actions[2019-10-31T15:40:50.389Z] [ 45%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/previewitem.cpp.o[2019-10-31T15:40:50.671Z] 13 warnings generated.[2019-10-31T15:40:50.941Z] [ 45%] Generating ui_select_scheme_dialog.h[2019-10-31T15:40:50.941Z] [ 45%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyboardlayout.cpp.o[2019-10-31T15:40:50.941Z] [ 45%] Generating kglobalaccel_interface.cpp, kglobalaccel_interface.h[2019-10-31T15:40:50.941Z] [ 45%] Generating kglobalaccel_component_interface.cpp, kglobalaccel_component_interface.h[2019-10-31T15:40:50.941Z] [ 46%] Generating ui_export_scheme_dialog.h[2019-10-31T15:40:50.941Z] [ 46%] Generating ui_kglobalshortcutseditor.h[2019-10-31T15:40:50.941Z] [ 46%] Generating ui_select_application.h[2019-10-31T15:40:50.941Z] [ 46%] Generating kglobalaccel_interface.moc[2019-10-31T15:40:50.941Z] [ 46%] Generating kglobalaccel_component_interface.moc[2019-10-31T15:40:51.213Z] Scanning dependencies of target kcm_keys[2019-10-31T15:40:51.213Z] [ 46%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kcm_keys_autogen/mocs_compilation.cpp.o[2019-10-31T15:40:51.470Z] [ 47%] Linking CXX shared module ../../bin/kcm_colors.so[2019-10-31T15:40:51.737Z] [ 47%] Built target kcm_colors[2019-10-31T15:40:51.737Z] [ 47%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/symbol_parser.cpp.o[2019-10-31T15:40:51.737Z] [ 47%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/setpreviewwidget.cpp.o[2019-10-31T15:40:51.737Z] [ 47%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalshortcutseditor.cpp.o[2019-10-31T15:40:51.737Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/desktoptheme/kcm.cpp:119:5: error: use of undeclared identifier 'settingsChanged'; did you mean 'buttonsChanged'?[2019-10-31T15:40:51.737Z] settingsChanged();[2019-10-31T15:40:51.737Z] ^~~[2019-10-31T15:40:51.737Z] buttonsChanged[2019-10-31T15:40:51.737Z] /usr/home/jenkins/install-prefix/include/KF5/KDeclarative/kquickaddons/configmodule.h:498:10: note: 'buttonsChanged' declared here[2019-10-31T15:40:51.737Z] void buttonsChanged();[2019-10-31T15:40:51.737Z]  ^[2019-10-31T15:40:51.737Z] [ 47%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/globalshortcuts.cpp.o[2019-10-31T15:40:52.314Z] 1 error generated.[2019-10-31T15:40:52.314Z] gmake[2]: *** [kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/build.make:88: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm.cpp.o] Error 1[2019-10-31T15:40:52.314Z] gmake[1]: *** [CMakeFiles/Makefile2:6081: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/all] Error 2[2019-10-31T15:40:52.314Z] gmake[1]: *** Waiting for unfinished jobs[2019-10-31T15:40:52.314Z] [ 47%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyaliases.cpp.o[2019-10-31T15:40:52.571Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/klauncher_iface.cpp.o[2019-10-31T15:40:52.571Z] [ 48%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/select_scheme_dialog.cpp.o[2019-10-31T15:40:52.837Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keys/kglobalshortcutseditor.cpp:21:[2019-10-31T15:40:52.837Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/kcms/keys/ui_select_application.h:40:38: warning: 'KFilterProxySearchLine' is deprecated: Since 5.50. See class API docs [-Wdeprecated-declarations][2019-10-31T15:40:52.837Z] kfilterproxysearchline = new KFilterProxySearchLine(SelectApplicationDialog);[2019-10-31T15:40:52.837Z]  ^[2019-10-31T15:40:52.837Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kfilterproxysearchline.h:57:5: note: 'KFilterProxySearchLine' has been explicitly marked deprecated here[2019-10-31T15:40:52.837Z] KITEMVIEWS_DEPRECATED_VERSION(5, 50, "See class API docs")[2019-10-31T15:40:52.837Z] ^[2019-10-31T15:40:52.837Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kitemviews_export.h:138:59: note: expanded from macro 'KITEMVIEWS_DEPRECATED_VERSION'[2019-10-31T15:40:52.837Z] #define KITEMVIEWS_DEPRECATED_VERSION(major, minor, text) KITEMVIEWS_DEPRECATED_VERSION_##major(minor, "Since "#major"."#minor". " text)[2019-10-31T15:40:52.837Z] 

D25094: Fix reset to defaults in the fonts KCM

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7b0149c79ea4: Fix reset to defaults in the fonts KCM 
(authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25094?vs=69118=69119

REVISION DETAIL
  https://phabricator.kde.org/D25094

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ervin, #plasma, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25094: Fix reset to defaults in the fonts KCM

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, bport, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Turns out one of the properties was utterly broken emitting the wrong
  signal, and the defaults() method was missing a piece of state to reset.
  
  Since it was making my eyes bleed I also removed the "const int &"
  parameters in the process. :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25094

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ervin, #plasma, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25091: [Digital Clock] Add preview for date format

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6671c13d4cb6: [Digital Clock] Add preview for date format 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25091?vs=69104=69117

REVISION DETAIL
  https://phabricator.kde.org/D25091

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25019: Ensure that GlobalDrawer topContent always stays on top

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> ahiemstra wrote in GlobalDrawer.qml:370
> We **really** should fix scrollview's scrollbars...

See https://phabricator.kde.org/T9126.

I *really* dislike overlay scrollbars, both in terms of utility and also 
because of the horrible code hacks required to make them work properly.

Material for another patch though.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25019

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25019: Ensure that GlobalDrawer topContent always stays on top

[Nathaniel Graham]

ngraham updated this revision to Diff 69116.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25019?vs=68920=69116

BRANCH
  topContent-always-on-top (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25019

AFFECTED FILES
  src/controls/GlobalDrawer.qml

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 195 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/195/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 15:02:42 +
 Build duration:
2 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 3208 lines...][2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T15:04:42.232Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T15:04:42.232Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T15:04:42.232Z]   ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T15:04:42.232Z]^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:295:24: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T15:04:42.232Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T15:04:42.232Z]^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T15:04:42.232Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T15:04:42.232Z]   ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T15:04:42.232Z]^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:295:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T15:04:42.232Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T15:04:42.232Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T15:04:42.232Z]^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T15:04:42.232Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T15:04:42.232Z]  ^[2019-10-31T15:04:42.232Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:295:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T15:04:42.232Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T15:04:42.232Z]^[2019-10-31T15:04:42.232Z] 

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:69d649e5aab4: [containments/desktop] Delete the 
Tweaks page and its options (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25055?vs=68997=69115

REVISION DETAIL
  https://phabricator.kde.org/D25055

AFFECTED FILES
  containments/desktop/package/contents/config/config.qml
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigTweaks.qml
  containments/desktop/package/contents/ui/main.qml

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  Thanks for your flexibility, @mart. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  delete-tweaks-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25093: ksmserver: remove unused explicit dependency to Phonon

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ae130775e865: ksmserver: remove unused explicit 
dependency to Phonon (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25093?vs=69109=69113

REVISION DETAIL
  https://phabricator.kde.org/D25093

AFFECTED FILES
  ksmserver/CMakeLists.txt

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24945: [ksmserver] Signal session management state to kwin directly

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> logout.cpp:194
> +
> +auto reply = m_kwinInterface->setState(KWinSessionState::Saving);
> +// we don't need to block as we wait for kwin to handle it's session 1

`reply` isn't actually used, remove?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24945

To: davidedmundson, #kwin
Cc: broulik, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24945: [ksmserver] Signal session management state to kwin directly

[David Edmundson]

davidedmundson updated this revision to Diff 69112.
davidedmundson added a comment.


  Update to enum

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24945?vs=69111=69112

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24945

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/org.kde.KWin.Session.xml
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #kwin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24945: [ksmserver] Signal session management state to kwin directly

[David Edmundson]

davidedmundson updated this revision to Diff 69111.
davidedmundson added a comment.


  update to enum

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24945?vs=68751=69111

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24945

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/org.kde.KWin.Session.xml
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #kwin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25093: ksmserver: remove unused explicit dependency to Phonon

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25093

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 194 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/194/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 14:18:24 +
 Build duration:
2 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 3460 lines...][2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T14:21:12.782Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T14:21:12.782Z]   ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T14:21:12.782Z]  ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T14:21:12.782Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T14:21:12.782Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T14:21:12.782Z]   ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T14:21:12.782Z]  ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T14:21:12.782Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T14:21:12.782Z]  ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T14:21:12.782Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T14:21:12.782Z]  ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T14:21:12.782Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T14:21:12.782Z]^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T14:21:12.782Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T14:21:12.782Z]   ^[2019-10-31T14:21:12.782Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T14:21:12.782Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T14:21:12.782Z]  

D24701: Notify about change after cursor config is saved

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cf7254a70f01: Notify about change after cursor config is 
saved (authored by gikari, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24701?vs=68060=69110

REVISION DETAIL
  https://phabricator.kde.org/D24701

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp

To: gikari, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Fabian Riethmayer]

fabianr added a comment.


  I would
  
  In D25055#557216 , @hein wrote:
  
  > If we want to keep the handles-on-hover outside of Edit Mode, is there a 
reason it can't be always on and needs to be gated behind a checkbox?
  >
  > I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?
  
  
  +1
  And long hover is not something that would work with touch devices or is 
common in plasma or other environments, so I don't see a point in introducing a 
new usage pattern, that looks to me quiet cumbersome and problematic.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  In D25055#557216 , @hein wrote:
  
  > I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?
  
  
  Exactly my thoughts.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25093: ksmserver: remove unused explicit dependency to Phonon

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It may be used through KNotifications

TEST PLAN
  Builds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25093

AFFECTED FILES
  ksmserver/CMakeLists.txt

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Eike Hein]

hein added a comment.


  If we want to keep the handles-on-hover outside of Edit Mode, is there a 
reason it can't be always on and needs to be gated behind a checkbox?
  
  I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> globalaccel.cpp:50
> +
> +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString )
> +{

I think the list that is returned can have up to 2 entries. The shortcut and 
the alternate shortcut. However the currently Gui shows/configures only one 
shortcut.

> globalaccel.h:27
> +public:
> +static QKeySequence getMenuEntryShortcut(const QString );
> +static void changeMenuEntryShortcut(const QString , const 
> QKeySequence );

I just used the old names.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  Ahh, I wasn't hovering for long enough. I see it now.
  
  After finally understanding and using this feature, I really think we should 
discard it. Actually explaining it in the UI in a way that would make it 
comprehensible would require an incredibly wordy checkbox like
  
[] Show widget handles when hovering over widgets for a few seconds while 
outside of edit mode
  
  Also, what does it really gain us? "Long hover" is no faster than "long 
press" and less intuitive. I don't really see the gain.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> globalaccel.cpp:50
> +
> +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString )
> +{

Why just return one if it can be a list?

> globalaccel.h:27
> +public:
> +static QKeySequence getMenuEntryShortcut(const QString );
> +static void changeMenuEntryShortcut(const QString , const 
> QKeySequence );

I'd call them `menuEntryShortcut` and `setMenuEntryShortcut`

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 193 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/193/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 13:16:16 +
 Build duration:
3 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 3197 lines...][2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T13:19:46.549Z]^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T13:19:46.549Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T13:19:46.549Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T13:19:46.549Z]   ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T13:19:46.549Z]^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:295:24: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T13:19:46.549Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T13:19:46.549Z]^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T13:19:46.549Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T13:19:46.549Z]   ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T13:19:46.549Z]^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:295:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T13:19:46.549Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T13:19:46.549Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T13:19:46.549Z]^[2019-10-31T13:19:46.549Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T13:19:46.549Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T13:19:46.549Z]  ^[2019-10-31T13:19:46.549Z] 

D25019: Ensure that GlobalDrawer topContent always stays on top

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> GlobalDrawer.qml:241
>  
> -rightPadding: !Settings.isMobile && mainFlickable.contentHeight > 
> mainFlickable.height ? Units.gridUnit : Units.smallSpacing
> +leftPadding: 0
> +rightPadding: 0

+1 for getting rid of these paddings.

> GlobalDrawer.qml:252
> +id: topContent
> +spacing: 50
> +Layout.alignment: Qt.AlignHCenter

Uhm, what's this value?

> GlobalDrawer.qml:260
> +visible: children.length > 0 && childrenRect.height > 0 && 
> opacity > 0
> +opacity: !root.collapsed || showTopContentWhenCollapsed
> +Behavior on opacity {

In my opinion, it is nicer to be explicit about types instead of relying on 
implicit conversion. So this should be `(!root.collapsed || 
showTopContentWhenCollapsed) ? 1 : 0`.

> GlobalDrawer.qml:370
> +Layout.fillWidth: true
> +Layout.rightMargin: !Settings.isMobile && 
> mainFlickable.contentHeight > mainFlickable.height ? Units.gridUnit : 0
> +Layout.minimumHeight: currentItem ? 
> currentItem.implicitHeight : 0

We **really** should fix scrollview's scrollbars...

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25019

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25045: kimpanel: don't crash when ibus is already loaded

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:299f298d168f: kimpanel: dont crash when ibus is 
already loaded (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25045?vs=68980=69108

REVISION DETAIL
  https://phabricator.kde.org/D25045

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: apol, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre updated this revision to Diff 69107.
davidre marked 4 inline comments as done.
davidre added a comment.


  - comments

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69105=69107

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> globalaccel.cpp:55
> +const QList shortcut = 
> KGlobalAccel::self()->globalShortcut(desktopFile, QStringLiteral("_launch"));
> +if (shortcut.size() > 0) {
> +return shortcut[0];

if (!shortcut.isEmpty()) {

> menuinfo.cpp:180
>  if (s_deletedApps) {
>  #ifdef WITH_HOTKEYS
>  // Remove hotkeys for applications that have been deleted

you can remove this ifdef

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:39
> Why removing it ?

Accidentally

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre updated this revision to Diff 69105.
davidre added a comment.


  - Don't delete disabled
  - Remove guards

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69095=69105

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25091: [Digital Clock] Add preview for date format

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Especially for the custom one it's useful to have a live preview rather than 
trial and error with the Apply button.

TEST PLAN
  F7702259: Screenshot_20191031_135004.png 

  F7702261: Screenshot_20191031_135215.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25091

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25090: kcm/fonts: Do not load image preview before loading settings

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  The way image preview works is it tries to actually "set" and then
  "reset" the original value to render the text.
  
  However if we don't have default or user set settings loaded, it will
  reset it back to "NotSet" in end instead of user set value and this is
  not what we want.

TEST PLAN
  this alone is not enough to make kcm save subpixel properly
  but this is part of patch series

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bshah/fonts

REVISION DETAIL
  https://phabricator.kde.org/D25090

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

[Méven Car]

meven added a comment.


  In D25089#557130 , @davidedmundson 
wrote:
  
  > Can you tell me which .desktops files are going to be using this flag, I 
don't think I follow so far.
  
  
  The ones installed in `${DATA_INSTALL_DIR}/kglobalaccel` for the need of 
disabling component shortcuts.
  D25088  has details

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25089

To: meven, #plasma, apol, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> CMakeLists.txt:39
> -find_package(KHotKeysDBusInterface QUIET)
> -if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
> -   add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)

Why removing it ?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

[David Edmundson]

davidedmundson added a comment.


  Can you tell me which .desktops files are going to be using this flag, I 
don't think I follow so far.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25089

To: meven, #plasma, apol, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 192 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/192/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 11:52:42 +
 Build duration:
1 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 3535 lines...][2019-10-31T11:54:27.060Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T11:54:27.060Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T11:54:27.060Z]^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T11:54:27.060Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T11:54:27.060Z]   ^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T11:54:27.060Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T11:54:27.060Z]^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T11:54:27.060Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T11:54:27.060Z]  ^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T11:54:27.060Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T11:54:27.060Z]  ^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T11:54:27.060Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T11:54:27.060Z]^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T11:54:27.060Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T11:54:27.060Z]  ^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:526:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T11:54:27.060Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-31T11:54:27.060Z]^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T11:54:27.060Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T11:54:27.060Z]   ^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T11:54:27.060Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T11:54:27.060Z]^[2019-10-31T11:54:27.060Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T11:54:27.060Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T11:54:27.060Z]  ^[2019-10-31T11:54:27.060Z] [ 56%] Linking CXX shared module ../../bin/kcm_smserver.so[2019-10-31T11:54:27.338Z] [ 56%] Built target kcm_smserver[2019-10-31T11:54:27.338Z] [ 56%] Building CXX object kcms/lookandfeel/CMakeFiles/lookandfeeltool.dir/__/krdb/krdb.cpp.o[2019-10-31T11:54:27.596Z] [ 56%] Building CXX object kcms/lookandfeel/CMakeFiles/lookandfeeltool.dir/__/cursortheme/xcursor/cursortheme.cpp.o[2019-10-31T11:54:27.596Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/krdb/krdb.cpp:93:33: warning: unused parameter 'active' [-Wunused-parameter][2019-10-31T11:54:27.596Z] static void applyGtkStyles(bool active, int version)[2019-10-31T11:54:27.596Z] ^[2019-10-31T11:54:27.596Z] 9 

D25081: [kcms/krdb] Fix krdb executable

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3a6dc8c07617: [kcms/krdb] Fix krdb executable (authored 
by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25081?vs=69068=69100

REVISION DETAIL
  https://phabricator.kde.org/D25081

AFFECTED FILES
  kcms/krdb/ad/krdb

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, apol, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  A Drawback with the current patch is that it will loose previous set 
preferences.
  
  See D25088  for details

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25089

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: meven, #plasma, apol, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25048: Expose libkworkspace SessionManagement class to QML

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fb5f9bd1012c: Expose libkworkspace SessionManagement 
class to QML (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25048?vs=68983=69098

REVISION DETAIL
  https://phabricator.kde.org/D25048

AFFECTED FILES
  components/sessionsprivate/sessionsprivateplugin.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

[David Edmundson]

davidedmundson added a comment.


  Concept 
  
  We don't need WITH_GLOBALACCEL guards. It's a dep of kxmlgui which we link 
against anyway.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 191 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/191/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 10:44:56 +
 Build duration:
3 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 3196 lines...][2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:24: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T10:48:22.462Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:48:22.462Z]^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T10:48:22.462Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T10:48:22.462Z]   ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T10:48:22.462Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T10:48:22.462Z]^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:48:22.462Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T10:48:22.462Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T10:48:22.462Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T10:48:22.462Z]^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:48:22.462Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T10:48:22.462Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:48:22.462Z]^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T10:48:22.462Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T10:48:22.462Z]   ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T10:48:22.462Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T10:48:22.462Z]^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:48:22.462Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T10:48:22.462Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:48:22.462Z]  ^[2019-10-31T10:48:22.462Z] 

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Replace KHotkeys with KGlobalAccel
  WIP because of missing migration

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24848: fix kcm fonts "typo" on connect

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:08a8914d7169: fix kcm fonts typo on connect 
(authored by bport, committed by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24848?vs=68500=69094

REVISION DETAIL
  https://phabricator.kde.org/D24848

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, mart, ervin, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:35fae4b55fc8: Do not assign combobox currentIndex as it 
breaks binding. (authored by crossi).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25000?vs=69055=69093

REVISION DETAIL
  https://phabricator.kde.org/D25000

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  plugin/CMakeLists.txt
  plugin/kpropertywriter.cpp
  plugin/kpropertywriter_p.h
  plugin/qqc2desktopstyleplugin.cpp

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556797 , @ngraham wrote:
  
  > In D25055#556755 , @mart wrote:
  >
  > > In D25055#556752 , @ngraham 
wrote:
  > >
  > > > In D25055#556751 , @mart 
wrote:
  > > >
  > > > > I would prefer keeping the press to move stuff
  > > >
  > > >
  > > > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  > >
  > >
  > > it makes the handles appear on mouse over, like they did in kde4, i spent 
a lot of time to make that work in the new layout
  >
  >
  > Can you be specific about how the behavior gets invoked? For me, when not 
in edit mode, the handles now always appear on hover, while outside of edit 
mode, the handles now only appear on press-and-hold. None of this changes 
regardless of whether or not the press-and-hold setting in Tweaks is checked.
  
  
  here they do appear on hover and delay

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 190 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/190/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 10:02:26 +
 Build duration:
3 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 3154 lines...][2019-10-31T10:05:39.408Z]^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T10:05:39.408Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T10:05:39.408Z]   ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T10:05:39.408Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T10:05:39.408Z]^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:05:39.408Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:05:39.408Z]  ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T10:05:39.408Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:05:39.408Z]  ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T10:05:39.408Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T10:05:39.408Z]^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:05:39.408Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:05:39.408Z]  ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T10:05:39.408Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:05:39.408Z]^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T10:05:39.408Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T10:05:39.408Z]   ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T10:05:39.408Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T10:05:39.408Z]^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T10:05:39.408Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T10:05:39.408Z]  ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:292:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T10:05:39.408Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-31T10:05:39.408Z]  ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T10:05:39.408Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T10:05:39.408Z]   ^[2019-10-31T10:05:39.408Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 

D24917: KCM Style port to KConfigXT

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fbed4b3efcdb: KCM Style port to KConfigXT (authored by 
crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24917?vs=68978=69089

REVISION DETAIL
  https://phabricator.kde.org/D24917

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/stylesettings.kcfg
  kcms/style/stylesettings.kcfgc

To: crossi, ervin, mart, bport, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24925: KCM KSplash port to ManagedConfigModule

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:332226003b04: KCM KSplash port to ManagedConfigModule 
(authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24925?vs=68734=69090

REVISION DETAIL
  https://phabricator.kde.org/D24925

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h

To: crossi, #plasma, ervin, mart, bport, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24916: KCM style : fix combobox that weren't updated after user made change

[Cyril Rossi]

crossi abandoned this revision.
crossi added a comment.


  Fix by D25000 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24916

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:9313c877f55f: Fix issue when there is no WidgetStyle 
value in kdeglobals (authored by crossi).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24918?vs=68672=69088

REVISION DETAIL
  https://phabricator.kde.org/D24918

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: crossi, #plasma, ervin, bport, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/55/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 09:17:01 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 189 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/189/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 09:17:01 +
 Build duration:
3 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 3194 lines...][2019-10-31T09:19:56.430Z]^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T09:19:56.430Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T09:19:56.430Z]   ^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T09:19:56.430Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T09:19:56.430Z]^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T09:19:56.430Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T09:19:56.430Z]  ^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:340:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T09:19:56.430Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T09:19:56.430Z]  ^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T09:19:56.430Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T09:19:56.430Z]^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T09:19:56.430Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T09:19:56.430Z]  ^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:340:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T09:19:56.430Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-31T09:19:56.430Z]^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T09:19:56.430Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T09:19:56.430Z]   ^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T09:19:56.430Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T09:19:56.430Z]^[2019-10-31T09:19:56.430Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T09:19:56.430Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T09:19:56.430Z]  ^[2019-10-31T09:19:56.689Z] [ 55%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalshortcutseditor.cpp.o[2019-10-31T09:19:56.689Z] [ 55%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyboardpainter.cpp.o[2019-10-31T09:19:56.969Z] [ 55%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/previewitem.cpp.o[2019-10-31T09:19:56.969Z] [ 55%] Built target kcolorschemeeditor[2019-10-31T09:19:56.969Z] [ 55%] Built target kcm_standard_actions[2019-10-31T09:19:56.969Z] [ 56%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysymhelper.cpp.o[2019-10-31T09:19:56.969Z] [ 56%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/klauncher_iface.cpp.o[2019-10-31T09:19:57.265Z] 13 warnings generated.[2019-10-31T09:19:57.265Z] [ 56%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysym2ucs.cpp.o[2019-10-31T09:19:57.869Z] [ 56%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/debug.cpp.o[2019-10-31T09:19:58.129Z] In file 

D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:59e3003943da: [Night Color KCM] Reset seconds and 
milliseconds in provided timings (authored by zzag).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25047?vs=68982=69087

REVISION DETAIL
  https://phabricator.kde.org/D25047

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimeField.qml

To: zzag, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kpropertywriter_p.h:26
> Throwing out another option
> 
>   class KPropertyWriter : public QObject, public QQmlPropertyValueSource
>   {
>   Q_INVOKABLE bool writeProperty(QVariant value);
>   }
>   
>   writeProperty(QVariant) {
> object()->setProperty(name(), value());
> // we can't use property().write() as that'll break the binding
>   }
>   
>   
>   PropertyWriter on currentIndex {
>  id: controlRootWriter
>   }
> 
> Though it's basically the same thing, so don't feel you have to, just wanted 
> to share the suggestion as it reduces two properties.

Thank you for sharing other option, I didn't know this one.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace-wallpapers » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace-wallpapers/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 04:35:48 +
 Build duration:
2 hr 32 min and counting
   CONSOLE OUTPUT
  [...truncated 85 lines...]remote: Compressing objects:  46% (1257/2690)   remote: Compressing objects:  46% (1260/2690)   remote: Compressing objects:  47% (1265/2690)   remote: Compressing objects:  47% (1272/2690)   remote: Compressing objects:  48% (1292/2690)   remote: Compressing objects:  49% (1319/2690)   remote: Compressing objects:  50% (1345/2690)   remote: Compressing objects:  51% (1372/2690)   remote: Compressing objects:  52% (1399/2690)   remote: Compressing objects:  53% (1426/2690)   remote: Compressing objects:  54% (1453/2690)   remote: Compressing objects:  55% (1480/2690)   remote: Compressing objects:  56% (1507/2690)   remote: Compressing objects:  57% (1534/2690)   remote: Compressing objects:  58% (1561/2690)   remote: Compressing objects:  59% (1588/2690)   remote: Compressing objects:  60% (1614/2690)   remote: Compressing objects:  61% (1641/2690)   remote: Compressing objects:  62% (1668/2690)   remote: Compressing objects:  63% (1695/2690)   remote: Compressing objects:  64% (1722/2690)   remote: Compressing objects:  65% (1749/2690)   remote: Compressing objects:  66% (1776/2690)   remote: Compressing objects:  67% (1803/2690)   remote: Compressing objects:  68% (1830/2690)   remote: Compressing objects:  69% (1857/2690)   remote: Compressing objects:  70% (1883/2690)   remote: Compressing objects:  71% (1910/2690)   remote: Compressing objects:  72% (1937/2690)   remote: Compressing objects:  73% (1964/2690)   remote: Compressing objects:  74% (1991/2690)   remote: Compressing objects:  75% (2018/2690)   remote: Compressing objects:  76% (2045/2690)   remote: Compressing objects:  77% (2072/2690)   remote: Compressing objects:  78% (2099/2690)   remote: Compressing objects:  79% (2126/2690)   remote: Compressing objects:  80% (2152/2690)   remote: Compressing objects:  81% (2179/2690)   remote: Compressing objects:  82% (2206/2690)   remote: Compressing objects:  83% (2233/2690)   remote: Compressing objects:  84% (2260/2690)   remote: Compressing objects:  85% (2287/2690)   remote: Compressing objects:  86% (2314/2690)   remote: Compressing objects:  87% (2341/2690)   remote: Compressing objects:  88% (2368/2690)   remote: Compressing objects:  89% (2395/2690)   remote: Compressing objects:  90% (2421/2690)   remote: Compressing objects:  91% (2448/2690)   remote: Compressing objects:  92% (2475/2690)   remote: Compressing objects:  93% (2502/2690)   remote: Compressing objects:  94% (2529/2690)   remote: Compressing objects:  95% (2556/2690)   remote: Compressing objects:  96% (2583/2690)   remote: Compressing objects:  97% (2610/2690)   remote: Compressing objects:  98% (2637/2690)   remote: Compressing objects:  99% (2664/2690)   remote: Compressing objects: 100% (2690/2690)   remote: Compressing objects: 100% (2690/2690), done.[2019-10-31T07:07:51.167Z] [2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-10-31T07:07:51.167Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-10-31T07:07:51.167Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2019-10-31T07:07:51.167Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-10-31T07:07:51.167Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2019-10-31T07:07:51.167Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2019-10-31T07:07:51.167Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-31T07:07:51.167Z] 	at