D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  I'll abandon this and see how starting my own theme goes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Nathaniel Graham]

ngraham added a comment.


  I have also been thinking that we might want to do the proposed "Breeze theme 
evolution" in a new theme (perhaps even just forked from Breeze) so that people 
people who like Breeze can keep it, and we can wipe the slate clean and have 
more design freedom.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis added a comment.


  In D25543#568160 , 
@hpereiradacosta wrote:
  
  > Also (and somewhat independently from this patch): with Qt6/KF6 being 
around the corner, I somewhat wonder about the utility of rewritting and 
hacking breeze at that time. Would this make sense to actually leave breeze 
(which is a rather well-working theme, with very little bug reports) unchanged, 
and start working anew on a new widget style targeting KF6 ? Would that not be 
more exciting, bring more people in, trigger new ideas, give more freedom ? And 
be a more ambitious task all in all ?  
  >  One could of course start from breeze, and apply all the new ideas about 
how the code should be organized, how highlight should look, and checkboxes, 
without disturbance for something which has lived largely unchanged (and with 
not so many complains) for all the kf5 lifetime ...
  >
  > My two cents.
  
  
  That's a fair point. I have thought a little bit about trying to start my own 
widget style and it would be easier to patch it a piece at a time instead of 
trying to do it all at once to prevent inconsistency between releases.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Also, this change will make it pretty difficult to use git blame and git 
bisect in the future to track possible regressions. (to my knowledge at least). 
Might as well start a new repository.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis added a comment.


  In D25543#568159 , 
@hpereiradacosta wrote:
  
  > You are missing copyright information and license in all the newly created 
files.
  
  
  Thanks, should I just copy/paste the info from breezestyle.cpp?
  
  > On the review side: it is impossible to actually review, right ?
  
  I was kind of worried that might be the case.
  
  > As for the conceptual side: I fear this is addressing a non existing issue, 
and giving a wrong impression about how one should hack on a widget style. It 
is wrong to think that you can hack on a widget style widget by widget without 
consideration about how they should appear one with respect to the others, how 
they should align one with respect to the other, and how the other widgets are 
implemented. You do need to know the whole code and interplay before starting 
to hack anyway. The splitting does not change this. In the end it might just 
result in a lot of duplicated code.
  
  I have seen others in the VDG chat room say that the massive length of 
breezestyle.cpp made hacking on Breeze too intimidating. I understand your 
concern about giving the wrong impression though. I'm hoping to use these new 
files as a way of categorizing by visible widget types ("Where is the code for 
tabs? In tabbar.cpp", not exact Qt Widget classes. There's still nothing 
stopping others from reusing code from one widget category in another since all 
the functions are still defined in breezehelper.h and breezestyle.h.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Also (and somewhat independently from this patch): with Qt6/KF6 being around 
the corner, I somewhat wonder about the utility of rewritting and hacking 
breeze at that time. Would this make sense to actually leave breeze (which is a 
rather well-working theme, with very little bug reports) unchanged, and start 
working anew on a new widget style targeting KF6 ? Would that not be more 
exciting, bring more people in, trigger new ideas, give more freedom ? And be a 
more ambitious task all in all ?  
  One could of course start from breeze, and apply all the new ideas about how 
the code should be organized, how highlight should look, and checkboxes, 
without disturbance for something which has lived largely unchanged (and with 
not so many complains) for all the kf5 lifetime ...
  
  My two cents.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  You are missing copyright information and license in all the newly created 
files. 
  On the review side: it is impossible to actually review, right ? 
  As for the conceptual side: I fear this is addressing a non existing issue, 
and giving a wrong impression about how one should hack on a widget style. It 
is wrong to think that you can hack on a widget style widget by widget without 
consideration about how they should appear one with respect to the others, how 
they should align one with respect to the other, and how the other widgets are 
implemented. You do need to know the whole code and interplay before starting 
to hack anyway. The splitting does not change this. In the end it might just 
result in a lot of duplicated code.
  
  Anyway. I wont prevent you for pushing this. Who does the job decides. This 
probably marks the end of my contributions to breeze though, but they have not 
been that many lately anyway.
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu marked 2 inline comments as done.
liushuyu added a comment.


  Now it looks like this
  F7785973: image.png 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu marked 2 inline comments as done.
liushuyu added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:32
> Doesn't seem to be used; the timer duration is hardcoded on the C++ side

Now, it's used by the Timer

> ngraham wrote in main.qml:110
> I would change these to `StandardButton.Apply` and `StandardButton.Discard`

Now InlineMessage is used

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu updated this revision to Diff 70390.
liushuyu added a comment.


  Use InlineMessage instead of MessageBox and move the timer to the QML portion

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25539?vs=70329=70390

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25539

AFFECTED FILES
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/package/contents/ui/main.qml

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25509: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c96809b1dac2: [applets/Weather] Port config UI mostly to 
QQC2 and away from Plasma components (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25509?vs=70265=70385

REVISION DETAIL
  https://phabricator.kde.org/D25509

AFFECTED FILES
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml
  applets/weather/package/contents/ui/config/WeatherStationPickerDialog.qml

To: ngraham, spstarr, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25509: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components

[Shawn Starr]

spstarr added a comment.


  For the applet side, I didn't rewrite this, the original applet was 
non-QtQuick even, but even so, this looks sane to me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25509

To: ngraham, spstarr, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis updated this revision to Diff 70384.
ndavis added a comment.


  - Actually rename all occurrences of combobox.h and tabbar.h

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25543?vs=70382=70384

BRANCH
  ndavis/kstyle-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25543

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/widgets/checkbox.cpp
  kstyle/widgets/combobox.cpp
  kstyle/widgets/combobox_p.h
  kstyle/widgets/dial.cpp
  kstyle/widgets/dockwidget.cpp
  kstyle/widgets/groupbox.cpp
  kstyle/widgets/header.cpp
  kstyle/widgets/itemview.cpp
  kstyle/widgets/linedit.cpp
  kstyle/widgets/mdi.cpp
  kstyle/widgets/menu.cpp
  kstyle/widgets/menubar.cpp
  kstyle/widgets/progressbar.cpp
  kstyle/widgets/pushbutton.cpp
  kstyle/widgets/radiobutton.cpp
  kstyle/widgets/scrollbar.cpp
  kstyle/widgets/slider.cpp
  kstyle/widgets/spinbox.cpp
  kstyle/widgets/tabbar.cpp
  kstyle/widgets/tabbar_p.h
  kstyle/widgets/toolbar.cpp
  kstyle/widgets/toolbox.cpp
  kstyle/widgets/toolbutton.cpp

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis updated this revision to Diff 70382.
ndavis added a comment.


  - Rename combobox.h and tabbar.h to be like private headers
  
  They use the BreezePrivate namespace, so it seemed appropriate.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25543?vs=70380=70382

BRANCH
  ndavis/kstyle-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25543

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/widgets/checkbox.cpp
  kstyle/widgets/combobox.cpp
  kstyle/widgets/combobox_p.h
  kstyle/widgets/dial.cpp
  kstyle/widgets/dockwidget.cpp
  kstyle/widgets/groupbox.cpp
  kstyle/widgets/header.cpp
  kstyle/widgets/itemview.cpp
  kstyle/widgets/linedit.cpp
  kstyle/widgets/mdi.cpp
  kstyle/widgets/menu.cpp
  kstyle/widgets/menubar.cpp
  kstyle/widgets/progressbar.cpp
  kstyle/widgets/pushbutton.cpp
  kstyle/widgets/radiobutton.cpp
  kstyle/widgets/scrollbar.cpp
  kstyle/widgets/slider.cpp
  kstyle/widgets/spinbox.cpp
  kstyle/widgets/tabbar.cpp
  kstyle/widgets/tabbar_p.h
  kstyle/widgets/toolbar.cpp
  kstyle/widgets/toolbox.cpp
  kstyle/widgets/toolbutton.cpp

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Nathaniel Graham]

ngraham added a comment.


  Ah whoops, I missed the huge `kstyle/breezestyle.cpp` diff because it was 
collapsed.
  
  Conceptually this makes sense to me and I can spot no visual regressions 
resulting from it. No formal acceptance from me yet because I feel like this 
requires more eyes, and we should probably keep it open for a while to make 
sure everything has gotten moved properly.
  
  Great work though! I think this will really make it easier to contribute to 
Breeze.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis added a comment.


  I plan to do the existing files in another patch

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis updated this revision to Diff 70380.
ndavis added a comment.


  - Move renderSidePanelFrame and renderSelection into itemview.cpp
  - Move renderDecorationButton into mdi.cpp

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25543?vs=70339=70380

BRANCH
  ndavis/kstyle-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25543

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/widgets/checkbox.cpp
  kstyle/widgets/combobox.cpp
  kstyle/widgets/combobox.h
  kstyle/widgets/dial.cpp
  kstyle/widgets/dockwidget.cpp
  kstyle/widgets/groupbox.cpp
  kstyle/widgets/header.cpp
  kstyle/widgets/itemview.cpp
  kstyle/widgets/linedit.cpp
  kstyle/widgets/mdi.cpp
  kstyle/widgets/menu.cpp
  kstyle/widgets/menubar.cpp
  kstyle/widgets/progressbar.cpp
  kstyle/widgets/pushbutton.cpp
  kstyle/widgets/radiobutton.cpp
  kstyle/widgets/scrollbar.cpp
  kstyle/widgets/slider.cpp
  kstyle/widgets/spinbox.cpp
  kstyle/widgets/tabbar.cpp
  kstyle/widgets/tabbar.h
  kstyle/widgets/toolbar.cpp
  kstyle/widgets/toolbox.cpp
  kstyle/widgets/toolbutton.cpp

To: ndavis, #plasma, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis added a comment.


  In D25543#567838 , @ngraham wrote:
  
  > Very nice, I applaud the goal. However it looks like on net a lot more 
lines of code were added than were removed, which suggests the addition of 
redundant boilerplate or unrelated style refactoring. In the former case, can 
we factor out some of it into additional helper functions?
  
  
  I didn't add any new lines of code, I just moved them into other files. I did 
format the new files in `widgets/`, but not the existing files.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: KScreen KCM: Add a revert timer to the settings page

[Roman Gilg]

romangg added a comment.


  Do we want a revert timer or not? I thought about this in the past and have 
not yet come to a definite conclusion. Other question is how this relates to 
"instant-apply". Do we want this as well in the future?
  
  Interesting would be the reasoning in the past to have neither.
  
  This can be changed later, but inline message would be preferable to dialog 
popup.
  
  What I could imagine here is the following:
  
  - Have instant-apply
  - Have 3 to 5 seconds change-timer after something changed (and was instantly 
applied)
  - If user changed something else before change-timer triggers restart 
change-timer
  - When change-timer triggers show warning and start revert-timer
  - When revert-timer triggers reset to the original configuration before any 
instantly-applied changes
  - When KCM closed by user assume user is content with all current changes and 
stop all timers

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KInit - Current state and benchmarks

[Albert Astals Cid]

El dimarts, 26 de novembre de 2019, a les 8:56:54 CET, Milian Wolff va escriure:
> On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote:
> > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va 
> escriure:
> > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote:
> > > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va
> > > 
> > > escriure:
> > > > > > Are we sure it's fair to assume people have SSD? our of the 4
> > > > > > laptops i
> > > > > > own, only 2 have SSD.>
> > > > > 
> > > > > It's at least safe to assume it's the trend moving forward.
> > > > > 
> > > > > > Do you think it's worth me trying in one of the two that don't have
> > > > > > SSD?
> > > > > 
> > > > > More data is normally a good thing. If you or anyone else wants to
> > > > > collect stats:
> > > > > From my git link above, it's as simple as running the normal ; cmake;
> > > > > make ; ./kinittest -median 5
> > > > 
> > > > On my very old/very slow computer seems to make a lot of difference
> > > > 
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,625 msecs per iteration (total: 2,625, iterations: 1)
> > > > 
> > > > RESULT : DaveTest::testKInit():
> > > >  1,852 msecs per iteration (total: 1,852, iterations: 1)
> > > > 
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,390 msecs per iteration (total: 2,390, iterations: 1)
> > > > 
> > > > RESULT : DaveTest::testKInit():
> > > >  1,846 msecs per iteration (total: 1,846, iterations: 1)
> > > 
> > > Hey Albert,
> > > 
> > > these numbers are quite impressive but I can't quite explain those. Are
> > > you
> > > measuring maybe a full debug build without any compiler optimizations?
> > 
> > I obviously can't remember, this was *months* ago, but i just ran the test
> > again (making sure -O3 was there and not any -g) and got a bit different
> > results, so maybe it was.
> 
> Does this apply to your whole stack (instead of just the inittest from Dave)?

Yes

> 
> > New results:
> >  * testQProcess: 2200 msec per iteration
> >  * testKInit:1700 msec per iteration
> > 
> > Still a 20% speed improvement.
> > 
> > > Then
> > > the library sizes will be _much_ larger and thus trigger more page faults.
> > > If every one of those is extremely slow on that machine compared to more
> > > modern machines?
> > > 
> > > May I ask how old this machine is and what the speed of the HDD is?
> > 
> > It's a Lenovo ideapad S10-3t, around 10 years old, the HDD is slow. But it's
> > of similar power to the Librecomputer La Frite i just got for free at
> > LinuxAppSummit, so even this is on the slow end of things we support i
> > think there's value on supporting it.
> > 
> > If you're interested i can arrange you to get ssh access to the machine (the
> > ideapad, i don't have all the KF5/Qt stack built for the LaFrite).
> 
> Yes, that would be interesting for me!

I sent you the details on private.

Cheers,
  Albert

> 
> Cheers
> 

D25556: Remove dead code

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aff09d73f337: Remove dead code (authored by nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25556?vs=70371=70375

REVISION DETAIL
  https://phabricator.kde.org/D25556

AFFECTED FILES
  klipper/configdialog.cpp

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25556: Remove dead code

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  lol

REPOSITORY
  R120 Plasma Workspace

BRANCH
  lol

REVISION DETAIL
  https://phabricator.kde.org/D25556

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25556: Remove dead code

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  lol

REPOSITORY
  R120 Plasma Workspace

BRANCH
  lol

REVISION DETAIL
  https://phabricator.kde.org/D25556

AFFECTED FILES
  klipper/configdialog.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25540: Add default value for cursor theme

[Mikhail Zolotukhin]

gikari accepted this revision.
gikari added a comment.


  It changes config correctly now (instead of empty cursor theme name, that was 
before), but somehow cursor does not change until I manually change the cursor 
theme in Cursors KCM. 
  Very strange.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25540

To: broulik, gikari, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25549: [kcms/keyboard] Port away from KToolInvokation

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I would prefer
  
  KRun::somethingsomething
  
  there's a lot of other magic when spawning a new process with environment 
variables for focus transfer that we don't want to accidentally lose

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25549

To: nicolasfella, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25549: [kcms/keyboard] Port away from KToolInvokation

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  kdeinit will most likely be dropped. Use QProcess to start it normally

TEST PLAN
  Open KCM from SNI

REPOSITORY
  R119 Plasma Desktop

BRANCH
  ktoo

REVISION DETAIL
  https://phabricator.kde.org/D25549

AFFECTED FILES
  kcms/keyboard/CMakeLists.txt
  kcms/keyboard/layouts_menu.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Nathaniel Graham]

ngraham added a comment.


  Very nice, I applaud the goal. However it looks like on net a lot more lines 
of code were added than were removed, which suggests the addition of redundant 
boilerplate or unrelated style refactoring. In the former case, can we factor 
out some of it into additional helper functions?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Nathaniel Graham]

ngraham added a comment.


  Instead of emulating a double-click, can we instead always launch on a 
single-click with touch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25227: Document Kirigami.Theme Better

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:15d2b186bee4: Document Kirigami.Theme Better (authored by 
zanny, committed by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25227?vs=69495=70355

REVISION DETAIL
  https://phabricator.kde.org/D25227

AFFECTED FILES
  src/controls/Theme.qml

To: zanny, apol, davidedmundson
Cc: ngraham, davidedmundson, davidre, apol, mart, plasma-devel, gennad, 
fbampaloukas, GB_2, domson, dkardarakos, skadinna, ahiemstra, hein

D25227: Document Kirigami.Theme Better

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25227

To: zanny, apol, davidedmundson
Cc: ngraham, davidedmundson, davidre, apol, mart, plasma-devel, gennad, 
fbampaloukas, GB_2, domson, dkardarakos, skadinna, ahiemstra, hein

D25426: use the new GlobalDrawer header property

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f365fd5e36d9: use the new GlobalDrawer header property 
(authored by mart).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25426?vs=70337=70354

REVISION DETAIL
  https://phabricator.kde.org/D25426

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: mart, #discover_software_store, ngraham, apol
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25425: header property for the drawer

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c3e00e58b4ff: header property for the drawer (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25425?vs=70072=70353#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25425?vs=70072=70353

REVISION DETAIL
  https://phabricator.kde.org/D25425

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/icon.cpp

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D25539: KScreen KCM: Add a revert timer to the settings page

[Nathaniel Graham]

ngraham added a reviewer: romangg.
ngraham added a comment.


  Yeah, it would be good to know the history on that.
  
  Also, please change the title to "feat(kcm): add a revert timer to the 
settings page" to comply with KScreen's new commit message guidelines.

INLINE COMMENTS

> main.qml:32
>  property int selectedOutput: 0
> +property int revertCountdown: 10
>  

Doesn't seem to be used; the timer duration is hardcoded on the C++ side

> main.qml:110
> +}
> +standardButtons: StandardButton.Save | StandardButton.Cancel
> +}

I would change these to `StandardButton.Apply` and `StandardButton.Discard`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

To: mart, #discover_software_store, ngraham, apol
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25540: Add default value for cursor theme

[Mikhail Zolotukhin]

gikari added a comment.


  This is strange. I've just opened a Kde Neon Dev VM, done the above, and 
after relogin it works even without this patch.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25540

To: broulik, gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25525: KCM Style : take into account immutable properties

[Cyril Rossi]

crossi updated this revision to Diff 70351.
crossi added a comment.


  adjustment since view.enabled also show disabled look and feel

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25525?vs=70297=70351

REVISION DETAIL
  https://phabricator.kde.org/D25525

AFFECTED FILES
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25540: Add default value for cursor theme

[Kai Uwe Broulik]

broulik added a comment.


  Yes, when setting "Breeze" (not snow) as cursor theme, it will delete the key 
from the kcminputrc because it is the default.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25540

To: broulik, gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25522: KCM Colors : take into account immutable property

[Cyril Rossi]

crossi updated this revision to Diff 70350.
crossi added a comment.


  fix style issue

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25522?vs=70294=70350

REVISION DETAIL
  https://phabricator.kde.org/D25522

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25540: Add default value for cursor theme

[Mikhail Zolotukhin]

gikari added a comment.


  Did I understand correctly, that in order to test this I need to:
  
  1. Apply not a default cursor theme (for example `Breeze_Snow`)
  2. Comment a `cursorTheme=Breeze_Snow` line in `~/.config/kcminput`
  3. Check that Gtk apps still using Breeze_Snow
  4. Log out and then log in again
  5. Check that Gtk apps are using `breeze_cursors` - the default cursors
  
  ?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25540

To: broulik, gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25006: Make sure -dpi value is valid

[Gabriel Craciunescu]

gcraciunescu marked 2 inline comments as done.
gcraciunescu added a comment.


  
  
  > Though I'm not sure I fully understand why we have this sort of wrong value 
in the config anyway?
  
  The problem coming from force font DPI code so far I see.
  Now the min/max & steps to scale down/up are fixed in the UI but any reset to 
default
  enable/disable a DPI value there will write a forceFontDPI=0 in the config 
file which seems to mean disabled.
  I am not sure why we need to write a 0 on reset/disable since default has 
nothing also.
  
  However, even if we fix there we may still want to be sure the value is a 
number and >= 24, at least in my opinion.
  People do crazy stuff even writing manually or with scripts to configuration 
files.
  
  > Also do we want
  > 
  >   } else {
  >   args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = 
QString();
  >   }
  > 
  > 
  > so that a broken DPI wipes the old config entry out? Not sure.
  
  Not sure about that either but maybe a good idea.

INLINE COMMENTS

> ngraham wrote in advancedconfig.cpp:193
> You can combine both of these conditions into the same if statement.

I thought I should follow the coding style in the file which does
all the comparing in at least 2 lines.

> ngraham wrote in advancedconfig.cpp:195
> `>=` has a different meaning when comparing strings vs comparing integers. 
> You need to first parse or cast `dpiValue` to an `int`, then compare it to 
> the number 24.

Right,  I keep forgetting that =) Not doing much in Qt these days.

Also, QStringLiteral(X) needs to be .toInt() so I guess I drop that and use 
plain number.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25006

To: gcraciunescu, filipf, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25537: [kaccess] Remove unneeded KService dependency

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5c29f1f4aaee: [kaccess] Remove unneeded KService 
dependency (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25537?vs=70324=70342

REVISION DETAIL
  https://phabricator.kde.org/D25537

AFFECTED FILES
  kaccess/CMakeLists.txt
  kaccess/kaccess.cpp

To: nicolasfella, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25227: Document Kirigami.Theme Better

[Matthew Scheirer]

zanny added a comment.


  No commit access, email is matt.schei...@gmail.com

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25227

To: zanny, apol, davidedmundson
Cc: davidedmundson, davidre, apol, mart, plasma-devel, gennad, fbampaloukas, 
GB_2, domson, dkardarakos, ngraham, skadinna, ahiemstra, hein

D25428: Improved support for desktop "Folder View"

[Steffen Hartleib]

steffenh added a comment.


  @ngraham thanks again for testing,
  
  Ok, so it's just the double click simulation was is not working 100% on your 
laptop, I think I can work with it.
  
  On the other hand, if I am lucky I can borrow a HPSpectre x360  in the next 
days, too test this directly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25227: Document Kirigami.Theme Better

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Do you have commit access? If not can I have your email address?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25227

To: zanny, apol, davidedmundson
Cc: davidedmundson, davidre, apol, mart, plasma-devel, gennad, fbampaloukas, 
GB_2, domson, dkardarakos, ngraham, skadinna, ahiemstra, hein

D25227: Document Kirigami.Theme Better

[David Redondo]

davidre added a comment.


  Ping.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25227

To: zanny, apol
Cc: davidre, apol, mart, plasma-devel, gennad, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, skadinna, ahiemstra, davidedmundson, hein

D25543: Split Style & Helper into files by widget type

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Great, navigating in Breeze source will be a lot simpler now 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis added a comment.


  Please say if something about the structure does not make sense to you or if 
you think improvements could be made.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The goal of this change is to make it easier for people to hack on the Breeze 
KStyle by making it easier to find which parts they need to change.

REPOSITORY
  R31 Breeze

BRANCH
  ndavis/kstyle-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25543

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/widgets/checkbox.cpp
  kstyle/widgets/combobox.cpp
  kstyle/widgets/combobox.h
  kstyle/widgets/dial.cpp
  kstyle/widgets/dockwidget.cpp
  kstyle/widgets/groupbox.cpp
  kstyle/widgets/header.cpp
  kstyle/widgets/itemview.cpp
  kstyle/widgets/linedit.cpp
  kstyle/widgets/mdi.cpp
  kstyle/widgets/menu.cpp
  kstyle/widgets/menubar.cpp
  kstyle/widgets/progressbar.cpp
  kstyle/widgets/pushbutton.cpp
  kstyle/widgets/radiobutton.cpp
  kstyle/widgets/scrollbar.cpp
  kstyle/widgets/slider.cpp
  kstyle/widgets/spinbox.cpp
  kstyle/widgets/tabbar.cpp
  kstyle/widgets/tabbar.h
  kstyle/widgets/toolbar.cpp
  kstyle/widgets/toolbox.cpp
  kstyle/widgets/toolbutton.cpp

To: ndavis, #plasma, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25526: KCM launch feedback : take into account immutable properties

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Indeed much better with Kai's suggestion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25526

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ngraham wrote in DiscoverDrawer.qml:26
> 2.12 now, right?

there aren't been components registered as 2.12 so far, so technically, it 
doesn't exist max i can be put there for now is 2.11

> apol wrote in DiscoverDrawer.qml:158
> How's that related? at least the drawerOpen bit should stay.

ok, i can remove it.. not related but most of the manualadjustments discover is 
doing, it shouldn't, but this is for another topic/patch

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25426

To: mart, #discover_software_store, ngraham
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25525: KCM Style : take into account immutable properties

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  LGTM, assuming the patch to GridViewKCM goes in as is, if it's changed of 
course it'll need an adjustment here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25525

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25430: fix layout of overlaysheet

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:36bf9e7a51fe: fix layout of overlaysheet (authored by 
mart).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25430?vs=70335=70336

REVISION DETAIL
  https://phabricator.kde.org/D25430

AFFECTED FILES
  discover/qml/ProgressView.qml

To: mart, #discover_software_store, apol
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25430: fix layout of overlaysheet

[Marco Martin]

mart updated this revision to Diff 70335.
mart marked 2 inline comments as done.
mart added a comment.


  - adress comments

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25430?vs=70081=70335

BRANCH
  phab/overlaysheet

REVISION DETAIL
  https://phabricator.kde.org/D25430

AFFECTED FILES
  discover/qml/ProgressView.qml

To: mart, #discover_software_store, apol
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25522: KCM Colors : take into account immutable property

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a tiny style issue, otherwise LGTM.

INLINE COMMENTS

> colors.h:51
>  Q_PROPERTY(FilterProxyModel *filteredModel READ filteredModel CONSTANT)
> +Q_PROPERTY(ColorsSettings* colorsSettings READ colorsSettings CONSTANT)
>  Q_PROPERTY(bool downloadingFile READ downloadingFile NOTIFY 
> downloadingFileChanged)

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25522

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25540: Add default value for cursor theme

[Kai Uwe Broulik]

broulik added a comment.


  Hmm, somehow still doesn't apply the cursors on login

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25540

To: broulik, gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart