D25584: [TabBar] Add a border property

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  I don't think the style is the right approach. What happens if you run the 
KCM with a different style, will it refuse to load?
  And `border` is quite a non-descript property, how about `frameVisible`

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25584

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu updated this revision to Diff 70474.
liushuyu added a comment.


  Address ndavis' comments

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25539?vs=70451=70474

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25539

AFFECTED FILES
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/package/contents/ui/main.qml

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu added a comment.


  In D25539#568678 , @ndavis wrote:
  
  > Is there a way to tell the revert timer not to be used if the user only 
makes a change that requires a session restart? It wouldn't be very useful to 
ask a user to confirm if the screen is displaying correctly if the change can't 
be seen.
  
  
  Sorry, I don't know how to determine whether the changes only require a 
session restart properly. To my knowledge, the global scale option is the only 
setting that probably does not need the timer and my current idea is to set a 
boolean flag somewhere to indicate the global scale has changed and see if this 
is the only change user has made.

INLINE COMMENTS

> ndavis wrote in main.qml:109
> Since you are keeping the recently applied configuration rather than applying 
> a new one, wouldn't it be better to say something like "Keep"? It would also 
> be better to use `dialog-ok-apply` as the icon for consistency with similar 
> controls.

Will do

> ndavis wrote in main.qml:115
> I would put Undo to the left of Keep/Apply. Normally, Undo/Reset is to the 
> far left of Apply. That can't be the case here, but I think preserving the 
> order is better for muscle memory.

I will address this

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Noah Davis]

ndavis added a comment.


  Is there a way to tell the revert timer not to be used if the user only makes 
a change that requires a session restart? It wouldn't be very useful to ask a 
user to confirm if the screen is displaying correctly if the change can't be 
seen.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> main.qml:109
> +iconName: "document-save"
> +text: i18n("Apply")
> +onTriggered: {

Since you are keeping the recently applied configuration rather than applying a 
new one, wouldn't it be better to say something like "Keep"? It would also be 
better to use `dialog-ok-apply` as the icon for consistency with similar 
controls.

> main.qml:115
> +},
> +Kirigami.Action {
> +iconName: "edit-undo"

I would put Undo to the left of Keep/Apply. Normally, Undo/Reset is to the far 
left of Apply. That can't be the case here, but I think preserving the order is 
better for muscle memory.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25584: [TabBar] Add a border property

[Filip Fila]

filipf added a comment.


  In D25584#568669 , @ngraham wrote:
  
  > Feels like at this point we should just break down and create an actual 
`TabView` control all at once. :p
  
  
  Yep. Unfortunately it seems we'd still need this hacky property because we'd 
be including TabBar.
  
  ... and the other hack lol, but it would be nice to not have to do all this 
all the time:
  
  F7787597: image.png 
  
  F7787600: tabview.qml 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  border-property (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25584

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25584: [TabBar] Add a border property

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Feels like at this point we should just break down and create an actual 
`TabView` control all at once. :p

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  border-property (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25584

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25584: [TabBar] Add a border property

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  In the Window Decorations and Audio KCMs we use QQC2 TabBars with a frame.
  
  The frame already draws a top border but then the tabbar draws another 
border, resulting in an ugly, dark, out of place line.
  
  I added a property to the QQC2 TabBar style because I assume there might be 
cases where it's not used with a frame so a border is needed there.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  border-property (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25584

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25581: [TabBar] Use window color instead of button color

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  If some color scheme (not Breeze) doesn't use the same button and window 
colors the tab sticks out.
  
  BUG: 413311
  FIXED-IN: 5.65

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  right-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25581

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22176: Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  As mentioned earlier: this is a great idea, but has issues with the model. 
Please check D25580  as a per-requirement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25580: [System Tray] Unified data model for System Tray items

[Konrad Materka]

kmaterka added a comment.


  This is a simplified version of D23413  
needed for the D22176  to move forward.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25580

To: kmaterka, #plasma, broulik
Cc: plasma-devel, nicolasfella, anthonyfieroni, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25580: [System Tray] Unified data model for System Tray items

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  Currently there are two different sources of SystemTray items:
  
  - Plasmoids
  - Status Notifier
  
  Thi change adds new model that holds both Plasmoids and SNIs.

TEST PLAN
  Add/disable applets. Start/stop SNI app.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25580

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma, broulik
Cc: plasma-devel, nicolasfella, anthonyfieroni, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Benjamin Port]

bport updated this revision to Diff 70453.
bport added a comment.


  Fix regression (apply button not activated when eeded) and ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24847?vs=69037=70453

REVISION DETAIL
  https://phabricator.kde.org/D24847

AFFECTED FILES
  kcms/icons/iconsmodel.cpp
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, mart, ervin, #plasma, crossi, ngraham
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

[Benjamin Port]

bport updated this revision to Diff 70452.
bport added a comment.


  Take in consideration feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=69036=70452

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu added a comment.


  After applying the patches from 
https://cgit.kde.org/kirigami.git/commit/?id=8c1e5b1336e6dcae0a1b7756977fcd9368f853a2,
  it now looks like this:
  
  F7787159: image.png 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Zixing Liu]

liushuyu updated this revision to Diff 70451.
liushuyu added a comment.


  Update icons and stop the timer on actions pressed

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25539?vs=70390=70451

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25539

AFFECTED FILES
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/package/contents/ui/main.qml

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Supported devicesof Plasma

[Vignesh Rajendran]

Hello Plasma,

In the documentation, there are no information of supported devices. [Except 
Nexus?]
I would like try Plasma and interested to know the supported devices of Plasma.

Can you please list the supported devices?

I really appreciate your effort on alternative to Android.

Regards,
Vignesh Rajendran

Sent with [ProtonMail](https://protonmail.com) Secure Email.

D25305: Add Total/Available/Allocated memory sensors

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:05e26b28ebb7: Add Total/Available/Allocated memory 
sensors (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25305?vs=69748=70445

REVISION DETAIL
  https://phabricator.kde.org/D25305

AFFECTED FILES
  ksysguardd/Linux/Memory.c
  ksysguardd/Linux/Memory.h

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25306: Add translations for new memory sensors

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:eedf1ca73d1b: Add translations for new memory sensors 
(authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25306?vs=69749=70446

REVISION DETAIL
  https://phabricator.kde.org/D25306

AFFECTED FILES
  ksgrd/SensorManager.cpp

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25570: Fix InlineMessage actions always being placed in overflow menu

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8c1e5b1336e6: Fix InlineMessage actions always being 
placed in overflow menu (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25570?vs=70440=70443

REVISION DETAIL
  https://phabricator.kde.org/D25570

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/templates/InlineMessage.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25566: [Notifications] Move out of the way of dialog rather than just hiding

[Nathaniel Graham]

ngraham added a comment.


  Nice, this works great. Just what I would expect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25566

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25570: Fix InlineMessage actions always being placed in overflow menu

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Due to some of the recent ActionToolBar work, InlineMessage ended up always 
placing its
  actions into the overflow menu. This fixes that.

TEST PLAN
  Kirigami2Gallery's Inline Messages page now properly shows the actions for 
messages. When
  the window width is reduced, the actions will first be placed on a second 
line, then moved
  to the overflow menu once even that is too little space.

REPOSITORY
  R169 Kirigami

BRANCH
  inlinemessage_actions

REVISION DETAIL
  https://phabricator.kde.org/D25570

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/templates/InlineMessage.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25569: Also overwrite document.createElement using exportFunction

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: fvogt, davidedmundson, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures it works in Firefox on sites with content security policy like 
Spotify.

TEST PLAN
  - Spotify works now in Firefox
  - Google Translate still works in Firefox
  
  Needs more testing:
  
  - Firefox ESR
  - Chrome
  - the stuff that broke by replacing `document.createElement` before I changed 
it to use the `Document.prototype`
  
  ...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25569

AFFECTED FILES
  extension/content-script.js

To: broulik, fvogt, davidedmundson, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KInit - Current state and benchmarks

[Aleix Pol]

On Tue, Nov 26, 2019 at 8:57 AM Milian Wolff  wrote:
>
> On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote:
> > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va
> escriure:
> > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote:
> > > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va
> > >
> > > escriure:
> > > > > > Are we sure it's fair to assume people have SSD? our of the 4
> > > > > > laptops i
> > > > > > own, only 2 have SSD.>
> > > > >
> > > > > It's at least safe to assume it's the trend moving forward.
> > > > >
> > > > > > Do you think it's worth me trying in one of the two that don't have
> > > > > > SSD?
> > > > >
> > > > > More data is normally a good thing. If you or anyone else wants to
> > > > > collect stats:
> > > > > From my git link above, it's as simple as running the normal ; cmake;
> > > > > make ; ./kinittest -median 5
> > > >
> > > > On my very old/very slow computer seems to make a lot of difference
> > > >
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,625 msecs per iteration (total: 2,625, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testKInit():
> > > >  1,852 msecs per iteration (total: 1,852, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,390 msecs per iteration (total: 2,390, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testKInit():
> > > >  1,846 msecs per iteration (total: 1,846, iterations: 1)
> > >
> > > Hey Albert,
> > >
> > > these numbers are quite impressive but I can't quite explain those. Are
> > > you
> > > measuring maybe a full debug build without any compiler optimizations?
> >
> > I obviously can't remember, this was *months* ago, but i just ran the test
> > again (making sure -O3 was there and not any -g) and got a bit different
> > results, so maybe it was.
>
> Does this apply to your whole stack (instead of just the inittest from Dave)?
>
> > New results:
> >  * testQProcess: 2200 msec per iteration
> >  * testKInit:1700 msec per iteration
> >
> > Still a 20% speed improvement.
> >
> > > Then
> > > the library sizes will be _much_ larger and thus trigger more page faults.
> > > If every one of those is extremely slow on that machine compared to more
> > > modern machines?
> > >
> > > May I ask how old this machine is and what the speed of the HDD is?
> >
> > It's a Lenovo ideapad S10-3t, around 10 years old, the HDD is slow. But it's
> > of similar power to the Librecomputer La Frite i just got for free at
> > LinuxAppSummit, so even this is on the slow end of things we support i
> > think there's value on supporting it.
> >
> > If you're interested i can arrange you to get ssh access to the machine (the
> > ideapad, i don't have all the KF5/Qt stack built for the LaFrite).
>
> Yes, that would be interesting for me!

I have some leftover units. If that's helpful, I can arrange for you
to get a unit.

Aleix

D25567: Repair the wallpaper config dialog

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This is full of mixed bindings/signal handlers for properties and of
  broken references in here!
  
  There's likely more to do, but those were the most obvious ones when
  working on the screenlocker KCM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25567

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25566: [Notifications] Move out of the way of dialog rather than just hiding

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When e.g. connecting to a network with captive portal, it leaves you sitting 
there wondering what's going on. The notification won't time out until it 
becomes visible again but still there's been complaints that the notifications 
go missing.
  This patch makes them move out of the way vertically. It is pretty crude but 
covers the majority ("System Tray covers notifications") case.

TEST PLAN
  F7786935: 30ae33e9-8334-4928-8945-94371990c379.mp4 

  When there's many notifications, it can look a bit odd as they move down and 
then the lower part is hidden as notifications may only occupy 2/3 of vertical 
height even when shifted.
  Didn't test what happens if you have a giant notification on a small screen, 
it will probably end up partially off screen

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25566

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25287: Integrate the lnf and wallpaper settings with the KCM logic

[Kevin Ottens]

ervin updated this revision to Diff 70432.
ervin added a comment.


  Fix typo

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25287?vs=70429=70432

REVISION DETAIL
  https://phabricator.kde.org/D25287

AFFECTED FILES
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  greeter/wallpaper_integration.cpp
  greeter/wallpaper_integration.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/lnfconfig.qml
  kcm/wallpaperconfig.qml

To: ervin, #plasma, mart, davidedmundson, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25540: Add default value for cursor theme

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:4090e899eddd: Add default value for cursor theme (authored 
by broulik).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25540?vs=70331=70431

REVISION DETAIL
  https://phabricator.kde.org/D25540

AFFECTED FILES
  kded/configvalueprovider.cpp

To: broulik, gikari, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25287: Integrate the lnf and wallpaper settings with the KCM logic

[Kevin Ottens]

ervin updated this revision to Diff 70429.
ervin added a comment.


  Adjust for bugs found in the lnf and wallpaper integration
  
  This was missing some signalling and copying back in the item

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25287?vs=69678=70429

REVISION DETAIL
  https://phabricator.kde.org/D25287

AFFECTED FILES
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  greeter/wallpaper_integration.cpp
  greeter/wallpaper_integration.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/lnfconfig.qml
  kcm/wallpaperconfig.qml

To: ervin, #plasma, mart, davidedmundson, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25322: Have the wallpaper combo managed by KConfigDialogManager

[Kevin Ottens]

ervin updated this revision to Diff 70430.
ervin added a comment.


  On some condition the assert would be triggered

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25322?vs=69791=70430

REVISION DETAIL
  https://phabricator.kde.org/D25322

AFFECTED FILES
  CMakeLists.txt
  greeter/greeterapp.cpp
  kcfg/kscreenlockersettings.kcfg
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kscreensaversettings.cpp
  kscreensaversettings.h

To: ervin, #plasma, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart