D25624: Don't use qmlRegisterType with QT-5.14

[Peter Levine]

plevine created this revision.
plevine added a reviewer: jriddell.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
plevine requested review of this revision.

REVISION SUMMARY
  Building Plymouth-kcm-5.17.3 against Qt 5.14.0_beta3 fails with:
  
../plymouth-kcm-5.17.3/src/kcm.cpp: In constructor 
'KCMPlymouth::KCMPlymouth(QObject*, const QVariantList&)':
../plymouth-kcm-5.17.3/src/kcm.cpp:54:41: error: no matching function for 
call to 'qmlRegisterType()'
   54 | qmlRegisterType();
  | ^
In file included from /usr/include/qt5/QtQml/QtQml:9,
 from 
/usr/include/KF5/KDeclarative/kquickaddons/configmodule.h:34,
 from 
/usr/include/KF5/KDeclarative/KQuickAddons/ConfigModule:1,
 from ../plymouth-kcm-5.17.3/src/kcm.h:28,
 from ../plymouth-kcm-5.17.3/src/kcm.cpp:21:
/usr/include/qt5/QtQml/qqml.h:291:5: note: candidate: 'int 
qmlRegisterType(const char*, int, int, const char*) [with T = 
QStandardItemModel]'
  291 | int qmlRegisterType(const char *uri, int versionMajor, int 
versionMinor, const char *qmlName)
  | ^~~
/usr/include/qt5/QtQml/qqml.h:291:5: note:   candidate expects 4 arguments, 
0 provided
/usr/include/qt5/QtQml/qqml.h:322:5: note: candidate: 'template int qmlRegisterType(const char*, int, int, const char*)'
  322 | int qmlRegisterType(const char *uri, int versionMajor, int 
versionMinor, const char *qmlName)
  | ^~~
/usr/include/qt5/QtQml/qqml.h:322:5: note:   template argument 
deduction/substitution failed:
../plymouth-kcm-5.17.3/src/kcm.cpp:54:41: note:   candidate expects 4 
arguments, 0 provided
   54 | qmlRegisterType();
  | ^
../plymouth-kcm-5.17.3/src/kcm.cpp:55:34: error: no matching function for 
call to 'qmlRegisterType()'
   55 | qmlRegisterType();
  |  ^
In file included from /usr/include/qt5/QtQml/QtQml:9,
 from 
/usr/include/KF5/KDeclarative/kquickaddons/configmodule.h:34,
 from 
/usr/include/KF5/KDeclarative/KQuickAddons/ConfigModule:1,
 from ../plymouth-kcm-5.17.3/src/kcm.h:28,
 from ../plymouth-kcm-5.17.3/src/kcm.cpp:21:
/usr/include/qt5/QtQml/qqml.h:291:5: note: candidate: 'int 
qmlRegisterType(const char*, int, int, const char*) [with T = KCMPlymouth]'
  291 | int qmlRegisterType(const char *uri, int versionMajor, int 
versionMinor, const char *qmlName)
  | ^~~
/usr/include/qt5/QtQml/qqml.h:291:5: note:   candidate expects 4 arguments, 
0 provided
/usr/include/qt5/QtQml/qqml.h:322:5: note: candidate: 'template int qmlRegisterType(const char*, int, int, const char*)'
  322 | int qmlRegisterType(const char *uri, int versionMajor, int 
versionMinor, const char *qmlName)
  | ^~~
/usr/include/qt5/QtQml/qqml.h:322:5: note:   template argument 
deduction/substitution failed:
../plymouth-kcm-5.17.3/src/kcm.cpp:55:34: note:   candidate expects 4 
arguments, 0 provided
   55 | qmlRegisterType();
  |  ^
ninja: build stopped: subcommand failed.
  
  From https://doc-snapshots.qt.io/qt5-5.14/qqmlengine-obsolete.html:
  
int qmlRegisterType()
This function is obsolete. It is provided to keep old source code working. 
We strongly advise against using it in new code.

This is an overloaded function.

Do not use this function. For anonymous type registrations, use 
qmlRegisterAnonymousType(), and make sure to provide a URI and a major version.
  
  I don't have much experience with QT/KDE programming but these changes are 
sufficient to fix the build error on my end.
  
  BUG: 414679

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25624

AFFECTED FILES
  src/kcm.cpp

To: plevine, jriddell
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25618: Account for a mnemonic label to go back to ""

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We are discarding the value if there's no weights which meant that when
  setting a button to "", the text provided by mnemonicLabel wouldn't update.
  This patch changes it so it only skips the weights computation if there's no
  text.

TEST PLAN
  Tested with patch that removes the text of some buttons when the
  screen is smaller on Discover.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25618

AFFECTED FILES
  src/mnemonicattached.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25617: MenuIcon: fix warnings when the drawer isn't initialized

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Have a plan for when drawer isn't initialized

TEST PLAN
  I don't get all the warnings from discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25617

AFFECTED FILES
  src/controls/templates/private/MenuIcon.qml

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Something to consider in time for Plasma 5.18, post 5.17.5 and before 5.17.90)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D23005

To: kossebau, mart, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22778: Restore option to create a Qt Designer plugin

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 70584.
kossebau added a comment.


  Update to latest master

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22778?vs=62646&id=70584

BRANCH
  readdoptiontogeneratedesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22778

AFFECTED FILES
  CMakeLists.txt
  lsofui/CMakeLists.txt
  lsofui/designer/CMakeLists.txt
  lsofui/ksysguardlsof.widgets
  processui/CMakeLists.txt
  processui/designer/CMakeLists.txt
  processui/ksysguard.widgets
  signalplotter/CMakeLists.txt
  signalplotter/designer/CMakeLists.txt
  signalplotter/ksignalplotter.widgets

To: kossebau, #plasma, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25581: [TabBar] Use window color instead of button color

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:386248f6d454: [TabBar] Use window color instead of button 
color (authored by filipf).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25581?vs=70470&id=70583

REVISION DETAIL
  https://phabricator.kde.org/D25581

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf, #plasma, #vdg, ngraham
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25581: [TabBar] Use window color instead of button color

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Yeah, the widget style version uses a lightened version of the window color 
for the active tab and the frame's background. Ideally we would do the same 
thing in the QQC2 desktop style. However this patch is enough to fix the bug in 
its current form so I think it can go in now, and we can investigate that in 
the next patch.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25581

To: filipf, #plasma, #vdg, ngraham
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25581: [TabBar] Use window color instead of button color

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oops.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  right-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25581

To: filipf, #plasma, #vdg, ngraham
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much for this, it made D25361  
such a breeze!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25586

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham updated this revision to Diff 70579.
ngraham added a comment.


  Rebase; soo much easier now with D25586 
!

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25361?vs=69933&id=70579

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.h
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: ngraham, #plasma, #vdg, ndavis
Cc: GB_2, davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham updated this revision to Diff 70580.
ngraham added a comment.


  Clean up more

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25361?vs=70579&id=70580

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: ngraham, #plasma, #vdg, ndavis
Cc: GB_2, davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Björn Feber]

GB_2 added a comment.


  In D25361#566193 , @ngraham wrote:
  
  > I share you concern about this KCM becoming a dumping ground. But I don't 
see a better place for this setting right now. And I think it does make some 
sense for it to hold general behavioral settings that affect both apps and 
Plasma.
  
  
  Sounds plausible to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: GB_2, davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:95047f61275e: Reshape Kickoff avatar to a circle with 
Opacity Mask (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13415?vs=70124&id=70578

REVISION DETAIL
  https://phabricator.kde.org/D13415

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ngraham, sharvey, #vdg, #plasma, mart
Cc: filipf, sefaeyeoglu, hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24866: Wired setting: improve handling of link negotiation

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  UI looks good to me.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24866

To: jgrulich, #plasma, #vdg
Cc: ngraham, dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25614: [System Tray] Clean up popup code

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:103
>  checked: plasmoid.configuration.pin
> -onCheckedChanged: plasmoid.configuration.pin = checked
> +onClicked: plasmoid.configuration.pin = checked
>  icon.name: "window-pin"

`onToggled`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25614

To: filipf, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25614: [System Tray] Clean up popup code

[Filip Fila]

filipf added a comment.


  Everything looks the same, but I did notice that the "Status and 
Notifications" isn't on the right in RTL mode, not sure why:
  
  F7789933: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25614

To: filipf, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25614: [System Tray] Clean up popup code

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This removes hacks and does things in a cleaner way.
  
  Credits go to @broulik.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  code-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25614

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25602: [System Tray] Restore old pin button size

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:37c1ec10888f: [System Tray] Restore old pin button size 
(authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25602?vs=70526&id=70575

REVISION DETAIL
  https://phabricator.kde.org/D25602

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg, davidedmundson, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:26284d73cf94: Simplify load of locale variables (authored 
by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25612?vs=70568&id=70573

REVISION DETAIL
  https://phabricator.kde.org/D25612

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/writeexports.h
  startkde/startplasma.cpp

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25613: Remove generation of plasma-locale-settings.sh

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f5ab71acc03b: Remove generation of 
plasma-locale-settings.sh (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25613?vs=70572&id=70574

REVISION DETAIL
  https://phabricator.kde.org/D25613

AFFECTED FILES
  kcms/formats/kcmformats.cpp
  kcms/formats/writeexports.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25613: Remove generation of plasma-locale-settings.sh

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's being addressed with D25612 

TEST PLAN
  Builds, makes sense.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25613

AFFECTED FILES
  kcms/formats/kcmformats.cpp
  kcms/formats/writeexports.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25018: Move ACPI battery information from /proc/acpi to /sys

[Arjen Hiemstra]

ahiemstra added a comment.


  @jjorge: I had to manually edit your author information into the commit, 
since that got lost somewhere along the way and replaced with our localization 
script info. I think it is OK now, but please check 
https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9be791f43ba5052

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25018: Move ACPI battery information from /proc/acpi to /sys

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:9022a93738df: Move ACPI battery information from 
/proc/acpi to /sys (authored by l10n daemon script , 
committed by ahiemstra).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25018?vs=69357&id=70569#toc

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25018?vs=69357&id=70569

REVISION DETAIL
  https://phabricator.kde.org/D25018

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h
  ksysguardd/modules.h

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Lovely.
  
  There's a writeexports.h in p-d to kill too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25612

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25569: Also overwrite document.createElement using exportFunction

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Ugly...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25569

To: broulik, fvogt, davidedmundson, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[Aleix Pol Gonzalez]

apol updated this revision to Diff 70567.
apol added a comment.


  Address david comment, merge all of the LANG things

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25612?vs=70555&id=70567

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25612

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/writeexports.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[Aleix Pol Gonzalez]

apol updated this revision to Diff 70568.
apol added a comment.


  Remember to sync

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25612?vs=70567&id=70568

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25612

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/writeexports.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25566: [Notifications] Move out of the way of dialog rather than just hiding

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:24900b334788: [Notifications] Move out of the way of 
dialog rather than just hiding (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25566?vs=70433&id=70564#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25566?vs=70433&id=70564

REVISION DETAIL
  https://phabricator.kde.org/D25566

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25608: Remove dead code

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c95d7fad0ef7: Remove dead code (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25608?vs=70548&id=70562

REVISION DETAIL
  https://phabricator.kde.org/D25608

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[Kevin Ottens]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:506d1807e6a4: Port KSMServer's KCM to KConfigXT 
(authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25609?vs=70551&id=70563

REVISION DETAIL
  https://phabricator.kde.org/D25609

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h
  kcms/ksmserver/smserversettings.kcfg
  kcms/ksmserver/smserversettings.kcfgc

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25525: KCM Style : take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable 
properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25525?vs=70351&id=70559

REVISION DETAIL
  https://phabricator.kde.org/D25525

AFFECTED FILES
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25523: KCM LookAndFeel : take into account immutable property

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:277bb04e7455: KCM LookAndFeel : take into account 
immutable property (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25523?vs=70295&id=70557

REVISION DETAIL
  https://phabricator.kde.org/D25523

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. 
Take into account immutable properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25586?vs=70482&id=70561

REVISION DETAIL
  https://phabricator.kde.org/D25586

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg
  kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfgc

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25524: KCM KSplash : take into account immutable property

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dd9a6da45f9e: KCM KSplash : take into account immutable 
property (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25524?vs=70296&id=70558

REVISION DETAIL
  https://phabricator.kde.org/D25524

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25526: KCM launch feedback : take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account 
immutable properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25526?vs=70304&id=70560

REVISION DETAIL
  https://phabricator.kde.org/D25526

AFFECTED FILES
  kcms/launch/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25522: KCM Colors : take into account immutable property

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:298611977e3b: KCM Colors : take into account immutable 
property (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25522?vs=70350&id=70556

REVISION DETAIL
  https://phabricator.kde.org/D25522

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Looks like you didn't address a faire number of comments, or they ended up in 
the wrong commit (by the look of D24847 ).

INLINE COMMENTS

> main.cpp:137
>  {
> -return m_iconSizes[group];
> -}
> -
> -void IconModule::setIconSize(int group, int size)
> -{
> -if (iconSize(group) == size) {
> -return;
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {

nitpick, I find = more readable in such a context (and less prone to the most 
vexing parse since you don't use curly braces init).

I'd write: const auto themeName = m_model->selectedTheme();

> ervin wrote in main.cpp:102
> Now that my ManagedConfigModule change landed, you should use a proper 
> compile time check connect to settingsChanged here.

I still think those connects might not be necessary.

> ervin wrote in main.cpp:110
> Don't do foreach. Instead write:
> 
>   for (auto theme : qAsConst(m_iconThemeCache)) {
> 
> Or even better, just use qDeleteAll:
> 
>   qDeleteAll(m_iconThemeCache)
> 
> Or even better yet : try to use std::unique_ptr, std::shared_ptr or 
> QScopedPointer as values in your associative container (I let you check which 
> one fits best).

Still not addressed... mind your for loops...

> main.h:117
>  
> -QVector m_iconSizes;
> +QMap m_kicon_theme_map;
>  

Still not addressed... s/m_kicon_theme_map/m_iconThemeMap/ (we do camel case 
here) and should be a QHash.

> ervin wrote in main.h:34
> s/QMap/QHash/

Still not addressed, use a QHash

> ervin wrote in main.h:83
> Killing the const here is semantically wrong IMO.

Still not addressed, put the const back

> ervin wrote in IconSizePopup.qml:81
> I think I'd have expected that logic on the C++ side actually. Others might 
> disagree. :-)

Not on the C++ side still?

> ervin wrote in IconSizePopup.qml:91
> Urgh, I'd assert than silently swallow that I think.

Still not addressed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[David Edmundson]

davidedmundson added a comment.


  +1

INLINE COMMENTS

> startplasma.cpp:143
>  if (!QFile::exists(localerc)) {
>  QFile f(localerc);
>  f.open(QFile::WriteOnly);

This may as well be merged if we're going to open the config next anyway

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25612

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25612: Simplify load of locale variables

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Load l10n values using kconfig instead of sourcing a generated shell script
  from the kcm.

TEST PLAN
  Builds, starts properly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25612

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/writeexports.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/breeze.git/commit/?id=6fe549361b4301efddb358989af45ad44d4ae7a8

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25593

To: broulik, #vdg, hpereiradacosta, davidedmundson, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcmsmserver.cpp:203
> This patch renames this entry "default" to "emptySession"
> 
> From what I can tell it won't matter for ksmserver itself as that only 
> compares against the other two strings.
> 
> But if  a user had this value set currently then opens the KCM afterwards, 
> which value gets loaded?

Yes, several reasons for that change: default doesn't play well as an enum 
value, also it wasn't the default at all... since restoring the previous 
session is.
In our case, if there's "default" in the file, it will in practice fallback to 
restore previous session which I think is fine as a behavior.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[Kevin Ottens]

ervin updated this revision to Diff 70551.
ervin added a comment.


  Add missing scoped pointer. I thought I did it, apparently just in my head. 
:-D

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25609?vs=70549&id=70551

REVISION DETAIL
  https://phabricator.kde.org/D25609

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h
  kcms/ksmserver/smserversettings.kcfg
  kcms/ksmserver/smserversettings.kcfgc

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[David Edmundson]

davidedmundson added a comment.


  So much red :D

INLINE COMMENTS

> kcmsmserver.cpp:203
> -  if ( dialog->emptySessionRadio->isChecked() )
> -  s = QStringLiteral("default");
> -  else if ( dialog->savedSessionRadio->isChecked() )

This patch renames this entry "default" to "emptySession"

From what I can tell it won't matter for ksmserver itself as that only compares 
against the other two strings.

But if  a user had this value set currently then opens the KCM afterwards, 
which value gets loaded?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmsmserver.h:50
>  
> +  Ui::SMServerConfigDlg *ui;
> +  SMServerSettings *m_settings;

it seems that ui is never deleted. (I can't see it deleted in destructor.)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

To: ervin, #plasma, mart, davidedmundson, crossi, bport, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25608: Remove dead code

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25608

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25609: Port KSMServer's KCM to KConfigXT

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25609

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h
  kcms/ksmserver/smserversettings.kcfg
  kcms/ksmserver/smserversettings.kcfgc

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25592: handle action for custom shadow background hint

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e473bdd3f9ad: handle action for custom shadow background 
hint (authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25592?vs=70514&id=70547

REVISION DETAIL
  https://phabricator.kde.org/D25592

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25591: support for the shadow and effectiveBackgroundhints

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:84247e8424b7: support for the shadow and 
effectiveBackgroundhints (authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25591?vs=70515&id=70546

REVISION DETAIL
  https://phabricator.kde.org/D25591

AFFECTED FILES
  applets/digital-clock/package/contents/ui/main.qml
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml

To: mart, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

[Wilfried van Asten]

sniperrifle added a comment.


  I'm thinking of adding what the intended behaviour is of the function 
regarding XDG_DATA_DIRS to the function comment and removing the comment in the 
code. Would that be acceptable?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25604

To: sniperrifle, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:02bbef3b506a: [XembedSNIProxy] Send all container windows 
to background on KWin restart (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25603?vs=70528&id=70542

REVISION DETAIL
  https://phabricator.kde.org/D25603

AFFECTED FILES
  xembed-sni-proxy/fdoselectionmanager.cpp
  xembed-sni-proxy/sniproxy.cpp
  xembed-sni-proxy/sniproxy.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

[Konrad Materka]

kmaterka added a comment.


  In D25603#569113 , @davidedmundson 
wrote:
  
  > Alternatively, if we need to reset something when our window gets 
moved...could we watch for our window getting moved?
  >  It'll be the more technically correct, and keeps this code agnostic.
  >
  > No idea how feasible that is though. Your call.
  
  
  I'm fully aware that this "fix" is an ugly hack. Checking if window moved 
probably won't work, as window is not moving, it is just stacked above other 
windows (or all other are stacked below?). In addition, it is probably not a 
KWin fault. Container window is very strange for KWin, for example it has no 
window decorations. Maybe it is missing some essential window hint?
  Anyway, I will think about this, but firstly I need to learn more about X 
windows, hints, compositing etc. From the other side XembedSNIProxy should be 
simple, not as complex as window manager :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25603

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart