D25624: Don't use qmlRegisterType with QT-5.14

2019-11-30 Thread Peter Levine 
plevine updated this revision to Diff 70645.
plevine added a comment.


  Use QT_VERSION_CHECK for clarity.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25624?vs=70596&id=70645

REVISION DETAIL
  https://phabricator.kde.org/D25624

AFFECTED FILES
  src/kcm.cpp

To: plevine, jriddell, #plasma, davidedmundson
Cc: zzag, davidedmundson, asturmlechner, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25633: Fix Cuttlefish mouse click selection in icon grid

2019-11-30 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:dd263acd2f62: Fix Cuttlefish mouse click selection in 
icon grid (authored by GB_2).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25633?vs=70626&id=70637

REVISION DETAIL
  https://phabricator.kde.org/D25633

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGridDelegate.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25633: Fix Cuttlefish mouse click selection in icon grid

2019-11-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25633

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25637: Port away from kglobalsettings

2019-11-30 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> componentchooserterminal.cpp:87
>  Kdelibs4SharedConfig::syncConfigGroup(QLatin1String("General"), 
> "kdeglobals");
>  
>  QDBusMessage message  = 
> QDBusMessage::createMethodCall(QStringLiteral("org.kde.klauncher5"),

No need to notify here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25637

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-11-30 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 70633.
kossebau added a comment.


  - keep old CMake Config files installed
  - no longer create unused version.h file

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23005?vs=63296&id=70633

BRANCH
  fixcmakeconfigname

REVISION DETAIL
  https://phabricator.kde.org/D23005

AFFECTED FILES
  CMakeLists.txt
  KF5QQC2DesktopStyleConfig.cmake.in

To: kossebau, mart, broulik
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25637: Port away from kglobalsettings

2019-11-30 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This was there only to support notifying kdeinit4, which we no longer
  care about.
  
  For KF5 we should be sending the specific call to klauncher
  to reparse KProtocolManager, which in one case we seem to 
  actually miss.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25637

AFFECTED FILES
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25635: Add icon to browser integration do not remind menu item

2019-11-30 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:e37eef54ab35: Add icon to browser integration do not 
remind menu item (authored by GB_2).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25635?vs=70628&id=70630

REVISION DETAIL
  https://phabricator.kde.org/D25635

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: GB_2, #plasma, #vdg, davidedmundson
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25636: Fixup deprecated use of QWeakPointer::data

2019-11-30 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  At the point init is run we can be sure that our decoration->client()
  pointer is valid, but we still need to get a strongRef for the duration
  of our usage for Qt6

TEST PLAN
  Compiles

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25636

AFFECTED FILES
  src/decorationbutton.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25635: Add icon to browser integration do not remind menu item

2019-11-30 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  F7791325: Plasma Browser Integration Do Not Remind Menu Item Icon.png 


TEST PLAN
  Don't have the PBI addon installed and reset its `showCount`. Then open the 
tray icon context menu.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25635

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25634: Add kconf update script for ksmserver

2019-11-30 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Config enum value was moved in a recent commit to
  kcfg we should port the value for existing setups

TEST PLAN
  Ran script

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25634

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kconf_update/ksmserver_update_loginMode_value.py
  kcms/ksmserver/kconf_update/ksmserver_update_loginMode_value.upd

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-11-30 Thread Aleix Pol Gonzalez 
apol added a comment.


  Maybe you can install one with the typo and one without, so Plasma and 
whatever else can be ported and start doing things properly.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D23005

To: kossebau, mart, broulik
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25633: Fix Cuttlefish mouse click selection in icon grid

2019-11-30 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Fixes the selection preview being changed before the selection rectangle 
changes.

TEST PLAN
  Click on an icon in Cuttlefish.

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25633

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGridDelegate.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25624: Don't use qmlRegisterType with QT-5.14

2019-11-30 Thread Vlad Zahorodnii 
zzag added inline comments.

INLINE COMMENTS

> kcm.cpp:55
>  {
> +#if QT_VERSION < 0x050140
>  qmlRegisterType();

You could use `QT_VERSION_CHECK` to make the code more readable, e.g.

  #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
  qmlRegisterType();
  qmlRegisterType();
  #else
  qmlRegisterAnonymousType("KCMPlymouth", 1);
  qmlRegisterAnonymousType("KCMPlymouth", 1);
  #endif

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25624

To: plevine, jriddell, #plasma, davidedmundson
Cc: zzag, davidedmundson, asturmlechner, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25624: Don't use qmlRegisterType with QT-5.14

2019-11-30 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  You'll find this with the other repos too.
  
  In general I've been reverting the relevant path of the cmake that forces no 
deprecated.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25624

To: plevine, jriddell, #plasma, davidedmundson
Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

2019-11-30 Thread Steffen Hartleib 
steffenh updated this revision to Diff 70597.
steffenh added a comment.


  don't use simulated double mouse click to open/launch an item.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25428?vs=70247&id=70597

BRANCH
  arcpatch-D25428

REVISION DETAIL
  https://phabricator.kde.org/D25428

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart