D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi updated this revision to Diff 71488.
trmdi added a comment.


  - Improve comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71408=71488

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/othershellhelper.cpp
  shell/othershellhelper.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Noah Davis]

ndavis added a comment.


  I don't find this better than the current form:
  F7817345: Screenshot_20191214_002245.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

[David Faure]

dfaure added a comment.


  Fix pushed 
https://commits.kde.org/plasma-desktop/2b5e86323f180f0c51ef9af898a69a522bc379ad 
after the bug reporter confirmed it fixes the bug.
  
  Reopening this after it was committed is a bit weird. I can't close it, 
please do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit! Stable branch please.
  
  BTW, GridViewKCM, SimpleKCM, and ScrollViewKCM seem like they needs the same 
treatment, now that I'm navigating System Settings with the Oxygen style to 
test this.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  transparent-quick-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25973

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

[Filip Fila]

filipf updated this revision to Diff 71485.
filipf added a comment.


  - downgrade Rectangle to Item since we don't need anything fancy anymore 
(good tip @ngraham)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25973?vs=71484=71485

BRANCH
  transparent-quick-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25973

AFFECTED FILES
  src/qml/main.qml
  src/themeconfig.cpp

To: filipf, #plasma, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

[Nathaniel Graham]

ngraham added a comment.


  Excellent solution. Question: do we even need a `Rectangle` at all if it's 
going to be transparent? Can it just be an `Item`?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25973

To: filipf, #plasma, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  In D19890#577221 , 
@hpereiradacosta wrote:
  
  > Confused about 2: I thought icon size was the same for flat and non flat 
toolbuttons (see oxygen-demo5, buttons tab)
  
  
  Most normal buttons use 16px icons while flat buttons on the toolbar use 22px 
icons.
  F7817118: Screenshot_20191213_175032.png 
F7817120: Screenshot_20191213_175119.png 

  Here's what it looks like when flat buttons and normal buttons are both using 
22px icons.
  F7817116: Screenshot_20191213_174918.png 

  
  > About 3: really I think that would be bad
  
  I also think that it would cause more trouble than it would fix.
  
  > I too think that either 4 (ignoring the problem) or 5: don't change the 
current code, and dont revert the revert, is the way to go.
  >  for 4: only a few icons would be affected, and only for toolbuttons with 
long popup delay (the only case for which this arrow is drawn).
  
  Are you saying not to revert the revert at all and instead write a new patch 
or is that just part of #5 (not changing the code)?
  
  > These are already rather rare, and considered bad UI anyway if I remember 
right.
  
  Correct, I personally think we should never use long popup delay buttons for 
devices with touchpads or mice.
  
  > Please pretty please, do not (re) add this arrow (whether tiny or large) to 
instant-popup toolbuttons though.
  
  Ok

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

[Filip Fila]

filipf updated this revision to Diff 71484.
filipf added a comment.


  - remove old hack comment

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25973?vs=71483=71484

BRANCH
  transparent-quick-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25973

AFFECTED FILES
  src/qml/main.qml
  src/themeconfig.cpp

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We're currently using an ugly hack in our main.qml file to make the 
QuickWidget that shows>
  
  The hack is not only ugly but totally breaks apart with any widget style 
that's not Breeze.
  
  The correct solution has always been to just set the QuickWidget to be 
transparent. It now blends with every widget style and we don't need a hack 
anymore.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  transparent-quick-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25973

AFFECTED FILES
  src/qml/main.qml
  src/themeconfig.cpp

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  We could also do these things:
  
  - In Dolphin, mimic the back/forward buttons in Firefox/Chromium/Falkon by 
making the right click menu provide the history instead of the normal menu for 
manipulating the toolbar. Inconsistent with what we normally do, but not 
unexpected for anyone used to web browsers. Clicking and holding is also 
awkward and slow for mouse and touchpad users.
  - Remove the feature. It's not essential, but it is nice to have.
  
  In D19890#577207 , @ngraham wrote:
  
  > I honestly think ignoring the problem is the best solution, because it's 
not even really a problem in practice: the vast, overwhelming majority of icons 
use correct margins, especially action icons which are going to be the ones 
used 99.9% of the time in buttons that will get these corner arrows. The 
alternative is to regress something significant for a more common use case or 
abandon this change and live with user complaints about these buttons taking up 
too much space, neither of which seem very appealing.
  
  
  What are correct margins though? Margins are only correct if following an HIG 
that requires margins. There are no universally correct margins.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D19890#577204 , @ndavis wrote:
  
  > Ok, so there is an overlap problem, but it's quite rare. It happens when an 
icon uses 100% of the available space in the bottom right corner (or left with 
RTL, I think).
  >  Here I changed the stop icon in KDevelop to the icon for Codelite: 
F7817068: Screenshot_20191213_171219.png .
  >
  > I could get around this in a number of ways that all have their downsides:
  >  1/ Move the arrow to the very bottom right and make sure it's small enough 
that no clipping happens
  >
  > - This looks bad and makes it harder to see the arrow 2/ Reduce the default 
icon size for flat buttons
  > - This is more consistent with non-flat buttons, but I like the bigger 
icons. They're more readable too.
  
  
  
  
  > 3/ Increase the padding around flat buttons
  > 
  > - I like the current padding 4/ Ignore the problem
  > - Will look fine with most icon themes, but bad in some cases such as the 
one described above.
  
  Confused about 2: I thought icon size was the same for flat and non flat 
toolbuttons (see oxygen-demo5, buttons tab)
  About 3: really I think that would be bad
  I too think that either 4 (ignoring the problem) or 5: don't change the 
current code, and dont revert the revert, is the way to go.
  for 4: only a few icons would be affected, and only for toolbuttons with long 
popup delay (the only case for which this arrow is drawn). 
  These are already rather rare, and considered bad UI anyway if I remember 
right.
  
  Please pretty please, do not (re) add this arrow (whether tiny or large) to 
instant-popup toolbuttons ...
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Nathaniel Graham]

ngraham added a comment.


  I honestly think ignoring the problem is the best solution, because it's not 
even really a problem in practice: the vast, overwhelming majority of icons use 
correct margins, especially action icons which are going to be the ones used 
99.9% of the time in buttons that will get these corner arrows. The alternative 
is to regress something significant for a more common use case or abandon this 
change and live with user complaints about these buttons taking up too much 
space, neither of which seem very appealing.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  Ok, so there is an overlap problem, but it's quite rare. It happens when an 
icon uses 100% of the available space in the bottom right corner (or left with 
RTL, I think).
  Here I changed the stop icon in KDevelop to the icon for Codelite: F7817068: 
Screenshot_20191213_171219.png .
  
  I could get around this in a number of ways that all have their downsides:
  
  - Move the arrow to the very bottom right and make sure it's small enough 
that no clipping happens
- This looks bad and makes it harder to see the arrow
  - Reduce the default icon size for flat buttons
- This is more consistent with non-flat buttons, but I like the bigger 
icons. They're more readable too.
  - Increase the padding around buttons
- I like the current padding around toolbuttons
  - Ignore the problem
- Will look fine with most icon themes, but bad in some cases such as the 
one described above.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25971: Use text color for "No preview image" text

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  clearly correct, stable branch please

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25971

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25971: Use text color for "No preview image text"

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The text that shows up as the theme preview when no image preview is 
available was always just black.
  
  That's not great for dark themes so this patch makes it use text color.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25971

AFFECTED FILES
  src/themesdelegate.cpp

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Nathaniel Graham]

ngraham added a comment.


  Thanks, that fixed it. I haven't noticed any shifting of the plasmoid in the 
system tray, but if you want to minimize that, you can add 
`X-Plasma-NotificationAreaCategory=SystemServices` to the `metadata.desktop` 
file. See D11352  for more details.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 71479.
zzag added a comment.


  Revert applet visibility changes.
  
  Unfortunately, this may cause unnecessary shuffling of system tray items.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71477=71479

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

[David Faure]

dfaure added a comment.


  Further research leads to this possible patch 
http://www.davidfaure.fr/2019/windowmodel.cpp.diff

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Nathaniel Graham]

ngraham added a comment.


  Hmm, that last change broke clicking on the applet. Now it does nothing. +1 
for the general ideal behind it though.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Nathaniel Graham]

ngraham added a comment.


  All right, if you're working on it, I won't bug you. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25969: No longer vertically flip the shade icon when toggled

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  @ndavis?

REPOSITORY
  R31 Breeze

BRANCH
  no-flip-for-shade-button

REVISION DETAIL
  https://phabricator.kde.org/D25969

To: andykluger, #breeze, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  +1 for readability

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25970

To: ngraham, #vdg, jgrulich, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  In D19890#577135 , @ngraham wrote:
  
  > I'm not sure how to do that in the Breeze style here; can you show me?
  
  
  Ehh, I'm already working on it and figuring it out as I go. I have to move 
points in a vector around, which is annoying since I can't see the dimentions 
of the area I'm drawing in. I'm not even sure where the origin is. I would 
assume the top left of the area I have, but I'm not certain since -4 is 
apparently a valid X and Y position.

INLINE COMMENTS

> breezehelper.cpp:1308
>  case ArrowRight: arrow = QVector{QPointF( -2, -4 ), 
> QPointF( 2, 0 ), QPointF( -2, 4 )}; break;
> +case ArrowDown_Small: arrow = QVector{QPointF( 2, 4 ), 
> QPointF( 4, 6 ), QPointF( 6, 4 )}; break;
>  default: break;

The vector I'm talking about

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Nathaniel Graham]

ngraham added a comment.


  Will do. I didn't even know they used the same style.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25970

To: ngraham, #vdg, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Kai Uwe Broulik]

broulik added a comment.


  Make sure that whatever you decide on is also applied to Bluetooth plasmoid

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25970

To: ngraham, #vdg, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  There isn't any need to make the labels bold and all the text almost half 
transparent.
  The view is just fine without them, and the current style is quite 
low-contrast with a
  dark theme.
  
  BUG: 414993
  FIXED-IN: 5.18.0

TEST PLAN
  F7816994: Less transparent.png 
  F7816993: Less transparent dark.png 

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  less-transparent-details-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25970

AFFECTED FILES
  applet/contents/ui/DetailsText.qml

To: ngraham, #vdg, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  One problem I see with this is that the tops of the down arrows are a bit 
blurry. The way to fix that is to increase the size just enough that they fill 
the pixel. The bottom point should also have a MiterJoin so that it isn't a 
horizontal flat tip on high DPI screens.

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Nathaniel Graham]

ngraham added a comment.


  I'm not sure how to do that in the Breeze style here; can you show me?

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 71477.
zzag added a comment.


  Display the applet in the system tray when Night Color is inhibited.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71474=71477

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25969: No longer vertically flip the shade icon when toggled

[Andy Kluger]

andykluger created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
andykluger requested review of this revision.

REVISION SUMMARY
  Now that it gets color-inverted, there's no need to (and some say it should 
not) get flipped. As discussed in D14389 .

REPOSITORY
  R31 Breeze

BRANCH
  no-flip-for-shade-button

REVISION DETAIL
  https://phabricator.kde.org/D25969

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: andykluger
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Andres Betts]

abetts accepted this revision.
abetts added a comment.


  Love it! Move forward!

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts
Cc: abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  UI and interactivity seems spot-on to me now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In retrospect, I think I reverted this too quickly in response to concerns. 
As expected, we have been receiving user complaints that the arrows in the 
corners of Dolphin's back and forward buttons are too large. This patch fixes 
the issue by making them less obtrusive, and I tested it with oxygen5-demo and 
several icon themes and our own icons and could not find any cases where the 
arrow overlaps with the icon. I would like to propose re-merging it.

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 71474.
zzag added a comment.


  Nate's suggestion.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71438=71474

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25967: Emit panelTakesFocus for other plamsashell types

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The semantics of a window taking focus on user interaction apply to more
  roles. See D25851 .
  
  Arguably the name implies something more limited, but it makes sense to
  reuse the existing logic.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25967

AFFECTED FILES
  src/windowsystem/windowsystem.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2a42a15cdf68: [KCMs/Night Color] Make activation criteria 
and times more obvious (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71461=71470

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg, filipf
Cc: filipf, abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Looks good. I just realized that maybe the message at the top could be an 
info inline message, but I see how that could be too much.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg, filipf
Cc: filipf, abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Nathaniel Graham]

ngraham added a comment.


  This is fantastic! My on UI suggestion is to only the applet in the system 
tray (when using "Auto" visibility) only when Night Color is actually activated 
or activating. People who want it in their tray all the time can manually set 
it to "shown". The one exception would be that when Night Color is is using the 
"Constant" mode, the applet should always be visible in the tray when using 
"Auto" visibility.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Don't require KWallet, and require KAccounts and libaccounts-Qt5
  
  Link and use includes from new requirements
  
  Remove KWallet bits, and use KAccounts/libaccounts-qt instead
  
  This removes the custom KWallet integration in favour of an approach
  based on the more generic KAccounts framework. It is a work in progress
  which currently does not allow for creating new accounts (which would
  be done through saveCredentials), but which does load and use the data
  from any accounts which already exist.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71461.
ngraham added a comment.


  Address other VDG comments from chatroom (add time labels to main formlayout 
and align)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71460=71461

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/314/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Dec 2019 17:14:35 +
 Build duration:
3 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 2646 lines...][2019-12-13T17:17:32.934Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslide/cubeslide.cpp.o[2019-12-13T17:17:32.934Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgrid/desktopgrid.cpp.o[2019-12-13T17:17:35.042Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-13T17:17:35.042Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-13T17:17:35.328Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-13T17:17:35.328Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-13T17:17:35.328Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-13T17:17:35.614Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-13T17:17:35.874Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-13T17:17:36.157Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-13T17:17:47.998Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-13T17:17:47.998Z] desktop = activeWindow->desktop();[2019-12-13T17:17:47.998Z] ^[2019-12-13T17:17:47.998Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-13T17:17:47.998Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-13T17:17:47.998Z] ^[2019-12-13T17:17:47.998Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-13T17:17:47.998Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-13T17:17:47.998Z]   ^[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-13T17:17:47.998Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-13T17:17:47.998Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-13T17:17:47.998Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-13T17:17:47.998Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-13T17:17:47.998Z] 1 warning generated.[2019-12-13T17:17:47.998Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2019-12-13T17:17:47.998Z] [ 49%] Building CXX object 

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71460.
ngraham added a comment.


  Address VDG review comments from here

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71430=71460

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham added a comment.


  In D25920#576966 , @abetts wrote:
  
  > Suggestions:
  >
  > "To reduce eye strain, Night Color makes the colors on the screen warmer at 
the time of your choosing"
  >
  > Change to:
  >
  > "Night Color makes the screen colors warmer to reduce eye strain"
  
  
  That eliminates the "at the time of your choosing", bit, without which I 
worry that users might mistakenly believe that this feature permanently tints 
the screen while on, missing the entire point that it does this on;y at certain 
times of day.
  
  > "Night color temperature"
  > 
  > Change to:
  > 
  > "Temperature"
  
  Or maybe even... "Color"?
  
  > - Sunset/sunrise at manual location
  > 
  >   Change to:
  > - Sunset to sunrise at different location
  
  Other proposed changes seem fine, but this would make that feature 
misleading, I feat. My first iteration of this patch used "different location", 
but upon reflection and consultation with the developers, using a location 
other than your own makes no sense whatsoever. The point of the manual location 
entry is to enter your own location without needing to use the geolocator in 
the case that it's broken or you're very privacy-conscious. There are no valid 
user use cases to living in Australia and setting the location to Canada.
  
  > Instead of having latitude/longitude + Detect Location, swap to Detect 
Location + Lat/long after.
  
  Good idea!
  
  > "Color change begins at XX:XX"
  > 
  > Change to:
  > 
  > Night color begins at XX;XX
  > 
  > Color fully changed, might not be necessary? Too much detail?
  > 
  > "Color begins changing back at XX:XX"
  > 
  > Change to
  > 
  > Night color ends XX:XX
  > 
  > Normal coloration restored by XX:XX, might be too much info.
  
  Because of the lengthy transition time, if we just list the time when it 
starts, people will get confused because they'll say, "hey, this thing says 
it's on, but I don't see any color change!" because the color has just started 
changing and has not finished the transition yet.
  
  > Since the color changes gradually, maybe we could add an option to 
enable/disable that function? Something like
  > 
  > [X] Gradual activation
  > [X] Change colors gradually
  
  There is, when using manual times mode. In that mode, you can choose the 
transition time. When using a location-based mode, this isn't user-selectable 
because the transition time is perfectly coordinated to come on when the sun 
starts to set and complete when it's dark. It doesn't make sense to let the 
user override that when in a location-based mode.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Andres Betts]

abetts added a comment.


  Suggestions:
  
  "To reduce eye strain, Night Color makes the colors on the screen warmer at 
the time of your choosing"
  
  Change to:
  
  "Night Color makes the screen colors warmer to reduce eye strain"
  
  "Night color temperature"
  
  Change to:
  
  "Temperature"
  
  Activation
  
  - Sunset/sunrise at current location
  - Sunset/sunrise at manual location
  - Manual times
  - Always on
  
  Change to:
  
  Time:
  
  - Sunset to sunrise at your location
  - Sunset to sunrise at different location
  - Custom time
  - Always on
  
  Instead of having latitude/longitude + Detect Location, swap to Detect 
Location + Lat/long after.
  
  "Color change begins at XX:XX"
  
  Change to:
  
  Night color begins at XX;XX
  
  Color fully changed, might not be necessary? Too much detail?
  
  "Color begins changing back at XX:XX"
  
  Change to
  
  Night color ends XX:XX
  
  Normal coloration restored by XX:XX, might be too much info.
  
  Since the color changes gradually, maybe we could add an option to 
enable/disable that function? Something like
  
  [X] Gradual activation
  [X] Change colors gradually

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25940: Add support for custom display components to Action

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:22d31898ae0b: Add support for custom display components 
to Action (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25940?vs=71418=71459

REVISION DETAIL
  https://phabricator.kde.org/D25940

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25844: Don't compress tasks before grouping, when task manager is vertical

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, now the bug and the fix are very clear! LGTM!
  
  @hein and/or #plasma  people, what 
do you think?

REVISION DETAIL
  https://phabricator.kde.org/D25844

To: gvgeo, #plasma, #vdg, hein, ngraham
Cc: davidedmundson, GB_2, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25959: [applets/taskmanager] Add highlight effect for hovered tooltip

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Looks better now, and matches the hover effect for the close button.

TEST PLAN
  F781: demo-2019-12-13_16.59.41.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tm-tooltip-highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25959

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25936: [Desktop Containment] Hide tooltip while rotating the widget

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:115a3e1aeede: [Desktop Containment] Hide tooltip while 
rotating the widget (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25936?vs=71400=71456

REVISION DETAIL
  https://phabricator.kde.org/D25936

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml

To: broulik, #plasma, mart, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25932: [Task Manager] Better align badge in tooltip

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67d86068d7f2: [Task Manager] Better align badge in 
tooltip (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25932?vs=71384=71455#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25932?vs=71384=71455

REVISION DETAIL
  https://phabricator.kde.org/D25932

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, #vdg, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25944: Let the other components grow if there's more things on the header

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3aa7f59f9ebe: Let the other components grow if 
theres more things on the header (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25944?vs=71422=71449

REVISION DETAIL
  https://phabricator.kde.org/D25944

AFFECTED FILES
  src/controls/ListSectionHeader.qml

To: apol, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/313/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Dec 2019 14:44:04 +
 Build duration:
6 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 2641 lines...][2019-12-13T14:49:50.499Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cube/cube_proxy.cpp.o[2019-12-13T14:49:50.499Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslide/cubeslide.cpp.o[2019-12-13T14:49:51.074Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgrid/desktopgrid.cpp.o[2019-12-13T14:49:51.723Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-13T14:49:52.329Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-13T14:49:52.586Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-13T14:49:53.555Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-13T14:49:53.555Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-13T14:49:53.556Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-13T14:49:56.042Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-13T14:49:58.142Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-13T14:49:58.447Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-13T14:49:58.447Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-13T14:49:58.447Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-13T14:49:58.731Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-13T14:50:02.255Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-13T14:50:03.781Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-13T14:50:03.781Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-13T14:50:03.781Z] desktop = activeWindow->desktop();[2019-12-13T14:50:03.781Z] ^[2019-12-13T14:50:03.781Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-13T14:50:03.781Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-13T14:50:03.781Z] ^[2019-12-13T14:50:03.781Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-13T14:50:03.781Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-13T14:50:03.781Z]   ^[2019-12-13T14:50:04.048Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-13T14:50:04.321Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-13T14:50:04.581Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-13T14:50:05.185Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-13T14:50:05.848Z] 1 warning generated.[2019-12-13T14:50:05.848Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-13T14:50:07.967Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-13T14:50:08.638Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-13T14:50:08.950Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-13T14:50:10.019Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-13T14:50:11.095Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-13T14:50:11.376Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-13T14:50:12.387Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-13T14:50:14.393Z] [ 49%] Building CXX object 

D25950: Add specialized notification for Bluetooth battery

[Nathaniel Graham]

ngraham added a comment.


  Maybe this should be a critical notification? If it's your mouse or a device 
you're using to present with, that's not something you want to miss. :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25950

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The tooltip already stays open when you click on the close button, to allow 
you to close
  multiple windows in rapid succession. This patch adopts that behavior for 
when clicking
  on the thumbnail itself, in aid of the use case where you want to bring 
multiple windows
  forward in rapid succession.
  
  BUG: 414976
  FIXED-IN: 5.18.0

TEST PLAN
  - Turn on tooltips if they're off
  - Open multiple windows such that one of yout Task Manager items becomes 
grouped
  - Hover over the grouped item
  - Click on multiple windows to bring them all forward quickly

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25952

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25951: Show peripheral low battery notification for NoCharge

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BlueZ doesn't report charge state, only percentage, so it is unfortunately 
always `NoCharge` for them.
  Add an additional guard to check for "0%" charge explicitly just in case.

TEST PLAN
  - Got a notificaton about my headphones running low

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25951

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25950: Add specialized notification for Bluetooth battery

[Kai Uwe Broulik]

broulik updated this revision to Diff 71439.
broulik added a comment.


  - Drop odd parentheses

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25950?vs=71437=71439

REVISION DETAIL
  https://phabricator.kde.org/D25950

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25950: Add specialized notification for Bluetooth battery

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we have a type for generic Bluetooth devices now, add a specialized 
notification for it.

TEST PLAN
  Needs another patch to actually work as Bluetooth reports no charge state
  F7816444: Screenshot_20191213_144643.png 


REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25950

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 71438.
zzag added a comment.


  Delete stray include.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71433=71438

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag added a comment.


  This patch depends on D25946  and D25786 
.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new applet allows to temporarily disable Night Color, for example if
  one wants to edit a video or an image.
  
  BUG: 400418

REPOSITORY
  R114 Plasma Addons

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71430.
ngraham added a comment.


  Put the separator in the formlayout for more simplicity

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71429=71430

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71429.
ngraham added a comment.


  Restore original import order for timings view now that we don't need layouts 
anymore

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71428=71429

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71428.
ngraham added a comment.


  Put the labels back in a FormLayout to align the times, but don't align the 
formlayout
  itself with the top one or else the whole thing is too far over to the left

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71419=71428

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham added a comment.


  This idea was to have a top-to-bottom flow. First you turn it on, then you 
select the activation mode, then you manipulate the controls specific to that 
mode (if applicable), then you see the times that result from those settings. I 
think it makes logical sense. If you have any suggestions for how to improve 
the presentation, I'm all ears. Also interested in #VDG 
 feedback.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25945: Sync dark theme preference for GTK3 applications

[Mikhail Zolotukhin]

gikari created this revision.
gikari added reviewers: apol, cblack, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Previously preference of dark GTK3 theme was set by checkbox in GTK KCM.  
Now, the checkbox is removed and preference is set according to color scheme, 
the user set in Colors KCMm, using the same heuristic, used for filter combobox 
in that KCM.
  
  This makes sense, because, suppose the user set Adwaita GTK3 theme, and their 
color scheme is something dark. Therefore their overall theme is supposedly 
dark, so Adwaita needs to be dark too.
  
  Note, however, that this preference is somewhat buggy. It does not work in 
flatpak apps, it can't be autoreloaded with xsettingsd, and also it is applied 
after some time has passed (this is hypothetical). You can check these 
statements, using the present checkbox in GTK KCM.
  
  Depends on D25872 

TEST PLAN
  1. Apply Adwaita GTK3 Theme
  2. Reload kded5
  3. Apply dark color scheme
  4. Wait some time
  5. (Re)open GTK3 app
  6. App should use Dark color scheme
  7. Apply light color scheme
  8. Wait some time
  9. Reopen GTK3 app
  10. App should use Light color scheme

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  sync-dark-gtk3-theme-preference (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25945

AFFECTED FILES
  CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari, apol, cblack, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Roman Gilg]

romangg added a comment.


  Sorry, but I don't like how the text is "hanging in the air" and how it is 
jumping around when changing the setting.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25944: Let the other components grow if there's more things on the header

[Nathaniel Graham]

ngraham added a comment.


  Much better, this fixes the issue for me.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25944

To: apol, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D25942: Instead of just delaying, compress calls to update

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  It was quite wrong

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, hein

D25944: Let the other components grow if there's more things on the header

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25944

AFFECTED FILES
  src/controls/ListSectionHeader.qml

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25844: Don't compress tasks before grouping, when task manager is vertical

[Nathaniel Graham]

ngraham added a comment.


  I'm not sure how to reproduce the issue that this patch is fixing. Can you 
add more detail to the Test Plan section maybe?

REVISION DETAIL
  https://phabricator.kde.org/D25844

To: gvgeo, #plasma, #vdg, hein
Cc: davidedmundson, GB_2, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Nathaniel Graham]

ngraham added a comment.


  In D25728#572362 , @manueljlin 
wrote:
  
  > I though that would just affect every app's titlebar without actually 
checking if the app has a toolbar, etc etc and just add/remove the divider 
everywhere and be done with it. However, if the app can actually send a hint to 
Kwin to make it hide or show the divider depending if it has a toolbar or not 
(or maybe through a window / app rule), then it's great
  
  
  Exactly.
  
  We can't rely 100% on KWin to draw the separator because with our proposed 
redesign, we want to have the separator below the menu or toolbar, if those are 
present. That means they would need to drawn by the app or the widget toolkit, 
not the window manager. That means that we can't have KWin always draw or not 
draw the titlebar. That means we need to have the separator drawn here.
  
  However there are two caveats that I can accept:
  
  - Right now this is the only kind of window that gains a separator drawn by 
the content view itself, so we should either turn it off or add it to all other 
windows with only titlebars
  - We should make the content view not draw the titlebar when KWin is drawing 
it
  
  Maybe what we should do is change the titlebar separator color in Breeze to 
be a pleasant dark gray like in the screenshot in @flipwise's latest comment 
instead of a garish blue, turn it on by default, and remove this here. Then for 
Plasma 6 (or whenever we do the proposed Breeze evolution) we can revisit that 
implementation and come up with something smarter.
  
  Does that make sense?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25943: Expose ActionToolBar's overflow button icon name

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This exposes the ActionToolBar overflow button's icon name as a property on
  ActionToolBar. This allows changing the icon, primarily to using a hamburger
  icon for indicating a "global menu".

TEST PLAN
  Overflow menus still look the same.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_overflowicon

REVISION DETAIL
  https://phabricator.kde.org/D25943

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71419.
ngraham added a comment.


  Polish everything even more to ensure a consistent top-to-bottom workflow. To 
do this
  I had to do a lot of refactoring that also has the side effect of making the 
UI a lot
  more declarative.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71399=71419

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25940: Add support for custom display components to Action

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 71418.
ahiemstra added a comment.


  - Add missing @since

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25940?vs=71415=71418

BRANCH
  action_displaycomponent

REVISION DETAIL
  https://phabricator.kde.org/D25940

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25942: Instead of just delaying, compress calls to update

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:106
> +id: delayUpdate
> +interval: 200
> +onTriggered: update()

i suppose if the delay is 0 it starts to jump again?

> broulik wrote in ActionToolBarLayoutDetails.qml:110
> How can this even work? `start` is a method. You probably meant `running = 
> true`? or `start()` which, in contrast to a `QTimer` will *not* restart the 
> timer if already running.
> 
> So apparently this isn't necessary at all, if it not doing anything actually 
> works?

to properly do event compression, you should do timer.restart()
(which, if already running restart the timer from 0)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, hein

D25940: Add support for custom display components to Action

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Action.qml:151
> + * A Component that should be preferred when displaying this Action.
> + */
> +property Component displayComponent: null

@since 2.12
@since 5.65

REPOSITORY
  R169 Kirigami

BRANCH
  action_displaycomponent

REVISION DETAIL
  https://phabricator.kde.org/D25940

To: ahiemstra, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25942: Instead of just delaying, compress calls to update

[Nathaniel Graham]

ngraham added a comment.


  This does not actually fix the vibrating label for me. It's still going, as 
fast as ever: F7816236: Peek 2019-12-13 10-59.gif 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart, hein

D25942: Instead of just delaying, compress calls to update

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:110
> +
> +onWidthChanged: { delayUpdate.start = true }
> +Component.onCompleted: { delayUpdate.start = true }

How can this even work? `start` is a method. You probably meant `running = 
true`? or `start()` which, in contrast to a `QTimer` will *not* restart the 
timer if already running.

So apparently this isn't necessary at all, if it not doing anything actually 
works?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25942: Instead of just delaying, compress calls to update

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Fixes an issue I was seeing where the size kept changing between updates.

TEST PLAN
  Now the ActionToolBar doesn't move about within the ListSectionHeader.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25942

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25941: Add a page to display ActionToolBar and some of its features

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  ActionToolBar has gained quite a lot of functionality. So add a page
  to highlight some of it.

TEST PLAN
  The new page displays properly.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  actiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25941

AFFECTED FILES
  src/data/contents/ui/MainPage.qml
  src/data/contents/ui/gallery/ActionToolBarGallery.qml
  src/data/info-data.json
  src/resources.qrc

To: ahiemstra, #kirigami
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25940: Add support for custom display components to Action

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "displayComponent" property to Action, which allows specifying a
  component to use when displaying an Action. Support is added to ActionToolBar
  and ActionsMenu for displaying these custom components.

TEST PLAN
  ActionToolBar and ActionsMenu still work the same. The new Action Tool Bar 
page
  in Kirigami Gallery displays the custom components.

REPOSITORY
  R169 Kirigami

BRANCH
  action_displaycomponent

REVISION DETAIL
  https://phabricator.kde.org/D25940

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25908: Lock screen by default, on mobile

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:0f75d80f23e8: Lock screen by default, on mobile (authored 
by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25908?vs=71320=71414

REVISION DETAIL
  https://phabricator.kde.org/D25908

AFFECTED FILES
  daemon/powerdevilprofilegenerator.cpp

To: apol, #plasma, broulik, nicolasfella
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik updated this revision to Diff 71413.
broulik added a comment.


  - Restore condition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25917?vs=71412=71413

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik updated this revision to Diff 71412.
broulik added a comment.


  - Cleanup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25917?vs=71350=71412

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart