D26338: Ensure WM initializes before session starts

[Eon S. Jeon]

esjeon added a comment.


  In D26338#588960 , @davidedmundson 
wrote:
  
  > On the conceptual level, does it make more sense for the relevant client 
(konsole) to monitor for compositing changed itself. It's something that could 
change at runtime regardless, so it needs to react to it anyway?
  >  If it does need that code anyway, there's no point doing fixes in startkde
  
  
  Technically, yes, apps can do that. But this will force changes to any apps 
that embed Konsole (i.e. dolphin, kate) or depend on desktop effects. Also, 
this issue will arise whenever an app implements such features. We can just 
solve this here and forget about it forever.
  
  Also, the problem only occurs during session restoration, so it's clear that 
one change here can fix for all applications.
  
  > Code wise, this gives a timeout for anyone who doesn't run kwin composited, 
which would be a problem as is.
  
  Welp, I agree, but there's just no way to figure out if user wants compositor 
or just WM. A possible solution is to make this toggleable through 
configuration or env, which isn't exactly beautiful.
  
  Still, the impact can be minimized by moving `wmjob` to right before session 
restoration instead of stage0.
  
  > also I don't like the split that ksmserver is waiting for kwin to register 
on ICE, and startkde is waiting on kwin through a combo of both DBus and X 
atoms in KWindowSystem::compositingActive(). That's 3 different paths all used 
at once.
  > 
  > I've been wanting to move the kwin startup from ksmserver into startkde 
anyway, doing those things together would make the most sense.
  
  I agree. Things will be much cleaner if WM is handled in startkde. WM isn't 
really a part of session, and ksmserver already treats WM as a special case 
anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26338

To: esjeon, #plasma, davidedmundson
Cc: asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Carson Black]

cblack added a comment.


  The QML code could use some help in the style department. Some changes I 
would do:
  
  1. Make ID separate from other properties
  2. Chunk together related properties in a consistent manner
  
  https://doc.qt.io/qt-5/qml-codingconventions.html and 
https://community.kde.org/Plasma/QMLStyle are relevant here.
  
  Also, I wonder if it would be better to spin out each tab into a KCM of its 
own instead of retaining a single Accessibility KCM as a catch-all for 
accessibility stuff that doesn't go anywhere else.

INLINE COMMENTS

> CMakeLists.txt:17
>  
> -target_link_libraries(kcm_access
> -Qt5::X11Extras
> +message("Arquivos" ${kcmaccess_PART_SRCS})
> +target_link_libraries(kcmaccess

What purpose does this serve? It looks like you're simply printing a list of 
source files with a Portuguese header.

> kcmaccess.cpp:194
> +
>  int ret = QProcess::execute(QStringLiteral("gsettings"), gsettingArgs);
>  if (ret) {

You could consider using glib for a stable ABI instead of invoking a command 
line that could change at any time. Also would reduce dependencies for most 
distros, as glib's command line tools are often packaged separately from glib 
itself.

> ModifierKeys.qml:98
> +icon.name: "preferences-desktop-notification"
> +onClicked: kcm.keyboardSettings.configureKNotify();
> +}

Redundant semicolon; there's only one statement on this line.

> ScreenReader.qml:35
> +QQC2.Button {
> +text: i18n("Launch Orca Screen Reader Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()

There should be an ellipsis here since this is opening another configuration 
window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Nathaniel Graham]

ngraham added a comment.


  Wondering if this is something that should be set in CMake or if it's so 
universal that it's okay to have it hardcoded in the file like this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 415461
  FIXED-IN: 5.18.0
  
  Right now when you first change the wallpaper plugin to slideshow, no 
locations are
  pre-configured, so you have to add one yourself. Considering that 
`/usr/share/wallpapers`
  is the default location for image wallpapers, this patch adds it as a default 
location
  for slideshow wallpapers too.

TEST PLAN
  Log in as new user > right-click desktop > configure > change to slideshow 
wallpaper
  See `/usr/share/wallpapers` is already in the list of wallpaper locations; 
how nice

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

AFFECTED FILES
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26482: [Folder view] Don't create a rubberband when dragging during a rename

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 415816
  FIXED-IN: 5.17.5

TEST PLAN
  Rename an item on the desktop
  Start a drag within the text area
  While dragging, move the cursor out of the text area
  Other filed no longer get selected by a rubberband

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-inappropriate-rubberband-while-renaming (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26482

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26481: feat(kcm): control scale

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Some backends might not transmit scale information. For these save the scale
  value in the control file on change.
  
  Loading it from there is unproblematic in all three cases:
  
  - No scale value in file. Then falls back to libkscreen's value (default = 1).
  - Scale values are the same, that means backend transmits scale.
  - Backend does not transmit and scale is different, then prefer control file.

REPOSITORY
  R104 KScreen

BRANCH
  scale-control

REVISION DETAIL
  https://phabricator.kde.org/D26481

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/output_model.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 366 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/366/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 06 Jan 2020 20:32:26 +
 Build duration:
3 hr 27 min and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.runners.bookmarks.tests.testChromeBookmarksName: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 101 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/101/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 06 Jan 2020 20:32:25 +
 Build duration:
3 hr 21 min and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26421: Only show full name in review dialog

[Aleix Pol Gonzalez]

apol added a subscriber: jgrulich.
apol added a comment.


  @jgrulich you included that, right? Do you remember why? I can see it's used 
for generating the user hash.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26478: KCM/baloo Display full mount point in list of excluded mount points

[Nathaniel Graham]

ngraham added a comment.


  In D26478#589158 , @meven wrote:
  
  > It would probably be better to exclude squashfs drives from the drives 
indexed by baloo.
  
  
  I agree.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26478

To: meven, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: KRunner add a recentlyused runner accessing KActivityStats data

[Ivan Čukić]

ivan added a comment.


  > Why not change the recentdocuments runner?
  
  Looks fine to me, I just don't see a response to this comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25925: Mark applications that play audio, for all task icon sizes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yes it would. :)
  
  @hein, you good with this now?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25925

To: gvgeo, #vdg, #plasma, ndavis, ngraham
Cc: plasma-devel, hein, ngraham, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven added a comment.


  @hein is it fine for you ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26478: KCM/baloo Display full mount point in list of excluded mount points

[Méven Car]

meven added a comment.


  It would probably be better to exclude squashfs drives from the drives 
indexed by baloo.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26478

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26478: KCM/baloo Display full mount point in list of excluded mount points

[Méven Car]

meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 379516

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26478

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: KRunner add a recentlyused runner accessing KActivityStats data

[Méven Car]

meven added a comment.


  Anyone to review this ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25925: Mark applications that play audio, for all task icon sizes

[George Vogiatzis]

gvgeo added a comment.


  No problem ngraham, was tiny change anyway.
  
  Btw, Vlc would love a follow up patch.
  F7865092: audio icon.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25925

To: gvgeo, #vdg, #plasma, ndavis, ngraham
Cc: plasma-devel, hein, ngraham, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25925: Mark applications that play audio, for all task icon sizes

[George Vogiatzis]

gvgeo updated this revision to Diff 72929.
gvgeo added a comment.
Herald added a subscriber: plasma-devel.


  Removed glow
  Small increase of icon size.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25925?vs=72136=72929

BRANCH
  audio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25925

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, ndavis, ngraham
Cc: plasma-devel, hein, ngraham, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26475: [kstyle] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag added a comment.


  This patch depends on D26457 .

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26475

To: zzag, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26475: [kstyle] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The primary task of a compositor is to take a bunch of buffers from
  different clients and present them on the screen. However, the compositor
  may need to present its own stuff on the screen as well.
  
  On X11, internal clients (the ones created by KWin) are backed by real
  windows. This looks a bit clumsy since KWin uses X11 to communicate with
  itself.
  
  On Wayland, we use our own QPA that talks to KWin directly. Given that
  internal clients with the custom QPA are no longer backed by wayland
  surfaces or x11 windows, things like blur, background contrast, and
  shadows must be set through KWindowSystem APIs so KWin can catch the
  relevant API calls and handle them accordingly.
  
  The good thing is that we get rid of a good portion of platform-specific
  code. The bad thing is that we still need to be cautious about QPAs that
  destroy the underlying platform resources upon a window becoming hidden.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26475

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26476: [kstyle] Remove shadows in Qt 4 style plugin

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand,
  we need to use KWindowSystem to make QWidget-based internal clients in
  KWin cast drop-shadows.
  
  This change drops support for drop-shadows in the Qt 4 style plugin because
  maintaining both platform-dependent and platform-independent way of setting
  shadows on widgets will be troublesome and technically challenging.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26476

AFFECTED FILES
  CMakeLists.txt
  kstyle/CMakeLists.txt
  kstyle/breezeshadowhelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowrenderer.cpp
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 365 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/365/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 06 Jan 2020 19:37:44 +
 Build duration:
3 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 2212 lines...][2020-01-06T19:41:05.133Z]^[2020-01-06T19:41:05.133Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:42:59: note: expanded from macro 'PLASMA_DECL_DEPRECATED_TEXT'[2020-01-06T19:41:05.133Z] #define PLASMA_DECL_DEPRECATED_TEXT(text) __attribute__ ((__deprecated__(text)))[2020-01-06T19:41:05.133Z]   ^[2020-01-06T19:41:05.133Z] [ 25%] Building CXX object libnotificationmanager/CMakeFiles/notificationmanager.dir/jobsmodel.cpp.o[2020-01-06T19:41:06.129Z] 1 warning generated.[2020-01-06T19:41:06.129Z] [ 25%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/consolekit_manager_interface.cpp.o[2020-01-06T19:41:06.129Z] [ 25%] Building CXX object components/containmentlayoutmanager/CMakeFiles/containmentlayoutmanagerplugin.dir/resizehandle.cpp.o[2020-01-06T19:41:06.129Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/libtaskmanager/virtualdesktopinfo.cpp:247:68: warning: unused variable 'desktops' [-Wunused-variable][2020-01-06T19:41:06.129Z] const QList  = virtualDesktopManagement->desktops();[2020-01-06T19:41:06.129Z]^[2020-01-06T19:41:06.411Z] 1 warning generated.[2020-01-06T19:41:06.411Z] [ 25%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/waylandtasksmodel.cpp.o[2020-01-06T19:41:06.986Z] [ 25%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/interactiveconsole/interactiveconsole.cpp.o[2020-01-06T19:41:06.986Z] [ 25%] Building CXX object libnotificationmanager/CMakeFiles/notificationmanager.dir/jobsmodel_p.cpp.o[2020-01-06T19:41:07.952Z] Scanning dependencies of target plasmawindowed[2020-01-06T19:41:07.952Z] [ 25%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowed_autogen/mocs_compilation.cpp.o[2020-01-06T19:41:08.226Z] [ 25%] Linking CXX shared library ../../bin/libcontainmentlayoutmanagerplugin.so[2020-01-06T19:41:08.504Z] [ 25%] Built target containmentlayoutmanagerplugin[2020-01-06T19:41:08.504Z] [ 25%] Building CXX object libnotificationmanager/CMakeFiles/notificationmanager.dir/job.cpp.o[2020-01-06T19:41:08.787Z] [ 25%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/ksmserver_interface.cpp.o[2020-01-06T19:41:09.367Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/components/shellprivate/interactiveconsole/interactiveconsole.cpp:389:21: warning: 'KPluginInfo' is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2020-01-06T19:41:09.367Z] KPluginInfo info(it.value());[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] /usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:5: note: 'KPluginInfo' has been explicitly marked deprecated here[2020-01-06T19:41:09.367Z] KSERVICE_DEPRECATED_VERSION(5, 0, "Use (Q|K)PluginLoader")[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] /usr/home/jenkins/install-prefix/include/KF5/KService/kservice_export.h:143:57: note: expanded from macro 'KSERVICE_DEPRECATED_VERSION'[2020-01-06T19:41:09.367Z] #define KSERVICE_DEPRECATED_VERSION(major, minor, text) KSERVICE_DEPRECATED_VERSION_##major(minor, "Since "#major"."#minor". " text)[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] :53:1: note: expanded from here[2020-01-06T19:41:09.367Z] KSERVICE_DEPRECATED_VERSION_5[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] /usr/home/jenkins/install-prefix/include/KF5/KService/kservice_export.h:142:57: note: expanded from macro 'KSERVICE_DEPRECATED_VERSION_5'[2020-01-06T19:41:09.367Z] #define KSERVICE_DEPRECATED_VERSION_5(minor, text)  KSERVICE_DEPRECATED_VERSION_5_##minor(text)[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] :54:1: note: expanded from here[2020-01-06T19:41:09.367Z] KSERVICE_DEPRECATED_VERSION_5_0[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] /usr/home/jenkins/install-prefix/include/KF5/KService/kservice_export.h:114:49: note: expanded from macro 'KSERVICE_DEPRECATED_VERSION_5_0'[2020-01-06T19:41:09.367Z] #  define KSERVICE_DEPRECATED_VERSION_5_0(text) KSERVICE_DECL_DEPRECATED_TEXT(text)[2020-01-06T19:41:09.367Z] ^[2020-01-06T19:41:09.367Z] /usr/home/jenkins/install-prefix/include/KF5/KService/kservice_export.h:42:61: note: expanded from macro 'KSERVICE_DECL_DEPRECATED_TEXT'[2020-01-06T19:41:09.367Z] #define 

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 100 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/100/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 06 Jan 2020 19:36:54 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 2263 lines...][2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-01-06T19:38:13.328Z]   ^[2020-01-06T19:38:13.328Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 FreeBSDQt5.13/libtaskmanager/tasksmodel.cpp:1671:65: warning: 'child' is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations][2020-01-06T19:38:13.328Z] groupingNewPosIndex = groupingNewPosIndexParent.child(extra, 0);[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qabstractitemmodel.h:71:5: note: 'child' has been explicitly marked deprecated here[2020-01-06T19:38:13.328Z] QT_DEPRECATED_X("Use QAbstractItemModel::index") inline QModelIndex child(int row, int column) const;[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-01-06T19:38:13.328Z]   ^[2020-01-06T19:38:13.328Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 FreeBSDQt5.13/libtaskmanager/tasksmodel.cpp:1821:52: warning: 'child' is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations][2020-01-06T19:38:13.328Z] const QModelIndex  = idx.child(j, 0);[2020-01-06T19:38:13.328Z]^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qabstractitemmodel.h:71:5: note: 'child' has been explicitly marked deprecated here[2020-01-06T19:38:13.328Z] QT_DEPRECATED_X("Use QAbstractItemModel::index") inline QModelIndex child(int row, int column) const;[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-01-06T19:38:13.328Z]   ^[2020-01-06T19:38:13.328Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 FreeBSDQt5.13/libtaskmanager/tasksmodel.cpp:1848:27: warning: 'child' is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations][2020-01-06T19:38:13.328Z] return parent.child(childRow, 0);[2020-01-06T19:38:13.328Z]   ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qabstractitemmodel.h:71:5: note: 'child' has been explicitly marked deprecated here[2020-01-06T19:38:13.328Z] QT_DEPRECATED_X("Use QAbstractItemModel::index") inline QModelIndex child(int row, int column) const;[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-01-06T19:38:13.328Z] ^[2020-01-06T19:38:13.328Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-01-06T19:38:13.328Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-01-06T19:38:13.329Z]   ^[2020-01-06T19:38:13.600Z] [ 30%] Linking CXX executable ../bin/plasmawindowed[2020-01-06T19:38:13.600Z] [ 30%] Linking CXX shared library ../../bin/libkeyboardlayoutplugin.so[2020-01-06T19:38:13.600Z] 

D26474: Fix build with gpsd 3.20

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0c4974d68804: Fix build with gpsd 3.20 (authored by 
arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26474?vs=72919=72921

REVISION DETAIL
  https://phabricator.kde.org/D26474

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, rikmills, #plasma, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich added a comment.


  It requires networkmanager-qt from master (upcoming 5.66 version).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26474: Fix build with gpsd 3.20

[Antonio Rojas]

arojas created this revision.
arojas added reviewers: rikmills, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  gps_data_t.online has changed type from double to struct timespec

TEST PLAN
  Builds with gpsd 3.20 and 3.19

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26474

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, rikmills, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26418: [Applet]Add global mute function

[George Vogiatzis]

gvgeo updated this revision to Diff 72916.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26418?vs=72857=72916

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26418

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo updated this revision to Diff 72915.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26256?vs=72855=72915

BRANCH
  raise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 72914.
gvgeo added a comment.


  Add description check

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26271?vs=72854=72914

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Nathaniel Graham]

ngraham added a comment.


  This no longer compiles for me:
  
/home/nate/kde/src/plasma-nm/libs/handler.cpp: In member function ‘void 
Handler::createHotspot()’:
/home/nate/kde/src/plasma-nm/libs/handler.cpp:622:94: error: 
‘addAndActivateConnection2’ is not a member of ‘NetworkManager’; did you mean 
‘addAndActivateConnection’?
  622 | QDBusPendingReply reply = 
NetworkManager::addAndActivateConnection2(connectionSettings->toMap(), 
wifiDev->uni(), QString(), options);
  | 
 ^
  | 
 addAndActivateConnection

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26241: Remove Kirigami DelegateRecycler

[David Edmundson]

davidedmundson added a comment.


  Sounds like
  
  BUG: 404518
  BUG: 411795
  
  Which we have quite a lot of dupes of :/
  
  We know this bug went away with Qt5.14, so maybe it's worth just merging this 
simple fix. 
  Wait for @notmart, but I say lets merge this into Plasma 5.17.x
  
  +1
  
  
  
  I do have a theory of what's wrong underneath.
  
  ConfigModule owns the QML context. It sets itself as a context property. 
Context properties have to outlive the QML context they are assigned.
  
  ConfigModuleDervied::~ConfigModuledDerived gets run before 
ConfigModule::~ConfigModule() which is where we delete the QML context - which 
means we have a small period of time where a QML accessing a the "kcm" config 
property is in an awkward state. I suspect something about the translations KCM 
shutdown must be triggering a binding re-evaluation at this phase.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26241

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26401: KCM Baloo: Migrate to KConfigXT and add immutability

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in filteredfoldermodel.cpp:59
> Indentation of that line and the previous one looks wrong... but surprisingly 
> the previous line is not showing up as changed, I wonder if that's the review 
> tool acting up.

No I just aligned with the previous "wrong" one

> ervin wrote in kcm.cpp:87
> Why are you updating m_previouslyEnabled again? The old code wasn't doing 
> this AFAICT.

Because we need to update it:

- or we will not have same behavior if we enable / disable it with or without 
closing kcm between the two step

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26401

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26401: KCM Baloo: Migrate to KConfigXT and add immutability

[Benjamin Port]

bport updated this revision to Diff 72907.
bport marked 9 inline comments as done.
bport added a comment.


  Update according to ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26401?vs=72702=72907

REVISION DETAIL
  https://phabricator.kde.org/D26401

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26388: Get rid of KGlobalSettings

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Couldn't even find a reference in kde-workspace / kdelibs  in plasma4 code 
when I went searching...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26388

To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26338: Ensure WM initializes before session starts

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  On the conceptual level, does it make more sense for the relevant client 
(konsole) to monitor for compositing changed itself. It's something that could 
change at runtime regardless, so it needs to react to it anyway?
  If it does need that code anyway, there's no point doing fixes in startkde
  
  
  
  Code wise, this gives a timeout for anyone who doesn't run kwin composited, 
which would be a problem as is.
  
  also I don't like the split that ksmserver is waiting for kwin to register on 
ICE, and startkde is waiting on kwin through a combo of both DBus and X atoms 
in KWindowSystem::compositingActive(). That's 3 different paths all used at 
once.
  
  I've been wanting to move the kwin startup from ksmserver into startkde 
anyway, doing those things together would make the most sense.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26338

To: esjeon, #plasma, davidedmundson
Cc: asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Benjamin Port]

bport updated this revision to Diff 72905.
bport added a comment.


  Check KCMUtils version

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26467?vs=72886=72905

REVISION DETAIL
  https://phabricator.kde.org/D26467

AFFECTED FILES
  kcms/runners/kcm.cpp

To: bport, #plasma, ervin, meven, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26391: DesktopPaths KCM: Remove the moving directory logic

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > it would also leave you stranded in case of an
  
  uncompleted move.
  
  That's actually quite easy to hit if a move causes conflcts and you press 
cancel...I just did so when testing to see if there were any other features 
we'd lose.
  
  Given this codepath once caused widespread dataloss, I'm all for killing it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26391

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  In D26271#588909 , @ngraham wrote:
  
  > Lovely. Any chance we could make the bottom divider touch the edges of the 
window?
  
  
  Not really, not from here. This space is part of system tray. If you use the 
plasma-pa widget only, will see that it touches exactly the edge.
  Bigger negative value  does not show in the system tray, but would make the 
line appear outside the widget if used on desktop.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Lovely. Any chance we could make the bottom divider touch the edges of the 
window?
  
  I suppose we'll need to adjust the Breeze Plasma theme for the changes to the 
tab bar appearance.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26418: [Applet]Add global mute function

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better, thanks.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26418

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26447: Dynamically show and hide based on whether or not any vaults are configured

[Nathaniel Graham]

ngraham added a comment.


  In D26447#588486 , @ivan wrote:
  
  > For some reason, hiding this icon when there are no vaults was deemed 
undesired before. I don't recall why as I think it is a good idea. :)
  >
  > Maybe it was always shown for discoverability purposes... don't know.
  
  
  Probably that, though VDG discussion on the matter was strongly negative on 
the idea of putting more things in the system tray's visible section for 
discoverability purposes.
  
  > Is there a reason why this is a `count` instead of (or in addition to) just 
being `isEmpty` or something similar since the actual count is not used?
  
  It was a smaller code change than adding a new `isEmpty` property, and I 
suppose exposing `count` as a property could be useful in other contexts too.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D26447

To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26462: RFC: Register Secret Agent on startup

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:169d398bfeda: egister Secret Agent on startup (authored 
by davidedmundson).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26462?vs=72874=72892

REVISION DETAIL
  https://phabricator.kde.org/D26462

AFFECTED FILES
  kded/service.cpp

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> DeviceListItem.qml:36
> +var name  = model.data(model.index(i, 0), 
> model.role("Ports"))
> +[model.data(model.index(i, 0), 
> model.role("ActivePortIndex"))].description;
> +var length = Math.min(itemLength, name.length)

if (description)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Kevin Ottens]

ervin added a comment.


  In D26467#588812 , @davidedmundson 
wrote:
  
  > We're entering an awkward part of the Plasma release cycle.
  >
  > Our next beta is in 3 weeks but will depend on the framework that has just 
been tagged.
  >  Any changes entering master, need to be compilable against 5.66 otherwise 
they will have to wait until after Plasma/5.18 branches
  
  
  So ifdefs for cases like this one? Note however that we could go through 
SIGNAL/SLOT macros in that particular case, there'd be a spurious warning on 
5.66 though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26467

To: bport, #plasma, ervin, meven, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26401: KCM Baloo: Migrate to KConfigXT and add immutability

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filteredfoldermodel.cpp:5
>   * Copyright (C) 2019 Tomaz Canabrava 
> - *
> +   Copyright (c) 2020 Benjamin Port 
>   * This library is free software; you can redistribute it and/or

Missing the * and an empty line after that one.

> filteredfoldermodel.cpp:59
> +: QAbstractListModel(parent)
> +, m_settings(settings)
>  {

Indentation of that line and the previous one looks wrong... but surprisingly 
the previous line is not showing up as changed, I wonder if that's the review 
tool acting up.

> filteredfoldermodel.cpp:159
>  }
> -beginResetModel();
> -m_excludeList.append(QUrl(url).toLocalFile());
> -std::sort(std::begin(m_excludeList), std::end(m_excludeList));
> -endResetModel();
> -Q_EMIT folderAdded();
> +auto excluded = m_settings->excludedFolders();
> +excluded.append(QUrl(url).toLocalFile());

Could have been the first line of that method, would avoid retrieving that list 
twice and make the if condition more readable.

> filteredfoldermodel.h:35
>  
> -void setDirectoryList(const QStringList& includeDirs, const QStringList& 
> exclude);
> +void updateDirectoryList();
>  QStringList includeFolders() const;

Declare it as a slot for good measure (although it's technically not really 
necessary).

> kcm.cpp:66
> +connect(m_settings, ::excludedFoldersChanged, this, 
> [this]{ m_filteredFolderModel->updateDirectoryList(); });
> +connect(m_settings, ::foldersChanged, this, [this]{ 
> m_filteredFolderModel->updateDirectoryList(); });
>  }

Why not connect directly to updateDirectoryList in m_filteredFolderModel? Those 
lambdas look unnecessary (besides you'd want m_filteredFolderModel and not this 
as third parameter anyway).

Also you probably want to call updateDirectoryList() once just after those 
connects.

> kcm.cpp:77
> +m_previouslyEnabled = m_settings->indexingEnabled();
> +m_filteredFolderModel->updateDirectoryList();
>  }

I don't think this call is necessary (it's probably because of the missing call 
in the ctor).

> kcm.cpp:87
> +
> +m_previouslyEnabled = m_settings->indexingEnabled();
>  

Why are you updating m_previouslyEnabled again? The old code wasn't doing this 
AFAICT.

> kcm.cpp:116
> +ManagedConfigModule::defaults();
> +m_filteredFolderModel->updateDirectoryList();
>  }

Same thing, I don't think this is necessary. defaults() can likely completely 
go away.

> kcm.cpp:133
> +
> +BalooSettings *ServerConfigModule::balooSettings() const {
> +return m_settings;

The opening curly brace should be on its own line.

> main.qml:49
>  }
> +enabled: !kcm.balooSettings.isImmutable("indexingEnabled")
>  }

nitpick: I'd put enabled before checked

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26401

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26309: feat: replace replication source with logical size API

[Roman Gilg]

romangg updated this revision to Diff 72890.
romangg added a comment.


  - Remove support in Wayland backend
  - Add support in RandR backend

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26309?vs=72428=72890

BRANCH
  logical-size

REVISION DETAIL
  https://phabricator.kde.org/D26309

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrconfig.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  src/output.cpp
  src/output.h

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[David Edmundson]

davidedmundson added a comment.


  We're entering an awkward part of the Plasma release cycle.
  
  Our next beta is in 3 weeks but will depend on the framework that has just 
been tagged.
  Any changes entering master, need to be compilable against 5.66 otherwise 
they will have to wait until after Plasma/5.18 branches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26467

To: bport, #plasma, ervin, meven, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Waiting on D26466  to get in of course.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26467

To: bport, #plasma, ervin, meven, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Méven Car]

meven added a comment.


  Depends on D26466 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26467

To: bport, #plasma, ervin, meven, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, meven, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  connect new signal from KPluginSelector to respect default button state

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26467

AFFECTED FILES
  kcms/runners/kcm.cpp

To: bport, #plasma, ervin, meven, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6b6ae6162457: Runners: Convert foreach to for (authored 
by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26438?vs=72867=72879

REVISION DETAIL
  https://phabricator.kde.org/D26438

AFFECTED FILES
  runners/activities/activityrunner.cpp
  runners/appstream/appstreamrunner.cpp
  runners/bookmarks/bookmarksrunner.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/opera.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/kill/killrunner.cpp
  runners/powerdevil/PowerDevilRunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/services/servicerunner.cpp
  runners/sessions/sessionrunner.cpp
  runners/windowedwidgets/windowedwidgetsrunner.cpp
  runners/windows/windowsrunner.cpp

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

meven added a comment.


  In D26438#588686 , @ivan wrote:
  
  > @meven
  >
  > I hate Qt... defining `operator*` without `operator->` ... ugh
  >
  > I've approved the patch, sorry for the bad nitpick :)
  
  
  No worries, thanks for the review

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  @meven
  
  I hate Qt... defining `operator*` without `operator->` ... ugh
  
  I've approved the patch, sorry for the bad nitpick :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

meven added a comment.


  In D26438#588598 , @ivan wrote:
  
  > @davidedmundson
  >
  > Yes, the wrapper just serves for keyval iterators to be usable with a 
range-based for loop. Quite useful if there are a lot of these. In this case, 
where it is only one loop I agree it might be an overkill.
  
  
  I wish your wrapper was part of Qt directly to avoid boilerplate and give a 
simpler more idimatic way to get a key/value iteration.
  
  > @meven
  > 
  > Just a single nit-pick left :)
  
  You suggestion does not work (or at least QtCreator does not allow me to 
write like you suggested).
  entry here is a `QKeyValueIterator` that needs to be dereferenced using 
`std::pair QKeyValueIterator::operator*()` to get its underlining 
`std::pair`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26451: KCM/Component clean unused file

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7313066401d5: KCM/Component clean unused file (authored 
by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26451?vs=72851=72875

REVISION DETAIL
  https://phabricator.kde.org/D26451

AFFECTED FILES
  kcms/componentchooser/EXAMPLE.desktop

To: meven, ervin, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26462: RFC: Register Secret Agent on startup

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Plasma NM's KDED is loaded on boot, but effectively does nothing until
  the relevant plasmoid triggers the KDED.
  
  This makes some sense for notifications and monitors, as it allows a
  user to opt of a UI plasma network manager experience.
  
  However, we want the secret agent as early in the boot as possible.
  If a user is running NM, they definitely want this component active, and
  if NM isn't running then registering the agent will no-op anyway.
  
  DBus logs show that with this patch, I am retrieving my password and
  a full 1500ms before org.kde.plasmanetworkmanagement.init is called and my 
initial wifi
  connected 3s faster than before this patch.
  
  We could potentially move this kded to phase 0 and get us even earlier.

TEST PLAN
  Had a wifi with security set to "Store password for this user only"
  Added dbus-monitor into my startup scripts
  
  Logged in, wifi connected, logs showed a difference

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26462

AFFECTED FILES
  kded/service.cpp

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Noah Davis]

ndavis added a comment.


  In D26271#588570 , @gvgeo wrote:
  
  > It is a theme problem. Breeze light also has problem.
  >  Widgets take color from Plasma Style. While in applications are fine. 
  >  I checked with this widget   to compare.
  
  
  Interesting. I'll see if I can fix that.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  @davidedmundson
  
  Yes, the wrapper just serves for keyval iterators to be usable with a 
range-based for loop. Quite useful if there are a lot of these. In this case, 
where it is only one loop I agree it might be an overkill.
  
  @meven
  
  Just a single nit-pick left :)

INLINE COMMENTS

> fetchsqlite.cpp:101
> +for (auto entry = bindObjects.constKeyValueBegin(); entry != 
> bindObjects.constKeyValueEnd(); ++entry) {
> +query.bindValue((*entry).first, (*entry).second);
>  //qDebug() << "* Bound " << variableName << " to " << 
> query.boundValue(variableName);

`entry->first` and `entry->second`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  If it isn't possible that's okay (it looks really nice right now, great job 
btw :D), although it'd be nice to make it consistent with the kirigami style 
divider

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26416: Kicker/Documents optimization: Lazily build KFileItem

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build 
KFileItem (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26416?vs=72761=72869

REVISION DETAIL
  https://phabricator.kde.org/D26416

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #frameworks, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor 
that was lost during KConfig XT port (authored by crossi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25843?vs=71183=72868#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25843?vs=71183=72868

REVISION DETAIL
  https://phabricator.kde.org/D25843

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

meven updated this revision to Diff 72867.
meven marked an inline comment as done.
meven added a comment.


  Use a loop over bindObjects.constKeyValueBegin/bindObjects.constKeyValueEnd

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26438?vs=72866=72867

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26438

AFFECTED FILES
  runners/activities/activityrunner.cpp
  runners/appstream/appstreamrunner.cpp
  runners/bookmarks/bookmarksrunner.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/opera.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/kill/killrunner.cpp
  runners/powerdevil/PowerDevilRunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/services/servicerunner.cpp
  runners/sessions/sessionrunner.cpp
  runners/windowedwidgets/windowedwidgetsrunner.cpp
  runners/windows/windowsrunner.cpp

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[David Edmundson]

davidedmundson added a comment.


  We don't need any custom code, it's a QMap, it has existing iterators already 
which can be used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Ivan Čukić]

ivan added a comment.


  Something like this:
  
template 
class asRangeImpl
{
public:
asRange(const T )
: m_data{data}
{
}

auto begin() const { return m_data.keyValueBegin(); }
auto end() const { return m_data.keyValueEnd(); }

private:
const T _data;
};

template 
class asRange(const T& map)
{
return asRangeImpl(map);
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

[Vlad Zahorodnii]

zzag added a comment.


  This patch depends on D26457 .

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26458

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Ivan Čukić]

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in fetchsqlite.cpp:100
> There's an optimisation available here

This can be made much better by providing a custom range object to iterate from 
`keyValueBegin()` to `keyValueEnd()` - converting to `std::map` is quite 
inefficient.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  It is a theme problem. Breeze light also has problem.
  Widgets take color from Plasma Style. While in applications are fine. 
  I checked with this widget   to compare.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

meven updated this revision to Diff 72866.
meven marked an inline comment as done.
meven added a comment.


  Add a ref

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26438?vs=72864=72866

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26438

AFFECTED FILES
  runners/activities/activityrunner.cpp
  runners/appstream/appstreamrunner.cpp
  runners/bookmarks/bookmarksrunner.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/opera.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/kill/killrunner.cpp
  runners/powerdevil/PowerDevilRunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/services/servicerunner.cpp
  runners/sessions/sessionrunner.cpp
  runners/windowedwidgets/windowedwidgetsrunner.cpp
  runners/windows/windowsrunner.cpp

To: meven, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26438: Runners: Convert foreach to for

[Méven Car]

meven updated this revision to Diff 72864.
meven marked an inline comment as done.
meven added a comment.


  Ensure windowList is const, use stdMap to loop over QMap key+value

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26438?vs=72810=72864

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26438

AFFECTED FILES
  runners/activities/activityrunner.cpp
  runners/appstream/appstreamrunner.cpp
  runners/bookmarks/bookmarksrunner.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/opera.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/kill/killrunner.cpp
  runners/powerdevil/PowerDevilRunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/services/servicerunner.cpp
  runners/sessions/sessionrunner.cpp
  runners/windowedwidgets/windowedwidgetsrunner.cpp
  runners/windows/windowsrunner.cpp

To: meven, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26456: KCM runners : fix reset and default behavior

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.


  Might require further work to nail down the "back to defaults" case which is 
not handled by KPluginSelector currently

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26456

To: bport, #plasma, ervin, crossi, meven, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26456: KCM runners : fix reset and default behavior

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, crossi, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26456

AFFECTED FILES
  kcms/runners/kcm.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Noah Davis]

ndavis added a comment.


  Why do the unchecked radiobuttons have a dark outline in your screenshot?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26447: Dynamically show and hide based on whether or not any vaults are configured

[Ivan Čukić]

ivan added a comment.


  For some reason, hiding this icon when there are no vaults was deemed 
undesired before. I don't recall why as I think it is a good idea. :)
  
  Maybe it was always shown for discoverability purposes... don't know.
  
  Is there a reason why this is a `count` instead of (or in addition to) just 
being `isEmpty` or something similar since the actual count is not used?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D26447

To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo marked 5 inline comments as done.
gvgeo added a comment.




REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26418: [Applet]Add global mute function

[George Vogiatzis]

gvgeo updated this revision to Diff 72857.
gvgeo added a comment.


  Cleanup
  Planed changes

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26418?vs=72762=72857

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26418

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo updated this revision to Diff 72855.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26256?vs=72751=72855

BRANCH
  raise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 72854.
gvgeo added a comment.


  leanup
  Remove separation lines
  Fix 2 bugs
  Full Name display when a port name sub-strings are same.
  Requested changes
  
  Issues:
  
  1. Check comment at the bottom of main.qml in D26256 

  
  These two strange margins (including defaultButton in this patch), are 
required to vertical align the icons in their center, and the texts with the 
slider.
  
  2. Setting preferredHeight in fullRepresentation makes widget on desktop to 
load with size >= preferredHeight on boot.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26271?vs=72750=72854

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26451: KCM/Component clean unused file

[Méven Car]

meven created this revision.
meven added reviewers: ervin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Apparently a leftover file.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26451

AFFECTED FILES
  kcms/componentchooser/EXAMPLE.desktop

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26398: [KCM/Activities] Use KConfigXT in ui

[Méven Car]

meven updated this revision to Diff 72850.
meven added a comment.


  Remove unwanted change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26398?vs=72849=72850

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26398

AFFECTED FILES
  kcms/activities/ActivitiesTab.cpp
  kcms/activities/ActivitiesTab.h
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: meven, #plasma, ervin, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26398: [KCM/Activities] Use KConfigXT in ui

[Méven Car]

meven updated this revision to Diff 72849.
meven added a comment.


  KCM/Component clean unused file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26398?vs=72695=72849

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26398

AFFECTED FILES
  kcms/activities/ActivitiesTab.cpp
  kcms/activities/ActivitiesTab.h
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui
  kcms/componentchooser/EXAMPLE.desktop

To: meven, #plasma, ervin, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich added a comment.


  I used ToolButton instead of a regular button, reason is that I don't think 
there is enough space. If there is modem device available, there will be three 
checkboxes on the left and with a regular button in various languages this 
might not be enough space.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

[Kevin Ottens]

ervin updated this revision to Diff 72848.
ervin added a comment.


  Addresses bport comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26389?vs=72677=72848

REVISION DETAIL
  https://phabricator.kde.org/D26389

AFFECTED FILES
  kcms/desktoppaths/CMakeLists.txt
  kcms/desktoppaths/desktoppathssettings.cpp
  kcms/desktoppaths/desktoppathssettings.h
  kcms/desktoppaths/globalpaths.cpp
  kcms/desktoppaths/globalpaths.h

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich updated this revision to Diff 72847.
jgrulich marked an inline comment as done.
jgrulich added a comment.


  Use button instead of checkbox

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26392?vs=72682=72847

BRANCH
  hotspot

REVISION DETAIL
  https://phabricator.kde.org/D26392

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  kcm/kcm.cpp
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/main.qml
  kded/networkmanagement.notifyrc
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> desktoppathssettings.h:2
> +/**
> + *  Copyright 2019 Kevin Ottens 
> + *

2019 => 2020

> desktoppathssettingsbase.kcfg:1
> +
> +http://www.kde.org/standards/kcfg/1.0;

I think we don't need this file

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26389

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart