D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Michail Vourlakos]

mvourlakos added a comment.


  For reference https://en.m.wikipedia.org/wiki/Golden_ratio

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Michail Vourlakos]

mvourlakos added a comment.


  In D27329#611906 , @trmdi wrote:
  
  > How about this?
  >  F8104781: image.png 
  
  
  You can also try the GoldNumber/Ratio that is found in all real nature 
patterns and also at Ancient Greeks in their architectural buildings. That is 
1.618, there is a big chance that it feels right without being able to explain 
why.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  How about this?
  F8104781: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27412: Port away from deprecated API on Qt 5.15.0

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 
(authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27412?vs=75714=75731#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27412?vs=75714=75731

REVISION DETAIL
  https://phabricator.kde.org/D27412

AFFECTED FILES
  src/drkonqidialog.cpp

To: apol, #frameworks, davidedmundson, sitter
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/5/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 15 Feb 2020 00:57:17 +
 Build duration:
3 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 502 lines...][2020-02-15T01:00:57.789Z] [120/149] Automatic MOC for target commenttest[2020-02-15T01:00:57.789Z] [121/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla_duplicates.cpp.obj[2020-02-15T01:00:57.789Z] [122/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:57.789Z] [123/149] Automatic MOC for target bugfieldtest[2020-02-15T01:00:57.789Z] [124/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:57.789Z] [125/149] Automatic MOC for target connectiontest[2020-02-15T01:00:57.789Z] [126/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugfieldtest.dir\bugfieldtest_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:57.789Z] [127/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\parsebugbacktraces.cpp.obj[2020-02-15T01:00:57.789Z] [128/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\connectiontest.dir\connectiontest_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:58.049Z] [129/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\duplicatefinderjob.cpp.obj[2020-02-15T01:00:58.310Z] [130/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\DrKonqiInternal_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:58.571Z] [131/149] Linking CXX static library lib\DrKonqiInternal.lib[2020-02-15T01:00:58.571Z] [132/149] Automatic MOC for target drkonqi[2020-02-15T01:00:58.571Z] [133/149] Building CXX object src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj[2020-02-15T01:00:58.831Z] [134/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugzillatest.dir\bugzillatest.cpp.obj[2020-02-15T01:00:58.831Z] [135/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugfieldtest.dir\bugfieldtest.cpp.obj[2020-02-15T01:00:58.831Z] [136/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\attachmenttest.dir\attachmenttest.cpp.obj[2020-02-15T01:00:58.831Z] [137/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugtest.dir\bugtest.cpp.obj[2020-02-15T01:00:59.092Z] [138/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest.cpp.obj[2020-02-15T01:00:59.092Z] [139/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest.cpp.obj[2020-02-15T01:00:59.092Z] [140/149] Linking CXX executable bin\bugzillatest.exe[2020-02-15T01:00:59.352Z] [141/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\connectiontest.dir\connectiontest.cpp.obj[2020-02-15T01:00:59.352Z] ..\src\bugzillaintegration\libbugzilla\autotests\connectiontest.cpp(52): warning C4101: 'e': unreferenced local variable[2020-02-15T01:00:59.352Z] ..\src\bugzillaintegration\libbugzilla\autotests\connectiontest.cpp(159): warning C4573: the usage of 'QObject::connect' requires the compiler to capture 'this' but the current default capture mode does not allow it[2020-02-15T01:00:59.614Z] [142/149] Linking CXX executable bin\bugfieldtest.exe[2020-02-15T01:00:59.614Z] [143/149] Linking CXX executable bin\bugtest.exe[2020-02-15T01:00:59.614Z] [144/149] Linking CXX executable bin\attachmenttest.exe[2020-02-15T01:00:59.614Z] [145/149] Linking CXX executable bin\producttest.exe[2020-02-15T01:00:59.614Z] [146/149] Linking CXX executable bin\commenttest.exe[2020-02-15T01:00:59.879Z] [147/149] Linking CXX executable bin\connectiontest.exe[2020-02-15T01:01:00.153Z] [148/149] Building CXX object src\CMakeFiles\drkonqi.dir\main.cpp.obj[2020-02-15T01:01:00.412Z] [149/149] Linking CXX executable bin\drkonqi.exe[2020-02-15T01:01:00.412Z] FAILED: bin/drkonqi.exe [2020-02-15T01:01:00.413Z] cmd.exe /C "cd . && C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe -E vs_link_exe --intdir=src\CMakeFiles\drkonqi.dir --manifests  -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo src\CMakeFiles\drkonqi.dir\main.cpp.obj src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj  /out:bin\drkonqi.exe /implib:lib\drkonqi.lib /pdb:bin\drkonqi.pdb /version:0.0  /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL  /subsystem:console  lib\DrKonqiInternal.lib "C:\CI\Software Installs\drkonqi\lib\KF5ConfigWidgets.lib" "C:\CI\Software 

D27418: Don't let the Advanced tab's spacers expand all they want

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:26022caf9a2a: Dont let the Advanced tabs 
spacers expand all they want (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27418?vs=75728=75729

REVISION DETAIL
  https://phabricator.kde.org/D27418

AFFECTED FILES
  src/ui/advancedconfig.ui

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27418: Don't let the Advanced tab's spacers expand all they want

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  `dont-stretch-it`

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  dont-stretch-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27418

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27418: Don't let the Advanced tab's spacers expand all they want

[Nathaniel Graham]

ngraham added a comment.


  probably stable branch

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  dont-stretch-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27418

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27418: Don't let the Advanced tab's spacers expand all they want

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We have 3 vertical spacers in the Advanced tab and their defined as Expanding.
  
  So that means they become quite the gaps if the window is expanded.
  
  This patch changes their size policy to Preffered to avoid such a feature.
  
  BUG: 417657

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  dont-stretch-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27418

AFFECTED FILES
  src/ui/advancedconfig.ui

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27088: [applets/SystemTray] Implement sorting in the model

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: mart.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM but let's make sure one of our model experts (@davidedmundson, @broulik, 
@mart) gets a chance to make sure I'm not smoking crack by approving this. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27088

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-13 00:48, Kai Uwe Broulik wrote:
To minimize potential Frameworks dependency problems I would even go as 
far as put Feature freeze on same date as Frameworks tagging date so 
that no new stuff goes in that could require a Framework change, like 
the wallpaper JPG vs PNG situation.


But did people care about all of this? Nope. We had a wallpaper contest 
that was explicitly scheduled to go in even after the Beta. This is 
unacceptable and next time we do this I will flat out revert a wallpaper 
change after the beta.


I agree, we could have and should have done the wallpaper competition 
earlier. However I'm not aware of any user-visible regressions that 
stemmed from the last-minute shuffle for the wallpaper, which is what 
I'm talking about here. Are you?



Next is this pointless scroll bar visual change. Why did that have to go 
in a day before the Beta, and - surprise - cause problems all over the 
stack which require a bunch of Frameworks fixes?


I agree, that should have been deferred to 5.19. Definitely a lack of 
discipline on our behalf.



Another topic was the KUserFeedback KCM. There had been substantial 
changes also on release date and this is a feature that must be spot-on 
and work 120% from day one. The KNewStuffQuick stuff was a substantial 
change even after Beta freeze...


Like the wallpaper shuffle, I'm not aware of any actual user-visible 
bugs that resulted from this.


In my estimation, the last-minute changes were necessary to get us to 
that 120%, or at least closer than where we were before. Without those 
last-minute kuserfeedback changes, I was worried that the poor 
presentation of what was being transmitted would cause a PR disaster, 
send privacy-conscious people into a panic, and cause other users to 
lose trust in us. As-is, we got one guy on Reddit who wouldn't pipe down 
about it. Without the last-minute changes, I foresaw that times a 
hundred. So at that point it was either introduce last-minute changes or 
punt the whole feature into Plasma 5.19. Which we could have done I 
guess. Maybe we should have. But it seemed like a lot of people really 
wanted it in the LTS release.


And again, nothing actually regressed from that, to my knowledge. What I 
was drawing attention here were regressions and bugs introduced in 
Frameworks that affected people upgrading to Plasma 5.18, such as:


- https://bugs.kde.org/show_bug.cgi?id=417351 [FormLayout positioning 
and width regressions]

- https://bugs.kde.org/show_bug.cgi?id=417127 [Can't turn off Baloo]
- https://bugs.kde.org/show_bug.cgi?id=417511 [Un-maximized dark panels 
have white corners]


Without special point releases or distro packager backporting, LTS users 
could be hitting these issues for years.



Nate

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-13 00:42, Ben Cooksley wrote:

A better way of approaching this would be to freeze the Frameworks
version you are going to require API wise at an earlier point in the
Plasma development cycle. This would allow for a full Frameworks
release cycle to pass where bugs encountered during the lead up to the
Plasma release can be fixed.

This version of Frameworks would then be the one that Plasma hard depends on.


We do this; Plasma 5.18 has a minimum Frameworks dependency of 5.66. See 
https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series


The problem here isn't so much API breaks but rather major bugs and UI 
regressions. if a framework has a very visible bug or UI regression in 
5.66 of the kind that we would really like to fix, but LTS distros 
freeze on that version, then LTS users will be stuck with that issue 
forever unless we make a frameworks point release or cajole distro 
packagers to backport the fix.


Rolling release distro users will first see Plasma 5.18 with Frameworks 
5.67, so if that frameworks version has a major bug or UI regression, it 
will take a month for the fix to land in users' hands whereas if the 
issue were in Plasma itself, we could fix it immediately and users would 
get the fix in a week (the first point release is one week after the .0 
release).


My point is that the schedules just don't really match up if we want to 
present a polished finished product and continue to fix bugs for the 
lifetime of an LTS release.



Nate

D27412: Port away from deprecated API on Qt 5.15.0

[Ömer Fadıl Usta]

usta added a comment.


  isnt this also needs #include 

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

To: apol, #frameworks, davidedmundson, sitter
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Nathaniel Graham]

ngraham added a comment.


  In D26726#610446 , @guilhermesilva 
wrote:
  
  > Hello,
  >
  > I'm the person the reported this issue 
 to the Chromium 
team. The fix they made will probably land only on Chromium 81 or later, but a 
lot of Electron apps will still rely on older versions of Chromium for a long 
time, where this missing cursors issue will still be present, unless they 
upgrade to Plasma 5.18.
  >
  > Speaking of which, I just upgraded to Plasma 5.18 myself, and it looks 
incredible, by the way. And this fix of yours is already present there too, 
which is great. However, I believe you unintentionally missed two CSS cursors: 
`grab`, and `grabbing`, which should be linked to `openhand` and `closedhand`, 
respectively. The rest of cursors are fine and can be tested here:
  >
  > http://elektronotdienst-nuernberg.de/bugs/cursor.html
  >
  > So, it'd be great if you added those too.
  >
  > Thanks!
  
  
  Great, I'm glad you're happy with it!
  
  As you can see here, the change is pretty simple. Would you like to try your 
hand at submitting a patch to add the two missing cursors, modeled on this one?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Re: Plasma 5.18 release post-mortem

[Nate Graham]

Some of the features or large changes that were added to 5.18 but caused 
regressions made it in close to the cut-off, but many were committed 
months ago. In particular 417424, 416695, 416358 were not the result of 
rush jobs, but they got broken anyway.


I don't necessarily disagree though, but if we want to take a firm 
stance on this, I think we need to branch much earlier. "Soft" feature 
freezes don't cut it. We should maybe branch two months before the 
release rather than one.


Also, we can't branch Frameworks due to their inherently rolling nature. 
Some of the regressions were caused by issues in Frameworks (417351, 
417127, 417511). What are we going to do about those? It's not feasible 
to ask people to stop committing potentially risky changes to frameworks 
near a Plasma release because Plasma isn't the only customer of Frameworks.


Nate


On 2020-02-14 01:58, Marco Martin wrote:

On Thu, Feb 13, 2020 at 5:40 PM Nate Graham  wrote:


Plasma 5.18 was a pretty buggy release, and I'd like to start a
discussion about how we think it happened and what we can do better next
time. Here are some of the top bugs that our users are reporting:


I think we wanted to put too much in this release: it's pretty buggy
but also the one that came in with more new features since quite a
while. which in retrospect wasn't that good for an lts

--
Marco Martin

D27365: fix condition in KonsoleProfiles::run

[Alexander Lohnau]

alex added a comment.


  Hello, 
  I have already created a patch for this (and some other improvements) which 
is currently waiting to be reviewed: https://phabricator.kde.org/D27098

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex updated this revision to Diff 75724.
alex added a comment.


  Remove unnecessary include, simplify

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=74853=75724

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27401: [applets/SystemTray] Fix crash on shutdown

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown 
(authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27401?vs=75690=75723

REVISION DETAIL
  https://phabricator.kde.org/D27401

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven added a comment.


  How about you @bport ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

5.19 Kickoff Meeting Thursday 20th at 15:00UTC/16:00CET

[Jonathan Riddell]

Let's have a Kickoff meeting at Thursday 20th at 15:00UTC/16:00CET in
#plasma on freenode or #plasma:kde.org on Matrix.

Agenda will be: review of 5.18, review of dependencies for 5.19, review of
schedule for 5.19, review of workitems for 5.19.  We usually take 2 hours
for these meetings but sometimes manage less.

Jonathan

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  No need to worry. The flip of the toolbar is a small proportion of the patch, 
most of the time I try to solve other problems. And in the end of the line was 
a team decision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Cyril Rossi]

crossi added a comment.


  looks ok to me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27393: [Applet]Fix details layout.

[George Vogiatzis]

gvgeo added a comment.


  > Might be nice to port to ColumnLayout while we're at it
  
  It is not really possible, what makes sense is changing to GridLayout. But 
because is a similar situation with battery's info bug, I don't want to do it 
together with these patches.
  D26806#inline-151955  (Line 
96 in code now)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27393

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27392: [Applet]Add info messages.

[George Vogiatzis]

gvgeo updated this revision to Diff 75721.
gvgeo added a comment.


  Set first label enabled false, and the second specified opacity to 0.6 
instead (it is used as a delay).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27392?vs=75669=75721

BRANCH
  warings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27392

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> meven wrote in componentchooseremail.cpp:154
> I would rather do the opposite the check below is for historical reasons from 
> before my refactoring.

I meant to remove the check below (which I did).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  Sounds like it will provide a complete fix, the update script will fix the 
issue without requiring the user to reset its application style, and this patch 
will ensure it won't come back.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27406: Fix build with Qt 5.15

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:3a5aca82527e: Fix build with Qt 5.15 (authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27406?vs=75707=75718

REVISION DETAIL
  https://phabricator.kde.org/D27406

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> crossi wrote in componentchooseremail.cpp:154
> While you are here, can you had a check on this pointer. I don't understand 
> why there is one below but not here.

I would rather do the opposite the check below is for historical reasons from 
before my refactoring.

> crossi wrote in componentchooserfilemanager.cpp:117
> I would have kept this test that is more clearer than `if (currentIndex() == 
> count() - 1) {}` if you confirm it works the same.

It would test twice the same thing : only the last value in the combobox can 
have an empty currendData.
I'd rather have the same combo accross the CfoPlugin.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Nathaniel Graham]

ngraham added a comment.


  Could we maybe ship a kconfig update script to change the string in the 
config file for people who don't ever change their global theme? Or is the 
problem moot because the global theme gets automatically applied on upgrade or 
something?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham added a comment.


  I'm on Tumbleweed and everything is up to date, but hmm, I see that 
libappstream is still at 0.12.7, not 0.12.10, the current release. I wonder why 
that is.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol added a comment.


  In D27402#611754 , @ngraham wrote:
  
  > Being able to sort search results in different ways is a nice feature for 
sure. But the desire for it arises from dissatisfaction with the default 
"relevance" search results. We might want to still do this, but the pressure 
for it could be reduced if the relevance algorithm returned more relevant 
results.
  
  
  This was supposedly improved on the last libappstream releases. Can you check 
that you're on the last stable release?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27412: Port away from deprecated API on Qt 5.15.0

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Upstream recommends using QLocale for turning dates into strings.

TEST PLAN
  Builds on my system now

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

AFFECTED FILES
  src/drkonqidialog.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham added a comment.


  Being able to sort search results in different ways is a nice feature for 
sure. But the desire for it arises from dissatisfaction with the default 
"relevance" search results. We might want to still do this, but the pressure 
for it could be reduced if the relevance algorithm returned more relevant 
results.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  In D27407#611723 , @ngraham wrote:
  
  > This doesn't fix the problem for me until I actually apply a Global Theme. 
Until I do that, the current widget style remaing un-highlighted in the Style 
KCM. It does fix the issue for that use case though.
  
  
  Yes, it requires to apply Breeze style again, to set widgetStyle to `Breeze` 
in kdeglobals, instead of `breeze`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27411: Port away from deprecated API

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  QComboBox::currentIndexChanged now gets an int and a string

TEST PLAN
  Can build it now on my system

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27411

AFFECTED FILES
  src/screenshotdialog.cpp

To: apol, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Nathaniel Graham]

ngraham added a comment.


  So this is clearly a correct fix, but I'm not sure it's sufficient to fully 
resolve 417515.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Nathaniel Graham]

ngraham added a comment.


  This doesn't fix the problem for me until I actually apply a Global Theme. 
Until I do that, the current widget style remaing un-highlighted in the Style 
KCM. It does fix the issue for that use case though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27406: Fix build with Qt 5.15

[Aleix Pol Gonzalez]

apol updated this revision to Diff 75707.
apol added a comment.


  I am potato

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27406?vs=75697=75707

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27406

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a subscriber: ngraham.
crossi added a comment.


  @ngraham my bad, didn't see your edit ^^

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  currentIndexChanged(int) is reprecated and bound to be removed.

TEST PLAN
  Builds

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27408

AFFECTED FILES
  AuthDialog.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27393: [Applet]Fix details layout.

[Nathaniel Graham]

ngraham added a comment.


  Might be nice to port to `ColumnLayout` while we're at it

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27393

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27390: [GTK3] Fix menubar colours

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:d3e9aa737502: [GTK3] Fix menubar colours (authored by 
cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27390?vs=75655=75700

REVISION DETAIL
  https://phabricator.kde.org/D27390

AFFECTED FILES
  src/gtk3/applications/_chromium.scss

To: cblack, #breeze, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27392: [Applet]Add info messages.

[Nathaniel Graham]

ngraham added a comment.


  Both labels should have `enabled: false` set to lighten the text in a 
consistent way.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27392

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: ervin, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 414885

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

AFFECTED FILES
  lookandfeel/contents/defaults

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  In D27199#611308 , @gvgeo wrote:
  
  > I made 3 smaller patches, to decrease this patch's size. D27391 
 D27392 
 D27393 
  >
  > @ngraham Before I make any change here, can you tell me if you can still 
reproduce the problem, with this diff on **master**?
  >  F8102982: withoutCpp.diff 
  >  It exludes changes in modelitem and C++ in general.
  
  
  Yes, I can still reproduce the issue with this diff applied on top of master. 
HOWECVER! I just noticed that I can reproduce the issue on master right now, 
with no patches. I can't believe I missed this before, sorry!

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27406: Fix build with Qt 5.15

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Doesn't compile, there is no such signal as `currentIndexChanged(int, 
QString)`

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D27406

To: apol, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27406: Fix build with Qt 5.15

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  QComboBox::currentIndexChanged(int) got deprecated.

TEST PLAN
  Builds

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27406

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27394: [applets/notes] Only show configure button when focussed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  stable branch?

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27394

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol added a comment.


  In D27402#611597 , @ngraham wrote:
  
  > When you switch from relevance to something else, that entry *disappears 
entirely* from the menu! That's rather odd. You should be able to return to 
sorting by relevance if you switch to a different sort order and don't like the 
presentation.
  
  
  Right, should. We'd have to keep a copy of every resource which is quite 
dangerous for several reasons and would need a bunch of duplicated code. I'd 
say the question is whether this is an improvement over the status quo or not.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven updated this revision to Diff 75695.
meven marked an inline comment as done.
meven added a comment.


  Clean a redundant check, ensure that if the user cancels selecting a custom 
app, the right entry is selected and hasChanged reflects the state correctly

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27395?vs=75691=75695

BRANCH
  arcpatch-D27384

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  When you switch from relevance to something else, that entry *disappears 
entirely* from the menu! That's rather odd. You should be able to return to 
sorting by relevance if you switch to a different sort order and don't like the 
presentation.

INLINE COMMENTS

> ApplicationsListPage.qml:84
> +ActionGroup.group: sortGroup
> +text: i18n("Relevancy")
> +checkable: true

"Relevance"

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D27398#611564 , @davidedmundson 
wrote:
  
  > >> This patch fixes the issue, but I do still see the sidebar
  >
  > I meant  to phrase that as
  >
  > this patch completes the removal of the code, so that we always show the 
sidebar
  
  
  Gotcha.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We were hiding it because sorting wouldn't work when we have the relevancy 
on, so now we'll disable it when searching something else.
  
  BUG: 399502

TEST PLAN
  Used it, seems to work fine.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27402

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  libdiscover/resources/ResourcesProxyModel.cpp
  libdiscover/resources/ResourcesProxyModel.h

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27397: Align name displayed for wayland session with sddm

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Was fixed by D27358 

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27397

To: meven, ervin, crossi, bport
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

davidedmundson added a comment.


  > I don't get why it would overlap if it's not visible since we're in a 
RowLayout here?
  
  Because the background to the categories view isn't in the categories view. 
  There's some rectangles at the top that don't update. The content is clashing 
with these.
  
  Fixing that would be an alternate solution to the problem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

davidedmundson added a comment.


  >> This patch fixes the issue, but I do still see the sidebar
  
  I meant  to phrase that as
  
  this patch completes the removal of the code, so that we always show the 
sidebar

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27397: Align name displayed for wayland session with sddm

[Nathaniel Graham]

ngraham added a comment.


  Didn't this just get fixed with D27358 ?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27397

To: meven, ervin, crossi, bport
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:154
>  } else {
>  pSettings->setSetting(KEMailSettings::ClientProgram, 
> emailClientService->storageId());
>  pSettings->setSetting(KEMailSettings::ClientTerminal, 
> emailClientService->terminal() ? QStringLiteral("true") : 
> QStringLiteral("false"));

While you are here, can you had a check on this pointer. I don't understand why 
there is one below but not here.

> componentchooserfilemanager.cpp:117
>  const QString storageId = currentData().toString();
> -if (!storageId.isEmpty()) {
> -m_currentIndex = currentIndex();

I would have kept this test that is more clearer than `if (currentIndex() == 
count() - 1) {}` if you confirm it works the same.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  In D27260#611545 , @davidedmundson 
wrote:
  
  > It still sounds like you're saying "we've just made a breaking change in 
frameworks "
  
  
  I mean... yeah. :/ It's kind of a lousy situation since the Frameworks change 
fixed a bug, but regressed this code since we were doing it wrong here in a way 
that isn't compatible with the correct implementation.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> AppletConfiguration.qml:167
>  Layout.fillHeight: true
> -visible: (configDialog.configModel ? 
> configDialog.configModel.count : 0) + globalConfigModel.count > 1
> +visible: true
>  Layout.maximumWidth: units.gridUnit * 7

Can you instead bind this to the count of the three `Repeater`s below? I don't 
get why it would overlap if it's not visible since we're in a `RowLayout` here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Nathaniel Graham]

ngraham added a comment.


  This patch fixes the issue, but I do still see the sidebar with only one 
category in it: F8103697: Screenshot_20200214_073711.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  FWIW, Plasma 5.17 uses PC2, so I have no real objections to this patch in the 
context of this patch. I'm only questioning if that frameworks change is safe, 
given if it is causing changes elsewhere

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven updated this revision to Diff 75691.
meven added a comment.


  standardize how we check if the combobox has a value to save, allow to mark 
the value as changed when there was no value selected at the beginning

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27395?vs=75679=75691

BRANCH
  arcpatch-D27384

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  It still sounds like you're saying "we've just made a breaking change in 
frameworks "

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  @mart, @davidedmundson
  
  So the PC3 ToolButton change just went in anyway via D27396 
. So we now need to fix this somehow or 
else it'll be mega broken looking. If we fix it by landing this patch on 
master, here's how it will look for people who get the frameworks change but 
have to wait 4 months until the next major Plasma version: F8103598: 
Screenshot_20200214_063636.png 
  
  If we land this on the stable branch, here's how it will look for people who 
get the Plasma change but never get the Frameworks change: F8103650: 
Screenshot_20200214_071459.PNG 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27401: [SysterTray] Fix crash on shutdown

[Kai Uwe Broulik]

broulik added a comment.


  Luckily, the change is only in `master` anyway

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27401

To: kmaterka, #plasma_workspaces, #plasma, broulik
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27401: [SysterTray] Fix crash on shutdown

[Anthony Fieroni]

anthonyfieroni added a comment.


  It should target 5.18.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27401

To: kmaterka, #plasma_workspaces, #plasma, broulik
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27401: [SysterTray] Fix crash on shutdown

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  When having expanded System Tray once, plasmashell crashes on teardown.
  
  BUG: 417552
  FIXED-IN: 5.19.0

TEST PLAN
  1. Start plasmashell
  2. Open System Tray popup, close it again
  3. run kquitapp5 plasmashell, it should not crash

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27401

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: kmaterka, #plasma_workspaces, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27358: Sync ("Wayland") appending to match SDDM

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c0fdf0039be4: Sync (Wayland) appending to 
match SDDM (authored by davidedmundson).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27358?vs=75584=75689

REVISION DETAIL
  https://phabricator.kde.org/D27358

AFFECTED FILES
  src/sessionmodel.cpp

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Fonts KCM

[Jonathan Riddell]

The fonts KCM can't apply changes in Plasma 5.18.0.  This will be fixed in
Plasma 5.18.1 next week but it's a popular problem so distros may well want
to patch it out before

https://bugs.kde.org/show_bug.cgi?id=416358

Jonathan

D27381: [sidebar] Resolve changes in module before switching

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:979419d7430d: [sidebar] Resolve changes in module before 
switching (authored by davidedmundson).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27381?vs=75635=75687

REVISION DETAIL
  https://phabricator.kde.org/D27381

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: davidedmundson, #plasma, bport, ngraham
Cc: ngraham, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27386: Set toolbox to invisble when it's invisible

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a48de1efa22: Set toolbox to invisble when its 
hidden (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27386?vs=75647=75683

REVISION DETAIL
  https://phabricator.kde.org/D27386

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27007: [kcm/standardactions] Don't register kcminit hook when we don't have one

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ea7013f17b31: [kcm/standardactions] Dont register 
kcminit hook when we dont have one (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27007?vs=74624=75682

REVISION DETAIL
  https://phabricator.kde.org/D27007

AFFECTED FILES
  kcms/standard_actions/standard_actions.desktop

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There was some broken code to hide the sidebar when we only have one
  module. However at some point it seems half was removed, half wasn't.
  
  This leads to the content overlapping the sidebar frame, but the sidebar 
  was invisible and it looks generally broken.
  
  This patch completes the removal.
  
  BUG: 410770

TEST PLAN
  Opened touchpad KCM
  Saw the one module (keyboard shortcuts)
  Sidebar was visible, and nothing was overlapping

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> bport wrote in componentchooserbrowser.cpp:107
> add a space between -  and 1
> 
> By the way this check seems strange to me, can you confirm it still allow to 
> save custom browser ?

Once the user has added browsers to the list, they appear as before last 
entries.
`insertItem(count() -1, QIcon::fromTheme(icon), service->name(), 
service->storageId())` insert before count() - 1 the custom browser, line 58
The last entry is always "Other", whose index is count() - 1.
So this still allows custom browsers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven updated this revision to Diff 75679.
meven marked an inline comment as done.
meven added a comment.


  Add a space

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27395?vs=75671=75679

BRANCH
  arcpatch-D27384

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27397: Align name displayed for wayland session with sddm

[Méven Car]

meven created this revision.
meven added reviewers: ervin, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 417499
  Since commit 
https://github.com/sddm/sddm/commit/62cd789ff62d7d9c6ef189314f05093b34eaf6ad to 
sddm the behavior of sddm and sddm-kcm splitted.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27397

AFFECTED FILES
  src/sessionmodel.cpp

To: meven, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooserbrowser.cpp:107
>  {
> +if (currentIndex() == count() -1) {
> +// no browser installed, nor selected

add a space between -  and 1

By the way this check seems strange to me, can you confirm it still allow to 
save custom browser ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27393: [Applet]Fix details layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 75674.
gvgeo added a comment.


  Removed empty line.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27393?vs=75673=75674

BRANCH
  details (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27393

AFFECTED FILES
  applet/contents/ui/DetailsText.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27393: [Applet]Fix details layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 75673.
gvgeo added a comment.


  Used Column as root item.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27393?vs=75658=75673

BRANCH
  details (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27393

AFFECTED FILES
  applet/contents/ui/DetailsText.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven created this revision.
meven added reviewers: bport, ervin, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 417276

TEST PLAN
  Have no email client installed.
  In kcm componentchooser
  
  - select another browser
  - Save
  
  Before:
  
  - Crash
  
  After:
  
  - No crash

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27384

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[George Vogiatzis]

gvgeo updated this revision to Diff 75670.
gvgeo edited the summary of this revision.
gvgeo added a comment.


  Changes:
  Added O value and aligned to the right.
  Used Math.round
  Made the plot's topMargin more specific. (Need to alling lines with labels)
  
  About the label workaround:
  It is the complete opposite problem of PlasmaComponents checkboxes, where 
label cannot take implicitHeight.
  Here it always takes implicitHeight with undefined or paintedheight.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27391?vs=75656=75670

BRANCH
  monitor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27391

AFFECTED FILES
  applet/contents/ui/TrafficMonitor.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27392: [Applet]Add info messages.

[George Vogiatzis]

gvgeo updated this revision to Diff 75669.
gvgeo added a comment.


  Made properties readonly.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27392?vs=75657=75669

BRANCH
  warings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27392

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27392: [Applet]Add info messages.

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Toolbar.qml:32
>  
> +property var displayWifiMessage: !wifiSwitchButton.checked && 
> wifiSwitchButton.visible
> +property var displayWwanMessage: !wwanSwitchButton.checked && 
> wwanSwitchButton.visible

Make it `readonly property bool`

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27392

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> TrafficMonitor.qml:40
>  top: parent.top
> -topMargin: Math.round(units.gridUnit / 3) + (index * 
> plotter.height / 5)
> +topMargin: index * plotter.height / 5
>  }

Always `Math.round` when you doing random fractions of sizes

> TrafficMonitor.qml:43
> +// Workaround to get paintedHeight.
> +height: theme.mSize(theme.smallestFont).height
>  font.pointSize: theme.smallestFont.pointSize

You can set it to `undefiend` to reset the height

> TrafficMonitor.qml:61
>  top: parent.top
> -topMargin: units.gridUnit
> +topMargin: theme.mSize(theme.smallestFont).height / 2
>  }

Ideally we didn't randomly divide random sizes

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27391

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27393: [Applet]Fix details layout.

[Kai Uwe Broulik]

broulik added a comment.


  Can we not make the `Column` the root item of the component? Then it should 
propagate the size automatically.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27393

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Re: Plasma 5.18 release post-mortem

[Marco Martin]

On Thu, Feb 13, 2020 at 5:40 PM Nate Graham  wrote:
>
> Plasma 5.18 was a pretty buggy release, and I'd like to start a
> discussion about how we think it happened and what we can do better next
> time. Here are some of the top bugs that our users are reporting:

I think we wanted to put too much in this release: it's pretty buggy
but also the one that came in with more new features since quite a
while. which in retrospect wasn't that good for an lts

--
Marco Martin

D27380: [GTK Config] Write Font without style name

[David Redondo]

davidre added a comment.


  Stretch is in https://doc.qt.io/qt-5/qfont.html#Stretch-enum

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Mikhail Zolotukhin]

gikari added a comment.


  In D27380#611204 , @davidedmundson 
wrote:
  
  > Take this code
  
  
  How about other styles, such as Condensed, Book etc?
  
  F8103081: Screenshot_20200214_114315.png 


REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0c4da0774e43: [KCM Fonts] force need save to false during 
load to avoid state to be true too… (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27384?vs=75639=75668

REVISION DETAIL
  https://phabricator.kde.org/D27384

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27394: [applets/notes] Only show configure button when focussed

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This makes the behaviour of the entire bottom panel consistent with how
  the font buttons currently behave.
  
  BUG: 417608

TEST PLAN
  Focussed widget, button appeared
  Left focus, all buttons disappeared
  Shrinking the widget hid the fonts buttons as expected

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27394

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Cyril Rossi]

crossi accepted this revision.
crossi added a comment.


  I can confirm this fix the issue here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Benjamin Port]

bport added a comment.


  I will look at a proper fix in the next days

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  > In more long term we need to fix ConfigModule do you think is better to do 
a setNeedsSave(false) after loading or emiting signal in all case ?
  
  I think we need something, I've seen some similar report in the nightmode KCM 
about the apply button.
  
  I would personally say the right thing is to remove this line:
  
QMetaObject::invokeMethod(this, "changed", Qt::QueuedConnection, 
Q_ARG(bool, false));
  
  As I don't see what it is trying to do

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Méven Car]

meven accepted this revision.
meven added a comment.


  I can confirm the patch fix the issue.
  
  Tested with
  
[General]
font=Noto Sans,10,-1,5,50,0,0,0,0,0
  
  in `.config/kdeglobals`
  
  With and without the patch, and the apply button now is highlighted when it 
the font setting was changed and the setting is saved and applied on `Apply`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart