D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: VDG, Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add gui for the new `dndToMove` option.
  Depend: D27951 

TEST PLAN
  It writes to `~/.config/kglobals` properly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=354004

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #4 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D27954: appstreamrunner: Port to KApplicationTrader

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appstreamrunner.cpp:102
> +return true;
> +} else {
> +const auto renamedFrom = 
> service->property("X-Flatpak-RenamedFrom").toStringList();

For symmetry I would have removed the "else" altogether, there are many other 
cases of if()+return above already, no need to do things differently here.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27954

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 77473.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27972?vs=77472=77473

REVISION DETAIL
  https://phabricator.kde.org/D27972

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski marked an inline comment as done.
pdabrowski added a comment.


  In D27972#625596 , @zzag wrote:
  
  > > Fix for NightColor plasmoid active/passive status
  >
  > Could you please describe what's wrong with it right now?
  
  
  I wanted the icon to hide when Night Color is not affecting color correction 
(both in timed modes and manual "Always on" mode). Currently the icon is almost 
always visible.
  See updated description.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski marked an inline comment as done.
pdabrowski added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:36-38
> We want to keep the applet visible even if Night Color is inhibited so user 
> can quickly uninhibit it. With this patch, the user would have to click the 
> system tray to show hidden icons and after that click the applet icon to 
> uninhibit Night Color.

> We want to keep the applet visible even if Night Color is inhibited so user 
> can quickly uninhibit it.

You are right. I have modified the patch to show the icon when inhibited in 
timed modes.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 77472.
pdabrowski edited the summary of this revision.
pdabrowski added a comment.


  new patch

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27972?vs=77379=77472

REVISION DETAIL
  https://phabricator.kde.org/D27972

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27954: appstreamrunner: Port to KApplicationTrader

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> dfaure wrote in appstreamrunner.cpp:96
> Note that the original trader query used =~ which meant "case insensitive 
> comparison".
> I have no idea if it was necessary though.

Might have just chosen the wrong operator, it's part of the problem of using a 
weird ad-hoc language I guess.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27954

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27954: appstreamrunner: Port to KApplicationTrader

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77469.
apol added a comment.


  Remove unnecessary check

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27954?vs=77306=77469

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27954

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27954: appstreamrunner: Port to KApplicationTrader

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Cool to see KApplicationTrader being used :-)

INLINE COMMENTS

> appstreamrunner.cpp:96
> +
> +if (service->desktopEntryName() == componentId)
> +return true;

Note that the original trader query used =~ which meant "case insensitive 
comparison".
I have no idea if it was necessary though.

> appstreamrunner.cpp:102
> +return true;
> +} else if 
> (service->propertyNames().contains("X-Flatpak-RenamedFrom")) {
> +const auto renamedFrom = 
> service->property("X-Flatpak-RenamedFrom").toStringList();

This test seems slow and unnecessary.
IMHO you can remove it, and just query for that property, and if it's empty it 
won't contain anything so you'll move ahead to the final return false.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27954

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27996: Fix undefined check in global drawer menu mode

[Nicolas Fella]

nicolasfella marked an inline comment as done.
nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in PageRowGlobalToolBarUI.qml:49
> Wouldn't it be easier to do:
> 
>   visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && 
> applicationWindow().globalDrawer.isMenu
> 
> ?
> 
> Otherwise we better check for the property with `"isMenu" in 
> applicationWindow().globalDrawer`

The former gives `Unable to assign [undefined] to bool`

REPOSITORY
  R169 Kirigami

BRANCH
  fixkamoso

REVISION DETAIL
  https://phabricator.kde.org/D27996

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D27996: Fix undefined check in global drawer menu mode

[Nicolas Fella]

nicolasfella updated this revision to Diff 77465.
nicolasfella added a comment.


  - use 'in'

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27996?vs=77458=77465

BRANCH
  fixkamoso

REVISION DETAIL
  https://phabricator.kde.org/D27996

AFFECTED FILES
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D27996: Fix undefined check in global drawer menu mode

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> PageRowGlobalToolBarUI.qml:49
>  id: menuButton
> -visible: !Kirigami.Settings.isMobile && 
> applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu 
> !== "undefined" && applicationWindow().globalDrawer.isMenu
> +visible: !Kirigami.Settings.isMobile && 
> applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu 
> !== undefined && applicationWindow().globalDrawer.isMenu
>  icon.name: "application-menu"

Wouldn't it be easier to do:

  visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && 
applicationWindow().globalDrawer.isMenu

?

Otherwise we better check for the property with `"isMenu" in 
applicationWindow().globalDrawer`

REPOSITORY
  R169 Kirigami

BRANCH
  fixkamoso

REVISION DETAIL
  https://phabricator.kde.org/D27996

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27996: Fix undefined check in global drawer menu mode

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Hah I was just investigating this the other day but couldn't find it. This 
makes sense.

REPOSITORY
  R169 Kirigami

BRANCH
  fixkamoso

REVISION DETAIL
  https://phabricator.kde.org/D27996

To: nicolasfella, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27996: Fix undefined check in global drawer menu mode

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Kamoso uses Overlaydrawer instead of GlobalDrawer, which has no isMenu 
property
  
  BUG: 417956

TEST PLAN
  Kamoso doesn't have an empty second hamburger button any more

REPOSITORY
  R169 Kirigami

BRANCH
  fixkamoso

REVISION DETAIL
  https://phabricator.kde.org/D27996

AFFECTED FILES
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27917: [Baloo] Fix firstRun and config change logic

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:550cf9cafb19: [Baloo] Fix firstRun and config change 
logic (authored by bruns).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27917?vs=77183=77456

REVISION DETAIL
  https://phabricator.kde.org/D27917

AFFECTED FILES
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: bruns, #baloo, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: [WIP] Add a ShadowedRectangle item

[Marco Martin]

mart added a comment.


  tested it locally, works beautifully

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27985: Include s_kcrashErrorMessage in our traces

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77452.
apol added a comment.


  Include a usage in the test app, adapt to changes in kcrash

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27985?vs=77424=77452

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 77446.
ahiemstra added a comment.


  - Remove QRectF parameter from ShadowedRectNode ctor
  - Properly initialize offset and aspect ratio variables of ShadowedRectNode

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77436=77446

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  For appearance:
  
  F8171055: Peek 2020-03-11 18-28.mp4 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  In D27984#625969 , @cblack wrote:
  
  > Attributes of a shadow (size/radius, offsets)
  
  
  Performance isn't going to be much different between any of these properties, 
except that a few will be slightly faster because they won't need to resize 
geometry.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77442.
ahmadsamir retitled this revision from "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] 
Change how nearestExistingFonts() finds a matching font".
ahmadsamir edited the summary of this revision.
ahmadsamir removed a subscriber: bport.
ahmadsamir added a comment.


  Rebase
  Actually address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77268=77442

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart, bport

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 77436.
ahiemstra added a comment.


  - Convert to SPDX identifiers

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77430=77436

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27985: Include s_kcrashErrorMessage in our traces

[Harald Sitter]

sitter added a comment.


  Probably should also get added to one of the parser tests to make sure it 
doesn't fall on the face.
  
  Talking about parser, I feel like this might benefit from highlighting 
somehow, currently it's very squished in with the random stuff in the header. 
That'll make it hard to search bugzilla for, globally, but also across 
different errors within the same application, as the only identifying element 
is `$1` and I'm sure that's profoundly ambiguous as a search term. Admittedly 
the only way to improve it I can think of is `print "Content of 
s_kcrashErrorMessage:"\nprint s_kcrashErrorMessage\n"`. The fact that this also 
prints empty messages doesn't exactly fill me with joy but I have no input on 
how to improve it either.
  
Application: dragon (dragon), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
$1 = "!!! HALLO THIS IS A MESSAGE !!", '\000' 
[Current thread is 1 (Thread 0x7f255f320880 (LWP 19076))]

Thread 18 (Thread 0x7f250cff9700 (LWP 19093)):
#0  0x7f255628d9f3 in futex_wait_cancelable (private=, 
expected=0, futex_word=0x2544640) at 
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D27985

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: [WIP] Add a ShadowedRectangle item

[Carson Black]

cblack added a comment.


  In D27984#625964 , @ahiemstra 
wrote:
  
  > In D27984#625933 , @cblack wrote:
  >
  > > How does the shadow look and perform when animating?
  >
  >
  > Animating what?
  
  
  Attributes of a shadow (size/radius, offsets)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  In D27984#625933 , @cblack wrote:
  
  > I feel like a border property would be desirable for the following usecases:
  >
  > - Cards that have no elevation when resting
  > - Fallback for when shadows are too heavy
  
  
  The fallback case is not going to be relevant, a border is going to be as 
heavy as the shadow is with this approach. But I'm fine with adding a border, 
also to make it behave more like Rectangle in general.
  
  > How does the shadow look and perform when animating?
  
  Animating what?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra reopened this revision.
ahiemstra added a comment.


  Argh I hate arc

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27979: [WIP] Add top area to notifications

[Nathaniel Graham]

ngraham added a comment.


  In D27979#625943 , @niccolove 
wrote:
  
  > In D27979#625809 , @broulik 
wrote:
  >
  > > Please also test with icons and configure button, I use 
https://tests.peter.sh/notification-generator/ which can generate a multitude 
of test notifications
  >
  >
  > Yepp, I did test it with various notifications.
  >
  > In D27979#625865 , @ngraham 
wrote:
  >
  > > Please test to make sure that your patches work :)
  >
  >
  > I do! But since I was unable to add that class to my local framework
  
  
  If it doesn't work for you, that's a good bet it won't work for other people 
either, which means it can't actually be tested and merged. :) Whatever is 
preventing it from working when you integrate it in the correct way is a bug 
that needs to be fixed so that the patch is testable and merge-able, not 
something you can hack around.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27987: Fix inverse scaling calculation with regards to offset

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27987

AFFECTED FILES
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectanglenode.cpp

To: ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4a2ced7919b5: Add ElevatedRectangle object (authored by 
ahiemstra).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27984?vs=77427=77430#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77427=77430

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/elevatedrectangle.cpp
  src/elevatedrectangle.h
  src/kirigamiplugin.cpp
  src/scenegraph/elevatedrectangle.frag
  src/scenegraph/elevatedrectangle.vert
  src/scenegraph/elevatedrectanglematerial.cpp
  src/scenegraph/elevatedrectanglematerial.h
  src/scenegraph/elevatedrectanglenode.cpp
  src/scenegraph/elevatedrectanglenode.h
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27979: [WIP] Add top area to notifications

[Niccolò Venerandi]

niccolove added a comment.


  In D27979#625809 , @broulik wrote:
  
  > Please also test with icons and configure button, I use 
https://tests.peter.sh/notification-generator/ which can generate a multitude 
of test notifications
  
  
  Yepp, I did test it with various notifications.
  
  In D27979#625865 , @ngraham wrote:
  
  > Please test to make sure that your patches work :)
  
  
  I do! But since I was unable to add that class to my local framework, I 
tested it by putting the PlasmoidHeading in the same folder and using 
"PlasmoidHeading" instead of "PlasmaExtras.PlasmoidHeading". Then I replaced it 
to make the diff, but got the name wrong.
  
  Anyway - the main thing missing in this task is how to avoid broke history - 
do you have any tip on how I could address it?
  F8170937: Screenshot_20200311_173516.png 


INLINE COMMENTS

> ngraham wrote in NotificationItem.qml:119
> there are spaces on this line

I set up Kate to show trailing spaces now, so I should stop putting them 
accidentally.

> broulik wrote in NotificationPopup.qml:168
> You know I'm not a fan of randomly dividing sizes

What should I use? 0 is too small, while the entire margin is too big.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Proposal to centralize KCM bugs inside the systemsettings product

[Nate Graham]

The bugs in those products that affect their KCMs were moved into the 
systemsettings products. fFr print-manager, bugs in the applet were 
moved into plasmashell. Other bugs were not moved. So it it normal that 
there are still bugs in print-manager, plasma-nm, etc; they are bugs 
that don't affect their KCMs.


And your script shouldn't need any adjustments since the new components 
are in systemsettings and plasmashell, which your script already looks at


Nate



On 3/11/20 10:05 AM, Jonathan Riddell wrote:

I still see bugs in e.g.
https://bugs.kde.org/buglist.cgi?component=general_id=1723750=print-manager=---
and
https://bugs.kde.org/buglist.cgi?component=general_id=1723749=plasma-nm=---
so have they been moved?

I use this script to update the Bugzilla products with new versions when 
I make a Plasma release, should I remove the products you mentioned?

https://cgit.kde.org/releaseme.git/tree/plasma/plasma-add-bugzilla-versions

Jonathan

D27984: [WIP] Add a ShadowedRectangle item

[Carson Black]

cblack added a comment.


  I feel like a border property would be desirable for the following usecases:
  
  - Cards that have no elevation when resting
  - Fallback for when shadows are too heavy
  
  How does the shadow look and perform when animating?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 77427.
ahiemstra added a comment.


  - Add a manual test

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77421=77427

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  Yeah I can't upload screenshots etc. through Arc so I always need to upload 
those afterwards.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27984: [WIP] Add a ShadowedRectangle item

[Vlad Zahorodnii]

zzag added a comment.


  Are there any significant differences between shadows that were generated 
using distance fields and shadows that were generated with a blur filter(e.g. 
box blur or stack blur, etc)? (asking out of curiosity)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami
Cc: zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

Re: Proposal to centralize KCM bugs inside the systemsettings product

[Jonathan Riddell]

I still see bugs in e.g.
https://bugs.kde.org/buglist.cgi?component=general_id=1723750=print-manager=---
and
https://bugs.kde.org/buglist.cgi?component=general_id=1723749=plasma-nm=---
so have they been moved?

I use this script to update the Bugzilla products with new versions when I
make a Plasma release, should I remove the products you mentioned?
https://cgit.kde.org/releaseme.git/tree/plasma/plasma-add-bugzilla-versions

Jonathan

Re: Moving bugzilla components

[Nate Graham]

On 3/11/20 9:39 AM, David Edmundson wrote:

It was not sent to this mailing list.

After some searching Kai says it was sent to plasma-bugs, a ml which 
isn't subscribed to directly but used (by me at least) only for bugzilla 
user watching.


Probably explains the lack of response too.

In that case it seems this was merely a communication breakdown and an 
innocent mistake, and I apologise for being frustrated this morning.


Could you forward that thread to plasma-devel so I can read and reply to it

Thanks


Done.

Nate

Fwd: Proposal to centralize KCM bugs inside the systemsettings product

[Nate Graham]

Forwarding to plasma-devel at David Edmundson's request because I 
originally sent this to the wrong mailing lists. Will send future such 
emails to plasma-devel, sorry about that.


FWIW the proposed changes were already made, so this is mostly for 
visibility and record-keeping at this point.


Nate


 Forwarded Message 
Subject: Proposal to centralize KCM bugs inside the systemsettings product
Date: Thu, 27 Feb 2020 07:42:23 -0700
From: Nate Graham 
Organization: kde.org
To: kscreen-bugs-n...@kde.org, jgrul...@redhat.com, now...@gmail.com, 
plasma-b...@kde.org, albertv...@gmail.com, nicolas.fe...@gmx.de, 
bhus...@gmail.com, dantt...@gmail.com


Howdy folks!

Right now most Bugzilla components for KCMs live inside the 
systemsettings product, but there are a small number of exceptions:


- bluedevil | kcm
- kdeconnect | kcm
- kscreen | kcm
- kscreenlocker | kcm
- plasma-pa | kcm
- plasma-nm | kcm
- print-manager | general

I'd like to propose moving these into components of the systemsettings 
product, which would make it easier for bug submitters to file bugs in 
the right place, easier for bug triagers to keep track of System 
Settings bugs, and easier for Plasma developers to notice significant 
issues and regressions in KCMs, since we started a new policy of more 
closely monitoring Plasma bugs, including those filed on the 
systemsettings product.


Nate

D27985: Include s_kcrashErrorMessage in our traces

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  CCBUG: 375913

TEST PLAN
  Called `kill -SIGSEGV plasma-discover` and got to see the string I passed.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27982: use better strings for dri devices

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> ngraham wrote in opengl.cpp:284
> What does "Card" mean in this context? A graphics card?

Relates to D27980 

a card here is a "3D Accelerator" "Card". whatever that means...
It's a graphics card essentially, except, technically not a graphics card, also 
technically not a card, that's just how we enumerate it on a system level. This 
is the mirror term for what we call it in the get_drm_devices_sysfs() variant, 
there it's the verbatim device name card0,card1,card2... while here we don't 
have that (or at least I don't think we have) hence the bespoke 'Card 0', 'Card 
1', 'Card 2' string.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27982

To: sitter
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Moving bugzilla components

[David Edmundson]

On Wed, 11 Mar 2020, 15:05 Nate Graham,  wrote:

> On 3/10/20 11:11 PM, David Edmundson wrote:
> > As a reminder, bugzilla components should not be moved without prior
> > discussion with maintainers.
> >
> > @nate please inform everyone of the bulk changes made and we'll see
> > which we keep.
>
> The last time I performed this kind of Bugzilla maintenance without
> first consulting people, you asked me to do so beforehand, so this time
> I did. See the thread entitled "Proposal to centralize KCM bugs inside
> the systemsettings product". Permission was sought and granted, though a
> few maintainers were silent for 2 weeks, which I interpreted as a lack
> of objection.
>
> If this was insufficient notification, I apologize for the mistake.
>

It was not sent to this mailing list.

After some searching Kai says it was sent to plasma-bugs, a ml which isn't
subscribed to directly but used (by me at least) only for bugzilla user
watching.

Probably explains the lack of response too.

In that case it seems this was merely a communication breakdown and an
innocent mistake, and I apologise for being frustrated this morning.

Could you forward that thread to plasma-devel so I can read and reply to it

Thanks

David

>
> Here is a summary of the changes:
>
> bluedevil | kcm -> systemsettings | kcm_bluetooth
> kdeconnect | kcm-> systemsettings | kcm_kdeconnect
> kscreen | kcm   -> systemsettings | kcm_kscreen
> kscreenlocker | kcm -> systemsettings | kcm_screenlocker
> plasma-pa | kcm -> systemsettings | kcm_pulseaudio
> plasma-nm | kcm -> systemsettings | kcm_networkmanagement
> print-manager | general -> KCM: systemsettings | kcm_printer_manager
> applet: plasmashell | printers
>
>
> On 3/11/20 3:38 AM, Ben Cooksley wrote:
>  > Please also note that bulk changes which are janitorial in nature (as
>  > this sounds like it is) should be performed via Sysadmin ticket, as we
>  > have a way of executing these without causing email notifications to
>  > be sent en-masse to users.
>
> Sure, will do in the future.
>
> Nate
>

D27980: make opengl module support multiple dri devices

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> apol wrote in opengl.cpp:281
> Probably only want to list files?

Dirs actually, e.g. /proc/dri/0/name
I honestly do not know what they are so I figured best to just list everything. 
They could be symlinks for all I know. /proc/dri/ isn't a thing on any of my 
VMs :|

> apol wrote in opengl.cpp:303
> Use QStandardPaths::findExecutable?

I agree. Not really related though.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27979: [WIP] Add top area to notifications

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Please test to make sure that your patches work :)

INLINE COMMENTS

> NotificationItem.qml:114
>  
> -NotificationHeader {
> -id: notificationHeading
> -Layout.fillWidth: true
> +PlasmaExtraComponents.PlasmoidHeading {
> +bottomInset: Math.round(thumbnailTopPadding / 2)

there's no such thing as `PlasmaExtraComponents`

> NotificationItem.qml:119
>  Layout.rightMargin: notificationItem.headingRightPadding
> +
> +NotificationHeader {

there are spaces on this line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a ShadowedRectangle item, which is a rectangle with a shadow.
  It uses a custom shader that draws the rectangle and the shadow below it
  using distance fields, which has significantly better performance compared
  to the DropShadow effect.
  
  This is a first step to moving more of AbstractCard and related items to
  C++ code. Other bits will include a ShadowedImage item and moving actual
  card code to C++.

TEST PLAN
  TBD

REPOSITORY
  R169 Kirigami

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27980: make opengl module support multiple dri devices

[Vlad Zahorodnii]

zzag added a comment.


  I'm not sure whether this is useful, but libdrm has an API to enumerate 
devices.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol added subscribers: adridg, apol.
apol added a comment.


  +1 overall

INLINE COMMENTS

> opengl.cpp:278
> +
> +static QList get_dri_devices_proc()
>  {

I'd make it QVector, less to worry in the future.

> opengl.cpp:281
> +QList list;
> +const auto entries = QDir(QStringLiteral("/proc/dri/")).entryList();
> +for (const auto  : entries) {

Probably only want to list files?

> opengl.cpp:303
> +int num = 0;
> +if (((num = ReadPipe(cmd, pci_info)) ||
> + (num = ReadPipe("/sbin/"+cmd, pci_info)) ||

Use QStandardPaths::findExecutable?

> opengl.cpp:334
> +QList list;
>   QStringList pci_info;
> +if (ReadPipe("sysctl -n hw.dri.0.name", pci_info)) {

Indentation looks off

> opengl.cpp:335
>   QStringList pci_info;
> - if (ReadPipe("sysctl -n hw.dri.0.name",pci_info)) {
> - dri_info.module = pci_info[0].mid(0, pci_info[0].indexOf(0x20));
> - }
> - return false;
> +if (ReadPipe("sysctl -n hw.dri.0.name", pci_info)) {
> +DriInfo info{};

Probably want to list them all on BSD too, right @adridg?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27982: use better strings for dri devices

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> opengl.cpp:284
>  auto info = get_dri_device_proc(QStringLiteral("/proc/dri/") + entry 
> + QStringLiteral("/name"));
> -info.deviceId = entry;
> +info.deviceId = i18nc("%1 is a DRI card index integer", "Card %1", 
> entry);
>  if (info.isValid()) {

What does "Card" mean in this context? A graphics card?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27982

To: sitter
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27979: Added top area to notifications

[Kai Uwe Broulik]

broulik added a comment.


  Please also test with icons and configure button, I use 
https://tests.peter.sh/notification-generator/ which can generate a multitude 
of test notifications

INLINE COMMENTS

> NotificationPopup.qml:168
>  // let the item bleed into the dialog margins so the close 
> button margins cancel out
> -y: closable || dismissable || configurable ? 
> -notificationPopup.margins.top : 0
> +y: closable || dismissable || configurable ? 
> -math.round(notificationPopup.margins.top / 2) : 0
>  headingRightPadding: -notificationPopup.margins.right

You know I'm not a fan of randomly dividing sizes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Moving bugzilla components

[Nate Graham]

On 3/10/20 11:11 PM, David Edmundson wrote:
As a reminder, bugzilla components should not be moved without prior 
discussion with maintainers.


@nate please inform everyone of the bulk changes made and we'll see 
which we keep.


The last time I performed this kind of Bugzilla maintenance without 
first consulting people, you asked me to do so beforehand, so this time 
I did. See the thread entitled "Proposal to centralize KCM bugs inside 
the systemsettings product". Permission was sought and granted, though a 
few maintainers were silent for 2 weeks, which I interpreted as a lack 
of objection.


If this was insufficient notification, I apologize for the mistake.

Here is a summary of the changes:

bluedevil | kcm -> systemsettings | kcm_bluetooth
kdeconnect | kcm-> systemsettings | kcm_kdeconnect
kscreen | kcm   -> systemsettings | kcm_kscreen
kscreenlocker | kcm -> systemsettings | kcm_screenlocker
plasma-pa | kcm -> systemsettings | kcm_pulseaudio
plasma-nm | kcm -> systemsettings | kcm_networkmanagement
print-manager | general -> KCM: systemsettings | kcm_printer_manager
   applet: plasmashell | printers


On 3/11/20 3:38 AM, Ben Cooksley wrote:
> Please also note that bulk changes which are janitorial in nature (as
> this sounds like it is) should be performed via Sysadmin ticket, as we
> have a way of executing these without causing email notifications to
> be sent en-masse to users.

Sure, will do in the future.

Nate

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77416.
niccolove added a comment.


  Trailing spaces

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77412=77416

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27981: strip non prtinable characters from opengl dri info

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously this was incorrectly indented
  
  was
  
  | Vendor | \s\s\s\s\s\s\s\sFoobar |
  |
  
  is now
  
  | Vendor | Foobar |

TEST PLAN
  with D27980  applied the kernel module 
doesn't stick out anymore as now all strings are uniformly simplified and have 
no unexpected indentation

REPOSITORY
  R102 KInfoCenter

BRANCH
  multidri-simplified

REVISION DETAIL
  https://phabricator.kde.org/D27981

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27982: use better strings for dri devices

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the /proc based fallback was using the raw entry name (number) to
  avoid a new string in 5.18.
  
  the Accelerator grouping entry avoided plural mutation for 5.18.

TEST PLAN
  hoping for the best!

REPOSITORY
  R102 KInfoCenter

BRANCH
  multidri-simplified-master

REVISION DETAIL
  https://phabricator.kde.org/D27982

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77412.
niccolove added a comment.


  Third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77411=77412

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27980: make opengl module support multiple dri devices

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously the code would only ever look at dri0 when that may not actually
  be the device that is used. instead list all possible devices (I am
  assuming in nvidia/intel combos the actual computations may happen on any
  of them depending on configuration).
  as a side effect we can no longer list a single kernel module but instead
  list the module per-device.
  the devices use cardN names on linux.
  for the /proc based fallback we do not use cardN but simply N (to be
  improved in master with localized string).
  
  on freebsd we continue to only support one device, in part because I have
  no way to test multi-device support. the info is woefully underwhelming and
  could as well not be there anyway TBH.
  
  BUG: 417986
  FIXED-IN: 5.18.4

TEST PLAN
  vm with 3 cards show all of them with suitable info

REPOSITORY
  R102 KInfoCenter

BRANCH
  multidri

REVISION DETAIL
  https://phabricator.kde.org/D27980

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77411.
niccolove added a comment.


  Second try of getting rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77410=77411

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77410.
niccolove added a comment.


  Trying to get rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77409=77410

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77409.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76823=77409

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove added a comment.


  Opened another one due to i-messed-up-arc-again: 
https://phabricator.kde.org/D27979

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27979: Added top area to notifications

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added the new PlasmoidHeading component to notifications, see:
  (...)
  This also adds it to the notifications in the history, which is not wanted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_toparea

REVISION DETAIL
  https://phabricator.kde.org/D27979

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27978: [FormLayout] Propagate FormData.enabled also to label

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to mark the section as disabled even when the control itself is not, 
e.g. when you have a `RowLayout` and don't want to disable the entire row.

TEST PLAN
  In the following example I don't want the `BusyIndicator` disabled but still 
have the rest of the row (the label *and* its section label) disabled.
  
Kirigami.FormLayout {
RowLayout {
Kirigami.FormData.label: "Foo"
Kirigami.FormData.enabled: !something.busy

QQC2.CheckBox {
text: "Enabled"
enabled: !something.busy
}

QQC2.BusyIndicator {
running: something.busy
visible: running
}
}
}

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27978

AFFECTED FILES
  src/controls/FormLayout.qml

To: broulik, #plasma
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:2bae103fa66e: [Cuttleffish] Use proper 
QSortFilterProxyModel (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27421?vs=77171=77399#toc

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27421?vs=77171=77399

REVISION DETAIL
  https://phabricator.kde.org/D27421

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/autotests/iconmodeltest.cpp
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp
  cuttlefish/src/sortfiltermodel.cpp
  cuttlefish/src/sortfiltermodel.h

To: davidre, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Re: Proposal: Dynamic Wallpapers in Plasma

[Vlad Zahorodnii]

On 3/11/20 10:45 AM, Kai Uwe Broulik wrote:
It appears there's a need for a collection/dict API in QImageReader 
either way.


Uh, maybe. At least, applications such as Gwenview need to know the 
difference between image sequences and image collections in order to 
display them correctly.


Cheers,
Vlad

Re: Moving bugzilla components

[Ben Cooksley]

On Wed, Mar 11, 2020 at 6:12 PM David Edmundson
 wrote:
>
> As a reminder, bugzilla components should not be moved without prior 
> discussion with maintainers.
>
> @nate please inform everyone of the bulk changes made and we'll see which we 
> keep.

Please also note that bulk changes which are janitorial in nature (as
this sounds like it is) should be performed via Sysadmin ticket, as we
have a way of executing these without causing email notifications to
be sent en-masse to users.

>
> David

Cheers,
Ben

Re: Proposal: Dynamic Wallpapers in Plasma

[Kai Uwe Broulik]

Hi,

According to Qt documentation, if QImageReader::imageCount() returns a 
positive number, it means that the file contains an animated image.


And that isn't even true. An ICO (windows icon file) has all its 
contained pixmap sizes and depths as a flat list. E.g. in the windows 
icon thumbnailer I iterate all icons to find the one with highest color 
depth and best fitting size.


It appears there's a need for a collection/dict API in QImageReader 
either way.


> As far as I know, GIMP just shows a dialog with all images and you 
just pick the one you want to edit.


At least with ICO just dumps all pixmaps into different layers of the 
same canvas.


In any case, if ICO abuses QImageReader "sequential API" I don't see why 
HEIF couldn't :)


Cheers
Kai Uwe

Re: Proposal: Dynamic Wallpapers in Plasma

[Vlad Zahorodnii]

On 3/11/20 8:08 AM, David Edmundson wrote:
We need to tweak the name as we have many wallpapers that are dynamic. 
This is a specific subset within that.


Yes, agreed! I'm open to suggestions. ;-)

Code wise, we have both sun positions and clock skew management in the 
time dataengine already.


Does the dataengine allow to query position of the Sun at some specified 
time?


I'm fine for things becoming public qml plugins instead of dataengines 
using that code, porting the existing clocks and deprecating the 
dataengine, but we want to avoid duplication of active code.


Yes, this seems quite reasonable.


What do you need that you can't do as a sequence?


My biggest concern is that they are semantically different. An image 
sequence is just a plain animation, while an image collection is a bunch 
of images that are stored in one file.


According to Qt documentation, if QImageReader::imageCount() returns a 
positive number, it means that the file contains an animated image.


Let's break it down from the user's perspective. If you open a file with 
an image sequence, you should see some silly animation. On the other 
hand, if you open a file with an image collection, you should see the 
primary image and have some way to browse through images in the file, 
for example, a sidebar where you can select an image. As far as I know, 
GIMP just shows a dialog with all images and you just pick the one you 
want to edit.


In order to read an image collection, we just need to know how many 
images are stored in a file, jumpToImage() and read(), so maybe Qt folks 
could adjust documentation for the QImageReader class. I'm not sure 
whether that is doable, though.


Cheers,
Vlad

D27915: Use breeze icons for categories

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a6e8f3bc52a: Use breeze icons for categories (authored 
by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27915?vs=77174=77392

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> main.qml:36-38
> -if (inhibitor.state != Inhibitor.Uninhibited) {
> -return PlasmaCore.Types.ActiveStatus;
>  }

We want to keep the applet visible even if Night Color is inhibited so user can 
quickly uninhibit it. With this patch, the user would have to click the system 
tray to show hidden icons and after that click the applet icon to uninhibit 
Night Color.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Vlad Zahorodnii]

zzag added a comment.


  > Fix for NightColor plasmoid active/passive status
  
  Could you please describe what's wrong with it right now?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Moving bugzilla components

[Vlad Zahorodnii]

On 3/11/20 7:11 AM, David Edmundson wrote:
As a reminder, bugzilla components should not be moved without prior 
discussion with maintainers.


@nate please inform everyone of the bulk changes made and we'll see 
which we keep.


David


What components were moved?

Re: Proposal: Dynamic Wallpapers in Plasma

[David Edmundson]

We need to tweak the name as we have many wallpapers that are dynamic. This
is a specific subset within that.

Code wise, we have both sun positions and clock skew management in the time
dataengine already.

I'm fine for things becoming public qml plugins instead of dataengines
using that code, porting the existing clocks and deprecating the
dataengine, but we want to avoid duplication of active code.

>QImageReader class can't be used to read image collections

What do you need that you can't do as a sequence?