D28306: [applets/taskmanager] Make the hover state clarifying, but not main

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:488c4b746d68: [applets/taskmanager] Make the hover state 
clarifying, but not main (authored by epopov, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78599=78609

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78605.
apol added a comment.


  Don't leak

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78604=78605

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78604.
apol marked 3 inline comments as done.
apol added a comment.


  Rebase on top of ksyntaxhighlighting, works great

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78117=78604

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Eugene Popov]

epopov updated this revision to Diff 78599.
epopov added a comment.


  Fix hover state for pinned launchers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78580=78599

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  WIP because of the TODOs at the top of the file in `DeviceItem.qml`. 
Assistance with
  these would be appreciated.

TEST PLAN
  The only major UI change is the loss of the progress bar. It is replaced with 
a textual
  display of free space and total space in the subtitle, which is more 
consistent with the
  appearance of other ExpandableListItem-using applets, and IMO is more useful 
anyway.
  
  F8200390: vokoscreenNG-2020-03-26_15-16-38.webm 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Carson Black]

cblack updated this revision to Diff 78590.
cblack added a comment.


  Drop giomm

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77833=78590

BRANCH
  arcpatch-D28086

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28318: [controls/formlayout] Don't attempt to reset implicitWidth

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9b6ec041936a: [controls/formlayout] Dont attempt to 
reset implicitWidth (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28318?vs=78585=78589

REVISION DETAIL
  https://phabricator.kde.org/D28318

AFFECTED FILES
  src/controls/FormLayout.qml

To: cblack, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28306: Make the hover state clarifying, but not main

[Nathaniel Graham]

ngraham added a comment.


  This does introduce a visual change: the hover effect now adds a blue 
background, even for un-launched pinned launchers. Currently the hover effect 
for pinned launchers is just a lightening of the icon itself.
  
  I'm not against it, but this is a visual change that must be discussed; this 
isn't just a bugfix or code cleanup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28318: [controls/formlayout] Don't attempt to reset implicitWidth

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  When a FormLayout is in wide mode, it attempts to
  reset the implicitWidth of a GridLayout by assigning undefined to it.
  This doesn't work because:
  
  1. Layouts provide their own implicit width
  2. You can't reset an implicit size with undefined, hence the error messages 
obtained from trying to do so

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/formlayout-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28318

AFFECTED FILES
  src/controls/FormLayout.qml

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adjusts the default Breeze color scheme to produce the final Tools 
Area
  appearance proposed in T10201 . The 
titlebar background color is darkened a bit, and the
  titlebar gradient is turned off by default.
  
  Depends on D27669 

TEST PLAN
  Kate: F8200278: Kate.png 
  
  File dialog: F8200280: File dialog.png 
  
  Plasma config window: F8200280: File dialog.png 

  
  (more images to come)

REPOSITORY
  R31 Breeze

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  kdecoration/breezesettingsdata.kcfg

To: ngraham, #vdg, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28316: Add useful input method hints to password field by default

[Johan Ouwerkerk]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c9bbe6dea5a1: Add useful input method hints to password 
field by default (authored by ouwerkerk).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28316?vs=78579=78582

REVISION DETAIL
  https://phabricator.kde.org/D28316

AFFECTED FILES
  src/controls/PasswordField.qml

To: ouwerkerk, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Can can confirm. Toolbars are no longer considered to be a part of the Tools 
area in all apps with the latest version of the patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28316: Add useful input method hints to password field by default

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent idea!

REPOSITORY
  R169 Kirigami

BRANCH
  fix-password-field-input-hints

REVISION DETAIL
  https://phabricator.kde.org/D28316

To: ouwerkerk, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27669: [kstyle] Tools area

[Abstract Software]

abstractdevelop added a comment.


  For me it only merges the menus with the window decoration, not the toolbar :/
  F8200218: QtAssistantToolbars.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Eugene Popov]

epopov marked 2 inline comments as done.
epopov added inline comments.

INLINE COMMENTS

> broulik wrote in Task.qml:331
> We can use ECMAScript 6 now, use spread syntax:
> 
>   return [
>   ...TaskTools.taskPrefix(etc),
>   ...foo,
>   ...bar
>   ];
> 
> Note the `...`

TaskTools.taskPrefix(...) returns an array, so it will be an array-of-arrays

> broulik wrote in Task.qml:331
> We can use ECMAScript 6 now, use spread syntax:
> 
>   return [
>   ...TaskTools.taskPrefix(etc),
>   ...foo,
>   ...bar
>   ];
> 
> Note the `...`

Ah, now I understand. It looks amazing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Eugene Popov]

epopov updated this revision to Diff 78580.
epopov added a comment.


  Use ES6 spread syntax 

 instead of Array.concat()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78568=78580

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28316: Add useful input method hints to password field by default

[Johan Ouwerkerk]

ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.

REVISION SUMMARY
  Hint that input methods should treat the password as sensitive and avoid
  applying "auto-correct" features as well.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-password-field-input-hints

REVISION DETAIL
  https://phabricator.kde.org/D28316

AFFECTED FILES
  src/controls/PasswordField.qml

To: ouwerkerk
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

[Méven Car]

meven added a comment.


  Seems good to me 
  @bport should be the best reviewer here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 647 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/647/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Mar 2020 15:51:54 +
 Build duration:
1 hr 18 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 108 test(s), Skipped: 0 test(s), Total: 108 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)58%
(322/560)58%
(322/560)43%
(31564/74187)32%
(14325/44344)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(130/151)86%
(130/151)65%
(19518/30018)51%
(9976/19705)colorcorrection100%
(7/7)100%
(7/7)79%
(672/855)59%
(238/401)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(443/562)65%
(140/216)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(79/970)3%
(29/894)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/233)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(46/657)1%
(5/552)effects.glide67%
(2/3)67%
(2/3)72%
(150/208)65%
(60/93)effects.highlightwindow100%
(2/2)100%
(2/2)40%
   

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78577.
cblack added a comment.


  Don't include toolbars in MDI/dock widgets for the tools area calculation

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78572=78577

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  two videos showing the performance regression (on the left current breeze, on 
the right with this patch applied)
  F8200103: breeze.webm  F8200105: 
toolarea.webm 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  With the latest version of the patch, I still see this hilarious visual bug: 
F8200104: vokoscreenNG-2020-03-26_10-37-25.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Yes, the decoration theme determines its own border value. For Breeze it's 
"No borders", but we can't assume that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#635285 , @davidre wrote:
  
  > In D27669#635243 , @cblack wrote:
  >
  > > Assume there's no borders when there's not a BorderSize entry
  >
  >
  > That's totally not correct. The default value when there's no BorderSize 
entry is "Normal" . This patch is now also enabled when the user manually 
selects "Normal". The correct thing is to check  first whether `BorderSizeAuto` 
is enabled (default true) . If it's not enabled you can read `BorderSize` 
(default "Normal") otherwise check what the preference the decoration sets. I 
didn't check yet where that value is defined
  
  
  Took a look: it's not defined anywhere; it's up to the decorations to do 
whatever they feel like.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  In D27669#635243 , @cblack wrote:
  
  > Assume there's no borders when there's not a BorderSize entry
  
  
  That's totally not correct. The default value when there's no BorderSize 
entry is "Normal" . This patch is now also enabled when the user manually 
selects "Normal". The correct thing is to check  first whether `BorderSizeAuto` 
is enabled (default true) . If it's not enabled you can read `BorderSize` 
(default "Normal") otherwise check what the preference the decoration sets. I 
didn't check yet where that value is defined

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "corners" grouped property that allows setting separate radii for
  the different corners of ShadowedRectangle. By default, these are ignored and
  instead the value of "radius" is used.

TEST PLAN
  The manual test has been updated, it should look like this:

REPOSITORY
  R169 Kirigami

BRANCH
  shadowedrect_separatecorners

REVISION DETAIL
  https://phabricator.kde.org/D28314

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78574.
ahiemstra added a comment.


  - Update test

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28314?vs=78573=78574

BRANCH
  shadowedrect_separatecorners

REVISION DETAIL
  https://phabricator.kde.org/D28314

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78572.
cblack marked an inline comment as done.
cblack added a comment.


  Fix error

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78567=78572

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1687
> +while (parent != nullptr) {
> +if (qobject_cast(widget) || qobject_cast QDockWidget*>(widget)) {
> +return false;

mmm shouldn't you test on parent rather than widget here ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Eugene Popov]

epopov updated this revision to Diff 78568.
epopov added a comment.


  Create a new function in TasksTools to make the code more readable.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78540=78568

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28297: KCM/touchpad: Disables the middleEmulation when not supported

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:73f3855ed3c5: KCM/touchpad: Disables the middleEmulation 
when not supported (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28297?vs=78524=78569

REVISION DETAIL
  https://phabricator.kde.org/D28297

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/touchpad.qml

To: meven, #plasma, ervin, bport, crossi, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78567.
cblack added a comment.


  Assume there's no borders when there's not a BorderSize entry

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78565=78567

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28296: KCM/Mouse: fix the middleEmulation checkbox status

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fb86174858b5: KCM/Mouse: fix the middleEmulation checkbox 
status (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28296?vs=78523=78566

REVISION DETAIL
  https://phabricator.kde.org/D28296

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: meven, #plasma, ervin, bport, crossi, hchain, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78565.
cblack added a comment.


  Account for the applications that think it's semantically correct to put a 
main window in a dock widget

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78505=78565

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 26 Mar 2020 15:51:54 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 10 test(s), Passed: 98 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testModiferOnlyShortcutFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 5 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

D28289: Refactor of OverlaySheet

[Nathaniel Graham]

ngraham added a comment.


  Generally much nicer looking. I found one visual issue: when I switch from 
touchpad scrolling to touchscreen scrolling, the close button in the corner 
gets overlapped by the content area since the scroll track gets narrower.

INLINE COMMENTS

> OverlaySheet.qml:24
>  background: DefaultCardBackground {
> -anchors.fill: parent
> +   // anchors.fill: parent
>  }

Remove commented code

> OverlaySheet.qml:4
> - *
> - *  SPDX-License-Identifier: LGPL-2.0-or-later
> - */

Is this intentional?

> OverlaySheet.qml:278
> +: outerFlickable.contentHeight - outerFlickable.height + 
> outerFlickable.topEmptyArea + headerItem.height + footerItem.height
> +duration: Units.longDuration*10
> +easing.type: Easing.OutQuad

I thought we weren't supposed to multiply duration values. :) is the new 
`veryLongDuration` not long enough? do we need `superDuperLongDuration`?

> OverlaySheet.qml:363
> +bottomMargin: height
> +contentHeight: Math.max(height+1, 
> scrollView.flickableItem.contentHeight + topEmptyArea)
> +

what's this `+1` for?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28289

To: mart, #kirigami
Cc: anthonyfieroni, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart

D28296: KCM/Mouse: fix the middleEmulation checkbox status

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  stable branch

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse-middleEmulation

REVISION DETAIL
  https://phabricator.kde.org/D28296

To: meven, #plasma, ervin, bport, crossi, hchain, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from 
shown/hidden list when disabling entry (authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28311?vs=78561=78563#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28311?vs=78561=78563

REVISION DETAIL
  https://phabricator.kde.org/D28311

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: nicolasfella, #plasma, kmaterka, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#634903 , @davidre wrote:
  
  > - Why are we drawing a separator if the window has no toolbar?
  
  
  Because this looks really good :)
  
  F821: vokoscreenNG-2020-03-26_09-46-28.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Can confirm, if I override the default border setting and change it to "no 
borders", the appearance looks right again. So I guess we need to handle cases 
where the window decoration theme's default border setting is "no borders".
  
  It might also be nice to mention in the config UI that the appearance change 
only takes effect when using No Borders. The text could be something like 
"Visually merge toolbars and menubars into window titlebar when using no window 
borders"

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ConfigEntries.qml:226
>  case "disabled":
>  if (extraIndex > -1) {
>  cfg_extraItems.splice(extraIndex, 1)

Keep the order consistent with the cases above: shown, hidden, extra

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systrayhidden

REVISION DETAIL
  https://phabricator.kde.org/D28311

To: nicolasfella, #plasma, kmaterka, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI 
will display it as shown instead of disabled.
  
  BUG: 419197

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systrayhidden

REVISION DETAIL
  https://phabricator.kde.org/D28311

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: nicolasfella, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Task.qml:331
> this is a bit longwinded, can we make a function in TasksTools?

We can use ECMAScript 6 now, use spread syntax:

  return [
  ...TaskTools.taskPrefix(etc),
  ...foo,
  ...bar
  ];

Note the `...`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28308: [FormLayout] Set compression timer interval to 0

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f6e15f51cac7: [FormLayout] Set compression timer interval 
to 0 (authored by broulik).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28308?vs=78546=78559

REVISION DETAIL
  https://phabricator.kde.org/D28308

AFFECTED FILES
  src/controls/FormLayout.qml

To: broulik, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

Re: KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

[Aleix Pol]

On it.

Aleix

On Thu, Mar 26, 2020 at 4:15 PM CI System  wrote:

> *BUILD FAILURE*
> Build URL
> https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/9/
> Project: kf5-qt5 FreeBSDQt5.14
> Date of build: Thu, 26 Mar 2020 15:10:31 +
> Build duration: 4 min 17 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 4101 lines...]
> [2020-03-26T15:14:41.362Z] Scanning dependencies of target
> testDontCrashNoBorder
> [2020-03-26T15:14:41.362Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/testDontCrashNoBorder_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:41.362Z] Scanning dependencies of target
> testXdgShellClient_waylandonly
> [2020-03-26T15:14:41.362Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashEmptyDeco.dir/dont_crash_empty_deco.cpp.o
> [2020-03-26T15:14:41.362Z] Scanning dependencies of target
> testDontCrashUseractionsMenu_waylandonly
> [2020-03-26T15:14:41.362Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/dont_crash_no_border.cpp.o
> [2020-03-26T15:14:41.625Z] Scanning dependencies of target
> testNoXdgRuntimeDir
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashUseractionsMenu_waylandonly.dir/testDontCrashUseractionsMenu_waylandonly_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testXdgShellClient_waylandonly.dir/testXdgShellClient_waylandonly_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testNoXdgRuntimeDir.dir/testNoXdgRuntimeDir_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashUseractionsMenu_waylandonly.dir/dont_crash_useractions_menu.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testXdgShellClient_waylandonly.dir/xdgshellclient_test.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testNoXdgRuntimeDir.dir/no_xdg_runtime_dir_test.cpp.o
> [2020-03-26T15:14:41.625Z] [ 90%] Linking CXX executable
> ../../bin/testNoXdgRuntimeDir_waylandonly
> [2020-03-26T15:14:41.885Z] [ 90%] Linking CXX executable
> ../../bin/testSceneQPainterShadow
> [2020-03-26T15:14:42.455Z] [ 90%] Built target testXwaylandInput
> [2020-03-26T15:14:42.455Z] [ 90%] Built target
> testDontCrashReinitializeCompositor_waylandonly
> [2020-03-26T15:14:42.455Z] [ 90%] Built target
> testNoXdgRuntimeDir_waylandonly
> [2020-03-26T15:14:42.455Z] Scanning dependencies of target
> testDontCrashAuroraeDestroyDeco
> [2020-03-26T15:14:42.455Z] Scanning dependencies of target
> testDecorationInput_waylandonly
> [2020-03-26T15:14:42.455Z] Scanning dependencies of target testMaximized
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashAuroraeDestroyDeco.dir/testDontCrashAuroraeDestroyDeco_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:42.720Z] [ 90%] Built target testSceneQPainterShadow
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testMaximized.dir/testMaximized_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testMaximized.dir/maximize_test.cpp.o
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDecorationInput_waylandonly.dir/testDecorationInput_waylandonly_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDontCrashAuroraeDestroyDeco.dir/dont_crash_aurorae_destroy_deco.cpp.o
> [2020-03-26T15:14:42.720Z] [ 90%] Linking CXX executable
> ../../bin/testXdgShellClient
> [2020-03-26T15:14:42.720Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testDecorationInput_waylandonly.dir/decoration_input_test.cpp.o
> [2020-03-26T15:14:42.720Z] Scanning dependencies of target
> testSceneOpenGLShadow_waylandonly
> [2020-03-26T15:14:42.990Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testSceneOpenGLShadow_waylandonly.dir/testSceneOpenGLShadow_waylandonly_autogen/mocs_compilation.cpp.o
> [2020-03-26T15:14:42.990Z] [ 90%] Building CXX object
> autotests/integration/CMakeFiles/testSceneOpenGLShadow_waylandonly.dir/scene_opengl_shadow_test.cpp.o
> [2020-03-26T15:14:42.990Z] [ 90%] Linking CXX executable
> ../../bin/testDontCrashNoBorder_waylandonly
> [2020-03-26T15:14:43.566Z] [ 90%] Built target testXdgShellClient
> [2020-03-26T15:14:43.834Z] [ 90%] Built target
> testDontCrashNoBorder_waylandonly
> [2020-03-26T15:14:43.834Z] Scanning dependencies of target
> testTransientPlacement_waylandonly
> [2020-03-26T15:14:43.834Z] [ 90%] Building CXX object
> 

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 646 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/646/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Mar 2020 15:10:31 +
 Build duration:
6 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 3970 lines...][2020-03-26T15:17:06.639Z] [ 94%] Built target testBufferSizeChange[2020-03-26T15:17:06.639Z] Scanning dependencies of target testKeymapCreationFailure[2020-03-26T15:17:06.639Z] [ 94%] Building CXX object autotests/integration/CMakeFiles/testKeymapCreationFailure.dir/testKeymapCreationFailure_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:06.639Z] [ 94%] Linking CXX executable ../../bin/testActivation[2020-03-26T15:17:06.639Z] [ 94%] Building CXX object autotests/integration/CMakeFiles/testKeymapCreationFailure.dir/keymap_creation_failure_test.cpp.o[2020-03-26T15:17:06.898Z] [ 94%] Linking CXX executable ../../bin/testQuickTiling[2020-03-26T15:17:06.898Z] [ 94%] Built target testStruts[2020-03-26T15:17:06.898Z] Scanning dependencies of target testX11DesktopWindow[2020-03-26T15:17:06.898Z] [ 94%] Building CXX object autotests/integration/CMakeFiles/testX11DesktopWindow.dir/testX11DesktopWindow_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:06.898Z] [ 94%] Building CXX object autotests/integration/CMakeFiles/testX11DesktopWindow.dir/desktop_window_x11_test.cpp.o[2020-03-26T15:17:07.156Z] [ 95%] Linking CXX executable ../../bin/testShade[2020-03-26T15:17:07.415Z] [ 95%] Linking CXX executable ../../bin/testMoveResize[2020-03-26T15:17:07.415Z] [ 95%] Linking CXX executable ../../bin/testDontCrashAuroraeDestroyDeco[2020-03-26T15:17:07.673Z] [ 95%] Built target testPlacement_waylandonly[2020-03-26T15:17:07.673Z] Scanning dependencies of target testXwaylandInput[2020-03-26T15:17:07.673Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/testXwaylandInput_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:07.673Z] [ 95%] Built target testActivation[2020-03-26T15:17:07.673Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/xwayland_input_test.cpp.o[2020-03-26T15:17:07.673Z] Scanning dependencies of target testGlobalShortcuts[2020-03-26T15:17:07.930Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testGlobalShortcuts.dir/testGlobalShortcuts_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:07.930Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testGlobalShortcuts.dir/globalshortcuts_test.cpp.o[2020-03-26T15:17:08.188Z] [ 95%] Built target testQuickTiling[2020-03-26T15:17:08.188Z] Scanning dependencies of target testStackingOrder[2020-03-26T15:17:08.188Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testStackingOrder.dir/testStackingOrder_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:08.188Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testStackingOrder.dir/stacking_order_test.cpp.o[2020-03-26T15:17:08.188Z] [ 95%] Built target testShade[2020-03-26T15:17:08.445Z] Scanning dependencies of target testActivities[2020-03-26T15:17:08.445Z] [ 95%] Building CXX object autotests/integration/CMakeFiles/testActivities.dir/testActivities_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:08.445Z] [ 96%] Building CXX object autotests/integration/CMakeFiles/testActivities.dir/activities_test.cpp.o[2020-03-26T15:17:08.445Z] [ 96%] Built target testDontCrashAuroraeDestroyDeco[2020-03-26T15:17:08.703Z] Scanning dependencies of target testDontCrashEmptyDeco[2020-03-26T15:17:08.703Z] [ 96%] Building CXX object autotests/integration/CMakeFiles/testDontCrashEmptyDeco.dir/testDontCrashEmptyDeco_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:08.703Z] [ 96%] Built target testMoveResize[2020-03-26T15:17:08.703Z] [ 96%] Building CXX object autotests/integration/CMakeFiles/testDontCrashEmptyDeco.dir/dont_crash_empty_deco.cpp.o[2020-03-26T15:17:08.703Z] Scanning dependencies of target testSceneQPainterShadow[2020-03-26T15:17:08.703Z] [ 96%] Building CXX object autotests/integration/CMakeFiles/testSceneQPainterShadow.dir/testSceneQPainterShadow_autogen/mocs_compilation.cpp.o[2020-03-26T15:17:08.703Z] [ 96%] Linking CXX executable ../../bin/testXdgShellClient[2020-03-26T15:17:08.703Z] [ 96%] Building CXX object autotests/integration/CMakeFiles/testSceneQPainterShadow.dir/scene_qpainter_shadow_test.cpp.o[2020-03-26T15:17:09.270Z] [ 96%] Linking CXX executable ../../bin/testPlasmaWindow[2020-03-26T15:17:09.528Z] [ 96%] Linking CXX executable ../../bin/testSceneQPainter[2020-03-26T15:17:10.092Z] [ 96%] Linking CXX executable ../../bin/testKeymapCreationFailure[2020-03-26T15:17:10.092Z] [ 96%] Built target testXdgShellClient[2020-03-26T15:17:10.092Z] [ 96%] Linking CXX executable ../../bin/testXdgShellClientRules_waylandonly[2020-03-26T15:17:10.092Z] Scanning dependencies of target testMinimizeAllScript[2020-03-26T15:17:10.092Z] [ 96%] Building CXX object 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 26 Mar 2020 15:10:31 +
 Build duration:
4 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 4101 lines...][2020-03-26T15:14:41.362Z] Scanning dependencies of target testDontCrashNoBorder[2020-03-26T15:14:41.362Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/testDontCrashNoBorder_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:41.362Z] Scanning dependencies of target testXdgShellClient_waylandonly[2020-03-26T15:14:41.362Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashEmptyDeco.dir/dont_crash_empty_deco.cpp.o[2020-03-26T15:14:41.362Z] Scanning dependencies of target testDontCrashUseractionsMenu_waylandonly[2020-03-26T15:14:41.362Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/dont_crash_no_border.cpp.o[2020-03-26T15:14:41.625Z] Scanning dependencies of target testNoXdgRuntimeDir[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashUseractionsMenu_waylandonly.dir/testDontCrashUseractionsMenu_waylandonly_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testXdgShellClient_waylandonly.dir/testXdgShellClient_waylandonly_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testNoXdgRuntimeDir.dir/testNoXdgRuntimeDir_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashUseractionsMenu_waylandonly.dir/dont_crash_useractions_menu.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testXdgShellClient_waylandonly.dir/xdgshellclient_test.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testNoXdgRuntimeDir.dir/no_xdg_runtime_dir_test.cpp.o[2020-03-26T15:14:41.625Z] [ 90%] Linking CXX executable ../../bin/testNoXdgRuntimeDir_waylandonly[2020-03-26T15:14:41.885Z] [ 90%] Linking CXX executable ../../bin/testSceneQPainterShadow[2020-03-26T15:14:42.455Z] [ 90%] Built target testXwaylandInput[2020-03-26T15:14:42.455Z] [ 90%] Built target testDontCrashReinitializeCompositor_waylandonly[2020-03-26T15:14:42.455Z] [ 90%] Built target testNoXdgRuntimeDir_waylandonly[2020-03-26T15:14:42.455Z] Scanning dependencies of target testDontCrashAuroraeDestroyDeco[2020-03-26T15:14:42.455Z] Scanning dependencies of target testDecorationInput_waylandonly[2020-03-26T15:14:42.455Z] Scanning dependencies of target testMaximized[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashAuroraeDestroyDeco.dir/testDontCrashAuroraeDestroyDeco_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:42.720Z] [ 90%] Built target testSceneQPainterShadow[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testMaximized.dir/testMaximized_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testMaximized.dir/maximize_test.cpp.o[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDecorationInput_waylandonly.dir/testDecorationInput_waylandonly_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashAuroraeDestroyDeco.dir/dont_crash_aurorae_destroy_deco.cpp.o[2020-03-26T15:14:42.720Z] [ 90%] Linking CXX executable ../../bin/testXdgShellClient[2020-03-26T15:14:42.720Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testDecorationInput_waylandonly.dir/decoration_input_test.cpp.o[2020-03-26T15:14:42.720Z] Scanning dependencies of target testSceneOpenGLShadow_waylandonly[2020-03-26T15:14:42.990Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testSceneOpenGLShadow_waylandonly.dir/testSceneOpenGLShadow_waylandonly_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:42.990Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testSceneOpenGLShadow_waylandonly.dir/scene_opengl_shadow_test.cpp.o[2020-03-26T15:14:42.990Z] [ 90%] Linking CXX executable ../../bin/testDontCrashNoBorder_waylandonly[2020-03-26T15:14:43.566Z] [ 90%] Built target testXdgShellClient[2020-03-26T15:14:43.834Z] [ 90%] Built target testDontCrashNoBorder_waylandonly[2020-03-26T15:14:43.834Z] Scanning dependencies of target testTransientPlacement_waylandonly[2020-03-26T15:14:43.834Z] [ 90%] Building CXX object autotests/integration/CMakeFiles/testTransientPlacement_waylandonly.dir/testTransientPlacement_waylandonly_autogen/mocs_compilation.cpp.o[2020-03-26T15:14:43.834Z] [ 90%] Building CXX object 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 808 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/808/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Mar 2020 15:00:54 +
 Build duration:
4 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)16%
(59/369)16%
(59/369)12%
(3794/31472)9%
(1743/19038)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/180)0%
(0/107)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/359)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/320)0%
(0/244)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2351)28%
(419/1503)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
 

D28232: [SpellChecking KCM] Fix the build

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:646bd3eecc72: [SpellChecking KCM] Fix the build (authored 
by ahmadsamir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28232?vs=78554=78555

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin, davidedmundson
Cc: davidedmundson, bcooksley, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78554.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28232?vs=78347=78554

BRANCH
  l-fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin, davidedmundson
Cc: davidedmundson, bcooksley, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > I could rework the patch to make it conditional on 5.14 and keep the 
iterator-based ctors as-is.
  
  May as well merge this and just revert when we're able to use 5.14
  
  The alternative is more work.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin, davidedmundson
Cc: davidedmundson, bcooksley, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[David Edmundson]

davidedmundson added a comment.


  @ngraham the default theme doesn't change with this patch.
  
  I believe there are no plans to do so.

INLINE COMMENTS

> Task.qml:331
> +if (isHovered)
> +return TaskTools.taskPrefix(basePrefix + 
> "-hover").concat(TaskTools.taskPrefix("hover")).concat(TaskTools.taskPrefix(basePrefix));
> +return TaskTools.taskPrefix(basePrefix);

this is a bit longwinded, can we make a function in TasksTools?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! For visual patches like this, it's helpful if you put 
before-and-after images or screen recordings in the Test Plan section.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28300: Opt into KIO changes for cgroup management

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b6a8662dbd91: Opt into KIO changes for cgroup management 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28300?vs=78527=78547

REVISION DETAIL
  https://phabricator.kde.org/D28300

AFFECTED FILES
  startkde/startplasma.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[Henri Chain]

hchain added inline comments.

INLINE COMMENTS

> startplasma.cpp:404
> +startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR 
> "/plasma_session"), plasmaSessionOptions);
> +rc = startPlasmaSession.waitForStarted();
> +#else

unrelated change ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28308: [FormLayout] Set compression timer interval to 0

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Apparently `Timer` default interval is `1000` :)

TEST PLAN
  - Putting a `FormLayout` into a hidden `OverlaySheet` now has correct sizes 
when it opens, not a second after that

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28308

AFFECTED FILES
  src/controls/FormLayout.qml

To: broulik, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28305: WIP: Systemd Startup

[Henri Chain]

hchain added inline comments.

INLINE COMMENTS

> hchain wrote in plasmawayland-dev.desktop.cmake:2
> does that still work in legacy (non-systemd) mode ?

original patch https://phabricator.kde.org/D19004

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28305: WIP: Systemd Startup

[Henri Chain]

hchain added inline comments.

INLINE COMMENTS

> apol wrote in plasmawayland-dev.desktop.cmake:2
> Is this change related?

does that still work in legacy (non-systemd) mode ?

> apol wrote in org.kde.plasmashell.desktop.cmake:55
> We probably want it always hidden?

maybe add a comment that this file is superseded in systemd-mode by a custom 
service and we don't want the systemd generator to make another one for us

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ahiemstra wrote in CMakeLists.txt:44
> This pattern is repeated multiple times, maybe we should make a macro out of 
> it? Like `install_systemd_service_file(source_file)`

that's a good idea

> apol wrote in ksmserver.service.cmake:8
> Why is there a - here after the =?

there's a comment above that line

> apol wrote in plasmawayland-dev.desktop.cmake:2
> Is this change related?

Related, yes.
Is this the right commit for it, probably not.

If we nest another dbus-session inside the system one everything gets confused.

Start dbus-manually shouldn't be our repsonsibility but apparently it's needed 
on some setups that don't have the combined systemd+dbus setups. See 404335

> apol wrote in org.kde.plasmashell.desktop.cmake:55
> We probably want it always hidden?

Right, this line currently does nothing.

It's meant to tell the systemd generator to skip this as we have a unit 
already, but we're going to use a common prefix at some point.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28305: WIP: Systemd Startup

[Aleix Pol Gonzalez]

apol added a comment.


  Change looks good to me overall +1

INLINE COMMENTS

> ksmserver.service.cmake:8
> +# This magic minus sign means don't fail if exit code is non-zero...
> +ExecStartPost=-@QtBinariesDir@/qdbus org.kde.KSplash /KSplash 
> org.kde.KSplash.setStage ksmserver
> +BusName=org.kde.ksmserver

Why is there a - here after the =?

> plasmawayland-dev.desktop.cmake:2
>  [Desktop Entry]
> -Exec=dbus-run-session @CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh 
> -wayland
> +Exec=@CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh -wayland
>  DesktopNames=KDE

Is this change related?

> org.kde.plasmashell.desktop.cmake:55
>  X-KDE-StartupNotify=false
> +X-KDE-HiddenUnderSystemd=true
>  X-DBUS-ServiceName=org.kde.plasmashell

We probably want it always hidden?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28305: WIP: Systemd Startup

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> CMakeLists.txt:44
>  
> +configure_file(krunner.service.cmake 
> ${CMAKE_CURRENT_BINARY_DIR}/krunner.service @ONLY)
> +install( FILES  ${CMAKE_CURRENT_BINARY_DIR}/krunner.service DESTINATION

This pattern is repeated multiple times, maybe we should make a macro out of 
it? Like `install_systemd_service_file(source_file)`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson added a comment.


  In terms of testing, you will need:
  
  - this patch
  - to rerun ./login-sessions/install-sessions.sh
  - cherry-picked the relevant repos in  kded, kwin, kactivitymanagerd
  
  This will give you a basic session, for everything , you'll also want
  
  optionally for full autostart for 3rd party things like next cloud and stuff:
  
  - https://github.com/systemd/systemd/pull/15226 and 
https://github.com/systemd/systemd/pull/15230

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: benjaminberg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28306: Make the hover state clarifying, but not main

[Eugene Popov]

epopov created this revision.
epopov added reviewers: davidedmundson, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  I'm trying to make a custom appearance of the Task Manager by creating a new 
theme, but I ran into some issue. I expected that there are three main states 
(minimized, normal and active) and one clarifying state (hover). But I was 
surprised to find that there are four main states (minimized, normal, active 
and hover), and the hover state is also main, but not clarifying. I believe 
that the hover state should be clarifying for the main states, i.e. there must 
be three main states (minimized, normal and active) and three additional 
(minimzed-hover, normal-hover, active-hover).
  
  BUG: 418318
  
  See https://phabricator.kde.org/P555

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: epopov, davidedmundson, #vdg
Cc: epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28289: Refactor of OverlaySheet

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> OverlaySheet.qml:2-19
> +*   Copyright (C) 2016 by Marco Martin 
> +*
> +*   This program is free software; you can redistribute it and/or modify
> +*   it under the terms of the GNU Library General Public License as
> +*   published by the Free Software Foundation; either version 2, or
> +*   (at your option) any later version.
> +*

Keep SPDX.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28289

To: mart, #kirigami
Cc: anthonyfieroni, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart

D28289: Refactor of OverlaySheet

[Marco Martin]

mart updated this revision to Diff 78542.
mart added a comment.


  - better response to window resizes

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28289?vs=78532=78542

BRANCH
  mart/overlaysheetrefactor2

REVISION DETAIL
  https://phabricator.kde.org/D28289

AFFECTED FILES
  src/controls/OverlaySheet.qml
  src/controls/templates/OverlaySheet.qml

To: mart, #kirigami
Cc: anthonyfieroni, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson updated this revision to Diff 78541.
davidedmundson added a comment.


  add comments explaining some code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28305?vs=78539=78541

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/krunner.service.cmake
  ksmserver/CMakeLists.txt
  ksmserver/ksmserver.service.cmake
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasmashell.service.cmake
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/kcminit-phase1.service.cmake
  startkde/kcminit/kcminit.service.cmake
  startkde/ksplash-ready.service.cmake
  startkde/plasma-core.target
  startkde/plasma-workspace.target
  startkde/startplasma.cpp

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This brings numerous advantages such as:
  
  - easier admin configuration with drop-ins, overrides a
  
  nd multiple hooks throughout (and only having to learn one tool)
  
  - session cleanup on exit, avoiding that occasional part where shutdown
  
  hangs
  
  - startup that actually knows when things are up
  - race free autostart and DBus activation at once
  - logs that rotate are split by service and usable
  - resource management through slices and cgroups (the part I want)
  
  Over the past 2 years I've been trying to tidy up and encapsulate the
  relevant parts of startup into the binary plasma-session so that we can
  just runtime swap out that one part and supporting both paths will be
  easy.
  
  Support is toggleable via cmake flag, as it seems like it should be a
  distro decision, especially as we will require a specific systemd with
  the xdg-generator.
  
  KDED/kwin/other services are attached to the relevant repo.
  
  It is WIP as:
  
  - it requires unmerged generator for regular autostart files
  - There are outstanding tasks, see below
  
  Task T11914 
  
  Uploaded to get more people on board and also because merging master
  into a feature branch is becoming really annoying.
  
  Given it's cmake guarded, I'm also up for merging before completion if
  others are happy?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/krunner.service.cmake
  ksmserver/CMakeLists.txt
  ksmserver/ksmserver.service.cmake
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasmashell.service.cmake
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/kcminit-phase1.service.cmake
  startkde/kcminit/kcminit.service.cmake
  startkde/ksplash-ready.service.cmake
  startkde/plasma-core.target
  startkde/plasma-workspace.target
  startkde/startplasma.cpp

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28272: Avoid copying buffer twice

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> ahiemstra wrote in screencaststream.cpp:549-563
> The entire framebuffer is superfluous, it is never used. glGetTexImage() 
> reads from the currently bound texture, which in this case is "texture" since 
> you bind it at line 546.

The fbo is gone 8a2286317edf91017a4854814340c48c4552fafe 


REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma, zzag
Cc: ahiemstra, meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28277: [UrlButton] Disable when there is no URL

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d6cfab5bec74: [UrlButton] Disable when there is no URL 
(authored by broulik).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28277?vs=78460=78538

REVISION DETAIL
  https://phabricator.kde.org/D28277

AFFECTED FILES
  src/controls/UrlButton.qml

To: broulik, mart, #vdg, #kirigami, ngraham, apol
Cc: bugseforuns, apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ahiemstra, davidedmundson, mart

D28277: [UrlButton] Disable when there is no URL

[Patrick Silva]

bugseforuns added a comment.


  This patch fixes bug 418580 .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami, ngraham, apol
Cc: bugseforuns, apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ahiemstra, davidedmundson, mart

D28272: Avoid copying buffer twice

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> zzag wrote in screencaststream.cpp:549-563
> Do we actually need an fbo?

The entire framebuffer is superfluous, it is never used. glGetTexImage() reads 
from the currently bound texture, which in this case is "texture" since you 
bind it at line 546.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma, zzag
Cc: ahiemstra, meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28192: WIP: Refactor dictionary runner

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> config_keys.h:5
> + */
> +
> +static const char CONFIG_TRIGGERWORD[] = "triggerWord";

Include guards please

> dictionarymatchengine.cpp:85
>  m_wordLock.lockForRead();
> -foreach (ThreadData *data, m_lockers.values(source)) {
> +for (ThreadData *data: m_lockers.values(source)) {
>  QMutexLocker locker(>mutex);

I think our style is space before and after :

> dictionaryrunner.cpp:37
> +}
> +setSyntaxes({Plasma::RunnerSyntax(Plasma::RunnerSyntax(i18nc("Dictionary 
> keyword", "%1:q:", m_triggerWord),
> +   i18n("Finds the 
> definition of :q:.")))});

This constructs the same RunnerSyntax twice does it not?

> dictionaryrunner.cpp:75
>  QString lastPartOfSpeech;
> -foreach (const QString , lines) {
> -if (partOfSpeech.indexIn(line) == -1)
> +for (const QString : qAsConst(lines)) {
> +const QRegularExpressionMatch partOfSpeechMatch = 
> m_partOfSpeechRegex.match(line);

` : `

> dictionaryrunner.cpp:90
> +// TODO What to set as data?
> +//match.setData(QVariant());
>  matches.append(match);

You could simply use the lastPartOfSpeech I would guess. From what I've seen 
and what Kai tells me you really only need to set setData if you want to 
implement actions (`::actionsForMatch`) and need to carry some information to 
figure out what the match result was or what its actions ought to be, or 
runability (`::run`). The latter in fact only appears to need id() so it can 
persistently track how often a given thing was run and thus give it higher 
relevance if the user chooses that option a lot.
That is to say: the runner as-is wouldn't benefit from setData at all.

> dictionaryrunner_config.cpp:24
> - connect(m_triggerWord, SIGNAL(textChanged(QString)), this, 
> SLOT(changed()));
> - load();
>  }

I wouldn't remove this without good reason.

Without this blocking load() call the UI gets set up and shown and only then 
the data gets loaded in a kinda async fashion. That is cool, but only iff the 
KCM is actually equipped for handling the intermediate time frame with a "I'm 
still loading" UI state (busyindicator or something; or is completely empty at 
least). If that is not the case then relying on async load will result in the 
KCM appearing in an incomplete state until the load() is run which may take a 
noticeable amount of time depending on system performance. So, when load() is 
doing trivial/cheap work it makes a whole lot of sense to call it blockingly 
form the ctor.

> dictionaryrunner_config.cpp:29
>  {
> - KCModule::load();
> - KSharedConfig::Ptr cfg = 
> KSharedConfig::openConfig(QLatin1String("krunnerrc"));

Could you elaborate on why you removed the baseclass calls for 
load/save/defaults please?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28192

To: alex, broulik, ngraham, sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28289: Refactor of OverlaySheet

[Marco Martin]

mart updated this revision to Diff 78532.
mart added a comment.


  - Merge branch 'master' into mart/overlaysheetrefactor2

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28289?vs=78482=78532

BRANCH
  mart/overlaysheetrefactor2

REVISION DETAIL
  https://phabricator.kde.org/D28289

AFFECTED FILES
  src/controls/OverlaySheet.qml
  src/controls/templates/OverlaySheet.qml

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

licensing terms of plasma dictionary runner

[Harald Sitter]

Hey Jason!

Hope you are doing well.
I've just noticed that the dictionary runner you've made for Plasma
doesn't really have licensing terms in its source files.

https://cgit.kde.org/kdeplasma-addons.git/tree/runners/dictionary/dictionaryrunner.cpp

It'd be really grand if you could specify which terms apply so we can
fix up the headers accordingly.

https://community.kde.org/Policies/Licensing_Policy

Thanks!
HS

D28300: Opt into KIO changes for cgroup management

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It was safeguarded by an environment variable so we don't retroactively
  change behaviour of existing setups in a bugfix update.
  
  See https://phabricator.kde.org/D27883

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28300

AFFECTED FILES
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28297: KCM/touchpad: Disables the middleEmulation when not supported

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, bport, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Similar to D28296 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpad-middleEmulation

REVISION DETAIL
  https://phabricator.kde.org/D28297

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/touchpad.qml

To: meven, #plasma, ervin, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  Some observation:
  
- Performance in KDevelop is horrible (First startup, opening files, 
switching between file tabs...)
- It also colors the toolbars of mdi windows F8199474: 
Screenshot_20200326_101026.png 
  - It also draws the line around some views double, see above screenshot and 
F8199478: Screenshot_20200326_101134.png 
  - Why are we drawing a separator if the window has no toolbar?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre requested changes to this revision.
davidre added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> breezehelper.cpp:1782
> +auto borderSize = kdecorationGroup.readEntry("BorderSize", 
> "Invalid");
> +if (borderSize != "None" && borderSize != "NoSides") {
> +return false;

This check is the problem. If "Use Theme's default border size" is checked (the 
default) then no entry will be written in the config file because the defaults 
are used. This is for`BorderSizeAuto` "true" and for `BorderSize` "Normal" 
(Note however that because of the the BorderSizeAuto the default borders of the 
deco are used and not normal sized borders)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28296: KCM/Mouse: fix the middleEmulation checkbox status

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, bport, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The load function of the field was not called previously.
  Preventing the checkbox from reflecting the property status and if it is 
enabled.

TEST PLAN
  kcmshell5 mouse
  Select a pointer not support middle click emulation.
  Before:
  middle click emulation is enabled
  After:
  middle click emulation is disabled

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse-middleEmulation

REVISION DETAIL
  https://phabricator.kde.org/D28296

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: meven, #plasma, ervin, bport, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

meven updated this revision to Diff 78522.
meven marked 4 inline comments as done.
meven added a comment.


  Review comments, code formating more const

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78457=78522

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik updated this revision to Diff 78521.
broulik retitled this revision from "WIP: [Task Manager] Port backend to 
ApplicationLauncherJob" to "[Task Manager] Port backend to 
ApplicationLauncherJob".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Use `KNotificationJobUiDelegate`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28286?vs=78471=78521

REVISION DETAIL
  https://phabricator.kde.org/D28286

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78519.
ahmadsamir retitled this revision from "[Fonts KCM] Port 
KFontDialog/KFontChooser to QFontDialog" to "[Fonts KCM] Use KFontChooserDialog 
instead of QFontDialog".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir edited reviewers, added: cfeck, bport; removed: ervin.
ahmadsamir removed subscribers: cfeck, bport.
ahmadsamir added a comment.


  Use KFontChooserDialog

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27808?vs=76867=78519

BRANCH
  l-kfontchooserdialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27808

AFFECTED FILES
  CMakeLists.txt
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml

To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for(QString component : qAsConst(mComponents))
>  {

const QString &

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for(QAbstractButton const *button : buttons)
>  {

const QAbstractButton *button

> kglobalshortcutseditor.cpp:708
>  {
> -Q_FOREACH (ComponentData *cd, d->components) {
> +for (ComponentData *cd : qAsConst(d->components)) {
>  if (cd->editor()->isModified()) {

I would make the ComponentData::editor() method const, then 'const 
ComponentData *cd'.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Re: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

[Ben Cooksley]

On Wed, Mar 25, 2020 at 6:39 PM Ömer Fadıl USTA  wrote:
>
>
> Ben Cooksley , 25 Mar 2020 Çar, 07:48 tarihinde şunu yazdı:
>>
>> The Dependency Build says plasma-desktop is broken.
>>
>> Ideas anyone?
>>
> Hello ben, It looks like this will solve that problem :
> https://phabricator.kde.org/D28232
> Could you apply that patch and try if it fixes the problem?

Hi Omer,

Yes, i'm aware of that patch - however the CI system cannot rely on
applying patches that have not been committed.
The code in the repository needs to be fixed.

Cheers,
Ben

>
> And the problem is here :
>
> 06:24:21  /home/jenkins/workspace/Administration/Dependency Build Plasma 
> kf5-qt5 
> SUSEQt5.12/plasma-desktop/kcms/spellchecking/spellchecking.cpp:69:119: error: 
> no matching function for call to 
> ���QSet::QSet(QList::iterator, QList::iterator)���
> 06:24:21 69 | QSet 
> defaultPreferredLanguages(defaultPreferredLanguagesList.begin(), 
> defaultPreferredLanguagesList.end());
> 06:24:21| 
>   ^
> 06:24:21  In file included from /usr/include/qt5/QtCore/QSet:1,
> 06:24:21   from 
> /home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5 
> SUSEQt5.12/plasma-desktop/kcms/spellchecking/spellchecking.cpp:27:
> 06:24:21  /usr/include/qt5/QtCore/qset.h:61:12: note: candidate: 
> ���QSet::QSet(std::initializer_list<_Tp>) [with T = QString]���
> 06:24:21 61 | inline QSet(std::initializer_list list)
> 06:24:21|^~~~
> 06:24:21  /usr/include/qt5/QtCore/qset.h:61:12: note:   candidate expects 1 
> argument, 2 provided
> 06:24:21  /usr/include/qt5/QtCore/qset.h:59:12: note: candidate: 
> ���QSet::QSet() [with T = QString]���
> 06:24:21 59 | inline QSet() Q_DECL_NOTHROW {}
> 06:24:21|^~~~
> 06:24:21  /usr/include/qt5/QtCore/qset.h:59:12: note:   candidate expects 0 
> arguments, 2 provided
> 06:24:21  /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: 
> ���QSet::QSet(const QSet&)���
> 06:24:21 54 | class QSet
> 06:24:21|   ^~~~
> 06:24:21  /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 
> argument, 2 provided
> 06:24:21  /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: 
> ���QSet::QSet(QSet&&)���
> 06:24:21  /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 
> argument, 2 provided
> 06:24:21  Scanning dependencies of target kded_touchpad
> 06:24:21  [ 66%] Building CXX object 
> kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kded_touchpad_autogen/mocs_compilation.cpp.o
> 06:24:21  make[2]: *** 
> [kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/build.make:89: 
> kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/spellchecking.cpp.o] Error 
> 1
> 06:24:21  make[1]: *** [CMakeFiles/Makefile2:7597: 
> kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/all] Error 2
> 06:24:21  make[1]: *** Waiting for unfinished jobs

D28232: [SpellChecking KCM] Fix the build

[Ben Cooksley]

bcooksley added a comment.


  @bport Sorry, but this cannot be left in a broken state like this.
  
  Reality is that the `plasma-desktop` repository declares that it depends on a 
minimum of Qt 5.12 at the moment in CMake, so that is what it needs to build 
with.
  Should this be insufficient, then that needs to be corrected.
  
  You cannot just bump that dependency though, as notice needs to be given to 
the CI system maintainers at a minimum of 2 weeks in advance of such a change.
  To date, no notice has been received from Plasma of this.
  
  Discussion of a change on any mailing list, regardless of whether the CI 
maintainers are subscribed to the list or not does not constitute giving this 
notice - you need to open an issue on #build.kde.org 
 or file a #Sysadmin 
 ticket to give this notice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart