D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop added a comment.


  Sorry everybody for not seeing all the new comments sooner! :D
  
  Ok, it seems like the some corners being rounded is a common complaint, so we 
should address it. I agree that it looks a little out of place in System 
Settings. The only trouble is doing this in a way which respects the line at 
the top.
  
  As for the inactive tab background, the problem is that I can't seem to find 
a QPalette color which is not too light/dark. The current one 
(QPalette::Disabled, QPalette::Window) is the best I could find, but we can go 
back to using the rather extreme dark one as is used in the current tabs, which 
IMO doesn't look good with this style. We could also make the current tab 
background *lighter* instead, as in manueljlins mockups where it is almost 
white. But that appears to be an issue left to colorshemes and not to the code. 
;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Konrad Materka]

kmaterka added a comment.


  With this change, plasma-workspace fails to build on my system (Neon User, 
kdesrc-build)
  
  Error message:
  
CMake Warning at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:27
 (message):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
  KSysGuard as namespace.
Call Stack (most recent call first):
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


CMake Error at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34
 (add_library):
  add_library cannot create ALIAS target "KF5::SysGuard" because target
  "KSysGuard::SysGuard" is IMPORTED.
Call Stack (most recent call first):
  
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37
 (add_sysguard_target)
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


CMake Error at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34
 (add_library):
  add_library cannot create ALIAS target "KF5::ProcessCore" because target
  "KSysGuard::ProcessCore" is IMPORTED.
Call Stack (most recent call first):
  
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:38
 (add_sysguard_target)
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


CMake Error at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34
 (add_library):
  add_library cannot create ALIAS target "KF5::ProcessUi" because target
  "KSysGuard::ProcessUi" is IMPORTED.
Call Stack (most recent call first):
  
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:39
 (add_sysguard_target)
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


CMake Error at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34
 (add_library):
  add_library cannot create ALIAS target "KF5::LsofUi" because target
  "KSysGuard::LsofUi" is IMPORTED.
Call Stack (most recent call first):
  
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:40
 (add_sysguard_target)
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


CMake Error at 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34
 (add_library):
  add_library cannot create ALIAS target "KF5::SignalPlotter" because target
  "KSysGuard::SignalPlotter" is IMPORTED.
Call Stack (most recent call first):
  
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:41
 (add_sysguard_target)
  /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 
(find_package)
  CMakeLists.txt:55 (find_package)


-- Found KF5SysGuard: 
/home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> SensorFaceController.cpp:177
> +if (component->status() != QQmlComponent::Ready) {
> +qCritical() << "Error creating component:";
> +for (auto err : component->errors()) {

One could argue that "Error creating component" is a pretty common error 
message. Categorized logging can be useful for resolving such ambiguities.

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  Never mind, @zzag discovered that I didn't have the `xorg-x11-server-sdk` 
package installed, so nothing to see here, and sorry for the noise!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this doesn't seem to apply cleanly on top of current master.

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  In D29514#665916 , @cblack wrote:
  
  > That's the source package location, not where you'd expect to find the 
headers for usage by other packages. You'd probably be looking for 
`/usr/include/xorg/xserver-properties.h`.
  
  
  It isn't in there on openSUSE TW.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Carson Black]

cblack added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  >
  >   -- The following features have been disabled:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >  
  >   -- The following OPTIONAL packages have not been found:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >
  
  
  That's the source package location, not where you'd expect to find the 
headers for usage by other packages. You'd probably be looking for 
`/usr/include/xorg/xserver-properties.h`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Vlad Zahorodnii]

zzag added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
  
  What distro are you running?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665912 , @ngraham wrote:
  
  > In D29514#665911 , 
@asturmlechner wrote:
  >
  > > In D29514#665869 , @ngraham 
wrote:
  > >
  > > > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  > >
  > >
  > > Where is synaptics-properties.h located on your system, if you even have 
been building touchpad kcm so far?
  >
  >
  > It's in `/usr/include/xorg`.
  >
  > I must confess I've never actually been able to build it, so I appreciate 
your efforts here to fix that.
  
  
  In that case yes it must have failed so far during build, now cmake will warn 
you already. It is now the same as with Evdev, Libinput and Synaptics, if you 
don't have them in system paths you would have to somehow feed the alternative 
paths to cmake.
  
  In D29514#665912 , @ngraham wrote:
  
  > What I'd really like is the ability to build just the libinput one if I 
don't have the synaptics dev stuff installed.
  
  
  Me too, unfortunately that will take a bit more work untangling the bits. In 
our source package I use this patch which enables me to bundle only the four 
headers and get rid of them as build dependencies, then point cmake to the 
bundle dir: 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/plasma-desktop/files/plasma-desktop-5.18.5-override-include-dirs.patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  In D29514#665911 , @asturmlechner 
wrote:
  
  > In D29514#665869 , @ngraham 
wrote:
  >
  > > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  >
  >
  > Where is synaptics-properties.h located on your system, if you even have 
been building touchpad kcm so far?
  
  
  It's in `/usr/include/xorg`.
  
  I must confess I've never actually been able to build it, so I appreciate 
your efforts here to fix that.
  
  What I'd really like is the ability to build just the libinput one if I don't 
have the synaptics dev stuff installed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
  
  Where is synaptics-properties.h located on your system, if you even have been 
building touchpad kcm so far?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29516: Remove remaining icon from applet with custom tooltip

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: bugseforuns, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Last bits needed for T12778 .
  
  CCBUG: 420934

TEST PLAN
  F8295118: Peek 2020-05-07 13-58.webm 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  remove-remaining-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29516

AFFECTED FILES
  applets/lock_logout/contents/ui/lockout.qml

To: ngraham, bugseforuns, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29518: Remove remaining icons from applets with custom tooltips

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: bugseforuns, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Last bits needed for T12778 .
  
  BUG: 420934

TEST PLAN
  F8295118: Peek 2020-05-07 13-58.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-remaining-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29518

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/showActivityManager/package/contents/ui/main.qml
  applets/showdesktop/package/contents/ui/main.qml
  applets/trash/package/contents/ui/main.qml
  kcms/touchpad/applet/qml/contents/ui/touchpad.qml

To: ngraham, bugseforuns, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29517: Remove remaining icons from applets with custom tooltips

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: bugseforuns, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Last bits needed for T12778 .
  
  CCBUG: 420934

TEST PLAN
  F8295118: Peek 2020-05-07 13-58.webm 

REPOSITORY
  R114 Plasma Addons

BRANCH
  remove-remaining-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29517

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/main.qml
  applets/quickshare/plasmoid/contents/ui/main.qml

To: ngraham, bugseforuns, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
-- The following features have been disabled:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

-- The following OPTIONAL packages have not been found:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  x11 backend of the touchpad KCM uses xserver-properties.h that is part of
  xorg-server package. As XORG_INCLUDE_DIRS seems to be empty, so far, it was
  relying on Synaptics_INCLUDE_DIRS implicitly and worked only if the header
  happened to be in the same directory as Synaptics' which is the case most of
  the time.
  
  FindXorgServer.cmake is just a copy of FindXorgLibinput, adapted accordingly.

TEST PLAN
  Pointed Synaptics_INCLUDE_DIRS somewhere else than /usr/include/xorg and build
  succeeded.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29514

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgServer.cmake
  kcms/CMakeLists.txt
  kcms/touchpad/backends/x11.cmake

To: asturmlechner, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  @davidre can you extract your test improvement to a separate patch? it would 
help me in another issue and I don't want to "steal" your code :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  IANAL but the Pexels and Unsplash licence look the same to me: free to 
distribute, free to modify, no attribution needed, but don't use it to make a 
Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS 
licence database. I'll just ask everyone to do CC0 but we'll still credit them. 
Thanks @ognarb and @jriddell.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 82224.
mart added a comment.


  - adapt to api changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=82187=82224

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/contents/config/faceproperties
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/config/faceproperties
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/config/faceproperties
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/config/faceproperties
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/config/faceproperties
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/config/faceproperties
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmonitor/systemmonitor/package/metadata.desktop
  applets/systemmonitor/systemmonitor/systemmonitor-faces.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor-presets.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor.cpp
  applets/systemmonitor/systemmonitor/systemmonitor.h

To: mart, #plasma
Cc: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82223.
mart added a comment.


  - use QJsonArrays for sensors

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82188=82223

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added a comment.


  I would like to get this into 5.19, which would mean moving the code back 
into the user-manager repo, or removing it as a dependency for Plasma 5.19 by 
requesting an exception to the repo freeze.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  There's still disagreement over whether we should do this or the other one, 
and how to implement them, so I don't think we know what release one of them 
will land in (if any).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Rik Mills]

rikmills added a comment.


  Is this to land in 5.19?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[David Edmundson]

davidedmundson added a comment.


  From my POV. +1
  
  I still need a reply on:
  
  "Which release?"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82214.
cblack marked 4 inline comments as done.
cblack added a comment.


  Parent temporary file to the application

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82212=82214

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b34e88da7a5d: [applets/systemtray] Hide/show expander 
arrow - regression fix (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28180?vs=82205=82213

REVISION DETAIL
  https://phabricator.kde.org/D28180

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82212.
cblack added a comment.


  realize you forgot to change the name of the argument in the body as well

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82211=82212

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> that looks like it could possibly run into race conditions, as the applyjob 
> is executed asynchronously and IIRC is able to still be running when 
> everything else, including this, has destructed and removed one of the files 
> it could be using

new QTemporaryFile(qApp) then

KJobs have an QEventLoopLocker that will stop qApp from quitting until they 
finish so you can be sure your applyjob is done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82211.
cblack added a comment.


  Refine method signature and add a comment for less ambiguity

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82210=82211

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:121
> Normally the app creating a temp file would clean it up.
> 
> A quick fix would be
> file = new QTemporaryFile(this);
> 
> It's sort of leaking the object, but on exit it'll tidy everything up.

that looks like it could possibly run into race conditions, as the applyjob is 
executed asynchronously and IIRC is able to still be running when everything 
else, including this, has destructed and removed one of the files it could be 
using

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:97
> OH!
> 
> Initial-ise
> 
> not initialise as in "to prepare"
> 
> Makes sense :)

Then it should have a different name, like "getInitials", else the next person 
will be just as confused

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> whoever is normally cleaning up tempfiles

Normally the app creating a temp file would clean it up.

A quick fix would be
file = new QTemporaryFile(this);

It's sort of leaking the object, but on exit it'll tidy everything up.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82210.
cblack marked an inline comment as done.
cblack added a comment.


  Parent the dynamically created user to the model

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82209=82210

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:97
> taking the initials of a user's real name

OH!

Initial-ise

not initialise as in "to prepare"

Makes sense :)

> usermodel.cpp:37
> +connect(m_dbusInterface, ::UserAdded, 
> this, [this](const QDBusObjectPath ) {
> +User *user = new User();
> +user->setPath(path);

This one isn't parented to the model

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29288: Improve PageRouter API

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> cblack wrote in pagerouter.h:443
> It could possibly be a list, but not of pure strings. You want to be able to 
> watch a list of routes?

Watching a list of routes is probably going to result in both clunky code and 
clunky API design in return for minimal gains.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29288

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82209.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address some of the code feedback from d_ed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82158=82209

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack marked 5 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:94
> what's this for?

used as a hook for QML to know when the KCM needs to apply

> davidedmundson wrote in kcm.cpp:97
> This is an odd method name.
> 
> I don't really understand what it's doing, some sort of title casing?

taking the initials of a user's real name

> davidedmundson wrote in kcm.cpp:121
> so who cleans this up?

whoever is normally cleaning up tempfiles

> davidedmundson wrote in usermodel.cpp:72
> why are we resetting the whole model instead of just dataChanged() on the 
> relevant row

i couldn't figure out how to use those correctly. some help would be 
appreciated.

> davidedmundson wrote in usermodel.cpp:78
> The ones not logged in will be sorted randomly.
> 
> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

loggedIn compares the UID of the user to the UID of the currently running 
program, which means only one user can be logged in at a time by our metric.

> davidedmundson wrote in usermodel.cpp:96
> this is marked as done, yet I can't see where ?

users are parented to the model, which will use normal QObject destructor 
behaviour to clean them

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29507: Use KSysGuard namespace for KSysGuard targets

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:dbb0b515364b: Use KSysGuard namespace for KSysGuard 
targets (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29507?vs=82204=82207

REVISION DETAIL
  https://phabricator.kde.org/D29507

AFFECTED FILES
  CMakeLists.txt
  gui/CMakeLists.txt
  kstats/CMakeLists.txt
  libkstats/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/nvidia/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/nvidia/CMakeLists.txt

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Nathaniel Graham]

ngraham added a comment.


  In D29501#665639 , @filipf wrote:
  
  > If user data would show low vertical panel usage, what are we really fixing 
and for who? Extrapolating from that and presuming that a fair share of them 
are content with the current default, why do we go against that? And if it's 
just a matter of not touching defaults, can you guarantee users are going to be 
equally content with a left panel as a default?
  
  
  Design of software and its default settings is hard because you have to 
anticipate people's needs, not ask them what they want (they don't know what 
they want or their ideas are bad) or reflect what they've already done (most 
people don't know what's possible).
  
  Most users never change more than a small handful of default settings, if 
any. This is practically a universal constant that is borne out by data 
wherever it is collected. So the fraction of users who have changed a default 
setting is rarely a useful metric for determining whether the default setting 
is a good one or not, because even if something is a bad default, most people 
will still not have changed it. The only case where this kind of data can be 
useful if the it shows that, say, 50% of users have changed a default 
setting--this means that it's so catastrophically bad that the system managed 
to overcome the inability or disinterest of most people in changing default 
settings because it was so bad that they went out of their way to seek help in 
changing it. At that point changing the default setting in the next release 
becomes a pants-on-fire emergency to prevent all of these irritated people from 
leaving your platform (if they can) or trashing it in their communications with 
others (if they can't).
  
  > It seems to me this would boil down to touch usage. (My hunch is most 
people don't care too much about saving some vertical pixels). We're still only 
talking about a smaller subset of users, who we could equally benefit by 
finishing D27845 , which is less risky.
  
  Not sure I understand the risks involved in this patch. Can you explain?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82206.
gikari added a comment.


  - Render buttons to SVGs

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82167=82206

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Konrad Materka]

kmaterka updated this revision to Diff 82205.
kmaterka added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28180?vs=78148=82205

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28180

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Kai Uwe Broulik]

broulik added a comment.


  Ah, right, we just use the sort filter model, no model from C++. Meh, so I 
can't think of a better way right now either..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28180

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29507: Use KSysGuard namespace for KSysGuard targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  With D29302  all KSysGuard targets have 
been placed in the KSysGuard namespace
  and the KF5 versions deprecated. This changes KSysGuard to use the new
  namespace. In addition, it renames the libkstats target from 
"PW5::KSysGuardBackend"
  to "KSysGuard::StatsBackend".

TEST PLAN
  Things still compile.

REPOSITORY
  R106 KSysguard

BRANCH
  library_targets

REVISION DETAIL
  https://phabricator.kde.org/D29507

AFFECTED FILES
  CMakeLists.txt
  gui/CMakeLists.txt
  kstats/CMakeLists.txt
  libkstats/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/nvidia/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/nvidia/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Kai Uwe Broulik]

broulik added a comment.


  I would suggest we add a `count` property with a `NOTIFY` signal on the model 
which is then updated on C++ side? I find that cleaner than doing that from QML 
like this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28180

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf added a comment.


  If user data would show low vertical panel usage, what are we really fixing 
and for who? Extrapolating from that and presuming that a fair share of them 
are content with the current default, why do we go against that? And if it's 
just a matter of not touching defaults, can you guarantee users are going to be 
equally content with a left panel as a default?
  
  It seems to me this would boil down to touch usage. (My hunch is most people 
don't care too much about saving some vertical pixels). We're still only 
talking about a smaller subset of users, who we could equally benefit by 
finishing D27845 , which is less risky.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Nathaniel Graham]

ngraham added a comment.


  #plasma  ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28180

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29288: Improve PageRouter API

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> mart wrote in pagerouter.h:443
> could this be just a QStringList?

It could possibly be a list, but not of pure strings. You want to be able to 
watch a list of routes?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29288

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D29288: Improve PageRouter API

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> pagerouter.h:443
> + */
> +Q_PROPERTY(QJSValue watchedRoute READ watchedRoute WRITE setWatchedRoute 
> NOTIFY watchedRouteChanged)
> +

could this be just a QStringList?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29288

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  Every change upsets somebody; that's not a reason to avoid change. We change 
things when the proposed change is a universal or net improvement, and we leave 
things the same when it would be worse or no better. So you should evaluate 
that (and any) patch on its merits.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29506: rejigger lookup of services by exec

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> servicerunner.cpp:164
>  
> -QString finalQuery = QStringLiteral("exist Exec and ( (%1) or (%2) 
> or (%3) or ('%4' ~~ Exec) or (%5) )")
> -.arg(keywordTemplate, genericNameTemplate, nameTemplate, 
> strList[0].toString(), commentTemplate);
> +QString finalQuery = QStringLiteral("exist Exec and ( (%1) or (%2) 
> or (%3) or (%5) )")
> +.arg(keywordTemplate, genericNameTemplate, nameTemplate, 
> commentTemplate);

It should be `%4` instead of `%5`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29506

To: sitter, broulik
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29506: rejigger lookup of services by exec

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously we'd simply query for an Exec that contains the primary query
  word. that is actually fairly unreliable because that will also match
  on env vars, arguments and the like which then has opportunity to produce
  false positives.
  
  notably examples is the konversation flatpak which matches 'ding' because
  it has a --forwarding argument in the Exec line and then even gets a
  relevance bump because it is a KDE application, so suddenly it outscores
  the actual ding application.
  
  to deal with this some rejiggering is necessary. we now query for potential
  Exec matches in its own query so we can tell which services are general
  matches and which are Exec matches. we'll then reduce the exec matches
  down to the ones that aren't already service matches AND where the actual
  executable name contains the primary query.

TEST PLAN
  test passes, konversation is no longer reported as match for 'ding' in kickoff

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29506

AFFECTED FILES
  runners/services/autotests/fixtures/ding.desktop
  runners/services/autotests/fixtures/flatpak_org.kde.konversation.desktop
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Nathaniel Graham]

ngraham added a comment.


  I don't know if I agree that "Looks like Windows" is a part of Plasma's brand 
identity, or should be. If anything, we're like //ancient// Windows, with a 
Windows-95-style Task Manager that everyone else has since moved away from; 
even Windows itself has used an Icons-Only Task manager with a thickened panel 
for the past decade.
  
  However if that's your thing, arguably this makes us more like Modern Windows 
(as does D27845 ) with the only difference 
being the screen edge of the panel. IMO this is really not rocket surgery for a 
person to figure out even if they've only ever used Windows 10 for their whole 
life. It's basically the exact same thing as the default Windows taskbar, just 
on a different screen edge.
  
  I don't think it makes sense to wait for kuserfeedback metrics before 
touching this. For one, we don't have those metrics and collecting them will 
take years due to the bureaucracy around changing what kuserfeedback collects 
and rolling it out to a statistically significant share of our userbase. Once 
we have those metrics, how will they help us? I can guarantee you that they 
aren't going to show then 35% or more of our users already use a left edge 
panel with an IOTM on it. So we'll end up getting data showing that maybe 5% of 
users do and 80% of users haven't changed the default panel at all. Or 
alternatively the data might show than 3% already do and 70% have not changed 
the defaults at all. But how will this help us make a decision? It won't, 
really.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[KonqiDragon]

KonqiDragon added a comment.


  In D27845#665342 , @ngraham wrote:
  
  > Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an 
alternative that fully implements the proposal in T12441 
 with no design compromises: D29501: Use 
left-aligned thickened panel with IOTM populated with some apps by default 

  
  
  I think you should not move the panel to the left, because "Kool Desktop 
Environment" and Plasma always had a panel on bottom by default, such a sudden 
change may upset users.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[David Edmundson]

davidedmundson added a comment.


  > There's going to be enough breakage as it is, let's do things that can be 
done now, now, instead of waiting for some nebulous "Plasma 6".
  
  That's a good argument when it comes to adding new code.
  For flipping defaults it doesn't really apply. We support both styles of 
layout both now and will continue to do so in Plasma 6.  There's no extra 
breakage potential.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b1e9126e2087: Use KSysGuard namespace for KSysGuard 
library targets (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29302?vs=82193=82194

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Arjen Hiemstra]

ahiemstra added a comment.


  > This is a major identity change better suited for Plasma 6.
  
  I disagree. I would like Plasma 6 to be a really uneventful release, not one 
that has a whole bunch of changes. There's going to be enough breakage as it 
is, let's do things that can be done now, now, instead of waiting for some 
nebulous "Plasma 6".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29394: Add photographic user avatars

[Carl Schwan]

ognarb added a comment.


  CC-0 or any license compatible with CC-BY-SA-4.0 are fine.
  
  The Unsplash license is non-free too: "This license does not include the 
right to compile photos from Unsplash to replicate a similar or competing 
service. ".

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Jonathan Riddell]

jriddell added a comment.


  We can't use anything under that Pexels licence, it's non-free.
  
  Unsplash and CC0 are good to use.  They both explicitly don't need 
attribution (which is pretty generous), but it's nice to do so and helps 
clarity in future.
  
  Preferably use this format https://reuse.software/tutorial/  making a 
LICENCE/ directory with the licence text in it and cat.jpg.license with the 
SPDX header

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82193.
ahiemstra added a comment.


  - Add backward-compatibility package config file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29302?vs=81594=82193

BRANCH
  lib_namespace

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  After additional consideration, I'm not too happy with the car avatar but I 
did find this:
  
  F8292121: Screenshot_20200507_090804.png 

  
  Speaking of licences, I assume I can leave the CC0 ones at CC0, while the 
rest should be CC-BY-SA 4.0 as per KDE licencing policy for images?

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[David Edmundson]

davidedmundson added a comment.


  Which release?
  
  We need to remove user-manager. We're technically in a repo freeze, and this 
would involve changing (removing) a repo a breakage of that.
  
  
  
  Generally this looks quite neat and tidy. A big simplification +++

INLINE COMMENTS

> kcm.cpp:94
> +KQuickAddons::ConfigModule::save();
> +Q_EMIT apply();
> +}

what's this for?

> kcm.cpp:97
> +
> +QString KCMUser::initializeString(const QString& stringToInitial)
> +{

This is an odd method name.

I don't really understand what it's doing, some sort of title casing?

> kcm.cpp:121
> +QTemporaryFile file;
> +file.setAutoRemove(false);
> +if (file.open()) {

so who cleans this up?

> user.cpp:96
> +}
> +QString trueVal = value.toString();
> +if (value.toString().startsWith(QStringLiteral("file://"))) {

use url.path and url.protocol for this not string manipulation

> usermodel.cpp:72
> +connect(user, ::dataChanged, [=]() {
> +beginResetModel();
> +endResetModel();

why are we resetting the whole model instead of just dataChanged() on the 
relevant row

> usermodel.cpp:78
> +std::sort(m_userList.begin(), m_userList.end(), [](User *lhs, User *) {
> +return lhs->loggedIn();
> +});

The ones not logged in will be sorted randomly.

Also note that if the intention is to have your user at the top, this check 
won't suffice as you can have 2 things logged in.

> broulik wrote in usermodel.cpp:96
> You're leaking all the users.
> `qDeleteAll(m_userList)`

this is marked as done, yet I can't see where ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29466: [applets/appmenu] Add search to global application menu

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> appmenumodel.cpp:193
> +removeSearchActionsFromMenu();
> +if (filter == QString()) {
> +return;

.isEmpty()

> appmenumodel.cpp:196
> +}
> +auto actions = flatActionList();
> +for (const auto : actions) {

const

> appmenumodel.h:70
>  void setScreenGeometry(QRect geometry);
> +QList flatActionList();
> +

const

> appmenumodel.h:73
> +void setMenuOpen(bool open);
> +bool menuOpen();
> +Q_SIGNAL void menuOpenChanged();

const

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> appmenumodel.cpp:246
> +}
> +for (auto : m_menu->findChildren()) {
> +if (action->menu() == nullptr) {

Extract the list into a variable before iterating, else this might blow up

See 
https://github.com/KDE/clazy/blob/master/docs/checks/README-temporary-iterator.md

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82188.
mart added a comment.


  - remove extra debug

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82185=82188

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 82187.
mart marked 3 inline comments as done.
mart added a comment.


  - make disk usage a bar chart

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=82118=82187

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/contents/config/faceproperties
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/config/faceproperties
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/config/faceproperties
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/config/faceproperties
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/config/faceproperties
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/config/faceproperties
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmonitor/systemmonitor/package/metadata.desktop
  applets/systemmonitor/systemmonitor/systemmonitor-faces.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor-presets.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor.cpp
  applets/systemmonitor/systemmonitor/systemmonitor.h

To: mart, #plasma
Cc: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82185.
mart added a comment.


  - use regexp for multiple sensors
  - left-alignlegends when they are too wide

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82119=82185

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28140: Add a declarative plugin to ProcessCore

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:82879c590d99: Add a declarative plugin to ProcessCore 
(authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28140?vs=78360=82182

REVISION DETAIL
  https://phabricator.kde.org/D28140

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/declarative/CMakeLists.txt
  processcore/declarative/ProcessEnums.cpp
  processcore/declarative/ProcessEnums.h
  processcore/declarative/ProcessPlugin.cpp
  processcore/declarative/ProcessPlugin.h
  processcore/declarative/qmldir
  processcore/process_controller.cpp
  processcore/process_controller.h
  tests/process/test_process.qml

To: ahiemstra, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by 
ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82082=82181

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma, davidedmundson
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf added a comment.


  I'd also be interested if #kde_promo 
 has any insights here. It doesn't 
seem (?) like we advertise it too much, but I know reviews often praise Plasma 
for its familiarity for Windows users. Given our major competitor does the 
opposite and that the majority of our new users are going to be Windows 
converts (and keeping in mind that the less technologically able people tend to 
not like unfamiliarity), it seems like a good market share to grab. Changing 
the layout could mean a boost for other competitors such as Zorin. Thoughts?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: broulik, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Kai Uwe Broulik]

broulik added a comment.


  > Switching to it would also require user data. How many users use a vertical 
panel?
  
  Yes, please!
  It also imho depends on the usecase. On a laptop you're more likely to use a 
left vertical panel than on a giant desktop setup with multiple monitors.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: broulik, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  This is a major identity change better suited for Plasma 6. We've never had a 
vertical panel and are moreover defined by offering a layout familiar to 
Windows users.
  
  Switching to it would also require user data. How many users use a vertical 
panel? Anecdotal evidence isn't enough, and we shouldn't be using developers as 
a sample for the whole userbase.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart