Re: Online sprint(?!)

[Aleix Pol]

On Thu, May 14, 2020 at 6:32 AM Bhushan Shah  wrote:

> So I am seeing this idea floating around in multiple occasion in Plasma
> IRC channel and as well on other places, but nothing concrete came up
> out of this discussion so I thought I should start formal discussion,
>
> Due to COVID-19 we had to skip our in-person sprint[1], however recently
> Plasma Mobile team experimented with the virtual sprint using
> BigBlueButton and I should say it was quite success/fun to attend and
> super useful.
>
> So I am thinking of planning similar sprint for the Plasma team as well.
> I don't really have a concrete date/time planning for this but probably
> week after we release final Plasma 5.19? which would also help kickstart
> Plasma 5.20 (along with virtual release party for 5.19 release! )
>
> I've started a wiki page to plan this better[2]. Pleaes fill-in your
> availability before 23rd May 2020 so we can decide upon a date and time
> slots that works for everyone.
>
> Stay safe!
>
> [1] https://community.kde.org/Sprints/Plasma/2020
> [2] https://community.kde.org/Sprints/Plasma/2020Virtual


Hi Bhushan,
I think it's a good idea, thanks for putting it together! :)

Aleix

D29709: Give all OverlaySheets consistent headers

[Aleix Pol Gonzalez]

apol added a comment.


  +1 for the change btw, thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29709: Give all OverlaySheets consistent headers

[Aleix Pol Gonzalez]

apol added a comment.


  We are in string freeze right now, aren't we?

INLINE COMMENTS

> ApplicationPage.qml:282
>  enabled: appInfo.application.isInstalled
> -visible: reviewsModel.backend && 
> reviewsModel.backend.isResourceSupported(appInfo.application)
> +// visible: reviewsModel.backend && 
> reviewsModel.backend.isResourceSupported(appInfo.application)
>  Layout.topMargin: Kirigami.Units.largeSpacing

I guess this was for testing?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It could make sense to leverage QCollatorSortKey in this class if it's 
sorting often.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 82302.
apol added a comment.


  Adapt to changes in the protocol, implement windows

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81926=82302

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/screenchooserdialog.ui
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> systemclipboard.cpp:63
> +
> +class DataControlDeviceManager : public 
> QWaylandClientExtensionTemplate
> +, public QtWayland::zwlr_data_control_manager_v1

Maybe split the DataControl classes into a separate file?

> systemclipboard.h:45
> +
> +class XClipboard : public SystemClipboard
> +{

I'd call it QtClipboard or GenericClipboard. There's nothing X-specific there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  In D29476#664751 , @nicolasfella 
wrote:
  
  > Isn't this something that should be in QClipboard in an ideal world? Or is 
that currently not feasible since the protocol is non-standard?
  
  
  It's more that only few processes should be able to monitor the clipboard.
  We'll need some of that code for kdeconnect-kde though, in case that's why 
you're asking.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29437: Use font: instead of font.pointSize: where possible

[Aleix Pol Gonzalez]

apol added a comment.


  You can do that now but this behaviour is deprecated and disallowed in Qt 6 
AFAIK.
  
  I don't know a better way of doing this, so +0 from me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29437

To: ngraham, cblack, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81926.
apol added a comment.


  Rebase on top of kwayland-server changes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81343=81926

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: repo freeze tomorrow

[Aleix Pol]

Hi Jonathan,
Thank you, will do!

Aleix

On Fri, May 1, 2020 at 5:27 PM Jonathan Riddell  wrote:
>
> So modules to be released are same as last time plus kwayland-server.  The 
> cmake setup of the repo looks good to me.
>
> Let me know if you need any help releasing plasma-wayland-protocols
>
> Jonathan
>
>
> On Fri, 1 May 2020 at 02:13, Aleix Pol  wrote:
>>
>> On Thu, Apr 30, 2020 at 7:57 PM Rik Mills  wrote:
>> >
>> > On 30/04/2020 18:33, Aleix Pol wrote:
>> > > Yes, in practice.
>> >
>> > In practice? What other way is there? Now I check some more they seem
>> > very non-optional.
>>
>> I mean that plasma-wayland-protocols is supposed to be released
>> outside of Plasma (as it will be a kwayland dependency eventually).
>> Sorry, could have explained myself better.
>>
>> Aleix

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> main.qml:92
> +function onExtraItemsChanged() {
> +plasmoid.nativeInterface.allowedPlasmoids = 
> plasmoid.configuration.extraItems
>  }

Why's this needed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Aleix Pol]

On Fri, May 1, 2020 at 7:18 AM Ben Cooksley  wrote:
>
> On Fri, May 1, 2020 at 4:38 PM Nate Graham  wrote:
> >
> >
> >
> > On 4/30/20 5:59 PM, Aleix Pol wrote:
> > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
> > >> Am I the only person that just has all the repos on the same folder? I 
> > >> thought it was the common thing to do :?
> > >
> > > I do too
> >
> > Same here. kdesrc-build's default settings do this, and download all
> > repos into ~/kde/src without any of the levels of hierarchy. This would
> > seem to require unique repo names, no?
>
> Not necessarily.
>
> Git allows you to override the name that the local folder is called
> when cloning, so there is no reason why we can't specify something in
> the metadata to override the local name that the folder gets called in
> your local checkout folder.
> This would allow for example:
>
> - frameworks/kcoreaddons on Gitlab continues to be called
> 'kcoreaddons' in your local checkout folder
> - maui/dialer on Gitlab gets called 'maui-dialer' in your local checkout 
> folder
>
> This allows for the URLs on Gitlab to make sense, while simultaneously
> allowing your local source checkout folders to continue to work in the
> manner in which they do currently.
> Note that we do not expect people to hit this in many cases - this is
> about giving us the flexibility for the long term without imposing
> unnecessary bureaucracy and limits on projects within the KDE
> umbrella.
>
> Automated tooling such as kdesrc-build and the proposed clone script
> (that searches in namespaces) should be able to handle this without
> much issue.
> In the case of manually done clones, it is reasonable to expect people
> to know what they're doing with their clones, and name them
> appropriately in the event they have a collision.
>
> Does this sound acceptable?

Okay, if that's necessary, we'll have to do it.

We'll appreciate simpler bureaucracy.

Aleix

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4c767ab70005: Address Connections syntax warnings on the 
systray plasmoid (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29150?vs=81088=81679

REVISION DETAIL
  https://phabricator.kde.org/D29150

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: apol, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: repo freeze tomorrow

[Aleix Pol]

On Thu, Apr 30, 2020 at 7:57 PM Rik Mills  wrote:
>
> On 30/04/2020 18:33, Aleix Pol wrote:
> > Yes, in practice.
>
> In practice? What other way is there? Now I check some more they seem
> very non-optional.

I mean that plasma-wayland-protocols is supposed to be released
outside of Plasma (as it will be a kwayland dependency eventually).
Sorry, could have explained myself better.

Aleix

Re: Information regarding upcoming Gitlab Migration: clarifications

[Aleix Pol]

On Fri, May 1, 2020 at 1:08 AM Nicolás Alvarez
 wrote:
>
> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
> (aa...@kde.org) escribió:
> >
> > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va 
> > escriure:
> > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
> > > >
> > > > > We have made a big fuss in the past about having different projects
> > > > > that do the same thing and now we'll have that but also we'll have
> > > > > several projects with the same name?
> > > > > It really feels off to me and I wonder if this is related to the move 
> > > > > to
> > > > > gitlab.
> > > >
> > > > +1 to both sentiments - that projects should have different names and 
> > > > that
> > > > this is a bit off topic for the gitlab migration.
> > >
> > > The projects *DO* have very different names. That *HAS NOT* changed.
> > > To use the example Bhushan gave above, one is called Plasma Mobile
> > > Dialer and the other one is called Maui Dialer.
> > >
> > > With the current git.kde.org setup, we have a flat namespace, so all
> > > repositories if the name appears to be generic (as dialer is) have to
> > > be namespaced by prefixing of the repository name.
> > >
> > > With Gitlab however we will now namespaces that group repositories,
> > > making the prefixing unnecessary and as some projects have complained
> > > about, duplicative.
> > >
> > > Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
> > > path, which just looks silly.
> >
> > Am I the only person that just has all the repos on the same folder? I 
> > thought it was the common thing to do :?

I do too

> Oh, your local path could be anywhere. It doesn't even need the same
> name, you can put it in the same folder as the rest and call it
> dial-thingy :)

And then you'll have to have a modified build script to account for
thingy because KDE can't stay consistent at naming.

I suggest not to use the gitlab transition to make such an important change.

Aleix

2 new repositories: plasma-wayland-protocols and kwayland-server

[Aleix Pol]

Hi everyone,
After long discussions, we have broken kwayland into 3 pieces so we
can work and improve kwin_wayland without having to extend our stable
framework constantly. This of course comes together with an updated
policy with regards to where things should be developed with the goal
of only adding Wayland protocol implementation public interfaces in
the cases that will be shared among several users.

This then includes 2 new repositories:
kdesupport/plasma-wayland-protocols
kde/workspace/kwayland-server

The first should be released independently whenever we have a new
protocol, the latter only together with the rest of Plasma.

Over the next months we'll adapt KWayland as well to depend on
plasma-wayland-protocols and deprecate some of its parts that are now
duplicated.

Anything compiling against kwayland for now is fine and will continue
to work. It still needs to be installed.
All 3 are co-installable.

Sorry for the extra work of caring for the extra repositories. We are
convinced it will be worth it in the long run.

Best regards,
Aleix

Re: Information regarding upcoming Gitlab Migration: clarifications

[Aleix Pol]

On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah  wrote:
>
> Good afternoon,
>
> [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> replies]
>
> I want to clarify some bits for which we have gotten a questions about,
>
> - Non unique naming: There's some teams which prefer if we dropped the
>   namespace- part from their name which we have added. While currently
>   this does not result in the naming conflict right away, we realize
>   this will cause it at one point, for example,
>
>   maui-dialer -> maui/dialer
>   plasma-dialer -> plasma-mobile/dialer
>
>   To minimize the impact of the Gitlab move we won't be doing such
>   renames which introduce non-unique names right away. But we would
>   prefer if the existing tooling or infrastructure is ready for this
>   kind of cases at later point. Only way to enforce non-unique naming is
>   one big KDE/ subgroup which we want to avoid.
>
>   Current naming in the repo-metadata branch[1] I've pointed does not
>   reflect those renames, as we are not planning to do those renames
>   right away during gitlab move, but at a later stage.

We have made a big fuss in the past about having different projects
that do the same thing and now we'll have that but also we'll have
several projects with the same name?
It really feels off to me and I wonder if this is related to the move to gitlab.

> - Existing configurations: we want to reduce impact on existing release
>   schedule, and existing developer workflow,  therefore we will continue
>   to privide the existing anongit.kde.org and git.kde.org (although this
>   will be read-only) with current flat structuring for 3 weeks after
>   actual migration, which will keep the existing scripts/clones working
>   enough to give developers time to change to the new structure.
>
>   We will also try to provide a script which allows you to migrate your
>   existing clones to new repo paths and as mentioned by Ben in other
>   message, potentially a git-kde script which would allow you to clone
>   individual repository without knowing it's namespace (provided that
>   there is no conflict of it's name). like "git kde karchive"

IMHO needing tools ad-hoc to KDE development can be a barrier of entrance.
I feel like these things make us look distant, it's important that
people's skills translate automatically when they want to get started.

> - Translations: we will co-ordinate with the translations team to let
>   them adapt their tooling to updated structure as this requires changes
>   on their side how translations are stored in svn repository

Thanks! :)

Re: repo freeze tomorrow

[Aleix Pol]

Yes, in practice.

Aleix

On Thu, Apr 30, 2020 at 6:19 PM Rik Mills  wrote:
>
> On 29/04/2020 22:04, David Edmundson wrote:
> > We have something announced that I'm not sure is on the list.
> >
> > Plasma will gain a new repo called kwayland-server.
> > This is a split of half the code currently in framework.
> >
> > Aleix has things prepared, but we haven't done all the steps to making
> > it part of Plasma.
> >
> > David
> >
>
> So this is 2 new repos for 5.19? plasma-wayland-protocols and
> kwayland-server
>

Re: repo freeze tomorrow

[Aleix Pol]

Are there any specific steps needed?
I tried to make it so the cmake variables on the /CMakeLists.txt are
named like in Plasma.

We will also need plasma-wayland-protocols released as kdesupport soon.
Right now I'm trying to make sure all is well on the CI side.

Aleix

On Wed, Apr 29, 2020 at 11:04 PM David Edmundson
 wrote:
>
> We have something announced that I'm not sure is on the list.
>
> Plasma will gain a new repo called kwayland-server.
> This is a split of half the code currently in framework.
>
> Aleix has things prepared, but we haven't done all the steps to making it 
> part of Plasma.
>
> David
>

D27960: Make it possible to scroll through the padding

[Aleix Pol Gonzalez]

apol added a comment.


  @ngraham can you test again? it works well for me (admittedly better than 
when I first submitted it).
  
  Maybe something else got fixed too in the meantime.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27960

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27960: Make it possible to scroll through the padding

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81481.
apol added a comment.


  Rebase and improve test

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27960?vs=77323=81481

BRANCH
  arcpatch-D27960

REVISION DETAIL
  https://phabricator.kde.org/D27960

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml
  src/wheelhandler.cpp
  src/wheelhandler.h
  tests/ScrollPaddingScrollable.qml

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

apol added a comment.


  Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29150

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29071: FileChooser portal: add support for opening directories

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  filechooser-directory

REVISION DETAIL
  https://phabricator.kde.org/D29071

To: jgrulich, apol, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29224: [Task Manager] Avoid crash with QStringBuilder

[Aleix Pol Gonzalez]

apol added a comment.


  Good catch :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29224

To: broulik, #plasma, fvogt, anthonyfieroni, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81343.
apol added a comment.


  Explicitly request zkde_screencast_unstable_v1

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81115=81343

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration

[Aleix Pol]

On Mon, Apr 27, 2020 at 12:55 PM Ben Cooksley  wrote:
>
> On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol  wrote:
> >
> > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
> > >
> > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > > replies]
> > >
> > > Hello Community members,
> > >
> > > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > > the recommended structuring for the repositories on Gitlab.
> > >
> > > We had multiple options,
> > >
> > > - Flat structure: In this option we would have everything under one
> > >   single namespace/group: https://invent.kde.org/kde/knetwalk
> > > - Subgroups under top-level group: In this option we would have a groups
> > >   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > > - Groups at top level: In this option we would establish a series of
> > >   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> > >
> > > We have discussed this with small but representative group of
> > > contributors or maintainers, and based on their suggestions, we
> > > recommend that we go with option 3. Having sub-groups at top level will
> > > allow us to,
> > >
> > > - Provides good visibility on all reviews, tasks and other items within
> > >   the groups/modules we define
> > > - Provides improvements to discoverability of projects
> > > - Makes it possible for groups of projects to establish a group level
> > >   task board should it fit their needs (for tracking a release for
> > >   instance)
> > > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> > >   in option 2 is duplicative considering the Gitlab instance is under
> > >   kde.org.
> > > - The discoverability of projects is maximised, as there is no need to
> > >   open the top level ‘KDE’ group before going into the subgroup.
> > >
> > > I've worked on draft "move" of the current set of the repositories in
> > > their respective subgroups at the repo-metadata project's branch [1].
> > > You can browse the directory structure to get idea of how final
> > > structure on Gitlab would look like.
> > >
> > > If we don't have any objections we would like to implement this next
> > > week and move projects to https://invent.kde.org.
> > >
> > > Thanks!
> > > Bhushan for sysadmin team
> > >
> > > [1] 
> > > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
> >
> > Does this mean that to clone it we'll have to go "git clone
> > kde:games/knetwalk" or something along the lines?
>
> Yes.
>
> >
> > If that's the case I'd much prefer if we didn't do this, at the moment
> > it's already uncomfortable for me to remember the URL for some of the
> > repos (e.g. is it sysadmin/ or not?), this will only increase the
> > problem and I personally don't see the advantage.
>
> So you'd rather that we have no way to easily see a list of just
> Plasma / Frameworks / PIM / etc reviews?
> (See https://invent.kde.org/groups/kde/-/merge_requests for an example
> of the problem)
>
> Not to mention the fact that there will be several hundred
> repositories all in one group, so they will be completely
> undiscoverable to anyone outside of our community.
>
> >
> > e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
> > krita graphics or its own thing?
> >
> > I really prefer when I don't have to guess this kind of things when
> > fetching a repository.
>
> There is always the search on Gitlab, and you can keep a checkout of
> sysadmin/repo-metadata for grepping on.

I don't know, I've always felt that the nesting we have nowadays
stemmed from svn's tree structure more than convenience.

I don't have the feeling I'd use that feature and I'm happy to
convinced otherwise.

While discoverability would be an incentive, I don't know if it will
make a difference since it would be especially useful to see how
repositories relate one to another, but it's something we generally
split explicitly through frameworks so I don't see that will help
much, other than for the very big suites (kdepim, plasma, etc).

I know you don't like it when I do this, but:
https://gitlab.gnome.org/explore/groups < gnome kept all the programs
under the same group
https://gitlab.freedesktop.org/explore/groups < didn't, but they have
projects that have very little overlap of contributors

Aleix

Re: Information regarding upcoming Gitlab Migration

[Aleix Pol]

On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
>
> [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> replies]
>
> Hello Community members,
>
> In view of upcoming Gitlab migration, we sysadmin team wants to share
> the recommended structuring for the repositories on Gitlab.
>
> We had multiple options,
>
> - Flat structure: In this option we would have everything under one
>   single namespace/group: https://invent.kde.org/kde/knetwalk
> - Subgroups under top-level group: In this option we would have a groups
>   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> - Groups at top level: In this option we would establish a series of
>   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
>
> We have discussed this with small but representative group of
> contributors or maintainers, and based on their suggestions, we
> recommend that we go with option 3. Having sub-groups at top level will
> allow us to,
>
> - Provides good visibility on all reviews, tasks and other items within
>   the groups/modules we define
> - Provides improvements to discoverability of projects
> - Makes it possible for groups of projects to establish a group level
>   task board should it fit their needs (for tracking a release for
>   instance)
> - Makes the most semantic sense, as the ‘KDE’ top level group suggested
>   in option 2 is duplicative considering the Gitlab instance is under
>   kde.org.
> - The discoverability of projects is maximised, as there is no need to
>   open the top level ‘KDE’ group before going into the subgroup.
>
> I've worked on draft "move" of the current set of the repositories in
> their respective subgroups at the repo-metadata project's branch [1].
> You can browse the directory structure to get idea of how final
> structure on Gitlab would look like.
>
> If we don't have any objections we would like to implement this next
> week and move projects to https://invent.kde.org.
>
> Thanks!
> Bhushan for sysadmin team
>
> [1] 
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent

Does this mean that to clone it we'll have to go "git clone
kde:games/knetwalk" or something along the lines?

If that's the case I'd much prefer if we didn't do this, at the moment
it's already uncomfortable for me to remember the URL for some of the
repos (e.g. is it sysadmin/ or not?), this will only increase the
problem and I personally don't see the advantage.

e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
krita graphics or its own thing?

I really prefer when I don't have to guess this kind of things when
fetching a repository.

Aleix

Re: Type=FSDevice desktop files

[Aleix Pol]

On Sun, Apr 26, 2020 at 11:45 PM David Faure  wrote:
>
> Would it be OK if we dropped support for desktop files that represent devices?
> This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with
> Type=FSDevice and Dev=/dev/sdc
> and this would give you Mount and Unmount in the context menu.
>
> This was useful back then, for USB keys and CDROMs (kids, ask your parents
> what that was), before Solid, before the plasma device notification popup...
>
> But has anyone been using this in the last 10 years? I kind of doubt it.
>
> Since I'm refactoring KRun and KDesktopFileActions to be asynchronous and
> independent from QtWidgets, I need to know what to do with this IMHO very dead
> code. Of course these classes will keep providing the feature, but once I
> write a KIO::OpenUrlJob as a replacement for KRun and we port the code to
> that, we'll lose the feature from a user's point of view.
> Not sure this is really a loss though ;)

I don't think anyone I've ever discussed OSs would miss it.

CCing plasma-devel since people there might know more about different use cases.

Aleix

D29202: Remove unused QtConcurrent from colorutils

[Aleix Pol Gonzalez]

apol added a comment.


  Then remove it from CMakeLists.txt as well?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  Yeah, I guess that phabricator scaled the pictures to take less space.
  
  My impression was that the patch improved things.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  This is what it looks like for me with the patch applied.
  
  scale 1x: F8258193: Screenshot_20200424_203628.png 

  scale 2x: F8258201: Screenshot_20200424_203729.png 

  
  master:
  scale 1x: F8258205: Screenshot_20200424_203923.png 

  scale 2x:F8258207: Screenshot_20200424_203959.png 

  
  I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  In D29154#656516 , @cblack wrote:
  
  > Icon handling looks somewhat funky with this patch applied when a window 
changes DPI.
  >  F8257898: ksnip_20200424-111720.png 
  
  
  Right, should re-render the pixmaps when the window changes (we do so in 
QtQuick).
  That said, I don't think that this is reason enough to keep this patch. I 
guess the alternative would be to render at the maximum dpi of all the outputs 
we have which is odd.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  
  I did the same thing for kirigami @ D29100 
 and plasma-framework @ D29102 
 yesterday after looking at Qt's code and 
assessing it was the right thing to do.
  I am not familiar with Breeze's code but the patch is sound.
  
  I do have all of the dpis so if you tell me how I'll test it.
  
  This should probably fix the BUG 418869.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81115.
apol added a comment.


  Adapt to the changes in hte kwayland patch

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80985=81115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Using it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29150

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80985.
apol added a comment.


  Adopt kwayland changes, provide the right buffer size.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80797=80985

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6b76ce30811c: Icon: improve icon rendering on 
multi-screen multi-dpi setups (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29100?vs=80906=80944

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol, davidedmundson
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28711: WIP: OpenStore Integration

[Aleix Pol Gonzalez]

apol added a comment.


  Hey,
  I went through the review, the patch looks good. There's some fairly 
important bits missing:
  
  - un/installing
  - running
  - state of resources. Currently it searches only on the server but doesn't 
check if it's installed locally.
  - detecting if the runtime is available
  
  How do you suggest we proceed?
  
  If it makes your life any better, I'm happy with having this merged and 
disabled by default as it's being worked on.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28711

To: bhdouglass, apol
Cc: plasma-devel, nicolaas, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
semareit, jraleigh, zachus, fbampaloukas, ragreen, ixoos, ZrenBot, James, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into 
account which window it's rendering to.
  Otherwise it was assuming we were rendering on the primary screen and it 
would end up being unpredictable.

TEST PLAN
  All looks correct, if I move emojier from a scaled screen to a non-scaled 
one, icons re-render properly.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80797.
apol added a comment.


  Remember to run the event loop

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80795=80797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80795.
apol added a comment.


  Remove conditional compilation to pipewire
  
  It's not in this module, we don't need to depend on it.
  Also removes code regarding EGL initialization that I think now is not 
necessary.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80719=80795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  My bad, thanks!

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80719.
apol added a comment.


  Proper initialisation

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80663=80719

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.


  I don't really see why we'd want to support something that is not offering 
ABI stability and doesn't push Plasma in any direction.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: apol, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80663.
apol added a comment.


  Adadpt to changes in kwayland D28882 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80408=80663

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80408.
apol added a comment.


  Renamed classes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80340=80408

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80340.
apol added a comment.


  Include the notification

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80285=80340

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80285.
apol added a comment.


  Fix build

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80280=80285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of creating the pipewire feeds in the portal, they will be
  created in KWin.
  Then the portal task becomes to orchestrate the permission and delivery
  to the app.
  
  Depends on D28882 

TEST PLAN
  None yet, just a PoC

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28853: krunner: Prevent regression

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
apol added a project: Plasma.
apol requested review of this revision.

REVISION SUMMARY
  It was pointed out to me that using NoDisplay=true breaks starting
  krunner.
  
  Alternatively D24956  could be landed.

TEST PLAN
  Still works for me, for some reason

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28852: Yep

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28852

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28821: [Notifier] Port from KRun::runCommand

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28821

To: broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c963fe873f7c: krunner: polish placement (authored by 
apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28783?vs=80036=80091

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma, cblack, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Update on Status of Gitlab Migration

[Aleix Pol]

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley  wrote:
>
> On Tue, Apr 14, 2020 at 3:35 AM Nate Graham  wrote:
> >
> > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote:
> > > Regarding this: is the subdomain going to stay invent.kde.org once we
> > > have officially moved? I find it's a bit confusing to use that instead
> > > of gitlab.kde.org
> >
> > I agree. gitlab.kde.org would make more sense to me, mirroring
> > phabricator.kde.org.
> >
>
> There is no intention to change the name from invent.kde.org.
>
> We have a long precedent of not using the name of the software for the
> name in DNS, and Gitlab is continuing with this, for example:
> - bugs.kde.org is run by Bugzilla
> - dot.kde.org is run by Drupal
> - techbase.kde.org is run by Mediawiki
> - conf.kde.org is run by Frab
> - reimbursements.kde.org is run by travel-support-program
> - websvn.kde.org is run by ViewVC
> - build.kde.org and binary-factory.kde.org are both run by Jenkins
> - stats.kde.org is run by Matomo (formerly Piwik)
> - survey.kde.org is run by Limesurvey
>
> For essentially all of the above, calling it after the software
> running it makes no sense, and given that in some cases we have
> multiple instances would have made things more confusing
> (jenkins1.kde.org and jenkins2.kde.org anyone?)
>
> Phabricator and Reviewboard were the only ones to not follow this
> rule, and that was an error on our part.
>
> Given that there is a popular instance at Gitlab.com, referring to
> ours as "KDE Invent" is more likely to ensure newcomers are not
> confused (as they may not be aware that you can setup an instance of
> Gitlab on your own systems)
>
> Regards,
> Ben

We also use git.kde.org and svn.kde.org.

It would too mimic what others are doing at gitlab.gnome.org and
gitlab.freedesktop.org. So at the very least we'll want a redirect.

Aleix

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80036.
apol added a comment.


  DOn't set it to Dock type, all sort of bad things happen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28783?vs=79966=80036

BRANCH
  arcpatch-D28783

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28724: Fix build

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I don't really see why this would be necessary, but it's okay to add it.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28724

To: ngraham, davidre, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28627: Adaptive panel opacity

[Aleix Pol Gonzalez]

apol added a comment.


  In D28627#646898 , @ngraham wrote:
  
  > +1 for making this a user-controllable setting, but how does it interact 
with plasma themes where there isn't any transparency? Can we only show this UI 
for plasma themes with transparency?
  
  
  Shouldn't it be a setting of the theme rather than a button somewhere?
  
  It's a weird thing for a user to be specific about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol added a subscriber: davidedmundson.
apol added a comment.


  This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18 
, so 
I'll wait for @davidedmundson's comment.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

To: apol, #plasma, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Tell the parent Dialog class what the location is so it can configure
  the dialog accordingly.
  
  Install the desktop file where it can be found by kwin to know about
  X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.
  
  While at it, make sure we don't leak if we return early.

TEST PLAN
  Now I get the right animation

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  CMake bits look good.
  
  It's a bit of a shame that this whole complexity needs to be added, but oh 
well.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma, apol
Cc: apol, asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D28113: Fix initial loading of autostart program names

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Hi, sorry for the delay, this review skipped my attention.
  
  The patch looks good to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28113

To: yuyichao, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Making PipeWire required for xdp-kde

[Aleix Pol]

On Tue, Apr 7, 2020 at 1:27 PM Jan Grulich  wrote:
>
> Hi,
>
> I recently pushed a background portal implementation, which also needs some
> KWayland stuff, while previously it was needed just for screen sharing purpose
> and compiled only when PipeWire and some other libraries are found. Now I need
> the Wayland part available all the time and I don't want to use idefs all over
> the place to disable most of the Wayland code in case of PipeWire is not
> found. Because of that, I'm thinking of making PipeWire and remaining libs
> (GBM, Epoxy) as required. What do you think? PipeWire is already available
> basically everywhere and this way users won't miss screen sharing support in
> case packagers forget to add PipeWire as dependency.
>
> Optional dependencies are mentioned here:
> https://cgit.kde.org/xdg-desktop-portal-kde.git/tree/CMakeLists.txt#n23
>
> Here you can see that Wayland integration part is built only when screen
> sharing is enabled:
> https://cgit.kde.org/xdg-desktop-portal-kde.git/tree/src/CMakeLists.txt#n37
>
> Thank you for your opinions.
>
> Regards,
> Jan

+1 I'd say it makes a lot of sense.
We are also considering using Pipewire for other things like
thumbnails. Seems like it will be an important system in the future.

GBM and Epoxy are already used in KWin extensively.

Aleix

D28214: Add background portal

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> jgrulich wrote in background.cpp:194
> Doesn't need to? I think it just specifies that the desktop file should 
> ignore the exec line and start it through DBus (assuming correct dbus service 
> file is installed etc.). Or am I wrong?

Ah, alright.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  background-portal

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28214: Add background portal

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> background.cpp:69
> +qCDebug(XdgDesktopPortalKdeBackground) << "GetAppState called: no 
> parameters";
> +return m_appStates;
> +}

I don't really understand why we're exposing this. Is it for contained apps?

> background.cpp:133
> +
> +QVariantMap map;
> +map.insert(QStringLiteral("result"), static_cast(result));

const QVariantMap map = { {QStringLiteral("result"), static_cast(result)} 
};

> background.cpp:194
> +if (autostartFlags.testFlag(AutostartFlag::Activatable)) {
> +   desktopEntryConfigGroup.writeEntry(QStringLiteral("DBusActivatable"), 
> true);
> +}

Will dbus look in autostart though?

> background.cpp:207
> +
> +connect(window, ::Client::PlasmaWindow::activeChanged, this, 
> [=] () {
> +setActiveWindow(window->appId(), window->isActive());

context should be [this]

> background.cpp:210
> +});
> +connect(window, ::Client::PlasmaWindow::unmapped, this, [=] () {
> +uint windows = 0;

[this]

> background.h:79
> +uint m_notificationCounter = 0;
> +QList m_windowList;
> +QVariantMap m_appStates;

I'd call it windows, it's better not include the type. It will change to 
QVector with Qt6 anyway.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:989cd3098ced: Remove the STATIC_LIBRARY option to fix 
static builds (authored by bartoc, committed by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28066?vs=79439=79440

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28539: [Emoji panel] search search when the user begins typing

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Fonts are slow...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28539

To: ngraham, apol, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R102 KInfoCenter

BRANCH
  multidri

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter, apol
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It could make sense for you to test that the names are properly parsed 
besides just making sure it starts.

REPOSITORY
  R103 KMenu Editor

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28519

To: ahmadsamir, #plasma, davidedmundson, mlaurent, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28517: Send notification when screencasting fails

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in screencaststream.cpp:385
> Are there more user-friendly and actionable strings we could for these error 
> messages? I have no idea what this means specifically and would read it as 
> "there was some gobbeldygook error."

While I agree, I haven't been able to see what's the right way to get a more 
specific error message. Other implementations are doing the same.

I guess we can go with this and if we ever find a better way to get 
information, we include it.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28517

To: cblack, #plasma, #vdg
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> opengl.cpp:281
> +if (ReadPipe("sysctl -n hw.dri.0.name", pci_info)) {
> +DriInfo info{};
> +info.module = pci_info[0].mid(0, pci_info[0].indexOf(0x20));

the {} isn't necessary here.

> opengl.cpp:290
>  
> -static bool get_dri_device() { return false; }
> +static QVector get_dri_devices() { return QVector(); }
>  

return {}

> opengl.cpp:625
> +for (const auto  : infos) {
> +l3 = nullptr;
> +l3 = newItem(l2, l3, info.deviceId);

setting twice in a row? I'd skip setting a nullptr.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> sitter wrote in opengl.cpp:281
> As it turns out the /proc/dri stuff was supposedly removed here 
> https://github.com/torvalds/linux/commit/cb6458f97b53d7f73043206c18014b3ca63ac345
>  making this code entirely irrelevant since kernel 3.12.
> Any objections to removing it altogether?

Go for it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28491: Properly store the powerdown action

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:a9abb0cb7924: Properly store the powerdown action 
(authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28491?vs=79077=79121

REVISION DETAIL
  https://phabricator.kde.org/D28491

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h

To: apol, #plasma:_mobile, bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28492: Improve powerdevil's main

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:41ef07d6d3c1: Improve powerdevils main (authored by 
apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28492?vs=79078=79079

REVISION DETAIL
  https://phabricator.kde.org/D28492

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: apol, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28492: Improve powerdevil's main

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Make it possible to restart the daemon for easier debugging.
  Use Qt::AA_DisableSessionManager for all the performance.

TEST PLAN
  Using it right now

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28492

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: apol, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28491: Properly store the powerdown action

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma: Mobile, bshah, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The event needs to propagate correctly.

TEST PLAN
  Played with it on my laptop

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28491

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h

To: apol, #plasma:_mobile, bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:9dbae3f1c3d6: Revert Fix build with Qt 5.15 
(authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28481?vs=79043=79050

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28482: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Once is enough

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28482

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol added a comment.


  commit 46ebd11e66f6f3180043a7258b46a1aff79a69f8
  Author: Lars Knoll 
  Date:   Wed Mar 25 11:20:28 2020 +0100
  
Fix deprecation of QComboBox:::currentIndexChanged(const QString&)

Don't introduce another overload with two parameters. Users
want a simple signal to connect to, not another overload. Deprecate
the currentIndexChanged(QString) overload, usage of that can/should
get replaced by currentTextChanged().

This partially reverts commit 11dc7b35c8c3957bd19087a5e3ae7cfc4f1a3343.

Change-Id: I5e7d16413f3d62b1a5a7a197f510af2c45cdfa55
Reviewed-by: Vitaly Fanaskov 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28481

To: apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol updated this revision to Diff 79043.
apol added a comment.


  remove unrelated changes

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28481?vs=79041=79043

BRANCH
  arcpatch-D28481

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28482: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2 
.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28482

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2 
.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp
  daemon/powerdevilapp.cpp

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  
  If plasma pass is part of plasma, which I'm not sure of, you can consider 
just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt 
for Plasma 5.19.

REPOSITORY
  R1028 Plasma Pass

REVISION DETAIL
  https://phabricator.kde.org/D28398

To: heikobecker, dvratil
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28389: Add support for logging categories

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that, the patch looks good. +1

INLINE COMMENTS

> romangg wrote in CMakeLists.txt:23
> Any idea how to reuse the declaration from the top-directory CMake file?

Make sure the include() call is before the add_subdirectory().

That's why we usually put them together on top right under the find_package() 
together with `include(ECMGenerateHeaders)`.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:184cee85e9f5: Remove unused file (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78753=78802

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78753.
apol added a comment.


  was only meant to include this

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78752=78753

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Still included dcop, hadn't been compiled in years I presume.

TEST PLAN
  All good and normal

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h
  ksplash/ksplashqml/splashapp.cpp
  ksplash/ksplashqml/splashwindow.cpp
  shell/screenpool.cpp
  shell/shellcorona.cpp
  startkde/plasma-shutdown/shutdown.cpp
  startkde/plasma-shutdown/shutdown.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28368: [krunner] Avoid (a third!) pointless config parse

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Sounds like you can merge this with the other similar one, right?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28368

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28365: [krunner] Avoid (another) pointless config load on start

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> view.cpp:110
>  // Catch both, direct changes to the config file ...
> -connect(KDirWatch::self(), ::dirty, this, ::reloadConfig);
> -connect(KDirWatch::self(), ::created, this, 
> ::reloadConfig);
> +connect(KDirWatch::self(), ::dirty, this, [this]() {
> +m_config.config()->reparseConfiguration();

Using 2 lambdas looks unnecessary, make a reparseConfig private slot?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28365

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> The code stores the QRegularExpression::capturedTexts(), 
> m_regexCapturedTexts, which is eventually what ClipCommandProcess uses.

I think it's a silly way to do the port but okay, probably works and we get to 
move on.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> Another point (which I forgot since it has been some time since I last looked 
> at this patch), QRegExp stores the match info in itself, whereas 
> QRegularExpression stores the match info in a QRegularExpressionMatch object 
> (returned from calling QRegularExpression::match()), so if I use a 
> m_regularExpression I'll have to add a getter for it, so that it can be 
> called from URLGrabber::matchingActions().

Then you want to store a match?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> I find it confusing to call the pattern "regExp" and the QRegExp object 
> "m_myRegExp".

Then call it m_regularExpression?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> urlgrabber.h:185
>  private:
> -  QRegExp m_myRegExp;
> +  QString m_regexPattern;
> +  QStringList m_regexCapturedTexts;

Why did you change how it works right here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28339: [kapplymousetheme] Avoid loading QPT

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Good catch!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28339

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27203: Don't try to open files we can't figure out where they are

[Aleix Pol Gonzalez]

apol added a comment.


  Ping?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:cfa43ed278c8: Read the new message string after rather 
than before (authored by apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78627=78628

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78627.
apol added a comment.


  address weird +2 in the code

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78605=78627

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78605.
apol added a comment.


  Don't leak

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78604=78605

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78604.
apol marked 3 inline comments as done.
apol added a comment.


  Rebase on top of ksyntaxhighlighting, works great

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78117=78604

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart