D27555: Add a category for kde-only and gnome-only apps

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  I don't feel like the world needs this.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27555

To: apol, #plasma, #vdg, ngraham
Cc: ngraham, pino, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol added a comment.


  This is on 
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/1 now.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28884

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:0d2bd657963c: screencasting: Adoption of the 
org_kde_plasma_video_streaming protocol (authored by apol).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=82302=83050

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/screenchooserdialog.ui
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29784: Hardcode fewer colorSets

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29785: Always use Window colorset for AbstractApplicationHeader

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder if this should be specified in ToolBarApplicationHeader instead.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29785

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D29784: Hardcode fewer colorSets

[Aleix Pol Gonzalez]

apol added a comment.


  addressed

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29784: Hardcode fewer colorSets

[Aleix Pol Gonzalez]

apol updated this revision to Diff 83035.
apol marked an inline comment as done.
apol added a comment.


  Address comment

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29784?vs=82964=83035

BRANCH
  Plasma/5.19

REVISION DETAIL
  https://phabricator.kde.org/D29784

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml
  discover/qml/SourcesPage.qml
  discover/qml/UpdatesPage.qml

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29784: Hardcode less colorSets

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We were overriding them on the background only and it would play weird with 
the
  feature where the toolbar looks the same as the page.
  
  BUG: 421571

TEST PLAN
  Still feels a bit random that it keeps changing but at least it looks 
consistent.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.19

REVISION DETAIL
  https://phabricator.kde.org/D29784

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml
  discover/qml/SourcesPage.qml
  discover/qml/UpdatesPage.qml

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29709: Give all OverlaySheets consistent headers

[Aleix Pol Gonzalez]

apol added a comment.


  +1 for the change btw, thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29709: Give all OverlaySheets consistent headers

[Aleix Pol Gonzalez]

apol added a comment.


  We are in string freeze right now, aren't we?

INLINE COMMENTS

> ApplicationPage.qml:282
>  enabled: appInfo.application.isInstalled
> -visible: reviewsModel.backend && 
> reviewsModel.backend.isResourceSupported(appInfo.application)
> +// visible: reviewsModel.backend && 
> reviewsModel.backend.isResourceSupported(appInfo.application)
>  Layout.topMargin: Kirigami.Units.largeSpacing

I guess this was for testing?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It could make sense to leverage QCollatorSortKey in this class if it's 
sorting often.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 82302.
apol added a comment.


  Adapt to changes in the protocol, implement windows

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81926=82302

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/screenchooserdialog.ui
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> systemclipboard.cpp:63
> +
> +class DataControlDeviceManager : public 
> QWaylandClientExtensionTemplate
> +, public QtWayland::zwlr_data_control_manager_v1

Maybe split the DataControl classes into a separate file?

> systemclipboard.h:45
> +
> +class XClipboard : public SystemClipboard
> +{

I'd call it QtClipboard or GenericClipboard. There's nothing X-specific there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  In D29476#664751 , @nicolasfella 
wrote:
  
  > Isn't this something that should be in QClipboard in an ideal world? Or is 
that currently not feasible since the protocol is non-standard?
  
  
  It's more that only few processes should be able to monitor the clipboard.
  We'll need some of that code for kdeconnect-kde though, in case that's why 
you're asking.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29437: Use font: instead of font.pointSize: where possible

[Aleix Pol Gonzalez]

apol added a comment.


  You can do that now but this behaviour is deprecated and disallowed in Qt 6 
AFAIK.
  
  I don't know a better way of doing this, so +0 from me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29437

To: ngraham, cblack, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81926.
apol added a comment.


  Rebase on top of kwayland-server changes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81343=81926

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> main.qml:92
> +function onExtraItemsChanged() {
> +plasmoid.nativeInterface.allowedPlasmoids = 
> plasmoid.configuration.extraItems
>  }

Why's this needed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4c767ab70005: Address Connections syntax warnings on the 
systray plasmoid (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29150?vs=81088=81679

REVISION DETAIL
  https://phabricator.kde.org/D29150

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: apol, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27960: Make it possible to scroll through the padding

[Aleix Pol Gonzalez]

apol added a comment.


  @ngraham can you test again? it works well for me (admittedly better than 
when I first submitted it).
  
  Maybe something else got fixed too in the meantime.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27960

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27960: Make it possible to scroll through the padding

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81481.
apol added a comment.


  Rebase and improve test

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27960?vs=77323=81481

BRANCH
  arcpatch-D27960

REVISION DETAIL
  https://phabricator.kde.org/D27960

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml
  src/wheelhandler.cpp
  src/wheelhandler.h
  tests/ScrollPaddingScrollable.qml

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

apol added a comment.


  Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29150

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29071: FileChooser portal: add support for opening directories

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  filechooser-directory

REVISION DETAIL
  https://phabricator.kde.org/D29071

To: jgrulich, apol, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29224: [Task Manager] Avoid crash with QStringBuilder

[Aleix Pol Gonzalez]

apol added a comment.


  Good catch :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29224

To: broulik, #plasma, fvogt, anthonyfieroni, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81343.
apol added a comment.


  Explicitly request zkde_screencast_unstable_v1

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81115=81343

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29202: Remove unused QtConcurrent from colorutils

[Aleix Pol Gonzalez]

apol added a comment.


  Then remove it from CMakeLists.txt as well?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  Yeah, I guess that phabricator scaled the pictures to take less space.
  
  My impression was that the patch improved things.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  This is what it looks like for me with the patch applied.
  
  scale 1x: F8258193: Screenshot_20200424_203628.png 

  scale 2x: F8258201: Screenshot_20200424_203729.png 

  
  master:
  scale 1x: F8258205: Screenshot_20200424_203923.png 

  scale 2x:F8258207: Screenshot_20200424_203959.png 

  
  I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  In D29154#656516 , @cblack wrote:
  
  > Icon handling looks somewhat funky with this patch applied when a window 
changes DPI.
  >  F8257898: ksnip_20200424-111720.png 
  
  
  Right, should re-render the pixmaps when the window changes (we do so in 
QtQuick).
  That said, I don't think that this is reason enough to keep this patch. I 
guess the alternative would be to render at the maximum dpi of all the outputs 
we have which is odd.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  
  I did the same thing for kirigami @ D29100 
 and plasma-framework @ D29102 
 yesterday after looking at Qt's code and 
assessing it was the right thing to do.
  I am not familiar with Breeze's code but the patch is sound.
  
  I do have all of the dpis so if you tell me how I'll test it.
  
  This should probably fix the BUG 418869.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81115.
apol added a comment.


  Adapt to the changes in hte kwayland patch

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80985=81115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29150: Address Connections syntax warnings on the systray plasmoid

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Using it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29150

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80985.
apol added a comment.


  Adopt kwayland changes, provide the right buffer size.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80797=80985

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6b76ce30811c: Icon: improve icon rendering on 
multi-screen multi-dpi setups (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29100?vs=80906=80944

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol, davidedmundson
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28711: WIP: OpenStore Integration

[Aleix Pol Gonzalez]

apol added a comment.


  Hey,
  I went through the review, the patch looks good. There's some fairly 
important bits missing:
  
  - un/installing
  - running
  - state of resources. Currently it searches only on the server but doesn't 
check if it's installed locally.
  - detecting if the runtime is available
  
  How do you suggest we proceed?
  
  If it makes your life any better, I'm happy with having this merged and 
disabled by default as it's being worked on.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28711

To: bhdouglass, apol
Cc: plasma-devel, nicolaas, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
semareit, jraleigh, zachus, fbampaloukas, ragreen, ixoos, ZrenBot, James, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into 
account which window it's rendering to.
  Otherwise it was assuming we were rendering on the primary screen and it 
would end up being unpredictable.

TEST PLAN
  All looks correct, if I move emojier from a scaled screen to a non-scaled 
one, icons re-render properly.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80797.
apol added a comment.


  Remember to run the event loop

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80795=80797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80795.
apol added a comment.


  Remove conditional compilation to pipewire
  
  It's not in this module, we don't need to depend on it.
  Also removes code regarding EGL initialization that I think now is not 
necessary.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80719=80795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  My bad, thanks!

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80719.
apol added a comment.


  Proper initialisation

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80663=80719

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.


  I don't really see why we'd want to support something that is not offering 
ABI stability and doesn't push Plasma in any direction.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: apol, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80663.
apol added a comment.


  Adadpt to changes in kwayland D28882 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80408=80663

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80408.
apol added a comment.


  Renamed classes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80340=80408

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80340.
apol added a comment.


  Include the notification

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80285=80340

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80285.
apol added a comment.


  Fix build

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80280=80285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of creating the pipewire feeds in the portal, they will be
  created in KWin.
  Then the portal task becomes to orchestrate the permission and delivery
  to the app.
  
  Depends on D28882 

TEST PLAN
  None yet, just a PoC

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28853: krunner: Prevent regression

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
apol added a project: Plasma.
apol requested review of this revision.

REVISION SUMMARY
  It was pointed out to me that using NoDisplay=true breaks starting
  krunner.
  
  Alternatively D24956  could be landed.

TEST PLAN
  Still works for me, for some reason

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28852: Yep

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28852

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28821: [Notifier] Port from KRun::runCommand

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28821

To: broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c963fe873f7c: krunner: polish placement (authored by 
apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28783?vs=80036=80091

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma, cblack, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80036.
apol added a comment.


  DOn't set it to Dock type, all sort of bad things happen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28783?vs=79966=80036

BRANCH
  arcpatch-D28783

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28724: Fix build

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I don't really see why this would be necessary, but it's okay to add it.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28724

To: ngraham, davidre, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28627: Adaptive panel opacity

[Aleix Pol Gonzalez]

apol added a comment.


  In D28627#646898 , @ngraham wrote:
  
  > +1 for making this a user-controllable setting, but how does it interact 
with plasma themes where there isn't any transparency? Can we only show this UI 
for plasma themes with transparency?
  
  
  Shouldn't it be a setting of the theme rather than a button somewhere?
  
  It's a weird thing for a user to be specific about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol added a subscriber: davidedmundson.
apol added a comment.


  This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18 
, so 
I'll wait for @davidedmundson's comment.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

To: apol, #plasma, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Tell the parent Dialog class what the location is so it can configure
  the dialog accordingly.
  
  Install the desktop file where it can be found by kwin to know about
  X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.
  
  While at it, make sure we don't leak if we return early.

TEST PLAN
  Now I get the right animation

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  CMake bits look good.
  
  It's a bit of a shame that this whole complexity needs to be added, but oh 
well.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma, apol
Cc: apol, asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D28113: Fix initial loading of autostart program names

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Hi, sorry for the delay, this review skipped my attention.
  
  The patch looks good to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28113

To: yuyichao, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28214: Add background portal

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> jgrulich wrote in background.cpp:194
> Doesn't need to? I think it just specifies that the desktop file should 
> ignore the exec line and start it through DBus (assuming correct dbus service 
> file is installed etc.). Or am I wrong?

Ah, alright.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  background-portal

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28214: Add background portal

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> background.cpp:69
> +qCDebug(XdgDesktopPortalKdeBackground) << "GetAppState called: no 
> parameters";
> +return m_appStates;
> +}

I don't really understand why we're exposing this. Is it for contained apps?

> background.cpp:133
> +
> +QVariantMap map;
> +map.insert(QStringLiteral("result"), static_cast(result));

const QVariantMap map = { {QStringLiteral("result"), static_cast(result)} 
};

> background.cpp:194
> +if (autostartFlags.testFlag(AutostartFlag::Activatable)) {
> +   desktopEntryConfigGroup.writeEntry(QStringLiteral("DBusActivatable"), 
> true);
> +}

Will dbus look in autostart though?

> background.cpp:207
> +
> +connect(window, ::Client::PlasmaWindow::activeChanged, this, 
> [=] () {
> +setActiveWindow(window->appId(), window->isActive());

context should be [this]

> background.cpp:210
> +});
> +connect(window, ::Client::PlasmaWindow::unmapped, this, [=] () {
> +uint windows = 0;

[this]

> background.h:79
> +uint m_notificationCounter = 0;
> +QList m_windowList;
> +QVariantMap m_appStates;

I'd call it windows, it's better not include the type. It will change to 
QVector with Qt6 anyway.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:989cd3098ced: Remove the STATIC_LIBRARY option to fix 
static builds (authored by bartoc, committed by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28066?vs=79439=79440

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28539: [Emoji panel] search search when the user begins typing

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Fonts are slow...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28539

To: ngraham, apol, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R102 KInfoCenter

BRANCH
  multidri

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter, apol
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It could make sense for you to test that the names are properly parsed 
besides just making sure it starts.

REPOSITORY
  R103 KMenu Editor

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28519

To: ahmadsamir, #plasma, davidedmundson, mlaurent, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28517: Send notification when screencasting fails

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in screencaststream.cpp:385
> Are there more user-friendly and actionable strings we could for these error 
> messages? I have no idea what this means specifically and would read it as 
> "there was some gobbeldygook error."

While I agree, I haven't been able to see what's the right way to get a more 
specific error message. Other implementations are doing the same.

I guess we can go with this and if we ever find a better way to get 
information, we include it.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28517

To: cblack, #plasma, #vdg
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> opengl.cpp:281
> +if (ReadPipe("sysctl -n hw.dri.0.name", pci_info)) {
> +DriInfo info{};
> +info.module = pci_info[0].mid(0, pci_info[0].indexOf(0x20));

the {} isn't necessary here.

> opengl.cpp:290
>  
> -static bool get_dri_device() { return false; }
> +static QVector get_dri_devices() { return QVector(); }
>  

return {}

> opengl.cpp:625
> +for (const auto  : infos) {
> +l3 = nullptr;
> +l3 = newItem(l2, l3, info.deviceId);

setting twice in a row? I'd skip setting a nullptr.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27980: make opengl module support multiple dri devices

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> sitter wrote in opengl.cpp:281
> As it turns out the /proc/dri stuff was supposedly removed here 
> https://github.com/torvalds/linux/commit/cb6458f97b53d7f73043206c18014b3ca63ac345
>  making this code entirely irrelevant since kernel 3.12.
> Any objections to removing it altogether?

Go for it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28491: Properly store the powerdown action

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:a9abb0cb7924: Properly store the powerdown action 
(authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28491?vs=79077=79121

REVISION DETAIL
  https://phabricator.kde.org/D28491

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h

To: apol, #plasma:_mobile, bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28492: Improve powerdevil's main

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:41ef07d6d3c1: Improve powerdevils main (authored by 
apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28492?vs=79078=79079

REVISION DETAIL
  https://phabricator.kde.org/D28492

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: apol, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28492: Improve powerdevil's main

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Make it possible to restart the daemon for easier debugging.
  Use Qt::AA_DisableSessionManager for all the performance.

TEST PLAN
  Using it right now

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28492

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: apol, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28491: Properly store the powerdown action

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma: Mobile, bshah, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The event needs to propagate correctly.

TEST PLAN
  Played with it on my laptop

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28491

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h

To: apol, #plasma:_mobile, bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:9dbae3f1c3d6: Revert Fix build with Qt 5.15 
(authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28481?vs=79043=79050

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28482: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Once is enough

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28482

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol added a comment.


  commit 46ebd11e66f6f3180043a7258b46a1aff79a69f8
  Author: Lars Knoll 
  Date:   Wed Mar 25 11:20:28 2020 +0100
  
Fix deprecation of QComboBox:::currentIndexChanged(const QString&)

Don't introduce another overload with two parameters. Users
want a simple signal to connect to, not another overload. Deprecate
the currentIndexChanged(QString) overload, usage of that can/should
get replaced by currentTextChanged().

This partially reverts commit 11dc7b35c8c3957bd19087a5e3ae7cfc4f1a3343.

Change-Id: I5e7d16413f3d62b1a5a7a197f510af2c45cdfa55
Reviewed-by: Vitaly Fanaskov 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28481

To: apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol updated this revision to Diff 79043.
apol added a comment.


  remove unrelated changes

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28481?vs=79041=79043

BRANCH
  arcpatch-D28481

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28482: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2 
.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28482

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28481: Revert "Fix build with Qt 5.15"

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2 
.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28481

AFFECTED FILES
  daemon/actions/bundled/wirelesspowersavingconfig.cpp
  daemon/powerdevilapp.cpp

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  
  If plasma pass is part of plasma, which I'm not sure of, you can consider 
just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt 
for Plasma 5.19.

REPOSITORY
  R1028 Plasma Pass

REVISION DETAIL
  https://phabricator.kde.org/D28398

To: heikobecker, dvratil
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28389: Add support for logging categories

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that, the patch looks good. +1

INLINE COMMENTS

> romangg wrote in CMakeLists.txt:23
> Any idea how to reuse the declaration from the top-directory CMake file?

Make sure the include() call is before the add_subdirectory().

That's why we usually put them together on top right under the find_package() 
together with `include(ECMGenerateHeaders)`.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:184cee85e9f5: Remove unused file (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78753=78802

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78753.
apol added a comment.


  was only meant to include this

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78752=78753

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Still included dcop, hadn't been compiled in years I presume.

TEST PLAN
  All good and normal

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h
  ksplash/ksplashqml/splashapp.cpp
  ksplash/ksplashqml/splashwindow.cpp
  shell/screenpool.cpp
  shell/shellcorona.cpp
  startkde/plasma-shutdown/shutdown.cpp
  startkde/plasma-shutdown/shutdown.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28368: [krunner] Avoid (a third!) pointless config parse

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Sounds like you can merge this with the other similar one, right?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28368

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28365: [krunner] Avoid (another) pointless config load on start

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> view.cpp:110
>  // Catch both, direct changes to the config file ...
> -connect(KDirWatch::self(), ::dirty, this, ::reloadConfig);
> -connect(KDirWatch::self(), ::created, this, 
> ::reloadConfig);
> +connect(KDirWatch::self(), ::dirty, this, [this]() {
> +m_config.config()->reparseConfiguration();

Using 2 lambdas looks unnecessary, make a reparseConfig private slot?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28365

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> The code stores the QRegularExpression::capturedTexts(), 
> m_regexCapturedTexts, which is eventually what ClipCommandProcess uses.

I think it's a silly way to do the port but okay, probably works and we get to 
move on.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> Another point (which I forgot since it has been some time since I last looked 
> at this patch), QRegExp stores the match info in itself, whereas 
> QRegularExpression stores the match info in a QRegularExpressionMatch object 
> (returned from calling QRegularExpression::match()), so if I use a 
> m_regularExpression I'll have to add a getter for it, so that it can be 
> called from URLGrabber::matchingActions().

Then you want to store a match?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in urlgrabber.h:185
> I find it confusing to call the pattern "regExp" and the QRegExp object 
> "m_myRegExp".

Then call it m_regularExpression?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> urlgrabber.h:185
>  private:
> -  QRegExp m_myRegExp;
> +  QString m_regexPattern;
> +  QStringList m_regexCapturedTexts;

Why did you change how it works right here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28339: [kapplymousetheme] Avoid loading QPT

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Good catch!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28339

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27203: Don't try to open files we can't figure out where they are

[Aleix Pol Gonzalez]

apol added a comment.


  Ping?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:cfa43ed278c8: Read the new message string after rather 
than before (authored by apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78627=78628

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78627.
apol added a comment.


  address weird +2 in the code

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78605=78627

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78605.
apol added a comment.


  Don't leak

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78604=78605

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78604.
apol marked 3 inline comments as done.
apol added a comment.


  Rebase on top of ksyntaxhighlighting, works great

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=78117=78604

BRANCH
  arcpatch-D28129

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[Aleix Pol Gonzalez]

apol added a comment.


  Change looks good to me overall +1

INLINE COMMENTS

> ksmserver.service.cmake:8
> +# This magic minus sign means don't fail if exit code is non-zero...
> +ExecStartPost=-@QtBinariesDir@/qdbus org.kde.KSplash /KSplash 
> org.kde.KSplash.setStage ksmserver
> +BusName=org.kde.ksmserver

Why is there a - here after the =?

> plasmawayland-dev.desktop.cmake:2
>  [Desktop Entry]
> -Exec=dbus-run-session @CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh 
> -wayland
> +Exec=@CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh -wayland
>  DesktopNames=KDE

Is this change related?

> org.kde.plasmashell.desktop.cmake:55
>  X-KDE-StartupNotify=false
> +X-KDE-HiddenUnderSystemd=true
>  X-DBUS-ServiceName=org.kde.plasmashell

We probably want it always hidden?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28277: [UrlButton] Don't show tooltip if it would be empty

[Aleix Pol Gonzalez]

apol added a comment.


  disabling as suggested would make sense, thanks for looking into this!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:f304e0185fb8: Use SyntaxHighlighter for highlighting 
(authored by apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28234?vs=78354=78446

REVISION DETAIL
  https://phabricator.kde.org/D28234

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/backtracewidget.cpp
  src/backtracewidget.h
  src/gdbhighlighter.cpp
  src/gdbhighlighter.h

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

apol added a comment.


  F8196700: Screenshot_20200324_145906.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28234

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The code is especially fiddly and complex. Using this we can on the
  other hand leverage other parts of our system.

TEST PLAN
  Used, will upload screenshot

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28234

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/backtracewidget.cpp
  src/backtracewidget.h
  src/gdbhighlighter.cpp
  src/gdbhighlighter.h

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28218: FileChooser: add option to open file with or without write access

[Aleix Pol Gonzalez]

apol added a comment.


  This is a feature we generally don't show. What's the use-case?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28218

To: jgrulich, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart