D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

crossi added a comment.


  In D28662#664211 , @heikobecker 
wrote:
  
  > This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also 
fails on build.kde.org for a while, e.g.:
  >
  >   14:11:19  FAIL!  : KcmTest::testKCMSave() Compared values are not the same
  >   14:11:19 Actual   (cg.readEntry("widgetStyle", QString())): ""
  >   14:11:19 Expected (QString("testValue"))  : 
"testValue"
  >   14:11:19 Loc: 
[/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 
SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]
  >  
  >
  >
  > 
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console
  
  
  I will have a look at this test case. Thanks for reporting this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28662

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: heikobecker, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29402

AFFECTED FILES
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() 
instead of deprecated newIconLoader() (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29285?vs=81567=81569

REVISION DETAIL
  https://phabricator.kde.org/D29285

AFFECTED FILES
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/main.cpp

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi updated this revision to Diff 81567.
crossi added a comment.


  consider Kai's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29285?vs=81536=81567

REVISION DETAIL
  https://phabricator.kde.org/D29285

AFFECTED FILES
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/main.cpp

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi added a comment.


  In D29285#660158 , @broulik wrote:
  
  > Can this go into 5.18?
  
  
  Sure.

INLINE COMMENTS

> broulik wrote in main.cpp:307
> Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this?

This one sends a `notifyChange` signal.

`KIconLoader::emitChange()` sends a `iconChanged()` signal.

From KIconLoader :

  QDBusMessage message = 
QDBusMessage::createSignal(QStringLiteral("/KIconLoader"), 
QStringLiteral("org.kde.KIconLoader"), QStringLiteral("iconChanged"));

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Changing the icon size should emits `iconLoaderSettingsChanged` as well

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

AFFECTED FILES
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/main.cpp

To: crossi, #plasma, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6d12d2d62607: KCM Notifications : Manage app-specific 
notifications with KCconfigXTs magic (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=81014=81017

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 81014.
crossi added a comment.


  clear the nitpicks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=81009=81014

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 81009.
crossi added a comment.
This revision is now accepted and ready to land.


  Consider Kai's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=80894=81009

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi planned changes to this revision.
crossi added inline comments.

INLINE COMMENTS

> broulik wrote in ApplicationConfiguration.qml:45
> I've seen duplicate apps in this list, e.g. snap vs properly installed, so I 
> don't think you can rely on this.

I guess I could use `rootIndex` instead, and it will solve the issue you 
mention below as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29120: KCM Fonts disable AA items if they are immutable

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  If Anti Aliasing configuration is set to immutable, disable items in the KCM
  Since these entries are not read from config files, and only a few of them 
are saved, 
  consider that if enable Anti Aliasing entry is set to immutable, disable the 
whole AA configuration.

TEST PLAN
  To set AntiAliasing configuration immutable In kdeglobals add `[$i]` to 
`XftAntialias`
  
[General]
XftAntialias[$i]=true

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29120

AFFECTED FILES
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle 
availability before applying it (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28662?vs=80067=80895

REVISION DETAIL
  https://phabricator.kde.org/D28662

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is 
provided before applying it. (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28656?vs=79574=80896

REVISION DETAIL
  https://phabricator.kde.org/D28656

AFFECTED FILES
  kcms/ksplash/splashscreensettings.kcfg
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 80894.
crossi added a comment.


  use qAsConst, indent

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=80864=80894

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 80864.
crossi added a comment.


  maange reset to default application notification

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=76004=80864

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c56e12cc540d: libnotificationmanager : add app-specific 
kconfig settings (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=77068=80845

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28629: [WIP] Port KCM to SettingStateBinding

[Cyril Rossi]

crossi updated this revision to Diff 80611.
crossi added a comment.


  Work on fonts and style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28629?vs=79508=80611

REVISION DETAIL
  https://phabricator.kde.org/D28629

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Cyril Rossi]

crossi added a comment.


  These new properties can be managed by KConfig.
  It will automatically handle the read/write process and 
isSaveNeeded/isDefault status.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

crossi updated this revision to Diff 80067.
crossi added a comment.


  Fix comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28662?vs=79597=80067

REVISION DETAIL
  https://phabricator.kde.org/D28662

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:83
> +void save();
> +bool needsSave();
> +bool isDefault();

should be const

> shortcutsmodel.h:84
> +bool needsSave();
> +bool isDefault();
> +

should be const

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: crossi, nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 419552
  
  - Some Global Theme may refer to breeze widget style with a lower case b, 
apply the proper name `Breeze`
  
  BUG: 418698
  
  - Some Global Theme use widget style that may not be installed, then don't 
apply it.

TEST PLAN
  - Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply 
it. Open Application Style KCM, if kvantum is not installed, Breeze is 
highlited.
  - Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. 
Open Application Style KCM, Breeze is highlighted.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28662

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 414417
  
  - While saving a new global theme, don't set splash screen if none is 
provided, leave the current one.
  - KSplash kcfg set default to breeze instead of the current lnf theme which 
may not contain a splash screen.

TEST PLAN
  - Open LookAndFeel KCM, apply Breeze Dark, then open Splash screen KCM, 
Breeze should be highlighted.
  - Open splash screen KCM, select none, click on defaults, Breeze should be 
selected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28656

AFFECTED FILES
  kcms/ksplash/splashscreensettings.kcfg
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28629: [WIP] Port KCM to SettingStateBinding

[Cyril Rossi]

crossi updated this revision to Diff 79508.
crossi added a comment.


  port KCM cursor theme

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28629?vs=79507=79508

REVISION DETAIL
  https://phabricator.kde.org/D28629

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28629: [WIP] Port KCM to SettingStateBinding

[Cyril Rossi]

crossi updated this revision to Diff 79507.
crossi added a comment.


  fix import

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28629?vs=79506=79507

REVISION DETAIL
  https://phabricator.kde.org/D28629

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml
  kcms/colors/package/contents/ui/main.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28629: [WIP] Port KCM to SettingStateBinding

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  same as D27841 , depends on D27840 

  
  Port the following KCM to use SettingStateBinding
  
  - baloo
  - colors
  - fonts
  - ksplash
  - launchfeedback (need some work on feedback cursor)
  - lookandfeel
  - notifications
  - widget style

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28629

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml
  kcms/colors/package/contents/ui/main.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> kcm.cpp:73
> +
> +void KCMUser::defaults()
> +{

Not necessary to override if you don't add your specific implementatioin.

> kcm.cpp:78
> +
> +void KCMUser::load()
> +{

same here

> user.cpp:53
> +mName = value;
> +nameChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:66
> +mRealName = value;
> +realNameChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:79
> +mEmail = value;
> +emailChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:110
> +mAdministrator = value;
> +administratorChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b37bac64f0f0: Update kdeglobals config file for Breeze 
widgetStyle (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27482?vs=75931=77981

REVISION DETAIL
  https://phabricator.kde.org/D27482

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/style_widgetstyle_default_breeze.pl
  kcms/style/style_widgetstyle_default_breeze.upd

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4d33b8276e00: KCM Colors fix apply button always disabled 
(authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27944?vs=77282=77980

REVISION DETAIL
  https://phabricator.kde.org/D27944

AFFECTED FILES
  kcms/colors/colors.cpp

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 418604

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

AFFECTED FILES
  kcms/colors/colors.cpp

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi updated this revision to Diff 77068.
crossi added a comment.


  rename group attribute to parentGroupName

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=76834=77068

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi updated this revision to Diff 76834.
crossi added a comment.


  use parentGroup attribute

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=75090=76834

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings 
ctor that takes a config (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=76380=76394

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi updated this revision to Diff 76380.
crossi added a comment.


  constexpr

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=76379=76380

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi updated this revision to Diff 76379.
crossi added a comment.


  constexpr instead of static

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=74116=76379

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi added a comment.


  @broulik any thoughts on this ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26834

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> bport wrote in style_widgetstyle_default_breeze.pl:8
> This will fix only for Breeze theme
> This will fix existing case but we also need to fix the root cause (i.e. how 
> we end up with a lowercase name).

Root cause was fixed by D27407 

This patch will allow to fix faulty configuration file without requiring the 
user to re-apply Breeze Style as chatted in aforementioned patch.

Currently, this is the only faulty breeze I see, others KCM looks ok.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  @ngraham do you confirm it is not working ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6d3d3ffa76a5: KCM look and feel : set proper default 
values for kwin kdecoration when… (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27483?vs=75933=76081

REVISION DETAIL
  https://phabricator.kde.org/D27483

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, ervin, bport, meven, davidedmundson, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 76004.
crossi marked 6 inline comments as done.
crossi added a comment.


  Consider Kevin's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=75360=76004

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  In D27482#614006 , @meven wrote:
  
  > Works : replace widgetStyle in group KDE and selects the application style 
in systemsettings; Does not edit widgetStyle in group General
  
  
  Thanks for the confirmation.
  
  > +1 on fixing whatever lowercased the value in the first place. Comment by 
@bport
  
  Fixed by D27407 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  Weird, I've tested again, and works like expected on my machine.
  
  Is it the `widgetStyle` entry from `KDE` group ?
  
  I have also an entry named `widgetStyle` in group `General` but we are not 
interested in that one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  This fix the issue for Breeze theme, but according to bug description 
(https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also 
have `oxygen` instead of `Oxygen`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  In D27482#613699 , @ngraham wrote:
  
  > How do I trigger this to get run? Restarting plasmashell or opening the 
Style KCM didn't seem to do it.
  
  
  To run the update script, just apply the patch and rebuild plasma-desktop.
  
  To confirm it has run in .config/kconf_updaterc at the end you will see
  
[style_widgetstyle_default_breeze.upd]
done=StyleWidgetStyleDefaultBreeze,StyleRemoveGeneralWidgetStyle
  
  And in .config/kdeglobals should have updated `widgetStyle` entry in group 
`KDE`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Cyril Rossi]

crossi updated this revision to Diff 75933.
crossi added a comment.


  restore blank line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27483?vs=75932=75933

REVISION DETAIL
  https://phabricator.kde.org/D27483

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, ervin, bport, meven, davidedmundson, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG 397595

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27483

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D27407  provide kconf update 
script to fix user configuration for widgetStyle when Breeze global theme is 
applied

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/style_widgetstyle_default_breeze.pl
  kcms/style/style_widgetstyle_default_breeze.upd

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c7c190488e46: Breeze widgetStyle value is Breeze 
(authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27407?vs=75699=75909

REVISION DETAIL
  https://phabricator.kde.org/D27407

AFFECTED FILES
  lookandfeel/contents/defaults

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  Will do in a separate commit. I guess it's more or less related to the KCM 
Style.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> fontsaasettings.cpp:305
> +{
> +if(dpi() == newDPI) {
> +return;

add space between `if` and `(` please

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Cyril Rossi]

crossi added a comment.


  looks ok to me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  Sounds like it will provide a complete fix, the update script will fix the 
issue without requiring the user to reset its application style, and this patch 
will ensure it won't come back.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  In D27407#611723 , @ngraham wrote:
  
  > This doesn't fix the problem for me until I actually apply a Global Theme. 
Until I do that, the current widget style remaing un-highlighted in the Style 
KCM. It does fix the issue for that use case though.
  
  
  Yes, it requires to apply Breeze style again, to set widgetStyle to `Breeze` 
in kdeglobals, instead of `breeze`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a subscriber: ngraham.
crossi added a comment.


  @ngraham my bad, didn't see your edit ^^

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: ervin, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 414885

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

AFFECTED FILES
  lookandfeel/contents/defaults

To: crossi, ervin, bport, meven, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:154
>  } else {
>  pSettings->setSetting(KEMailSettings::ClientProgram, 
> emailClientService->storageId());
>  pSettings->setSetting(KEMailSettings::ClientTerminal, 
> emailClientService->terminal() ? QStringLiteral("true") : 
> QStringLiteral("false"));

While you are here, can you had a check on this pointer. I don't understand why 
there is one below but not here.

> componentchooserfilemanager.cpp:117
>  const QString storageId = currentData().toString();
> -if (!storageId.isEmpty()) {
> -m_currentIndex = currentIndex();

I would have kept this test that is more clearer than `if (currentIndex() == 
count() - 1) {}` if you confirm it works the same.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Cyril Rossi]

crossi accepted this revision.
crossi added a comment.


  I can confirm this fix the issue here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 75360.
crossi added a comment.


  Check before assign and emit changed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=75093=75360

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, broulik, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  App-specific notifications' behavior are now managed with KConfigXT. The 
default values are set in plasmanotifyrc shipped with the 
libnotificationmanager and can be override.
  Immutability can be set at applicatioin level in plasmanotifyrc.
  Reinitialize button reset all modifications not applied. Default button does 
not reset to default applications' behavior (same as before).
  
  Require D27059  D27133 
 D27155 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi updated this revision to Diff 75090.
crossi added a comment.


  Remove specific default values, will rely on shipped settings. Fix comment at 
EOL that makes the entry not read.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=74997=75090

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi planned changes to this revision.
crossi added a comment.


  Will remove the defaults and rely on the rules file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27155

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> fonts.cpp:201
> +Q_ASSERT(dpiItem && dpiWaylandItem && antiAliasingItem);
> +if (dpiItem->isSaveNeeded() || dpiWaylandItem->isSaveNeeded() || 
> antiAliasingItem) {
> +emit aliasingChangeApplied();

antiAliasingItem->isSaveNeeded() ?

> fontssettingsaa.cpp:154
> +
> +KXftConfig::SubPixel::Type spType = 
> (KXftConfig::SubPixel::Type)m_subPixel;
> +if (m_subPixelChanged || xft.subPixelTypeHasLocalConfig()) {

`static_cast<>` instead of c-style cast

Also, you can move closer the declaration of `spType`

> fontssettingsaa.cpp:161
> +
> +KXftConfig::Hint::Style hStyle = (KXftConfig::Hint::Style)m_hinting;
> +if (m_hintingChanged || xft.hintStyleHasLocalConfig()) {

`static_cast<>` instead of c-style cast

Also, you can move closer the declaration of `hStyle`

> krdb.cpp:774
>  
> -QString hintStyle = generalCfgGroup.readEntry("XftHintStyle", 
> "hintslight");
> +KXftConfig::Hint::Style hStyle = 
> (KXftConfig::Hint::Style)settingsAA.hinting();
> +QString hintStyle = KXftConfig::toStr(hStyle);

`static_cast<>`

> krdb.cpp:788
>  
> -QString subPixel = generalCfgGroup.readEntry("XftSubPixel", "rgb");
> +KXftConfig::SubPixel::Type spType = 
> (KXftConfig::SubPixel::Type)settingsAA.subPixel();
> +QString subPixel = KXftConfig::toStr(spType);

`static_cast<>`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: ervin, broulik, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Provide a kcfg for app-specific notifications with kconfig. Require D27059 
 and D27133 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

[Cyril Rossi]

crossi accepted this revision.
crossi added a comment.
This revision is now accepted and ready to land.


  Both patch applied and tested, it works for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27073

To: broulik, #plasma, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi updated this revision to Diff 74116.
crossi added a comment.


  Use config param in ctor. Avoid global static object as per library code 
policy.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=74096=74116

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: ervin, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Unused

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26653: KCM Joystick : restore Default button to allow reset calibration.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:05d380ace439: KCM Joystick : restore Default button to 
allow reset calibration. (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26653?vs=73501=74082

REVISION DETAIL
  https://phabricator.kde.org/D26653

AFFECTED FILES
  kcms/hardware/joystick/joystick.cpp

To: crossi, #plasma, ervin, bport, meven, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26083: KCM Notifications : disable settings that are immutable

[Cyril Rossi]

crossi abandoned this revision.
crossi added a comment.


  done in D26048 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26083

To: crossi, #plasma, ervin, mart, davidedmundson, broulik
Cc: meven, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26048: KCM Notification port to ManagedConfigModule

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a1d74059c09: KCM Notification port to 
ManagedConfigModule (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26048?vs=74037=74081

REVISION DETAIL
  https://phabricator.kde.org/D26048

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow 
registration in KCM Notification (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74023=74079

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26048: KCM Notification port to ManagedConfigModule

[Cyril Rossi]

crossi updated this revision to Diff 74037.
crossi added a comment.


  Not necessary anymore

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26048?vs=74028=74037

REVISION DETAIL
  https://phabricator.kde.org/D26048

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26048: KCM Notification port to ManagedConfigModule

[Cyril Rossi]

crossi added a comment.


  In D26048#598157 , @ervin wrote:
  
  > Wondering, do we still need "settings"? I guess it's for the per-app 
settings?
  
  
  Yes, for app specific settings.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26048

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26048: KCM Notification port to ManagedConfigModule

[Cyril Rossi]

crossi updated this revision to Diff 74028.
crossi added a comment.


  Following new approach in D26047 , also 
taking into immutability is much more straightforward.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26048?vs=71677=74028

REVISION DETAIL
  https://phabricator.kde.org/D26048

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74023.
crossi added a comment.


  Remove unneeded forward declaration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74021=74023

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74021.
crossi added a comment.


  Following discussion with @ervin and @broulik, export generated KConfig 
settings, remove singleton option. The KCM will have its own KConfig settings' 
instance like other KCMs.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=73214=74021

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26683: KCM Notifications : fix applications behavior not properly updated in KCM

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e236b520a720: KCM Notifications : fix applications 
behavior not properly updated in KCM (authored by crossi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26683?vs=73596=73609#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26683?vs=73596=73609

REVISION DETAIL
  https://phabricator.kde.org/D26683

AFFECTED FILES
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26683: KCM Notifications : fix applications behavior not properly updated in KCM

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26683

AFFECTED FILES
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26653: KCM Joystick : restore Default button to allow reset calibration.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Since there is no configuration saved, all button are hidden thanks to D26519 
, restore Default button which was used to 
reset calibration.
  Remove emit changed(true) as there is nothing to save.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26653

AFFECTED FILES
  kcms/hardware/joystick/joystick.cpp

To: crossi, #plasma, ervin, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi updated this revision to Diff 73216.
crossi added a comment.


  space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=73215=73216

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi updated this revision to Diff 73215.
crossi added a comment.


  Add API documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=71783=73215

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 73214.
crossi added a comment.


  Add API documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=71676=73214

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor 
that was lost during KConfig XT port (authored by crossi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25843?vs=71183=72868#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25843?vs=71183=72868

REVISION DETAIL
  https://phabricator.kde.org/D25843

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

[Cyril Rossi]

crossi added a comment.


  some nitpicks, otherwise looks good.

INLINE COMMENTS

> componentchooser.h:42
>   virtual void defaults()=0;
> +virtual bool isDefaults() {
> +return false;

Can you make it const please.

> componentchooserbrowser.cpp:110
>  
> -const auto  = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"),
> - 
> QStringLiteral("'WebBrowser' in Categories"));
> +const auto contraints = QStringLiteral("'WebBrowser' in Categories and"
> +  " ('x-scheme-handler/http' in 
> ServiceTypes or 'x-scheme-handler/https' in ServiceTypes)");

Did you mean con**s**traints ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26100

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> broulik wrote in settings.h:343
> Not a fan of this becoming public API

Maybe not the best approach.

Any suggestion to access the KCoreConfigSkeleton encapsulated to register them 
in the KCM's ConfigModule ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, 
broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Allow the KCM Notifications to query the immutable status of each settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26083: KCM Notifications : disable settings that are immutable

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, mart, davidedmundson, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Need D26082  to work.

TEST PLAN
  Settings thart set as Immutable are disabled in the KCM screen

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26083

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, mart, davidedmundson, broulik
Cc: meven, bport, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  In D26039#579546 , @davidre wrote:
  
  > - Only move to the next theme if the current selected one is marked for 
deletion
  >
  >   FYI I could spot this same bug in the colors kcm. Will fix after this
  
  
  Looks good to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  In D26039#579253 , @davidre wrote:
  
  > - Reinstate isSaveNeeded
  > - Fix initial index and pendingDeletion
  
  
  I can confirm these issue are fixed.
  
  Still one concern, when setting an item for pending deletion, it moves the 
current index to the next item after the one marked for deletion. See the 
attachement below.
  
  Current style is Breeze Dark, I want to delete Nordic style.
  F7823665: D26039_before_delete.png 
  
  Once marked for deletion, Oxygen style is now selected
  F7823668: D26039_pending_delete.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  Some concern here as I tested the patch. The filter is working but the 
implementation breaks some functionality.
  
  - At initialization, the current theme is not selected in the grid view.
  - When settings a theme for deletion, it does not activate the apply button 
and the theme is no longer greyed out in the grid view.

INLINE COMMENTS

> kcm.cpp:72
> +
> +connect(m_model, ::pendingDeletionsChanged, this, [this] {
> +setNeedsSave(true);

Should connect to KCMDesktopTheme::settingsChanged slot to request 
ManagedConfigModule to reassess isSaveNeeded().

> kcm.cpp:313
>  
> -bool KCMDesktopTheme::isSaveNeeded() const
> -{

Why removing this ?

It is necessary for ManagedConfigModule to enable the apply button when items 
are marked for deletion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:55
> Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff 
> Marco fixed a while back?

Yes it should.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> kcmcursortheme.cpp:367
>  {
>  m_settings->save();
> +setPreferredSize(m_settings->cursorSize());

Now you should simply call ManagedConfigModule::save(); instead

> kcmcursortheme.cpp:384
>  {
>  m_settings->load();
> +setPreferredSize(m_settings->cursorSize());

ManagedConfigModule::load();

> kcmcursortheme.cpp:403
>  {
>  m_settings->setDefaults();
>  m_preferredSize = m_settings->cursorSize();

ManagedConfigModule::defaults();

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> iconsmodel.cpp:29
>  #include 
> +#include 
>  

include not used

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26048: KCM Notification port to ManagedConfigModule

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Require D26046  and D26047 
 At least, the properties of Notification 
tab in the KCM is handled properly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26048

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  For KCM Notification, allow to register the generated settings to the 
ManagedConfigModule machinery

TEST PLAN
  refactor, no change

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25792: Add notifiers to workspace options kcfg

[Cyril Rossi]

crossi added a comment.


  Thanks  @davidedmundson for spotting this regression.
  
  Actually,  only AnimationDurationFactor should notify.
  
  From D25586 
  See kcms/workspaceoptions/workspaceoptions.cpp line 221.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25792

To: davidedmundson, ervin
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D25792  and D25586 
 only AnimationDurationFactor notifies

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25843

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25523: KCM LookAndFeel : take into account immutable property

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:277bb04e7455: KCM LookAndFeel : take into account 
immutable property (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25523?vs=70295=70557

REVISION DETAIL
  https://phabricator.kde.org/D25523

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25525: KCM Style : take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable 
properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25525?vs=70351=70559

REVISION DETAIL
  https://phabricator.kde.org/D25525

AFFECTED FILES
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. 
Take into account immutable properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25586?vs=70482=70561

REVISION DETAIL
  https://phabricator.kde.org/D25586

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg
  kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfgc

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25524: KCM KSplash : take into account immutable property

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dd9a6da45f9e: KCM KSplash : take into account immutable 
property (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25524?vs=70296=70558

REVISION DETAIL
  https://phabricator.kde.org/D25524

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25526: KCM launch feedback : take into account immutable properties

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account 
immutable properties (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25526?vs=70304=70560

REVISION DETAIL
  https://phabricator.kde.org/D25526

AFFECTED FILES
  kcms/launch/package/contents/ui/main.qml

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart