Re: Synchronized release schedule for Plasma

[Ilya Bizyaev]

Hello,



I would like to clarify that Promo has not reached any consensus on whether 
this would be a good idea for us. With my local promo hat on, I do not think 
Plasma announcements should be any larger than they are now, as that puts an 
extra load on translators.



Best regards,

Ilya





 Дата: Чт, 07 янв 2021 14:28:50 +0300 niccolo  
написал(а) 


Hi,

sorry to bring this up again, but I would be in favor of a switching to 2 
releases every year. I'd like to add some reasons to do that on the promotional 
side:

1) In Promo, we are quite stepping up our game in the quality of announcements, 
to both the website and the release video. We are already a bit stretched out 
with time, and having more of that to prepare each release would benefit us, 
especially if we intend - and I think we do - to improve our work even further.

2)
 We have measured that doing less announcements every year usually gives
 those more engagement; we'd expect a good rise of that if we switch 
from 3 to 2 yearly.

3) Finally, we also expect higher engagement if we have more big features to 
promote. In all the releases I've worked on, I always felt - yes, this is 
subjective - that the 
changes were not quite enough to make the user go "wow" (we are 
generally talking about 2/4 big features each release). Bringing that up by 
~50% would help a lot.

4)
 It is much easier to explain to the users that they are going to get 
the new features soon in an announcement, if major distributions such as
 Ubuntu and Kubuntu have the new release ready soon, rather than having to wait 
months to actually get them.

I
 would also suggest switching to 6 months from a developer point of 
view, but here I'd prefer to only argue the benefit in the promotional 
side, adding up to the advantage of synced release frequency with 
distributions. It doesn't make much sense to be annoyed 
that your changes do not reach the users in time in a 6 months release cycle, 
when you currently have to wait about the same amount of time, 
changing every time, before that version gets picked up by major 
distributions with most users, as said before.

Thanks,

Niccolò



p.s.: my mail could be arriving with a big delay and duplicated; if so, I'm 
sorry, I did some confusion with my different email addresses.



>From "Plasma-devel" mailto:plasma-devel-boun...@kde.org

To "plasma-devel" mailto:plasma-devel@kde.org

Cc mailto:kde-de...@kde.org

Date Tue, 1 Dec 2020 16:01:29 +

Subject Re: Synchronized release schedule for Plasma


We discussed this in the Plasma meeting on Monday and I'm afraid there's little 
appetite in moving to a 6 monthly release or a 3 monthly release.  We did used 
to have a 3 monthly schedule but that is too tight given the length of beta and 
freezes we want to have now.  But also 6 monthly feels too long, for distros 
that miss the release that become a long time that we have users on an older 
release.  



Having said that if there's occasions where we can shift a release a bit to 
help distros we're happy to do that.



Jonathan

Re: Plasma and a bachelor thesis

[Ilya Bizyaev]

Hello Christoph, David!



Thank you for your input!



I have read through the shared materials, browsed Bugzilla reports, dug up and 
read the 
https://blogs.kde.org/2018/08/02/engineering-plasma-extensions-and-stability-—-present-and-future
 by Eike, and watched David's 
https://conf.kde.org/en/Akademy2018/public/events/66.

I like the project idea that David suggested, and I would like to work on it.



 Date: Thu, 22 Oct 2020 17:31:32 +0400 David Edmundson 
 wrote 

> 2 years ago I started an ambitious project

I'll only have half a year or so, but David also does a ton of other work all 
around Plasma, so I hope to be able to complete the project in time 



> CompSci professors always look more for research  than actual coding

That's fair. Even though the format would declare it an engineering thesis and 
shift the focus more to the code, I would still need to show research skills, 
explain the novelty of this work (maybe by using a more general topic name) and 
write plenty of text. Do you think the topic allows for that?



If so, I will ask the university representative for approval of this project as 
an engineering development thesis topic. For that, I will need a formal 
"consultant" with a master's degree in Computer Science who can reason about 
the topic's relevance, track my progress, and sign the papers. Would anyone be 
up for the role?



Best regards,

Ilya

Re: Plasma and a bachelor thesis

[Ilya Bizyaev]

Hello Aleix, thank you for your reply!



> Have you thought about what you would like to do? Would you have some

> ideas about something you would like to see developed?



That's the hardest part for me, and what I was hoping to get some input on :)



Most of the projects I can think of involve adding features that are already

available in other open-source projects, like GNOME, but those are unlikely

to be approved by the university. Then I think of some lower-level components,

like file indexers, crash handlers, or window managers, where there's maybe a

possibility to do something more `scientific`, but I don't have any special 
context

to reason about what needs improvement there.



> I also did my master thesis on KDE software and I think it worked well

I have now found it and enjoyed reading it :D



Best regards,

Ilya





 Дата: Вт, 20 окт 2020 16:34:37 +0400 Aleix Pol  
написал(а) 



On Fri, Oct 16, 2020 at 3:26 PM Ilya Bizyaev <mailto:bizy...@zoho.com> wrote: 
> 
> Hello! 
> 
> I'm currently in my last year of bachelor studies, and I'm now looking for a 
> topic for my bachelor thesis. I've had a wild idea of doing a KDE-related 
> engineering project since it sounds fun, would give me a good occasion to 
> help advance open source software that I use and love, and appears to be an 
> acceptable way of doing the thesis from my university's side. 
> 
> Since it would have to be a big project, "scratching my own itch" with 
> bugfixes won't work. It would also require a sensible degree of novelty, so 
> doing something-that-GNOME-has-but-in-Qt is also not an option. Finally, for 
> a successful project I would need to prove its relevance, so that would have 
> to be something actually useful and releasable as part of our products. 
> 
> That's why I decided to write an email to this mailing list and ask if 
> someone with more insight into Plasma's development direction has some ideas 
> for such a project. 
> 
> As for me, you may have seen me around KDE for a while :) I study applied 
> mathematics and computer science at ITMO University in St Petersburg, so have 
> a background in mathematics, algorithms and data structures, and other 
> relevant subjects. I primarily code in C++ and have some insight into Qt/KDE 
> software, and I've worked on Chrome OS in the past. There are some topics 
> suggested by the university (mostly around machine learning), and there will 
> likely be some more from its partner companies, but I am curious if I can 
> also complete a well-defined and meaningful project for KDE. 
> 
> Best regards, 
> Ilya Bizyaev <mailto:m...@ilyabiz.com> 
> 
 
Hi Ilya, 
Have you thought about what you would like to do? Would you have some 
ideas about something you would like to see developed? 
 
I also did my master thesis on KDE software and I think it worked 
well, I'd love to help you do it too. 
 
Aleix

Plasma and a bachelor thesis

[Ilya Bizyaev]

Hello!



I'm currently in my last year of bachelor studies, and I'm now looking for a 
topic for my bachelor thesis. I've had a wild idea of doing a KDE-related 
engineering project since it sounds fun, would give me a good occasion to help 
advance open source software that I use and love, and appears to be an 
acceptable way of doing the thesis from my university's side.



Since it would have to be a big project, "scratching my own itch" with bugfixes 
won't work. It would also require a sensible degree of novelty, so doing 
something-that-GNOME-has-but-in-Qt is also not an option. Finally, for a 
successful project I would need to prove its relevance, so that would have to 
be something actually useful and releasable as part of our products.



That's why I decided to write an email to this mailing list and ask if someone 
with more insight into Plasma's development direction has some ideas for such a 
project.



As for me, you may have seen me around KDE for a while :) I study applied 
mathematics and computer science at ITMO University in St Petersburg, so have a 
background in mathematics, algorithms and data structures, and other relevant 
subjects. I primarily code in C++ and have some insight into Qt/KDE software, 
and I've worked on Chrome OS in the past. There are some topics suggested by 
the university (mostly around machine learning), and there will likely be some 
more from its partner companies, but I am curious if I can also complete a 
well-defined and meaningful project for KDE.



Best regards,

Ilya Bizyaev 

D29688: Ignore mount paths that start with '/snap/'

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Maybe also /var/lib/docker?

REPOSITORY
  R106 KSysguard

BRANCH
  ignore_snap_partitions

REVISION DETAIL
  https://phabricator.kde.org/D29688

To: ahiemstra, #plasma, davidedmundson
Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  On the screenshots, the notifications block tab bars and toolbars in 3 apps :)
  Are you sure it's more convenient?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack
Cc: IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27669: [kstyle] Tools area

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  For color schemes that have contrasting titlebar and content colors, this 
patch makes application headers look giant...
  F8168755: photo_2020-03-10_15-09-54.jpg 
  It does look good with the proposed default color palette, but it makes many 
others, including current Breeze, look like an ugly CSD parody :/

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Well, if dedoimedo likes it this way, then it's probably the right thing to 
do ;)
  
  Since no one else complains about this change, I'll assume I just was lucky 
to have proper scaling on my machine without "magic number" spacings.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  It's hard to measure this in pixels, but on the screenshot, it's a 10% 
increase in size.
  I use default font settings btw, with a global scaling factor of 1.25.
  
  I'm not strongly against this, but I don't really see a point in this either. 
In, like, 4 years of Plasma on my machines, I haven't missed a systray item a 
single time; probably because they're quite big already, compared to other 
elements like checkboxes and dropdown list arrows.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620191 , @ngraham wrote:
  
  > It is (already) font-dependent, yes. A higher font size will result in 
larger spacing.
  >
  > IMO this is not super sensible, but, there is it. :p
  
  
  Ok, so I guess for the group of users who currently have the right spacing 
it's going to become excessive then :/

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620050 , 
@The-Feren-OS-Dev wrote:
  
  > This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.
  
  
  I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  Is it maybe DPI or font dependent, causing the spacing to be smaller in your 
local setup?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Repeating my comment on the previous diff for this change: on my machine, the 
current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it 
mean that after this change, it's going to be even larger?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27380#618531 , @ngraham wrote:
  
  > The problem being solved here is that starting with 5.18, style names were 
being localized, which GTK doesn't understand, causing it to fall back to the 
default font. This patch fixes that.
  
  
  I see :)
  I just thought maybe the pre-existing solution from the deleted KCM could be 
reused since it seemed to work well.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27380#618526 , @ngraham wrote:
  
  > Prior to 5.18, you had to set the GTK font separately; now it's auto-synced.
  
  
  Right, so that's the difference in font style names between Qt and GTK that 
caused the problem?
  
  > Were you able to use an italic/bold/etc GTK font in 5.17 or earlier? I must 
admit I never tried, so if not being able to now is a regression, that's why I 
never noticed. :(
  
  Never tried, but Regular worked :)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I am missing context on this bug, but I wonder why there were no issues with 
font configuration prior to 5.18
  
  Was there a different workaround then?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  
  Does this depend on DPI/panel size maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I don't understand the problem in-depth, but isn't it possible to write 
non-localized style name instead?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari
Cc: IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  What about the "Get New Plugins" button in the same dialog? It still uses the 
old style.
  Probably unrelated, but for me, both of these buttons fail to actually load 
anything, stuck connecting forever. I would blame all of my internet 
connections that I tried it with, but it does not happen in System Settings, so 
maybe there's some bug here.
  
  And also, looking at @victorr's screenshot, I see that the "Close" button has 
no label on it. I got same problem here as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26530: ScrollView: Do not overlay scrollbars over contents

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Visually, this looks like a step back to me... Do you also envision Konsole 
using opaque overlay scrollbars again?
  The current scrollbar appearance is quite common on desktop (Telegram and 
GNOME apps come to mind), so it's not odd/out-of-place by any means.
  
  > it is inconsistent with all the other views we use
  
  Doesn't mean by default that the most common pattern is better... especially 
if it comes across as "old fashioned"
  
  > it just causes more problems than it solves
  
  Haven't heard of related issues before, could you give an example?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency
Cc: IlyaBizyaev, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Somehow I also feel Baloo is not a name to be surfaced...
  
  1. It's not really a brand, and if it was, it would have a terrible 
reputation due to all the user frustration accumulated.
  2. Those users on social media who know the name "Baloo" follow KDE 
development or have faced specific Baloo issues that made them learn the name. 
I agree with @davidedmundson in that the wider audience might be more confused 
by the change rather than enlightened.
  3. FWIW in Russian localization, the name "KRunner" was replaced everywhere 
with "Search and launch field", since "KRunner" does not mean anything to 
people who do not speak English.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: IlyaBizyaev, feverfew, tcanabrava, bruns, davidedmundson, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25543: Split Style & Helper into files by widget type

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Great, navigating in Breeze source will be a lot simpler now 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24768: Fix incorrect Credits model for Kirigami.AboutPage

[Ilya Bizyaev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9e3407ec40ab: Fix incorrect Credits model for 
Kirigami.AboutPage (authored by IlyaBizyaev).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24768?vs=68269=68418

REVISION DETAIL
  https://phabricator.kde.org/D24768

AFFECTED FILES
  src/controls/AboutPage.qml

To: IlyaBizyaev, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24768: Fix incorrect Credits model for Kirigami.AboutPage

[Ilya Bizyaev]

IlyaBizyaev created this revision.
IlyaBizyaev added a reviewer: Kirigami.
IlyaBizyaev added a project: Kirigami.
Herald added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REVISION SUMMARY
  Credits section currently displays the list of translators.
  
  This fixes a copy-paste mistake.

TEST PLAN
  Opened Discover's About page with and without the change; after the fix, the 
Credits section disappeared.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24768

AFFECTED FILES
  src/controls/AboutPage.qml

To: IlyaBizyaev, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Could you show how this change affects the default color scheme?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24205

To: cblack, #breeze
Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15696: Fix qmake build

[Ilya Bizyaev]

IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Closed by 8691651c1f0d09430416ba5fe2130647554b06a9 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I'm not sure... You can try building a Kirigami application that uses 
Kirigami as a qmake submodule, like Kaidan 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

[Ilya Bizyaev]

IlyaBizyaev updated this revision to Diff 42145.
IlyaBizyaev edited the summary of this revision.
IlyaBizyaev added a comment.


  Indeed, thanks @alexeymin!

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15696?vs=42142=42145

REVISION DETAIL
  https://phabricator.kde.org/D15696

AFFECTED FILES
  kirigami.pri
  kirigami.pro

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

[Ilya Bizyaev]

IlyaBizyaev created this revision.
IlyaBizyaev added a reviewer: mart.
IlyaBizyaev added a project: Kirigami.
Herald added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REVISION SUMMARY
  Add scenepositionattached.* to the qmake project file

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

AFFECTED FILES
  kirigami.pri

To: IlyaBizyaev, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D10429: Disable the title bar separator by default

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I think this line's goal is not really to separate the title bar from window 
content, but instead to make the transition smoother and emphasize style 
consistency.
  
  Take a look at these 2 screenshots, for example.
  F6267692: Screenshot_20180916_124803.png 
 F6267691: Screenshot_20180916_124749.png 

  
  The one without the line looks very rectangular and sharp for eyes, as if 
someone has cut window decorations aggressively.
  The other, in my opinion, has a more natural, friendly transition and shares 
color with application controls.
  
  I don't have user stats, though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham, abetts, romangg
Cc: IlyaBizyaev, romangg, mart, abetts, rizzitello, mmustac, broulik, 
anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D10429: Disable the title bar separator by default

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I'll be that one person here who likes the separator and notices it easily on 
the Breeze theme.
  
  I have no objections to changing the default, but "just removing it entirely" 
is not an option.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham, abetts, romangg
Cc: IlyaBizyaev, romangg, mart, abetts, rizzitello, mmustac, broulik, 
anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13663: Refactor the Global ToolBar concept

[Ilya Bizyaev]

IlyaBizyaev added inline comments.

INLINE COMMENTS

> ToolBarApplicationHeader.qml:42
>  
> +Component.onCopleted: print("Warning: ToolbarApplicationHeader is 
> deprecated, remove and use the automatic internal toolbar instead.")
>  pageDelegate: Item {

A typo :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein

D3588: Remove inexistent file references from kirigami.qrc

[Ilya Bizyaev]

IlyaBizyaev abandoned this revision.
IlyaBizyaev added a comment.


  Outdated, was superceded by D3591 .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3588

To: IlyaBizyaev, #kirigami, mart
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Merged by 389f4c29acc3 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev added a reviewer: mart.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev retitled this revision from "Fix qmake warning for " to "Fix qmake 
warning for Kirigami".
IlyaBizyaev edited the summary of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for

[Ilya Bizyaev]

IlyaBizyaev created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

AFFECTED FILES
  kirigami.qrc

To: IlyaBizyaev
Cc: plasma-devel, apol, davidedmundson, mart, hein

D9349: Fix qmake build of Kirigami

[Ilya Bizyaev]

IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Closed by 
https://phabricator.kde.org/R169:b0bf6b85ccd60aecb57c2cd5c54a912fc62d4113.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9349

To: IlyaBizyaev, #kirigami, davidedmundson
Cc: davidedmundson, mart, plasma-devel, apol, hein

D9349: Fix qmake build of Kirigami

[Ilya Bizyaev]

IlyaBizyaev updated this revision to Diff 24073.
IlyaBizyaev added a comment.


  Updated the revision to reflect the last commit in Kirigami

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9349?vs=23972=24073

REVISION DETAIL
  https://phabricator.kde.org/D9349

AFFECTED FILES
  kirigami.pri

To: IlyaBizyaev, #kirigami, davidedmundson
Cc: davidedmundson, mart, plasma-devel, apol, hein

D9349: Fix qmake build of Kirigami

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  No, I don't

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9349

To: IlyaBizyaev, #kirigami, davidedmundson
Cc: davidedmundson, mart, plasma-devel, apol, hein

D9349: Fix qmake build of Kirigami

[Ilya Bizyaev]

IlyaBizyaev updated this revision to Diff 23972.
IlyaBizyaev added a comment.


  Turns out some files have been removed from Kirigami while I've been sending 
a patch xD

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9349?vs=23965=23972

REVISION DETAIL
  https://phabricator.kde.org/D9349

AFFECTED FILES
  kirigami.pri
  kirigami.qrc

To: IlyaBizyaev, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

D9349: Fix qmake build of Kirigami

[Ilya Bizyaev]

IlyaBizyaev created this revision.
IlyaBizyaev added a reviewer: Kirigami.
IlyaBizyaev added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Build with QMake failed as certain files and include paths were missing from 
.pri and .qrc. This diff fixes it.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9349

AFFECTED FILES
  kirigami.pri
  kirigami.qrc

To: IlyaBizyaev, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

[Differential] [Commented On] D3588: Remove inexistent file references from kirigami.qrc

[IlyaBizyaev (Ilya Bizyaev)]

IlyaBizyaev added a comment.


  I don't know. I just removed references to inexistent files to make 
compilation possible.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3588

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: IlyaBizyaev, mart, #kirigami
Cc: bearsh, plasma-devel, apol

[Differential] [Request, 4 lines] D3588: Remove inexistent file references from kirigami.qrc

[IlyaBizyaev (Ilya Bizyaev)]

IlyaBizyaev created this revision.
IlyaBizyaev set the repository for this revision to R169 Kirigami.
IlyaBizyaev added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Some files that are referenced by Kirigami2's kirigami.qrc do not exist. This 
commit fixes it.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3588

AFFECTED FILES
  kirigami.qrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: IlyaBizyaev
Cc: plasma-devel, apol