[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. Thank you @graesslin and @bshah REPOSITORY rKWAYLAND KWayland BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma, bshah, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31870, @bshah wrote: > Looks good. Output of arc land fake-input-touch: TARGET Landing onto "master", the default target under git. REMOTE Using remote "origin", the default remote under git. FETCH Fetching origin/master... This commit will be landed: - 2d5d5c2 Add support for touch events in fakeinput protocol and interface. Revision 'https://phabricator.kde.org/D1672: Add support for touch events in fakeinput protocol and interface.' has not been accepted. Continue anyway? [y/N] Can i still submit it? REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
graesslin added a comment. > On server side FakeInputInterface, FakeInputDevice or client side in FakeInput? Needs to be done on server side. The thought is that the Client might send incorrect data (the interface is the protocol, not your client code), so the server needs to do input validation. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31141, @graesslin wrote: > In https://phabricator.kde.org/D1672#31140, @bdhruve wrote: > > > In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > > > > > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. > > > > > > Martin, do you prefer this change to be done in this review only or in separate review. > > > I think it would be better to directly integrate it here. Hello, I've understood the problem and how to fix it in theory, but i am not sure on implementation details? For instance, I am not sure on where to track ids? On server side FakeInputInterface, FakeInputDevice or client side in FakeInput? So, can you please help me on this? REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
graesslin added a comment. In https://phabricator.kde.org/D1672#31140, @bdhruve wrote: > In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > > > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. > > > Martin, do you prefer this change to be done in this review only or in separate review. I think it would be better to directly integrate it here. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. Martin, do you prefer this change to be done in this review only or in separate review. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
graesslin added a comment. In https://phabricator.kde.org/D1672#31094, @bshah wrote: > In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > > > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. > > > IMO client ideally will not send bogus event. And in any case if it does, compositor itself should ignore bogus events because it is the one which is processing in end.. a client could also use this to attack (crash) the Compositor by sending bogus events. That's security relevant from my point of view. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bshah added a comment. In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. IMO client ideally will not send bogus event. And in any case if it does, compositor itself should ignore bogus events because it is the one which is processing in end.. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
graesslin added a comment.
I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for
id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in FakeInputInterface. But it must be done
somewhere - either in the library or by the user of the library.
INLINE COMMENTS
> fakeinput_interface.cpp:196
> +FakeInputDevice *d = device(resource);
> +if (!d || !d->isAuthenticated()) {
> +return;
The isAuthenticated check is not verified in the autotest. That's the same with
the other new methods.
REPOSITORY
rKWAYLAND KWayland
REVISION DETAIL
https://phabricator.kde.org/D1672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
