D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  normal in Latte
  F5713010: εικόνα.png 
  
  needsattention in Latte
  F5713020: εικόνα.png 

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos closed this revision.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  merged with: 
https://commits.kde.org/plasma-active-window-control/d07bd170d39adab35b7861ab6c480286a4d0253e

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206606 , @martinkostolny 
wrote:
  
  > thanks!
  
  
  fatal: remote error: service not enabled: /plasma-active-window-control
  
  unfortunately I can commit, I get:
  
fatal: remote error: service not enabled: /plasma-active-window-control
  
  @martinkostolny feel to commit it...

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.


  thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206458 , @broulik wrote:
  
  > Oh, sorry, I assumed from the name of the files it was plasma-workspace :) 
lgtm!
  
  
  :) if this is accepted, then I will try to send a fix for plasma menu also 
afterwards...

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Kai Uwe Broulik]

broulik added a comment.


  Oh, sorry, I assumed from the name of the files it was plasma-workspace :) 
lgtm!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206437 , @martinkostolny 
wrote:
  
  > Thanks for fixing my code! :)
  
  
  can you please confirm also the update that follows @broulik suggestion? I 
confirmed with Latte that everything works flawlessly now.
  
  @broulik I created the diff without arcanist but I can merge the code with 
git, but this issue wont be closed automatically I think, is there any other 
way, e.g to referece in the commit text somehow the phabricator review?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos updated this revision to Diff 27186.
mvourlakos added a comment.


  followed @broulik suggestions and added also an improvement to not update 
menu index all the time when changing from menu to menu

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10516?vs=27174=27186

REVISION DETAIL
  https://phabricator.kde.org/D10516

AFFECTED FILES
  lib/appmenuapplet.cpp
  package/contents/ui/main.qml

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Thanks for fixing my code! :)
  
  I'm sure I can also provide a flag for menu availability (the code for 
appmenu is copied for now anyway). But I think in AWC it does not make sense to 
set status to active when menu is available because it has other use then 
showing menu. I can be wrong of course.
  
  Anyway I definitely agree with your proposed patch.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206373 , @broulik wrote:
  
  > Thanks for looking into this!
  >
  > I could prefer a QML binding that also takes into account wheter there is a 
menu at all, something like
  >
  >   Plasmoid.status: {
  >   if (currentIndex > -1) {
  >   return PlasmaCore.Types.NeedsAttentionStatus;
  >   } else if (menuAvailable) {
  >   return PlasmaCore.Types.ActiveStatus;
  >   } else {
  >   return PlasmaCore.Types.PassiveStatus;
  >   }
  >   }
  >
  >
  > also BUG: 390271
  
  
  @broulik no prob :) only problem is that this commit is for Active Window 
Control, not for the plasma menu applet. The AWC doesnt provide a 
**menuavailable** flag. Of course I can create a second commit for plasma and 
update this one with your proposal...
  
  would that be ok?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for looking into this!
  
  I could prefer a QML binding that also takes into account wheter there is a 
menu at all, something like
  
Plasmoid.status: {
if (currentIndex > -1) {
return PlasmaCore.Types.NeedsAttentionStatus;
} else if (menuAvailable) {
return PlasmaCore.Types.ActiveStatus;
} else {
return PlasmaCore.Types.PassiveStatus;
}
}
  
  also BUG: 390271

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos edited the test plan for this revision.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  Following the discussion at: 
https://github.com/psifidotos/Latte-Dock/issues/862
  
  when AWC shows menus in a Latte panel it is able to trigger the solid 
background and panel shadows for plasma theme consistency... Latte achieves 
this for all apllets that change their status to NeedsAttention... By addind 
this code AWC now provides nice solid background and shadows will Latte without 
noticing any other implications.

TEST PLAN
  Apply the code and observe the AWC to not breake its behavior

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

AFFECTED FILES
  lib/appmenuapplet.cpp

To: mvourlakos, martinkostolny
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart