D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos abandoned this revision.
mvourlakos added a comment.


  can be closed because https://phabricator.kde.org/D11651 was accepted...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  In D11220#232803 , @hein wrote:
  
  > If it's the only way to end this debate, could you instead implement the 
patch that uses the icon size setting as switch threshold?
  
  
  I created the following: https://phabricator.kde.org/D11651

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Eike Hein]

hein added a comment.


  I really think this is ugly and don't want it :/
  
  If it's the only way to end this debate, could you instead implement the 
patch that uses the icon size setting as switch threshold?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Marco Martin]

mart added a comment.


  i don't see much use case for it, but...
  Eike, i think the final word would be up to you, what do you think about it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  
  
  In D11220#223836 , @hein wrote:
  
  > Hmm I don't like the approach about putting this into individual applets - 
I think the containment should force constraints on the applets instead, and 
the applets need to follow the constraints. That's more Plasma-idiomatic to me. 
Marco?
  
  
  what containment constraint can block an applet to go to FullRepresentation?
  how do you imagine this to work?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  settings window looks like:
  
  F5752898: εικόνα.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos updated this revision to Diff 29439.
mvourlakos added a comment.


  - update semantics based on feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11220?vs=29195=29439

BRANCH
  alwaysShowAsIcon

REVISION DETAIL
  https://phabricator.kde.org/D11220

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  In D11220#224622 , @mart wrote:
  
  > Shouldn't the quick launch applet cover this use case?
  
  
  The quick launch applet can show folder contents or activities-pinned 
documents?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Marco Martin]

mart added a comment.


  Shouldn't the quick launch applet cover this use case?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  Please read also: https://bugs.kde.org/show_bug.cgi?id=379888 why I proposed 
this.
  
  The issue appeared from Latte Dock. When the user uses the parabolic effect 
and the FolderView is animated then somewhere in the middle of the animation it 
changes from icon to FullRepresentation and vice versa. In the bug report I 
proposed that this applet should respect at least the user-set panel icon-size 
in order to not change to FullRepresentation for values lower than the user set 
one.
  
  So if the user has set Panel Icon Size:256px then the applet shouldnt change 
to FullRepresentation for values lower than that.
  But @hein proposed that this isnt valid for the specific applet because some 
users might want to change to FullRepresentation earlier e.g. at sidebars.
  
  So after that discussion I implemented a user choice for this...
  
  > I think the containment should force constraints on the applets instead, 
and the applets need to follow the constraints.
  
  I dont have any problem to update the code if you can propose me an approach 
that fixes the Latte issue and preserves the plasma design.
  
  >   A config option for this seems to duplicate the concept of constraints 
(which are indeed determined by the containment.)
  
  to which constraints are you refering?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Sebastian Kügler]

sebas added a comment.


  In principle yes, but the applet should of course react suitably to these 
constraints. A config option for this seems to duplicate the concept of 
constraints (which are indeed determined by the containment.)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ConfigIcons.qml:155
> +checked: cfg_forceIconInPanel
> +text: i18n("Force icon presentation in panel")
> +}

"Always show as icon" or something like that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11220: option to force FolderView icon-only presentation

[Eike Hein]

hein added a reviewer: mart.
hein added a comment.


  Hmm I don't like the approach about putting this into individual applets - I 
think the containment should force constraints on the applets instead, and the 
applets need to follow the constraints. That's more Plasma-idiomatic to me. 
Marco?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --when a FolderView applet is located in panel, there
  is the chance that the user wants to always remain
  in icon-only presentation and never switch to
  FullRepresentation
  --update also row numbers in Icon Config Dialog in order
  to be consistent to the new added option
  
  BUG: 379888

TEST PLAN
  disable option and check that everything works as accepted,
  enable option in the panel and resize the panel to check
  that FolderView icon appearance remains at all cases

REPOSITORY
  R119 Plasma Desktop

BRANCH
  forceIconInPanel

REVISION DETAIL
  https://phabricator.kde.org/D11220

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart