D14562: Introduce Theme.smallestFont
volkov updated this revision to Diff 76554. volkov added a comment. registered for 2.2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14562?vs=38964=76554 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14562 AFFECTED FILES src/controls/plugins.qmltypes src/libkirigami/platformtheme.cpp src/libkirigami/platformtheme.h To: volkov, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein
D14562: Introduce Theme.smallestFont
mart added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: > https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions > One can import kirigami 2.2 and use smallestFont. Register it just for 2.2 and forget about revisions. They're a broken concept and they will be removed in Qt6 anyways REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein
D14562: Introduce Theme.smallestFont
volkov added a comment. Why add it to qml-base theme implementations? Aren't they obsolete? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
D14562: Introduce Theme.smallestFont
volkov added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: > https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions > One can import kirigami 2.2 and use smallestFont. https://bugreports.qt.io/browse/QTBUG-40043 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
D14562: Introduce Theme.smallestFont
volkov added inline comments. INLINE COMMENTS > mart wrote in kirigamiplugin.cpp:173 > this will break completely every import < 2.6 So, should it be registered for both versions 2.2 and 2.6? I tried to use revisions, but it looks like they don't work for properties of attached property objects: https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions One can import kirigami 2.2 and use smallestFont. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
D14562: Introduce Theme.smallestFont
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. good idea, 2 comments: - the import version of platformtheme cannot change or will break existing code - needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/ INLINE COMMENTS > kirigamiplugin.cpp:173 > > +//2.6 > +qmlRegisterUncreatableType(uri, 2, 6, "Theme", > "Cannot create objects of type Theme, use it as an attached poperty"); this will break completely every import < 2.6 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
D14562: Introduce Theme.smallestFont
volkov created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It can be useful in itself and when porting code from Plasma. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D14562 AFFECTED FILES src/controls/plugins.qmltypes src/kirigamiplugin.cpp src/libkirigami/platformtheme.cpp src/libkirigami/platformtheme.h To: volkov Cc: plasma-devel, apol, davidedmundson, mart, hein
